Re: [PATCH] hpsa: fix warning with smp_processor_id() in preemptible

* John Kacur | 2013-07-26 16:42:30 [+0200]: Signed-off-by: John Kacur jka...@redhat.com Acked-by: Stephen scame...@beardog.cce.hp.com ping. I checked the branches for-next, scsi-fixes, fixes and misc at [0] and I didn't see it. I'm going to take this for 3.10-rt but please don't lose it on its

Re: [PATCH] Try #2: Use SCSI read/write(16) with 2TB drives

On Wed, Nov 14, 2012 at 12:55:13AM -0500, Jason J. Herne wrote: --- a/drivers/scsi/sd.c +++ b/drivers/scsi/sd.c @@ -887,7 +887,7 @@ static int sd_prep_fn(struct request_queue *q, struct request *rq) SCpnt-cmnd[29] = (unsigned char) (this_count 16) 0xff;

[PATCH] scsi/aacraid: user upper/lower_address() macro to avoid right shift count = width of type warning.

shift count = width of type [enabled by default] | src_writel(dev, MUnit.IQ_H, (address 32) 0x); Signed-off-by: Sebastian Andrzej Siewior sebast...@breakpoint.cc --- drivers/scsi/aacraid/src.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/scsi

Re: [PATCH] target: Allow for target_submit_cmd() returning errors

On 07/18/2012 02:05 AM, Nicholas A. Bellinger wrote: index 02ace18..9ddf315 100644 --- a/drivers/usb/gadget/tcm_usb_gadget.c +++ b/drivers/usb/gadget/tcm_usb_gadget.c @@ -1060,7 +1060,10 @@ static void usbg_cmd_work(struct work_struct *work) tpg = cmd-fu-tpg; tv_nexus =

Re: [PREEMPT-RT] [PATCH v2] scsi/fcoe: convert to kworker

On 04/22/2016 06:39 PM, Laurence Oberman wrote: > I have fcoe for testing. > I will pull this in next week and test it. any update? > > Laurence Oberman > Principal Software Maintenance Engineer > Red Hat Global Support Services Sebastian -- To unsubscribe from this list: send the line

Re: [PREEMPT-RT] [PATCH v2] scsi/fcoe: convert to kworker

On 06/09/2016 03:15 PM, Laurence Oberman wrote: > Hello Hi, > Apologies, somehow this fell off my radar. > I will get the FCOE test bed up and get it done ASAP. Thanks > > Regards > Laurence Sebastian -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a

[PATCH 05/11] scsi/fcoe: drop the p_target lock earlier if there is no thread online

racle.com> Cc: Christoph Hellwig <h...@lst.de> Cc: fcoe-de...@open-fcoe.org Cc: linux-scsi@vger.kernel.org Signed-off-by: Sebastian Andrzej Siewior <bige...@linutronix.de> --- drivers/scsi/fcoe/fcoe.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers

[PATCH 10/11] scsi: bnx2fc: fix hotplug race in bnx2fc_process_new_cqes()

o do manually. Cc: qlogic-storage-upstr...@qlogic.com Cc: "James E.J. Bottomley" <jbottom...@odin.com> Cc: "Martin K. Petersen" <martin.peter...@oracle.com> Cc: Christoph Hellwig <h...@lst.de> Cc: linux-scsi@vger.kernel.org Signed-off-by: Sebastian Andrzej Siewi

[PATCH 08/11] scsi/fcoe: convert to smpboot thread

V. Cc: Vasu Dev <vasu@intel.com> Cc: "James E.J. Bottomley" <jbottom...@odin.com> Cc: "Martin K. Petersen" <martin.peter...@oracle.com> Cc: Christoph Hellwig <h...@lst.de> Cc: fcoe-de...@open-fcoe.org Cc: linux-scsi@vger.kernel.org Signed-off-by: Sebast

[PATCH 07/11] scsi/fcoe: drop the crc_eof page early

K. Petersen" <martin.peter...@oracle.com> Cc: Christoph Hellwig <h...@lst.de> Cc: fcoe-de...@open-fcoe.org Cc: linux-scsi@vger.kernel.org Signed-off-by: Sebastian Andrzej Siewior <bige...@linutronix.de> --- drivers/scsi/fcoe/fcoe.c | 5 ++--- 1 file changed, 2 insertions(+), 3 del

[PATCH 06/11] scsi/fcoe: use skb_queue_splice_tail() intead of manual job

racle.com> Cc: Christoph Hellwig <h...@lst.de> Cc: fcoe-de...@open-fcoe.org Cc: linux-scsi@vger.kernel.org Signed-off-by: Sebastian Andrzej Siewior <bige...@linutronix.de> --- drivers/scsi/fcoe/fcoe.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers

[PATCH 11/11] scsi: bnx2fc: convert to smpboot thread

mostly straightforward. This patch was only compile-tested due to -ENODEV. Cc: qlogic-storage-upstr...@qlogic.com Cc: "James E.J. Bottomley" <jbottom...@odin.com> Cc: "Martin K. Petersen" <martin.peter...@oracle.com> Cc: Christoph Hellwig <h...@lst.de> Cc: linux-scsi@vger

[PATCH 01/11] scsi/fcoe: lock online CPUs in fcoe_percpu_clean()

jbottom...@odin.com> Cc: "Martin K. Petersen" <martin.peter...@oracle.com> Cc: Christoph Hellwig <h...@lst.de> Cc: fcoe-de...@open-fcoe.org Cc: linux-scsi@vger.kernel.org Signed-off-by: Sebastian Andrzej Siewior <bige...@linutronix.de> --- drivers/scsi/fcoe/fcoe

[PATCH 00/11] SCSI smpboot thread conversion

This series converts fcoe, bnx2i and bnx2fc to smpboot thread instead of their own magic. The fcoe driver ended in more patches than I wanted but that way it is easier to find the individual code blocks which were used in the final patch. The overall diffstat: 8 files changed, 253

[PATCH 02/11] scsi/fcoe: remove CONFIG_SMP in fcoe_percpu_thread_destroy()

c: "Martin K. Petersen" <martin.peter...@oracle.com> Cc: Christoph Hellwig <h...@lst.de> Cc: fcoe-de...@open-fcoe.org Cc: linux-scsi@vger.kernel.org Signed-off-by: Sebastian Andrzej Siewior <bige...@linutronix.de> --- drivers/scsi/fcoe/fcoe.c | 13 - 1 file change

[PATCH 09/11] scsi: bnx2i: convert to smpboot thread

mostly straightforward. This patch was only compile-tested due to -ENODEV. Cc: qlogic-storage-upstr...@qlogic.com Cc: "James E.J. Bottomley" <jbottom...@odin.com> Cc: "Martin K. Petersen" <martin.peter...@oracle.com> Cc: Christoph Hellwig <h...@lst.de> Cc: linux-scsi@vger

[PATCH 03/11] scsi/fcoe: drop locking in fcoe_percpu_thread_destroy() if cpu == targ_cpu

: Vasu Dev <vasu@intel.com> Cc: "James E.J. Bottomley" <jbottom...@odin.com> Cc: "Martin K. Petersen" <martin.peter...@oracle.com> Cc: Christoph Hellwig <h...@lst.de> Cc: fcoe-de...@open-fcoe.org Cc: linux-scsi@vger.kernel.org Signed-off-by

[PATCH 04/11] scsi/fcoe: rename p0 to p_target in fcoe_percpu_thread_destroy()

K. Petersen" <martin.peter...@oracle.com> Cc: Christoph Hellwig <h...@lst.de> Cc: fcoe-de...@open-fcoe.org Cc: linux-scsi@vger.kernel.org Signed-off-by: Sebastian Andrzej Siewior <bige...@linutronix.de> --- drivers/scsi/fcoe/fcoe.c | 14 +++--- 1 file changed, 7 insertions(

[PATCH] MAINTAINERS: Update the email address of James E.J. Bottomley

after sending a few patches to the odin.com email address I noticed that it is no longer valid. Signed-off-by: Sebastian Andrzej Siewior <bige...@linutronix.de> --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 2a37ee

Re: [PATCH 01/11] scsi/fcoe: lock online CPUs in fcoe_percpu_clean()

On 03/11/2016 05:17 PM, Christoph Hellwig wrote: > On Fri, Mar 11, 2016 at 04:28:53PM +0100, Sebastian Andrzej Siewior wrote: >> for_each_possible_cpu() with a cpu_online() + `thread' check possibly does >> the job. But there is a tiny race: Say CPU5 is reported online but i

Re: [PATCH 01/11] scsi/fcoe: lock online CPUs in fcoe_percpu_clean()

On 03/15/2016 09:19 AM, Christoph Hellwig wrote: > On Fri, Mar 11, 2016 at 05:32:15PM +0100, Sebastian Andrzej Siewior wrote: >> alloc_workqueue() in setup and then queue_work_on(cpu, , item)? item >> should be struct work_struct but all I have is a skb. Is there an eas

[PATCH v2] scsi/fcoe: convert to kworker

.@open-fcoe.org Cc: linux-scsi@vger.kernel.org Signed-off-by: Sebastian Andrzej Siewior <bige...@linutronix.de> --- v1…v2: use kworker instead of smbthread as per hch If you want this I would the same for the two bnx drivers. drivers/scsi/bnx2fc/

Re: [PATCH 01/11] scsi/fcoe: lock online CPUs in fcoe_percpu_clean()

On 04/08/2016 03:30 PM, Sebastian Andrzej Siewior wrote: > On 03/15/2016 09:19 AM, Christoph Hellwig wrote: >> On Fri, Mar 11, 2016 at 05:32:15PM +0100, Sebastian Andrzej Siewior wrote: >>> alloc_workqueue() in setup and then queue_work_on(cpu, , item)? item >>> s

Re: [PREEMPT-RT] [PATCH v2] scsi/fcoe: convert to kworker

On 04/12/2016 05:16 PM, Sebastian Andrzej Siewior wrote: > The driver creates its own per-CPU threads which are updated based on > CPU hotplug events. It is also possible to use kworkers and remove some > of the kthread infrastrucure. > > The code checked ->thread to decide if

Re: [PATCH] scsi: bnx2i: convert to kworker

On 2016-07-04 19:40:37 [+0200], To linux-scsi@vger.kernel.org wrote: > The driver creates its own per-CPU threads which are updated based on CPU > hotplug events. It is also possible to use kworkers and remove some of the > infrastructure get the same job done while saving a few lines of code.

Re: [PATCH 1/4] scsi: bnx2fc: convert per-CPU thread to kworker

On 2016-07-05 18:08:46 [+0200], To linux-scsi@vger.kernel.org wrote: > The driver creates its own per-CPU threads which are updated based on CPU > hotplug events. It is also possible to use kworkers and remove some of the > infrastructure get the same job done while saving a few lines of code.

Re: [PATCH 1/4] scsi: bnx2fc: convert per-CPU thread to kworker

On 07/20/2016 01:04 PM, Johannes Thumshirn wrote: > Hi Sebastian, Hi Johannes, > I've tried to test your series and unfortunately I encountered the following > oops. thanks for testing. … > > I'll try to narrow it down to the specific patch, but currently I'm a bit > busy, sorry. I looked over

[PATCH] scsi: bnx2i: convert to kworker

e kworker code. This patch was only compile-tested due to -ENODEV. Cc: qlogic-storage-upstr...@qlogic.com Cc: Christoph Hellwig <h...@lst.de> Signed-off-by: Sebastian Andrzej Siewior <bige...@linutronix.de> --- drivers/scsi/bnx2i/bnx2i.h | 11 +--- drivers/scsi/bnx

[PATCH 3/4] scsi: bnx2fc: annoate unlock + release for sparse

lst.de> Signed-off-by: Sebastian Andrzej Siewior <bige...@linutronix.de> --- drivers/scsi/bnx2fc/bnx2fc_io.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/scsi/bnx2fc/bnx2fc_io.c b/drivers/scsi/bnx2fc/bnx2fc_io.c index f501095f91ac..634e1e539850 100644 --- a/drivers/scsi/bnx

[PATCH 1/4] scsi: bnx2fc: convert per-CPU thread to kworker

ning part is the removal CPU hotplug notifier since it is taken care by the kworker code. This patch was only compile-tested due to -ENODEV. Cc: qlogic-storage-upstr...@qlogic.com Cc: Christoph Hellwig <h...@lst.de> Signed-off-by: Sebastian Andrzej Siewior <bige...@linutronix.de> --- drivers

[PATCH 2/4] scsi: bnx2fc: clean up header definitions

<h...@lst.de> Signed-off-by: Sebastian Andrzej Siewior <bige...@linutronix.de> --- drivers/scsi/bnx2fc/bnx2fc.h | 5 + drivers/scsi/bnx2fc/bnx2fc_els.c | 4 ++-- drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 14 +++--- drivers/scsi/bnx2fc/bnx2fc_hwi.c | 8 +++- drivers

[PATCH 4/4 v2] scsi: bnx2fc: convert bnx2fc_l2_rcv_thread() to worker

-storage-upstr...@qlogic.com Cc: Christoph Hellwig <h...@lst.de> Cc: fcoe-de...@open-fcoe.org Signed-off-by: Sebastian Andrzej Siewior <bige...@linutronix.de> --- v1…v2: remove __set_current_state(TASK_INTERRUPTIBLE); from bnx2fc_l2_rcv_work() drivers/scsi/bnx2fc/bnx2fc

Re: [PATCH v2] scsi/fcoe: convert to kworker

On 06/10/2016 12:38 PM, Johannes Thumshirn wrote: … > > Tested in a Boot from FCoE scenario using a BCM57840. This got merged over the weekend. Thanks for that. I will try to look into the other two (bnx2i, bnx2fc) and convert them as well within this week. Sebastian -- To unsubscribe from

Re: [lkp-robot] [rcu] b332151a29: kernel_BUG_at_mm/slab.c

On 2017-01-19 09:02:16 [+0800], kernel test robot wrote: > test-description: Trinity is a linux system call fuzz tester. you don't even get to fire up trinity. With and without the patch you crash very early. > +-+++ > |

Re: [lkp-robot] [rcu] b332151a29: kernel_BUG_at_mm/slab.c

On 2017-01-20 08:32:37 [-0800], Jens Axboe wrote: > That's alright, sounds like it's not a -next regression, but rather something > that is already broken. I can reproduce a lot of breakage if I enable > CONFIG_DEBUG_TEST_DRIVER_REMOVE, in fact my system doesn't boot at all. This > is the first

Re: [lkp-robot] [rcu] b332151a29: kernel_BUG_at_mm/slab.c

On 2017-01-20 08:09:36 [-0800], Jens Axboe wrote: > Is there a full trace of this? [3.654003] scsi host0: scsi_debug: version 1.86 [20160430] [3.654003] dev_size_mb=8, opts=0x0, submit_queues=1, statistics=0 [3.660755] scsi 0:0:0:0: Direct-Access Linuxscsi_debug 0186

[PATCH 10/21] virtio scsi: Convert to hotplug state machine

ualizat...@lists.linux-foundation.org Signed-off-by: Sebastian Andrzej Siewior <bige...@linutronix.de> --- drivers/scsi/virtio_scsi.c | 76 ++ include/linux/cpuhotplug.h | 1 + 2 files changed, 50 insertions(+), 27 deletions(-) diff --git a/drivers

[REPOST PATCH 4/5] scsi: bnx2fc: annoate unlock + release for sparse

lst.de> Signed-off-by: Sebastian Andrzej Siewior <bige...@linutronix.de> --- drivers/scsi/bnx2fc/bnx2fc_io.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/scsi/bnx2fc/bnx2fc_io.c b/drivers/scsi/bnx2fc/bnx2fc_io.c index f501095f91ac..634e1e539850 100644 --- a/drivers/scsi/bnx

[REPOST PATCH 5/5] scsi: bnx2fc: convert bnx2fc_l2_rcv_thread() to worker

-storage-upstr...@qlogic.com Cc: Christoph Hellwig <h...@lst.de> Cc: fcoe-de...@open-fcoe.org Signed-off-by: Sebastian Andrzej Siewior <bige...@linutronix.de> --- drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 57 +-- include/scsi/libfcoe.h| 1 - 2 f

[REPOST PATCH 2/5] scsi: bnx2fc: convert per-CPU thread to kworker

ning part is the removal CPU hotplug notifier since it is taken care by the kworker code. This patch was only compile-tested due to -ENODEV. Cc: qlogic-storage-upstr...@qlogic.com Cc: Christoph Hellwig <h...@lst.de> Signed-off-by: Sebastian Andrzej Siewior <bige...@linutronix.de> --- drivers

[REPOST PATCH 1/5] scsi: bnx2i: convert to kworker

e kworker code. This patch was only compile-tested due to -ENODEV. Cc: qlogic-storage-upstr...@qlogic.com Cc: Christoph Hellwig <h...@lst.de> Signed-off-by: Sebastian Andrzej Siewior <bige...@linutronix.de> --- drivers/scsi/bnx2i/bnx2i.h | 11 +--- drivers/scsi/bnx

[REPOST PATCH 3/5] scsi: bnx2fc: clean up header definitions

<h...@lst.de> Signed-off-by: Sebastian Andrzej Siewior <bige...@linutronix.de> --- drivers/scsi/bnx2fc/bnx2fc.h | 5 + drivers/scsi/bnx2fc/bnx2fc_els.c | 4 ++-- drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 14 +++--- drivers/scsi/bnx2fc/bnx2fc_hwi.c | 8 +++- drivers

Re: [REPOST PATCH 1/5] scsi: bnx2i: convert to kworker

On 2016-09-14 13:25:12 [-0400], Martin K. Petersen wrote: > > "Chad" == Chad Dupuis writes: > > Chad> We're regression testing the patches now. Please hold off on > Chad> applying them. > > OK. I will wait. Chad, any updates on this tests? Sebastian -- To

Re: [PREEMPT-RT] [REPOST PATCH 1/5] scsi: bnx2i: convert to kworker

On 2016-11-07 17:38:48 [+0100], Christoph Hellwig wrote: > You're right it does - between the incorrect subject and the fact > that it still keeps the linked list of items arounds instead of fully > using the workqueue infrastructure I was a bit confused before my > first coffee this morning.

Re: [PREEMPT-RT] [REPOST PATCH 1/5] scsi: bnx2i: convert to kworker

On 2016-11-07 17:48:46 [+0100], Christoph Hellwig wrote: > On Mon, Nov 07, 2016 at 05:46:29PM +0100, Sebastian Andrzej Siewior wrote: > > sorry for the confusion in the subject. If I remember correctly you said > > that we may not have enough room for a larger / work_struct struct a

bnx2i + bnx2fc: convert to generic workqueue (#2)

This is the a repost + fixups to get the patches applied against v4.9-rc4. mkp's scsi for-next tree can be merged with no conflicts. The last repost was not merged and stalled after Chad Dupuis said to hold on because he is testing but never came back with the results [0]. Johannes confirmed that

[PATCH 1/5] scsi: bnx2i: convert to workqueue

workqueue code. This patch was only compile-tested due to -ENODEV. Cc: qlogic-storage-upstr...@qlogic.com Cc: Christoph Hellwig <h...@lst.de> Signed-off-by: Sebastian Andrzej Siewior <bige...@linutronix.de> --- drivers/scsi/bnx2i/bnx2i.h | 11 +--- drivers/scsi/bnx

[PATCH 4/5] scsi: bnx2fc: annoate unlock + release for sparse

lst.de> Signed-off-by: Sebastian Andrzej Siewior <bige...@linutronix.de> --- drivers/scsi/bnx2fc/bnx2fc_io.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/scsi/bnx2fc/bnx2fc_io.c b/drivers/scsi/bnx2fc/bnx2fc_io.c index f501095f91ac..634e1e539850 100644 --- a/drivers/scsi/bnx

[PATCH 5/5] scsi: bnx2fc: convert bnx2fc_l2_rcv_thread() to workqueue

: qlogic-storage-upstr...@qlogic.com Cc: Christoph Hellwig <h...@lst.de> Cc: fcoe-de...@open-fcoe.org Signed-off-by: Sebastian Andrzej Siewior <bige...@linutronix.de> --- drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 57 +-- include/scsi/libfcoe.h|

[PATCH 3/5] scsi: bnx2fc: clean up header definitions

<h...@lst.de> Signed-off-by: Sebastian Andrzej Siewior <bige...@linutronix.de> --- drivers/scsi/bnx2fc/bnx2fc.h | 5 + drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 19 +-- drivers/scsi/bnx2fc/bnx2fc_hwi.c | 6 ++ 3 files changed, 12 insertions(+), 18 deletions(-)

[PATCH 2/5] scsi: bnx2fc: convert per-CPU thread to workqueue

ning part is the removal CPU hotplug notifier since it is taken care by the workqueue code. This patch was only compile-tested due to -ENODEV. Cc: qlogic-storage-upstr...@qlogic.com Cc: Christoph Hellwig <h...@lst.de> Signed-off-by: Sebastian Andrzej Siewior <bige...@linutronix.de> --- drivers

Re: [PATCH 1/5] scsi: bnx2i: convert to kworker

On 2016-11-18 13:56:22 [+0100], Christoph Hellwig wrote: > still says kwork in the subject.. I was thinking about this before sending it out. But then it uses the generic workqueue / kworker and a custom kthread like it did before. What would you prefer to call it then? Just workqueue? Sebastian

[PATCH 2/5] scsi: bnx2fc: convert per-CPU thread to kworker

ning part is the removal CPU hotplug notifier since it is taken care by the kworker code. This patch was only compile-tested due to -ENODEV. Cc: qlogic-storage-upstr...@qlogic.com Cc: Christoph Hellwig <h...@lst.de> Signed-off-by: Sebastian Andrzej Siewior <bige...@linutronix.de> --- drivers

bnx2i + bnx2fc: convert to generic workqueue

] https://lkml.kernel.org/r/yq137l2mm13@sermon.lab.mkp.net [1] https://lkml.kernel.org/r/20161108072434.gnnhmrkkmxroy...@linux-x5ow.site [2] https://lkml.kernel.org/r/20161107191025.ga5...@lst.de Sebastian Andrzej Siewior (5): scsi: bnx2i: convert to kworker scsi: bnx2fc: convert per-CPU

[PATCH 1/5] scsi: bnx2i: convert to kworker

e kworker code. This patch was only compile-tested due to -ENODEV. Cc: qlogic-storage-upstr...@qlogic.com Cc: Christoph Hellwig <h...@lst.de> Signed-off-by: Sebastian Andrzej Siewior <bige...@linutronix.de> --- drivers/scsi/bnx2i/bnx2i.h | 11 +--- drivers/scsi/bnx

[PATCH 3/5] scsi: bnx2fc: clean up header definitions

<h...@lst.de> Signed-off-by: Sebastian Andrzej Siewior <bige...@linutronix.de> --- drivers/scsi/bnx2fc/bnx2fc.h | 5 + drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 19 +-- drivers/scsi/bnx2fc/bnx2fc_hwi.c | 6 ++ 3 files changed, 12 insertions(+), 18 deletions(-)

[PATCH 5/5] scsi: bnx2fc: convert bnx2fc_l2_rcv_thread() to worker

-storage-upstr...@qlogic.com Cc: Christoph Hellwig <h...@lst.de> Cc: fcoe-de...@open-fcoe.org Signed-off-by: Sebastian Andrzej Siewior <bige...@linutronix.de> --- drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 57 +-- include/scsi/libfcoe.h| 1 - 2 f

[PATCH 4/5] scsi: bnx2fc: annoate unlock + release for sparse

lst.de> Signed-off-by: Sebastian Andrzej Siewior <bige...@linutronix.de> --- drivers/scsi/bnx2fc/bnx2fc_io.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/scsi/bnx2fc/bnx2fc_io.c b/drivers/scsi/bnx2fc/bnx2fc_io.c index f501095f91ac..634e1e539850 100644 --- a/drivers/scsi/bnx

[PATCH 1/5] scsi: bnx2i: convert to workqueue

workqueue code. This patch was only compile-tested due to -ENODEV. Cc: qlogic-storage-upstr...@qlogic.com Cc: Christoph Hellwig <h...@lst.de> Signed-off-by: Sebastian Andrzej Siewior <bige...@linutronix.de> --- drivers/scsi/bnx2i/bnx2i.h | 11 ++--- drivers/scsi/bnx

[PATCH 5/5] scsi: bnx2fc: convert bnx2fc_l2_rcv_thread() to workqueue

: qlogic-storage-upstr...@qlogic.com Cc: Christoph Hellwig <h...@lst.de> Cc: fcoe-de...@open-fcoe.org Signed-off-by: Sebastian Andrzej Siewior <bige...@linutronix.de> --- drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 59 --- include/scsi/libfcoe.h|

[PATCH 4/5] scsi: bnx2fc: annoate unlock + release for sparse

lst.de> Signed-off-by: Sebastian Andrzej Siewior <bige...@linutronix.de> --- drivers/scsi/bnx2fc/bnx2fc_io.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/scsi/bnx2fc/bnx2fc_io.c b/drivers/scsi/bnx2fc/bnx2fc_io.c index 898461b146cc..3eed2453648c 100644 --- a/drivers/scsi/bnx

[PATCH 2/5] scsi: bnx2fc: convert per-CPU thread to workqueue

ning part is the removal CPU hotplug notifier since it is taken care by the workqueue code. This patch was only compile-tested due to -ENODEV. Cc: qlogic-storage-upstr...@qlogic.com Cc: Christoph Hellwig <h...@lst.de> Signed-off-by: Sebastian Andrzej Siewior <bige...@linutronix.de> --- drivers

[PATCH 3/5] scsi: bnx2fc: clean up header definitions

<h...@lst.de> Signed-off-by: Sebastian Andrzej Siewior <bige...@linutronix.de> --- drivers/scsi/bnx2fc/bnx2fc.h | 5 + drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 19 +-- drivers/scsi/bnx2fc/bnx2fc_hwi.c | 6 ++ 3 files changed, 12 insertions(+), 18 deletions(-)

[REEEEPOST] bnx2i + bnx2fc: convert to generic workqueue (#3)

This is a repost to get the patches applied against v4.11-rc6. mkp's scsi for-next tree can be merged with no conflicts. The last repost [0] was not merged and stalled after Martin pinged Chad [1]. He didn't even reply after tglx pinged him approx two weeks later. Johannes Thumshirn was so kind

Re: [REEEEPOST] bnx2i + bnx2fc: convert to generic workqueue (#3)

On 2017-04-10 14:20:41 [-0400], Chad Dupuis wrote: > Sebastian, will take a look. This [0] commit in tip's smp/hotplug branch is staged for the next merge window. It will trigger a lockdep warning on the recursive get_online_cpus() invocation in the two drivers. It is fixed/avoided by the

Re: [PATCH 1/5] scsi: bnx2i: convert to workqueue

On 2017-06-29 15:57:56 [+0200], Johannes Thumshirn wrote: > So here we are again, > Tested-by: Johannes Thumshirn > > FCoE will follow as soon as my setup can speak FCoE again. So it all looks good, doesn't it? Chad never responded to my question on his patch. I still doubt

Re: [PATCH 1/5] scsi: bnx2i: convert to workqueue

On 2017-07-07 09:20:02 [-0400], Chad Dupuis wrote: > What was the question? My observation is that the patch I proposed fixed > the issue we saw on testing the patch set. With that small change > (essentially modulo by the number of active CPUs vs. the total number) > your patch set worked

Re: [REEEEPOST] bnx2i + bnx2fc: convert to generic workqueue (#3)

On 2017-05-12 11:55:52 [-0400], Chad Dupuis wrote: > Ok, I believe I've found the issue here. The machine that the test has > performed on had many more possible CPUs than active CPUs. We calculate > which CPU to the work time on in bnx2fc_process_new_cqes() like this: > > unsigned int cpu =

Re: [PREEMPT-RT] [REEEEPOST] bnx2i + bnx2fc: convert to generic workqueue (#3)

On 2017-05-17 17:01:53 [+0200], To Chad Dupuis wrote: > On 2017-05-12 11:55:52 [-0400], Chad Dupuis wrote: > > Ok, I believe I've found the issue here. The machine that the test has > > performed on had many more possible CPUs than active CPUs. We calculate > > which CPU to the work time on in

Re: [PREEMPT-RT] [REEEEPOST] bnx2i + bnx2fc: convert to generic workqueue (#3)

On 2017-05-17 17:07:34 [+0200], To Chad Dupuis wrote: > > > Sebastian, can you add this change to your patch set? > > > > Are sure that you can reliably reproduce the issue and fix it with the > > patch above? Because this patch: > > oh. Okay. Now it clicked. It can fix the issue but it is still

Re: [REEEEPOST] bnx2i + bnx2fc: convert to generic workqueue (#3)

On 2017-04-10 19:12:49 [+0200], To Martin K . Petersen wrote: > This is a repost to get the patches applied against v4.11-rc6. mkp's scsi > for-next tree can be merged with no conflicts. … Martin, do you see any chance to get this merged? Chad replied to the list that he is going to test it on

[PATCH 1/2] libsas: remove irq save in sas_ata_qc_issue()

Signed-off-by: Sebastian Andrzej Siewior <bige...@linutronix.de> --- drivers/scsi/libsas/sas_ata.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/scsi/libsas/sas_ata.c b/drivers/scsi/libsas/sas_ata.c index 0cc1567eacc1..bc5d917ff643 100644 --- a/drivers/scsi/libsas/sas_ata.c ++

[PATCH 2/2] qla2xxx: remove irq save in qla2x00_poll()

ll of them use the irqsave variant so it is safe to remove the local_irq_save() block now. Signed-off-by: Sebastian Andrzej Siewior <bige...@linutronix.de> --- drivers/scsi/qla2xxx/qla_inline.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_

Re: [PATCH 1/2] libsas: remove irq save in sas_ata_qc_issue()

On 2018-05-23 09:46:30 [+0100], John Garry wrote: > On 22/05/2018 18:31, Sebastian Andrzej Siewior wrote: > > On 2018-05-18 14:31:27 [+0100], John Garry wrote: > > > On 04/05/2018 15:50, Sebastian Andrzej Siewior wrote: > > > > Since commit 312d3e56119a ("

Re: [PATCH 1/2] libsas: remove irq save in sas_ata_qc_issue()

On 2018-05-24 15:38:51 [+0800], Jason Yan wrote: > > no, please don't do this. Please add instead > > lockdep_assert_held() > > > > on the lock in question and let lockdep to its work. Lockdep has way > > better coverage than your irqs_disabled() check which also breaks RT. > > > >

Re: [PATCH 1/2] libsas: remove irq save in sas_ata_qc_issue()

On 2018-05-24 09:50:07 [+0200], Johannes Thumshirn wrote: > > lockdep_assert_held() cannot detect the irq state, it can only detect > > whether we have held the lock. > > I think Sebastian wanted to say lockdep_assert_irqs_disabled(). nope, meant the right thing. > Byte, > Johannes

Re: [PATCH 1/2] libsas: remove irq save in sas_ata_qc_issue()

On 2018-05-24 16:20:33 [+0800], Jason Yan wrote: > NO, this: > > /* TODO: audit callers to ensure they are ready for qc_issue to >* unconditionally re-enable interrupts >*/ > local_irq_save(flags); > spin_unlock(ap->lock); indeed, I have no idea how I could have

Re: [PATCH 1/2] libsas: remove irq save in sas_ata_qc_issue()

On 2018-05-24 16:00:47 [+0800], Jason Yan wrote: > > > Because you are trying to delete the irq-save code which will make the > > > comment hard to understand, I'm just giving an advise. It's welcome > > > if you have a better way. > > > > I am removing local_irq_save() prior an unlock of a lock

Re: [PATCH 1/2] libsas: remove irq save in sas_ata_qc_issue()

On 2018-05-24 10:58:44 [+0800], Jason Yan wrote: > I think it's fine to delete this irq save code. As for the "TODO" > comment, I think we can add: > > BUG_ON(!irqs_disabled()); > > or > > WARN_ON_ONCE(!irqs_disabled()); no, please don't do this. Please add instead

[PATCH 1/2 v2] scsi: libsas: remove irq save in sas_ata_qc_issue()

Signed-off-by: Sebastian Andrzej Siewior <bige...@linutronix.de> --- v1…v2: Drop the TODO comment as suggested by Jason Yan. drivers/scsi/libsas/sas_ata.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/scsi/libsas/sas_ata.c b/drivers/scsi/libsas/sas_ata.c index 0cc1567eacc1..b3b

Re: [PATCH 1/2] libsas: remove irq save in sas_ata_qc_issue()

On 2018-05-18 14:31:27 [+0100], John Garry wrote: > On 04/05/2018 15:50, Sebastian Andrzej Siewior wrote: > > Since commit 312d3e56119a ("[SCSI] libsas: remove ata_port.lock > > management duties from lldds") the sas_ata_qc_issue() function unlocks > > the ata_po

Re: [PATCH 0/2 REPOST] remove unneded irq save

On 2018-06-12 13:54:36 [+0100], John Garry wrote: > +Dan > > On 11/06/2018 19:23, Sebastian Andrzej Siewior wrote: > > On 2018-06-11 18:12:55 [+0100], John Garry wrote: > > > On 11/06/2018 15:40, Sebastian Andrzej Siewior wrote: > > > > This is the repost of

[PATCH 1/2 v2] libsas: remove irq save in sas_ata_qc_issue()

Signed-off-by: Sebastian Andrzej Siewior --- v1…v2: Updating comment as suggested by Dan Williams. drivers/scsi/libsas/sas_ata.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/scsi/libsas/sas_ata.c b/drivers/scsi/libsas/sas_ata.c index ff1d612f6fb9..2ac739511

Re: [PATCH 0/2 REPOST] remove unneded irq save

On 2018-06-12 08:46:38 [-0700], Dan Williams wrote: > On Tue, Jun 12, 2018 at 8:04 AM, John Garry wrote: > >> We had this comment for 6 years or so and nothing happend. What makes > >> you think that an updated version of that comment will motivate someone > >> to make change here in the near

[PATCH 0/2 REPOST] remove unneded irq save

This is the repost of the two patches I posted in earlier this month: - [PATCH 1/2] libsas: remove irq save in sas_ata_qc_issue() Received feedback but nothing really changed. I explained that this is not about "local_irqsave() + spin_lock()" *but* "local_irq_save() + spin_unlock()". This

[PATCH 1/2] libsas: remove irq save in sas_ata_qc_issue()

Signed-off-by: Sebastian Andrzej Siewior --- drivers/scsi/libsas/sas_ata.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/scsi/libsas/sas_ata.c b/drivers/scsi/libsas/sas_ata.c index ff1d612f6fb9..1216e6711178 100644 --- a/drivers/scsi/libsas/sas_ata.c +++ b/drivers/scsi/libsas/sas_ata.c

[PATCH 2/2] qla2xxx: remove irq save in qla2x00_poll()

ll of them use the irqsave variant so it is safe to remove the local_irq_save() block now. Cc: qla2xxx-upstr...@qlogic.com Signed-off-by: Sebastian Andrzej Siewior --- drivers/scsi/qla2xxx/qla_inline.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/scsi/qla2xxx/ql

Re: [PATCH 0/2 REPOST] remove unneded irq save

On 2018-06-11 18:12:55 [+0100], John Garry wrote: > On 11/06/2018 15:40, Sebastian Andrzej Siewior wrote: > > This is the repost of the two patches I posted in earlier this month: > > > > - [PATCH 1/2] libsas: remove irq save in sas_ata_qc_issue() > > Received

Re: [PATCH 2/2] qla2xxx: remove irq save in qla2x00_poll()

On 2018-06-11 16:56:35 [+0200], Johannes Thumshirn wrote: > Looks good, > Reviewed-by: Johannes Thumshirn Martin, what about this one? Sebastian

Re: [PATCH 1/2 v2] libsas: remove irq save in sas_ata_qc_issue()

On 2018-06-14 21:59:18 [-0400], Martin K. Petersen wrote: > > Sebastian, Martin, > Applied to 4.19/scsi-queue. Thank you! Thank you. Sebastian

Re: [PATCH 1/2] libsas: remove irq save in sas_ata_qc_issue()

On 2018-05-30 10:34:12 [+0100], John Garry wrote: > Sorry, but personally I don't see much value in this change. I think it's > better for safety to be consistent in how we lock & unlock the spinlock, > i.e. use irqsave variant (or similar). The lock should do irqsave() and unlock irqrestore().

Re: [PATCH 1/2] libsas: remove irq save in sas_ata_qc_issue()

On 2018-05-30 12:16:23 [+0100], John Garry wrote: > On 30/05/2018 11:16, Sebastian Andrzej Siewior wrote: > > On 2018-05-30 10:34:12 [+0100], John Garry wrote: > > > Sorry, but personally I don't see much value in this change. I think it's > > > better for safety to b

Re: [PATCH 1/2] libsas: remove irq save in sas_ata_qc_issue()

On 2018-05-30 14:37:50 [+0100], John Garry wrote: > On 30/05/2018 12:22, Sebastian Andrzej Siewior wrote: > > Yes, there are the same on vanilla and not on RT. However my point is > > that the code does this instead: > > local_irq_save(); > > spin_unlock

Re: [PATCH 1/2] libsas: remove irq save in sas_ata_qc_issue()

On 2018-05-30 15:08:37 [+0100], John Garry wrote: > On 30/05/2018 14:45, Sebastian Andrzej Siewior wrote: > > excellent. So no more objections from your side or is this a complaint I > > didn't fully decode? > > I think the original code is not great since we

Re: [PATCH] target: Use WARNON_NON_RT(!irqs_disabled())

On 2018-03-22 06:37:45 [-0300], Arnaldo Carvalho de Melo wrote: > Em Wed, Mar 21, 2018 at 11:43:58AM -0700, Linus Torvalds escreveu: > > [ Adding PeterZ to participants due to query about lockdep_assert() ] > > > > On Wed, Mar 21, 2018 at 8:38 AM, Arnaldo Carvalho de Melo > >

[PATCH 1/2 v2] target: drop spin_lock_assert() + irqs_disabled() combo checks

Suggested-by: Linus Torvalds <torva...@linux-foundation.org> Signed-off-by: Sebastian Andrzej Siewior <bige...@linutronix.de> --- v1…2: Add credits. drivers/target/target_core_tmr.c | 2 -- drivers/target/target_core_transport.c | 6 -- 2 files changed, 8 deletions(