Re: [PATCHv1 6/6] rdmacg: Added documentation for rdma controller.
Hello, On Thu, Jan 07, 2016 at 05:22:40AM +0530, Parav Pandit wrote: > I can remove "resource" key word. If just that if something other than > resource comes up to limit to in future, it will be hard to define at > that time. Please remove. The word doesn't mean anything in this context. > > Also can't the .max file list > > the available resources? Why does it need a separtae list file? > > > max file does lists them only after limits are configured for that > device. Thats when rpool (array of max and usage counts) is allocated. > > If user wants to know what all knobs are available, than list file > exposes them on per device basis without actually mentioning actual > limit or without allocating rpool arrays. ... > list file looks like below for two device entries. > mlx4_0 ah qp mr pd srq flow > ocrdma0 ah qp mr pd > > max file looks like below. > mlx4_0 ah=100 qp=40 mr=10 pd=90 srq=10 flow=10 Just always show the settings for all devices in the max file like the following? mlx4_0 ah=max qp=max mr=max pd=max srq=max flow=max ocrdma0 ah=max qp=max mr=max pd=max Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-security-module" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCHv1 6/6] rdmacg: Added documentation for rdma controller.
On Thu, Jan 7, 2016 at 4:27 AM, Tejun Heo wrote: > Hello, > > On Thu, Jan 07, 2016 at 04:14:26AM +0530, Parav Pandit wrote: >> Yes. I read through. I can see two changes to be made in V2 version of >> this patch. >> 1. rdma.resource.verb.usage and rdma.resource.verb.limit to change >> respectively to, >> 2. rdma.resource.verb.stat and rdma.resource.verb.max. >> 3. rdma.resource.verb.failcnt indicate failure events, which I think >> should go to events. > > What's up with the ".resource" part? I can remove "resource" key word. If just that if something other than resource comes up to limit to in future, it will be hard to define at that time. > Also can't the .max file list > the available resources? Why does it need a separtae list file? > max file does lists them only after limits are configured for that device. Thats when rpool (array of max and usage counts) is allocated. If user wants to know what all knobs are available, than list file exposes them on per device basis without actually mentioning actual limit or without allocating rpool arrays. If you are hinting that I should allocate rpool array when rdma cgroup is created, that can be done for already discovered devices. If new devices are discovered after cgroup is created, for them we anyway have to allocate/free when they appear/disappear. In different implementation, where list of all the rdma cgroups can be maintained, and rpool arrays can be allocated for all of them when new device appear/disappear. This can move complexity of dynamic allocation from try_charge/uncharge to device addition and removal APIs. ib_register_ib_device() level. However this comes with memory cost, where even if those device doesnt participate in cgroup, for them rpool memory will be allocated for each such rdma cgroup. list file looks like below for two device entries. mlx4_0 ah qp mr pd srq flow ocrdma0 ah qp mr pd max file looks like below. mlx4_0 ah=100 qp=40 mr=10 pd=90 srq=10 flow=10 >> I roll out new patch for events post this patch as additional feature >> and remove this feature in V2. >> >> rdma.resource.verb.list file is unique to rdma cgroup, so I believe >> this is fine. > > Please see above. > >> We will conclude whether to have rdma.resource.hw. or not in >> other patches. >> I am in opinion to keep "resource" and "verb" or "hw" tags around to >> keep it verbose enough to know what are we trying to control. > > What does that achieve? I feel that it's getting overengineered > constantly. Please see above for "resource". I guess we are not loosing anything by having "rdma.resource" vs just having "rdma". But if that sounds too much, we can remove "resource". > > Thanks. > > -- > tejun -- To unsubscribe from this list: send the line "unsubscribe linux-security-module" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCHv1 6/6] rdmacg: Added documentation for rdma controller.
Hello, On Thu, Jan 07, 2016 at 04:14:26AM +0530, Parav Pandit wrote: > Yes. I read through. I can see two changes to be made in V2 version of > this patch. > 1. rdma.resource.verb.usage and rdma.resource.verb.limit to change > respectively to, > 2. rdma.resource.verb.stat and rdma.resource.verb.max. > 3. rdma.resource.verb.failcnt indicate failure events, which I think > should go to events. What's up with the ".resource" part? Also can't the .max file list the available resources? Why does it need a separtae list file? > I roll out new patch for events post this patch as additional feature > and remove this feature in V2. > > rdma.resource.verb.list file is unique to rdma cgroup, so I believe > this is fine. Please see above. > We will conclude whether to have rdma.resource.hw. or not in > other patches. > I am in opinion to keep "resource" and "verb" or "hw" tags around to > keep it verbose enough to know what are we trying to control. What does that achieve? I feel that it's getting overengineered constantly. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-security-module" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCHv1 6/6] rdmacg: Added documentation for rdma controller.
On Wed, Jan 6, 2016 at 3:23 AM, Tejun Heo wrote: > Hello, > > On Wed, Jan 06, 2016 at 12:28:06AM +0530, Parav Pandit wrote: >> +5-4-1. RDMA Interface Files >> + >> + rdma.resource.verb.list >> + rdma.resource.verb.limit >> + rdma.resource.verb.usage >> + rdma.resource.verb.failcnt >> + rdma.resource.hw.list >> + rdma.resource.hw.limit >> + rdma.resource.hw.usage >> + rdma.resource.hw.failcnt > > Can you please read the rest of cgroup.txt and put the interface in > line with the common conventions followed by other controllers? > Yes. I read through. I can see two changes to be made in V2 version of this patch. 1. rdma.resource.verb.usage and rdma.resource.verb.limit to change respectively to, 2. rdma.resource.verb.stat and rdma.resource.verb.max. 3. rdma.resource.verb.failcnt indicate failure events, which I think should go to events. I roll out new patch for events post this patch as additional feature and remove this feature in V2. rdma.resource.verb.list file is unique to rdma cgroup, so I believe this is fine. We will conclude whether to have rdma.resource.hw. or not in other patches. I am in opinion to keep "resource" and "verb" or "hw" tags around to keep it verbose enough to know what are we trying to control. Is that ok? > Thanks. > > -- > tejun -- To unsubscribe from this list: send the line "unsubscribe linux-security-module" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCHv1 6/6] rdmacg: Added documentation for rdma controller.
Hello, On Wed, Jan 06, 2016 at 12:28:06AM +0530, Parav Pandit wrote: > +5-4-1. RDMA Interface Files > + > + rdma.resource.verb.list > + rdma.resource.verb.limit > + rdma.resource.verb.usage > + rdma.resource.verb.failcnt > + rdma.resource.hw.list > + rdma.resource.hw.limit > + rdma.resource.hw.usage > + rdma.resource.hw.failcnt Can you please read the rest of cgroup.txt and put the interface in line with the common conventions followed by other controllers? Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-security-module" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
