[patch] Space displayed after macro, #3705

2007-06-15 Thread Stefan Schimanski
Here is a patch for http://bugzilla.lyx.org/show_bug.cgi?id=3705. It adds the kerning method to a macro to inherit the kerning from the expanded form. Moreover the marker metrics calls are remove as they are not drawn anyway. Stefan Index: src/mathed/MathMacro.h

Re: WANTED: users of Right-To-Left languages who want proper support in LyX 1.5

2007-06-15 Thread Miki Dovrat
Hi, My comments are below Miki 3. If I have a Hebrew paragraph with an English word like ? English ? ? and I type continuously, the spaces are Hebrew. Now if I try to continue the Hebrew to the right of the English word, but after the Hebrew space, as to continue typing, I

Re: [patch] Language of Inset (bug 3011)

2007-06-15 Thread Dov Feldstern
Dov Feldstern wrote: Jean-Marc Lasgouttes wrote: Dov == Dov Feldstern [EMAIL PROTECTED] writes: Dov Hi! attached find a very simple fix for Dov http://bugzilla.lyx.org/show_bug.cgi?id=3011 (which is a Dov regression relative to 1.3.X). The problem is that when typing Dov some LTR in an RTL

was: Re: WANTED: users of Right-To-Left languages who want proper support in LyX 1.5

2007-06-15 Thread Dov Feldstern
Separating this into different issues, it's getting long... Miki Dovrat wrote: 3. If I have a Hebrew paragraph with an English word like ? English ? ? and I type continuously, the spaces are Hebrew. Now if I try to continue the Hebrew to the right of the English word, but after the

Re: 20% speedup of paragraph redraw with simple patch

2007-06-15 Thread Abdelrazak Younes
Andre Poenitz wrote: On Thu, Jun 14, 2007 at 05:49:53PM +0200, Abdelrazak Younes wrote: Moreover, it remains to be seen whether the map is faster in the cases where the container typically has at most 10 elements. It might be that a stupid plain loop is faster... Maybe not faster but a lot

Re: 20% speedup of paragraph redraw with simple patch

2007-06-15 Thread Martin Vermeer
On Thu, Jun 14, 2007 at 09:01:49PM +0200, Andre Poenitz wrote: On Thu, Jun 14, 2007 at 05:05:32PM +0200, Stefan Schimanski wrote: I did some profiling of paragraph drawing. 20% of the whole time while inserting characters and redrawing the screen was taken by Paragraph::getInset calls,

Re: WANTED: users of Right-To-Left languages who want proper support in LyX 1.5

2007-06-15 Thread Dov Feldstern
Miki Dovrat wrote: When moving across already written text, lyx, when spotting a move between \L and \R should move visually, i.e., to the end of the foreign text and go backwards (so the arrow keys move to the right direction), and change its language as well, again, unless explicitly

Re: was: Re: WANTED: users of Right-To-Left languages who want proper support in LyX 1.5

2007-06-15 Thread Abdelrazak Younes
Dov Feldstern wrote: , unless the user explicitly changes it with F12 (\language hebrew), the cursor will NOT MOVE, and the text will be added where it was, whether it was English or Hebrew. Again, this doesn't make sense when typing. It means after every insertion of an english word,

Re: WANTED: users of Right-To-Left languages who want proper support in LyX 1.5

2007-06-15 Thread Abdelrazak Younes
Miki Dovrat wrote: To sum up, I would like lyx, when it is inside a \L (English), to switch automatically to English, unless the user explicitly changes it with F12 (\language hebrew), the cursor will NOT MOVE, and the text will be added where it was, whether it was English or Hebrew. When

Re: WANTED: users of Right-To-Left languages who want proper support in LyX 1.5

2007-06-15 Thread Abdelrazak Younes
Dov Feldstern wrote: Miki Dovrat wrote: When moving across already written text, lyx, when spotting a move between \L and \R should move visually, i.e., to the end of the foreign text and go backwards (so the arrow keys move to the right direction), and change its language as well, again,

Re: WANTED: users of Right-To-Left languages who want proper support in LyX 1.5

2007-06-15 Thread Dov Feldstern
Miki Dovrat wrote: 6. I cannot enter an inline equation to the right of the English word. This looks like a bug. If you're coming from the english, then I think that the equation should also be in english (see next comment), and then what you want to do would work. Can you open a bug for this

Re: 20% speedup of paragraph redraw with simple patch

2007-06-15 Thread Jean-Marc Lasgouttes
Dov == Dov Feldstern [EMAIL PROTECTED] writes: Dov Hmm, I just came across this yesterday when trying to figure out Dov what was going on with bug 3011, and wondered about it. I'm not Dov sure if this is what you mean or not, but it might be relevant... Dov

Re: [patch] Language of Inset (bug 3011)

2007-06-15 Thread Jean-Marc Lasgouttes
Dov == Dov Feldstern [EMAIL PROTECTED] writes: Dov Attached is the patch using current_font. Is this Okay? The patch is definitely correct. Please apply. Dov I actually wanted to solve this in a more complete way, by Dov setting the font to current_font directly within Dov

Spaces in Bidi part #2

2007-06-15 Thread Dov Feldstern
Okay, I'm starting a new thread for this issue. This is now bug 3870 in bugzilla (http://bugzilla.lyx.org/show_bug.cgi?id=3870). The problem: typing spaces at RTL/LTR boundaries does not always do what the user expects/wants. (The reason I opened a new bug, is that this really a different

Re: [patch] Language of Inset (bug 3011)

2007-06-15 Thread Dov Feldstern
Jean-Marc Lasgouttes wrote: Dov == Dov Feldstern [EMAIL PROTECTED] writes: Dov Attached is the patch using current_font. Is this Okay? The patch is definitely correct. Please apply. Thanks, committed. Dov Could the versions of insertInset which do not take a font be Dov made private, so

Re: WANTED: users of Right-To-Left languages who want proper support in LyX 1.5

2007-06-15 Thread Dov Feldstern
Dov Feldstern wrote: Miki Dovrat wrote: Are these solved with the above-mentioned fix? Is it already in svn? if not, where is the patch? I will check. See http://permalink.gmane.org/gmane.editors.lyx.devel/87817. Let's continue the discussion of this issue in response to that thread.

Re: [patch] Language of Inset (bug 3011)

2007-06-15 Thread Jean-Marc Lasgouttes
Dov == Dov Feldstern [EMAIL PROTECTED] writes: Dov In that case, it looks like there's only one other place where Dov the form without a font is still used: Dov Paragraph::checkBiblio(bool track_changes) Dov I'm not familiar with this function at all. However, it is only Dov used in one place,

Re: [PATCH-updated] Make HTML Export Work

2007-06-15 Thread José Matos
On Friday 15 June 2007 05:39:01 Richard Heck wrote: Now seeking an OK to commit. Richard Richard has gave this some thought and has tested this thoroughly so I am inclined to give this my OK. Any objection? -- José Abílio

Re: [PATCH-updated] Make HTML Export Work

2007-06-15 Thread Jean-Marc Lasgouttes
Jean-Marc == Jean-Marc Lasgouttes [EMAIL PROTECTED] writes: Richard The patch also includes some associated updates to the Richard documentation. Jean-Marc But not Extended.lyx. Forget this. This patch does not get rid of originaldir. JMarc

Re: [PATCH-updated] Make HTML Export Work

2007-06-15 Thread Jean-Marc Lasgouttes
José == José Matos [EMAIL PROTECTED] writes: José On Friday 15 June 2007 05:39:01 Richard Heck wrote: Now seeking an OK to commit. Richard José Richard has gave this some thought and has tested this José thoroughly so I am inclined to give this my OK. Any objection? Since there is no

Re: [PATCH-updated] Make HTML Export Work

2007-06-15 Thread Enrico Forestieri
On Fri, Jun 15, 2007 at 12:39:01AM -0400, Richard Heck wrote: This patch is now slightly updated. In place of the two scripts tex4html_copy.py and dir_copy.py, there is now just one, ext_copy.py. Without any optional arguments, this script acts like dir_copy.py did: It copies all files in

Re: [PATCH-updated] Make HTML Export Work

2007-06-15 Thread Jean-Marc Lasgouttes
Richard == Richard Heck [EMAIL PROTECTED] writes: Richard This new patch will allow easy handling of other converters, Richard such as hevea (and if anyone knows what kinds of files it Richard generates, let me know, and I'll add the definition to Richard configure.py). The documentaton is

Re: [PATCH-updated] Make HTML Export Work

2007-06-15 Thread Georg Baum
Richard Heck wrote: This patch is now slightly updated. In place of the two scripts tex4html_copy.py and dir_copy.py, there is now just one, ext_copy.py. I was about to suggest that. Without any optional arguments, this script acts like dir_copy.py did: It copies all files in LyX's

Re: [PATCH] Strip unused originaldir flag from Converters.{cpp,h}

2007-06-15 Thread Georg Baum
Jean-Marc Lasgouttes wrote: Richard == Richard Heck [EMAIL PROTECTED] writes: Richard This time with the patch... Richard As said. This flag was removed from configure.py a while ago. Richard It was only ever used with HTML export, and it didn't work Richard there, anyway. I didn't

Re: [PATCH] Bug 3860 Toc crash when loading a child documents

2007-06-15 Thread Abdelrazak Younes
Abdelrazak Younes wrote: http://bugzilla.lyx.org/show_bug.cgi?id=3860 SVN Log: Polish the Toc and labels updating when loading a child document. Fix Bug 3860: Toc crash when loading a child documents. * BufferView::loadLyXFile(): simplify, transfer last part to LyXView::loadLyXFile() *

Re: Sample test files and improved patch Re: [patch] Enable tex2lyx read back lyx exported .tex as much as possible

2007-06-15 Thread Georg Baum
hzluo wrote: Please test and give me feedback. Thanks! I have a couple of comments you might want to consider or ignore: 1) Jose plans to rewrite tex2lyx in python, so be aware that all your work is wasted if he ever does that. The threat of the python rewrite is the only reason why I did not

Re: Sample test files and improved patch Re: [patch] Enable tex2lyx read back lyx exported .tex as much as possible

2007-06-15 Thread Jean-Marc Lasgouttes
Georg == Georg Baum [EMAIL PROTECTED] writes: Georg 1) Jose plans to rewrite tex2lyx in python, so be aware that Georg all your work is wasted if he ever does that. The threat of the Georg python rewrite is the only reason why I did not convert tex2lyx Georg to the unicode file format already

Re: 2007 LyX Meeting: Invitation

2007-06-15 Thread Jean-Marc Lasgouttes
Martin == Martin Vermeer [EMAIL PROTECTED] writes: Martin INVITATION Martin Hereby I invite everyone interested to participate in the ?th Martin International LyX Developers' Meeting in Bromarv, Western Martin Uusimaa, municipality of Ekenäs. What is the status? Who is coming and when? There

Re: Sample test files and improved patch Re: [patch] Enable tex2lyx read back lyx exported .tex as much as possible

2007-06-15 Thread Abdelrazak Younes
Georg Baum wrote: This might all sound very negative, please don't get that wrong. It is good that somebody works on tex2lyx +1 (and it would even be better if the python phantom would be killed). A phantom cannot be killed, it is not alive ;-) FYI Hangzai I have written somewhere in my

Re: was: Re: WANTED: users of Right-To-Left languages who want proper support in LyX 1.5

2007-06-15 Thread Miki Dovrat
I was going to say, let the cursor always stay where it is, and the user will learn to press END (end of line) to move it to continue typing. It is logical, (not in the logical direction sense), expected and easily adapted to by the user, as there are no surprises there. Abdel's idea is even

Re: Sample test files and improved patch Re: [patch] Enable tex2lyx read back lyx exported .tex as much as possible

2007-06-15 Thread Jean-Marc Lasgouttes
Abdelrazak == Abdelrazak Younes [EMAIL PROTECTED] writes: Abdelrazak FYI Hangzai I have written somewhere in my TODO list that Abdelrazak tex2lyx should be integrated into LyX. This would ease the Abdelrazak maintenance as we won't have to care about the LyX file Abdelrazak format compatibility

Re: Sample test files and improved patch Re: [patch] Enable tex2lyx read back lyx exported .tex as much as possible

2007-06-15 Thread Georg Baum
Abdelrazak Younes wrote: Georg Baum wrote: (and it would even be better if the python phantom would be killed). A phantom cannot be killed, it is not alive ;-) Well, it is alive enough to have real world effects. FYI Hangzai I have written somewhere in my TODO list that tex2lyx should

Re: Sample test files and improved patch Re: [patch] Enable tex2lyx read back lyx exported .tex as much as possible

2007-06-15 Thread Georg Baum
Abdelrazak Younes wrote: Georg Baum wrote: The integration might have advantages (e.g. inplace tex2lyx for clipboard snippets), but file format changes will only play a marginal role. The reason why it is some work to update tex2lyx to the newest file format does not lie in syntactical

Re: was: Re: WANTED: users of Right-To-Left languages who want proper support in LyX 1.5

2007-06-15 Thread Dov Feldstern
Miki Dovrat wrote: I was going to say, let the cursor always stay where it is, and the user will learn to press END (end of line) to move it to continue typing. It is logical, (not in the logical direction sense), expected and easily adapted to by the user, as there are no surprises there.

Re: Sample test files and improved patch Re: [patch] Enable tex2lyx read back lyx exported .tex as much as possible

2007-06-15 Thread Abdelrazak Younes
Georg Baum wrote: Abdelrazak Younes wrote: Georg Baum wrote: (and it would even be better if the python phantom would be killed). A phantom cannot be killed, it is not alive ;-) Well, it is alive enough to have real world effects. FYI Hangzai I have written somewhere in my TODO list that

Re: was: Re: WANTED: users of Right-To-Left languages who want proper support in LyX 1.5

2007-06-15 Thread Dov Feldstern
Dov Feldstern wrote: Miki Dovrat wrote: I was going to say, let the cursor always stay where it is, and the user will learn to press END (end of line) to move it to continue typing. It is logical, (not in the logical direction sense), expected and easily adapted to by the user, as there are

Re: [PATCH] Strip unused originaldir flag from Converters.{cpp,h}

2007-06-15 Thread Richard Heck
Georg Baum wrote: Jean-Marc Lasgouttes wrote: Richard As said. This flag was removed from configure.py a while ago. Richard It was only ever used with HTML export, and it didn't work Richard there, anyway. I didn't remove it from Converters.* at that Richard time, because I was intending to

Re: [PATCH-updated] Make HTML Export Work

2007-06-15 Thread Richard Heck
Georg Baum wrote: Richard Heck wrote: Without any optional arguments, this script acts like dir_copy.py did: It copies all files in LyX's temporary directory to a subdirectory of the target directory. But now the script takes two optional arguments: -e: a list of extensions to copy, by

Re: [PATCH-updated] Make HTML Export Work

2007-06-15 Thread Richard Heck
Enrico Forestieri wrote: On Fri, Jun 15, 2007 at 12:39:01AM -0400, Richard Heck wrote: This issue has proven to be difficult, so I think that your solution is the less intrusive and workable one. I think that we should support more actively the converters we look for, i.e., provide a -e

Re: [PATCH-updated] Make HTML Export Work

2007-06-15 Thread Georg Baum
Richard Heck wrote: Georg Baum wrote: Richard Heck wrote: Without any optional arguments, this script acts like dir_copy.py did: It copies all files in LyX's temporary directory to a subdirectory of the target directory. But now the script takes two optional arguments: -e: a list of

Re: [PATCH-updated] Make HTML Export Work

2007-06-15 Thread Richard Heck
Georg Baum wrote: Richard Heck wrote: Georg Baum wrote: Richard Heck wrote: Without any optional arguments, this script acts like dir_copy.py did: It copies all files in LyX's temporary directory to a subdirectory of the target directory. But now the script takes two

Re: [PATCH] Bug 3860 Toc crash when loading a child documents

2007-06-15 Thread Richard Heck
Abdelrazak Younes wrote: I won't be able to commit it this week-end so could anyone show a little bit of interest please? I've patched and am compiling now. rh -- == Richard G Heck, Jr Professor of Philosophy Brown University

Re: [PATCH] Bug 3860 Toc crash when loading a child documents

2007-06-15 Thread José Matos
On Friday 15 June 2007 18:57:44 Richard Heck wrote: I've patched and am compiling now. rh If it fixes the crash you have my OK. :-) -- José Abílio

Re: [PATCH] Bug 3860 Toc crash when loading a child documents

2007-06-15 Thread Stefan Schimanski
Abdelrazak Younes wrote: I won't be able to commit it this week-end so could anyone show a little bit of interest please? I've patched and am compiling now. Me too. Stefan PGP.sig Description: Signierter Teil der Nachricht

Re: [patch] Space displayed after macro, #3705

2007-06-15 Thread José Matos
On Friday 15 June 2007 19:01:23 Stefan Schimanski wrote: Is it ok, José? It's only about cosmetics... Stefan OK. -- José Abílio

RC2 coming soon

2007-06-15 Thread José Matos
Hi all, I will start looking to remaining issues before RC2, AFAIR there are two patches that I would like to have before the release, one by Jürgen that has a file format change and another related with reverting documents to 1.4. Is there anything else that I am missing

Re: [patch] Space displayed after macro, #3705

2007-06-15 Thread Stefan Schimanski
Is it ok, José? It's only about cosmetics... Stefan Am 15.06.2007 um 08:39 schrieb Stefan Schimanski: Here is a patch for http://bugzilla.lyx.org/show_bug.cgi?id=3705. It adds the kerning method to a macro to inherit the kerning from the expanded form. Moreover the marker metrics calls are

Re: [PATCH] Bug 3860 Toc crash when loading a child documents

2007-06-15 Thread Stefan Schimanski
Tried it a bit with child documents. Looks fine. Stefan PGP.sig Description: Signierter Teil der Nachricht

Re: RC2 coming soon

2007-06-15 Thread Richard Heck
José Matos wrote: Hi all, I will start looking to remaining issues before RC2, AFAIR there are two patches that I would like to have before the release, one by Jürgen that has a file format change and another related with reverting documents to 1.4. I think it'd be nice to have Abdel's

Re: [PATCH] Bug 3860 Toc crash WITH child documents

2007-06-15 Thread Richard Heck
Richard Heck wrote: Abdelrazak Younes wrote: I won't be able to commit it this week-end so could anyone show a little bit of interest please? I've patched and am compiling now. This patch does fix that crash, but I'm seeing some other odd behavior, and I'm getting another crash. I don't know

Re: [PATCH] Bug 3860 Toc crash WITH child documents

2007-06-15 Thread Richard Heck
Richard Heck wrote: Richard Heck wrote: Second problem: Now, with the TOC open, close the master document. BOOM. Backtrace below. I'm guessing that the problem here is related to the first problem. This bug may have been revealed by my don't close buffer dependent dialogs patch:

Re: was: Re: WANTED: users of Right-To-Left languages who want proper support in LyX 1.5

2007-06-15 Thread Miki Dovrat
Dov Feldstern wrote: Dov Feldstern wrote: Miki Dovrat wrote: I was going to say, let the cursor always stay where it is, and the user will learn to press END (end of line) to move it to continue typing. It is logical, (not in the logical direction sense), expected and easily adapted to by

Re: user auth patches

2007-06-15 Thread Peter Kümmel
Tor Lillqvist wrote: The SID is a structure but there exists a functions for serialization, ConvertSidToStringSid. Therefore a string would be fine, the questions remains if we should use a wchar_t or char? The serialization is always ASCII only, so I don't see any gain in using

Re: user auth patches

2007-06-15 Thread Peter Kümmel
Peter Kümmel wrote: Tor Lillqvist wrote: The SID is a structure but there exists a functions for serialization, ConvertSidToStringSid. Therefore a string would be fine, the questions remains if we should use a wchar_t or char? The serialization is always ASCII only, so I don't see

Re: was: Re: WANTED: users of Right-To-Left languages who want proper support in LyX 1.5

2007-06-15 Thread Miki Dovrat
Dov Feldstern wrote: Dov Feldstern wrote: Miki Dovrat wrote: I was going to say, let the cursor always stay where it is, and the user will learn to press END (end of line) to move it to continue typing. It is logical, (not in the logical direction sense), expected and easily adapted to by

[patch] cursor position update, cursor often stays at old position

2007-06-15 Thread Stefan Schimanski
Here is a patch for the following problem: Write something in a Standard layout paragraph. Change it into Title. The cursor will stay at the old position until the cursor blink interval is over There are many more those cases: Try to insert a math delimiter (Alt- m (). The cursor

Re: [patch] cursor position update, cursor often stays at old position

2007-06-15 Thread Stefan Schimanski
The bug report: http://bugzilla.lyx.org/show_bug.cgi?id=3854 Stefan PGP.sig Description: Signierter Teil der Nachricht

Re: [patch] cursor position update, cursor often stays at old position

2007-06-15 Thread Stefan Schimanski
And one about the described general problem: http://bugzilla.lyx.org/ show_bug.cgi?id=3873 Stefan PGP.sig Description: Signierter Teil der Nachricht

Re: [PATCH] Bug 3860 Toc crash WITH child documents

2007-06-15 Thread Abdelrazak Younes
Richard Heck wrote: Idea for fix: Since the buffer_func.cpp version of loadLyXFile() is called from LyXView::loadLyXFile(), anyway, all the child doc stuff could be moved there. But I don't know this code terribly well. Abdel? Very good analysis Richard! The solution is to use the LFUN

Re: [PATCH] Bug 3860 Toc crash when loading a child documents

2007-06-15 Thread Abdelrazak Younes
Stefan Schimanski wrote: Tried it a bit with child documents. Looks fine. OK, thanks. Abdel.

Re: [PATCH] Bug 3860 Toc crash WITH child documents

2007-06-15 Thread Abdelrazak Younes
Abdelrazak Younes wrote: Richard Heck wrote: Idea for fix: Since the buffer_func.cpp version of loadLyXFile() is called from LyXView::loadLyXFile(), anyway, all the child doc stuff could be moved there. But I don't know this code terribly well. Abdel? Very good analysis Richard! The solution

Re: [PATCH] Bug 3860 Toc crash WITH child documents

2007-06-15 Thread Abdelrazak Younes
Richard Heck wrote: Idea for fix: Since the buffer_func.cpp version of loadLyXFile() is called from LyXView::loadLyXFile(), anyway, all the child doc stuff could be moved there. Of course you are right but I don't want to do that now because it will involves much more intrusive changes in

Re: [patch] cursor position update, cursor often stays at old position

2007-06-15 Thread Uwe Stöhr
Here is a patch for the following problem: Write something in a Standard layout paragraph. Change it into Title. The cursor will stay at the old position until the cursor blink interval is over I also noticed this problem since a while. The patch seems obvious and fixes the problems for

Re: [PATCH] Bug 3860 Toc crash WITH child documents

2007-06-15 Thread Richard Heck
Abdelrazak Younes wrote: Richard Heck wrote: Idea for fix: Since the buffer_func.cpp version of loadLyXFile() is called from LyXView::loadLyXFile(), anyway, all the child doc stuff could be moved there. But I don't know this code terribly well. Abdel? Very good analysis Richard! The solution

Re: [patch] cursor position update, cursor often stays at old position

2007-06-15 Thread Stefan Schimanski
I also noticed this problem since a while. The patch seems obvious and fixes the problems for me, so I give an OK. Will be away until Sunday/Monday. Feel free to commit it. Stefan PGP.sig Description: Signierter Teil der Nachricht

Re: [PATCH] Bug 3860 Toc crash WITH child documents

2007-06-15 Thread Richard Heck
Abdelrazak Younes wrote: Abdelrazak Younes wrote: Richard Heck wrote: Idea for fix: Since the buffer_func.cpp version of loadLyXFile() is called from LyXView::loadLyXFile(), anyway, all the child doc stuff could be moved there. But I don't know this code terribly well. Abdel? Very good

Re: [PATCH] Bug 3860 Toc crash WITH child documents

2007-06-15 Thread Abdelrazak Younes
Richard Heck wrote: Abdelrazak Younes wrote: Richard Heck wrote: Idea for fix: Since the buffer_func.cpp version of loadLyXFile() is called from LyXView::loadLyXFile(), anyway, all the child doc stuff could be moved there. But I don't know this code terribly well. Abdel? Very good analysis

Re: [PATCH] Bug 3860 Toc crash WITH child documents

2007-06-15 Thread Abdelrazak Younes
Richard Heck wrote: Abdelrazak Younes wrote: Abdelrazak Younes wrote: Richard Heck wrote: Idea for fix: Since the buffer_func.cpp version of loadLyXFile() is called from LyXView::loadLyXFile(), anyway, all the child doc stuff could be moved there. But I don't know this code terribly well.

Re: [patch] cursor position update, cursor often stays at old position

2007-06-15 Thread Abdelrazak Younes
Stefan Schimanski wrote: I also noticed this problem since a while. The patch seems obvious and fixes the problems for me, so I give an OK. Will be away until Sunday/Monday. Feel free to commit it. You have my OK if you want to commit now ;-) Abdel.

Re: [PATCH] Bug 3860 Toc crash WITH child documents

2007-06-15 Thread Richard Heck
Abdelrazak Younes wrote: Richard Heck wrote: What follows has to be const_castBuffer (buffer).dispatch(). No, I want rather to use the global dispatch method. So that would be: +lyx::dispatch(FuncRequest(LFUN_BUFFER_CHILD_OPEN, MSVC chose this one automatically for me but I'll do the

Re: RC2 coming soon

2007-06-15 Thread Edwin Leuven
José Matos wrote: Hi all, I will start looking to remaining issues before RC2, AFAIR there are two patches that I would like to have before the release, one by Jürgen that has a file format change and another related with reverting documents to 1.4. Is there anything else that I am

Re: [PATCH] Bug 3860 Toc crash WITH child documents

2007-06-15 Thread Richard Heck
Abdelrazak Younes wrote: Richard Heck wrote: What follows has to be const_castBuffer (buffer).dispatch(). No, I want rather to use the global dispatch method. So that would be: +lyx::dispatch(FuncRequest(LFUN_BUFFER_CHILD_OPEN, MSVC chose this one automatically for me but I'll do the

Re: [PATCH] Bug 3860 Toc crash WITH child documents

2007-06-15 Thread Abdelrazak Younes
Richard Heck wrote: Abdelrazak Younes wrote: Richard Heck wrote: What follows has to be const_castBuffer (buffer).dispatch(). No, I want rather to use the global dispatch method. So that would be: +lyx::dispatch(FuncRequest(LFUN_BUFFER_CHILD_OPEN, MSVC chose this one automatically for

Re: [patch] cursor position update, cursor often stays at old position

2007-06-15 Thread Uwe Stöhr
Stefan Schimanski schrieb: Will be away until Sunday/Monday. Feel free to commit it. Abdel gave his OK too, so committed it for you: http://www.lyx.org/trac/changeset/18799 regards Uwe

Re: [PATCH] Bug 3860 Toc crash WITH child documents

2007-06-15 Thread Richard Heck
Abdelrazak Younes wrote: Richard Heck wrote: Abdelrazak Younes wrote: Richard Heck wrote: What follows has to be const_castBuffer (buffer).dispatch(). No, I want rather to use the global dispatch method. So that would be: +lyx::dispatch(FuncRequest(LFUN_BUFFER_CHILD_OPEN, MSVC chose

Re: RC2 coming soon

2007-06-15 Thread Bo Peng
tearing of math panels using attached patch? We are also finding a second home for aspell dictionaries so that the windows installer will work even ftp.lyx.org is unusable. Bo

Re: [patch] tex2lyx crash when full path is given from commandline on Win32

2007-06-15 Thread hzluo
We've been relaxing the rules lately; support/ uses QtCore for a number of things and I think it would be much saner at this point to use QFileInfo, QProcess and QNetwork to replace our hand-made local code. If somebody steps up to encapsulate this Qt API in our API (forkedControllers, Socket and

Re: Sample test files and improved patch Re: [patch] Enable tex2lyx read back lyx exported .tex as much as possible

2007-06-15 Thread hzluo
I'm glad to receive so many feedbacks for my patch :-) And here I have to tell you some of my thoughts: 1. I made this patch is because I need it. I have to convert .tex files including those features, and convert between .tex and .lyx back and forth. I met these problems addressed in the

[patch] Space displayed after macro, #3705

2007-06-15 Thread Stefan Schimanski
Here is a patch for http://bugzilla.lyx.org/show_bug.cgi?id=3705. It adds the kerning method to a macro to inherit the kerning from the expanded form. Moreover the marker metrics calls are remove as they are not drawn anyway. Stefan Index: src/mathed/MathMacro.h

Re: WANTED: users of Right-To-Left languages who want proper support in LyX 1.5

2007-06-15 Thread Miki Dovrat
Hi, My comments are below Miki 3. If I have a Hebrew paragraph with an English word like ? English ? ? and I type continuously, the spaces are Hebrew. Now if I try to continue the Hebrew to the right of the English word, but after the Hebrew space, as to

Re: [patch] Language of Inset (bug 3011)

2007-06-15 Thread Dov Feldstern
Dov Feldstern wrote: Jean-Marc Lasgouttes wrote: "Dov" == Dov Feldstern <[EMAIL PROTECTED]> writes: Dov> Hi! attached find a very simple fix for Dov> http://bugzilla.lyx.org/show_bug.cgi?id=3011 (which is a Dov> regression relative to 1.3.X). The problem is that when typing Dov> some LTR in

was: Re: WANTED: users of Right-To-Left languages who want proper support in LyX 1.5

2007-06-15 Thread Dov Feldstern
Separating this into different issues, it's getting long... Miki Dovrat wrote: 3. If I have a Hebrew paragraph with an English word like ? English ? ? and I type continuously, the spaces are Hebrew. Now if I try to continue the Hebrew to the right of the English word, but after the

Re: 20% speedup of paragraph redraw with simple patch

2007-06-15 Thread Abdelrazak Younes
Andre Poenitz wrote: On Thu, Jun 14, 2007 at 05:49:53PM +0200, Abdelrazak Younes wrote: Moreover, it remains to be seen whether the map is faster in the cases where the container typically has at most 10 elements. It might be that a stupid plain loop is faster... Maybe not faster but a lot

Re: 20% speedup of paragraph redraw with simple patch

2007-06-15 Thread Martin Vermeer
On Thu, Jun 14, 2007 at 09:01:49PM +0200, Andre Poenitz wrote: > On Thu, Jun 14, 2007 at 05:05:32PM +0200, Stefan Schimanski wrote: > > I did some profiling of paragraph drawing. 20% of the whole time > > while inserting characters and redrawing the screen was taken by > > Paragraph::getInset

Re: WANTED: users of Right-To-Left languages who want proper support in LyX 1.5

2007-06-15 Thread Dov Feldstern
Miki Dovrat wrote: When moving across already written text, lyx, when spotting a move between \L and \R should move visually, i.e., to the end of the foreign text and go backwards (so the arrow keys move to the right direction), and change its language as well, again, unless explicitly

Re: was: Re: WANTED: users of Right-To-Left languages who want proper support in LyX 1.5

2007-06-15 Thread Abdelrazak Younes
Dov Feldstern wrote: , unless the user explicitly changes it with F12 (\language hebrew), the cursor will NOT MOVE, and the text will be added where it was, whether it was English or Hebrew. Again, this doesn't make sense when typing. It means after every insertion of an english word,

Re: WANTED: users of Right-To-Left languages who want proper support in LyX 1.5

2007-06-15 Thread Abdelrazak Younes
Miki Dovrat wrote: To sum up, I would like lyx, when it is inside a \L (English), to switch automatically to English, unless the user explicitly changes it with F12 (\language hebrew), the cursor will NOT MOVE, and the text will be added where it was, whether it was English or Hebrew. When

Re: WANTED: users of Right-To-Left languages who want proper support in LyX 1.5

2007-06-15 Thread Abdelrazak Younes
Dov Feldstern wrote: Miki Dovrat wrote: When moving across already written text, lyx, when spotting a move between \L and \R should move visually, i.e., to the end of the foreign text and go backwards (so the arrow keys move to the right direction), and change its language as well, again,

Re: WANTED: users of Right-To-Left languages who want proper support in LyX 1.5

2007-06-15 Thread Dov Feldstern
Miki Dovrat wrote: 6. I cannot enter an inline equation to the right of the English word. This looks like a bug. If you're coming from the english, then I think that the equation should also be "in english" (see next comment), and then what you want to do would work. Can you open a bug for

Re: 20% speedup of paragraph redraw with simple patch

2007-06-15 Thread Jean-Marc Lasgouttes
> "Dov" == Dov Feldstern <[EMAIL PROTECTED]> writes: Dov> Hmm, I just came across this yesterday when trying to figure out Dov> what was going on with bug 3011, and wondered about it. I'm not Dov> sure if this is what you mean or not, but it might be relevant... Dov>

Re: [patch] Language of Inset (bug 3011)

2007-06-15 Thread Jean-Marc Lasgouttes
> "Dov" == Dov Feldstern <[EMAIL PROTECTED]> writes: Dov> Attached is the patch using current_font. Is this Okay? The patch is definitely correct. Please apply. Dov> I actually wanted to solve this in a more complete way, by Dov> setting the font to current_font directly within Dov>

Spaces in Bidi part #2

2007-06-15 Thread Dov Feldstern
Okay, I'm starting a new thread for this issue. This is now bug 3870 in bugzilla (http://bugzilla.lyx.org/show_bug.cgi?id=3870). The problem: typing spaces at RTL/LTR boundaries does not always do what the user expects/wants. (The reason I opened a new bug, is that this really a different

Re: [patch] Language of Inset (bug 3011)

2007-06-15 Thread Dov Feldstern
Jean-Marc Lasgouttes wrote: "Dov" == Dov Feldstern <[EMAIL PROTECTED]> writes: Dov> Attached is the patch using current_font. Is this Okay? The patch is definitely correct. Please apply. Thanks, committed. Dov> Could the versions of insertInset which do not take a font be Dov> made

Re: WANTED: users of Right-To-Left languages who want proper support in LyX 1.5

2007-06-15 Thread Dov Feldstern
Dov Feldstern wrote: Miki Dovrat wrote: Are these solved with the above-mentioned fix? Is it already in svn? if not, where is the patch? I will check. See http://permalink.gmane.org/gmane.editors.lyx.devel/87817. Let's continue the discussion of this issue in response to that thread.

Re: [patch] Language of Inset (bug 3011)

2007-06-15 Thread Jean-Marc Lasgouttes
> "Dov" == Dov Feldstern <[EMAIL PROTECTED]> writes: Dov> In that case, it looks like there's only one other place where Dov> the form without a font is still used: Dov> Paragraph::checkBiblio(bool track_changes) Dov> I'm not familiar with this function at all. However, it is only Dov> used

Re: [PATCH-updated] Make HTML Export Work

2007-06-15 Thread José Matos
On Friday 15 June 2007 05:39:01 Richard Heck wrote: > Now seeking an OK to commit. > > Richard Richard has gave this some thought and has tested this thoroughly so I am inclined to give this my OK. Any objection? -- José Abílio

Re: [PATCH-updated] Make HTML Export Work

2007-06-15 Thread Jean-Marc Lasgouttes
> "Jean-Marc" == Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: Richard> The patch also includes some associated updates to the Richard> documentation. Jean-Marc> But not Extended.lyx. Forget this. This patch does not get rid of originaldir. JMarc

Re: [PATCH-updated] Make HTML Export Work

2007-06-15 Thread Jean-Marc Lasgouttes
> "José" == José Matos <[EMAIL PROTECTED]> writes: José> On Friday 15 June 2007 05:39:01 Richard Heck wrote: >> Now seeking an OK to commit. >> >> Richard José> Richard has gave this some thought and has tested this José> thoroughly so I am inclined to give this my OK. Any objection? Since

Re: [PATCH-updated] Make HTML Export Work

2007-06-15 Thread Enrico Forestieri
On Fri, Jun 15, 2007 at 12:39:01AM -0400, Richard Heck wrote: > This patch is now slightly updated. In place of the two scripts > tex4html_copy.py and dir_copy.py, there is now just one, ext_copy.py. > Without any optional arguments, this script acts like dir_copy.py did: > It copies all files

Re: [PATCH-updated] Make HTML Export Work

2007-06-15 Thread Jean-Marc Lasgouttes
> "Richard" == Richard Heck <[EMAIL PROTECTED]> writes: Richard> This new patch will allow easy handling of other converters, Richard> such as hevea (and if anyone knows what kinds of files it Richard> generates, let me know, and I'll add the definition to Richard> configure.py). The

  1   2   >