Re: [LyX/master] Fix typo found by coverity

2017-03-14 Thread Richard Heck
On 03/14/2017 09:28 AM, Jean-Marc Lasgouttes wrote: > Le 14/03/2017 à 04:41, Richard Heck a écrit : >> On 03/13/2017 12:05 PM, Jean-Marc Lasgouttes wrote: >>> Le 13/03/2017 à 16:18, Richard Heck a écrit : I'll move the formats variable to the singleton, too. That seems worth doing, yes,

Re: [LyX/master] Fix typo found by coverity

2017-03-14 Thread Jean-Marc Lasgouttes
Le 14/03/2017 à 04:41, Richard Heck a écrit : On 03/13/2017 12:05 PM, Jean-Marc Lasgouttes wrote: Le 13/03/2017 à 16:18, Richard Heck a écrit : I'll move the formats variable to the singleton, too. That seems worth doing, yes, and should be painless? I think it should be a bit long, but

Re: [LyX/master] Fix typo found by coverity

2017-03-14 Thread Jean-Marc Lasgouttes
Le 14/03/2017 à 04:41, Richard Heck a écrit : Done. Not too long, but definitely painless. Thanks. JMarc

Re: [LyX/master] Fix typo found by coverity

2017-03-13 Thread Richard Heck
On 03/13/2017 12:05 PM, Jean-Marc Lasgouttes wrote: > Le 13/03/2017 à 16:18, Richard Heck a écrit : >> I'll move the formats variable to the singleton, too. That seems worth >> doing, yes, and should be painless? > > I think it should be a bit long, but painless. Done. Not too long, but

Re: [LyX/master] Fix typo found by coverity

2017-03-13 Thread Jean-Marc Lasgouttes
Le 13/03/2017 à 16:18, Richard Heck a écrit : I'll move the formats variable to the singleton, too. That seems worth doing, yes, and should be painless? I think it should be a bit long, but painless. JMarc

Re: [LyX/master] Fix typo found by coverity

2017-03-13 Thread Richard Heck
On 03/13/2017 06:43 AM, Jean-Marc Lasgouttes wrote: > Le 07/03/2017 à 21:14, Richard Heck a écrit : >>> Actually there are other uses of the variable `formats' in >>> Formats.cpp, and I think that they are all incorrect (should be >>> formatlist). This will not matter in most cases, fortunately.

Re: [LyX/master] Fix typo found by coverity

2017-03-13 Thread Jean-Marc Lasgouttes
Le 07/03/2017 à 21:14, Richard Heck a écrit : Actually there are other uses of the variable `formats' in Formats.cpp, and I think that they are all incorrect (should be formatlist). This will not matter in most cases, fortunately. I will try to have a look at this. I did that at a2bfe0042d.

Re: [LyX/master] Fix typo found by coverity

2017-03-07 Thread Richard Heck
On 03/07/2017 06:16 AM, Jean-Marc Lasgouttes wrote: > Le 07/03/2017 à 12:08, Jean-Marc Lasgouttes a écrit : >> commit dc126bad0441eb8721043e597657d5c18bdf6c90 >> Author: Jean-Marc Lasgouttes >> Date: Tue Mar 7 12:02:54 2017 +0100 >> >> Fix typo found by coverity >> >>

Re: [LyX/master] Fix typo found by coverity

2017-03-07 Thread Jean-Marc Lasgouttes
Le 07/03/2017 à 12:08, Jean-Marc Lasgouttes a écrit : commit dc126bad0441eb8721043e597657d5c18bdf6c90 Author: Jean-Marc Lasgouttes Date: Tue Mar 7 12:02:54 2017 +0100 Fix typo found by coverity We were not testing for the right end(), although it is not sure that