Re: Spaces on RTL boundaries

2007-06-13 Thread Georg Baum
Dov Feldstern wrote: Attached is a new version of this patch, which uses the paragraph's language as the default language. It may not be perfect, but I think it's good enough, and it seems to work... I did not test it, but if it does what you say then it is correct AFAIK. Georg

Re: Spaces on RTL boundaries

2007-06-13 Thread Dov Feldstern
José Matos wrote: On Tuesday 12 June 2007 23:08:47 Dov Feldstern wrote: Opinions? You made it. :-) OK. Thanks! Dov Committed.

Re: Spaces on RTL boundaries

2007-06-13 Thread Georg Baum
Dov Feldstern wrote: > Attached is a new version of this patch, which uses the paragraph's > language as the default language. It may not be perfect, but I think > it's good enough, and it seems to work... I did not test it, but if it does what you say then it is correct AFAIK. Georg

Re: Spaces on RTL boundaries

2007-06-13 Thread Dov Feldstern
José Matos wrote: On Tuesday 12 June 2007 23:08:47 Dov Feldstern wrote: Opinions? You made it. :-) OK. Thanks! Dov Committed.

Re: Spaces on RTL boundaries

2007-06-12 Thread Georg Baum
Am Montag, 11. Juni 2007 23:38 schrieb Dov Feldstern: Attached is a patch, using Georg's suggestion (refactoring). This is the first time I'm doing a format change, so please make sure that I'm doing everything which should be done in this case... Looks perfect. Georg

Re: Spaces on RTL boundaries

2007-06-12 Thread Dov Feldstern
Georg Baum wrote: Am Montag, 11. Juni 2007 23:38 schrieb Dov Feldstern: Attached is a patch, using Georg's suggestion (refactoring). This is the first time I'm doing a format change, so please make sure that I'm doing everything which should be done in this case... Looks perfect. Georg

Re: Spaces on RTL boundaries

2007-06-12 Thread Dov Feldstern
Dov Feldstern wrote: Georg Baum wrote: Am Montag, 11. Juni 2007 23:38 schrieb Dov Feldstern: Attached is a patch, using Georg's suggestion (refactoring). This is the first time I'm doing a format change, so please make sure that I'm doing everything which should be done in this case...

Re: Spaces on RTL boundaries

2007-06-12 Thread José Matos
On Tuesday 12 June 2007 21:38:49 Dov Feldstern wrote: I should be setting the language to the paragraph's language, not to default. How do I get the paragraph's language in lyx2lyx? That function is not defined but it should be easy to do. Either the paragraph has that option after

Re: Spaces on RTL boundaries

2007-06-12 Thread José Matos
On Tuesday 12 June 2007 23:08:47 Dov Feldstern wrote: Opinions? You made it. :-) OK. Thanks! Dov -- José Abílio

Re: Spaces on RTL boundaries

2007-06-12 Thread Georg Baum
Am Montag, 11. Juni 2007 23:38 schrieb Dov Feldstern: > Attached is a patch, using Georg's suggestion (refactoring). This is the > first time I'm doing a format change, so please make sure that I'm doing > everything which should be done in this case... Looks perfect. Georg

Re: Spaces on RTL boundaries

2007-06-12 Thread Dov Feldstern
Georg Baum wrote: Am Montag, 11. Juni 2007 23:38 schrieb Dov Feldstern: Attached is a patch, using Georg's suggestion (refactoring). This is the first time I'm doing a format change, so please make sure that I'm doing everything which should be done in this case... Looks perfect. Georg

Re: Spaces on RTL boundaries

2007-06-12 Thread Dov Feldstern
Dov Feldstern wrote: Georg Baum wrote: Am Montag, 11. Juni 2007 23:38 schrieb Dov Feldstern: Attached is a patch, using Georg's suggestion (refactoring). This is the first time I'm doing a format change, so please make sure that I'm doing everything which should be done in this case...

Re: Spaces on RTL boundaries

2007-06-12 Thread José Matos
On Tuesday 12 June 2007 21:38:49 Dov Feldstern wrote: > I should be setting the language to the paragraph's language, not to > "default". How do I get the paragraph's language in lyx2lyx? That function is not defined but it should be easy to do. Either the paragraph has that option after

Re: Spaces on RTL boundaries

2007-06-12 Thread José Matos
On Tuesday 12 June 2007 23:08:47 Dov Feldstern wrote: > Opinions? You made it. :-) OK. > Thanks! > Dov -- José Abílio

Re: Spaces on RTL boundaries

2007-06-11 Thread Georg Baum
Dov Feldstern wrote: *** I now see what the problem is! What we need is *exactly* the change of format 259; but in lyx2lyx, the \\lang property wasn't included for some reason! The attached patch fixes this, and the output is now OK (i.e., with this patch, a file created from before the

Re: Spaces on RTL boundaries

2007-06-11 Thread Dov Feldstern
Georg Baum wrote: Dov Feldstern wrote: *** I now see what the problem is! What we need is *exactly* the change of format 259; but in lyx2lyx, the \\lang property wasn't included for some reason! The attached patch fixes this, and the output is now OK (i.e., with this patch, a file created from

Re: Spaces on RTL boundaries

2007-06-11 Thread Georg Baum
Dov Feldstern wrote: > *** I now see what the problem is! What we need is *exactly* the change > of format 259; but in lyx2lyx, the \\lang property wasn't included for > some reason! The attached patch fixes this, and the output is now OK > (i.e., with this patch, a file created from before the

Re: Spaces on RTL boundaries

2007-06-11 Thread Dov Feldstern
Georg Baum wrote: Dov Feldstern wrote: *** I now see what the problem is! What we need is *exactly* the change of format 259; but in lyx2lyx, the \\lang property wasn't included for some reason! The attached patch fixes this, and the output is now OK (i.e., with this patch, a file created from

Re: Spaces on RTL boundaries

2007-06-09 Thread Dov Feldstern
Sorry --- wrong patch attached! Here's the correct one (rather shorter ;) ) Dov Feldstern wrote: Georg Baum wrote: Stefan Schimanski wrote: Then the question is only from which file format revision we start with a lyx2lyx filter: from the change of the exporting behavior or from the fix from

Re: Spaces on RTL boundaries

2007-06-09 Thread Dov Feldstern
Georg Baum wrote: Stefan Schimanski wrote: Then the question is only from which file format revision we start with a lyx2lyx filter: from the change of the exporting behavior or from the fix from today and the last days... That depends on the format when the change happened. If it was during

Re: Spaces on RTL boundaries

2007-06-09 Thread Dov Feldstern
Sorry --- wrong patch attached! Here's the correct one (rather shorter ;) ) Dov Feldstern wrote: Georg Baum wrote: Stefan Schimanski wrote: Then the question is only from which file format revision we start with a lyx2lyx filter: from the change of the exporting behavior or from the fix from

Re: Spaces on RTL boundaries

2007-06-09 Thread Dov Feldstern
Georg Baum wrote: Stefan Schimanski wrote: Then the question is only from which file format revision we start with a lyx2lyx filter: from the change of the exporting behavior or from the fix from today and the last days... That depends on the format when the change happened. If it was during

Re: Spaces on RTL boundaries

2007-06-08 Thread Martin Vermeer
On Fri, 08 Jun 2007 06:51:49 +0200 Andre Poenitz [EMAIL PROTECTED] wrote: On Thu, Jun 07, 2007 at 11:54:55AM +0200, Stefan Schimanski wrote: Ran Rutenberg wrote: Hi, I tried to write a bidi file using the four patches and I didn't see a big difference in writing with the patches and

Re: Spaces on RTL boundaries

2007-06-08 Thread Dov Feldstern
Andre Poenitz wrote: On Thu, Jun 07, 2007 at 11:54:55AM +0200, Stefan Schimanski wrote: Ran Rutenberg wrote: Hi, I tried to write a bidi file using the four patches and I didn't see a big difference in writing with the patches and without them. One small problem I did find is that when

Re: Spaces on RTL boundaries

2007-06-08 Thread Dov Feldstern
Martin Vermeer wrote: On Fri, 08 Jun 2007 06:51:49 +0200 Andre Poenitz [EMAIL PROTECTED] wrote: On Thu, Jun 07, 2007 at 11:54:55AM +0200, Stefan Schimanski wrote: Ran Rutenberg wrote: Hi, I tried to write a bidi file using the four patches and I didn't see a big difference in writing with

Re: Spaces on RTL boundaries

2007-06-08 Thread Stefan Schimanski
Am 08.06.2007 um 09:21 schrieb Dov Feldstern: Martin Vermeer wrote: On Fri, 08 Jun 2007 06:51:49 +0200 Andre Poenitz [EMAIL PROTECTED] wrote: On Thu, Jun 07, 2007 at 11:54:55AM +0200, Stefan Schimanski wrote: Ran Rutenberg wrote: Hi, I tried to write a bidi file using the four patches and

Re: Spaces on RTL boundaries

2007-06-08 Thread Stefan Schimanski
I like it! The only thing missing is the EPM which works with the patch. I added this in set_font_spaces_magic.patch. Moreover I made your patch a bit simpler. I hope it's ok like that. Order to apply: rtl_spaces.patch set_font_spaces_magic.patch space_lang_change.patch Stefan Index:

Re: Spaces on RTL boundaries

2007-06-08 Thread Stefan Schimanski
I like it! The only thing missing is the EPM which works with the patch. I added this in set_font_spaces_magic.patch. Moreover I made your patch a bit simpler. I hope it's ok like that. Order to apply: rtl_spaces.patch set_font_spaces_magic.patch space_lang_change.patch Stefan

Re: Spaces on RTL boundaries

2007-06-08 Thread Dov Feldstern
Stefan Schimanski wrote: I like it! The only thing missing is the EPM which works with the patch. I added this in set_font_spaces_magic.patch. Moreover I made your patch a bit simpler. I hope it's ok like that. I incorporated some of the changes you proposed. But the main change you made I'd

Re: Spaces on RTL boundaries

2007-06-08 Thread Stefan Schimanski
Am 08.06.2007 um 13:30 schrieb Dov Feldstern: Stefan Schimanski wrote: I like it! The only thing missing is the EPM which works with the patch. I added this in set_font_spaces_magic.patch. Moreover I made your patch a bit simpler. I hope it's ok like that. I incorporated some of the

Re: Spaces on RTL boundaries

2007-06-08 Thread Dov Feldstern
Stefan Schimanski wrote: Am 08.06.2007 um 13:30 schrieb Dov Feldstern: Stefan Schimanski wrote: I like it! The only thing missing is the EPM which works with the patch. I added this in set_font_spaces_magic.patch. Moreover I made your patch a bit simpler. I hope it's ok like that. I

Re: Spaces on RTL boundaries

2007-06-08 Thread Dov Feldstern
Stefan Schimanski wrote: On top of those, we can continue experimenting with the EPM --- though again, I'm not sure anymore that it's really necessary, and I also agree somewhat with the issues that Andre' raised... I think you are right. EPM can come later. We should put in your patch ASAP.

Re: Spaces on RTL boundaries

2007-06-08 Thread Stefan Schimanski
Right, sorry... F12 is in the hebrew bindings, and all it does is bind to language hebrew (which toggles back and forth between Hebrew and the primary language, as set in the preferences; note that this is *not* the document language, but the default language). I'm not sure what switching

Re: Spaces on RTL boundaries

2007-06-08 Thread Stefan Schimanski
I applied the Bidi patch to disable special space handling and Dov's insertion magic to switch the language of the space in front of the boundary. With this one I think RC2 will finally have usable RTL support now. Please check it out and report problems. We committed quite a lot of code

Re: Spaces on RTL boundaries

2007-06-08 Thread Stefan Schimanski
Yes, I think it is what we want. The space that was typed at the end of the Hebrew was meant to separate it from the next word. By switching its language, we achieve exactly that. But here you press space F12 space. And what you mean is that you press space to separate words, switch to

Re: Spaces on RTL boundaries

2007-06-08 Thread José Matos
On Friday 08 June 2007 15:01:18 Stefan Schimanski wrote: Dov's patch has my OK. OK. -- José Abílio

Re: Spaces on RTL boundaries

2007-06-08 Thread Dov Feldstern
Stefan Schimanski wrote: Ok, EPM is another issue, maybe even a matter of taste one could enable/disable in the preferences. But first we should get this into svn. José? Dov's patch has my OK. Great. Next (but the patch shouldn't wait for this!), we have to look into lyx2lyx for converting

Re: Spaces on RTL boundaries

2007-06-08 Thread Stefan Schimanski
Am 08.06.2007 um 16:16 schrieb Dov Feldstern: Stefan Schimanski wrote: Ok, EPM is another issue, maybe even a matter of taste one could enable/disable in the preferences. But first we should get this into svn. José? Dov's patch has my OK. Great. Next (but the patch shouldn't wait for

Re: Spaces on RTL boundaries

2007-06-08 Thread Georg Baum
Stefan Schimanski wrote: Am 08.06.2007 um 16:16 schrieb Dov Feldstern: Stefan Schimanski wrote: Ok, EPM is another issue, maybe even a matter of taste one could enable/disable in the preferences. But first we should get this into svn. José? Dov's patch has my OK. Great. Next (but the

Re: Spaces on RTL boundaries

2007-06-08 Thread Stefan Schimanski
Am 08.06.2007 um 18:20 schrieb Georg Baum: Stefan Schimanski wrote: Am 08.06.2007 um 16:16 schrieb Dov Feldstern: Stefan Schimanski wrote: Ok, EPM is another issue, maybe even a matter of taste one could enable/disable in the preferences. But first we should get this into svn. José?

Re: Spaces on RTL boundaries

2007-06-08 Thread Georg Baum
Stefan Schimanski wrote: No, our patches did not change the file format. The file format was changed long ago (don't ask me exactly, Dov might know better). If you want to implement something in lyx2lyx then you need to know when exactly that happened, because that will determine the formats X

Re: Spaces on RTL boundaries

2007-06-08 Thread Georg Baum
Stefan Schimanski wrote: Then the question is only from which file format revision we start with a lyx2lyx filter: from the change of the exporting behavior or from the fix from today and the last days... That depends on the format when the change happened. If it was during the 1.5

Re: Spaces on RTL boundaries

2007-06-08 Thread Stefan Schimanski
No, our patches did not change the file format. The file format was changed long ago (don't ask me exactly, Dov might know better). If you want to implement something in lyx2lyx then you need to know when exactly that happened, because that will determine the formats X and X+1 between

Re: Spaces on RTL boundaries

2007-06-08 Thread Martin Vermeer
On Fri, 08 Jun 2007 06:51:49 +0200 Andre Poenitz <[EMAIL PROTECTED]> wrote: > On Thu, Jun 07, 2007 at 11:54:55AM +0200, Stefan Schimanski wrote: > > Ran Rutenberg wrote: > > >Hi, > > > > > >I tried to write a bidi file using the four patches and I didn't see > > >a big difference in writing with

Re: Spaces on RTL boundaries

2007-06-08 Thread Dov Feldstern
Andre Poenitz wrote: On Thu, Jun 07, 2007 at 11:54:55AM +0200, Stefan Schimanski wrote: Ran Rutenberg wrote: Hi, I tried to write a bidi file using the four patches and I didn't see a big difference in writing with the patches and without them. One small problem I did find is that when

Re: Spaces on RTL boundaries

2007-06-08 Thread Dov Feldstern
Martin Vermeer wrote: On Fri, 08 Jun 2007 06:51:49 +0200 Andre Poenitz <[EMAIL PROTECTED]> wrote: On Thu, Jun 07, 2007 at 11:54:55AM +0200, Stefan Schimanski wrote: Ran Rutenberg wrote: Hi, I tried to write a bidi file using the four patches and I didn't see a big difference in writing with

Re: Spaces on RTL boundaries

2007-06-08 Thread Stefan Schimanski
Am 08.06.2007 um 09:21 schrieb Dov Feldstern: Martin Vermeer wrote: On Fri, 08 Jun 2007 06:51:49 +0200 Andre Poenitz <[EMAIL PROTECTED]> wrote: On Thu, Jun 07, 2007 at 11:54:55AM +0200, Stefan Schimanski wrote: Ran Rutenberg wrote: Hi, I tried to write a bidi file using the four patches

Re: Spaces on RTL boundaries

2007-06-08 Thread Stefan Schimanski
I like it! The only thing missing is the EPM which works with the patch. I added this in set_font_spaces_magic.patch. Moreover I made your patch a bit simpler. I hope it's ok like that. Order to apply: rtl_spaces.patch set_font_spaces_magic.patch space_lang_change.patch Stefan Index:

Re: Spaces on RTL boundaries

2007-06-08 Thread Stefan Schimanski
I like it! The only thing missing is the EPM which works with the patch. I added this in set_font_spaces_magic.patch. Moreover I made your patch a bit simpler. I hope it's ok like that. Order to apply: rtl_spaces.patch set_font_spaces_magic.patch space_lang_change.patch Stefan

Re: Spaces on RTL boundaries

2007-06-08 Thread Dov Feldstern
Stefan Schimanski wrote: I like it! The only thing missing is the EPM which works with the patch. I added this in set_font_spaces_magic.patch. Moreover I made your patch a bit simpler. I hope it's ok like that. I incorporated some of the changes you proposed. But the main change you made I'd

Re: Spaces on RTL boundaries

2007-06-08 Thread Stefan Schimanski
Am 08.06.2007 um 13:30 schrieb Dov Feldstern: Stefan Schimanski wrote: I like it! The only thing missing is the EPM which works with the patch. I added this in set_font_spaces_magic.patch. Moreover I made your patch a bit simpler. I hope it's ok like that. I incorporated some of the

Re: Spaces on RTL boundaries

2007-06-08 Thread Dov Feldstern
Stefan Schimanski wrote: Am 08.06.2007 um 13:30 schrieb Dov Feldstern: Stefan Schimanski wrote: I like it! The only thing missing is the EPM which works with the patch. I added this in set_font_spaces_magic.patch. Moreover I made your patch a bit simpler. I hope it's ok like that. I

Re: Spaces on RTL boundaries

2007-06-08 Thread Dov Feldstern
Stefan Schimanski wrote: On top of those, we can continue experimenting with the EPM --- though again, I'm not sure anymore that it's really necessary, and I also agree somewhat with the issues that Andre' raised... I think you are right. EPM can come later. We should put in your patch ASAP.

Re: Spaces on RTL boundaries

2007-06-08 Thread Stefan Schimanski
Right, sorry... F12 is in the hebrew bindings, and all it does is bind to "language hebrew" (which toggles back and forth between Hebrew and the primary language, as set in the preferences; note that this is *not* the document language, but the default language). I'm not sure what

Re: Spaces on RTL boundaries

2007-06-08 Thread Stefan Schimanski
I applied the Bidi patch to disable special space handling and Dov's insertion magic to switch the language of the space in front of the boundary. With this one I think RC2 will finally have usable RTL support now. Please check it out and report problems. We committed quite a lot of code

Re: Spaces on RTL boundaries

2007-06-08 Thread Stefan Schimanski
Yes, I think it is what we want. The space that was typed at the end of the Hebrew was meant to separate it from the next word. By switching its language, we achieve exactly that. But here you press space F12 space. And what you mean is that you press space to separate words, switch to

Re: Spaces on RTL boundaries

2007-06-08 Thread José Matos
On Friday 08 June 2007 15:01:18 Stefan Schimanski wrote: > Dov's patch has my OK. OK. -- José Abílio

Re: Spaces on RTL boundaries

2007-06-08 Thread Dov Feldstern
Stefan Schimanski wrote: Ok, EPM is another issue, maybe even a matter of taste one could enable/disable in the preferences. But first we should get this into svn. José? Dov's patch has my OK. Great. Next (but the patch shouldn't wait for this!), we have to look into lyx2lyx for converting

Re: Spaces on RTL boundaries

2007-06-08 Thread Stefan Schimanski
Am 08.06.2007 um 16:16 schrieb Dov Feldstern: Stefan Schimanski wrote: Ok, EPM is another issue, maybe even a matter of taste one could enable/disable in the preferences. But first we should get this into svn. José? Dov's patch has my OK. Great. Next (but the patch shouldn't wait for

Re: Spaces on RTL boundaries

2007-06-08 Thread Georg Baum
Stefan Schimanski wrote: > > Am 08.06.2007 um 16:16 schrieb Dov Feldstern: > >> Stefan Schimanski wrote: >>> Ok, EPM is another issue, maybe even a matter of taste one could >>> enable/disable in the preferences. But first we should get this >>> into svn. José? Dov's patch has my OK. >> >>

Re: Spaces on RTL boundaries

2007-06-08 Thread Stefan Schimanski
Am 08.06.2007 um 18:20 schrieb Georg Baum: Stefan Schimanski wrote: Am 08.06.2007 um 16:16 schrieb Dov Feldstern: Stefan Schimanski wrote: Ok, EPM is another issue, maybe even a matter of taste one could enable/disable in the preferences. But first we should get this into svn. José?

Re: Spaces on RTL boundaries

2007-06-08 Thread Georg Baum
Stefan Schimanski wrote: > No, our patches did not change the file format. The file format was > changed long ago (don't ask me exactly, Dov might know better). If you want to implement something in lyx2lyx then you need to know when exactly that happened, because that will determine the formats

Re: Spaces on RTL boundaries

2007-06-08 Thread Georg Baum
Stefan Schimanski wrote: > Then the question is only from which file format revision we start > with a lyx2lyx filter: from the change of the exporting behavior or > from the fix from today and the last days... That depends on the format when the change happened. If it was during the 1.5

Re: Spaces on RTL boundaries

2007-06-08 Thread Stefan Schimanski
No, our patches did not change the file format. The file format was changed long ago (don't ask me exactly, Dov might know better). If you want to implement something in lyx2lyx then you need to know when exactly that happened, because that will determine the formats X and X+1 between

Re: Spaces on RTL boundaries

2007-06-07 Thread Ran Rutenberg
Hi, I tried to write a bidi file using the four patches and I didn't see a big difference in writing with the patches and without them. One small problem I did find is that when writing a word in a RTL language (the document should be a RTL document) then switching to a LTR language and writing a

Re: Spaces on RTL boundaries

2007-06-07 Thread Stefan Schimanski
Stefan, I like it! :) I haven't gone over the code at all yet, I hope to be able to do that over the weekend, maybe. But in terms of the behavior --- I like it a lot. And it solves all of the related crashes that I know of. And I think that it's the right approach in terms of not using any

Re: Spaces on RTL boundaries

2007-06-07 Thread Stefan Schimanski
Ran Rutenberg wrote: Hi, I tried to write a bidi file using the four patches and I didn't see a big difference in writing with the patches and without them. One small problem I did find is that when writing a word in a RTL language (the document should be a RTL document) then switching to a LTR

Re: Spaces on RTL boundaries

2007-06-07 Thread Stefan Schimanski
Hi! I cleaned up the patches a bit more. * Finally removed Text::bidi (its global status was not necessary anymore after the no_bidi_isboundary patch), see local_bidi.patch * Fixed the behavior if RTL is disabled in the preference dialog * Fixed the EPM. Try out the ABC[ DEF] ghi example

Re: Spaces on RTL boundaries

2007-06-07 Thread José Matos
On Thursday 07 June 2007 14:19:41 Stefan Schimanski wrote: Order to apply: no_bidi_isboundary.patch no_bidi_setcurrentfont.patch local_bidi.patch cursor_get_font.patch rtl_spaces.patch What is missing to apply from this set? Stefan -- José Abílio

Re: Spaces on RTL boundaries

2007-06-07 Thread Stefan Schimanski
Am 07.06.2007 um 22:29 schrieb José Matos: On Thursday 07 June 2007 14:19:41 Stefan Schimanski wrote: Order to apply: no_bidi_isboundary.patch no_bidi_setcurrentfont.patch local_bidi.patch cursor_get_font.patch rtl_spaces.patch What is missing to apply from this set? Just the last one.

Re: Spaces on RTL boundaries

2007-06-07 Thread José Matos
On Thursday 07 June 2007 21:41:45 Stefan Schimanski wrote: Just the last one. Want to hear some report by people here in the   thread. Then it can go in. That is fair. Stefan -- José Abílio

Re: Spaces on RTL boundaries

2007-06-07 Thread Dov Feldstern
Stefan Schimanski wrote: Am 07.06.2007 um 22:29 schrieb José Matos: On Thursday 07 June 2007 14:19:41 Stefan Schimanski wrote: Order to apply: no_bidi_isboundary.patch no_bidi_setcurrentfont.patch local_bidi.patch cursor_get_font.patch rtl_spaces.patch What is missing to apply from this

Re: Spaces on RTL boundaries

2007-06-07 Thread Stefan Schimanski
Am 07.06.2007 um 22:51 schrieb Dov Feldstern: Stefan Schimanski wrote: Am 07.06.2007 um 22:29 schrieb José Matos: On Thursday 07 June 2007 14:19:41 Stefan Schimanski wrote: Order to apply: no_bidi_isboundary.patch no_bidi_setcurrentfont.patch local_bidi.patch cursor_get_font.patch

Re: Spaces on RTL boundaries

2007-06-07 Thread Dov Feldstern
Stefan Schimanski wrote: Guy in the other thread prefers some magic here that the first space is moved to the other side (so in fact the LyX 1.3 behavior. What do you think? We could probably implement such a magic in the insertChar handler. Right, and so does Ran. Attached is a patch

Re: Spaces on RTL boundaries

2007-06-07 Thread Dov Feldstern
Sorry, please use the corrected patch attached... Dov Feldstern wrote: Stefan Schimanski wrote: Guy in the other thread prefers some magic here that the first space is moved to the other side (so in fact the LyX 1.3 behavior. What do you think? We could probably implement such a magic in

Re: Spaces on RTL boundaries

2007-06-07 Thread Andre Poenitz
On Thu, Jun 07, 2007 at 11:54:55AM +0200, Stefan Schimanski wrote: Ran Rutenberg wrote: Hi, I tried to write a bidi file using the four patches and I didn't see a big difference in writing with the patches and without them. One small problem I did find is that when writing a word in a RTL

Re: Spaces on RTL boundaries

2007-06-07 Thread Ran Rutenberg
Hi, I tried to write a bidi file using the four patches and I didn't see a big difference in writing with the patches and without them. One small problem I did find is that when writing a word in a RTL language (the document should be a RTL document) then switching to a LTR language and writing a

Re: Spaces on RTL boundaries

2007-06-07 Thread Stefan Schimanski
Stefan, I like it! :) I haven't gone over the code at all yet, I hope to be able to do that over the weekend, maybe. But in terms of the behavior --- I like it a lot. And it solves all of the related crashes that I know of. And I think that it's the right approach in terms of not using any

Re: Spaces on RTL boundaries

2007-06-07 Thread Stefan Schimanski
Ran Rutenberg wrote: Hi, I tried to write a bidi file using the four patches and I didn't see a big difference in writing with the patches and without them. One small problem I did find is that when writing a word in a RTL language (the document should be a RTL document) then switching to a LTR

Re: Spaces on RTL boundaries

2007-06-07 Thread Stefan Schimanski
Hi! I cleaned up the patches a bit more. * Finally removed Text::bidi (its global status was not necessary anymore after the no_bidi_isboundary patch), see local_bidi.patch * Fixed the behavior if RTL is disabled in the preference dialog * Fixed the EPM. Try out the "ABC[ DEF] ghi" example

Re: Spaces on RTL boundaries

2007-06-07 Thread José Matos
On Thursday 07 June 2007 14:19:41 Stefan Schimanski wrote: > Order to apply: > > no_bidi_isboundary.patch > no_bidi_setcurrentfont.patch > local_bidi.patch > cursor_get_font.patch > rtl_spaces.patch What is missing to apply from this set? > Stefan -- José Abílio

Re: Spaces on RTL boundaries

2007-06-07 Thread Stefan Schimanski
Am 07.06.2007 um 22:29 schrieb José Matos: On Thursday 07 June 2007 14:19:41 Stefan Schimanski wrote: Order to apply: no_bidi_isboundary.patch no_bidi_setcurrentfont.patch local_bidi.patch cursor_get_font.patch rtl_spaces.patch What is missing to apply from this set? Just the last one.

Re: Spaces on RTL boundaries

2007-06-07 Thread José Matos
On Thursday 07 June 2007 21:41:45 Stefan Schimanski wrote: > Just the last one. Want to hear some report by people here in the   > thread. Then it can go in. That is fair. > Stefan -- José Abílio

Re: Spaces on RTL boundaries

2007-06-07 Thread Dov Feldstern
Stefan Schimanski wrote: Am 07.06.2007 um 22:29 schrieb José Matos: On Thursday 07 June 2007 14:19:41 Stefan Schimanski wrote: Order to apply: no_bidi_isboundary.patch no_bidi_setcurrentfont.patch local_bidi.patch cursor_get_font.patch rtl_spaces.patch What is missing to apply from this

Re: Spaces on RTL boundaries

2007-06-07 Thread Stefan Schimanski
Am 07.06.2007 um 22:51 schrieb Dov Feldstern: Stefan Schimanski wrote: Am 07.06.2007 um 22:29 schrieb José Matos: On Thursday 07 June 2007 14:19:41 Stefan Schimanski wrote: Order to apply: no_bidi_isboundary.patch no_bidi_setcurrentfont.patch local_bidi.patch cursor_get_font.patch

Re: Spaces on RTL boundaries

2007-06-07 Thread Dov Feldstern
Stefan Schimanski wrote: Guy in the other thread prefers some magic here that the first space is moved to the other side (so in fact the LyX 1.3 behavior. What do you think? We could probably implement such a magic in the insertChar handler. Right, and so does Ran. Attached is a patch

Re: Spaces on RTL boundaries

2007-06-07 Thread Dov Feldstern
Sorry, please use the corrected patch attached... Dov Feldstern wrote: Stefan Schimanski wrote: Guy in the other thread prefers some magic here that the first space is moved to the other side (so in fact the LyX 1.3 behavior. What do you think? We could probably implement such a magic in

Re: Spaces on RTL boundaries

2007-06-07 Thread Andre Poenitz
On Thu, Jun 07, 2007 at 11:54:55AM +0200, Stefan Schimanski wrote: > Ran Rutenberg wrote: > >Hi, > > > >I tried to write a bidi file using the four patches and I didn't see > >a big difference in writing with the patches and without them. One > >small problem I did find is that when writing a word

Spaces on RTL boundaries

2007-06-06 Thread Stefan Schimanski
Continuing the discussion about the space issue here. I have implemented Georg's idea/hint to allow spaces on both sides of the RTL/LTR boundary, but let the empty-paragraph-mechanism (EPM, the algorithm which among other things kills double spaces) take care of double spaces around

Re: Spaces on RTL boundaries

2007-06-06 Thread Dov Feldstern
Stefan Schimanski wrote: Continuing the discussion about the space issue here. I have implemented Georg's idea/hint to allow spaces on both sides of the RTL/LTR boundary, but let the empty-paragraph-mechanism (EPM, the algorithm which among other things kills double spaces) take care of

Spaces on RTL boundaries

2007-06-06 Thread Stefan Schimanski
Continuing the discussion about the space issue here. I have implemented Georg's idea/hint to allow spaces on both sides of the RTL/LTR boundary, but let the empty-paragraph-mechanism (EPM, the algorithm which among other things kills double spaces) take care of double spaces around

Re: Spaces on RTL boundaries

2007-06-06 Thread Dov Feldstern
Stefan Schimanski wrote: Continuing the discussion about the space issue here. I have implemented Georg's idea/hint to allow spaces on both sides of the RTL/LTR boundary, but let the empty-paragraph-mechanism (EPM, the algorithm which among other things kills double spaces) take care of