Re: New Defects reported by Coverity Scan for LyX

2020-08-25 Thread Stephan Witt
Am 25.08.2020 um 11:40 schrieb Jean-Marc Lasgouttes : > > Le 25/08/2020 à 11:06, Stephan Witt a écrit : >> Next patch is the real change for #6401. I’d like to apply it soon. Any >> objections or possible improvements? > > It is difficult to understand what it does by reading it, and your

Re: Size of space insets seem way too small in master

2020-08-25 Thread Scott Kostyshak
On Tue, Aug 25, 2020 at 06:41:50PM +0200, Jean-Marc Lasgouttes wrote: > Le 25/08/2020 à 18:35, Scott Kostyshak a écrit : > > This is a slippery slope [1]. > > You mean like when we added support for C++11 and now everybody is forced to > use it? It's a plot! Yes another slippery slope. What's

Re: Size of space insets seem way too small in master

2020-08-25 Thread Jean-Marc Lasgouttes
Le 25/08/2020 à 18:35, Scott Kostyshak a écrit : This is a slippery slope [1]. You mean like when we added support for C++11 and now everybody is forced to use it? It's a plot! JMarc -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: lyx2lyx roundtrip test failing with BibTeX errors

2020-08-25 Thread Scott Kostyshak
On Mon, Aug 24, 2020 at 01:02:36AM -0400, Scott Kostyshak wrote: > The following test fails for me: > > > export/templates/Articles/American_Psychological_Association_%28APA%29,_v._7_lyx22 > (Failed) > > To reproduce: > > lyx -e lyx22x

Re: Size of space insets seem way too small in master

2020-08-25 Thread Scott Kostyshak
On Tue, Aug 25, 2020 at 05:11:36PM +0200, Jean-Marc Lasgouttes wrote: > Le 25/08/2020 à 17:08, Pavel Sanda a écrit : > > On Tue, Aug 25, 2020 at 05:06:10PM +0200, Jean-Marc Lasgouttes wrote: > > > > I never saw problem with solution 1, what is the drawback of it? > > > > Maybe Scott has some

Re: Size of space insets seem way too small in master

2020-08-25 Thread Jean-Marc Lasgouttes
Le 25/08/2020 à 17:08, Pavel Sanda a écrit : On Tue, Aug 25, 2020 at 05:06:10PM +0200, Jean-Marc Lasgouttes wrote: I never saw problem with solution 1, what is the drawback of it? Maybe Scott has some opinion. Look closely at the selected one in my second attachment. It overflows on the

Re: Size of space insets seem way too small in master

2020-08-25 Thread Pavel Sanda
On Tue, Aug 25, 2020 at 05:06:10PM +0200, Jean-Marc Lasgouttes wrote: > >I never saw problem with solution 1, what is the drawback of it? > >Maybe Scott has some opinion. > > Look closely at the selected one in my second attachment. It overflows on > the right. Sorry I was not clear. I noticed

Re: Size of space insets seem way too small in master

2020-08-25 Thread Jean-Marc Lasgouttes
Le 25/08/2020 à 16:23, Pavel Sanda a écrit : On Tue, Aug 25, 2020 at 04:12:20PM +0200, Jean-Marc Lasgouttes wrote: Le 25/08/2020 ?? 16:03, Pavel Sanda a écrit : On Tue, Aug 25, 2020 at 03:20:55PM +0200, Jean-Marc Lasgouttes wrote: see the screenshot in attachment. first char is thin line,

Re: Non-pointed rectangle corners

2020-08-25 Thread Jean-Marc Lasgouttes
Le 06/08/2020 à 09:46, Daniel a écrit : I noticed that the corners of rectangles in LyX are drawn bevel instead of a pointy since they are drawn with the Qt default, see https://doc.qt.io/qt-5/qpen.html#QPen-3 https://doc.qt.io/qt-5/qt.html#PenJoinStyle-enum I don't think the bevel corners

Re: Size of space insets seem way too small in master

2020-08-25 Thread Pavel Sanda
On Tue, Aug 25, 2020 at 04:23:01PM +0200, Pavel Sanda wrote: > > No. Note however that is is a 1 pixel difference. > > On the screenshot I sent it was 3 pixels for protected and 1 for thin. 3 pixels *difference* -- lyx-devel mailing list lyx-devel@lists.lyx.org

Re: Size of space insets seem way too small in master

2020-08-25 Thread Pavel Sanda
On Tue, Aug 25, 2020 at 04:12:20PM +0200, Jean-Marc Lasgouttes wrote: > Le 25/08/2020 ?? 16:03, Pavel Sanda a écrit : > >On Tue, Aug 25, 2020 at 03:20:55PM +0200, Jean-Marc Lasgouttes wrote: > >>>see the screenshot in attachment. first char is thin line, second > >>>protected space. > >> > >>I

Re: display of $int...$ under QT5

2020-08-25 Thread Pavel Sanda
On Tue, Aug 25, 2020 at 02:45:46PM +0200, M.B. Schiekel wrote: > > Yes, we might need to do that as well. I am waiting for the feedback because > > I can't reproduce the problem myself. > > where can I download the newest lyx 2.4, so that tomorrow I can test? (..sent privately..) P -- lyx-devel

Re: Size of space insets seem way too small in master

2020-08-25 Thread Jean-Marc Lasgouttes
Le 25/08/2020 à 16:03, Pavel Sanda a écrit : On Tue, Aug 25, 2020 at 03:20:55PM +0200, Jean-Marc Lasgouttes wrote: see the screenshot in attachment. first char is thin line, second protected space. I understand that it looks small. Does it mean that you find the size of newer screenshots

Re: Size of space insets seem way too small in master

2020-08-25 Thread Pavel Sanda
On Tue, Aug 25, 2020 at 03:20:55PM +0200, Jean-Marc Lasgouttes wrote: > >see the screenshot in attachment. first char is thin line, second protected > >space. > > I understand that it looks small. Does it mean that you find the size of newer screenshots acceptable? > Notice however that the

Re: Size of space insets seem way too small in master

2020-08-25 Thread Jean-Marc Lasgouttes
Le 25/08/2020 à 13:54, Pavel Sanda a écrit : On Tue, Aug 25, 2020 at 01:25:12PM +0200, Pavel Sanda wrote: On Tue, Aug 25, 2020 at 12:14:33AM +0200, Jean-Marc Lasgouttes wrote: Le 24/08/2020 ?? 13:28, Pavel Sanda a écrit : Hi (JMarc?), thin space is almost invisible on my screen and normal

Re: [Wiki site] recent notify posts

2020-08-25 Thread Thibaut Cuvelier
On Tue, 25 Aug 2020 at 14:33, Pavel Sanda wrote: > On Tue, Aug 25, 2020 at 07:56:09AM +0200, Apache wrote: > > > > All recent posts: http://wiki.lyx.org/Site/AllRecentChanges > > > > * http://wiki.lyx.org/LyX.NewInLyX24 . . . 2020-08-25 07:56 CEST by > spitz > > Looking at the news wiki I find

Re: display of $int...$ under QT5

2020-08-25 Thread M.B. Schiekel
Am 25.08.20 um 14:15 schrieb Pavel Sanda: thank you for your kind reply. This morning I tried to compile LyX 2.3.5.2 with your suggested environment-variable export QT_HARFBUZZ=old , and yes, it works, all integral-signs are Ok. >>> >>> Could you possibly try to compile

Re: [Wiki site] recent notify posts

2020-08-25 Thread Pavel Sanda
On Tue, Aug 25, 2020 at 07:56:09AM +0200, Apache wrote: > > All recent posts: http://wiki.lyx.org/Site/AllRecentChanges > > * http://wiki.lyx.org/LyX.NewInLyX24 . . . 2020-08-25 07:56 CEST by spitz Looking at the news wiki I find the current separation on New features brought by the new file

Re: Size of space insets seem way too small in master

2020-08-25 Thread Pavel Sanda
On Tue, Aug 25, 2020 at 01:54:34PM +0200, Pavel Sanda wrote: > On Tue, Aug 25, 2020 at 01:25:12PM +0200, Pavel Sanda wrote: > > On Tue, Aug 25, 2020 at 12:14:33AM +0200, Jean-Marc Lasgouttes wrote: > > > Le 24/08/2020 ?? 13:28, Pavel Sanda a écrit : > > > >Hi (JMarc?), > > > > > > > >thin space is

Re: display of $int...$ under QT5

2020-08-25 Thread Pavel Sanda
On Tue, Aug 25, 2020 at 01:39:46PM +0200, Jean-Marc Lasgouttes wrote: > Le 25/08/2020 ?? 13:27, Pavel Sanda a écrit : > >On Tue, Aug 25, 2020 at 11:22:01AM +0200, M.B. Schiekel wrote: > >>Hi Jean-Marc, > >> > >>thank you for your kind reply. This morning I tried to compile LyX > >>2.3.5.2 with

Re: Size of space insets seem way too small in master

2020-08-25 Thread Pavel Sanda
On Tue, Aug 25, 2020 at 01:25:12PM +0200, Pavel Sanda wrote: > On Tue, Aug 25, 2020 at 12:14:33AM +0200, Jean-Marc Lasgouttes wrote: > > Le 24/08/2020 ?? 13:28, Pavel Sanda a écrit : > > >Hi (JMarc?), > > > > > >thin space is almost invisible on my screen and normal protected space > > >looks

Re: Allow empty line ... I know

2020-08-25 Thread Jean-Marc Lasgouttes
Le 15/08/2020 à 16:50, Daniel a écrit : The attached document demonstrates the situation: LyX shows no space difference between the text and the display formula. However, the output shows such difference. It would be good if LyX makes one aware that one has started a new paragraph before a

Re: display of $int...$ under QT5

2020-08-25 Thread Jean-Marc Lasgouttes
Le 25/08/2020 à 13:27, Pavel Sanda a écrit : On Tue, Aug 25, 2020 at 11:22:01AM +0200, M.B. Schiekel wrote: Hi Jean-Marc, thank you for your kind reply. This morning I tried to compile LyX 2.3.5.2 with your suggested environment-variable export QT_HARFBUZZ=old , and yes, it works, all

Re: display of $int...$ under QT5

2020-08-25 Thread Pavel Sanda
On Tue, Aug 25, 2020 at 11:22:01AM +0200, M.B. Schiekel wrote: > Hi Jean-Marc, > > thank you for your kind reply. This morning I tried to compile LyX > 2.3.5.2 with your suggested environment-variable > export QT_HARFBUZZ=old , > and yes, it works, all integral-signs are Ok. Could you possibly

Re: Size of space insets seem way too small in master

2020-08-25 Thread Pavel Sanda
On Tue, Aug 25, 2020 at 12:14:33AM +0200, Jean-Marc Lasgouttes wrote: > Le 24/08/2020 ?? 13:28, Pavel Sanda a écrit : > >Hi (JMarc?), > > > >thin space is almost invisible on my screen and normal protected space looks > >smaller than thin space used to... > > Different from 2.3.x with the same

Re: New Defects reported by Coverity Scan for LyX

2020-08-25 Thread Jean-Marc Lasgouttes
Le 25/08/2020 à 11:06, Stephan Witt a écrit : Next patch is the real change for #6401. I’d like to apply it soon. Any objections or possible improvements? It is difficult to understand what it does by reading it, and your commit log does not help much! JMarc -- lyx-devel mailing list

Re: display of $int...$ under QT5

2020-08-25 Thread M.B. Schiekel
Am 24.08.20 um 18:02 schrieb Jean-Marc Lasgouttes: >> After a longer discussion here I found, that the cause of this problem >> was the interaction of LyX with QT5-Qt-5.9.4. Then I compiled LyX with >> QT4 and this workaround was fine for me. >> Now with LyX 2.3.5.2 there is the same problem with

Re: New Defects reported by Coverity Scan for LyX

2020-08-25 Thread Stephan Witt
Am 25.08.2020 um 10:41 schrieb Jean-Marc Lasgouttes : > > Le 25/08/2020 à 07:17, Stephan Witt a écrit : >>> I would propose to either define Inset::asInsetBibitem() and use that, or >>> rely only on dynamic_cast. But it is not necessary to rely on inset code >>> IMO (I try to reduce the amount

Re: New Defects reported by Coverity Scan for LyX

2020-08-25 Thread Jean-Marc Lasgouttes
Le 25/08/2020 à 02:16, Thibaut Cuvelier a écrit : I've just pushed a pash for this on my development branch; here it is for inclusion (you were right about the missing index…). All your solutions seem like design decisions that should be taken once and for all (e.g., get rid of lyxCode and

Re: New Defects reported by Coverity Scan for LyX

2020-08-25 Thread Jean-Marc Lasgouttes
Le 25/08/2020 à 07:17, Stephan Witt a écrit : I would propose to either define Inset::asInsetBibitem() and use that, or rely only on dynamic_cast. But it is not necessary to rely on inset code IMO (I try to reduce the amount of such code uses, but they creep back relentlessly :). So, this