Re: LyX 2.2 cannot read a document from LyX 2.1?

2017-03-14 Thread José Abílio Matos
On Tuesday, 7 March 2017 12.39.19 WET Enrico Forestieri wrote: > > Is this a valid process that we should support? > > Given that lyx2lyx processes text files, taking into account that they > may have a BOM is safer. OK. So I will try to solve this problem. > > If so the following patch fixes

Jenkins build is back to normal : Build branch "master" » ubuntu-latest-qt5-cmake #92

2017-03-14 Thread ci-lyx
https://ci.inria.fr/lyx/job/build-master-head/job/ubuntu-latest-qt5-cmake/92/

Build failed in Jenkins: Build branch "master" » ubuntu-xenial-qt4-autotools-extended #106

2017-03-14 Thread ci-lyx
https://ci.inria.fr/lyx/job/build-master-head/job/ubuntu-xenial-qt4-autotools-extended/106/-- [...truncated 1122 lines...] CXX insets/InsetGraphicsParams.o CXX insets/InsetGraphics.o CXX insets/InsetHyperlink.o CXX

new compilation warning in DepTable.cpp

2017-03-14 Thread Uwe Stöhr
With current master I get: D:\LyXGit\Master\src\DepTable.cpp(46): warning C4244: '=': conversion from 'time_t' to 'long', possible loss of data [D:\LyXGit\Master\compile-2015\src\LyX.vcxproj] JMarc, could you please have a look? thanks and regards Uwe

Build failed in Jenkins: Build branch "master" » ubuntu-latest-qt5-cmake #91

2017-03-14 Thread ci-lyx
https://ci.inria.fr/lyx/job/build-master-head/job/ubuntu-latest-qt5-cmake/91/Changes: [rgheck] Move the global formats and system_formats variables into the LyX -- [...truncated 1940 lines...] make[2]: Entering directory '/build/lyx/build' cd

Build failed in Jenkins: Build branch "master" » ubuntu-xenial-qt4-autotools-extended #105

2017-03-14 Thread ci-lyx
https://ci.inria.fr/lyx/job/build-master-head/job/ubuntu-xenial-qt4-autotools-extended/105/Changes: [rgheck] Move the global formats and system_formats variables into the LyX -- [...truncated 1126 lines...] CXX insets/InsetGraphicsParams.o CXX

Re: Build failed in Jenkins: Build branch "master" » ubuntu-latest-qt5-cmake #91

2017-03-14 Thread Jean-Marc Lasgouttes
Le 14/03/2017 à 12:11, Kornel Benko a écrit : Should we really add LyX.cpp to sources of check_layout executable? Or is there some dummy defined? I think we should define a dummy getFormats(). JMarc

Re: Build failed in Jenkins: Build branch "master" » ubuntu-latest-qt5-cmake #91

2017-03-14 Thread Kornel Benko
Am Dienstag, 14. März 2017 um 11:36:34, schrieb ci-...@inria.fr > [ 98%] Linking CXX executable ../../bin/check_layout > cd /build/lyx/build/src/tests && /usr/bin/cmake -E cmake_link_script > CMakeFiles/check_layout.dir/link.txt --verbose=1 > /usr/bin/c++ -Wall -Wunused-parameter --std=c++14

Re: [LyX/master] Fix typo found by coverity

2017-03-14 Thread Jean-Marc Lasgouttes
Le 14/03/2017 à 04:41, Richard Heck a écrit : Done. Not too long, but definitely painless. Thanks. JMarc

Re: [LyX/master] Fix typo found by coverity

2017-03-14 Thread Jean-Marc Lasgouttes
Le 14/03/2017 à 04:41, Richard Heck a écrit : On 03/13/2017 12:05 PM, Jean-Marc Lasgouttes wrote: Le 13/03/2017 à 16:18, Richard Heck a écrit : I'll move the formats variable to the singleton, too. That seems worth doing, yes, and should be painless? I think it should be a bit long, but

Re: Build failed in Jenkins: Build branch "master" » ubuntu-latest-qt5-cmake #91

2017-03-14 Thread Jean-Marc Lasgouttes
Le 14/03/2017 à 12:18, Jean-Marc Lasgouttes a écrit : Le 14/03/2017 à 12:11, Kornel Benko a écrit : Should we really add LyX.cpp to sources of check_layout executable? Or is there some dummy defined? I think we should define a dummy getFormats(). All should be good now. JMarc

Re: Fwd: New Defects reported by Coverity Scan for LyX

2017-03-14 Thread Jean-Marc Lasgouttes
Le 13/03/2017 à 21:16, Pavel Sanda a écrit : Jean-Marc Lasgouttes wrote: Here are new defaults discovered by coverity. Guillaume, I think that they should all ring bells wrt your recent external modification code. Btw since you were working on coverity bugs for a while now, how many _real_

Re: Build failed in Jenkins: Build branch "master" » ubuntu-latest-qt5-cmake #91

2017-03-14 Thread Kornel Benko
Am Dienstag, 14. März 2017 um 14:29:13, schrieb Jean-Marc Lasgouttes > Le 14/03/2017 à 12:18, Jean-Marc Lasgouttes a écrit : > > Le 14/03/2017 à 12:11, Kornel Benko a écrit : > >> Should we really add LyX.cpp to sources of check_layout executable? > >> Or is there some dummy

Re: Fwd: New Defects reported by Coverity Scan for LyX

2017-03-14 Thread Jean-Marc Lasgouttes
Le 14/03/2017 à 14:39, Jean-Marc Lasgouttes a écrit : A good example of non-obvious report is this one: a2bfe004. Then there are the really tricky reports like Converters::convert where part of the code checks whether buffer is null, and the other part uses it without any check. JMarc

Re: [LyX/master] Fix typo found by coverity

2017-03-14 Thread Richard Heck
On 03/14/2017 09:28 AM, Jean-Marc Lasgouttes wrote: > Le 14/03/2017 à 04:41, Richard Heck a écrit : >> On 03/13/2017 12:05 PM, Jean-Marc Lasgouttes wrote: >>> Le 13/03/2017 à 16:18, Richard Heck a écrit : I'll move the formats variable to the singleton, too. That seems worth doing, yes,