Re: design patterns used in LyX

2017-04-21 Thread Jean-Marc Lasgouttes
Le 21/04/2017 à 05:51, Scott Kostyshak a écrit : (1) studying design patterns is a reasonable way to achieve that goal (2) what the best way to do that would be (3) which design patterns we use in LyX I am not much of a C++ programmer in this respect. I also found JMarc's commit at

Re: [LyX/master] use examples folder setting from preferences

2017-04-21 Thread Kornel Benko
Am Freitag, 21. April 2017 um 11:28:12, schrieb Stephan Witt > commit a91402dc64cb6c73b355465ec11868cf1d0a443d > Author: Stephan Witt > Date: Tue Apr 18 09:32:22 2017 +0200 > > use examples folder setting from preferences > --- >

Re: #10400: keyboard shortcut for document settings?

2017-04-21 Thread Jean-Marc Lasgouttes
Le 21/04/2017 à 05:50, Scott Kostyshak a écrit : Should we have a keyboard shortcut for document settings, as proposed at http://www.lyx.org/trac/ticket/10400 ? There is a proposal to use ctrl + p, which is now free because we got rid of print. I agree a shortcut would be nice. I have

Re: beamer editing

2017-04-21 Thread Jürgen Spitzmüller
Am Donnerstag, den 20.04.2017, 22:30 +0200 schrieb Edwin Leuven: > feel free to apply the patch ;-) I'll let others comment and test first. Alas, I do not have time for testing myself ATM. Jürgen > > ed. > signature.asc Description: This is a digitally signed message part

Re: #10400: keyboard shortcut for document settings?

2017-04-21 Thread Kornel Benko
Am Donnerstag, 20. April 2017 um 23:50:45, schrieb Scott Kostyshak > Should we have a keyboard shortcut for document settings, as proposed at > > http://www.lyx.org/trac/ticket/10400 > > ? > > There is a proposal to use ctrl + p, which is now free because we got > rid of

Re: design patterns used in LyX

2017-04-21 Thread Tommaso Cucinotta
On 21/04/2017 05:51, Scott Kostyshak wrote: (1) studying design patterns is a reasonable way to achieve that goal (2) what the best way to do that would be I have good memories of Bruce Eckel's Thinking in C++ http://www.mindviewinc.com/Books/downloads.html there's a whole chapter

focus-handling

2017-04-21 Thread mn
With 2.3-dev (and before that) there are inconsistencies or bugs regarding focus-management. Open LyX, create new document. Open document-settings. Switch to preamble. There is no focus in the preamble-editing area. It should be active immediately. Activate preamble editing area. Now close

Re: SIGSEGV on luatex export #2

2017-04-21 Thread Kornel Benko
Am Freitag, 21. April 2017 um 00:47:38, schrieb Scott Kostyshak > On Thu, Apr 20, 2017 at 11:48:12PM -0400, Scott Kostyshak wrote: > > > > $1 = (const lyx::support::FileName &) @0x3559560: { > > > _vptr.FileName = 0x38ca7d0, > > > d = 0x0 > > > } > > > > What information

Re: SIGSEGV on luatex export #2

2017-04-21 Thread Kornel Benko
Am Donnerstag, 20. April 2017 um 23:48:12, schrieb Scott Kostyshak > On Thu, Apr 20, 2017 at 07:59:05PM +0200, Kornel Benko wrote: > > Am Donnerstag, 20. April 2017 um 13:02:32, schrieb Scott Kostyshak > > > > > On Thu, Apr 20, 2017 at 04:21:49AM -0400,

Re: master closed today at 22h00 UTC for 2.3.0alpha1

2017-04-21 Thread Guenter Milde
Dear Scott, > As discussed [1], the current plan is to release alpha1 on Saturday. > Please do not make any commits to master today after 22h00 UTC until > master is open again. Between now and 22h00 UTC, please only make > commits that: > (1) are very safe > and > (2) you are confident

Re: [LyX/master] special character "allowbreak" (ZWSP), fileformat change

2017-04-21 Thread Guenter Milde
On 2017-04-21, Scott Kostyshak wrote: > On Thu, Apr 20, 2017 at 11:29:55PM +0200, Günter Milde wrote: >> commit f5ac0580ff8f4f1fd34d792f7952fb05d182e162 >> Author: Günter Milde >> Date: Mon Mar 6 14:49:30 2017 +0100 >> special character "allowbreak" (ZWSP), fileformat

Re: [LyX/master] Mover.h: let move be defined

2017-04-21 Thread Jean-Marc Lasgouttes
Le 20/04/2017 à 23:49, Guillaume MM a écrit : commit d4ea07705a88089519b80db3307a7d940fbae40d Author: Guillaume MM Date: Mon Apr 3 00:31:37 2017 +0200 Mover.h: let move be defined This commit leads to a compile error with gcc 4.6. I guess it is due to this compiler's

Re: master closed today at 22h00 UTC for 2.3.0alpha1

2017-04-21 Thread Scott Kostyshak
On Fri, Apr 21, 2017 at 12:20:47PM +, Guenter Milde wrote: > Dear Scott, > > > As discussed [1], the current plan is to release alpha1 on Saturday. > > > Please do not make any commits to master today after 22h00 UTC until > > master is open again. Between now and 22h00 UTC, please only make

Re: master closed today at 22h00 UTC for 2.3.0alpha1

2017-04-21 Thread Jean-Marc Lasgouttes
Le 21/04/2017 à 14:20, Guenter Milde a écrit : I propose a simple change to the lyx2lyx conversions for now: User a closed ERT inset for ligature dashes in pre-2.2 documents: 2.1 <-> 2.2 -- <-> ERT -- --- <-> ERT --- Would that mean that all 2.1 documents that

Re: master closed today at 22h00 UTC for 2.3.0alpha1

2017-04-21 Thread Guenter Milde
On 2017-04-21, Jean-Marc Lasgouttes wrote: > Le 21/04/2017 à 14:20, Guenter Milde a écrit : >> I propose a simple change to the lyx2lyx conversions for now: >> User a closed ERT inset for ligature dashes in pre-2.2 documents: >> 2.1 <-> 2.2 >> -- <-> ERT -- >> ---

Re: New warnings in master

2017-04-21 Thread Guenter Milde
On 2017-04-20, Guillaume MM wrote: > ../../src/insets/InsetSpecialChar.cpp: In member function ‘virtual > lyx::docstring lyx::InsetSpecialChar::toolTip(const lyx::BufferView&, > int, int) const’: > ../../src/insets/InsetSpecialChar.cpp:92:9: warning: enumeration value > ‘LDOTS’ not handled in

Re: New warnings in master

2017-04-21 Thread Jean-Marc Lasgouttes
Le 21/04/2017 à 18:12, Guenter Milde a écrit : This is a result of the addition of tooltips for some special chars (where the symbol in the GUI is a bit ambiguous...). No tooltips for the values above is the intended behaviour. What would be the correct way to silence the warnings? The lazy

Re: master closed today at 22h00 UTC for 2.3.0alpha1

2017-04-21 Thread Guenter Milde
On 2017-04-21, Scott Kostyshak wrote: > On Fri, Apr 21, 2017 at 12:20:47PM +, Guenter Milde wrote: >> Dear Scott, >> > As discussed [1], the current plan is to release alpha1 on Saturday. >> > Please do not make any commits to master today after 22h00 UTC until >> > master is open again.

Re: master closed today at 22h00 UTC for 2.3.0alpha1

2017-04-21 Thread Scott Kostyshak
On Apr 21, 2017 12:45 PM, "Guenter Milde" wrote: > > On 2017-04-21, Jean-Marc Lasgouttes wrote: > > Le 21/04/2017 à 14:20, Guenter Milde a écrit : > >> I propose a simple change to the lyx2lyx conversions for now: > > >> User a closed ERT inset for ligature dashes in pre-2.2

Re: [LyX/master] Mover.h: let move be defined

2017-04-21 Thread Jean-Marc Lasgouttes
Yes plzase, so that we have time to understand fully the problem. Although I am 90% sure it is a gcc4.6 issue. Jmarc Le 21 avril 2017 21:34:59 GMT+02:00, Scott Kostyshak a écrit : > >I think Guillaume is away until May. JMarc, do you recommend we revert >this commit for

keytest.py

2017-04-21 Thread Kornel Benko
With this patch all findadv tests pass now. This is result of collaboration with Tommaso. Not important for alpha, but also no side effects to the rest. Kornel signature.asc Description: This is a digitally signed message part. diff --git

Re: master closed today at 22h00 UTC for 2.3.0alpha1

2017-04-21 Thread Scott Kostyshak
On Apr 21, 2017 1:45 PM, "Guenter Milde" wrote: > > On 2017-04-21, Scott Kostyshak wrote: > > > Is there consensus that this is the right approach? > > There is no consensus about the right approach to the "dash problem". > Therefore, this is only a minimal, "stop gap"

Re: [LyX/master] Mover.h: let move be defined

2017-04-21 Thread Scott Kostyshak
On Fri, Apr 21, 2017 at 03:47:21PM +0200, Jean-Marc Lasgouttes wrote: > Le 20/04/2017 à 23:49, Guillaume MM a écrit : > > commit d4ea07705a88089519b80db3307a7d940fbae40d > > Author: Guillaume MM > > Date: Mon Apr 3 00:31:37 2017 +0200 > > > > Mover.h: let move be defined > >

Re: [LyX/master] special character "allowbreak" (ZWSP), fileformat change

2017-04-21 Thread Scott Kostyshak
On Fri, Apr 21, 2017 at 12:06:46PM +, Guenter Milde wrote: > Fixed at f5ac0580ff8f4f1fd3. Thanks for the quick fix. All tex2lyx tests pass on current master. Scott signature.asc Description: PGP signature

Re: master closed today at 22h00 UTC for 2.3.0alpha1

2017-04-21 Thread Scott Kostyshak
On Fri, Apr 21, 2017 at 01:59:30PM -0400, Scott Kostyshak wrote: > On Apr 21, 2017 1:45 PM, "Guenter Milde" wrote: > > > > On 2017-04-21, Scott Kostyshak wrote: > > > > > Is there consensus that this is the right approach? > > > > There is no consensus about the right approach

Re: #10400: keyboard shortcut for document settings?

2017-04-21 Thread Scott Kostyshak
On Fri, Apr 21, 2017 at 10:48:05AM +0200, Jean-Marc Lasgouttes wrote: > Le 21/04/2017 à 05:50, Scott Kostyshak a écrit : > > Should we have a keyboard shortcut for document settings, as proposed at > > > > http://www.lyx.org/trac/ticket/10400 > > > > ? > > > > There is a proposal to use ctrl

Re: #10469: patch for putting LyX window on top on Windows

2017-04-21 Thread Enrico Forestieri
On Thu, Apr 20, 2017 at 11:50:03PM -0400, Scott Kostyshak wrote: > Dear all, > > I am wondering if we should include racoon's patch at #10469. It can be > seen here: > > http://www.lyx.org/trac/attachment/ticket/10469/0001-Fix-for-10469.patch > > I would propose that we include it with an OS

Re: #10469: patch for putting LyX window on top on Windows

2017-04-21 Thread Scott Kostyshak
On Sat, Apr 22, 2017 at 03:04:11AM +0200, Enrico Forestieri wrote: > I tried the patch but it does not work for me. I started lyx and then, > from another terminal, I issued "lyx --remote file.lyx". The file was > loaded in the already running instance but it was not brought to top. Thanks for

Re: design patterns used in LyX

2017-04-21 Thread Scott Kostyshak
On Fri, Apr 21, 2017 at 09:01:09AM +0200, Tommaso Cucinotta wrote: > On 21/04/2017 05:51, Scott Kostyshak wrote: > > (1) studying design patterns is a reasonable way to achieve that goal > > (2) what the best way to do that would be > > I have good memories of Bruce Eckel's Thinking in C++ >

Re: SIGSEGV on luatex export #2

2017-04-21 Thread Scott Kostyshak
On Fri, Apr 21, 2017 at 09:08:36AM +0200, Kornel Benko wrote: > Am Donnerstag, 20. April 2017 um 23:48:12, schrieb Scott Kostyshak > > > On Thu, Apr 20, 2017 at 07:59:05PM +0200, Kornel Benko wrote: > > > Am Donnerstag, 20. April 2017 um 13:02:32, schrieb Scott Kostyshak > > >

Re: [LyX/master] Mover.h: let move be defined

2017-04-21 Thread Scott Kostyshak
On Fri, Apr 21, 2017 at 10:45:02PM +0200, Jean-Marc Lasgouttes wrote: > Yes plzase, so that we have time to understand fully the problem. Although I > am 90% sure it is a gcc4.6 issue. Reverted at ee7d78d1. Scott signature.asc Description: PGP signature