Re: [Mapbuilder-devel] Reducing code duplication in Mapbuilder

2008-02-28 Thread Gertjan van Oosten
Hi Andreas, As quoted from Andreas Hocevar <[EMAIL PROTECTED]>: > Gertjan van Oosten wrote: > > When does > > node.firstChild.nodeValue not work exactly? And when does > > getNodeValue(node) > > not return the equivalent of node.firstChild.nodeValue? My > > impression/assumption was that the tw

Re: [Mapbuilder-devel] Reducing code duplication in Mapbuilder

2008-02-27 Thread Andreas Hocevar
Gertjan van Oosten wrote: > As quoted from Andreas Hocevar: > >> I think replacing firstChild.nodeValue with getNodeValue() was the most >> effort, and I am not sure if this was a good idea, because >> Jean-Sebastien was referring to parsing context properties when he said >> that firstChild.nod

Re: [Mapbuilder-devel] Reducing code duplication in Mapbuilder

2008-02-27 Thread Gertjan van Oosten
As quoted from Andreas Hocevar: > I think replacing firstChild.nodeValue with getNodeValue() was the most > effort, and I am not sure if this was a good idea, because > Jean-Sebastien was referring to parsing context properties when he said > that firstChild.nodeValue does not work. I do not under

Re: [Mapbuilder-devel] Reducing code duplication in Mapbuilder

2008-02-27 Thread Andreas Hocevar
Gertjan, thanks for your efforts! Gertjan van Oosten wrote: > Done this for widgets, tools, models, examples and util. > Also used getNodeValue() and Mapbuilder.parseBoolean() where > appropriate. > I think replacing firstChild.nodeValue with getNodeValue() was the most effort, and I am not

Re: [Mapbuilder-devel] Reducing code duplication in Mapbuilder

2008-02-27 Thread Gertjan van Oosten
Andreas, As quoted from Andreas Hocevar <[EMAIL PROTECTED]>: > This issue is now addressed in http://jira.codehaus.org/browse/MAP-500, > [...] > TODO: use it in all widgets, tools and models. Volunteers are welcome! Done this for widgets, tools, models, examples and util. Also used getNodeValue(