[Mesa-dev] [PATCH 0/3] Misc GLhandleARB GLuint cleanup

This series includes 3 changes related to help reconcile the differences in declaration between Apple's vs Mesa's GLhandleARB type. The first, I expect to be mostly uncontroversial as they are mainly cleaning up and correcting some prototypes. The second is just a casting which should be

Re: [Mesa-dev] [PATCH 5/4] mesa: Refactor error checking for GL_TEXTURE_BASE_LEVEL vs texture targets

On Jan 20, 2016 6:20 PM, "Ian Romanick" wrote: > > From: Ian Romanick > > Add a big spec quotation justifying the error generated, which has > changed over the GL versions. > > Signed-off-by: Ian Romanick > --- > > I

Re: [Mesa-dev] About drm_hwcomposer (Was Re: About the PixelFormat mappings in drm_gralloc)

CC to the android-x86 devel list so more developers can follow. 2016-01-21 6:19 GMT+08:00 Rob Clark : > On Wed, Jan 20, 2016 at 4:59 PM, Rob Herring wrote: >> Hi Sean, >> >> On Thu, Jan 14, 2016 at 1:15 PM, Sean Paul wrote: >>> >>>

Re: [Mesa-dev] [PATCH 3/4] radeonsi: allow tessellation on CU1 and ES on CU0

On 20.01.2016 19:20, Marek Olšák wrote: On Wed, Jan 20, 2016 at 6:30 PM, Nicolai Hähnle wrote: On 19.01.2016 20:20, Marek Olšák wrote: From: Marek Olšák We don't use on-chip GS, so it's not required to reserve CU1 for ES. Why is a deadlock not

[Mesa-dev] [PATCH 2/3] mesa: Fix format warnings

main/shaderapi.c:1318:51: warning: format specifies type 'unsigned int' but the argument has type 'GLhandleARB' (aka 'unsigned long') [-Wformat] _mesa_debug(ctx, "glDeleteObjectARB(%u)\n", obj); ~~ ^~~

[Mesa-dev] [PATCH 3/3] mesa: Deal with size differences between GLuint and GLhandleARB in GetAttachedObjectsARB

Signed-off-by: Jeremy Huddleston Sequoia --- src/mesa/main/shaderapi.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/shaderapi.c b/src/mesa/main/shaderapi.c index a988f41..75fc17c 100644 --- a/src/mesa/main/shaderapi.c +++

[Mesa-dev] [PATCH 1/3] mesa: Fix some function prototype mismatching

main/api_exec.c:543:36: warning: incompatible pointer types passing 'void (GLhandleARB, GLuint, const GLcharARB *)' (aka 'void (unsigned long, unsigned int, const char *)') to parameter of type 'void (*)(GLuint, GLuint, const GLchar *)' (aka 'void (*)(unsigned int, unsigned int, const

[Mesa-dev] [Bug 93796] glGetActiveAtomicCounterBufferiv is broken

https://bugs.freedesktop.org/show_bug.cgi?id=93796 --- Comment #2 from Tapani Pälli --- Would it be possible to attach the test application? > (The atomic counter buffers have the ids 0 and 1, queried with glGetProgramiv) Can you paste how do you query the indices of the

[Mesa-dev] [PATCH] i965: Implement a drirc workaround for broken dual color blending.

OpenGL's dual color blending feature was specified so that an implementation could support both multiple render targets (MRT) and dual source blending. Fragment shader outputs specify both "location" (the render target number) and "index" (either color 0 or 1). I believe DirectX only has the

[Mesa-dev] [PATCH 4/4] meta: Use internal functions to set texture parameters

From: Ian Romanick _mesa_texture_parameteriv is used because (the more obvious) _mesa_texture_parameteri just stuffs the parameter in an array and calls _mesa_texture_parameteriv. This just cuts out the middleman. As a side bonus we no longer need check that

[Mesa-dev] [PATCH 3/4] meta/blit: Restore GL_DEPTH_STENCIL_TEXTURE_MODE state for GL_TEXTURE_RECTANGLE

From: Ian Romanick Commit c246828c added the code to save and restore the stencil texturing mode. The restore, however, was erroneously inside the 'target != GL_TEXTURE_RECTANGLE' block. Fixes piglit test 'arb_stencil_texturing-blit_corrupts_state

[Mesa-dev] [PATCH 1/4] mesa: Don't include meta.h

From: Ian Romanick Commit 055093e removed the call to _mesa_meta_in_progress, and meta.h has not been necessary in src/mesa/main/enable.c since. Signed-off-by: Ian Romanick --- src/mesa/main/enable.c | 1 - 1 file changed, 1 deletion(-)

[Mesa-dev] [PATCH 2/4] meta/copy_image: Fix typo in comment

From: Ian Romanick Trivial. Signed-off-by: Ian Romanick --- src/mesa/drivers/common/meta_copy_image.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/common/meta_copy_image.c

[Mesa-dev] [Bug 93796] glGetActiveAtomicCounterBufferiv is broken

https://bugs.freedesktop.org/show_bug.cgi?id=93796 Tapani Pälli changed: What|Removed |Added Status|ASSIGNED|NEEDINFO --- Comment

[Mesa-dev] [PATCH] radeonsi: fix discard-only fragment shaders (v2)

From: Nicolai Hähnle When a fragment shader is used that has no outputs but does conditional discard (KILL_IF), all fragments are killed without this patch. By comparing various register settings, my conclusion is that the exec mask is either not properly forwarded to

Re: [Mesa-dev] [PATCH 4/4] meta: Use internal functions to set texture parameters

On Jan 20, 2016 6:18 PM, "Ian Romanick" wrote: > > From: Ian Romanick > > _mesa_texture_parameteriv is used because (the more obvious) > _mesa_texture_parameteri just stuffs the parameter in an array and calls > _mesa_texture_parameteriv. This

[Mesa-dev] [PATCH 5/4] mesa: Refactor error checking for GL_TEXTURE_BASE_LEVEL vs texture targets

From: Ian Romanick Add a big spec quotation justifying the error generated, which has changed over the GL versions. Signed-off-by: Ian Romanick --- I intended to send this out with the other four, but I selected the wrong SHA from the list.

[Mesa-dev] [Bug 93796] glGetActiveAtomicCounterBufferiv is broken

https://bugs.freedesktop.org/show_bug.cgi?id=93796 --- Comment #3 from Tapani Pälli --- (In reply to Tapani Pälli from comment #2) > Would it be possible to attach the test application? > > > (The atomic counter buffers have the ids 0 and 1, queried with > > glGetProgramiv) >

[Mesa-dev] [Bug 93796] glGetActiveAtomicCounterBufferiv is broken

https://bugs.freedesktop.org/show_bug.cgi?id=93796 --- Comment #5 from Timothy Arceri --- Hmm, seems I didn't read the code properly when I pointed out what I thought was the offending commit. On second look it does look like it *should* work. -- You are receiving this

[Mesa-dev] [Bug 93796] glGetActiveAtomicCounterBufferiv is broken

https://bugs.freedesktop.org/show_bug.cgi?id=93796 --- Comment #6 from Tapani Pälli --- Created attachment 121167 --> https://bugs.freedesktop.org/attachment.cgi?id=121167=edit piglit test Attaching here a patch to Piglit that exercises these queries. Nicolas, please also

Re: [Mesa-dev] [RFC 00/63] ARB_internalformat_query2 on Mesa and i965 backend

On 01/20/2016 12:22 AM, Nanley Chery wrote: > On Tue, Jan 19, 2016 at 05:41:40PM +0100, Eduardo Lima Mitev wrote: >> Hello, >> >> This is an RFC series adding support for the ARB_internalformat-query2 >> extension: >> >> https://www.opengl.org/registry/specs/ARB/internalformat_query2.txt >> >>

[Mesa-dev] [Bug 93796] glGetActiveAtomicCounterBufferiv is broken

https://bugs.freedesktop.org/show_bug.cgi?id=93796 Timothy Arceri changed: What|Removed |Added Assignee|mesa-dev@lists.freedesktop. |lem...@gmail.com

Re: [Mesa-dev] [PATCH 2/2] radeonsi: implement SAMPLEPOS system value without a constant buffer load

Reviewed-by: Nicolai Hähnle On 19.01.2016 20:39, Marek Olšák wrote: From: Marek Olšák We always get per-sample input position. --- src/gallium/drivers/radeonsi/si_shader.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-)

[Mesa-dev] [Bug 72877] Wrong colors with Mesa 9.2 and Mesa 10.0 on PPC Linux systems

https://bugs.freedesktop.org/show_bug.cgi?id=72877 Alex Perez changed: What|Removed |Added Assignee|mesa-dev@lists.freedesktop.

Re: [Mesa-dev] [PATCH 23/28] glsl: add pack varying to resource list for vertex input / fragment output

On Mon, Dec 28, 2015 at 9:00 PM, Timothy Arceri wrote: > This is needed now that we pack these type of varyings when they have a > component layout qualifier. > --- > src/glsl/linker.cpp | 15 --- > 1 file changed, 8 insertions(+), 7 deletions(-) > >

Re: [Mesa-dev] [PATCH 15/28] glsl: add support for packing varyings with explicit locations

On Mon, Dec 28, 2015 at 9:00 PM, Timothy Arceri wrote: > --- > src/glsl/lower_packed_varyings.cpp | 45 > +++--- > 1 file changed, 32 insertions(+), 13 deletions(-) > > diff --git a/src/glsl/lower_packed_varyings.cpp >

Re: [Mesa-dev] [PATCH 4/4] radeonsi: enable late VS allocation (v2)

Patches 1, 2 & 4 are Reviewed-by: Nicolai Hähnle On 19.01.2016 20:20, Marek Olšák wrote: From: Marek Olšák --- src/gallium/drivers/radeonsi/si_state.c | 21 +++-- 1 file changed, 19 insertions(+), 2 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 3/4] radeonsi: allow tessellation on CU1 and ES on CU0

On 19.01.2016 20:20, Marek Olšák wrote: From: Marek Olšák We don't use on-chip GS, so it's not required to reserve CU1 for ES. Why is a deadlock not possible with an off-chip GS ring? Nicolai --- src/gallium/drivers/radeonsi/si_state.c | 4 ++-- 1 file changed, 2

Re: [Mesa-dev] [PATCH 1/2] radeonsi: add max waves / CU to shader stats

On 19.01.2016 20:39, Marek Olšák wrote: From: Marek Olšák --- src/gallium/drivers/radeonsi/si_shader.c | 33 +--- 1 file changed, 30 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c

Re: [Mesa-dev] [PATCH] glsl: add missing explicit_image_format flag to has_layout()

On 01/19/2016 04:28 PM, Mark Janes wrote: > This patch fixes > arb_shader_image_load_store.compiler.declaration-format-qualifier-duplicate > tests. However, it regresses 17 other arb_shader_image_load_store other > tests with: Which tests? As Timothy says, the tests may be incorrect. Rules

[Mesa-dev] [Bug 93796] glGetActiveAtomicCounterBufferiv is broken

https://bugs.freedesktop.org/show_bug.cgi?id=93796 Bug ID: 93796 Summary: glGetActiveAtomicCounterBufferiv is broken Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity: normal

[Mesa-dev] [Bug 93796] glGetActiveAtomicCounterBufferiv is broken

https://bugs.freedesktop.org/show_bug.cgi?id=93796 Nicolas Koch changed: What|Removed |Added Hardware|Other |x86-64 (AMD64)

Re: [Mesa-dev] [PATCH v2] glsl: move uniform calculation to link_uniforms

On Wed, Jan 20, 2016 at 6:35 AM, Tapani Pälli wrote: > On 01/20/2016 01:11 PM, Ilia Mirkin wrote: >> >> On Wed, Jan 20, 2016 at 6:02 AM, Tapani Pälli >> wrote: Unfortunately putting such a shader together is a bit of a pain, since

Re: [Mesa-dev] [PATCH] llvmpipe: warn about illegal use of objects in different contexts

On 19/01/16 23:49, srol...@vmware.com wrote: From: Roland Scheidegger Doing that is clearly a bug. We can't quite assert as st/mesa may hit this, but increase at least visibility of it a bit. (For the non-refcounted objects it would be illegal too, but we can't detect that

Re: [Mesa-dev] [PATCH] glsl: expose accurate gl_MaxCompute* constants rather than cooked values

Actually as we just realized, this patch only makes sense on top of Samuel's other work which made the GL-side constants driver-configurable. (I didn't realize that mesa master didn't have this.) On Wed, Jan 20, 2016 at 11:47 AM, Samuel Pitoiset wrote: > This patch

[Mesa-dev] [PATCH v2 3/4] gallium: add GREMEDY_string_marker

From: Rob Clark Since the GREMEDY extensions are normally only exposed by the gremedy debugger (and could possibly trigger debug paths in the app), we don't expose the extension by default, but instead only with ST_DEBUG=gremedy. Signed-off-by: Rob Clark

[Mesa-dev] [PATCH] llvmpipe, i915: add back NEW_RASTERIZER dependency when computing vertex info

From: Roland Scheidegger I removed this mistakenly in 2dbc20e45689e09766552517a74e2270e49817b5. I actually thought it should not be necessary and a piglit run didn't show any differences, but this shouldn't have been in there. draw_prepare_shader_outputs() is in fact

Re: [Mesa-dev] [PATCH 2/2] nir: Lower ldexp to arithmetic.

On 01/19/2016 10:14 PM, Kenneth Graunke wrote: > This is a port of Matt's GLSL IR lowering pass to NIR. It's required > because we translate SPIR-V directly to NIR, bypassing GLSL IR. > > I haven't introduced a lower_ldexp flag, as I believe all current NIR > consumers would set the flag. i965

Re: [Mesa-dev] [PATCH v2] glsl: move uniform calculation to link_uniforms

So... I'm just going to say that this is commit is the new poster child for not committing something as soon as you get a positive review. This patch went out barely 36 hours ago, and there is already a fix-up patch for it. I have also found two other issues in review. We're not in that much of

Re: [Mesa-dev] [PATCH v2 1/4] mesa: add GREMEDY_string_marker

On Wed, Jan 20, 2016 at 2:32 PM, Rob Clark wrote: > From: Rob Clark > > Signed-off-by: Rob Clark > --- > src/mapi/glapi/gen/GREMEDY_string_marker.xml | 18 ++ > src/mapi/glapi/gen/Makefile.am

Re: [Mesa-dev] [PATCH v2 2/4] mesa: wire up EmitStringMarker for KHR_debug

Reviewed-by: Ilia Mirkin On Wed, Jan 20, 2016 at 2:32 PM, Rob Clark wrote: > From: Rob Clark > > The extension spec[1] describes DEBUG_TYPE_MARKER as "Annotation of the > command stream". So for DEBUG_TYPE_MARKER, also pass

Re: [Mesa-dev] [PATCH v2 0/4] string-marker support

On Wed, Jan 20, 2016 at 2:32 PM, Rob Clark wrote: > From: Rob Clark > > Slightly overdue respin of the patchset. Addressing the couple minor > points from Emil. (Spiffed out commit msg on 3/4 and couple tweaks > on 1/4), but overall other than

Re: [Mesa-dev] [PATCH v2 1/4] mesa: add GREMEDY_string_marker

On Wed, Jan 20, 2016 at 2:44 PM, Ilia Mirkin wrote: > On Wed, Jan 20, 2016 at 2:32 PM, Rob Clark wrote: >> From: Rob Clark >> >> Signed-off-by: Rob Clark >> --- >>

Re: [Mesa-dev] [PATCH v2 3/4] gallium: add GREMEDY_string_marker

Reviewed-by: Ilia Mirkin (with the GREMEDY bits subject to resolution of patch 1.) On Wed, Jan 20, 2016 at 2:32 PM, Rob Clark wrote: > From: Rob Clark > > Since the GREMEDY extensions are normally only exposed by the gremedy

Re: [Mesa-dev] [PATCH v2 4/4] freedreno: implement emit_string_marker

On Wed, Jan 20, 2016 at 2:50 PM, Ilia Mirkin wrote: > On Wed, Jan 20, 2016 at 2:32 PM, Rob Clark wrote: >> From: Rob Clark >> >> Writes string to cmdstream in payload of a no-op packet. >> >> Signed-off-by: Rob Clark

Re: [Mesa-dev] [PATCH 2/2] nir: Lower ldexp to arithmetic.

On Tuesday, January 19, 2016 10:14:18 PM PST Kenneth Graunke wrote: > This is a port of Matt's GLSL IR lowering pass to NIR. It's required > because we translate SPIR-V directly to NIR, bypassing GLSL IR. > > I haven't introduced a lower_ldexp flag, as I believe all current NIR > consumers would

[Mesa-dev] [PATCH v2 0/4] string-marker support

From: Rob Clark Slightly overdue respin of the patchset. Addressing the couple minor points from Emil. (Spiffed out commit msg on 3/4 and couple tweaks on 1/4), but overall other than rebasing not much has changed. Note that I need to clean them up a bit and resend,

[Mesa-dev] [PATCH v2 1/4] mesa: add GREMEDY_string_marker

From: Rob Clark Signed-off-by: Rob Clark --- src/mapi/glapi/gen/GREMEDY_string_marker.xml | 18 ++ src/mapi/glapi/gen/Makefile.am | 1 + src/mapi/glapi/gen/gl_API.xml| 2 ++ src/mesa/main/dd.h

[Mesa-dev] [PATCH v2 2/4] mesa: wire up EmitStringMarker for KHR_debug

From: Rob Clark The extension spec[1] describes DEBUG_TYPE_MARKER as "Annotation of the command stream". So for DEBUG_TYPE_MARKER, also pass the buf to the driver's EmitStringMarker() to be inserted in the command stream. [1]

[Mesa-dev] [PATCH v2 4/4] freedreno: implement emit_string_marker

From: Rob Clark Writes string to cmdstream in payload of a no-op packet. Signed-off-by: Rob Clark --- src/gallium/drivers/freedreno/freedreno_context.c | 27 +++ src/gallium/drivers/freedreno/freedreno_screen.c | 2 +-

Re: [Mesa-dev] [PATCH v2 4/4] freedreno: implement emit_string_marker

On Wed, Jan 20, 2016 at 2:32 PM, Rob Clark wrote: > From: Rob Clark > > Writes string to cmdstream in payload of a no-op packet. > > Signed-off-by: Rob Clark > --- > src/gallium/drivers/freedreno/freedreno_context.c | 27

Re: [Mesa-dev] [PATCH 2/2] nir: Lower ldexp to arithmetic.

On Tuesday, January 19, 2016 10:14:18 PM PST Kenneth Graunke wrote: > This is a port of Matt's GLSL IR lowering pass to NIR. It's required > because we translate SPIR-V directly to NIR, bypassing GLSL IR. > > I haven't introduced a lower_ldexp flag, as I believe all current NIR > consumers would

Re: [Mesa-dev] [PATCH v2 1/4] mesa: add GREMEDY_string_marker

On 01/20/2016 12:36 PM, Ian Romanick wrote: > On 01/20/2016 11:32 AM, Rob Clark wrote: >> diff --git a/src/mesa/main/errors.c b/src/mesa/main/errors.c >> index 9e66109..fc3c6d0 100644 >> --- a/src/mesa/main/errors.c >> +++ b/src/mesa/main/errors.c >> @@ -1276,6 +1276,19 @@

Re: [Mesa-dev] [PATCH v2 2/4] mesa: wire up EmitStringMarker for KHR_debug

On Wed, Jan 20, 2016 at 11:32 AM, Rob Clark wrote: > From: Rob Clark > > The extension spec[1] describes DEBUG_TYPE_MARKER as "Annotation of the > command stream". So for DEBUG_TYPE_MARKER, also pass the buf to the > driver's EmitStringMarker() to

Re: [Mesa-dev] [PATCH v2 2/4] mesa: wire up EmitStringMarker for KHR_debug

On 01/20/2016 12:34 PM, Matt Turner wrote: > On Wed, Jan 20, 2016 at 11:32 AM, Rob Clark wrote: >> From: Rob Clark >> >> The extension spec[1] describes DEBUG_TYPE_MARKER as "Annotation of the >> command stream". So for DEBUG_TYPE_MARKER, also pass

[Mesa-dev] [PATCH] freedreno: make opc array static const

Signed-off-by: Christian Gmeiner --- src/gallium/drivers/freedreno/ir3/disasm-a3xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/freedreno/ir3/disasm-a3xx.c b/src/gallium/drivers/freedreno/ir3/disasm-a3xx.c index

Re: [Mesa-dev] [PATCH v2 1/4] mesa: add GREMEDY_string_marker

On 01/20/2016 11:32 AM, Rob Clark wrote: > From: Rob Clark > > Signed-off-by: Rob Clark > --- > src/mapi/glapi/gen/GREMEDY_string_marker.xml | 18 ++ > src/mapi/glapi/gen/Makefile.am | 1 + >

Re: [Mesa-dev] [PATCH] llvmpipe, i915: add back NEW_RASTERIZER dependency when computing vertex info

On 20/01/16 19:43, srol...@vmware.com wrote: From: Roland Scheidegger I removed this mistakenly in 2dbc20e45689e09766552517a74e2270e49817b5. I actually thought it should not be necessary and a piglit run didn't show any differences, but this shouldn't have been in there.

Re: [Mesa-dev] [PATCH v2 1/4] mesa: add GREMEDY_string_marker

On 01/20/2016 11:48 AM, Rob Clark wrote: > On Wed, Jan 20, 2016 at 2:44 PM, Ilia Mirkin wrote: >> On Wed, Jan 20, 2016 at 2:32 PM, Rob Clark wrote: >>> From: Rob Clark >>> diff --git a/src/mesa/main/errors.c

Re: [Mesa-dev] [PATCH 23/28] glsl: add pack varying to resource list for vertex input / fragment output

On Wed, 2016-01-20 at 10:06 -0800, Anuj Phogat wrote: > On Mon, Dec 28, 2015 at 9:00 PM, Timothy Arceri > wrote: > > This is needed now that we pack these type of varyings when they > > have a > > component layout qualifier. > > --- > > src/glsl/linker.cpp | 15

Re: [Mesa-dev] [PATCH 15/28] glsl: add support for packing varyings with explicit locations

On Wed, 2016-01-20 at 09:32 -0800, Anuj Phogat wrote: > On Mon, Dec 28, 2015 at 9:00 PM, Timothy Arceri > wrote: > > --- > > src/glsl/lower_packed_varyings.cpp | 45 > > +++--- > > 1 file changed, 32 insertions(+), 13 deletions(-) > >

Re: [Mesa-dev] [PATCH 15/28] glsl: add support for packing varyings with explicit locations

On Wed, Jan 20, 2016 at 1:53 PM, Timothy Arceri wrote: > On Wed, 2016-01-20 at 09:32 -0800, Anuj Phogat wrote: >> On Mon, Dec 28, 2015 at 9:00 PM, Timothy Arceri >> wrote: >> > --- >> > src/glsl/lower_packed_varyings.cpp | 45 >> >

Re: [Mesa-dev] [PATCH 23/28] glsl: add pack varying to resource list for vertex input / fragment output

On Wed, Jan 20, 2016 at 1:39 PM, Timothy Arceri wrote: > On Wed, 2016-01-20 at 10:06 -0800, Anuj Phogat wrote: >> On Mon, Dec 28, 2015 at 9:00 PM, Timothy Arceri >> wrote: >> > This is needed now that we pack these type of varyings when

Re: [Mesa-dev] [PATCH] glsl: add missing explicit_image_format flag to has_layout()

On Wed, 2016-01-20 at 10:51 -0800, Ian Romanick wrote: > On 01/19/2016 04:28 PM, Mark Janes wrote: > > This patch fixes > > arb_shader_image_load_store.compiler.declaration-format-qualifier > > -duplicate > > tests. However, it regresses 17 other arb_shader_image_load_store > > other > > tests

Re: [Mesa-dev] [PATCH v2 2/4] mesa: wire up EmitStringMarker for KHR_debug

On Wed, Jan 20, 2016 at 3:40 PM, Ian Romanick wrote: > On 01/20/2016 12:34 PM, Matt Turner wrote: >> On Wed, Jan 20, 2016 at 11:32 AM, Rob Clark wrote: >>> From: Rob Clark >>> >>> The extension spec[1] describes

Re: [Mesa-dev] About drm_hwcomposer (Was Re: About the PixelFormat mappings in drm_gralloc)

On Wed, Jan 20, 2016 at 4:59 PM, Rob Herring wrote: > Hi Sean, > > On Thu, Jan 14, 2016 at 1:15 PM, Sean Paul wrote: >> >> >> On Thu, Jan 14, 2016 at 9:47 AM, Chih-Wei Huang >> wrote: >>> >>> Hello Sean, >>> My last try of

[Mesa-dev] [PATCH] r600g: don't leak driver const buffers

The buffers are referenced from r600_update_driver_const_buffers() -> r600_set_constant_buffer() -> u_upload_data(), but nothing ever releases the reference. Similar case with driver_consts. Found using valgrind. Signed-off-by: Grazvydas Ignotas --- No commit access, if the

Re: [Mesa-dev] [PATCH 3/4] radeonsi: allow tessellation on CU1 and ES on CU0

On Wed, Jan 20, 2016 at 6:30 PM, Nicolai Hähnle wrote: > On 19.01.2016 20:20, Marek Olšák wrote: >> >> From: Marek Olšák >> >> We don't use on-chip GS, so it's not required to reserve CU1 for ES. > > > Why is a deadlock not possible with an off-chip GS

Re: [Mesa-dev] [PATCH 23/28] glsl: add pack varying to resource list for vertex input / fragment output

On Wed, 2016-01-20 at 15:38 -0800, Anuj Phogat wrote: > On Wed, Jan 20, 2016 at 1:39 PM, Timothy Arceri > wrote: > > On Wed, 2016-01-20 at 10:06 -0800, Anuj Phogat wrote: > > > On Mon, Dec 28, 2015 at 9:00 PM, Timothy Arceri > > >

Re: [Mesa-dev] mesa: Reduce libGL.so binary size by about 15%

Sorry, I thought I responded to this a while ago. Reviewed-by: Jeremy Huddleston Sequoia Tested-by: Jeremy Huddleston Sequoia --Jeremy > On Jan 19, 2016, at 05:21, Andreas Boll wrote: > > Jeremy, did you have a chance to

Re: [Mesa-dev] [PATCH] mesa: Move sanity check of BindVertexBuffer for OpenGL ES 3.1

> -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On > Behalf Of Ian Romanick > Sent: Tuesday, January 19, 2016 9:16 PM > To: Marta Lofstedt; mesa-dev@lists.freedesktop.org > Subject: Re: [Mesa-dev] [PATCH] mesa: Move sanity check of > BindVertexBuffer

Re: [Mesa-dev] [PATCH v2] glsl: move uniform calculation to link_uniforms

On Tue, Jan 19, 2016 at 6:35 AM, Tapani Pälli wrote: > On 01/19/2016 01:14 PM, Ilia Mirkin wrote: >> >> The data structure is a (memory) heap... there appears to be one in >> mesa/main/mm.h. There's also one in nouveau_heap.h which is quite >> simple and totally unreliant

Re: [Mesa-dev] [PATCH] glsl: expose accurate gl_MaxCompute* constants rather than cooked values

On Wed, Jan 20, 2016 at 3:48 AM, Timothy Arceri wrote: >> diff --git a/src/glsl/main.cpp b/src/glsl/main.cpp >> index c9432f1..bdf2f07 100644 >> --- a/src/glsl/main.cpp >> +++ b/src/glsl/main.cpp >> @@ -63,6 +63,10 @@ initialize_context(struct gl_context *ctx, gl_api >>

Re: [Mesa-dev] [PATCH v2] glsl: move uniform calculation to link_uniforms

On 01/20/2016 10:26 AM, Ilia Mirkin wrote: On Tue, Jan 19, 2016 at 6:35 AM, Tapani Pälli wrote: On 01/19/2016 01:14 PM, Ilia Mirkin wrote: The data structure is a (memory) heap... there appears to be one in mesa/main/mm.h. There's also one in nouveau_heap.h which is

Re: [Mesa-dev] [PATCH v2] glsl: move uniform calculation to link_uniforms

On Wed, Jan 20, 2016 at 4:09 AM, Tapani Pälli wrote: > On 01/20/2016 10:26 AM, Ilia Mirkin wrote: >> >> On Tue, Jan 19, 2016 at 6:35 AM, Tapani Pälli >> wrote: >>> >>> On 01/19/2016 01:14 PM, Ilia Mirkin wrote: The data structure is a

[Mesa-dev] [PATCH] glsl: expose accurate gl_MaxCompute* constants rather than cooked values

Looks like the various max's were never plumbed through. This fixes dEQP test failures which checked for gl_MaxCompute* to match up to the relevant GL queries. Signed-off-by: Ilia Mirkin --- src/glsl/builtin_variables.cpp | 15 ++-

Re: [Mesa-dev] [PATCH v2] glsl: move uniform calculation to link_uniforms

On 01/20/2016 11:16 AM, Ilia Mirkin wrote: On Wed, Jan 20, 2016 at 4:09 AM, Tapani Pälli wrote: On 01/20/2016 10:26 AM, Ilia Mirkin wrote: On Tue, Jan 19, 2016 at 6:35 AM, Tapani Pälli wrote: On 01/19/2016 01:14 PM, Ilia Mirkin wrote: The

Re: [Mesa-dev] [PATCH] radeonsi: fix discard-only fragment shaders (11.1 version)

On 20.01.2016 05:18, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > When a fragment shader is used that has no outputs but does conditional > discard (KILL_IF), all fragments are killed without this patch. > > By comparing various register settings, my conclusion is

Re: [Mesa-dev] [PATCH] glsl: expose accurate gl_MaxCompute* constants rather than cooked values

On Wed, 2016-01-20 at 03:06 -0500, Ilia Mirkin wrote: > Looks like the various max's were never plumbed through. This fixes > dEQP > test failures which checked for gl_MaxCompute* to match up to the > relevant GL queries. > > Signed-off-by: Ilia Mirkin > --- >

Re: [Mesa-dev] [PATCH v2] glsl: move uniform calculation to link_uniforms

On Wed, Jan 20, 2016 at 4:22 AM, Tapani Pälli wrote: > On 01/20/2016 11:16 AM, Ilia Mirkin wrote: >> >> On Wed, Jan 20, 2016 at 4:09 AM, Tapani Pälli >> wrote: >>> >>> On 01/20/2016 10:26 AM, Ilia Mirkin wrote: On Tue, Jan 19, 2016 at

Re: [Mesa-dev] [PATCH v2] glsl: move uniform calculation to link_uniforms

On Wed, Jan 20, 2016 at 6:02 AM, Tapani Pälli wrote: >> Unfortunately putting such a shader together is a bit of a pain, since >> all the uniforms have to be used. I still really think you need to >> build a heap. Or at least store a "first empty slot" so that you don't >>

Re: [Mesa-dev] [PATCH] glsl: fix a bug with loop counter in find_empty_block

Reviewed-by: Ilia Mirkin I still hate this whole thing and think it should be reverted. But I'll wait until the US wakes up to gather more opinions before doing so. -ilia On Wed, Jan 20, 2016 at 6:42 AM, Tapani Pälli wrote: > Reported-by: Ilia

Re: [Mesa-dev] [PATCH] glsl: expose accurate gl_MaxCompute* constants rather than cooked values

On Wed, 2016-01-20 at 03:51 -0500, Ilia Mirkin wrote: > On Wed, Jan 20, 2016 at 3:48 AM, Timothy Arceri < > t_arc...@yahoo.com.au> wrote: > > > diff --git a/src/glsl/main.cpp b/src/glsl/main.cpp > > > index c9432f1..bdf2f07 100644 > > > --- a/src/glsl/main.cpp > > > +++ b/src/glsl/main.cpp > > >

Re: [Mesa-dev] [PATCH v2] glsl: move uniform calculation to link_uniforms

On Wed, Jan 20, 2016 at 4:44 AM, Tapani Pälli wrote: > On 01/20/2016 11:31 AM, Ilia Mirkin wrote: >> >> On Wed, Jan 20, 2016 at 4:22 AM, Tapani Pälli >> wrote: >>> >>> On 01/20/2016 11:16 AM, Ilia Mirkin wrote: On Wed, Jan 20, 2016 at

[Mesa-dev] [PATCH] glsl: fix a bug with loop counter in find_empty_block

Reported-by: Ilia Mirkin Signed-off-by: Tapani Pälli --- src/glsl/link_uniforms.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/glsl/link_uniforms.cpp b/src/glsl/link_uniforms.cpp index 76ee70d..23b3d66 100644 ---

Re: [Mesa-dev] [PATCH v2] glsl: move uniform calculation to link_uniforms

On 01/20/2016 11:31 AM, Ilia Mirkin wrote: On Wed, Jan 20, 2016 at 4:22 AM, Tapani Pälli wrote: On 01/20/2016 11:16 AM, Ilia Mirkin wrote: On Wed, Jan 20, 2016 at 4:09 AM, Tapani Pälli wrote: On 01/20/2016 10:26 AM, Ilia Mirkin wrote: On Tue,

Re: [Mesa-dev] [PATCH v2] glsl: move uniform calculation to link_uniforms

On 01/20/2016 12:45 PM, Ilia Mirkin wrote: On Wed, Jan 20, 2016 at 4:44 AM, Tapani Pälli wrote: On 01/20/2016 11:31 AM, Ilia Mirkin wrote: On Wed, Jan 20, 2016 at 4:22 AM, Tapani Pälli wrote: On 01/20/2016 11:16 AM, Ilia Mirkin wrote: On Wed,

Re: [Mesa-dev] [PATCH v2] glsl: move uniform calculation to link_uniforms

On 01/20/2016 01:11 PM, Ilia Mirkin wrote: On Wed, Jan 20, 2016 at 6:02 AM, Tapani Pälli wrote: Unfortunately putting such a shader together is a bit of a pain, since all the uniforms have to be used. I still really think you need to build a heap. Or at least store a

Re: [Mesa-dev] [PATCH] radeonsi: fix discard-only fragment shaders (11.1 version)

Reviewed-by: Marek Olšák Marek On Tue, Jan 19, 2016 at 9:18 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > When a fragment shader is used that has no outputs but does conditional > discard (KILL_IF), all fragments are

Re: [Mesa-dev] [PATCH 4/9] st/mesa: Accelerate PBO uploads

The fragment shader shouldn't be created if the driver doesn't support integers. Marek On Mon, Jan 18, 2016 at 11:22 PM, Nicolai Hähnle wrote: > From: Fredrik Höglund > > Create a PIPE_BUFFER sampler view on the pixel-unpack buffer, and draw > the image on

Re: [Mesa-dev] [PATCH 1/9] gallium: Add PIPE_CAP_BUFFER_SAMPLER_VIEW_RGBA_ONLY

On Tuesday 19 January 2016, Nicolai Hähnle wrote: > On 19.01.2016 10:45, Fredrik Höglund wrote: > > On Tuesday 19 January 2016, Nicolai Hähnle wrote: > >> > >> On 18.01.2016 18:50, Ilia Mirkin wrote: > >>> On Mon, Jan 18, 2016 at 5:22 PM, Nicolai Hähnle > >>> wrote: >