[Mesa-dev] [Bug 97879] [amdgpu] Rocket League: long hangs (several seconds) when loading assets (models/textures/shaders?)

2017-01-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97879 libgra...@gmail.com changed: What|Removed |Added CC||libgra...@gmail.com -- You are

Re: [Mesa-dev] [PATCH 2/2] nvc0: fix transfer of larger rectangles with DmaCopy on gk104 and up

2017-01-27 Thread Ilia Mirkin
Have you tested any actual games with this? If not, please do try a "real" piece of software before pushing. Either way, Acked-by: Ilia Mirkin On Fri, Jan 27, 2017 at 10:14 PM, Ben Skeggs wrote: > From: Ben Skeggs > > By treating

[Mesa-dev] [PATCH 2/2] nvc0: fix transfer of larger rectangles with DmaCopy on gk104 and up

2017-01-27 Thread Ben Skeggs
From: Ben Skeggs By treating the rectangles as 1cpp, we can run up against some internal copy engine limits and trigger a MEM2MEM_RECT_OUT_OF_BOUNDS error check at launch time. This commit enables the REMAP hardware, which allows us to specify both the component size and

[Mesa-dev] [PATCH 1/2] nvc0: copy engine surface params are only relevant for tiled surfaces

2017-01-27 Thread Ben Skeggs
From: Ben Skeggs Aside from reducing pushbuf usage in some situations, this commit should have no other effect, and is just to make it somewhat obvious that those methods have zero effect on linear surfaces. Signed-off-by: Ben Skeggs ---

Re: [Mesa-dev] [PATCH] radv/ac: Use base in push constant loads.

2017-01-27 Thread Dave Airlie
On 28 January 2017 at 10:35, Bas Nieuwenhuizen wrote: > Apparently the source is not an address but an offset, so we actually > need to use the base. Nice find! Reviewed-by: Dave Airlie > > Signed-off-by: Bas Nieuwenhuizen > --- >

[Mesa-dev] [PATCH] radv/ac: Use base in push constant loads.

2017-01-27 Thread Bas Nieuwenhuizen
Apparently the source is not an address but an offset, so we actually need to use the base. Signed-off-by: Bas Nieuwenhuizen --- src/amd/common/ac_nir_to_llvm.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c

Re: [Mesa-dev] [PATCH] configure.ac: Add radeon to with-vulkan-drivers help message.

2017-01-27 Thread Andres Rodriguez
Reviewed-by: Andres Rodriguez On 1/27/2017 6:15 PM, Lionel Landwerlin wrote: I was bitten by that too so : Acked-by: Lionel Landwerlin On 27/01/17 18:47, Bas Nieuwenhuizen wrote: Had someone that tried --with-vulkan-drivers=radv, this will

Re: [Mesa-dev] [PATCH 0/7] i965: Implement EGL_ANDROID_native_fence_sync

2017-01-27 Thread Emil Velikov
On Friday, 27 January 2017, Chris Wilson wrote: > On Fri, Jan 27, 2017 at 10:35:34AM -0800, Chad Versace wrote: > > On Fri 27 Jan 2017, Rafael Antognolli wrote: > > > On Thu, Jan 26, 2017 at 07:18:24PM -0800, Ben Widawsky wrote: > > > > On 17-01-23 15:32:32, Chad

Re: [Mesa-dev] [PATCH] configure.ac: Add radeon to with-vulkan-drivers help message.

2017-01-27 Thread Lionel Landwerlin
I was bitten by that too so : Acked-by: Lionel Landwerlin On 27/01/17 18:47, Bas Nieuwenhuizen wrote: Had someone that tried --with-vulkan-drivers=radv, this will guide people in the right direction. Signed-off-by: Bas Nieuwenhuizen CC:

Re: [Mesa-dev] [PATCH 1/2] intel/blorp: Handle clearing of A4B4G4R4 on all platforms

2017-01-27 Thread Mark Janes
Tested-by: Mark Janes Jason Ekstrand writes: > Cc: "13.0 17.0" > --- > src/intel/blorp/blorp_clear.c | 19 +++ > 1 file changed, 19 insertions(+) > > diff --git a/src/intel/blorp/blorp_clear.c

[Mesa-dev] [Bug 99527] Provide option for llvmpipe JIT code to run cleanly under valgrind

2017-01-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99527 --- Comment #2 from Jose Fonseca --- I agree with Roland. I wouldn't oppose patches fixing these (including --enable-valgrind build option if performance suffered). But it won't be trivial. A big source of issues is the

Re: [Mesa-dev] [PATCH 2/2] isl/formats: Only advertise sampling for A4B4G4R4 on Broadwell

2017-01-27 Thread Jason Ekstrand
On Fri, Jan 27, 2017 at 2:31 PM, Matt Turner wrote: > On Fri, Jan 27, 2017 at 2:18 PM, Jason Ekstrand > wrote: > > This causes hangs on Broadwell if you try to render to it. I have no > > idea how we managed to not hit this earlier. > > > > Cc: "13.0

Re: [Mesa-dev] [PATCH 2/2] isl/formats: Only advertise sampling for A4B4G4R4 on Broadwell

2017-01-27 Thread Ilia Mirkin
On Fri, Jan 27, 2017 at 5:18 PM, Jason Ekstrand wrote: > This causes hangs on Broadwell if you try to render to it. I have no > idea how we managed to not hit this earlier. > > Cc: "13.0 17.0" > --- > src/intel/isl/isl_format.c | 5 +++--

Re: [Mesa-dev] [PATCH 3/3] glsl/linker: Check that re-declared, inter-shader built-in blocks match

2017-01-27 Thread Timothy Arceri
On Fri, 2017-01-27 at 17:42 +0100, Eduardo Lima Mitev wrote: > From GLSL 4.5 spec, section "7.1 Built-In Language Variables", page > 130 of > the PDF states: > > "If multiple shaders using members of a built-in block belonging > to >  the same interface are linked together in the same

Re: [Mesa-dev] [PATCH 2/2] isl/formats: Only advertise sampling for A4B4G4R4 on Broadwell

2017-01-27 Thread Matt Turner
On Fri, Jan 27, 2017 at 2:18 PM, Jason Ekstrand wrote: > This causes hangs on Broadwell if you try to render to it. I have no > idea how we managed to not hit this earlier. > > Cc: "13.0 17.0" > --- > src/intel/isl/isl_format.c | 5 +++--

Re: [Mesa-dev] [PATCH] st/va encode handle ntsc framerate rate control

2017-01-27 Thread Mark Thompson
On 27/01/17 22:06, Andy Furniss wrote: > Mark Thompson wrote: >> On 26/01/17 18:26, Andy Furniss wrote: >>> Tested with ffmpeg and gst-vaapi. Without this bits per >>> frame is set way too low. >>> >>> Signed-off-by: Andy Furniss >>> --- >>>

[Mesa-dev] [PATCH 2/2] isl/formats: Only advertise sampling for A4B4G4R4 on Broadwell

2017-01-27 Thread Jason Ekstrand
This causes hangs on Broadwell if you try to render to it. I have no idea how we managed to not hit this earlier. Cc: "13.0 17.0" --- src/intel/isl/isl_format.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git

[Mesa-dev] [PATCH 1/2] intel/blorp: Handle clearing of A4B4G4R4 on all platforms

2017-01-27 Thread Jason Ekstrand
Cc: "13.0 17.0" --- src/intel/blorp/blorp_clear.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/src/intel/blorp/blorp_clear.c b/src/intel/blorp/blorp_clear.c index afc505d..f8ac6dc 100644 --- a/src/intel/blorp/blorp_clear.c +++

Re: [Mesa-dev] [PATCH] st/va encode handle ntsc framerate rate control

2017-01-27 Thread Andy Furniss
Mark Thompson wrote: On 26/01/17 18:26, Andy Furniss wrote: Tested with ffmpeg and gst-vaapi. Without this bits per frame is set way too low. Signed-off-by: Andy Furniss --- src/gallium/state_trackers/va/picture.c | 32 1 file changed,

[Mesa-dev] [PATCH] st/va: Support fractional framerate in misc parameter

2017-01-27 Thread Mark Thompson
Signed-off-by: Mark Thompson --- See - this is a recent addition, but is backwards-compatible. Depends on Andy's patch for actual support for

Re: [Mesa-dev] [PATCH] i965: Fix check for negative pitch in can_do_fast_copy_blit().

2017-01-27 Thread Jason Ekstrand
I think this is ok, Reviewed-by: Jason Ekstrand On Thu, Jan 26, 2017 at 1:27 AM, Kenneth Graunke wrote: > At this point, the pitch is in bytes. We haven't yet divided the pitch > by 4 for tiled surfaces, so abs(pitch) may be larger than 32K. This

Re: [Mesa-dev] [PATCH] anv: Advertise API version 1.0.39

2017-01-27 Thread Jason Ekstrand
On Fri, Jan 27, 2017 at 11:22 AM, Emil Velikov wrote: > On 26 January 2017 at 17:27, Jason Ekstrand wrote: > > I'm pretty sure we've kept up with the bug fixes. > > --- > > src/intel/vulkan/anv_device.c | 2 +- > > 1 file changed, 1 insertion(+),

Re: [Mesa-dev] [PATCH] st/va encode handle ntsc framerate rate control

2017-01-27 Thread Mark Thompson
On 26/01/17 18:26, Andy Furniss wrote: > Tested with ffmpeg and gst-vaapi. Without this bits per > frame is set way too low. > > Signed-off-by: Andy Furniss > --- > src/gallium/state_trackers/va/picture.c | 32 > 1 file changed, 24

Re: [Mesa-dev] [PATCH 0/7] i965: Implement EGL_ANDROID_native_fence_sync

2017-01-27 Thread Chris Wilson
On Fri, Jan 27, 2017 at 10:35:34AM -0800, Chad Versace wrote: > On Fri 27 Jan 2017, Rafael Antognolli wrote: > > On Thu, Jan 26, 2017 at 07:18:24PM -0800, Ben Widawsky wrote: > > > On 17-01-23 15:32:32, Chad Versace wrote: > > > > On Fri 20 Jan 2017, Rafael Antognolli wrote: > > > > > I have

Re: [Mesa-dev] 10bit HEVC decoding for RadeonSI

2017-01-27 Thread Mark Thompson
On 27/01/17 14:27, Christian König wrote: > Am 27.01.2017 um 13:51 schrieb Mark Thompson: >> On 26/01/17 16:59, Christian König wrote: >>> Am 26.01.2017 um 13:14 schrieb Mark Thompson: [SNIP] >>> The problem here is I need to know what will be done with the surface from >>> the very

Re: [Mesa-dev] [PATCH] radv: automake: Don't install vk_platform.h or vulkan.h.

2017-01-27 Thread Emil Velikov
On 27 January 2017 at 18:29, Matt Turner wrote: > On Fri, Jan 27, 2017 at 10:25 AM, Emil Velikov > wrote: >> From: Emil Velikov >> >> These files belong to the vulkan loader. >> >> Identical to >> 045f38a5075 vulkan:

Re: [Mesa-dev] [PATCH] anv: Advertise API version 1.0.39

2017-01-27 Thread Emil Velikov
On 26 January 2017 at 17:27, Jason Ekstrand wrote: > I'm pretty sure we've kept up with the bug fixes. > --- > src/intel/vulkan/anv_device.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/intel/vulkan/anv_device.c

Re: [Mesa-dev] [PATCH 0/8] LLVM requirement for drivers using draw

2017-01-27 Thread Matt Turner
On Thu, Jan 26, 2017 at 10:27 AM, Emil Velikov wrote: > With this in mind we can drop the LLVM requirement, which some > builders/distros explicitly patch out. Like who? I'm not sure why binary distros would do such a thing. Gentoo used to have a patch that removed the

Re: [Mesa-dev] [PATCH] configure.ac: list radeon in --with-vulkan-drivers help string

2017-01-27 Thread Bas Nieuwenhuizen
And this time I need to check my mail before sending ;) Reviewed-by: Bas Nieuwenhuizen On Fri, Jan 27, 2017, at 19:31, Emil Velikov wrote: > From: Emil Velikov > > Analogous to what we do for the dri and gallium drivers. > > Cc: 17.0 13.0

Re: [Mesa-dev] [PATCH 3/3] gallium/radeon: add new HUD queries for monitoring the CP

2017-01-27 Thread Alex Deucher
On Fri, Jan 27, 2017 at 1:49 PM, Marek Olšák wrote: > CP_STAT is only readable on amdgpu and only VI. > It can be added to other chips if anyone wants to send me a patch. Alex > It's OK to expose the queries on other chips if it simplies things > even if they don't update. >

Re: [Mesa-dev] [PATCH 3/3] gallium/radeon: add new HUD queries for monitoring the CP

2017-01-27 Thread Marek Olšák
CP_STAT is only readable on amdgpu and only VI. It's OK to expose the queries on other chips if it simplies things even if they don't update. Marek On Thu, Jan 26, 2017 at 8:54 PM, Samuel Pitoiset wrote: > There are even more counters in the CP_STAT register but I

Re: [Mesa-dev] [Mesa-stable] [PATCH] configure.ac: Augment error message to list vulkan drivers.

2017-01-27 Thread Bas Nieuwenhuizen
On Fri, Jan 27, 2017, at 10:31, Emil Velikov wrote: > On 27 January 2017 at 18:14, Bas Nieuwenhuizen > wrote: > > Had someone that tried --with-vulkan-drivers=radv, this will guide > > people in the right direction. > > > It might be better to update the help string ?

[Mesa-dev] [PATCH] configure.ac: Add radeon to with-vulkan-drivers help message.

2017-01-27 Thread Bas Nieuwenhuizen
Had someone that tried --with-vulkan-drivers=radv, this will guide people in the right direction. Signed-off-by: Bas Nieuwenhuizen CC: --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac

Re: [Mesa-dev] [PATCH 2/3] gallium/radeon: add new GPU-sdma-busy HUD query

2017-01-27 Thread Marek Olšák
SRBM_STATUS2 doesn't exist on R600-R700, so it shouldn't be read on those gens. Marek On Thu, Jan 26, 2017 at 8:54 PM, Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset > --- > src/gallium/drivers/radeon/r600_gpu_load.c| 11

Re: [Mesa-dev] [Intel-gfx] [PATCH] i965: Share the workaround bo between all contexts

2017-01-27 Thread Emil Velikov
On 27 January 2017 at 18:30, Chris Wilson wrote: > On Fri, Jan 27, 2017 at 06:20:46PM +, Emil Velikov wrote: >> On 27 January 2017 at 00:01, Chad Versace wrote: >> > On Thu 26 Jan 2017, Chad Versace wrote: >> >> On Thu 26 Jan 2017, Chris

Re: [Mesa-dev] [PATCH 0/7] i965: Implement EGL_ANDROID_native_fence_sync

2017-01-27 Thread Chad Versace
On Fri 27 Jan 2017, Rafael Antognolli wrote: > On Thu, Jan 26, 2017 at 07:18:24PM -0800, Ben Widawsky wrote: > > On 17-01-23 15:32:32, Chad Versace wrote: > > > On Fri 20 Jan 2017, Rafael Antognolli wrote: > > > > I have tested this series with the branches that you mentioned, and with > > > >

[Mesa-dev] [PATCH] configure.ac: list radeon in --with-vulkan-drivers help string

2017-01-27 Thread Emil Velikov
From: Emil Velikov Analogous to what we do for the dri and gallium drivers. Cc: 17.0 13.0 Cc: Bas Nieuwenhuizen Signed-off-by: Emil Velikov --- configure.ac | 2 +- 1 file

Re: [Mesa-dev] [Mesa-stable] [PATCH] configure.ac: Augment error message to list vulkan drivers.

2017-01-27 Thread Emil Velikov
On 27 January 2017 at 18:14, Bas Nieuwenhuizen wrote: > Had someone that tried --with-vulkan-drivers=radv, this will guide > people in the right direction. > It might be better to update the help string ? That's the thing we do for dri and gallium drivers. -Emil

Re: [Mesa-dev] [Intel-gfx] [PATCH] i965: Share the workaround bo between all contexts

2017-01-27 Thread Chris Wilson
On Fri, Jan 27, 2017 at 06:20:46PM +, Emil Velikov wrote: > On 27 January 2017 at 00:01, Chad Versace wrote: > > On Thu 26 Jan 2017, Chad Versace wrote: > >> On Thu 26 Jan 2017, Chris Wilson wrote: > >> > Since the workaround bo is used strictly as a write-only

Re: [Mesa-dev] [PATCH] radv: automake: Don't install vk_platform.h or vulkan.h.

2017-01-27 Thread Matt Turner
On Fri, Jan 27, 2017 at 10:25 AM, Emil Velikov wrote: > From: Emil Velikov > > These files belong to the vulkan loader. > > Identical to > 045f38a5075 vulkan: Don't install vk_platform.h or vulkan.h. > > Cc: Dave Airlie >

[Mesa-dev] [PATCH] radv: automake: Don't install vk_platform.h or vulkan.h.

2017-01-27 Thread Emil Velikov
From: Emil Velikov These files belong to the vulkan loader. Identical to 045f38a5075 vulkan: Don't install vk_platform.h or vulkan.h. Cc: Dave Airlie Cc: Bas Nieuwenhuizen Cc: Matt Turner Cc: 17.0

Re: [Mesa-dev] [PATCH 0/7] i965: Implement EGL_ANDROID_native_fence_sync

2017-01-27 Thread Rafael Antognolli
On Thu, Jan 26, 2017 at 07:18:24PM -0800, Ben Widawsky wrote: > On 17-01-23 15:32:32, Chad Versace wrote: > > On Fri 20 Jan 2017, Rafael Antognolli wrote: > > > I have tested this series with the branches that you mentioned, and with > > > piglit with the patches from my own branch: > > > > > >

Re: [Mesa-dev] [Intel-gfx] [PATCH] i965: Share the workaround bo between all contexts

2017-01-27 Thread Emil Velikov
On 27 January 2017 at 00:01, Chad Versace wrote: > On Thu 26 Jan 2017, Chad Versace wrote: >> On Thu 26 Jan 2017, Chris Wilson wrote: >> > Since the workaround bo is used strictly as a write-only buffer, we need >> > only allocate one per screen and use the same one from

[Mesa-dev] [PATCH] configure.ac: Augment error message to list vulkan drivers.

2017-01-27 Thread Bas Nieuwenhuizen
Had someone that tried --with-vulkan-drivers=radv, this will guide people in the right direction. Signed-off-by: Bas Nieuwenhuizen CC: --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac

Re: [Mesa-dev] [PATCH mesa v2] gbm/dri: fix memory leaks in error path

2017-01-27 Thread Emil Velikov
On 27 January 2017 at 17:29, Eric Engestrom wrote: > Signed-off-by: Eric Engestrom > --- > v2: add another missing destroy (Emil) > --- > src/gbm/backends/dri/gbm_dri.c | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff

Re: [Mesa-dev] [PATCH 3/8] softpipe: set softpipe_screen::use_llvm when draw is build with LLVM

2017-01-27 Thread Roland Scheidegger
Am 27.01.2017 um 18:20 schrieb Emil Velikov: > On 26 January 2017 at 20:17, Roland Scheidegger wrote: >> Am 26.01.2017 um 19:27 schrieb Emil Velikov: >>> From: Emil Velikov >>> >>> Currently we can build draw without LLVM thus honouring

[Mesa-dev] [PATCH mesa v2] gbm/dri: fix memory leaks in error path

2017-01-27 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- v2: add another missing destroy (Emil) --- src/gbm/backends/dri/gbm_dri.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/gbm/backends/dri/gbm_dri.c b/src/gbm/backends/dri/gbm_dri.c index

Re: [Mesa-dev] [PATCH] anv: handle VK_ERROR_OUT_OF_POOL_MEMORY_KHR error

2017-01-27 Thread Lionel Landwerlin
On 27/01/17 16:26, Eric Engestrom wrote: On Friday, 2017-01-27 17:00:18 +0100, Juan A. Suarez Romero wrote: This fixes dEQP-VK.api.descriptor_pool.out_of_pool_memory test Signed-off-by: Juan A. Suarez Romero Thanks, this is correct, but Lionel Landwerlin already sent [1]

Re: [Mesa-dev] [PATCH 8/8] nouveau: let .get_name() append LLVM if built with LLVM

2017-01-27 Thread Ilia Mirkin
On Fri, Jan 27, 2017 at 12:16 PM, Emil Velikov wrote: > On 26 January 2017 at 19:46, Ilia Mirkin wrote: >> Yeah, I'd much prefer this to be >> >> if (nouveau_screen(pscreen)->class_3d < NV50_3D_CLASS) >> llvm = " LLVM"; >> >> or something along

Re: [Mesa-dev] [PATCH 3/8] softpipe: set softpipe_screen::use_llvm when draw is build with LLVM

2017-01-27 Thread Emil Velikov
On 26 January 2017 at 20:17, Roland Scheidegger wrote: > Am 26.01.2017 um 19:27 schrieb Emil Velikov: >> From: Emil Velikov >> >> Currently we can build draw without LLVM thus honouring SOFTPIPE_USE_LLVM >> is misleading even if most of the code

Re: [Mesa-dev] [PATCH 8/8] nouveau: let .get_name() append LLVM if built with LLVM

2017-01-27 Thread Emil Velikov
On 26 January 2017 at 19:46, Ilia Mirkin wrote: > Yeah, I'd much prefer this to be > > if (nouveau_screen(pscreen)->class_3d < NV50_3D_CLASS) > llvm = " LLVM"; > > or something along those lines. [Using dev->chipset will be annoying > since nv50 = 0x50, and nv67 (nv4x) =

Re: [Mesa-dev] [PATCH 0/8] LLVM requirement for drivers using draw

2017-01-27 Thread Emil Velikov
On 26 January 2017 at 19:32, Marek Olšák wrote: > On Thu, Jan 26, 2017 at 7:58 PM, Emil Velikov > wrote: >> On 26 January 2017 at 18:54, Marek Olšák wrote: >>> They still have to ship LLVM to have GCN support. Or do they simply not

[Mesa-dev] [PATCH 1/3] glsl_parser_extra: Add utility to copy symbols between symbol tables

2017-01-27 Thread Eduardo Lima Mitev
Some symbols gathered in the symbols table during parsing are needed later for the compile and link stages, so they are moved along the process. Currently, only functions and non-temporary variables are copied between symbol tables. However, the built-in input and output interface blocks are also

[Mesa-dev] [PATCH 3/3] glsl/linker: Check that re-declared, inter-shader built-in blocks match

2017-01-27 Thread Eduardo Lima Mitev
From GLSL 4.5 spec, section "7.1 Built-In Language Variables", page 130 of the PDF states: "If multiple shaders using members of a built-in block belonging to the same interface are linked together in the same program, they must all redeclare the built-in block in the same way, as

[Mesa-dev] [PATCH 2/3] glsl: Use the utility function to copy symbols between symbol tables

2017-01-27 Thread Eduardo Lima Mitev
This effectively factorizes a couple of similar routines. --- src/compiler/glsl/glsl_parser_extras.cpp | 18 ++ src/compiler/glsl/linker.cpp | 16 +++- 2 files changed, 5 insertions(+), 29 deletions(-) diff --git a/src/compiler/glsl/glsl_parser_extras.cpp

Re: [Mesa-dev] [PATCH mesa 2/2] radv: add missing extension errors in vk_errorf()

2017-01-27 Thread Bas Nieuwenhuizen
On Thu, Jan 26, 2017, at 06:20, Eric Engestrom wrote: > Signed-off-by: Eric Engestrom > --- > Feel free to reject this if you prefer to add extension errors when > each extension is implemented :) > --- > src/amd/vulkan/radv_util.c | 8 > 1 file changed, 8

Re: [Mesa-dev] [PATCH mesa] gbm/dri: fix memory leaks in error path

2017-01-27 Thread Emil Velikov
On 23 January 2017 at 12:19, Eric Engestrom wrote: > Signed-off-by: Eric Engestrom > --- > src/gbm/backends/dri/gbm_dri.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/src/gbm/backends/dri/gbm_dri.c

Re: [Mesa-dev] [PATCH] anv: handle VK_ERROR_OUT_OF_POOL_MEMORY_KHR error

2017-01-27 Thread Juan A. Suarez Romero
On Fri, 2017-01-27 at 16:26 +, Eric Engestrom wrote: > Thanks, this is correct, but Lionel Landwerlin already sent [1] a more > complete patch. Didn't realize :) Thanks! J.A. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

Re: [Mesa-dev] [PATCH] anv: handle VK_ERROR_OUT_OF_POOL_MEMORY_KHR error

2017-01-27 Thread Eric Engestrom
On Friday, 2017-01-27 17:00:18 +0100, Juan A. Suarez Romero wrote: > This fixes dEQP-VK.api.descriptor_pool.out_of_pool_memory test > > Signed-off-by: Juan A. Suarez Romero Thanks, this is correct, but Lionel Landwerlin already sent [1] a more complete patch. Lionel, can

[Mesa-dev] [PATCH] anv: handle VK_ERROR_OUT_OF_POOL_MEMORY_KHR error

2017-01-27 Thread Juan A. Suarez Romero
This fixes dEQP-VK.api.descriptor_pool.out_of_pool_memory test Signed-off-by: Juan A. Suarez Romero --- src/intel/vulkan/anv_util.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/intel/vulkan/anv_util.c b/src/intel/vulkan/anv_util.c index 6408ac8..7045a78 100644

[Mesa-dev] [Bug 97879] [amdgpu] Rocket League: long hangs (several seconds) when loading assets (models/textures/shaders?)

2017-01-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97879 David Ortner changed: What|Removed |Added CC|

Re: [Mesa-dev] [PATCH] radv: drop support for VK_AMD_NEGATIVE_VIEWPORT_HEIGHT

2017-01-27 Thread Fredrik Höglund
Reviewed-by: Fredrik Höglund On Friday 27 January 2017, Andres Rodriguez wrote: > This extension was not correctly supported, and it conflicts with the > VK_KHR_MAINTENANCE1 spec. > --- > src/amd/vulkan/radv_device.c | 4 > 1 file changed, 4 deletions(-) > > diff --git

Re: [Mesa-dev] [PATCH 01/10] gallium: add a common uploader to pipe_context

2017-01-27 Thread Marek Olšák
On Fri, Jan 27, 2017 at 3:38 PM, Roland Scheidegger wrote: > Am 27.01.2017 um 12:02 schrieb Marek Olšák: >> From: Marek Olšák >> >> For lower memory usage and more efficient updates of the buffer residency >> list. (e.g. if drivers keep seeing the same

[Mesa-dev] [Bug 99517] [TRACKER] Mesa 17.0 release tracker

2017-01-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99517 Emil Velikov changed: What|Removed |Added Depends on||99010

[Mesa-dev] [Bug 99010] --disable-gallium-llvm no longer recognized

2017-01-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99010 Emil Velikov changed: What|Removed |Added Blocks||99517

Re: [Mesa-dev] [PATCH 01/10] gallium: add a common uploader to pipe_context

2017-01-27 Thread Roland Scheidegger
Am 27.01.2017 um 12:02 schrieb Marek Olšák: > From: Marek Olšák > > For lower memory usage and more efficient updates of the buffer residency > list. (e.g. if drivers keep seeing the same buffer for many consecutive > "add" calls, the calls can be turned into no-ops

Re: [Mesa-dev] 10bit HEVC decoding for RadeonSI

2017-01-27 Thread Christian König
Am 27.01.2017 um 13:51 schrieb Mark Thompson: On 26/01/17 16:59, Christian König wrote: Am 26.01.2017 um 13:14 schrieb Mark Thompson: [SNIP] The problem here is I need to know what will be done with the surface from the very beginning. E.g. if you want to scan it out directly to hardware you

Re: [Mesa-dev] [PATCH] gbm: add support for loading third-party backend

2017-01-27 Thread Emil Velikov
Hi Qiang Yu, On 24 January 2017 at 03:36, Qiang Yu wrote: > Third-party can put their backend to a directory configured with > '--with-gbm-backenddir' and create a /etc/gbm.conf.d/*.conf file > which contains the backend so file name to overwrite the default > builtin DRI

[Mesa-dev] [PATCH 1/2] winsys/amdgpu: add one likely() call in amdgpu_cs_flush()

2017-01-27 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/gallium/winsys/amdgpu/drm/amdgpu_cs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/winsys/amdgpu/drm/amdgpu_cs.c b/src/gallium/winsys/amdgpu/drm/amdgpu_cs.c index 0bc4ce941b..789a5dbafa

[Mesa-dev] [PATCH 2/2] winsys/amdgpu: do not iterate twice when adding fence dependencies

2017-01-27 Thread Samuel Pitoiset
The perf difference is very small, 3.25->2.84% in amdgpu_cs_flush() in the DXMD benchmark. Signed-off-by: Samuel Pitoiset --- src/gallium/winsys/amdgpu/drm/amdgpu_cs.c | 63 --- 1 file changed, 32 insertions(+), 31 deletions(-) diff --git

[Mesa-dev] [PATCH] st/mesa: make st_texture_get_sampler_view() static

2017-01-27 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/mesa/state_tracker/st_sampler_view.c | 2 +- src/mesa/state_tracker/st_sampler_view.h | 4 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/src/mesa/state_tracker/st_sampler_view.c

[Mesa-dev] [PATCH] hud: fix compilation warnings in hud_nic_graph_install()

2017-01-27 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/gallium/auxiliary/hud/hud_nic.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/auxiliary/hud/hud_nic.c b/src/gallium/auxiliary/hud/hud_nic.c index f9935dea8b..7e4feb9573 100644 ---

Re: [Mesa-dev] 10bit HEVC decoding for RadeonSI

2017-01-27 Thread Mark Thompson
On 26/01/17 16:59, Christian König wrote: > Am 26.01.2017 um 13:14 schrieb Mark Thompson: >> On 26/01/17 11:00, Christian König wrote: >>> Hi Peter, >>> >>> Am 25.01.2017 um 19:45 schrieb Peter Frühberger: Peter, Rainer any idea what I'm missing here? Do you guys use some

Re: [Mesa-dev] [PATCH] i965: Unbind deleted shaders from brw_context, fixing malloc heisenbug.

2017-01-27 Thread Eero Tamminen
Hi, On 27.01.2017 00:08, Kenneth Graunke wrote: On Thursday, January 26, 2017 12:00:14 PM PST Eric Anholt wrote: Kenneth Graunke writes: Any reason you're not just using _mesa_reference_program()? That might be a better plan. Conceptually, I thought of this more as a

Re: [Mesa-dev] [PATCH 08/10] gallium/vl: use the common uploader

2017-01-27 Thread Christian König
Reviewed-by: Christian König . Am 27.01.2017 um 12:02 schrieb Marek Olšák: From: Marek Olšák --- src/gallium/auxiliary/vl/vl_compositor.c | 14 ++ src/gallium/auxiliary/vl/vl_compositor.h | 1 -

Re: [Mesa-dev] Directly using upstream headers (Was Re: [PATCH] vulkan: Don't install vk_platform.h or vulkan.h.)

2017-01-27 Thread Eric Engestrom
On Thursday, 2017-01-26 18:54:59 +, Emil Velikov wrote: > On 25 January 2017 at 22:10, Chad Versace wrote: > > On Tue 24 Jan 2017, Jason Ekstrand wrote: > >> On Tue, Jan 24, 2017 at 11:25 AM, Emil Velikov > > >> > I'd rather not. That

Re: [Mesa-dev] 10bit HEVC decoding for RadeonSI

2017-01-27 Thread Andy Furniss
Peter Frühberger wrote: just tell us when we can remove: https://github.com/FernetMenta/kodi-agile/blob/master/xbmc/cores/VideoPlayer/DVDCodecs/Video/VAAPI.cpp#L534 Maybe I mis-remember, but doesn't AMD also need some EGL work for VAAPI display with kodi? Would be handy to get kodi to work

Re: [Mesa-dev] [PATCH 8/8] nir/spirv/glsl450: Implement IEEE-compliant handling of atan2(±∞, ±∞).

2017-01-27 Thread Juan A. Suarez Romero
Reviewed-by: Juan A. Suarez Romero On Tue, 2017-01-24 at 15:26 -0800, Francisco Jerez wrote: > --- > src/compiler/spirv/vtn_glsl450.c | 22 +- > 1 file changed, 21 insertions(+), 1 deletion(-) > > diff --git a/src/compiler/spirv/vtn_glsl450.c >

Re: [Mesa-dev] [PATCH 7/8] glsl: Implement IEEE-compliant handling of atan2(±∞, ±∞).

2017-01-27 Thread Juan A. Suarez Romero
Reviewed-by: Juan A. Suarez Romero On Tue, 2017-01-24 at 15:26 -0800, Francisco Jerez wrote: > --- > src/compiler/glsl/builtin_functions.cpp | 22 +- > 1 file changed, 21 insertions(+), 1 deletion(-) > > diff --git

[Mesa-dev] [PATCH 09/10] st/mesa: use the common uploader

2017-01-27 Thread Marek Olšák
From: Marek Olšák --- src/mesa/state_tracker/st_atom_constbuf.c | 6 +++--- src/mesa/state_tracker/st_cb_bitmap.c | 4 ++-- src/mesa/state_tracker/st_cb_drawtex.c| 4 ++-- src/mesa/state_tracker/st_context.c | 28

[Mesa-dev] [PATCH 07/10] gallium/vbuf: use the common uploader

2017-01-27 Thread Marek Olšák
From: Marek Olšák --- src/gallium/auxiliary/util/u_vbuf.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/src/gallium/auxiliary/util/u_vbuf.c b/src/gallium/auxiliary/util/u_vbuf.c index 532e7c0..c26a923 100644 ---

[Mesa-dev] [PATCH 10/10] gallium/radeon: remove the internal u_upload_mgr pointer

2017-01-27 Thread Marek Olšák
From: Marek Olšák also remove the BIND flags --- src/gallium/drivers/r600/r600_state_common.c| 14 +- src/gallium/drivers/radeon/r600_buffer_common.c | 6 -- src/gallium/drivers/radeon/r600_pipe_common.c | 15 +++

[Mesa-dev] [PATCH 08/10] gallium/vl: use the common uploader

2017-01-27 Thread Marek Olšák
From: Marek Olšák --- src/gallium/auxiliary/vl/vl_compositor.c | 14 ++ src/gallium/auxiliary/vl/vl_compositor.h | 1 - src/gallium/state_trackers/va/context.c | 4 3 files changed, 2 insertions(+), 17 deletions(-) diff --git

[Mesa-dev] [PATCH 01/10] gallium: add a common uploader to pipe_context

2017-01-27 Thread Marek Olšák
From: Marek Olšák For lower memory usage and more efficient updates of the buffer residency list. (e.g. if drivers keep seeing the same buffer for many consecutive "add" calls, the calls can be turned into no-ops trivially) --- src/gallium/include/pipe/p_context.h | 7

[Mesa-dev] [PATCH 06/10] gallium/blitter: use the common uploader

2017-01-27 Thread Marek Olšák
From: Marek Olšák --- src/gallium/auxiliary/util/u_blitter.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/src/gallium/auxiliary/util/u_blitter.c b/src/gallium/auxiliary/util/u_blitter.c index 45dc033..447d8d2 100644 ---

[Mesa-dev] [PATCH 04/10] gallium/hud: use the common uploader

2017-01-27 Thread Marek Olšák
From: Marek Olšák --- src/gallium/auxiliary/hud/hud_context.c | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/src/gallium/auxiliary/hud/hud_context.c b/src/gallium/auxiliary/hud/hud_context.c index a635797..6caf821 100644 ---

[Mesa-dev] [PATCH 05/10] gallium/primconvert: use the common uploader

2017-01-27 Thread Marek Olšák
From: Marek Olšák --- src/gallium/auxiliary/indices/u_primconvert.c | 12 ++-- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/src/gallium/auxiliary/indices/u_primconvert.c b/src/gallium/auxiliary/indices/u_primconvert.c index 5effd88..2bdfade 100644

[Mesa-dev] [PATCH 03/10] gallium: set pipe_context::stream_uploader

2017-01-27 Thread Marek Olšák
From: Marek Olšák Notes: - make sure the default size is large enough to handle all state trackers - pipe wrappers don't receive transfer calls from stream_uploader, because pipe_context::stream_uploader points directly to the underlying driver's stream_uploader (to keep

[Mesa-dev] [PATCH 02/10] gallium/u_upload_mgr: add a helper that creates the default uploader

2017-01-27 Thread Marek Olšák
From: Marek Olšák --- src/gallium/auxiliary/util/u_upload_mgr.c | 9 + src/gallium/auxiliary/util/u_upload_mgr.h | 7 +++ 2 files changed, 16 insertions(+) diff --git a/src/gallium/auxiliary/util/u_upload_mgr.c b/src/gallium/auxiliary/util/u_upload_mgr.c index

Re: [Mesa-dev] [RFC PATCH] gallium: add a common uploader to pipe_context

2017-01-27 Thread Marek Olšák
On Fri, Jan 27, 2017 at 10:05 AM, Nicolai Hähnle wrote: > On 27.01.2017 00:51, Marek Olšák wrote: >> >> From: Marek Olšák >> >> For lower memory usage and more efficient updates of the buffer residency >> list. (e.g. if drivers keep seeing the same buffer

[Mesa-dev] [PATCH 2/2] glx/dri3: handle NULL pointers in loader-to-DRI3 drawable conversion

2017-01-27 Thread Nicolai Hähnle
From: Nicolai Hähnle With the previous patch, we can now get NULL loaderPrivates, e.g. when a DRIdrawable is flushed whose corresponding GLXDRIdrawable was destroyed. This resulted in a crash, since the loader vs. DRI3 drawable structures have a non-zero offset. Fixes

[Mesa-dev] [PATCH 1/2] dri/common: clear the loaderPrivate pointer in driDestroyDrawable

2017-01-27 Thread Nicolai Hähnle
From: Nicolai Hähnle This fixes memory corruption in piglit ./bin/glx-visuals-depth/stencil -pixmap -auto Cc: 17.0 --- src/mesa/drivers/dri/common/dri_util.c | 12 1 file changed, 12 insertions(+) diff --git

Re: [Mesa-dev] [PATCH 3/8] glsl/ir_builder: Add rcp builder.

2017-01-27 Thread Juan A. Suarez Romero
Reviewed-by: Juan A. Suarez Romero On Tue, 2017-01-24 at 15:26 -0800, Francisco Jerez wrote: > --- > src/compiler/glsl/ir_builder.cpp | 6 ++ > src/compiler/glsl/ir_builder.h | 1 + > 2 files changed, 7 insertions(+) > > diff --git a/src/compiler/glsl/ir_builder.cpp

Re: [Mesa-dev] [PATCH 2/8] glsl: Fix constant evaluation of the rcp op.

2017-01-27 Thread Juan A. Suarez Romero
On Tue, 2017-01-24 at 15:26 -0800, Francisco Jerez wrote: > Will avoid a regression in a future commit that introduces some > additional rcp operations. Reviewed-by: Juan A. Suarez Romero > --- > src/compiler/glsl/ir_expression_operation.py | 2 +- > 1 file changed, 1

Re: [Mesa-dev] [PATCH 2/8] glsl: Fix constant evaluation of the rcp op.

2017-01-27 Thread Juan A. Suarez Romero
On Tue, 2017-01-24 at 17:06 -0800, Ian Romanick wrote: > On 01/24/2017 03:26 PM, Francisco Jerez wrote: > > Will avoid a regression in a future commit that introduces some > > additional rcp operations. > > When I converted GLSL IR to ir_expression_operation.py, I was careful to > keep all the

Re: [Mesa-dev] [PATCH] st/va encode handle ntsc framerate rate control

2017-01-27 Thread Christian König
That looks correct to me, but I'm not deeply enough into the H264 encoding any more. Adding Leo and Boyuan to comment as well. Regards, Christian. Am 26.01.2017 um 19:26 schrieb Andy Furniss: Tested with ffmpeg and gst-vaapi. Without this bits per frame is set way too low. Signed-off-by:

Re: [Mesa-dev] [PATCH] radv: use proper maximum slice for layered view

2017-01-27 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Thu, Jan 26, 2017, at 19:47, Dave Airlie wrote: > From: Dave Airlie > > this fixes deferred shadows with geom shaders enabled. > > but I think this fix is fine by itself. > > Signed-off-by: Dave Airlie

Re: [Mesa-dev] [PATCH 1/8] mesa/program: Translate csel operation from GLSL IR.

2017-01-27 Thread Juan A. Suarez Romero
Reviewed-by: Juan A. Suarez Romero On Tue, 2017-01-24 at 15:26 -0800, Francisco Jerez wrote: > This will be used internally by the GLSL front-end in order to > implement some built-in functions. Plumb it through MESA IR for > back-ends that rely on this translation pass. >

Re: [Mesa-dev] [PATCH] gallium/radeon: add a new HUD query for the number of mapped buffers

2017-01-27 Thread Christian König
Am 27.01.2017 um 10:33 schrieb Samuel Pitoiset: On 01/26/2017 12:07 PM, Christian König wrote: Am 26.01.2017 um 12:01 schrieb Samuel Pitoiset: On 01/26/2017 03:45 AM, Michel Dänzer wrote: On 25/01/17 11:19 PM, Samuel Pitoiset wrote: On 01/25/2017 03:56 AM, Michel Dänzer wrote: On

Re: [Mesa-dev] [PATCH 2/2] spirv: handle undefined components for OpVectorShuffle

2017-01-27 Thread Juan A. Suarez Romero
On Fri, 2017-01-27 at 09:46 +, Lionel Landwerlin wrote: > > But what the test does is calling OpSpecConstantOp[2], which is the > > operation we are patching here. > > > > And according to the spec, "all Operands must be the s of other > > constant instructions", being constant instructions

  1   2   >