Re: [Mesa-dev] [PATCH:mesa] util: Make xmlconfig.c build on Solaris without d_type in dirent

2018-10-03 Thread Roland Mainz
On Thu, Oct 4, 2018 at 5:21 AM Alan Coopersmith wrote: > On 10/ 3/18 03:15 PM, Roland Mainz wrote: > > On Wed, Oct 3, 2018 at 11:51 PM Alan Coopersmith > > wrote: > >> Introduced-by: commit 04bdbbcab3c4862bf3f54ce60fcc1d2007776f80 > >> Signed-off-by: Alan Coopersmith > >> --- > >>

[Mesa-dev] [Bug 77449] Tracker bug for all bugs related to Steam titles

2018-10-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=77449 Bug 77449 depends on bug 101739, which changed state. Bug 101739 Summary: An issue with alpha-to-coverage handling is causing Arma 3 64-bit Linux port to render trees incorrectly https://bugs.freedesktop.org/show_bug.cgi?id=101739

Re: [Mesa-dev] [PATCH:mesa] util: Make xmlconfig.c build on Solaris without d_type in dirent

2018-10-03 Thread Alan Coopersmith
On 10/ 3/18 03:15 PM, Roland Mainz wrote: On Wed, Oct 3, 2018 at 11:51 PM Alan Coopersmith wrote: Introduced-by: commit 04bdbbcab3c4862bf3f54ce60fcc1d2007776f80 Signed-off-by: Alan Coopersmith --- src/util/xmlconfig.c | 8 1 file changed, 8 insertions(+) diff --git

[Mesa-dev] [Bug 108165] Assembler is incompatible with musl

2018-10-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108165 Nicholas Miell changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW

[Mesa-dev] [Bug 35268] initial-exec TLS model breaks dlopen'ed libGL

2018-10-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35268 Nicholas Miell changed: What|Removed |Added CC||r...@burtonini.com --- Comment #21

Re: [Mesa-dev] [PATCH V2 6/6] util: disable cache if we have no build-id and timestamp is zero

2018-10-03 Thread Timothy Arceri
On 3/10/18 8:49 pm, Emil Velikov wrote: HI Tim, On Wed, 19 Sep 2018 at 23:55, Timothy Arceri wrote: Timestamp can be zero for example when Flatpak is used. In this case just disable the cache rather then segfaulting when incompatible cache items are loaded. V2: actually return false when

Re: [Mesa-dev] [PATCH 1/2] spirv/nir: handle memory access qualifiers for SSBO loads/stores

2018-10-03 Thread Jason Ekstrand
On Wed, Oct 3, 2018 at 4:07 PM Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset > --- > src/compiler/nir/nir_intrinsics.py | 4 ++-- > src/compiler/spirv/spirv_to_nir.c | 29 ++--- > src/compiler/spirv/vtn_private.h | 3 +++ >

Re: [Mesa-dev] [PATCH:mesa] util: Make xmlconfig.c build on Solaris without d_type in dirent

2018-10-03 Thread Roland Mainz
On Wed, Oct 3, 2018 at 11:51 PM Alan Coopersmith wrote: > > Introduced-by: commit 04bdbbcab3c4862bf3f54ce60fcc1d2007776f80 > Signed-off-by: Alan Coopersmith > --- > src/util/xmlconfig.c | 8 > 1 file changed, 8 insertions(+) > > diff --git a/src/util/xmlconfig.c b/src/util/xmlconfig.c

[Mesa-dev] [Bug 108112] [vulkancts] some of the coherent memory tests fail.

2018-10-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108112 --- Comment #2 from Bas Nieuwenhuizen --- So I think these are the pre-memory model tests added at the same time of the memory model tests, so these are supposed to be passing without implementing the new memory model stuff and are mostly about

Re: [Mesa-dev] [PATCH 1/2] spirv/nir: handle memory access qualifiers for SSBO loads/stores

2018-10-03 Thread Bas Nieuwenhuizen
This patch is r-b, but maybe get Jason to look at it? On Wed, Oct 3, 2018 at 11:07 PM Samuel Pitoiset wrote: > > Signed-off-by: Samuel Pitoiset > --- > src/compiler/nir/nir_intrinsics.py | 4 ++-- > src/compiler/spirv/spirv_to_nir.c | 29 ++--- >

Re: [Mesa-dev] [PATCH 2/2] radv: emit the GLC bit for SSBO loads/stores when needed

2018-10-03 Thread Bas Nieuwenhuizen
This patch is r-b. On Wed, Oct 3, 2018 at 11:07 PM Samuel Pitoiset wrote: > > This fixes some new memory model tests: > dEQP-VK.memory_model.message_passing.core11.u32.coherent.fence_fence.atomicwrite.device.* > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108112 > Signed-off-by:

Re: [Mesa-dev] [PATCH] i965: fallback RGBX to RGBA in glEGLImageTargetRenderbufferStorageOES

2018-10-03 Thread Gurchetan Singh
Reviewed-by: Gurchetan Singh On Wed, Oct 3, 2018 at 2:53 AM Tapani Pälli wrote: > > From: "Chystiakov, Dmytro" > > In the same fashion as is done for glEGLImageTextureTarget2D. > > v2: share the fallback which sets baseformat and internalformat correctly > which makes both of the tests pass

[Mesa-dev] [PATCH 1/2] spirv/nir: handle memory access qualifiers for SSBO loads/stores

2018-10-03 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/compiler/nir/nir_intrinsics.py | 4 ++-- src/compiler/spirv/spirv_to_nir.c | 29 ++--- src/compiler/spirv/vtn_private.h | 3 +++ src/compiler/spirv/vtn_variables.c | 16 4 files changed, 43 insertions(+), 9

[Mesa-dev] [PATCH 2/2] radv: emit the GLC bit for SSBO loads/stores when needed

2018-10-03 Thread Samuel Pitoiset
This fixes some new memory model tests: dEQP-VK.memory_model.message_passing.core11.u32.coherent.fence_fence.atomicwrite.device.* Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108112 Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_llvm_build.c | 5 +++--

Re: [Mesa-dev] [PATCH 11/11] nir: Copy propagation between blocks

2018-10-03 Thread Jason Ekstrand
On Sat, Sep 15, 2018 at 12:46 AM Caio Marcelo de Oliveira Filho < caio.olive...@intel.com> wrote: > Extend the pass to propagate the copies information along the control > flow graph. It performs two walks, first it collects the vars > that were written inside each node. Then it walks applying

Re: [Mesa-dev] [PATCH] gallivm: Make it possible to disable some optimization shortcuts in release builds

2018-10-03 Thread Roland Scheidegger
Is it worth it splitting out to another var? We actually have code branches internally where we just define the gallivm_debug var always, and some of the debug flags outside the #ifdef debug (we'll actually need more than just these 3 accessible outside debug builds). If you think this is

[Mesa-dev] [Bug 108112] [vulkancts] some of the coherent memory tests fail.

2018-10-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108112 --- Comment #1 from Jason Ekstrand --- This may help and/or be applicable: https://patchwork.freedesktop.org/series/49443/ -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the

Re: [Mesa-dev] [PATCH 06/11] intel/nir: Use the separated dead write vars pass

2018-10-03 Thread Jason Ekstrand
I see what you're doing now. I just saw patch 8. Still, 6-8 could go together. Doesn't really matter I guess. --Jason On Wed, Oct 3, 2018 at 2:40 PM Jason Ekstrand wrote: > This should probably be squashed into patch 5 > > On Sat, Sep 15, 2018 at 12:46 AM Caio Marcelo de Oliveira Filho < >

Re: [Mesa-dev] [PATCH 06/11] intel/nir: Use the separated dead write vars pass

2018-10-03 Thread Jason Ekstrand
This should probably be squashed into patch 5 On Sat, Sep 15, 2018 at 12:46 AM Caio Marcelo de Oliveira Filho < caio.olive...@intel.com> wrote: > No changes to shader-db. > --- > src/intel/compiler/brw_nir.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/intel/compiler/brw_nir.c

[Mesa-dev] [PATCH] nir/alu_to_scalar: Use ssa_for_alu_src in hand-rolled expansions

2018-10-03 Thread Jason Ekstrand
The ssa_for_alu_src helper will correctly handle swizzles and other source modifiers for you. The expansions for unpack_half_2x16, pack_uvec2_to_uint, and pack_uvec4_to_uint were all broken with regards to swizzles. The brokenness of unpack_half_2x16 was causing rendering errors in Rise of the

Re: [Mesa-dev] [PATCH 7/7] meson: egl: group dri2 bits separately from haiku

2018-10-03 Thread Dylan Baker
Quoting Emil Velikov (2018-10-03 07:02:47) > One cannot have haiku and dri2 - surfaceless,x11,etc. > > Group things up, which will make the addition of platform_device a bit > easier. > > Signed-off-by: Emil Velikov > --- > View with git show -w to omit the whitespace changes. > --- >

Re: [Mesa-dev] [PATCH v4 2/2] virgl: Pass resource size and transfer offsets

2018-10-03 Thread Gurchetan Singh
On Tue, Oct 2, 2018 at 12:08 AM Gert Wollny wrote: > > From: Tomeu Vizoso > > Pass the size of a resource when creating it so a backing can be kept in > the other side. > > Also pass the required offset to transfer commands. > > This moves vtest closer to how virtio-gpu works, making it more

Re: [Mesa-dev] [PATCH v2] meson: Don't allow building EGL on Windows or MacOS

2018-10-03 Thread Dylan Baker
Quoting Dylan Baker (2018-10-03 10:35:45) > Currently mesa only supports EGL on Unix like systems, cygwin, and > haiku. Meson should actually enforce this. This fixes the default build > on MacOS. > > v2: - invert the condition, mark darwin and windows as not supported > instead of trying

[Mesa-dev] [PATCH v2] meson: Don't allow building EGL on Windows or MacOS

2018-10-03 Thread Dylan Baker
Currently mesa only supports EGL on Unix like systems, cygwin, and haiku. Meson should actually enforce this. This fixes the default build on MacOS. v2: - invert the condition, mark darwin and windows as not supported instead of trying to mark what is supported. CC: 18.2 --- meson.build

Re: [Mesa-dev] [PATCH] meson: Don't allow building EGL on on KMS systems or Haiku

2018-10-03 Thread Dylan Baker
Quoting Emil Velikov (2018-10-03 09:42:32) > On Wed, 3 Oct 2018 at 16:29, Dylan Baker wrote: > > > > Quoting Emil Velikov (2018-10-03 04:06:43) > > > On Mon, 1 Oct 2018 at 20:44, Dylan Baker wrote: > > > > > > > > Currently mesa only supports EGL for KMS (Linux, *BSD) systems and > > > > Haiku,

Re: [Mesa-dev] [PATCH] util/u_queue: don't inherit thread affinity from parent thread

2018-10-03 Thread Marek Olšák
On Wed, Oct 3, 2018 at 4:16 AM Eero Tamminen wrote: > > Hi, > > On 10/3/18 2:00 AM, Marek Olšák wrote: > > On Tue, Oct 2, 2018 at 6:36 PM Rob Clark wrote: > >> On Tue, Oct 2, 2018 at 6:30 PM Marek Olšák wrote: > >>> From: Marek Olšák > [...] > >> Just curious (and maybe I missed some previous

Re: [Mesa-dev] [PATCH 0/2] Fix the value of discreteQueuePriorities

2018-10-03 Thread Gabriel Majeri
I think the changes should be fine on stable. It's a breaking change in theory, but I haven't found any Vulkan apps / libraries / engines which rely on this value yet (and anv doesn't support queue priorities yet, anyway). În mie., 3 oct. 2018 la 13:49, Emil Velikov a scris: > Hi Gabriel, > >

Re: [Mesa-dev] [PATCH] meson: Don't allow building EGL on on KMS systems or Haiku

2018-10-03 Thread Emil Velikov
On Wed, 3 Oct 2018 at 16:29, Dylan Baker wrote: > > Quoting Emil Velikov (2018-10-03 04:06:43) > > On Mon, 1 Oct 2018 at 20:44, Dylan Baker wrote: > > > > > > Currently mesa only supports EGL for KMS (Linux, *BSD) systems and > > > Haiku, we should actually enforce this. This fixes the default

Re: [Mesa-dev] [ANNOUNCE] Mesa 18.2.2 release candidate

2018-10-03 Thread Juan A. Suarez Romero
On Wed, 2018-10-03 at 16:54 +0200, Michel Dänzer wrote: > On 2018-10-03 2:41 p.m., Juan A. Suarez Romero wrote: > > Hello list, > > > > The candidate for the Mesa 18.2.2 is now available. Currently we have: > > - 20 queued (+1 squashed) > > - 2 nominated (outstanding) > > - and 0 rejected

Re: [Mesa-dev] [PATCH] st/va:Aligned image width and height to 16.

2018-10-03 Thread Sharma, Deepak
I understand the problem with vlVaGetImage not respecting parameter and that has to be fixed. Christian, could you please provide some more input on addrlib alignment for fixing this. Thanks, Deepak -Original Message- From: Ilia Mirkin Sent: Wednesday, October 3, 2018 8:03 AM To:

Re: [Mesa-dev] [PATCH 1/2] glx: remove unused __glXPreferEGL() declaration

2018-10-03 Thread Brian Paul
Reviewed-by: Brian Paul On 10/3/18 6:12 AM, Emil Velikov wrote: > From: Emil Velikov > > The function definition is no longer around, drop the useless declaration. > > Cc: Brian Paul > Signed-off-by: Emil Velikov > --- > src/glx/glxclient.h | 2 -- > 1 file changed, 2 deletions(-) > > diff

[Mesa-dev] [PATCH v2 6/6] radeonsi:optimizing SET_CONTEXT_REG for shaders vgt_vertex_reuse

2018-10-03 Thread Sonny Jiang
Signed-off-by: Sonny Jiang --- src/gallium/drivers/radeonsi/si_gfx_cs.c| 1 + src/gallium/drivers/radeonsi/si_shader.h| 1 + src/gallium/drivers/radeonsi/si_state.h | 1 + src/gallium/drivers/radeonsi/si_state_shaders.c | 17 +++-- 4 files changed, 18

[Mesa-dev] [PATCH v2 4/6] radeonsi:optimizing SET_CONTEXT_REG for shaders PS

2018-10-03 Thread Sonny Jiang
Signed-off-by: Sonny Jiang --- src/gallium/drivers/radeonsi/si_gfx_cs.c | 7 +++ src/gallium/drivers/radeonsi/si_state.h | 11 .../drivers/radeonsi/si_state_shaders.c | 56 ++- 3 files changed, 60 insertions(+), 14 deletions(-) diff --git

[Mesa-dev] [PATCH v2 5/6] radeonsi:optimizing SET_CONTEXT_REG for shaders Tessellation

2018-10-03 Thread Sonny Jiang
Signed-off-by: Sonny Jiang --- src/gallium/drivers/radeonsi/si_gfx_cs.c | 1 + src/gallium/drivers/radeonsi/si_shader.h | 3 +++ src/gallium/drivers/radeonsi/si_state.h | 1 + .../drivers/radeonsi/si_state_shaders.c | 26 +++ 4 files changed, 26

[Mesa-dev] [PATCH v2 3/6] radeonsi:optimizing SET_CONTEXT_REG for shaders VS

2018-10-03 Thread Sonny Jiang
Signed-off-by: Sonny Jiang --- src/gallium/drivers/radeonsi/si_gfx_cs.c | 6 ++ src/gallium/drivers/radeonsi/si_state.h | 6 ++ .../drivers/radeonsi/si_state_shaders.c | 98 --- 3 files changed, 77 insertions(+), 33 deletions(-) diff --git

[Mesa-dev] [PATCH v2 2/6] radeonsi:optimizing SET_CONTEXT_REG for shaders GS

2018-10-03 Thread Sonny Jiang
Signed-off-by: Sonny Jiang --- src/gallium/drivers/radeonsi/si_gfx_cs.c | 15 ++- src/gallium/drivers/radeonsi/si_shader.h | 39 +++ src/gallium/drivers/radeonsi/si_state.h | 19 +++- .../drivers/radeonsi/si_state_shaders.c | 105 ++ 4 files changed,

[Mesa-dev] [PATCH v2 1/6] radeonsi: optimizing SET_CONTEXT_REG for shaders ES

2018-10-03 Thread Sonny Jiang
Signed-off-by: Sonny Jiang --- src/gallium/drivers/radeonsi/si_gfx_cs.c | 1 + src/gallium/drivers/radeonsi/si_pm4.c | 3 +++ src/gallium/drivers/radeonsi/si_pm4.h | 11 + src/gallium/drivers/radeonsi/si_state.h | 9 ++--

Re: [Mesa-dev] Meson-windows v4 (9/21/2018 rebase): LLVM linking problems

2018-10-03 Thread Dylan Baker
Quoting Liviu Prodea (2018-10-03 01:03:43) > > Automatic wrap with llvm-config does get the version right so it has to be > something else. > > I usually build LLVM myself like this: > > > cd llvm-7.0.0.src & md buildsys-x86 & cd buildsys-x86 & cmake -G "Ninja" > -Thost > =x64

Re: [Mesa-dev] [PATCH] meson: Don't allow building EGL on on KMS systems or Haiku

2018-10-03 Thread Dylan Baker
Quoting Emil Velikov (2018-10-03 04:06:43) > On Mon, 1 Oct 2018 at 20:44, Dylan Baker wrote: > > > > Currently mesa only supports EGL for KMS (Linux, *BSD) systems and > > Haiku, we should actually enforce this. This fixes the default build on > > MacOS. > > Currently you can build EGL on Linux,

Re: [Mesa-dev] [PATCH] anv: Use separate MOCS settings for external BOs

2018-10-03 Thread Eero Tamminen
Hi, On 10/3/18 12:11 AM, Jason Ekstrand wrote: On Broadwell and above, we have to use different MOCS settings to allow the kernel to take over and disable caching when needed for external buffers. On Broadwell, this is especially important because the kernel can't disable eLLC so we have to do

Re: [Mesa-dev] [PATCH] st/va:Aligned image width and height to 16.

2018-10-03 Thread Ilia Mirkin
On Wed, Oct 3, 2018 at 10:59 AM Koenig, Christian wrote: > > Am 03.10.2018 um 16:56 schrieb Ilia Mirkin: > > On Wed, Oct 3, 2018 at 9:36 AM Christian König > > wrote: > >> What the heck are you talking about? As far as I can see this patch is > >> about adding hw specific alignment to

Re: [Mesa-dev] [PATCH] st/va:Aligned image width and height to 16.

2018-10-03 Thread Koenig, Christian
Am 03.10.2018 um 16:56 schrieb Ilia Mirkin: > On Wed, Oct 3, 2018 at 9:36 AM Christian König > wrote: >> What the heck are you talking about? As far as I can see this patch is >> about adding hw specific alignment to vlVaCreateImage which is a state >> tracker function. >> >> Completely agree

Re: [Mesa-dev] [PATCH] st/va:Aligned image width and height to 16.

2018-10-03 Thread Ilia Mirkin
On Wed, Oct 3, 2018 at 9:36 AM Christian König wrote: > > What the heck are you talking about? As far as I can see this patch is > about adding hw specific alignment to vlVaCreateImage which is a state > tracker function. > > Completely agree that vlVaGetImage should respect the parameters given

Re: [Mesa-dev] [ANNOUNCE] Mesa 18.2.2 release candidate

2018-10-03 Thread Michel Dänzer
On 2018-10-03 2:41 p.m., Juan A. Suarez Romero wrote: > Hello list, > > The candidate for the Mesa 18.2.2 is now available. Currently we have: > - 20 queued (+1 squashed) > - 2 nominated (outstanding) > - and 0 rejected patches > > The current queue consists of: > > Different patches for the

[Mesa-dev] [Bug 108065] Launching SteamVR results in nir_deref_instr_remove_if_unused assert

2018-10-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108065 Samuel Pitoiset changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

[Mesa-dev] [Bug 100960] Special block from Minecraft mod rendered out of place

2018-10-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100960 --- Comment #13 from Fabian Maurer --- Created attachment 141856 --> https://bugs.freedesktop.org/attachment.cgi?id=141856=edit vr.trace windows picture Attaching the requested picture. -- You are receiving this mail because: You are the

[Mesa-dev] [PATCH 5/7] egl: set the EGLDevice when creating a display

2018-10-03 Thread Emil Velikov
From: Emil Velikov This is the final requirement from the base EGLDevice spec. v2: - split from another patch - move wayland hunk after we have the fd Signed-off-by: Emil Velikov --- src/egl/drivers/dri2/egl_dri2.h | 1 + src/egl/drivers/dri2/platform_android.c | 9

[Mesa-dev] [PATCH 4/7] egl: add EGL_EXT_device_drm support

2018-10-03 Thread Emil Velikov
From: Emil Velikov Add implementation based around the drmDevice API. As such it's only available only when building with libdrm. With the latter already a requirement when using !SW code paths in the platform code. Note: the current code will work if a device is hot-plugged. Yet hot-unplugged

[Mesa-dev] [PATCH 6/7] egl: enable EGL_EXT_device_{base, enumeration, query}

2018-10-03 Thread Emil Velikov
From: Emil Velikov Now that we support the extensions, fully, enabled them. The specs mandate that we always have at least one device and each dpy has a device associated with it. Signed-off-by: Emil Velikov --- src/egl/main/eglglobals.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

[Mesa-dev] [PATCH 7/7] meson: egl: group dri2 bits separately from haiku

2018-10-03 Thread Emil Velikov
One cannot have haiku and dri2 - surfaceless,x11,etc. Group things up, which will make the addition of platform_device a bit easier. Signed-off-by: Emil Velikov --- View with git show -w to omit the whitespace changes. --- src/egl/meson.build | 71 ++---

[Mesa-dev] [PATCH 2/7] specs: Add EGL_MESA_device_software

2018-10-03 Thread Emil Velikov
From: Adam Jackson The device extension string is expected to contain the name of the extension defining what kind of device it is, so the caller can know what kinds of operations it can perform with it. So that string had better be non-empty, hence this trivial extension. v2: - drop

[Mesa-dev] [PATCH 0/7] EGLDevice, take 2.1

2018-10-03 Thread Emil Velikov
Hi all, This re-spin of the series includes: - correct flipped asserts - cosmetic wording/comment fixes - drop EGL_EXT_platform_device patches (swrast is broken) - add the EGL_MESA_device_software spec patch At this point we should be pretty much set, so any formal Ack/Rb will be

[Mesa-dev] [PATCH 1/7] egl: add base EGL_EXT_device_base implementation

2018-10-03 Thread Emil Velikov
From: Emil Velikov Introduce the API for device query and enumeration. Those at the moment produce nothing useful since zero devices are actually available. That contradicts with the spec, so the extension isn't advertised just yet. With later commits we'll add support for software (always)

[Mesa-dev] [PATCH 3/7] egl: add EGL_MESA_device_software support

2018-10-03 Thread Emil Velikov
From: Emil Velikov Add a plain software device, which is always available. We can safely assign it as the first/initial device in _eglGlobals, although we ensure that's the case with a handful of _eglDeviceSupports checks throughout the code. v2: - s/_eglFindDevice/_eglAddDevice/ (Eric) -

[Mesa-dev] [PATCH 3/3] radv: tidy up radv_pipeline_init_multisample_state()

2018-10-03 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_pipeline.c | 35 -- 1 file changed, 16 insertions(+), 19 deletions(-) diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c index 2db44cb24f..b39e8b62bb 100644 ---

[Mesa-dev] [PATCH 2/3] radv: always set PA_SC_MODE_CNTL_1.OUT_OF_ORDER_WATER_MARK

2018-10-03 Thread Samuel Pitoiset
It has probably no effect without out of order rasterization anyway. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_pipeline.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c index

[Mesa-dev] [PATCH 1/3] radv: set DB_EQAA.INCOHERENT_EQAA_READS

2018-10-03 Thread Samuel Pitoiset
My attempt was to set this field instead of duplicating one. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_pipeline.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c index 4b626a59af..6b3e120802 100644

Re: [Mesa-dev] [PATCH] anv/batch_chain: Don't start a new BO just for BATCH_BUFFER_START

2018-10-03 Thread Lionel Landwerlin
On 03/10/2018 00:24, Jason Ekstrand wrote: Previously, we just went ahead and emitted MI_BATCH_BUFFER_START as normal. If we are near enough to the end, this can cause us to start a new BO just for the MI_BATCH_BUFFER_START which messes up chaining. We always reserve enough space at the end

Re: [Mesa-dev] [PATCH] anv: Use separate MOCS settings for external BOs

2018-10-03 Thread Lionel Landwerlin
On 02/10/2018 23:11, Jason Ekstrand wrote: On Broadwell and above, we have to use different MOCS settings to allow the kernel to take over and disable caching when needed for external buffers. On Broadwell, this is especially important because the kernel can't disable eLLC so we have to do it

[Mesa-dev] [Bug 108165] Assembler is incompatible with musl

2018-10-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108165 Bug ID: 108165 Summary: Assembler is incompatible with musl Product: Mesa Version: 18.1 Hardware: Other OS: All Status: NEW Severity: normal

Re: [Mesa-dev] [PATCH] st/va:Aligned image width and height to 16.

2018-10-03 Thread Christian König
What the heck are you talking about? As far as I can see this patch is about adding hw specific alignment to vlVaCreateImage which is a state tracker function. Completely agree that vlVaGetImage should respect the parameters given instead of using the one from the surface, but that sounds

Re: [Mesa-dev] [PATCH] anv/batch_chain: Don't start a new BO just for BATCH_BUFFER_START

2018-10-03 Thread Jason Ekstrand
On Wed, Oct 3, 2018 at 8:23 AM Alex Smith wrote: > Fixes a crash I see on Broadwell. > > Tested-by: Alex Smith > Thanks! > Cc to stable for 18.2? The crash is reproducible there as well. > The "Fixes:" tag should take care of that. --Jason > On Tue, 2 Oct 2018 at 23:25, Jason Ekstrand

Re: [Mesa-dev] [PATCH] glsl/linker: Check the subroutine associated functions names

2018-10-03 Thread Vadim Shovkoplias
Hi Iago, I also think that compiler is the best place for the fix. But from my understanding compiler fix will be limited to distinct shader objects (not the shader stage). In GLSL spec mentioned: "A program will fail to compile or link if any *shader or stage* contains two or more functions with

Re: [Mesa-dev] [PATCH] anv/batch_chain: Don't start a new BO just for BATCH_BUFFER_START

2018-10-03 Thread Alex Smith
Fixes a crash I see on Broadwell. Tested-by: Alex Smith Cc to stable for 18.2? The crash is reproducible there as well. On Tue, 2 Oct 2018 at 23:25, Jason Ekstrand wrote: > Previously, we just went ahead and emitted MI_BATCH_BUFFER_START as > normal. If we are near enough to the end, this

[Mesa-dev] [PATCH 2/2] glx: be explicit about when mapping X <> GLX visuals

2018-10-03 Thread Emil Velikov
From: Emil Velikov Write down both X and GLX visual types when mapping from one to the other. Makes grepping through the code a tiny bit easier. Signed-off-by: Emil Velikov --- src/glx/glxext.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/glx/glxext.c

[Mesa-dev] [PATCH 1/2] glx: remove unused __glXPreferEGL() declaration

2018-10-03 Thread Emil Velikov
From: Emil Velikov The function definition is no longer around, drop the useless declaration. Cc: Brian Paul Signed-off-by: Emil Velikov --- src/glx/glxclient.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/glx/glxclient.h b/src/glx/glxclient.h index f3a36cf106b..df51f2b8ce4

[Mesa-dev] [Bug 108164] [radv] VM faults since 5d6a560a2986c9ab421b3c7904d29bb7bc35e36f

2018-10-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108164 Józef Kucia changed: What|Removed |Added Keywords||bisected, regression -- You are

[Mesa-dev] [Bug 108164] [radv] VM faults since 5d6a560a2986c9ab421b3c7904d29bb7bc35e36f

2018-10-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108164 Bug ID: 108164 Summary: [radv] VM faults since 5d6a560a2986c9ab421b3c7904d29bb7bc35e36f Product: Mesa Version: git Hardware: Other OS: Linux (All)

Re: [Mesa-dev] [PATCH 4/5] vulkan/wsi: Use the interface from the real modifiers extension

2018-10-03 Thread Jason Ekstrand
On Wed, Oct 3, 2018 at 6:15 AM Daniel Stone wrote: > Hi, > > On Mon, 1 Oct 2018 at 22:25, Jason Ekstrand wrote: > > index 70594d6c053..2850349a619 100644 > > --- a/src/intel/vulkan/anv_image.c > > +++ b/src/intel/vulkan/anv_image.c > > @@ -109,6 +109,8 @@ choose_isl_tiling_flags(const struct >

[Mesa-dev] [ANNOUNCE] Mesa 18.2.2 release candidate

2018-10-03 Thread Juan A. Suarez Romero
Hello list, The candidate for the Mesa 18.2.2 is now available. Currently we have: - 20 queued (+1 squashed) - 2 nominated (outstanding) - and 0 rejected patches The current queue consists of: Different patches for the DirectX9 and DRI state trackers. A patch to implement

[Mesa-dev] [Bug 108160] GLSL version >=1.30 built-in functions present in version <1.30

2018-10-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108160 Bug ID: 108160 Summary: GLSL version >=1.30 built-in functions present in version <1.30 Product: Mesa Version: 18.2 Hardware: Other OS: All

[Mesa-dev] [Bug 100960] Special block from Minecraft mod rendered out of place

2018-10-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100960 --- Comment #12 from Sergii Romantsov --- Created attachment 141846 --> https://bugs.freedesktop.org/attachment.cgi?id=141846=edit vr.trace -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for

[Mesa-dev] [Bug 100960] Special block from Minecraft mod rendered out of place

2018-10-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100960 --- Comment #11 from Sergii Romantsov --- Hello again. Fabian, could you, please, do one more thing: use trace vr.trace and provide an image that it gives on Windows? And Timothy, could you, please, do the same for Nvidia Linux driver? --

Re: [Mesa-dev] [PATCH] util/u_queue: don't inherit thread affinity from parent thread

2018-10-03 Thread Rob Clark
Yeah, I guess that is a simple/easy option.. generally it seems like it would be better not to expand the set of possible cpu's other than to lift restrictions mesa might have imposed upon itself elsewhere (iirc, you were trying to limit the glthread/threaded_context stuff to run on the same

Re: [Mesa-dev] [PATCH mesa 3/6] vulkan/wsi/display: pass the plane's modifiers to the image

2018-10-03 Thread Daniel Stone
On Thu, 27 Sep 2018 at 00:33, Keith Packard wrote: > Eric Engestrom writes: > > Signed-off-by: Eric Engestrom > > (I'll have to let someone familiar with the formats and modifiers stuff > review this one; I'm not comfortable with that at all). For my sins, I am, and this patch is: Reviewed-by:

Re: [Mesa-dev] [PATCH 4/5] vulkan/wsi: Use the interface from the real modifiers extension

2018-10-03 Thread Daniel Stone
Hi, On Mon, 1 Oct 2018 at 22:25, Jason Ekstrand wrote: > index 70594d6c053..2850349a619 100644 > --- a/src/intel/vulkan/anv_image.c > +++ b/src/intel/vulkan/anv_image.c > @@ -109,6 +109,8 @@ choose_isl_tiling_flags(const struct > anv_image_create_info *anv_info, > case

Re: [Mesa-dev] [PATCH] meson: Don't allow building EGL on on KMS systems or Haiku

2018-10-03 Thread Emil Velikov
On Mon, 1 Oct 2018 at 20:44, Dylan Baker wrote: > > Currently mesa only supports EGL for KMS (Linux, *BSD) systems and > Haiku, we should actually enforce this. This fixes the default build on > MacOS. Currently you can build EGL on Linux, BSD, Cygwin and (most likely) exotic ones like GNU Hurd

Re: [Mesa-dev] [PATCH] glsl/linker: Check the subroutine associated functions names

2018-10-03 Thread Iago Toral
Hi Vadym, I think this looks correct, but I was wondering if you considered implementing this check in ir_reader::read_function_sig (ir_reader.cpp) instead, which runs at compile time. My rationale is that given the option, I think it is preferable to push work to compile time rather than link

Re: [Mesa-dev] [PATCH V2 6/6] util: disable cache if we have no build-id and timestamp is zero

2018-10-03 Thread Emil Velikov
HI Tim, On Wed, 19 Sep 2018 at 23:55, Timothy Arceri wrote: > > Timestamp can be zero for example when Flatpak is used. In this > case just disable the cache rather then segfaulting when > incompatible cache items are loaded. > > V2: actually return false when mtime is 0. Guessing that you've

Re: [Mesa-dev] [PATCH 0/2] Fix the value of discreteQueuePriorities

2018-10-03 Thread Emil Velikov
Hi Gabriel, On Sun, 26 Aug 2018 at 19:51, Gabriel Majeri wrote: > > According to the Vulkan specification, the value of the > `discreteQueuePriorities` of the device limits structure > **must** be at least two. > > Gabriel Majeri (2): > anv: Ensure discreteQueuePriorities is at least 2 >

[Mesa-dev] [PATCH] anv/android: we need git_sha1.h in include paths

2018-10-03 Thread Tapani Pälli
Fixes: e4538b9 "anv: Implement VK_KHR_driver_properties" Signed-off-by: Tapani Pälli --- src/intel/Android.vulkan.mk | 1 + 1 file changed, 1 insertion(+) diff --git a/src/intel/Android.vulkan.mk b/src/intel/Android.vulkan.mk index 8dc20149784..03120cf48a0 100644 ---

Re: [Mesa-dev] [PATCH v2 3/8] egl: add EGL_EXT_device_drm support

2018-10-03 Thread Emil Velikov
On Wed, 3 Oct 2018 at 09:19, Mathias Fröhlich wrote: > > Hi Emil, > > On Tuesday, 2 October 2018 11:59:23 CEST Emil Velikov wrote: > > > > + return dev->device->nodes[DRM_NODE_PRIMARY]; > > > ... we probably want > > > return _eglGetDRMDeviceRenderNode(dev); > > > > > That isn't quite

[Mesa-dev] [PATCH] i965: fallback RGBX to RGBA in glEGLImageTargetRenderbufferStorageOES

2018-10-03 Thread Tapani Pälli
From: "Chystiakov, Dmytro" In the same fashion as is done for glEGLImageTextureTarget2D. v2: share the fallback which sets baseformat and internalformat correctly which makes both of the tests pass (Tapani) Fixes android.hardware.nativehardware.cts.AHardwareBufferNativeTests:

[Mesa-dev] [PATCH] glsl/linker: Check the subroutine associated functions names

2018-10-03 Thread Vadym Shovkoplias
From Section 6.1.2 (Subroutines) of the GLSL 4.00 specification "A program will fail to compile or link if any shader or stage contains two or more functions with the same name if the name is associated with a subroutine type." Fixes: * no-overloads.vert Bugzilla:

Re: [Mesa-dev] [PATCH v2 8/8] egl: add EGL_platform_device support

2018-10-03 Thread Mathias Fröhlich
Hi Emil, Ok, thanks for picking that up. On Tuesday, 2 October 2018 12:23:30 CEST Emil Velikov wrote: > On Thu, 20 Sep 2018 at 15:13, Mathias Fröhlich > wrote: > > > > > If I replace the above with > > > > EGLint surface_type = 0; > > /* Only advertise pbuffer configs for non

Re: [Mesa-dev] [PATCH v2 3/8] egl: add EGL_EXT_device_drm support

2018-10-03 Thread Mathias Fröhlich
Hi Emil, On Tuesday, 2 October 2018 11:59:23 CEST Emil Velikov wrote: > > > + return dev->device->nodes[DRM_NODE_PRIMARY]; > > ... we probably want > > return _eglGetDRMDeviceRenderNode(dev); > > > That isn't quite possible, as discussed in 2016's thread > "EGL_EXT_*_drm - primary vs

Re: [Mesa-dev] Meson-windows v4 (9/21/2018 rebase): LLVM linking problems

2018-10-03 Thread Liviu Prodea
Automatic wrap with llvm-config does get the version right so it has to be something else. I usually build LLVM myself like this: cd llvm-7.0.0.src & md buildsys-x86 & cd buildsys-x86 & cmake -G "Ninja" -Thost=x64 -DLLVM_TARGETS_TO_BUILD=X86 -DCMAKE_BUILD_TYPE=Release

Re: [Mesa-dev] [PATCH] util/u_queue: don't inherit thread affinity from parent thread

2018-10-03 Thread Eero Tamminen
Hi, On 10/3/18 2:00 AM, Marek Olšák wrote: On Tue, Oct 2, 2018 at 6:36 PM Rob Clark wrote: On Tue, Oct 2, 2018 at 6:30 PM Marek Olšák wrote: From: Marek Olšák [...] Just curious (and maybe I missed some previous discussion), would this override taskset? Asking because when benchmarking

[Mesa-dev] [PATCH] gallivm: Make it possible to disable some optimization shortcuts in release builds

2018-10-03 Thread Gert Wollny
From: Gert Wollny For testing it is of interetest that all tests of dEQP pass, e.g. to test virglrenderer on a host only providing software rendering like in a CI. Hence make it possible to disable certain optimizations that make tests fail. While we are there also add some documentation to the

Re: [Mesa-dev] [PATCH] radv: disable HTILE for very small depth surfaces

2018-10-03 Thread Samuel Pitoiset
On 10/1/18 8:23 PM, Marek Olšák wrote: What improvement do you get from this? Possibly less HTILE decompressions if small surfaces don't support TC-compatible HTILE. RADV has some restrictions, like mipmaps and MSAA. I didn't benchmark anything though. Thanks, Marek On Fri, Sep 28,

Re: [Mesa-dev] [PATCH] util/u_queue: don't inherit thread affinity from parent thread

2018-10-03 Thread Marek Olšák
I could add a flag to util queue not to do this. Then your driver can use the flag. Marek On Tue, Oct 2, 2018, 7:00 PM Marek Olšák wrote: > On Tue, Oct 2, 2018 at 6:36 PM Rob Clark wrote: > > > > On Tue, Oct 2, 2018 at 6:30 PM Marek Olšák wrote: > > > > > > From: Marek Olšák > > > > > > ---