Re: [Mesa-dev] [PATCH 1/4] i965/gen6: setup limits for ARB_viewport_array

2015-05-06 Thread Kenneth Graunke
On Wednesday, May 06, 2015 06:08:17 PM Chris Forbes wrote: Signed-off-by: Chris Forbes chr...@ijw.co.nz --- src/mesa/drivers/dri/i965/brw_context.c | 4 ++-- src/mesa/drivers/dri/i965/brw_defines.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git

[Mesa-dev] [PATCH] glsl/ast: don't implicit convert from double to float

2015-05-06 Thread Dave Airlie
From: Dave Airlie airl...@redhat.com Implicit conversion can only happen the other way. This fixes a bug I just saw from writing an incorrect test. Signed-off-by: Dave Airlie airl...@redhat.com --- src/glsl/ast_to_hir.cpp | 1 - 1 file changed, 1 deletion(-) diff --git

Re: [Mesa-dev] [PATCH 7/9] i965: ensure execution of fragment shader when fragment shader has atomic buffer access

2015-05-06 Thread Ian Romanick
On 04/29/2015 01:56 AM, kevin.rogo...@intel.com wrote: From: Kevin Rogovin kevin.rogo...@intel.com If the fragment shader has atomic buffer access, the shader must execute even if the current draw buffer has no attachments. --- src/mesa/drivers/dri/i965/gen7_wm_state.c | 7 +++

Re: [Mesa-dev] [PATCH 1/3] mesa/main: Remove _mesa_HashClone()

2015-05-06 Thread Timothy Arceri
On Tue, 2015-05-05 at 13:50 +0300, Juha-Pekka Heikkila wrote: I didn't find this being used anywhere. It used to be used by KHR_debug but Chia-I Wu replaced the hash table with a list for a number of reasons this time last year. Reviewed-by: Timothy Arceri t_arc...@yahoo.com.au

Re: [Mesa-dev] [PATCH 4/9] mesa: add helper convenience functions for fetching geometry of gl_framebuffer

2015-05-06 Thread Rogovin, Kevin
One more question: for patch 2 of the series, there was the request to change the type of _HasAttachments from GLboolean to bool. If the helper functions survive, should the helper functions return unsigned int instead of GLuint? -Kevin -Original Message- From: Rogovin, Kevin Sent:

Re: [Mesa-dev] [PATCH 7/9] egl/wayland: assume EGL_WINDOW_BIT

2015-05-06 Thread Daniel Stone
Hi, On 6 May 2015 at 07:25, Pekka Paalanen ppaala...@gmail.com wrote: On Wed, 6 May 2015 11:00:13 +1000 Dave Airlie airl...@gmail.com wrote: On 2 May 2015 at 20:15, Axel Davy axel.d...@ens.fr wrote: Only EGL_WINDOW_BIT is supported. Remove tests related. Is this there no plans to support

Re: [Mesa-dev] [PATCH 1/7] mesa/es3.1: enable DRAW_INDIRECT_BUFFER_BINDING for gles3.1

2015-05-06 Thread Tapani Pälli
I've just noticed that this is wrong, sorry :/ We should to make a new section for some of the enums that are only in GL core and ES31, DRAW_INDIRECT_BUFFER_BINDING is one of these cases .. so this patch is broken. Same may apply for some of your patches, there should not be duplicates but

Re: [Mesa-dev] [RFC 0/6] i965: INTEL_performance_query re-work

2015-05-06 Thread Samuel Pitoiset
On 05/06/2015 02:53 AM, Robert Bragg wrote: As we've learned more about the observability capabilities of Gen graphics we've found that it's not enough to only try and configure the OA unit from userspace without any dedicated support from the kernel. Hi Robert, Yeah, this is the same idea

[Mesa-dev] [PATCH 5/7] mesa/es3.1: enable GL_ARB_texture_gather for gles 3.1

2015-05-06 Thread Marta Lofstedt
GL_ARB_texture_gather is needed for gles 3.1 conformance. Signed-off-by: Marta Lofstedt marta.lofst...@intel.com --- src/mesa/main/get.c | 6 ++ src/mesa/main/get_hash_params.py | 4 2 files changed, 10 insertions(+) diff --git a/src/mesa/main/get.c b/src/mesa/main/get.c

[Mesa-dev] [PATCH 7/7] mesa/es3.1: enable GL_ARB_explicit_uniform_location for gles 3.1

2015-05-06 Thread Marta Lofstedt
GL_ARB_explicit_uniform_location is required for gles 3.1 conformance Signed-off-by: Marta Lofstedt marta.lofst...@intel.com --- src/mesa/main/get.c | 6 ++ src/mesa/main/get_hash_params.py | 2 ++ 2 files changed, 8 insertions(+) diff --git a/src/mesa/main/get.c

[Mesa-dev] [PATCH 0/7] Continue enabling OpenGL ES 3.1

2015-05-06 Thread Marta Lofstedt
This series of patches continues on the GLES 3.1 enabling started by Ian. It focusing of exposing definitions from previously extisting Open GL extensions that are needed for OpenGL ES 3.1 conformance. Marta Lofstedt (6): mesa/es3.1: enable GL_ARB_shader_image_load_store for gles3.1

[Mesa-dev] [PATCH 6/7] mesa/es3.1: enable GL_ARB_compute_shader for gles 3.1

2015-05-06 Thread Marta Lofstedt
GL_ARB_compute_shader is needed for gles 3.1 conformance. Signed-off-by: Marta Lofstedt marta.lofst...@intel.com --- src/mesa/main/get.c | 6 ++ src/mesa/main/get_hash_params.py | 9 + 2 files changed, 15 insertions(+) diff --git a/src/mesa/main/get.c

[Mesa-dev] [PATCH 2/7] mesa/es3.1: enable GL_ARB_shader_image_load_store for gles3.1

2015-05-06 Thread Marta Lofstedt
GL_ARB_shader_image_load store support is required for GLES 3.1 conformance. Signed-off-by: Marta Lofstedt marta.lofst...@intel.com --- src/mesa/main/get.c | 6 ++ src/mesa/main/get_hash_params.py | 8 2 files changed, 14 insertions(+) diff --git a/src/mesa/main/get.c

[Mesa-dev] [PATCH 1/7] mesa/es3.1: enable DRAW_INDIRECT_BUFFER_BINDING for gles3.1

2015-05-06 Thread Marta Lofstedt
From: Tapani Pälli tapani.pa...@intel.com (increases ES31-CTS.draw_indirect.basic.* passing tests) Signed-off-by: Tapani Pälli tapani.pa...@intel.com --- src/mesa/main/get.c | 12 src/mesa/main/get_hash_params.py | 2 ++ 2 files changed, 14 insertions(+) diff --git

[Mesa-dev] [PATCH 4/7] mesa/es3.1: enable GL_ARB_texture_multisample for gles 3.1

2015-05-06 Thread Marta Lofstedt
GL_ARB_texture_multisample is required for gles 3.1 conformance. Signed-off-by: Marta Lofstedt marta.lofst...@intel.com --- src/mesa/main/get.c | 6 ++ src/mesa/main/get_hash_params.py | 8 2 files changed, 14 insertions(+) diff --git a/src/mesa/main/get.c

[Mesa-dev] [PATCH 3/7] mesa/es3.1: enable GL_ARB_shader_atomic_counters for gles 3.1

2015-05-06 Thread Marta Lofstedt
GL_ARB_shader_atomic_counters is required for gles 3.1 conformance. Signed-off-by: Marta Lofstedt marta.lofst...@intel.com --- src/mesa/main/get.c | 6 ++ src/mesa/main/get_hash_params.py | 12 2 files changed, 18 insertions(+) diff --git a/src/mesa/main/get.c

[Mesa-dev] [PATCH] android: egl: remove st/egl from build

2015-05-06 Thread Varad Gautam
Build without st/egl and target/egl. Signed-off-by: Varad Gautam varadgau...@gmail.com --- src/egl/main/Android.mk | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/egl/main/Android.mk b/src/egl/main/Android.mk index 12b66d0..800d20d 100644 --- a/src/egl/main/Android.mk +++

Re: [Mesa-dev] [PATCH 4/9] mesa: add helper convenience functions for fetching geometry of gl_framebuffer

2015-05-06 Thread Ian Romanick
On 04/29/2015 01:56 AM, kevin.rogo...@intel.com wrote: From: Kevin Rogovin kevin.rogo...@intel.com Add convenience helper functions for fetching geometry of gl_framebuffer that return the geometry of the gl_framebuffer instead of the geometry of the buffers of the gl_framebuffer when then

Re: [Mesa-dev] [PATCH 7/9] egl/wayland: assume EGL_WINDOW_BIT

2015-05-06 Thread Pekka Paalanen
On Wed, 6 May 2015 11:00:13 +1000 Dave Airlie airl...@gmail.com wrote: On 2 May 2015 at 20:15, Axel Davy axel.d...@ens.fr wrote: Only EGL_WINDOW_BIT is supported. Remove tests related. Is this there no plans to support pixmap/pbuffer/ or any of the other bits? Seems like a step in the

Re: [Mesa-dev] [PATCH] glsl/ast: don't implicit convert from double to float

2015-05-06 Thread Tapani Pälli
This seems to be used in ast_function.cpp for implementing constructors where this type of conversion can happen, so not a implicit conversion but a 'conversion constructor'. (5.4.1 Conversion and Scalar Constructors) You would need to change that also. On 05/06/2015 09:17 AM, Dave Airlie

Re: [Mesa-dev] [PATCH 2/9] mesa:Define constants and functions for GL_ARB_framebuffer_no_attachment extension

2015-05-06 Thread Ian Romanick
You haven't been running 'make check'. :) You also need to update src/mesa/tests/dispatch_sanity.cpp. On 04/29/2015 01:56 AM, kevin.rogo...@intel.com wrote: From: Kevin Rogovin kevin.rogo...@intel.com Define the enumeration constants, function entry points and glGet for the

Re: [Mesa-dev] [PATCH 1/9] mesa:Define extension GL_ARB_framebuffer_no_attachments

2015-05-06 Thread Ian Romanick
These patches are partitioned in a atypical way. The usual way is - A patch that modifies extensions.c, struct gl_extensions, the XML files (in patch #2), dispatch_sanity (see my comment on patch #2), and adds the stub functions (in patch #2). - A patch that adds the other necessary

[Mesa-dev] [PATCH] mesa: support compute stage in _mesa_program_resource_prop

2015-05-06 Thread Tapani Pälli
Increases pass rate of ES31-CTS.*program_interface_query* tests when run with MESA_EXTENSION_OVERRIDE='GL_ARB_compute_shader'. Many of the negative tests that happen to use compute stage in queries start passing. Signed-off-by: Tapani Pälli tapani.pa...@intel.com ---

Re: [Mesa-dev] [PATCH 3/9] mesa: Complete implementation for GL_ARB_framebuffer_no_attachments in Mesa core

2015-05-06 Thread Ian Romanick
On 04/29/2015 01:56 AM, kevin.rogo...@intel.com wrote: From: Kevin Rogovin kevin.rogo...@intel.com Implement GL_ARB_framebuffer_no_attachments in Mesa core - changes to conditions for framebuffer completenss - implement set/get functions for framebuffers for new functions in

[Mesa-dev] [PATCH] glsl: clone inputs and outputs during linking

2015-05-06 Thread Tapani Pälli
This increases memory pressure during linking but makes it easier for backend to free IR after it is not needed anymore. Signed-off-by: Tapani Pälli tapani.pa...@intel.com --- src/glsl/linker.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/glsl/linker.cpp

[Mesa-dev] [PATCH] program_interface_query: clone ir_variables

2015-05-06 Thread Tapani Pälli
Hi; I've tested this + a modified version (where I just free all ir_instructions) of Kenneth's: i965: Delete most of the linked GLSL IR when using NIR No Piglit regressions observed. From here on plan would be to change ir_variable to a structure which will be hopefully more minimal and easier

[Mesa-dev] [PATCH 2/4] i965/gen6: Upload all the clip viewports

2015-05-06 Thread Chris Forbes
Signed-off-by: Chris Forbes chr...@ijw.co.nz --- src/mesa/drivers/dri/i965/gen6_viewport_state.c | 40 + 1 file changed, 21 insertions(+), 19 deletions(-) diff --git a/src/mesa/drivers/dri/i965/gen6_viewport_state.c b/src/mesa/drivers/dri/i965/gen6_viewport_state.c index

[Mesa-dev] [PATCH 3/4] i965/gen6: Upload all the SF viewports

2015-05-06 Thread Chris Forbes
Signed-off-by: Chris Forbes chr...@ijw.co.nz --- src/mesa/drivers/dri/i965/brw_structs.h | 2 ++ src/mesa/drivers/dri/i965/gen6_viewport_state.c | 29 +++-- 2 files changed, 19 insertions(+), 12 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_structs.h

Re: [Mesa-dev] [PATCH] i965: Delete most of the linked GLSL IR when using NIR.

2015-05-06 Thread Tapani Pälli
On 05/06/2015 08:38 AM, Jason Ekstrand wrote: On May 5, 2015 10:17 PM, Tapani Pälli tapani.pa...@intel.com mailto:tapani.pa...@intel.com wrote: On 05/06/2015 04:57 AM, Kenneth Graunke wrote: Vertex shader attribute and fragment shader output queries rely on being able to inspect

[Mesa-dev] [PATCH 1/4] i965/gen6: setup limits for ARB_viewport_array

2015-05-06 Thread Chris Forbes
Signed-off-by: Chris Forbes chr...@ijw.co.nz --- src/mesa/drivers/dri/i965/brw_context.c | 4 ++-- src/mesa/drivers/dri/i965/brw_defines.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_context.c b/src/mesa/drivers/dri/i965/brw_context.c

[Mesa-dev] [PATCH 4/4] i965/gen6: Enable ARB_viewport_array and AMD_vertex_shader_viewport_index

2015-05-06 Thread Chris Forbes
Signed-off-by: Chris Forbes chr...@ijw.co.nz --- src/mesa/drivers/dri/i965/intel_extensions.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c b/src/mesa/drivers/dri/i965/intel_extensions.c index c28c171..3088a1a

Re: [Mesa-dev] [PATCH 8/9] i965: enable ARB_framebuffer_no_attachments extension for Gen7 and later

2015-05-06 Thread Ian Romanick
On 04/29/2015 01:56 AM, kevin.rogo...@intel.com wrote: From: Kevin Rogovin kevin.rogo...@intel.com Enable GL_ARB_framebuffer_no_attachments in i965 for Gen7 and higher. --- src/mesa/drivers/dri/i965/brw_context.c | 6 ++ src/mesa/drivers/dri/i965/intel_extensions.c | 1 + 2

Re: [Mesa-dev] [PATCH 9/9] mark GL_ARB_framebuffer_no_attachments as done for i965

2015-05-06 Thread Ian Romanick
With Petri and Ilia's comments addressed, this patch is Reviewed-by: Ian Romanick ian.d.roman...@intel.com On 04/29/2015 01:56 AM, kevin.rogo...@intel.com wrote: From: Kevin Rogovin kevin.rogo...@intel.com Mark GL_ARB_framebuffer_no_attachments as done for i965. --- docs/GL3.txt

Re: [Mesa-dev] [PATCH] mesa: support compute stage in _mesa_program_resource_prop

2015-05-06 Thread Martin Peres
Looks good. Reviewed-by: Martin Peres martin.pe...@linux.intel.com On 06/05/15 09:36, Tapani Pälli wrote: Increases pass rate of ES31-CTS.*program_interface_query* tests when run with MESA_EXTENSION_OVERRIDE='GL_ARB_compute_shader'. Many of the negative tests that happen to use compute stage

Re: [Mesa-dev] [PATCH 3/9] mesa: Complete implementation for GL_ARB_framebuffer_no_attachments in Mesa core

2015-05-06 Thread Rogovin, Kevin
HI, For both this and get_framebuffer_parameteriv below, I don't see the value in splitting the implementations. Also, these functions need to check that the extension is enabled and generate GL_INVALID_OPERATION if it is not. No worries, I can add the GL_INVALID_OPERATION bit in. I have

Re: [Mesa-dev] [PATCH 4/9] mesa: add helper convenience functions for fetching geometry of gl_framebuffer

2015-05-06 Thread Rogovin, Kevin
I'm waffling about this a bit. I'm concerned that people will use buffer-Width when they should use the accessor. I don't see any changes to core Mesa code to use the accessor, so I'm a little concerned that some subtle, incorrect behavior is introduced... but there may well not be. A

Re: [Mesa-dev] [PATCH 2/9] mesa:Define constants and functions for GL_ARB_framebuffer_no_attachment extension

2015-05-06 Thread Rogovin, Kevin
You haven't been running 'make check'. :) You also need to update src/mesa/tests/dispatch_sanity.cpp. There is something wrong with my box or something... I did run make check and there were no failures. Out of paranoia, I also ran src/mesa/main/tests/main-test explicitly and there were no

[Mesa-dev] [PATCH] mesa/es3.1: enable DRAW_INDIRECT_BUFFER_BINDING for gles3.1

2015-05-06 Thread Tapani Pälli
(increases ES31-CTS.draw_indirect.basic.* passing tests) v2: only expose DRAW_INDIRECT_BUFFER_BINDING for GL core + ES3.1 Signed-off-by: Tapani Pälli tapani.pa...@intel.com --- src/mesa/main/get.c | 12 src/mesa/main/get_hash_params.py | 8 ++-- 2 files changed,

[Mesa-dev] [PATCH 2/2] glx: provide a way to disable DRI3 using an environment variable

2015-05-06 Thread Martin Peres
This provides an easy way to test differences in rendering performance or conformance between DRI2 and DRI3. Signed-off-by: Martin Peres martin.pe...@linux.intel.com --- docs/envvars.html | 1 + src/glx/dri3_glx.c | 5 + 2 files changed, 6 insertions(+) diff --git a/docs/envvars.html

[Mesa-dev] [PATCH 1/2] glx: report which DRI version is used when in verbose debug mode

2015-05-06 Thread Martin Peres
This should make it more obvious in bug reports while also removing any sort of guesswork for developers. Signed-off-by: Martin Peres martin.pe...@linux.intel.com --- src/glx/dri2_glx.c | 2 ++ src/glx/dri3_glx.c | 2 ++ 2 files changed, 4 insertions(+) diff --git a/src/glx/dri2_glx.c

Re: [Mesa-dev] [PATCH 7/9] i965: ensure execution of fragment shader when fragment shader has atomic buffer access

2015-05-06 Thread Rogovin, Kevin
Hi, I think this check should be put in a utility function up in core Mesa somewhere. It's open-coded twice in this patch, and the check will change when GL_ARB_image_load_store lands. Would a check of the form: inline bool _mesa_has_atomic_ops(struct gl_context *ctx) { return ctx-

Re: [Mesa-dev] [PATCH 4/9] mesa: add helper convenience functions for fetching geometry of gl_framebuffer

2015-05-06 Thread Rogovin, Kevin
Sorry, one more question, which I should have asked before, but neglected to: If we go that route, we should probably just add a gl_framebuffer::Samples field for uniformity. If this is done, then there are two ways to get the value: from the Visual field and from the new field; Naturally,

[Mesa-dev] [Bug 80183] [llvmpipe] triangles with vertices that map to raster positions viewport width/height are not displayed

2015-05-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=80183 --- Comment #12 from cgerlac...@gmail.com --- Created attachment 115590 -- https://bugs.freedesktop.org/attachment.cgi?id=115590action=edit triangles get completely clipped on viewport - 2 -- You are receiving this mail because: You are the

[Mesa-dev] [Bug 80183] [llvmpipe] triangles with vertices that map to raster positions viewport width/height are not displayed

2015-05-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=80183 --- Comment #11 from cgerlac...@gmail.com --- Created attachment 115589 -- https://bugs.freedesktop.org/attachment.cgi?id=115589action=edit triangles get completely clipped on viewport - 1 -- You are receiving this mail because: You are the

[Mesa-dev] [v2 02/12] Revert i965/gen7: Factor out texture surface state set-up from gen7_update_texture_surface().

2015-05-06 Thread Topi Pohjolainen
This reverts commit 6f26ffaf66affb6563e548646fb6d6a049fe6bff. --- src/mesa/drivers/dri/i965/brw_context.h | 11 -- src/mesa/drivers/dri/i965/gen7_wm_surface_state.c | 127 +- 2 files changed, 54 insertions(+), 84 deletions(-) diff --git

[Mesa-dev] [v2 09/12] i965: Pass texture target as parameter for surface setup

2015-05-06 Thread Topi Pohjolainen
Also changed a couple of direct shifts into SET_FIELD(). Reviewed-by: Matt Turner matts...@gmail.com Reviewed-by: Kenneth Graunke kenn...@whitecape.org Signed-off-by: Topi Pohjolainen topi.pohjolai...@intel.com --- src/mesa/drivers/dri/i965/brw_context.h | 2 +-

[Mesa-dev] [v2 04/12] i965: Move texture buffer dispatch into single location

2015-05-06 Thread Topi Pohjolainen
All generations do the same exact dispatch and it could be therefore done in the hardware independent stage. Reviewed-by: Matt Turner matts...@gmail.com Reviewed-by: Kenneth Graunke kenn...@whitecape.org Signed-off-by: Topi Pohjolainen topi.pohjolai...@intel.com ---

[Mesa-dev] [v2 07/12] i965: Move texture swizzle resolving into dispatcher

2015-05-06 Thread Topi Pohjolainen
Reviewed-by: Matt Turner matts...@gmail.com Reviewed-by: Kenneth Graunke kenn...@whitecape.org Signed-off-by: Topi Pohjolainen topi.pohjolai...@intel.com --- src/mesa/drivers/dri/i965/brw_context.h | 4 ++-- src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 20 +++-

[Mesa-dev] [v2 01/12] Revert i965/gen8: Factor out texture surface state set-up from gen8_update_texture_surface().

2015-05-06 Thread Topi Pohjolainen
This reverts commit e17dc004fd96e589e92ee64deeb45339af4bf671. --- src/mesa/drivers/dri/i965/gen8_surface_state.c | 137 +++-- 1 file changed, 60 insertions(+), 77 deletions(-) diff --git a/src/mesa/drivers/dri/i965/gen8_surface_state.c

[Mesa-dev] [v2 12/12] i965/SQUASH: Implement surface state set-up for shader images.

2015-05-06 Thread Topi Pohjolainen
--- src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_wm_surface_state.c b/src/mesa/drivers/dri/i965/brw_wm_surface_state.c index 6e0166e..250c61a 100644 ---

[Mesa-dev] [v2 11/12] i965: Implement surface state set-up for shader images.

2015-05-06 Thread Topi Pohjolainen
From: Francisco Jerez curroje...@riseup.net --- src/mesa/drivers/dri/i965/brw_context.h | 2 + src/mesa/drivers/dri/i965/brw_surface_formats.c | 112 +++ src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 77 3 files changed, 191 insertions(+)

[Mesa-dev] i965: Revision of texture surface setup refactoring

2015-05-06 Thread Topi Pohjolainen
This series moves all the decision making of values into common hardware independent dispatcher while leaving the hardware specific logic to deal with formatting only. Curro needed a similar refactor for gen7 and gen8. However, that makes it a harder to apply the changes I needed that expand all

Re: [Mesa-dev] i965: Revision of texture surface setup refactoring

2015-05-06 Thread Francisco Jerez
Hi! Topi Pohjolainen topi.pohjolai...@intel.com writes: This series moves all the decision making of values into common hardware independent dispatcher while leaving the hardware specific logic to deal with formatting only. Curro needed a similar refactor for gen7 and gen8. However, that

[Mesa-dev] [Bug 80183] [llvmpipe] triangles with vertices that map to raster positions viewport width/height are not displayed

2015-05-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=80183 cgerlac...@gmail.com changed: What|Removed |Added Attachment #115588|text/plain |image/png mime type|

[Mesa-dev] [PATCH] util: Take memset out of rzalloc_size()

2015-05-06 Thread Juha-Pekka Heikkila
rzalloc_size() call ralloc_size() to allocate memory. ralloc_size() use calloc to get memory thus zeroing in rzalloc_size is not necessary. Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/util/ralloc.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/util/ralloc.c

Re: [Mesa-dev] [PATCH 7/7] mesa/es3.1: enable GL_ARB_explicit_uniform_location for gles 3.1

2015-05-06 Thread Tapani Pälli
Instead of adding new one you should move the existing declaration to section: apis: [GL, GL_CORE, GLES3] and make it use the new specified extra extra_ARB_explicit_uniform_location_es31. (same is actually true for all other patches, they all add enums that should be available for GL,

[Mesa-dev] [v2 06/12] i965: Move tex miptree and format resolving into dispatcher

2015-05-06 Thread Topi Pohjolainen
All hardware platforms have this in common, so do it in the hardware independent dispatcher. v2 (Matt): Removed extra whitespace. Reviewed-by: Matt Turner matts...@gmail.com (v1) Reviewed-by: Kenneth Graunke kenn...@whitecape.org (v1) Signed-off-by: Topi Pohjolainen topi.pohjolai...@intel.com

[Mesa-dev] [v2 03/12] i965/gen7: Check mip-tree for integer formats in surface setup

2015-05-06 Thread Topi Pohjolainen
Signed-off-by: Topi Pohjolainen topi.pohjolai...@intel.com --- src/mesa/drivers/dri/i965/gen7_wm_surface_state.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/gen7_wm_surface_state.c b/src/mesa/drivers/dri/i965/gen7_wm_surface_state.c index

[Mesa-dev] [v2 10/12] i965: Pass slice details as parameters for surface setup

2015-05-06 Thread Topi Pohjolainen
Also changed a couple of direct shifts into SET_FIELD(). Fixes: arb_copy_image-formats -auto -fbo on ILK. In principle, minimum level settings are only for TextureView to use. We, however, also take advantage of that internally when blitting. Before this patch this wasn't taken into account for

[Mesa-dev] [v2 05/12] i965/gen8: Use miptree format in the surface setup

2015-05-06 Thread Topi Pohjolainen
No functional change but this allows to drop the texture object's mesa format in later patches. Stencil buffer has fixed hardware format corresponding to fixed mesa format. (This is in fact already specfically tested in intel_fbo.c::intel_validate_framebuffer()). Reviewed-by: Matt Turner

[Mesa-dev] [v2 08/12] i965: Refactor effective depth calculation

2015-05-06 Thread Topi Pohjolainen
Reviewed-by: Matt Turner matts...@gmail.com Reviewed-by: Kenneth Graunke kenn...@whitecape.org Signed-off-by: Topi Pohjolainen topi.pohjolai...@intel.com --- src/mesa/drivers/dri/i965/brw_context.h | 1 + src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 12 ++--

Re: [Mesa-dev] [PATCH 1/7] mesa/es3.1: enable DRAW_INDIRECT_BUFFER_BINDING for gles3.1

2015-05-06 Thread Lofstedt, Marta
That's OK, Tapani, I will fix up my patches once I see what reception you patch gets. /Marta -Original Message- From: Palli, Tapani Sent: Wednesday, May 6, 2015 12:19 PM To: Lofstedt, Marta Cc: mesa-dev@lists.freedesktop.org Subject: Re: [PATCH 1/7] mesa/es3.1: enable

[Mesa-dev] [Bug 80183] [llvmpipe] triangles with vertices that map to raster positions viewport width/height are not displayed

2015-05-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=80183 cgerlac...@gmail.com changed: What|Removed |Added Attachment #115589|text/plain |image/png mime type|

Re: [Mesa-dev] [RFC 0/6] i965: INTEL_performance_query re-work

2015-05-06 Thread Daniel Vetter
On Wed, May 06, 2015 at 10:36:15AM +0200, Samuel Pitoiset wrote: On 05/06/2015 02:53 AM, Robert Bragg wrote: As we've learned more about the observability capabilities of Gen graphics we've found that it's not enough to only try and configure the OA unit from userspace without any

Re: [Mesa-dev] i965 implementation of the ARB_shader_image_load_store built-ins. (v2)

2015-05-06 Thread Francisco Jerez
Kenneth Graunke kenn...@whitecape.org writes: On Tuesday, May 05, 2015 03:05:02 PM Matt Turner wrote: On Tue, May 5, 2015 at 2:17 PM, Francisco Jerez curroje...@riseup.net wrote: Kenneth Graunke kenn...@whitecape.org writes: That then begs the question - could we do the format conversion

[Mesa-dev] [Bug 9951] GL_LINE_SMOOTH and GL_POLYGON_SMOOTH with i965 driver

2015-05-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=9951 marius predut marius.pre...@intel.com changed: What|Removed |Added Assignee|haihao.xi...@intel.com

[Mesa-dev] [Bug 9951] GL_LINE_SMOOTH and GL_POLYGON_SMOOTH with i965 driver

2015-05-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=9951 --- Comment #6 from marius predut marius.pre...@intel.com --- The patch series that fix this bug are upstream -- You are receiving this mail because: You are on the CC list for the bug. ___ mesa-dev

Re: [Mesa-dev] [PATCH V2 06/22] i965/gen9: Set tiled resource mode for the miptree

2015-05-06 Thread Daniel Vetter
On Fri, Apr 17, 2015 at 04:51:27PM -0700, Anuj Phogat wrote: Signed-off-by: Anuj Phogat anuj.pho...@gmail.com --- src/mesa/drivers/dri/i965/brw_tex_layout.c| 2 ++ src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 6 ++ 2 files changed, 8 insertions(+) diff --git

[Mesa-dev] [PATCH] i965: Document brw_mask_reg().

2015-05-06 Thread Francisco Jerez
--- src/mesa/drivers/dri/i965/brw_reg.h | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_reg.h b/src/mesa/drivers/dri/i965/brw_reg.h index c03a8ae..81a9320 100644 --- a/src/mesa/drivers/dri/i965/brw_reg.h +++

Re: [Mesa-dev] [RFC 0/6] i965: INTEL_performance_query re-work

2015-05-06 Thread Martin Peres
On 06/05/15 17:02, Daniel Vetter wrote: On Wed, May 06, 2015 at 10:36:15AM +0200, Samuel Pitoiset wrote: On 05/06/2015 02:53 AM, Robert Bragg wrote: As we've learned more about the observability capabilities of Gen graphics we've found that it's not enough to only try and configure the OA

Re: [Mesa-dev] [PATCH] draw: (trivial) fix out-of-bounds vector initialization

2015-05-06 Thread Brian Paul
On 05/06/2015 08:05 AM, srol...@vmware.com wrote: From: Roland Scheidegger srol...@vmware.com Was off-by-one. llvm says inserting an element with an index higher than the number of elements yields undefined results. Previously such inserts were ignored but as of llvm revision 235854 the vector

[Mesa-dev] New stable-branch 10.5 candidate pushed

2015-05-06 Thread Emil Velikov
Hello list, The candidate for the Mesa 10.5.5 is now available. The current patch queue is as follows: - 10 queued - 5 nominated (outstanding) - and 0 rejected (obsolete) patches The queue consists mostly of nouveau and i965 fixes. Take a look at section Mesa stable queue for more

[Mesa-dev] [Bug 80183] [llvmpipe] triangles with vertices that map to raster positions viewport width/height are not displayed

2015-05-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=80183 --- Comment #13 from Roland Scheidegger srol...@vmware.com --- Does this happen with other gallium based drivers (softpipe for instance, though it might hit all the same code)? I'm afraid noone will look into it without an apitrace trace (or some

[Mesa-dev] [Bug 80183] [llvmpipe] triangles with vertices that map to raster positions viewport width/height are not displayed

2015-05-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=80183 --- Comment #10 from cgerlac...@gmail.com --- Created attachment 115588 -- https://bugs.freedesktop.org/attachment.cgi?id=115588action=edit all clipped triangles are within the viewport -- You are receiving this mail because: You are the

[Mesa-dev] [Bug 80183] [llvmpipe] triangles with vertices that map to raster positions viewport width/height are not displayed

2015-05-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=80183 cgerlac...@gmail.com changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED

[Mesa-dev] [Bug 80183] [llvmpipe] triangles with vertices that map to raster positions viewport width/height are not displayed

2015-05-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=80183 cgerlac...@gmail.com changed: What|Removed |Added Attachment #115590|text/plain |image/png mime type|

Re: [Mesa-dev] i965: Revision of texture surface setup refactoring

2015-05-06 Thread Pohjolainen, Topi
On Wed, May 06, 2015 at 02:56:53PM +0300, Francisco Jerez wrote: Hi! Topi Pohjolainen topi.pohjolai...@intel.com writes: This series moves all the decision making of values into common hardware independent dispatcher while leaving the hardware specific logic to deal with formatting

Re: [Mesa-dev] [PATCH] mesa: support compute stage in _mesa_program_resource_prop

2015-05-06 Thread Ilia Mirkin
On Wed, May 6, 2015 at 2:36 AM, Tapani Pälli tapani.pa...@intel.com wrote: Increases pass rate of ES31-CTS.*program_interface_query* tests when run with MESA_EXTENSION_OVERRIDE='GL_ARB_compute_shader'. Many of the negative tests that happen to use compute stage in queries start passing.

[Mesa-dev] [Bug 90354] Software rendering cuses X BadMatch error

2015-05-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90354 Bug ID: 90354 Summary: Software rendering cuses X BadMatch error Product: Mesa Version: git Hardware: All OS: All Status: NEW Severity: normal

Re: [Mesa-dev] [PATCH] i965: Change the order of conditions tested in if

2015-05-06 Thread Anuj Phogat
On Wed, May 6, 2015 at 2:19 PM, Matt Turner matts...@gmail.com wrote: On Wed, Apr 15, 2015 at 11:46 AM, Anuj Phogat anuj.pho...@gmail.com wrote: Reduces the number of conditions tested in if to one in case of non-integer formats. Makes no functional changes. Signed-off-by: Anuj Phogat

Re: [Mesa-dev] [PATCH] glapi: Add positional argument specifier.

2015-05-06 Thread Kenneth Graunke
On Wednesday, May 06, 2015 12:48:30 PM Vinson Lee wrote: Fix build error introduced with commit 1c5a57a glapi/es3.1: Add support for GLES versions 3.0 with Python 2.7. File src/mapi/glapi/gen/gl_genexec.py, line 230, in module printer.Print(api) File src/mapi/glapi/gen/gl_XML.py,

Re: [Mesa-dev] [PATCH 0/7] i965: Enable EGL_KHR_fence_sync

2015-05-06 Thread Kenneth Graunke
On Friday, May 01, 2015 01:01:55 PM Chad Versace wrote: The first 6 patches are small cleanups. The real implementation is patch 7/7. Enabling EGL_KHR_fence_sync also gives us EGL_KHR_wait_sync for free. This series lives on the tag: git://github.com/chadversary/mesa

Re: [Mesa-dev] [PATCH 1/7] egl/dri2: Check return value of __DRI2fence::create_fence()

2015-05-06 Thread Kenneth Graunke
On Friday, May 01, 2015 01:01:56 PM Chad Versace wrote: From: Chad Versace c...@kiwitree.net If it returns NULL, then return early with an error. Cc: Marek Olšák marek.ol...@amd.com --- src/egl/drivers/dri2/egl_dri2.c | 7 +++ 1 file changed, 7 insertions(+) diff --git

Re: [Mesa-dev] [PATCH] i965/wm/gen6: Refactor state setup

2015-05-06 Thread Kenneth Graunke
On Wednesday, May 06, 2015 10:41:30 PM Topi Pohjolainen wrote: CC: Kenneth Graunke kenn...@whitecape.org Signed-off-by: Topi Pohjolainen topi.pohjolai...@intel.com --- src/mesa/drivers/dri/i965/brw_state.h | 11 +++ src/mesa/drivers/dri/i965/gen6_wm_state.c | 111

[Mesa-dev] [PATCH] i965: Remove unused variables

2015-05-06 Thread Anuj Phogat
Signed-off-by: Anuj Phogat anuj.pho...@gmail.com --- src/mesa/drivers/dri/i965/brw_cs.cpp | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_cs.cpp b/src/mesa/drivers/dri/i965/brw_cs.cpp index e2f3d63..70731e4 100644 --- a/src/mesa/drivers/dri/i965/brw_cs.cpp +++

[Mesa-dev] [Bug 90354] Software rendering cuses X BadMatch error

2015-05-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90354 --- Comment #1 from Igor Gnatenko i.gnatenko.br...@gmail.com --- Looks like a bug in swrast. The error was 'BadMatch (invalid parameter attributes)'. (Details: serial 801 error_code 8 request_code 72 (core protocol) minor_code 0) (Note to

Re: [Mesa-dev] [PATCH] glapi: Add positional argument specifier.

2015-05-06 Thread Ian Romanick
On 05/06/2015 12:48 PM, Vinson Lee wrote: Fix build error introduced with commit 1c5a57a glapi/es3.1: Add support for GLES versions 3.0 with Python 2.7. File src/mapi/glapi/gen/gl_genexec.py, line 230, in module printer.Print(api) File src/mapi/glapi/gen/gl_XML.py, line 120, in

Re: [Mesa-dev] [PATCH] glapi: Add positional argument specifier.

2015-05-06 Thread Ian Romanick
On 05/06/2015 03:45 PM, Kenneth Graunke wrote: On Wednesday, May 06, 2015 12:48:30 PM Vinson Lee wrote: Fix build error introduced with commit 1c5a57a glapi/es3.1: Add support for GLES versions 3.0 with Python 2.7. File src/mapi/glapi/gen/gl_genexec.py, line 230, in module

Re: [Mesa-dev] [PATCH 5/5] nir: Allow feq/fne/ieq/ine to be optimized with inot.

2015-05-06 Thread Glenn Kennard
On Wed, 06 May 2015 23:12:54 +0200, Matt Turner matts...@gmail.com wrote: instructions in affected programs: 380 - 376 (-1.05%) helped:2 --- Did we just completely forget these in commit 391fb32b, or is there a reason to not include them?

Re: [Mesa-dev] [PATCH] i965: Remove unused variables

2015-05-06 Thread Jordan Justen
Whoops, these should have been added in a later (not yet sent to list) patch. (I need to look into posting those patches! :) Reviewed-by: Jordan Justen jordan.l.jus...@intel.com On 2015-05-06 15:14:42, Anuj Phogat wrote: Signed-off-by: Anuj Phogat anuj.pho...@gmail.com ---

Re: [Mesa-dev] [PATCH 5/5] nir: Allow feq/fne/ieq/ine to be optimized with inot.

2015-05-06 Thread Ian Romanick
On 05/06/2015 02:12 PM, Matt Turner wrote: instructions in affected programs: 380 - 376 (-1.05%) helped:2 --- Did we just completely forget these in commit 391fb32b, or is there a reason to not include them? I was recently wondering this as well. There

[Mesa-dev] [Bug 90346] DispatchSanity_test.GLES2 regression

2015-05-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90346 Vinson Lee v...@freedesktop.org changed: What|Removed |Added Status|NEEDINFO|NEW --- Comment #2

[Mesa-dev] [PATCH 5/5] nir: Allow feq/fne/ieq/ine to be optimized with inot.

2015-05-06 Thread Matt Turner
instructions in affected programs: 380 - 376 (-1.05%) helped:2 --- Did we just completely forget these in commit 391fb32b, or is there a reason to not include them? src/glsl/nir/nir_opt_algebraic.py | 4 1 file changed, 4 insertions(+) diff --git

Re: [Mesa-dev] [PATCH] i965: Change the order of conditions tested in if

2015-05-06 Thread Matt Turner
On Wed, Apr 15, 2015 at 11:46 AM, Anuj Phogat anuj.pho...@gmail.com wrote: Reduces the number of conditions tested in if to one in case of non-integer formats. Makes no functional changes. Signed-off-by: Anuj Phogat anuj.pho...@gmail.com --- src/mesa/drivers/dri/i965/brw_surface_formats.c |

Re: [Mesa-dev] [PATCH 4/5] nir: Recognize (a c || b c) as min(a, b) c.

2015-05-06 Thread Jordan Justen
On 2015-05-06 14:12:53, Matt Turner wrote: ... and (a = c) || (b = c) as max(a, b) = c. Looks like maybe you could use two commits, since the subject line overfloweth. Of course, you have shader-db results for them merged. :\ Series Reviewed-by: Jordan Justen jordan.l.jus...@intel.com Similar

[Mesa-dev] [PATCH 1/5] nir: Recognize imul(b2i(a), b2i(b)) as a logical AND.

2015-05-06 Thread Matt Turner
Four shaders in Unreal 4's Sun Temple are helped, and gain SIMD16 because we avoid an integer multiplication. instructions in affected programs: 2353 - 2245 (-4.59%) helped:4 GAINED:4 --- src/glsl/nir/nir_opt_algebraic.py | 1 +

[Mesa-dev] [PATCH 3/5] nir: Recognize trivial min/max.

2015-05-06 Thread Matt Turner
No changes, but does prevent some regressions in the next commit. --- src/glsl/nir/nir_opt_algebraic.py | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/glsl/nir/nir_opt_algebraic.py b/src/glsl/nir/nir_opt_algebraic.py index fda4bd5..42f4f47 100644 ---

[Mesa-dev] [PATCH 2/5] nir: Recognize i2b(b2i(x)) as x.

2015-05-06 Thread Matt Turner
Helps the same set of programs as the previous commit. instructions in affected programs: 4490 - 4346 (-3.21%) helped:8 --- src/glsl/nir/nir_opt_algebraic.py | 1 + 1 file changed, 1 insertion(+) diff --git a/src/glsl/nir/nir_opt_algebraic.py

[Mesa-dev] [Bug 90346] DispatchSanity_test.GLES2 regression

2015-05-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90346 Ian Romanick i...@freedesktop.org changed: What|Removed |Added Status|NEW |NEEDINFO

[Mesa-dev] [PATCH 4/5] nir: Recognize (a c || b c) as min(a, b) c.

2015-05-06 Thread Matt Turner
... and (a = c) || (b = c) as max(a, b) = c. Similar to commit 97e6c1b9. total instructions in shared programs: 6182276 - 6182180 (-0.00%) instructions in affected programs: 6400 - 6304 (-1.50%) helped:68 HURT: 4 ---

  1   2   >