Re: [Mesa-dev] [PATCH 1/5] mesa/bufferobj: make _mesa_delete_buffer_object externally accessible

For the series: Reviewed-by: Marek Olšák Marek On Wed, Jan 6, 2016 at 3:53 AM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > gl_buffer_object has grown more complicated and requires cleanup. Using this > function from

[Mesa-dev] [PATCH] glsl: fix varying slot allocation for blocks and structs with explicit locations

Previously each member was being counted as using a single slot, count_attribute_slots() fixes the count for array and struct members. Also don't assign a negitive to the unsigned expl_location variable. --- Fixes these new piglit tests: http://patchwork.freedesktop.org/patch/69531/

[Mesa-dev] [Bug 93577] Total war: Attila crashes at startup

https://bugs.freedesktop.org/show_bug.cgi?id=93577 --- Comment #4 from Médéric Boquien --- Thanks for the investigation. Is there a way I can find the list of extensions they are using? That way I can keep an eye with upcoming Mesa versions and try again when everything is in

Re: [Mesa-dev] [PATCH 3/3] tgsi/scan: set which color components are read by a fragment shader

On 05.01.2016 20:46, Marek Olšák wrote: From: Marek Olšák This will be used by radeonsi. --- src/gallium/auxiliary/tgsi/tgsi_scan.c | 30 ++ src/gallium/auxiliary/tgsi/tgsi_scan.h | 1 + 2 files changed, 23 insertions(+), 8 deletions(-)

Re: [Mesa-dev] [PATCH 2/3] tgsi/scan: fix tgsi_shader_info::reads_z

Patches 1 & 2 are Reviewed-by: Nicolai Hähnle On 05.01.2016 20:46, Marek Olšák wrote: From: Marek Olšák This has no users in Mesa. --- src/gallium/auxiliary/tgsi/tgsi_scan.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff

[Mesa-dev] [Bug 93577] Total war: Attila crashes at startup

https://bugs.freedesktop.org/show_bug.cgi?id=93577 Jose Fonseca changed: What|Removed |Added Status|NEW |RESOLVED

[Mesa-dev] [PATCH 07/23] radeonsi: export "undef" values for undefined PS outputs

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_shader.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index e08a076..73a34ac 100644 ---

[Mesa-dev] [PATCH 12/23] radeonsi: add struct si_shader_config

From: Marek Olšák There will be 1 config per variant, which will be a union of configs from {prolog, main, epilog}. For now, just add the structure. --- src/gallium/drivers/radeonsi/si_compute.c | 24 ++-- src/gallium/drivers/radeonsi/si_shader.c| 31

[Mesa-dev] [PATCH 15/23] radeonsi: always keep shader code, rodata, and relocs in memory

From: Marek Olšák We won't compile shaders in draw calls, but we will concatenate shader binaries according to states in draw calls, so keep the binaries. --- src/gallium/drivers/radeonsi/si_shader.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff

[Mesa-dev] [PATCH 06/23] radeonsi: move MRTZ export into a separate function

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_shader.c | 113 +-- 1 file changed, 62 insertions(+), 51 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index 8441fb4..e08a076

[Mesa-dev] [PATCH 18/23] radeonsi: add si_shader_destroy_binary

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_shader.c | 14 +- src/gallium/drivers/radeonsi/si_shader.h | 1 + 2 files changed, 10 insertions(+), 5 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c

[Mesa-dev] [PATCH 11/23] radeonsi: move NULL exporting into a separate function

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_shader.c | 37 +++- 1 file changed, 22 insertions(+), 15 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index f60b560..f6a5051

[Mesa-dev] [PATCH 16/23] radeonsi: move si_shader_binary_upload out of si_compile_llvm

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_compute.c | 1 + src/gallium/drivers/radeonsi/si_shader.c | 12 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_compute.c

[Mesa-dev] [PATCH 09/23] radeonsi: use EXP_NULL for pixel shaders without outputs

From: Marek Olšák This never happens currently. --- src/gallium/drivers/radeonsi/si_shader.c| 2 +- src/gallium/drivers/radeonsi/si_state_shaders.c | 7 ++- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c

[Mesa-dev] [PATCH 13/23] radeonsi: don't pass si_shader to si_shader_binary_read_config

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_compute.c | 5 +++-- src/gallium/drivers/radeonsi/si_shader.c | 28 ++-- src/gallium/drivers/radeonsi/si_shader.h | 3 ++- 3 files changed, 19 insertions(+), 17 deletions(-) diff --git

[Mesa-dev] [PATCH 08/23] radeonsi: only use LLVMBuildLoad once when updating color outputs at the end

From: Marek Olšák without LLVMBuildStore. So: - do LLVMBuildLoad - update the values as necessary - export --- src/gallium/drivers/radeonsi/si_shader.c | 67 ++-- 1 file changed, 20 insertions(+), 47 deletions(-) diff --git

[Mesa-dev] [PATCH 10/23] radeonsi: move MRT color exporting into a separate function

From: Marek Olšák This will be used by a fragment shader epilog. --- src/gallium/drivers/radeonsi/si_shader.c | 93 +++- 1 file changed, 55 insertions(+), 38 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c

[Mesa-dev] [PATCH 00/23] RadeonSI: Restructuring shader code generation part 2

Hi, These boring patches focus on restructuring pixel shader output handling and code around si_compile_llvm (config, dumping, etc.). They are mostly code movements and dividing functions into smaller ones, so that they can be re-used by pixel shader epilog compilation code. Please review.

[Mesa-dev] [PATCH 04/23] radeonsi: set SPI color formats and CB_SHADER_MASK outside of compilation

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_shader.c| 12 +- src/gallium/drivers/radeonsi/si_shader.h| 2 -- src/gallium/drivers/radeonsi/si_state_shaders.c | 30 ++--- 3 files changed, 28 insertions(+), 16 deletions(-)

[Mesa-dev] [PATCH 01/23] radeonsi: determine DB_SHADER_CONTROL outside of shader compilation

From: Marek Olšák because the API pixel shader binary will not emulate alpha test one day, so the KILL_ENABLE bit must be determined elsewhere. --- src/gallium/drivers/radeonsi/si_shader.c| 20 src/gallium/drivers/radeonsi/si_shader.h| 5 ++-

[Mesa-dev] [PATCH 02/23] radeonsi: determine SPI_SHADER_Z_FORMAT outside of shader compilation

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_shader.c| 7 --- src/gallium/drivers/radeonsi/si_shader.h| 1 - src/gallium/drivers/radeonsi/si_state_shaders.c | 7 ++- 3 files changed, 6 insertions(+), 9 deletions(-) diff --git

[Mesa-dev] [PATCH 03/23] radeonsi: write all MRTs only if there is exactly one output

From: Marek Olšák This doesn't fix a known bug, but better safe than sorry. Also, simplify the expression in si_shader.c. --- src/gallium/drivers/radeonsi/si_shader.c| 5 ++--- src/gallium/drivers/radeonsi/si_state_shaders.c | 4 +++- 2 files changed, 5

[Mesa-dev] [Bug 93577] Total war: Attila crashes at startup

https://bugs.freedesktop.org/show_bug.cgi?id=93577 --- Comment #2 from Jose Fonseca --- (In reply to Michel Dänzer from comment #1) > Reassigning to Mesa core since it happens with the i965 driver as well, but > it looks like it might be a game bug. > > BTW, an apitrace is

[Mesa-dev] [PATCH 14/23] radeonsi: don't pass si_shader to si_shader_binary_read

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_compute.c | 3 ++- src/gallium/drivers/radeonsi/si_shader.c | 23 --- src/gallium/drivers/radeonsi/si_shader.h | 7 +-- 3 files changed, 19 insertions(+), 14 deletions(-) diff --git

[Mesa-dev] [PATCH 22/23] radeonsi: move si_shader_dump call out of si_compile_llvm

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_compute.c | 3 +++ src/gallium/drivers/radeonsi/si_shader.c | 10 -- 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_compute.c

[Mesa-dev] [PATCH 17/23] radeonsi: don't pass si_shader to si_compile_llvm

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_compute.c | 3 ++- src/gallium/drivers/radeonsi/si_shader.c | 33 ++- src/gallium/drivers/radeonsi/si_shader.h | 10 +++--- 3 files changed, 28 insertions(+), 18 deletions(-) diff

[Mesa-dev] [PATCH 23/23] radeonsi: adjust the parameters of si_shader_dump

From: Marek Olšák The function will be extended to dump all binaries shaders will consist of, so si_shader* makes sense here. --- src/gallium/drivers/radeonsi/si_compute.c | 6 ++ src/gallium/drivers/radeonsi/si_shader.c | 18 +++---

[Mesa-dev] [PATCH 21/23] radeonsi: inline si_shader_binary_read

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_compute.c | 4 ++-- src/gallium/drivers/radeonsi/si_shader.c | 8 +--- src/gallium/drivers/radeonsi/si_shader.h | 2 -- 3 files changed, 3 insertions(+), 11 deletions(-) diff --git

[Mesa-dev] [PATCH 05/23] radeonsi: simplify setting the DONE bit for PS exports

From: Marek Olšák First find out what the last export is and simply set the DONE bit there. --- src/gallium/drivers/radeonsi/si_shader.c| 126 ++-- src/gallium/drivers/radeonsi/si_state_shaders.c | 2 +- 2 files changed, 55 insertions(+), 73

[Mesa-dev] [PATCH 20/23] radeonsi: move si_shader_dump call out of si_shader_binary_read

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_compute.c | 8 +--- src/gallium/drivers/radeonsi/si_shader.c | 21 + src/gallium/drivers/radeonsi/si_shader.h | 12 +++- 3 files changed, 21 insertions(+), 20 deletions(-) diff --git

[Mesa-dev] [PATCH 19/23] radeonsi: separate shader dumping code to si_shader_dump and *_dump_stats

From: Marek Olšák Eventually, I'd like to dump stats for several combined binaries, which is why you don't see a binary parameter in si_shader_dump_stats --- src/gallium/drivers/radeonsi/si_shader.c | 42 +++- 1 file changed, 30 insertions(+), 12

Re: [Mesa-dev] [PATCH 1/2] llvmpipe: scale up bounding box planes to subpixel precision

Intricate stuff. As long as testing was successful, looks good to me. For both, Reviewed-by: Brian Paul On 01/05/2016 05:06 PM, srol...@vmware.com wrote: From: Roland Scheidegger Otherwise some planes we get in rasterization have subpixel precision,

[Mesa-dev] [Bug 77449] Tracker bug for all bugs related to Steam titles

https://bugs.freedesktop.org/show_bug.cgi?id=77449 Bug 77449 depends on bug 76664, which changed state. Bug 76664 Summary: Metro: Last Light segfaults very often in level 10 (swamp) on loading last checkpoint https://bugs.freedesktop.org/show_bug.cgi?id=76664 What|Removed

Re: [Mesa-dev] [PATCH] glsl: fix varying slot allocation for blocks and structs with explicit locations

On Wed, Jan 6, 2016 at 4:32 AM, Timothy Arceri wrote: > Previously each member was being counted as using a single slot, > count_attribute_slots() fixes the count for array and struct members. > > Also don't assign a negitive to the unsigned expl_location variable. >

Re: [Mesa-dev] [PATCH 05/23] radeonsi: simplify setting the DONE bit for PS exports

Patches 1-5 are Reviewed-by: Nicolai Hähnle On 06.01.2016 07:41, Marek Olšák wrote: From: Marek Olšák First find out what the last export is and simply set the DONE bit there. --- src/gallium/drivers/radeonsi/si_shader.c| 126

Re: [Mesa-dev] [PATCH 2/2] llvmpipe: avoid most 64 bit math in rasterization

Am 06.01.2016 um 17:31 schrieb Jose Fonseca: > On 06/01/16 16:26, Jose Fonseca wrote: >> On 06/01/16 00:06, srol...@vmware.com wrote: >>> From: Roland Scheidegger >>> >>> The trick here is to recognize that in the c + n * dcdx calculations, >>> not only can the lower

[Mesa-dev] [Bug 77449] Tracker bug for all bugs related to Steam titles

https://bugs.freedesktop.org/show_bug.cgi?id=77449 Ernst Sjöstrand changed: What|Removed |Added CC||ern...@gmail.com --

[Mesa-dev] [Bug 77449] Tracker bug for all bugs related to Steam titles

https://bugs.freedesktop.org/show_bug.cgi?id=77449 Ernst Sjöstrand changed: What|Removed |Added Depends on||92944 -- You are

Re: [Mesa-dev] [PATCH 23/28] glsl: add pack varying to resource list for vertex input / fragment output

On 2015-12-29 06:00, Timothy Arceri wrote: > This is needed now that we pack these type of varyings when they have a > component layout qualifier. > --- > src/glsl/linker.cpp | 15 --- > 1 file changed, 8 insertions(+), 7 deletions(-) > > diff --git a/src/glsl/linker.cpp

[Mesa-dev] [PATCH 1/3] st/mesa: check state->mesa in early return check in st_validate_state()

We were checking the dirty->st flags but not the dirty->mesa flags. When we took the early return, we didn't clear the dirty->mesa flags so the next time we called st_validate_state() we'd often flush the glBitmap cache. And since st_validate_state() is called from st_Bitmap(), it meant we

Re: [Mesa-dev] [PATCH] gallium/r600: Replace ALIGN_DIVUP with DIV_ROUND_UP

Nicolai Hähnle writes: > On 30.12.2015 13:44, Krzysztof A. Sobiecki wrote: >> Nicolai Hähnle writes: >> >>> On 30.12.2015 08:42, Krzysztof A. Sobiecki wrote: Nicolai Hähnle writes: > On 29.12.2015 14:27, Krzysztof A.

Re: [Mesa-dev] [PATCH 00/23] RadeonSI: Restructuring shader code generation part 2

On Wed, Jan 06, 2016 at 01:41:22PM +0100, Marek Olšák wrote: > Hi, > > These boring patches focus on restructuring pixel shader output handling and > code around si_compile_llvm (config, dumping, etc.). They are mostly code > movements and dividing functions into smaller ones, so that they can

[Mesa-dev] [PATCH 2/4] st/mesa: use GLbitfield in st_state_flags, add comments

Use GLbitfield instead of GLuint to be consistent with other variables. --- src/mesa/state_tracker/st_context.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/state_tracker/st_context.h b/src/mesa/state_tracker/st_context.h index 35c8932..91b0f97 100644 ---

[Mesa-dev] [PATCH 1/4] s/GLuint/GLbitfield/ for st_invalidate_state() parameter

To match dd_function_table::UpdateState(). --- src/mesa/state_tracker/st_context.c | 2 +- src/mesa/state_tracker/st_context.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/state_tracker/st_context.c b/src/mesa/state_tracker/st_context.c index 31cc99d..e12c166

[Mesa-dev] [PATCH 3/3] st/mesa: be more careful about state validation in st_Bitmap()

If the only dirty state is mesa's _NEW_PROGRAM_CONSTANTS flag, we can skip state validation before drawing a bitmap since that state doesn't effect bitmap rendering. This further increases the performance of the ipers demo on llvmpipe to about what it was before commit 36c93a6fae27561. ---

Re: [Mesa-dev] [PATCH 2/2] llvmpipe: avoid most 64 bit math in rasterization

On 06/01/16 16:26, Jose Fonseca wrote: On 06/01/16 00:06, srol...@vmware.com wrote: From: Roland Scheidegger The trick here is to recognize that in the c + n * dcdx calculations, not only can the lower FIXED_ORDER bits not change (as the dcdx values have those all zero)

[Mesa-dev] [PATCH 2/3] st/mesa: move bitmap cache flushing out of state validation

Just do it where needed (before drawing, clearing, etc). --- src/mesa/state_tracker/st_atom.c | 4 src/mesa/state_tracker/st_cb_clear.c | 3 +++ src/mesa/state_tracker/st_cb_drawpixels.c | 5 + src/mesa/state_tracker/st_cb_drawtex.c| 3 +++

[Mesa-dev] [PATCH 2/2] st/mesa: check texture target in allocate_full_mipmap()

Some kinds of textures never have mipmaps. 3D textures seldom have mipmaps. --- src/mesa/state_tracker/st_cb_texture.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/src/mesa/state_tracker/st_cb_texture.c b/src/mesa/state_tracker/st_cb_texture.c index 867d4da..f8b3679

[Mesa-dev] [PATCH 1/2] st/mesa: move mipmap allocation check logic into a function

Better readability and easier to extend. --- src/mesa/state_tracker/st_cb_texture.c | 54 ++ 1 file changed, 42 insertions(+), 12 deletions(-) diff --git a/src/mesa/state_tracker/st_cb_texture.c b/src/mesa/state_tracker/st_cb_texture.c index 62f149a..867d4da

[Mesa-dev] [PATCH] wgl: Rudimentary wglUseFontBitmaps sample.

It uses SYSTEM_FONT which actually creates some challenges when emulating wglUseFontBitmaps: in spite what https://msdn.microsoft.com/en-us/library/windows/desktop/dd374392.aspx implies, GetGlyphOutline(GGO_BITMAP) does not seem to work with certain fonts. The only solution is to draw the font

Re: [Mesa-dev] [PATCH 2/2] llvmpipe: avoid most 64 bit math in rasterization

On 06/01/16 00:06, srol...@vmware.com wrote: From: Roland Scheidegger The trick here is to recognize that in the c + n * dcdx calculations, not only can the lower FIXED_ORDER bits not change (as the dcdx values have those all zero) but that this means the sign bit of the

Re: [Mesa-dev] [PATCH] wgl: Rudimentary wglUseFontBitmaps sample.

The copyright line could be bumped to 2016. Reviewed-by: Brian Paul On 01/06/2016 09:21 AM, Jose Fonseca wrote: It uses SYSTEM_FONT which actually creates some challenges when emulating wglUseFontBitmaps: in spite what

[Mesa-dev] [PATCH 3/4] vbo: s/GLuint/GLbitfield/ for state bitmasks

--- src/mesa/vbo/vbo.h | 2 +- src/mesa/vbo/vbo_context.c | 2 +- src/mesa/vbo/vbo_exec.c| 2 +- src/mesa/vbo/vbo_exec.h| 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/mesa/vbo/vbo.h b/src/mesa/vbo/vbo.h index cef3b8c..dd9b428 100644 ---

[Mesa-dev] [PATCH 4/4] main: s/GLuint/GLbitfield for state bitmasks

--- src/mesa/main/api_arrayelt.c | 4 ++-- src/mesa/main/api_arrayelt.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mesa/main/api_arrayelt.c b/src/mesa/main/api_arrayelt.c index 92d8238..c84db5f 100644 --- a/src/mesa/main/api_arrayelt.c +++

[Mesa-dev] [PATCH 2/3] nir/algebraic: Add more lowering

This commit adds lowering options for the following opcodes: - nir_op_fmod - nir_op_bitfield_insert - nir_op_uadd_carry - nir_op_usub_borrow --- src/glsl/nir/nir.h| 4 src/glsl/nir/nir_opt_algebraic.py | 6 ++ 2 files changed, 10 insertions(+) diff --git

[Mesa-dev] [PATCH 3/3] i965/compiler: Enable more lowering in NIR

We don't need these for GLSL or ARB, but we need them for SPIR-V --- src/mesa/drivers/dri/i965/brw_shader.cpp | 5 + 1 file changed, 5 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_shader.cpp b/src/mesa/drivers/dri/i965/brw_shader.cpp index 6d15c60..4ae403c 100644 ---

Re: [Mesa-dev] [PATCH 16/28] glsl: don't pack tessellation stages like we do other stages

On Wed, 2016-01-06 at 17:50 -0500, Ilia Mirkin wrote: > On Tue, Dec 29, 2015 at 12:00 AM, Timothy Arceri > wrote: > > Tessellation shaders treat varyings as shared memory and > > invocations > > can access each others varyings therefore we can't use the existing > >

[Mesa-dev] [PATCH V2 16/35] glsl: move packing rules for tessellation stages into the packing code

Following patches will allow packing of varyings with explicit locations via the component layout qualifier. Moving the rules here will enable us to call an alternate path for packing tessellation stages with explicit locations. --- V2: move the tessellation packing rules, allow TES output to be

Re: [Mesa-dev] [PATCH] draw: fix line stippling with unfilled prims

Reviewed-by: Brian Paul On 01/06/2016 03:26 PM, srol...@vmware.com wrote: From: Roland Scheidegger The unfilled stage was not filling in the prim header, and the line stage then decided to reset the stipple counter or not based on the uninitialized

Re: [Mesa-dev] [PATCH 16/28] glsl: don't pack tessellation stages like we do other stages

On Tue, 2015-12-29 at 17:38 +1100, eocallag...@alterapraxis.com wrote: > On 2015-12-29 16:00, Timothy Arceri wrote: > > Tessellation shaders treat varyings as shared memory and > > invocations > > can access each others varyings therefore we can't use the existing > > method to lower them. > > >

Re: [Mesa-dev] [PATCH 16/28] glsl: don't pack tessellation stages like we do other stages

On Wed, Jan 6, 2016 at 6:40 PM, Timothy Arceri wrote: > On Wed, 2016-01-06 at 17:50 -0500, Ilia Mirkin wrote: >> On Tue, Dec 29, 2015 at 12:00 AM, Timothy Arceri >> wrote: >> > Tessellation shaders treat varyings as shared memory and >>

Re: [Mesa-dev] [PATCH] glsl: replace null check with assert

Ping. Just looking over some older patches of mine. I made this change both as a clean up but also because the constant expression evaluation code is some of the most expensive in the compiler and this was right in the hot path for some of the AoA tests until I improved some other optimisation to

Re: [Mesa-dev] [PATCH] glsl: fix varying slot allocation for blocks and structs with explicit locations

On Wed, Jan 6, 2016 at 4:32 PM, Timothy Arceri wrote: > On Wed, 2016-01-06 at 09:46 -0500, Ilia Mirkin wrote: >> On Wed, Jan 6, 2016 at 4:32 AM, Timothy Arceri >> wrote: >> > Previously each member was being counted as using a single

[Mesa-dev] [PATCH 1/3] nir/opcodes: Fix the folding expression for usub_borrow

--- src/glsl/nir/nir_opcodes.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/glsl/nir/nir_opcodes.py b/src/glsl/nir/nir_opcodes.py index 1cd01a4..4bc6d16 100644 --- a/src/glsl/nir/nir_opcodes.py +++ b/src/glsl/nir/nir_opcodes.py @@ -366,7 +366,7 @@

Re: [Mesa-dev] [PATCH 16/28] glsl: don't pack tessellation stages like we do other stages

On Tue, Dec 29, 2015 at 12:00 AM, Timothy Arceri wrote: > Tessellation shaders treat varyings as shared memory and invocations > can access each others varyings therefore we can't use the existing > method to lower them. That's not strictly true... this is only true

Re: [Mesa-dev] [PATCH 16/28] glsl: don't pack tessellation stages like we do other stages

On Wed, 2016-01-06 at 18:45 -0500, Ilia Mirkin wrote: > On Wed, Jan 6, 2016 at 6:40 PM, Timothy Arceri > wrote: > > On Wed, 2016-01-06 at 17:50 -0500, Ilia Mirkin wrote: > > > On Tue, Dec 29, 2015 at 12:00 AM, Timothy Arceri > > >

Re: [Mesa-dev] [PATCH 3/3] llvmpipe: add sse code for fixed position calculation

Am 04.01.2016 um 20:38 schrieb Jose Fonseca: > On 02/01/16 20:39, srol...@vmware.com wrote: >> From: Roland Scheidegger >> >> This is quite a few less instructions, albeit still do the 2 64bit muls >> with scalar c code (they'd need way more shuffles, plus fixup for the >>

Re: [Mesa-dev] [PATCH 1/4] vbo: create a new draw function interface for indirect draws

On 01/04/2016 07:22 PM, Ilia Mirkin wrote: > Sure, no problem. Do you think you'll have time to look at it in the > next day or two though? Yes. I'll review it on Thursday. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

Re: [Mesa-dev] [PATCH V2 16/35] glsl: move packing rules for tessellation stages into the packing code

Whoops, the subject line should be [PATCH V2 16/28] ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH V2 16/35] glsl: move packing rules for tessellation stages into the packing code

On Wed, 2016-01-06 at 20:19 -0500, Ilia Mirkin wrote: > On Wed, Jan 6, 2016 at 8:00 PM, Timothy Arceri > wrote: > > Following patches will allow packing of varyings with explicit > > locations > > via the component layout qualifier. Moving the rules here will > >

Re: [Mesa-dev] [PATCH 09/23] radeonsi: use EXP_NULL for pixel shaders without outputs

On 06.01.2016 21:41, Marek Olšák wrote: > From: Marek Olšák > > This never happens currently. So this change is untested? If so, how confident are you that this won't break if it ever actually gets hit? :) -- Earthling Michel Dänzer |

Re: [Mesa-dev] [PATCH] i965: quieten compiler warning about out-of-bounds access

On Tue, Jan 5, 2016 at 8:30 PM, Jason Ekstrand wrote: > > On Jan 4, 2016 8:30 PM, "Ilia Mirkin" wrote: >> >> gcc 4.9.3 shows the following error: >> >> brw_vue_map.c:260:20: warning: array subscript is above array bounds >> [-Warray-bounds] >>

Re: [Mesa-dev] [PATCH V2 16/35] glsl: move packing rules for tessellation stages into the packing code

On Wed, Jan 6, 2016 at 8:00 PM, Timothy Arceri wrote: > Following patches will allow packing of varyings with explicit locations > via the component layout qualifier. Moving the rules here will enable > us to call an alternate path for packing tessellation stages

[Mesa-dev] [PATCH] i965: Explicitly write the "TR DS Cache Disable" bit at TCS EOT.

Bit 0 of the Patch Header is "TR DS Cache Disable". Setting that bit disables the DS Cache for tessellator-output topologies resulting in stitch-transition regions (but leaves it enabled for other cases). We probably shouldn't leave this to chance - the URB could contain garbage - which could

[Mesa-dev] [PATCH] draw: fix line stippling with unfilled prims

From: Roland Scheidegger The unfilled stage was not filling in the prim header, and the line stage then decided to reset the stipple counter or not based on the uninitialized data. This causes some failures in conform linestipple test (albeit quite randomly happening

[Mesa-dev] [PATCH] nv50/ir: don't touch degree on physreg RIG nodes

These nodes don't go through reduction, so we shouldn't be increasing their degrees. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=91895 Signed-off-by: Ilia Mirkin Cc: "11.0 11.1" --- I would like to see a *bunch* of testing on

Re: [Mesa-dev] [PATCH 09/28] glsl: validate and store component layout qualifier in GLSL IR

On Mon, Dec 28, 2015 at 9:00 PM, Timothy Arceri wrote: > We make use of the existing IR field location_frac used for tracking > component locations. > --- > src/glsl/ast_to_hir.cpp | 38 ++ > src/glsl/ir.h | 5 + >

Re: [Mesa-dev] [PATCH 06/28] glsl: fix overlapping of varying locations for arrays and structs

On Mon, Dec 28, 2015 at 9:00 PM, Timothy Arceri wrote: > Previously we were only reserving a single location for arrays and > structs. > > We also didn't take into account implicit locations clashing with > explicit locations when assigning locations for their arrays

Re: [Mesa-dev] [PATCH 07/28] glsl: don't try adding build-ins to explicit locations bitmask

s/build-ins/built-ins in commit message On Mon, Dec 28, 2015 at 9:00 PM, Timothy Arceri wrote: > --- > src/glsl/link_varyings.cpp | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/src/glsl/link_varyings.cpp b/src/glsl/link_varyings.cpp >

Re: [Mesa-dev] [PATCH 08/28] glsl: parse component layout qualifier

On Mon, Dec 28, 2015 at 9:00 PM, Timothy Arceri wrote: > --- > src/glsl/ast.h | 14 ++ > src/glsl/ast_type.cpp | 3 +++ > src/glsl/glsl_parser.yy | 11 +++ > 3 files changed, 28 insertions(+) > > diff --git a/src/glsl/ast.h

Re: [Mesa-dev] [PATCH 10/28] glsl: fix cross validation for explicit locations on structs and arrays

On Mon, Dec 28, 2015 at 9:00 PM, Timothy Arceri wrote: > --- > src/glsl/link_varyings.cpp | 43 ++- > 1 file changed, 30 insertions(+), 13 deletions(-) > > diff --git a/src/glsl/link_varyings.cpp b/src/glsl/link_varyings.cpp >

Re: [Mesa-dev] [PATCH 1/3] st/mesa: check state->mesa in early return check in st_validate_state()

On 06/01/16 16:50, Brian Paul wrote: We were checking the dirty->st flags but not the dirty->mesa flags. When we took the early return, we didn't clear the dirty->mesa flags so the next time we called st_validate_state() we'd often flush the glBitmap cache. And since st_validate_state() is

Re: [Mesa-dev] [PATCH] glsl: fix varying slot allocation for blocks and structs with explicit locations

On Wed, 2016-01-06 at 09:46 -0500, Ilia Mirkin wrote: > On Wed, Jan 6, 2016 at 4:32 AM, Timothy Arceri > wrote: > > Previously each member was being counted as using a single slot, > > count_attribute_slots() fixes the count for array and struct > > members. > > > >

Re: [Mesa-dev] [PATCH 4/4] main: s/GLuint/GLbitfield for state bitmasks

On 06/01/16 16:51, Brian Paul wrote: --- src/mesa/main/api_arrayelt.c | 4 ++-- src/mesa/main/api_arrayelt.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mesa/main/api_arrayelt.c b/src/mesa/main/api_arrayelt.c index 92d8238..c84db5f 100644 ---

Re: [Mesa-dev] [PATCH 2/2] st/mesa: check texture target in allocate_full_mipmap()

On 06/01/16 17:10, Brian Paul wrote: Some kinds of textures never have mipmaps. 3D textures seldom have mipmaps. --- src/mesa/state_tracker/st_cb_texture.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/src/mesa/state_tracker/st_cb_texture.c

Re: [Mesa-dev] [PATCH 06/28] glsl: fix overlapping of varying locations for arrays and structs

Thanks alot for reviewing these :) Are you able to take a quick look at 5 you seem to have missed it. I'd like to push these bug fixes as soon as possible. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

Re: [Mesa-dev] [PATCH 2/2] llvmpipe: avoid most 64 bit math in rasterization

On 06/01/16 18:18, Roland Scheidegger wrote: Am 06.01.2016 um 17:31 schrieb Jose Fonseca: On 06/01/16 16:26, Jose Fonseca wrote: On 06/01/16 00:06, srol...@vmware.com wrote: From: Roland Scheidegger The trick here is to recognize that in the c + n * dcdx calculations,

Re: [Mesa-dev] [PATCH 05/28] glsl: create helper to remove outer vertex index array used by some stages

On Mon, Dec 28, 2015 at 9:00 PM, Timothy Arceri wrote: > This will be used in the following patch for calculating array sizes correctly > when reserving explicit varying locations. > --- > src/glsl/link_varyings.cpp | 36 ++-- > 1

Re: [Mesa-dev] [PATCH 23/23] radeonsi: adjust the parameters of si_shader_dump

I like the code structure established by this series. Patches 20-23 are Reviewed-by: Nicolai Hähnle On 06.01.2016 07:41, Marek Olšák wrote: From: Marek Olšák The function will be extended to dump all binaries shaders will consist of, so

Re: [Mesa-dev] [PATCH] gallium/r600: Replace ALIGN_DIVUP with DIV_ROUND_UP

Pushed. On 06.01.2016 12:10, Krzysztof A. Sobiecki wrote: Nicolai Hähnle writes: On 30.12.2015 13:44, Krzysztof A. Sobiecki wrote: Nicolai Hähnle writes: On 30.12.2015 08:42, Krzysztof A. Sobiecki wrote: Nicolai Hähnle writes:

Re: [Mesa-dev] [PATCH 10/23] radeonsi: move MRT color exporting into a separate function

On 06.01.2016 07:41, Marek Olšák wrote: From: Marek Olšák This will be used by a fragment shader epilog. --- src/gallium/drivers/radeonsi/si_shader.c | 93 +++- 1 file changed, 55 insertions(+), 38 deletions(-) diff --git

[Mesa-dev] [Bug 93577] Total war: Attila crashes at startup

https://bugs.freedesktop.org/show_bug.cgi?id=93577 --- Comment #5 from ArneJ --- You're right, it needs a GL 4.3 Core Context. I was able to start the game with the following launch options in steam: MESA_GL_VERSION_OVERRIDE=4.3 MESA_GLSL_VERSION_OVERRIDE=430 %command% It runs

Re: [Mesa-dev] [PATCH 19/23] radeonsi: separate shader dumping code to si_shader_dump and *_dump_stats

On 06.01.2016 07:41, Marek Olšák wrote: From: Marek Olšák Eventually, I'd like to dump stats for several combined binaries, which is why you don't see a binary parameter in si_shader_dump_stats --- src/gallium/drivers/radeonsi/si_shader.c | 42