Re: [Mesa-dev] [PATCH 07/18] egl: add Android-specific extensions

2011-08-17 Thread Chad Versace
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Reviewed-by: Chad Versace c...@chad-versace.us On 08/16/2011 11:28 PM, Chia-I Wu wrote: Add EGL_ANDROID_image_native_buffer and EGL_ANDROID_swap_rectangle. There is no spec for them though. --- include/EGL/eglext.h | 14

Re: [Mesa-dev] [PATCH 09/18] android: build libGLES_mesa

2011-08-17 Thread Chad Versace
- -- Chad Versace c...@chad-versace.us -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQIcBAEBAgAGBQJOTAJ4AAoJEAIvNt057x8ilcAP/0wvxg/hUFAE/96bCsSDFjsB 5pl7KdyGpV7UyS71gpTSa/+P79zXRFqLb7+eXNTkApIyVn4G6XhDmhzaU0oLVlGT Y

Re: [Mesa-dev] [PATCH 14/18] android: build core EGL

2011-08-17 Thread Chad Versace
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 The version tag in the copyright header should be removed. But, either way, this is Reviewed-by: Chad Versace c...@chad-versace.us On 08/16/2011 11:28 PM, Chia-I Wu wrote: This builds the static library libmesa_egl from core EGL. --- Android.mk

Re: [Mesa-dev] [PATCH 15/18] android: build core mesa

2011-08-17 Thread Chad Versace
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Overall this looks good, but some of it I don't follow. I trust that you're doing the right thing for those parts. Acked-by: Chad Versace c...@chad-versace.us On 08/16/2011 11:28 PM, Chia-I Wu wrote: This builds the static library libmesa_st_mesa

Re: [Mesa-dev] [PATCH 17/18] android: build shared glapi

2011-08-17 Thread Chad Versace
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Reviewed-by: Chad Versace c...@chad-versace.us On 08/16/2011 11:28 PM, Chia-I Wu wrote: This builds the shared library libglapi from shared glapi. --- Android.mk |1 + src/mapi/Android.mk | 61

Re: [Mesa-dev] [PATCH 16/18] android: build glsl

2011-08-17 Thread Chad Versace
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/16/2011 11:28 PM, Chia-I Wu wrote: This builds the static library libmesa_glsl and executable glsl_compiler from glsl. glsl_compiler is only installed for engineering build. --- Android.mk |1 + src/glsl/Android.gen.mk |

Re: [Mesa-dev] [PATCH 18/18] android: make libGLES_mesa real

2011-08-17 Thread Chad Versace
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Acked-by: Chad Versace c...@chad-versace.us On 08/16/2011 11:28 PM, Chia-I Wu wrote: libGLES_mesa with swrast should link in these libraries libmesa_egl libmesa_st_egl libmesa_st_mesa libmesa_glsl libmesa_glsl_utils

Re: [Mesa-dev] [RFC-PATCH 00/18] add Android support

2011-08-17 Thread Chad Versace
to fold Android support into master and make progress towards a stable Mesa on Android. I've commented, acked, or rb'd all the patches that are within my domain. I've avoided commenting on patches specific to Gallium. - -- Chad Versace c...@chad-versace.us -BEGIN PGP SIGNATURE- Version

Re: [Mesa-dev] [PATCH 04/18] ralloc: SIZE_MAX is missing on Android

2011-08-18 Thread Chad Versace
On 08/17/2011 08:06 PM, Chia-I Wu wrote: On Thu, Aug 18, 2011 at 12:28 AM, Chad Versace c...@chad-versace.us wrote: On 08/17/2011 08:31 AM, Ian Romanick wrote: On 08/16/2011 11:28 PM, Chia-I Wu wrote: Define SIZE_MAX to UINT32_MAX for it. --- src/glsl/ralloc.c |4 1 files changed, 4

Re: [Mesa-dev] [PATCH 09/18] android: build libGLES_mesa

2011-08-18 Thread Chad Versace
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/17/2011 08:24 PM, Chia-I Wu wrote: On Thu, Aug 18, 2011 at 2:03 AM, Chad Versace c...@chad-versace.us wrote: I've commented below on TOP/Android.mk and TOP/Android.common.mk. The Gallium makefiles are outside of my domain, so I have

Re: [Mesa-dev] [PATCH 16/18] android: build glsl

2011-08-18 Thread Chad Versace
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Great. Then the glsl makefile is Reviewed-by: Chad Versace c...@chad-versace.us On 08/17/2011 08:26 PM, Chia-I Wu wrote: On Thu, Aug 18, 2011 at 4:06 AM, Chad Versace c...@chad-versace.us wrote: On 08/16/2011 11:28 PM, Chia-I Wu wrote: This builds

Re: [Mesa-dev] [RFC-PATCH 0/2] share source lists between scons and make

2011-08-18 Thread Chad Versace
Thanks for doing this, Chia-I. I like this approach. Chad Versace c...@chad-versace.us On 08/18/2011 03:33 AM, Jose Fonseca wrote: I think this is great. Thanks for stepping up and doing this, Olv! Concerning the implementation, my only suggestion is that it might be useful to have

Re: [Mesa-dev] [RFC-PATCH 00/18] add Android support

2011-08-18 Thread Chad Versace
On 08/17/2011 08:37 PM, Chia-I Wu wrote: On Thu, Aug 18, 2011 at 4:14 AM, Chad Versace c...@chad-versace.us wrote: On 08/16/2011 11:28 PM, Chia-I Wu wrote: Hi list, This patch series adds Android Gingerbread support to Mesa. To begin with, it only supports software rendering

[Mesa-dev] [PATCH] glsl: Do not link builtin_stubs.o into glsl_compiler

2011-08-18 Thread Chad Versace
Reviewed-by: Kenneth Graunke kenn...@whitecape.org Signed-off-by: Chad Versace c...@chad-versace.us --- src/glsl/Makefile |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/glsl/Makefile b/src/glsl/Makefile index c20a6c9..00b7b91 100644 --- a/src/glsl/Makefile +++ b/src

[Mesa-dev] [PATCH] mesa: Declare _mesa_meta_begin()/end() as public

2011-08-18 Thread Chad Versace
Declare _mesa_meta_begin()/end() in meta.h so that drivers can write custom meta-ops (such as HiZ resolves for i965). This necessitates moving the the META_* macros into meta.h. To prevent naming collisions, this commit renames each macro to be MESA_META_*. Signed-off-by: Chad Versace c...@chad

[Mesa-dev] [PATCH] intel: Emit assertion failure ASAP when DRI2 separate stencil handshake fails

2011-08-18 Thread Chad Versace
location is sufficiently unrelated to the DRI2 HiZ handshake as to be uninformative. In experimenting with HiZ, Anholt encountered this assertion failure and was unable to understand its cause. CC: Eric Anholt e...@anholt.net Signed-off-by: Chad Versace c...@chad-versace.us --- src/mesa/drivers

Re: [Mesa-dev] [PATCHv2 05/21] mesa: android has no log2f nor ffs

2011-08-19 Thread Chad Versace
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Reviewed-by: Chad Versace c...@chad-versace.us On 08/18/2011 07:37 PM, Chia-I Wu wrote: Define log2f(v) to be logf(v) / M_LN2 and ffs to __builtin_ffs. --- src/mesa/main/imports.h |8 +++- 1 files changed, 7 insertions(+), 1 deletions

Re: [Mesa-dev] [PATCHv2 21/21] android: make libGLES_mesa real

2011-08-19 Thread Chad Versace
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Reviewed-by: Chad Versace c...@chad-versace.us On 08/18/2011 07:37 PM, Chia-I Wu wrote: libGLES_mesa with swrast should link in these libraries libmesa_egl libmesa_egl_gallium libmesa_st_egl libmesa_st_mesa libmesa_glsl

Re: [Mesa-dev] [PATCHv2 00/21] initial Android support, try 2

2011-08-19 Thread Chad Versace
. Looks good to me. Thanks olv. - -- Chad Versace c...@chad-versace.us -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQIcBAEBAgAGBQJOTp9zAAoJEAIvNt057x8iYB0P/07r/fxAjTe8pOWhqP6lZS4M fMDRtRSwSrHDRISWO+bGjcbvZ45SqsbAA

Re: [Mesa-dev] [PATCH] intel: Emit assertion failure ASAP when DRI2 separate stencil handshake fails

2011-08-19 Thread Chad Versace
On 08/19/2011 10:35 AM, Eric Anholt wrote: On Thu, 18 Aug 2011 14:02:46 -0700, Chad Versace c...@chad-versace.us wrote: When intel_verify_dri2_has_hiz() discovers that DRI2 (that is, the DDX driver) cannot provide a separate stencil buffer, but intel_context::hw_must_use_separate_stencil

Re: [Mesa-dev] [PATCH] intel: Emit assertion failure ASAP when DRI2 separate stencil handshake fails

2011-08-19 Thread Chad Versace
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/19/2011 03:18 PM, Kenneth Graunke wrote: On 08/19/2011 10:44 AM, Chad Versace wrote: On 08/19/2011 10:35 AM, Eric Anholt wrote: On Thu, 18 Aug 2011 14:02:46 -0700, Chad Versace c...@chad-versace.us wrote: When intel_verify_dri2_has_hiz

Re: [Mesa-dev] [PATCH 0/2] share source lists between build systems

2011-08-22 Thread Chad Versace
Versace c...@chad-versace.us - -- Chad Versace c...@chad-versace.us -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQIcBAEBAgAGBQJOUoNYAAoJEAIvNt057x8icuQQAKHW2IF6BRv8RsOmsK4TSzuQ vwi8AhYLo1eIUTVTApFT

[Mesa-dev] [PATCH 1/2] i965: Factor source lists into Makefile.sources

2011-08-23 Thread Chad Versace
In preparation for porting i965 to Android, factor its source lists into a shared makefile. This prevents duplication of source lists, and hence prevents the Android from breaking as often. Signed-off-by: Chad Versace c...@chad-versace.us --- src/mesa/drivers/dri/i965/Makefile | 132

[Mesa-dev] [PATCH 2/2] i915: Factor source lists into Makefile.sources

2011-08-23 Thread Chad Versace
In preparation for porting i915 to Android, factor its source lists into a shared makefile. This prevents duplication of source lists, and hence prevents the Android from breaking as often. Signed-off-by: Chad Versace c...@chad-versace.us --- src/mesa/drivers/dri/i915/Makefile | 49

Re: [Mesa-dev] [PATCH 1/2] i965: Factor source lists into Makefile.sources

2011-08-23 Thread Chad Versace
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 The first two lines of the diff, + MESA_TOP := $(TOP) + ignore them. They slipped in by accident. - -- Chad Versace c...@chad-versace.us On 08/23/2011 05:04 PM, Chad Versace wrote: In preparation for porting i965 to Android, factor its

Re: [Mesa-dev] [PATCH 1/3] egl_dri2: allow RGBA masks to be specified for matching

2011-08-24 Thread Chad Versace
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 I see why it's necessary, and can think of no cleaner way of doing it. So this is Reviewed-by: Chad Versace c...@chad-versace.us On 08/23/2011 08:10 PM, Chia-I Wu wrote: Add rgba_masks to dri2_add_config. When it is non-NULL, the DRI config

Re: [Mesa-dev] [PATCH 3/3] android: add support for egl_dri2

2011-08-24 Thread Chad Versace
+++ src/egl/main/Android.mk |3 ++ 3 files changed, 63 insertions(+), 1 deletions(-) create mode 100644 src/egl/drivers/dri2/Android.mk Reviewed-by: Chad Versace c...@chad-versace.us - -- Chad Versace c...@chad-versace.us -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11

Re: [Mesa-dev] [PATCH 2/3] egl_dri2: add support for Android

2011-08-24 Thread Chad Versace
*/ +#include i915_drm.h +/* for radeon */ +#include radeon_drm.h These includes should be moved to the top of the file. - -- Chad Versace c...@chad-versace.us -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

Re: [Mesa-dev] [PATCH 2/3] egl_dri2: add support for Android

2011-08-25 Thread Chad Versace
On 08/24/2011 06:20 PM, Chia-I Wu wrote: On Thu, Aug 25, 2011 at 8:58 AM, Chad Versace c...@chad-versace.us wrote: Comments below. On 08/23/2011 08:10 PM, Chia-I Wu wrote: Add platform_android.c that supports _EGL_PLAFORM_ANDROID. It works with drm_gralloc, where back buffers of windows

Re: [Mesa-dev] [PATCH] glsl: Bail after reporting an error for non-constant const_in parameters.

2011-08-25 Thread Chad Versace
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Simple enough. Reviewed-by: Chad Versace c...@chad-versace.us On 08/25/2011 09:43 AM, Kenneth Graunke wrote: Otherwise we continue and hit the Illegal formal parameter mode assertion. Fixes negative compile test texelFetchOffset.frag in piglit

Re: [Mesa-dev] [PATCH] glsl: Fail linking if a global is both a uniform and non-uniform.

2011-08-25 Thread Chad Versace
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 We weren't catching this? Embarrassing. Reviewed-by: Chad Versace c...@chad-versace.us We may also want to emit an error when a variable is declared as 'in' a VS and as 'out' in a FS. But I'm not sure that's actually illegal. On 08/25/2011 08:26 AM

Re: [Mesa-dev] [PATCH 2/3] egl_dri2: add support for Android

2011-08-25 Thread Chad Versace
[CC'ing krh because I learned much of this from him, so may have some insight to share with us.] On 08/25/2011 08:14 PM, Chia-I Wu wrote: On Fri, Aug 26, 2011 at 4:09 AM, Chad Versace c...@chad-versace.us wrote: On 08/24/2011 06:20 PM, Chia-I Wu wrote: On Thu, Aug 25, 2011 at 8:58 AM, Chad

Re: [Mesa-dev] [PATCH 1/2] i965: Factor source lists into Makefile.sources

2011-08-25 Thread Chad Versace
Any comments from the Intel guys? I plan on pushing this Friday if no one objects. -- Chad Versace c...@chad-versace.us On 08/23/2011 05:04 PM, Chad Versace wrote: In preparation for porting i965 to Android, factor its source lists into a shared makefile. This prevents duplication of source

Re: [Mesa-dev] [PATCH 2/3] egl_dri2: add support for Android

2011-08-26 Thread Chad Versace
On 08/25/2011 11:19 PM, Chia-I Wu wrote: On Fri, Aug 26, 2011 at 2:05 PM, Chia-I Wu olva...@gmail.com wrote: On Fri, Aug 26, 2011 at 12:55 PM, Chad Versace c...@chad-versace.us wrote: [CC'ing krh because I learned much of this from him, so may have some insight to share with us.] On 08/25

[Mesa-dev] [PATCH 0/8] i965, mesa: Build libmesa_dricore and i965_dri for Android

2011-08-26 Thread Chad Versace
This series builds libmesa_dricore.so and i965_dri.so for Android. Along the way, a few cleanups are necessary. This just gets the driver to build. I have not tested it yet. Chad Versace (8): android: Remove -fvisibility=hidden from CFLAGS so that we can build a shared dricore mesa

[Mesa-dev] [PATCH 1/8] android: Remove -fvisibility=hidden from CFLAGS so that we can build a shared dricore

2011-08-26 Thread Chad Versace
If you attempt to link together libmesa_dricore.so from object files built with visibility=hidden, then the library is useless. It exposes no symbols. Signed-off-by: Chad Versace c...@chad-versace.us --- Android.common.mk |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git

[Mesa-dev] [PATCH 3/8] make: Document imported variables

2011-08-26 Thread Chad Versace
In src/mesa/Android.mk, it is non-trivial to determine which variables are imported by `include sources.mak`. So document them. Signed-off-by: Chad Versace c...@chad-versace.us --- src/mesa/Android.mk |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/src/mesa

[Mesa-dev] [PATCH 2/8] mesa: Build libmesa_dricore.so for Android

2011-08-26 Thread Chad Versace
libmesa_dricore is analogous to the libdricore built by the Autoconf build. Signed-off-by: Chad Versace c...@chad-versace.us --- src/mesa/Android.mk | 35 +++ 1 files changed, 35 insertions(+), 0 deletions(-) diff --git a/src/mesa/Android.mk b/src/mesa

[Mesa-dev] [PATCH 5/8] make: Factor out source lists from drivers/dri/common into Makefile.sources

2011-08-26 Thread Chad Versace
-off: Chad Versace c...@chad-versace.us --- src/mesa/drivers/dri/Makefile.defines| 23 ++- src/mesa/drivers/dri/common/Makefile.sources | 18 ++ 2 files changed, 28 insertions(+), 13 deletions(-) create mode 100644 src/mesa/drivers/dri/common

[Mesa-dev] [PATCH 4/8] make: Remove duplicate occurence of driverfuncs.c

2011-08-26 Thread Chad Versace
Stop building driverfuncs.c twice for each DRI driver. driverfuncs.c is included in both libmesa.a and in src/mesa/drivers/dri/Makefiles.defines:COMMON_SOURCES, so remove it from COMMON_SOURCES. Signed-off-by: Chad Versace c...@chad-versace.us --- src/mesa/drivers/dri/Makefile.defines |1

[Mesa-dev] [PATCH 7/8] i965: Fix Android build by removing relative includes

2011-08-26 Thread Chad Versace
Add $(TOP)/src/mesa to include paths and replace each occurence of #include ../glsl/*.h with #include glsl/*.h Signed-off-by: Chad Versace c...@chad-versace.us --- src/mesa/drivers/dri/i965/Makefile |1 + src/mesa/drivers/dri/i965/brw_clip.c |2 +- src

[Mesa-dev] [PATCH 6/8] dri: Build libmesa_dri_common for Android

2011-08-26 Thread Chad Versace
libmesa_dri_common is a static library that contains the sources in src/mesa/drivers/dri/common. Each DRI driver should link to it. Signed-off-by: Chad Versace c...@chad-versace.us --- Android.mk |1 + src/mesa/drivers/dri/common/Android.mk | 49

[Mesa-dev] [PATCH 8/8] i965: Build i965_dri.so for Android

2011-08-26 Thread Chad Versace
This just gets the driver to build. I have not yet tested if the driver actually works. Signed-off-by: Chad Versace c...@chad-versace.us --- Android.mk |3 +- src/mesa/drivers/dri/Android.mk | 61 ++ src/mesa/drivers/dri/i965

Re: [Mesa-dev] [PATCH 5/8] make: Factor out source lists from drivers/dri/common into Makefile.sources

2011-08-28 Thread Chad Versace
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/26/2011 10:56 PM, Chia-I Wu wrote: On Sat, Aug 27, 2011 at 9:53 AM, Chad Versace c...@chad-versace.us wrote: In order that the autoconf and Android build can share the same source lists, move the lists from src/mesa/drivers/dri

Re: [Mesa-dev] [PATCH 8/8] i965: Build i965_dri.so for Android

2011-08-28 Thread Chad Versace
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/26/2011 10:51 PM, Chia-I Wu wrote: On Sat, Aug 27, 2011 at 9:54 AM, Chad Versace c...@chad-versace.us wrote: This just gets the driver to build. I have not yet tested if the driver actually works. Signed-off-by: Chad Versace c...@chad

Re: [Mesa-dev] [PATCH 7/8] i965: Fix Android build by removing relative includes

2011-08-28 Thread Chad Versace
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Spurious whitespace is fixed in v2. On 08/27/2011 12:19 AM, Ian Romanick wrote: On 08/26/2011 06:54 PM, Chad Versace wrote: Add $(TOP)/src/mesa to include paths and replace each occurence of #include ../glsl/*.h with #include glsl/*.h

[Mesa-dev] [PATCH 0/3] make: A few small cleanups

2011-08-29 Thread Chad Versace
Chad Versace (3): make: Remove duplicate defintion of COMMON_SOURCES in Radeon makefiles make: Remove duplicate occurence of driverfuncs.c make: Factor out source lists from drivers/dri/common into Makefile.sources src/mesa/drivers/dri/Makefile.defines| 21

[Mesa-dev] [PATCH 1/3] make: Remove duplicate defintion of COMMON_SOURCES in Radeon makefiles

2011-08-29 Thread Chad Versace
Remove defintion of COMMON_SOURCES from {r300,r660}/Makefile. The defintion is a duplicate of that found in src/mesa/drivers/dri/Makefile.defines. CC: Ian Romanick i...@freedesktop.org Signed-off-by: Chad Versace c...@chad-versace.us --- src/mesa/drivers/dri/r300/Makefile |9 - src

[Mesa-dev] [PATCH 2/3] make: Remove duplicate occurence of driverfuncs.c

2011-08-29 Thread Chad Versace
commit message. For the autoconf build, it was incorrect to say that driverfuncs.o was built twice. CC: Ian Romanick i...@freedesktop.org Signed-off-by: Chad Versace c...@chad-versace.us --- src/mesa/drivers/dri/Makefile.defines |1 - src/mesa/drivers/dri/swrast/Makefile |1 - 2 files

[Mesa-dev] [PATCH 3/3] make: Factor out source lists from drivers/dri/common into Makefile.sources

2011-08-29 Thread Chad Versace
- [olv] Remove MESA_TOP from definition of *_INCLUDES so that Makefile.sources can be self-contained. CC: Chia-I Wu o...@lunarg.com Signed-off: Chad Versace c...@chad-versace.us --- src/mesa/drivers/dri/Makefile.defines| 20 +++- src/mesa/drivers/dri/common

Re: [Mesa-dev] [PATCH 0/8] i965, mesa: Build libmesa_dricore and i965_dri for Android

2011-08-29 Thread Chad Versace
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 v2 of this series has been posted. - -- Chad Versace c...@chad-versace.us On 08/26/2011 06:53 PM, Chad Versace wrote: This series builds libmesa_dricore.so and i965_dri.so for Android. Along the way, a few cleanups are necessary. This just

[Mesa-dev] [v2 PATCH 0/5] i965, mesa: Build libmesa_dricore and i965_dri for Android

2011-08-29 Thread Chad Versace
Changes noted in each patch. Chad Versace (5): mesa: Build libmesa_dricore.a for Android make: Document imported variables dri: Build libmesa_dri_common for Android i965: Fix Android build by removing relative includes i965: Build i965_dri.so for Android Android.mk

[Mesa-dev] [PATCH 1/5] mesa: Build libmesa_dricore.a for Android

2011-08-29 Thread Chad Versace
...@freedesktop.org CC: Chia-I Wu o...@lunarg.com Signed-off-by: Chad Versace c...@chad-versace.us --- src/mesa/Android.mk | 29 + 1 files changed, 29 insertions(+), 0 deletions(-) diff --git a/src/mesa/Android.mk b/src/mesa/Android.mk index 67808d4..5f0f4af 100644 --- a/src

[Mesa-dev] [PATCH 2/5] make: Document imported variables

2011-08-29 Thread Chad Versace
In src/mesa/Android.mk, it is non-trivial to determine which variables are imported by `include sources.mak`. So document them. v2 - [olv] Add X86_sources to list of documented variables. CC: Chia-I Wu o...@lunarg.com Signed-off-by: Chad Versace c...@chad-versace.us --- src/mesa/Android.mk

Re: [Mesa-dev] [PATCH 3/3] make: Factor out source lists from drivers/dri/common into Makefile.sources

2011-08-30 Thread Chad Versace
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/29/2011 08:46 PM, Chia-I Wu wrote: On Tue, Aug 30, 2011 at 2:43 AM, Chad Versace c...@chad-versace.us wrote: In order that the Autoconf and Android build can share the same source lists, move the lists from src/mesa/drivers/dri

Re: [Mesa-dev] [PATCH 5/5] i965: Build i965_dri.so for Android

2011-08-30 Thread Chad Versace
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/29/2011 08:59 PM, Chia-I Wu wrote: On Tue, Aug 30, 2011 at 2:50 AM, Chad Versace c...@chad-versace.us wrote: Compile tested only. v2 - [olv] Update comments to include i965 in list of classic drivers. CC: Ian Romanick i

Re: [Mesa-dev] [PATCH 2/3] egl_dri2: check the surface type in platform_android

2011-08-30 Thread Chad Versace
)) return NULL; Either way, Reviewed-by: Chad Versace c...@chad-versace.us -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQIcBAEBAgAGBQJOXWfjAAoJEAIvNt057x8ikBUP/33hYl97ZxN/ftSLbPwzwqHW g28pshV4q2CUe5y8hWngKOjXq

Re: [Mesa-dev] [PATCH 3/3] egl_dri2: add pbuffer support to platform_android

2011-08-30 Thread Chad Versace
) that the last fixup is equivalent to: dri2_conf-base.SurfaceType = 0; If it is, then the code should just set SurfaceType = 0. Other than that, the patch looks good. Reviewed-by: Chad Versace c...@chad-versace.us } return (count != 0); -BEGIN PGP SIGNATURE- Version

Re: [Mesa-dev] [PATCH] egl_dri2: set ctx-WindowRenderBuffer

2011-08-30 Thread Chad Versace
eglQuerySurface(EGL_RENDER_BUFFER) will do the right thing. Reviewed-by: Chad Versace c...@chad-versace.us - -- Chad Versace c...@chad-versace.us -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

Re: [Mesa-dev] [PATCH 1/3] i965: fix Android build

2011-08-31 Thread Chad Versace
deletions(-) Thanks for fixing the mistakes in i965/Android.mk. I was unaware of TARGET_CC. I tested the i915 build, both with Android and Autoconf. So, for the series: Reviewed-by: Chad Versace c...@chad-versace.us -- Chad Versace c...@chad-versace.us

[Mesa-dev] [PATCH] mesa: Fix save/restore of ActiveProgram in meta-ops

2011-09-20 Thread Chad Versace
it to be: _meas_meta_begin: line 465) ActiveShader := gl_shader_state::ActiveProgram _mesa_meta_end: line 741) gl_shader_state::ActiveProgram := ActiveShader I discovered this bug by inspection. Signed-off-by: Chad Versace c...@chad-versace.us --- src/mesa/drivers/common/meta.c |2 +- 1

[Mesa-dev] [PATCH 00/19] i965: Do HiZ and depth resolves

2011-09-23 Thread Chad Versace
. Chad Versace (18): intel: Add HiZ operations to intel_context.vtbl i965: Initialize intel_context.vtbl after calling intelInitContext i965: Add stub functions for HiZ operations i965: Set HiZ operations in brw vtbl intel: Add HiZ control state to intel_region intel: Add 'mode' param

[Mesa-dev] [PATCH 01/19] intel: Add HiZ operations to intel_context.vtbl

2011-09-23 Thread Chad Versace
Add the following functions: resolve_depthbuffer resolve_hizbuffer Signed-off-by: Chad Versace c...@chad-versace.us --- src/mesa/drivers/dri/intel/intel_context.h | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/src/mesa/drivers/dri/intel

[Mesa-dev] [PATCH 02/19] i965: Initialize intel_context.vtbl after calling intelInitContext

2011-09-23 Thread Chad Versace
The intel_context.gen field is set by intelInitContext. So, by calling intelInitContext before initializing the vtable, we can can construct different vtables for different gens. Signed-off-by: Chad Versace c...@chad-versace.us --- src/mesa/drivers/dri/i965/brw_context.c |3 ++- 1 files

[Mesa-dev] [PATCH 03/19] i965: Add stub functions for HiZ operations

2011-09-23 Thread Chad Versace
Add stub functions for the following: brw_hiz_resolve_depthbuffer brw_hiz_resolve_hizbuffer These will later be used to implement: intel.vtbl.resolve_depthbuffer intel.vtbl.resolve_hizbuffer Signed-off-by: Chad Versace c...@chad-versace.us --- src/mesa/drivers/dri/i965

[Mesa-dev] [PATCH 04/19] i965: Set HiZ operations in brw vtbl

2011-09-23 Thread Chad Versace
If Gen = 6, then set the following: vtbl.resolve_depthbuffer vtbl.resolve_hizbuffer. Signed-off-by: Chad Versace c...@chad-versace.us --- src/mesa/drivers/dri/i965/brw_vtbl.c |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/src/mesa/drivers/dri/i965

[Mesa-dev] [PATCH 05/19] intel: Add HiZ control state to intel_region

2011-09-23 Thread Chad Versace
by intel_renderbuffer::region::hiz::region. Signed-off-by: Chad Versace c...@chad-versace.us --- src/mesa/drivers/dri/intel/intel_regions.c |2 ++ src/mesa/drivers/dri/intel/intel_regions.h | 21 + 2 files changed, 23 insertions(+), 0 deletions(-) diff --git a/src/mesa/drivers/dri

[Mesa-dev] [PATCH 06/19] intel: Add 'mode' param to intel_region_map

2011-09-23 Thread Chad Versace
-by: Chad Versace c...@chad-versace.us --- src/mesa/drivers/dri/intel/intel_mipmap_tree.c | 11 +++ src/mesa/drivers/dri/intel/intel_mipmap_tree.h |1 + src/mesa/drivers/dri/intel/intel_regions.c |6 -- src/mesa/drivers/dri/intel/intel_regions.h |8 ++-- src

[Mesa-dev] [PATCH 07/19] intel: Execute HiZ resolve ops in intel_region_map

2011-09-23 Thread Chad Versace
Signed-off-by: Chad Versace c...@chad-versace.us --- src/mesa/drivers/dri/intel/intel_regions.c | 16 1 files changed, 16 insertions(+), 0 deletions(-) diff --git a/src/mesa/drivers/dri/intel/intel_regions.c b/src/mesa/drivers/dri/intel/intel_regions.c index 0a5c2c1..304de8b

[Mesa-dev] [PATCH 09/19] intel: Move definition of intel_framebuffer_get_hiz_region from .h to .c

2011-09-23 Thread Chad Versace
This eliminates the need for intel_fbo.h to include intel_regions.h on the next commit. And this function was too large to be inline, anyway. Signed-off-by: Chad Versace c...@chad-versace.us --- src/mesa/drivers/dri/intel/intel_fbo.c | 12 src/mesa/drivers/dri/intel/intel_fbo.h

[Mesa-dev] [PATCH 10/19] intel: Add function intel_renderbuffer_hiz_alloc

2011-09-23 Thread Chad Versace
This function allocates the HiZ region and initializes the HiZ control state for a depthbuffer. It is wise to define the logic for HiZ region allocation in a single location, since when MSAA arrives that logic will become more complicated. Signed-off-by: Chad Versace c...@chad-versace.us

[Mesa-dev] [PATCH 11/19] intel: Remove intel_renderbuffer::hiz_region

2011-09-23 Thread Chad Versace
And replace it with intel_renderbuffer::region::hiz::region. Signed-off-by: Chad Versace c...@chad-versace.us --- src/mesa/drivers/dri/i965/brw_misc_state.c | 27 +++-- src/mesa/drivers/dri/intel/intel_context.c | 14 -- src/mesa/drivers/dri/intel/intel_fbo.c

[Mesa-dev] [PATCH 12/19] i965: Add HiZ operation state to brw_context

2011-09-23 Thread Chad Versace
struct brw_context::hiz contains state needed to perform HiZ meta-ops and indicates if a HiZ operation is currently in progress. Signed-off-by: Chad Versace c...@chad-versace.us --- src/mesa/drivers/dri/i965/brw_context.h | 35 +++ src/mesa/drivers/dri/i965

[Mesa-dev] [PATCH 13/19] i965: Complete stubs for HiZ operation meta-ops

2011-09-23 Thread Chad Versace
. Signed-off-by: Chad Versace c...@chad-versace.us --- src/mesa/drivers/dri/i965/brw_hiz.c | 266 ++- 1 files changed, 262 insertions(+), 4 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_hiz.c b/src/mesa/drivers/dri/i965/brw_hiz.c index 4e8baa0..8815a26

[Mesa-dev] [PATCH 14/19] i965/gen6: Don't set intel_context.reduced_primitive on Gen = 6

2011-09-23 Thread Chad Versace
Before this commit, brw_set_prim() used intel_context.reduced_primitive and BRW_NEW_REDUCED_PRIMITIVE regardless of generation. This was confusing, because those bits are not actually used on Gen = 6. Signed-off-by: Chad Versace c...@chad-versace.us --- src/mesa/drivers/dri/i965/brw_draw.c

[Mesa-dev] [PATCH 15/19] i965: Change type of brw_context.primitive from GLenum to hardware primitive

2011-09-23 Thread Chad Versace
For example, GL_TRIANLES is converted to _3DPRIM_TRILIST. The conversion is necessary because HiZ and MSAA resolve operations emit a 3DPRIM_RECTLIST, which cannot be conveyed by GLenum. As a consequence, brw_gs_prog_key.primitive is also converted. Signed-off-by: Chad Versace c...@chad

[Mesa-dev] [PATCH 16/19] i965: Manipulate state batches for HiZ operation meta-ops

2011-09-23 Thread Chad Versace
Signed-off-by: Chad Versace c...@chad-versace.us --- src/mesa/drivers/dri/i965/brw_draw.c |3 ++ src/mesa/drivers/dri/i965/gen6_clip_state.c | 17 +++ src/mesa/drivers/dri/i965/gen6_depthstencil.c | 22 +- src/mesa/drivers/dri/i965/gen6_sf_state.c

[Mesa-dev] [PATCH 17/19] i965: After emitting a HiZ buffer, mark that it needs a HiZ resolve

2011-09-23 Thread Chad Versace
Signed-off-by: Chad Versace c...@chad-versace.us --- src/mesa/drivers/dri/i965/brw_misc_state.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_misc_state.c b/src/mesa/drivers/dri/i965/brw_misc_state.c index 5adf2d7..1121f61 100644

[Mesa-dev] [PATCH 18/19] i965: Do needed HiZ meta-ops before drawing

2011-09-23 Thread Chad Versace
In brw_try_draw_prims(), perform a HiZ resolve on the attached depthbuffer and perform a depth resolve on each enabled depth texture, if needed. Signed-off-by: Chad Versace c...@chad-versace.us --- src/mesa/drivers/dri/i965/brw_draw.c | 43 ++ 1 files changed

[Mesa-dev] [PATCH 19/19] i965/gen7: Manipulate gen7 state batches for HiZ meta-ops

2011-09-23 Thread Chad Versace
From: Kenneth Graunke kenn...@whitecape.org Signed-off-by: Chad Versace c...@chad-versace.us Signed-off-by: Kenneth Graunke kenn...@whitecape.org --- src/mesa/drivers/dri/i965/gen7_clip_state.c | 17 ++ src/mesa/drivers/dri/i965/gen7_misc_state.c | 33

[Mesa-dev] [PATCH 11/19 v2] intel: Remove intel_renderbuffer::hiz_region

2011-09-23 Thread Chad Versace
And replace it with intel_renderbuffer::region::hiz::region. v2: In intel_process_dri2_buffer*(), don't call intel_get_renderbuffer() to get the depthbuffer. The variable 'rb' already points to it. Signed-off-by: Chad Versace c...@chad-versace.us --- src/mesa/drivers/dri/i965

[Mesa-dev] [PATCH] intel: Remove intel_renderbuffer::hiz_region

2011-09-23 Thread Chad Versace
. Signed-off-by: Chad Versace c...@chad-versace.us --- src/mesa/drivers/dri/i965/brw_misc_state.c | 27 +++-- src/mesa/drivers/dri/intel/intel_context.c | 10 +-- src/mesa/drivers/dri/intel/intel_fbo.c | 36 ++- src/mesa/drivers/dri/intel/intel_fbo.h

Re: [Mesa-dev] [PATCH 00/19] i965: Do HiZ and depth resolves

2011-09-26 Thread Chad Versace
. -- Chad Versace c...@chad-versace.us On 09/23/2011 05:37 PM, Chad Versace wrote: By default, HiZ is still disabled. This series causes no Piglit regressions when HiZ is disabled. When HiZ *is* enabled, it is now stable enough to run gnome-shell, nexuiz, and openarena without any artifacts

[Mesa-dev] [PATCH] mesa: Allow override of GL version with environment variables

2011-09-26 Thread Chad Versace
. CC: Paul Berry stereotype...@gmail.com Signed-off-by: Chad Versace c...@chad-versace.us --- src/mesa/main/version.c | 55 +- 1 files changed, 53 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/version.c b/src/mesa/main/version.c index 80fa0c2

[Mesa-dev] [PATCH v2] mesa: Allow override of GL version with environment variable

2011-09-26 Thread Chad Versace
MESA_GL_VERSION_OVERRIDE. v2 --- - [brianp] Change variable name to MESA_GL_VERSION_OVERRIDE. - [brianp] Document in envvars.html. - [idr, kwg] Remove overrides for GLES1 and GLES2. Reviewed-by: Brian Paul bri...@vmware.com Signed-off-by: Chad Versace c...@chad-versace.us --- docs/envvars.html

Re: [Mesa-dev] [PATCH v2] mesa: Allow override of GL version with environment variable

2011-09-27 Thread Chad Versace
On 09/26/2011 01:57 PM, Brian Paul wrote: On 09/26/2011 02:50 PM, Chad Versace wrote: [idr and kwg, I see your point. I've removed the overrides for GLES1 and GLES2.] It is necessary to manually set the GL version to 3.0 in order to run Piglit tests using glGetUniform*(). This patch allows

Re: [Mesa-dev] [PATCH 10/19] intel: Add function intel_renderbuffer_hiz_alloc

2011-09-27 Thread Chad Versace
to execute that op, given that the fundamental object we're tracking is the depthbuffer's (or texture's) region. So, with that in mind, I can't think of any other data we may need. -- Chad Versace c...@chad-versace.us ___ mesa-dev mailing list mesa-dev

Re: [Mesa-dev] [PATCH 15/19] i965: Change type of brw_context.primitive from GLenum to hardware primitive

2011-09-27 Thread Chad Versace
)) { +brw-intel.reduced_primitive = brw_get_reduced_prim(hw_prim); brw-state.dirty.brw |= BRW_NEW_REDUCED_PRIMITIVE; } } - - return prim_to_hw_prim[mode]; } -- Chad Versace c...@chad-versace.us ___ mesa-dev mailing list

Re: [Mesa-dev] [PATCH 16/19] i965: Manipulate state batches for HiZ operation meta-ops

2011-09-27 Thread Chad Versace
if the meta code just set up an empty fragment shader with its VS, none of the hiz.op checks here would be needed. I think that would be cleaner. I agree. I'll test that idea and, if it works, this commit can be deleted. -- Chad Versace c...@chad-versace.us

Re: [Mesa-dev] [PATCH 17/19] i965: After emitting a HiZ buffer, mark that it needs a HiZ resolve

2011-09-27 Thread Chad Versace
is enabled and the depthbuffer has hiz, then at the point of emitting a primitive we know that a depth resolve must be needed. -- Chad Versace c...@chad-versace.us ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman

Re: [Mesa-dev] [PATCH] glsl 1.30: Fix numerical instabilities in asinh

2011-09-27 Thread Chad Versace
is equivalent to the old. This isn't evident at first glance, and I first thought that the new was perhaps just a good, stable approximation of the old. Reviewed-by: Chad Versace c...@chad-versace.us -- Chad Versace c...@chad-versace.us ___ mesa-dev mailing

Re: [Mesa-dev] [PATCH v2] mesa: Allow override of GL version with environment variable

2011-09-27 Thread Chad Versace
On 09/27/2011 09:29 AM, Ian Romanick wrote: On 09/26/2011 01:50 PM, Chad Versace wrote: [idr and kwg, I see your point. I've removed the overrides for GLES1 and GLES2.] It is necessary to manually set the GL version to 3.0 in order to run Piglit tests using glGetUniform*(). This patch allows

Re: [Mesa-dev] [PATCH v2] mesa: Allow override of GL version with environment variable

2011-09-27 Thread Chad Versace
] Remove overrides for GLES1 and GLES2. Reviewed-by: Brian Paulbri...@vmware.com Signed-off-by: Chad Versacec...@chad-versace.us Don't suppose you want to make the GLSL version override more generic as well? Dave. Actually, I do. How about MESA_GLSL_VERSION_OVERIDE? -- Chad Versace c...@chad

[Mesa-dev] [PATCH 1/2] mesa: Allow overriding GLSL version with environment varirable

2011-09-27 Thread Chad Versace
. Since the former supercedes the latter, this patch disables the latter. CC: Dave Airlie airl...@gmail.com Signed-off-by: Chad Versace c...@chad-versace.us --- docs/envvars.html |4 src/mesa/drivers/dri/intel/intel_extensions.c |3 ++- src/mesa/drivers/dri

[Mesa-dev] [PATCH 2/2] intel: Remove unused function get_glsl_version()

2011-09-27 Thread Chad Versace
It was replaced by _mesa_override_glsl_version(). Signed-off-by: Chad Versace c...@chad-versace.us --- src/mesa/drivers/dri/intel/intel_extensions.c | 16 1 files changed, 0 insertions(+), 16 deletions(-) diff --git a/src/mesa/drivers/dri/intel/intel_extensions.c b/src/mesa

Re: [Mesa-dev] [PATCH 7/7] glsl: Add support for constant expression evaluation on round(), roundEven().

2011-09-27 Thread Chad Versace
than rint(). When `rint(n) != n`, rint() takes the extra trouble to set FE_INEXACT, but nearbyint() just does the rounding and nothing else. Either way, the code is correct. Reviewed-by: Chad Versace c...@chad-versace.us -- Chad Versace c...@chad-versace.us

Re: [Mesa-dev] [PATCH 1/7] ir_to_mesa: Don't assertion fail on remaining GLSL 1.30 ops.

2011-09-27 Thread Chad Versace
For pathes 1-6: Reviewed-by: Chad Versace c...@chad-versace.us I have a minor comment on patch 7. -- Chad Versace c...@chad-versace.us On 09/27/2011 03:08 PM, Eric Anholt wrote: For hardware drivers, we only have ir_to_mesa called for the purposes of potential swrast fallbacks (basically

Re: [Mesa-dev] [PATCH] mesa: Convert _mesa_generate_mipmap to MapTexImage()-based access.

2011-09-28 Thread Chad Versace
This patch fixes many Piglit tests [failing due to assert(region-map_refcount == 0)] on SNB when HiZ is enabled, and causes no regressions. Tested-by: Chad Versace c...@chad-versace.us On 09/27/2011 12:27 PM, Eric Anholt wrote: From: Brian Paulbri...@vmware.com Now that we can zero-copy

[Mesa-dev] [PATCH] mesa: Remove unused tnl items from dd_functions

2011-09-30 Thread Chad Versace
Remove NeedValidate and ValidateTnlModule. Signed-off-by: Chad Versace c...@chad-versace.us --- src/mesa/drivers/common/driverfuncs.c |2 -- src/mesa/main/dd.h| 19 --- 2 files changed, 0 insertions(+), 21 deletions(-) diff --git a/src/mesa/drivers

Re: [Mesa-dev] [PATCH] configure: replace pkg-config calls $(PKG_CONFIG) in the makefiles.

2011-10-03 Thread Chad Versace
? When I cross-compile or do other pkg-config hocus pocus, I invoke configure as ./configure ... PKG_CONFIG_PATH=/my-libdrm/pkgconfig - -- Chad Versace c...@chad-versace.us -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http

<    1   2   3   4   5   6   7   8   9   10   >