Re: [Mesa-dev] [PATCH] egl: deduplicate allocations of local buffer over each platform backend (v2)

Reviewed-by: Emil Velikov <emil.veli...@collabora.com> v2 looks good to me. Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> Thanks! > --- > src/egl/drivers/dri2/egl_dri2.c | 34 + > src/egl/drivers/dri2/egl_dri2.h | 14 ++--- &

Re: [Mesa-dev] [PATCH 1/2] etnaviv: fix etna_bo_from_name

On Friday, 2017-08-04 17:07:54 +0200, Philipp Zabel wrote: > Look up BOs from the name table using the name parameter instead of > req.handle (which at this point is always zero). > > Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> Reviewed-by: Eric Engestrom <eric

Re: [Mesa-dev] [PATCH kmscube] atomic: Use normal rendering loop for modeset

f("no eglDupNativeFenceFDANDROID\n"); > - return -1; > - } This hunk is still needed, isn't it? With this restored, the patch is: Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> > - > - eglSwapBuffers(egl->display, egl->surface); > - bo =

Re: [Mesa-dev] [PATCH] configure.ac: Fix help string for --disable-pwr8 configure option

On Wednesday, 2017-05-10 17:44:29 +0200, Philipp Zabel wrote: > Signed-off-by: Philipp Zabel > --- > configure.ac | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure.ac b/configure.ac > index df3eb6b29a..5c460f43d5 100644 > ---

Re: [Mesa-dev] [PATCH] configure: remove unneeded bits around libunwind handling

n drop it. > > Fixes: 3bcef6aa245 ("configure.ac: honour --disable-libunwind if the .pc file > is present") > Signed-off-by: Emil Velikov <emil.veli...@collabora.com> Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> > --- > configure.ac | 5 - >

Re: [Mesa-dev] [PATCH 3/3] egl: annotate dri2_egl_display_vtbl as const data

eli...@collabora.com> Nice! Series is: Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> > --- > src/egl/drivers/dri2/platform_android.c | 2 +- > src/egl/drivers/dri2/platform_drm.c | 2 +- > src/egl/drivers/dri2/platform_surfaceless.c | 2 +- > src/egl/driv

Re: [Mesa-dev] [PATCH v2 07/27] configure: error out when building GLX w/o the X11 platform

On Monday, 2017-05-15 15:41:44 +0100, Emil Velikov wrote: > On 8 May 2017 at 01:35, Eric Engestrom <e...@engestrom.ch> wrote: > > I don't seem to have received patches 12-27 of this series though? > > > Git send-email tripped on a malformed email in 12. The rest of the >

Re: [Mesa-dev] [PATCH mesa 0/2] egl: wire up swap_with_damage() and enable it on Android

On Monday, 2017-06-12 09:39:15 +0300, Tapani Pälli wrote: > Hi Eric; > > EGL_KHR_swap_buffers_with_damage is implemented by Android's EGL wrapper > library so these tests are passing already, no implementation required in > Mesa side. Right, I keep forgetting that android intercepts some stuff

Re: [Mesa-dev] [PATCH 1/2] RFC i965: Bypass a couple of libraries for syscall on x84_64

On Monday, 2017-06-19 12:22:07 -0700, Chad Versace wrote: > The other reason for removing all uses of drmIoctl() is, imo, it's > excessive to jump through the PLT into a shared object for a mere ioctl > wrapper. Agreed, but doesn't my suggestion of moving drmIoctl() to the drm header as either a

Re: [Mesa-dev] [PATCH 1/2] RFC i965: Bypass a couple of libraries for syscall on x84_64

On Monday, 2017-06-19 13:02:11 +0100, Chris Wilson wrote: > Quoting Emil Velikov (2017-06-19 12:43:42) > > Hi Chris, > > > > On 19 June 2017 at 12:32, Chris Wilson wrote: > > > On linux/x86_64, calling into the kernel is just a single instruction > > > with the

[Mesa-dev] [PATCH mesa] egl: simplify dri_config conditionals

and making it easier to read. Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- src/egl/drivers/dri2/egl_dri2.c | 25 ++--- src/egl/drivers/dri2/egl_dri2.h | 3 +-- 2 files changed, 11 insertions(+), 17 deletions(-) diff --git a/src/egl/drivers/dri2/egl_dri2.c b/s

[Mesa-dev] [RFC mesa] travis: add couple missing proto+lib

> configure: error: Package requirements (x11 xext xdamage >= 1.1 xfixes > x11-xcb xcb xcb-glx >= 1.8.1 xcb-dri2 >= 1.8) were not met: > No package 'xdamage' found > No package 'xfixes' found They each depend on their own *proto. Signed-off-by: Eric Engestrom <e...@engest

Re: [Mesa-dev] [PATCH 3/5] egl/android: Rename var in droid_add_configs_for_visuals()

On Friday, 2017-06-16 19:37:48 -0700, Chad Versace wrote: > Rename 'config' to 'config_count'. I didn't understand what the variable I think you mean "Rename 'count' to 'config_count'" :) Agreed with Emil about making the same change across all platforms (one of these days I'll dedup those,

[Mesa-dev] [PATCH mesa v2] egl: properly count configs

dri2_conf represents another config (which shouldn't be counted) if it doesn't have the requested ID. Reported-by: Liu Zhiquan <zhiquan@intel.com> Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- v2: use original `count+1` comparison. --- src/egl/drivers/dri2/platform_andro

Re: [Mesa-dev] [PATCH 5/5] egl/android: Change order of EGLConfig generation

on Android Nougat, this > was good enough to pacify the buggy clients. I had to double-check with the spec, but this is indeed allowed: > EGL_NATIVE_VISUAL_TYPE (the actual sort order is > implementation-defined, depending on the meaning of > native visual types). Ser

Re: [Mesa-dev] [PATCH 09/10] egl/drm: Declare EGLConfig attrib array inside loop

On 22 June 2017 19:10:55 BST, Chad Versace <chadvers...@chromium.org> wrote: > No behavioral change. Just a readability cleanup. > > Instead of modifying this small array on each loop iteration, we now > initialize it in-place with the values it needs. > > Cc: Eric Enge

Re: [Mesa-dev] [PATCH 08/10] egl/drm: Declare EGLConfig attrib array inside loop

On 22 June 2017 19:10:54 BST, Chad Versace <chadvers...@chromium.org> wrote: > No behavioral change. Just a readability cleanup. > > Instead of modifying this small array on each loop iteration, we now > initialize it in-place with the values it needs. > > Cc: Eric Enge

Re: [Mesa-dev] [PATCH 00/10] egl: Little cleanups

drm: Declare EGLConfig attrib array inside loop With the two comments on the above two patches addressed, the series is: Reviewed-by: Eric Engestrom <e...@engestrom.ch> > egl: Rename 'count' in ${platform}_add_configs_for_visuals (v2) > > src/egl/drivers/dri2/egl_dri2.c

Re: [Mesa-dev] [RFC mesa] travis: add couple missing proto+lib

On Thursday, 2017-06-22 16:47:29 +0100, Emil Velikov wrote: > On 22 June 2017 at 00:29, Eric Engestrom <e...@engestrom.ch> wrote: > >> configure: error: Package requirements (x11 xext xdamage >= 1.1 xfixes > >> x11-xcb xcb xcb-glx >= 1.8.1 xcb-dri2 >= 1.8) we

Re: [Mesa-dev] [PATCH] swr/rast: adjust std::string usage to fix build

ds/247116248 Tested-by: Eric Engestrom <eric.engest...@imgtec.com> Thanks! > --- > .../drivers/swr/rasterizer/codegen/templates/gen_knobs.cpp | 12 > +--- > 1 file changed, 9 insertions(+), 3 deletions(-) > > diff --git > a/src/gallium/drivers/swr/rasteriz

[Mesa-dev] [PATCH mesa 2/2] anv: use Mesa's u_atomic.h header

Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- src/intel/vulkan/anv_private.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/intel/vulkan/anv_private.h b/src/intel/vulkan/anv_private.h index e5d88f2815..8079378ae6 100644 --- a/src/intel/

[Mesa-dev] [PATCH mesa 1/2] radv: use Mesa's u_atomic.h header

Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- src/amd/vulkan/radv_pipeline.c | 3 ++- src/amd/vulkan/radv_pipeline_cache.c | 7 --- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c

Re: [Mesa-dev] [PATCH] intel/anv: Add missing break in anv_CreateDevice()

On Monday, 2017-06-26 21:07:12 +0300, Topi Pohjolainen wrote: > CID: 1413018 > Signed-off-by: Topi Pohjolainen <topi.pohjolai...@intel.com> Both patches are Reviewed-by: Eric Engestrom <e...@engestrom.ch> > --- > src/intel/vulkan/anv_device.c | 1 + > 1 file change

Re: [Mesa-dev] [PATCH mesa] mesa/format_info: use designated initialiser list

On Tuesday, 2017-06-20 08:24:42 -0600, Brian Paul wrote: > On 06/19/2017 03:39 PM, Ian Romanick wrote: > > On 06/19/2017 04:01 AM, Eric Engestrom wrote: > > > Also, make that table const, since no-one is supposed to modify it anyway. > > > > I certainly like thi

Re: [Mesa-dev] [PATCH 1/2] egl: drop _eglInitImage() return type

On Tuesday, 2017-06-20 16:04:47 +0100, Emil Velikov wrote: > From: Emil Velikov <emil.veli...@collabora.com> > > Function cannot fail and always returns true. > > Signed-off-by: Emil Velikov <emil.veli...@collabora.com> Both patches are: Reviewed-by: Eric Engestrom

Re: [Mesa-dev] [PATCH 1/2] RFC i965: Bypass a couple of libraries for syscall on x84_64

On Monday, 2017-06-19 09:41:13 -0700, Jason Ekstrand wrote: > On Mon, Jun 19, 2017 at 7:43 AM, Chris Wilson > wrote: > > > > Just a cosmetic improvement, but quite straightforward. > > I think it's a bit hard to call replacing a standard library function with > inline

Re: [Mesa-dev] [PATCH 1/2] RFC i965: Bypass a couple of libraries for syscall on x84_64

On 20 June 2017 18:22:32 BST, Chad Versace <chadvers...@chromium.org> wrote: >On Tue 20 Jun 2017, Eric Engestrom wrote: >> On Tuesday, 2017-06-20 09:56:25 -0700, Chad Versace wrote: >> > On Tue 20 Jun 2017, Dave Airlie wrote: >> > >> > > I'm n

Re: [Mesa-dev] [PATCH 1/2] RFC i965: Bypass a couple of libraries for syscall on x84_64

On Tuesday, 2017-06-20 09:56:25 -0700, Chad Versace wrote: > On Tue 20 Jun 2017, Dave Airlie wrote: > > > I'm not sure why avoiding drmIoctl is even a thing, there are plenty > > of huge optimisation opportunities, this just seems like a feel good > > pointless microptimisation. > > There is

Re: [Mesa-dev] [PATCH mesa] mesa/format_info: use designated initialiser list

On Tuesday, 2017-06-20 09:47:30 -0700, Ian Romanick wrote: > On 06/20/2017 07:24 AM, Brian Paul wrote: > > On 06/19/2017 03:39 PM, Ian Romanick wrote: > >> On 06/19/2017 04:01 AM, Eric Engestrom wrote: > >>> Also, make that table const, since no-one is supp

[Mesa-dev] [PATCH mesa] amd/common: add missing libdrm include path

Fixes: de9dd4f9f1bb5984c554 ("ac/radeonsi: move struct radeon_info to ac_gpu_info.h") Cc: Nicolai Hähnle <nicolai.haeh...@amd.com> Cc: Marek Olšák <marek.ol...@amd.com> Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- src/amd/Makefile.common.am | 1 +

Re: [Mesa-dev] [PATCH 4/5] ac: remove amdgpu.h dependency

On Friday, 2017-05-26 16:32:52 +0100, Emil Velikov wrote: > From: Emil Velikov > > Add a couple of forward declarations and drop the amdgpu.h requirement. > > With this we can build the r300 and r600 drivers without the need for > amdgpu. > > Cc: Nicolai Hähnle

Re: [Mesa-dev] [PATCH] docs: small release calendar fixes

Good catch! Reviewed-by: Eric Engestrom <e...@engestrom.ch> On 25 May 2017 10:26:18 BST, Andres Gomez <ago...@igalia.com> wrote: >Signed-off-by: Andres Gomez <ago...@igalia.com> >--- > docs/release-calendar.html | 2 +- > docs/releasing.html| 2 +- > 2

[Mesa-dev] [PATCH mesa] configure.ac: fix the check

Signed-off-by: Adam Jackson <a...@redhat.com> Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- This is a port of ajax's 7040fea02 on libdrm. Honestly, I haven't seen this wall of warnings in Mesa yet, but I suspect this is just by some random "happy accident", so I t

Re: [Mesa-dev] [PATCH v14 07/36] egl: advertise EGL_EXT_image_dma_buf_import_modifiers

Since they haven't been altered for the last 9-12 revisions, and in order to reduce the load of patches to rebase and carry, I just landed the EGL side (patches 1-7), with my r-b added on the couple patches I hadn't reviewed. Cheers, Eric On Tuesday, 2017-05-30 17:23:40 +0530, Varad Gautam

[Mesa-dev] [PATCH mesa] egl/drm: remove temporary fd variable

e use of the dri2_display_destroy() helper") Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- src/egl/drivers/dri2/platform_drm.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/src/egl/drivers/dri2/platform_drm.c b/src/

Re: [Mesa-dev] [PATCH 6/7] nir: Port to u_dynarray and delete nir_array

*)nir_array_grow(arr, sizeof(type)) = (elem) > - > -#define nir_array_foreach(arr, type, elem) \ > - for (type *elem = (type *)(arr)->data; \ > -elem < (type *)((char *)(arr)->data + (arr)->size); elem++) > - > -#ifdef __cplusplus > -} /* extern "

Re: [Mesa-dev] [PATCH 3/7] util: Remove unused includes and convert to lower-case memory ops

On Saturday, 2017-06-03 20:11:38 +0200, Thomas Helland wrote: > Also, prepare for the next commit by correcting some coding style > changes. This should be all non-functional changes. > --- > src/util/u_dynarray.h | 27 --- > 1 file changed, 12 insertions(+), 15

Re: [Mesa-dev] [PATCH] Revert "egl/display: remove unnecessary code and make it easier to read"

M, it should not cause problems in practice. > > Cc: Eric Engestrom <eric.engest...@imgtec.com> > Fixes: 7adb9b0948 "egl/display: remove unnecessary code and make it easier to > read" > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101252 > Signed

[Mesa-dev] [PATCH mesa 2/2] egl/display: make platform detection thread-safe

has updated it since. This means the platform detected in the thread might not be the platform returned by the function, but this is a different issue that will need to be discussed when this becomes possible. Reported-by: Grazvydas Ignotas <nota...@gmail.com> Signed-off-by: Eric Eng

[Mesa-dev] [PATCH mesa 1/2] egl/display: only detect the platform once

Fixes: 7adb9b094894a512c019 ("egl/display: remove unnecessary code and make it easier to read") Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- src/egl/main/egldisplay.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) dif

Re: [Mesa-dev] [PATCH v4] egl/android: support for EGL_KHR_partial_update

ut the return values of the perform method. Window.h > documents only -ENOENT. Sure, I will make this change. > I will send the patch immediately after the fix for buffer age is merged. > Indeed, the only documented [1] return value is -ENOENT: > returns -ENOENT if [native_window_set_surfa

Re: [Mesa-dev] [PATCH] egl: fix _eglQuerySurface in EGL_BUFFER_AGE_EXT case

uery_buffer_age"); > - return 0; > + return -1; > } > > - return dri2_surf->back->age; > + return dri2_surf->back ? dri2_surf->back->age : 0; Nit: this could be a separate commit. Regardless, as one or two commits it all gets: Reviewed-by:

Re: [Mesa-dev] [PATCH v3] egl/android: support for EGL_KHR_partial_update

On Monday, 2017-06-05 19:37:55 +0530, Harish Krupo wrote: > This patch adds support for the EGL_KHR_partial_update extension for > android platform. It passes 36/37 tests in dEQP for EGL_KHR_partial_update. > 1 test not supported. > > v2: add fallback for eglSetDamageRegionKHR (Tapani) > > v3:

Re: [Mesa-dev] [PATCH v3] egl/android: support for EGL_KHR_partial_update

On Monday, 2017-06-05 17:04:28 +0100, Emil Velikov wrote: > > + * If the width of the passed rect is greater than the surface's > > + * width then it is clamped to the width of the surface. Same with > > + * height. > > + */ > > + > > +static void > > +_eglSetDamageRegionKHRClampRects(_EGLDisplay*

Re: [Mesa-dev] [PATCH v5] egl/android: support for EGL_KHR_partial_update

diately when n_rects is 0. Place function's entrypoint > in alphabetical order. (Eric Engestrom) > > v5: Replace unnecessary calloc with malloc (Eric) > Check for BAD_ALLOC error (Emil) > Check for error in native_window_set_damage_region. (Emil, Tapani, > Eric).

Re: [Mesa-dev] [PATCH] automake: increase the MESA_GIT_SHA1 hash id length from 7 to 10 digits

On Thursday, 2017-06-15 09:56:55 +0100, Emil Velikov wrote: > Hi Brian, > > On 15 June 2017 at 04:46, Brian Paul wrote: > > The SCons build has been using 10 digits of the git hash id for the > > MESA_GIT_SHA1 string in git_sha1.h for about a year now. I bumped it > > up

Re: [Mesa-dev] [PATCH] automake: increase the MESA_GIT_SHA1 hash id length from 7 to 10 digits

it --git-dir=$(top_srcdir)/.git log -n 1 --oneline | \ > - sed 's/^\([^ ]*\) .*/#define MESA_GIT_SHA1 "git-\1"/' \ > - > git_sha1.h.tmp ; \ > + git --git-dir=$(top_srcdir)/.git rev-parse --short=10 HEAD > | \ > +

Re: [Mesa-dev] [PATCH mesa 2/2] egl/display: make platform detection thread-safe

On Thursday, 2017-06-15 14:24:55 +0300, Grazvydas Ignotas wrote: > On Thu, Jun 1, 2017 at 2:15 PM, Eric Engestrom > <eric.engest...@imgtec.com> wrote: > > If the detections methods ever become able to return different results > > for different threads, the if chain mi

Re: [Mesa-dev] [PATCH] automake: increase the MESA_GIT_SHA1 hash id length from 7 to 10 digits

On Thursday, 2017-06-15 06:54:18 -0600, Brian Paul wrote: > On 06/15/2017 03:38 AM, Emil Velikov wrote: > > On 15 June 2017 at 10:12, Eric Engestrom <eric.engest...@imgtec.com> wrote: > > > On Thursday, 2017-06-15 09:56:55 +0100, Emil Velikov wrote: > > > > H

Re: [Mesa-dev] [PATCH] automake: increase the MESA_GIT_SHA1 hash id length from 7 to 10 digits

gt; branches). > > Instead of using "git log -n 1 --oneline" use > "git rev-parse --short=10 HEAD" to get the HEAD hash id. > > v2: use printf instead of sed, per Eric's suggestion. And good use of the backtick, instead of $(shell), to be compatible with no

Re: [Mesa-dev] egl/android: fence_fd being forced to -1

On Thursday, 2017-06-15 13:27:06 +, Marathe, Yogesh wrote: > Hello, > > I'm tyring to run flatland native app on android. It apparantly fails because > of a fence issue. > while debuging further it is observed that droid_window_enqueue_buffer() is > forcing > fence_fd =-1. I assume

Re: [Mesa-dev] [PATCH 05/11] gbm: Pull out FourCC <-> DRIimage format table

ith: X(GBM_FORMAT_..., __DRI_IMAGE_FORMAT_...) and in these two functions have a switch with: #define X(gbm, dri) case gbm: return dri; and #define X(gbm, dri) case dri: return gbm; It's a small list, so it doesn't really matter, and anyway it might as well be a follow-up

Re: [Mesa-dev] [PATCH 07/11] gbm: Remove is_planar_format dead code

On Friday, 2017-06-16 18:14:30 +0100, Daniel Stone wrote: > This was only used in create_dumb() to blacklist planar formats. > However, the start of the function already whitelists ARGB (cursor) > and XRGB (scanout), and nothing else. So this entire function can be > removed. > >

Re: [Mesa-dev] [PATCH 1/4] configure.ac: add -pthread to PTHREAD_LIBS

c: mesa-sta...@lists.freedesktop.org > Signed-off-by: Emil Velikov <emil.veli...@collabora.com> Series is: Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> I think you should push 1+3+4, 2 can wait for the various confirmations you requested. > --- > configure.ac | 5

[Mesa-dev] [PATCH mesa 2/2] egl/android: enable EGL_EXT_swap_buffers_with_damage

Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- src/egl/drivers/dri2/platform_android.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/egl/drivers/dri2/platform_android.c b/src/egl/drivers/dri2/platform_android.c index 7a73419d14..629ee593d0 100644 --- a/src/egl/driver

[Mesa-dev] [PATCH mesa 1/2] egl: improve dri2_fallback_swap_buffers_with_damage()

Let's (try to) set damages before swapping buffers. Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- src/egl/drivers/dri2/egl_dri2_fallbacks.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/egl/drivers/dri2/egl_dri2_fallbacks.h b/src/egl/drivers/dri2/egl_dri2_fallbacks.h

[Mesa-dev] [PATCH mesa 0/2] egl: wire up swap_with_damage() and enable it on Android

This is completely untested, as I don't have access to an Android test device, which is the only platform that can benefit from this improvement so far. Can someone run dEQP-EGL.functional.swap_buffers_with_damage.* on Android for me? Cheers, Eric --- Eric Engestrom (2): egl: improve

Re: [Mesa-dev] [RFC 01/22] RFC: egl/x11: Support DRI3 v1.1

ttrib; > + } > + ret = draw->ext->image->queryImage(image, __DRI_IMAGE_ATTRIB_STRIDE, > + >strides[i]); > + if (!ret) { > + if (image != pixmap_buffer) > +draw->ext->image->destroyImage

[Mesa-dev] [PATCH mesa v2 2/2] egl/display: make platform detection thread-safe

ed when this becomes possible. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101252 Signed-off-by: Eric Engestrom <e...@engestrom.ch> Reviewed-by: Grazvydas Ignotas <nota...@gmail.com> Ack-by: Emil Velikov <emil.l.veli...@gmail.com> --- src/egl/main/egldisplay.c | 19 +

[Mesa-dev] [PATCH mesa v2 1/2] egl/display: only detect the platform once

: 7adb9b094894a512c019 ("egl/display: remove unnecessary code and make it easier to read") Signed-off-by: Eric Engestrom <e...@engestrom.ch> Reviewed-by: Grazvydas Ignotas <nota...@gmail.com> Ack-by: Emil Velikov <emil.l.veli...@gmail.com> --- sr

[Mesa-dev] [PATCH mesa] egl: properly count configs

dri2_conf represents a similar config (which shouldn't be counted) if its config has the ID EGL_DONT_CARE. Reported-by: Liu Zhiquan <zhiquan@intel.com> Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- Re-implemented Liu Zhiquan's fix, without all the unnecessary changes,

Re: [Mesa-dev] egl/android: fence_fd being forced to -1

t; > wrote: > > > > On 06/15/2017 06:52 PM, Rob Clark wrote: > > > > On Thu, Jun 15, 2017 at 9:59 AM, Eric Engestrom > > <eric.engest...@imgtec.com> wrote: > > > > On Thursday, 2017-06-15 13:27:06 +, Marathe, Yogesh wrote: > > > &g

Re: [Mesa-dev] [PATCH v1 1/7] egl/android: Fix typ-o

On Thursday, 2017-06-15 16:47:53 -0400, Robert Foss wrote: > Signed-off-by: Robert Foss Trivial, so r-b and pushed immediately :) > --- > src/egl/drivers/dri2/platform_android.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [Mesa-dev] [PATCH mesa v2 1/2] egl/display: only detect the platform once

On Friday, 2017-06-16 12:10:55 +0300, Grazvydas Ignotas wrote: > On Fri, Jun 16, 2017 at 1:53 AM, Eric Engestrom <e...@engestrom.ch> wrote: > > My refactor missed the fact that `native_platform` is static. > > Add the proper guard around the detection code, as it might

[Mesa-dev] [PATCH mesa 1/2] egl: turn boolean `int`s into `bool`s

Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- src/egl/drivers/dri2/egl_dri2.c | 2 +- src/egl/drivers/dri2/egl_dri2.h | 17 + src/egl/drivers/dri2/platform_drm.c | 6 +++--- src/egl/drivers/dri2/platform_wayland.c | 20 ++-- s

[Mesa-dev] [PATCH mesa 2/2] egl: turn one more boolean `int` into a `bool`

Same as the previous commit, but this one was split out because it's a bit more complicated: this field is given as a pointer to a function, so the function had to be changed as well, and the function was use in a bunch of places, which needed updating as well. Signed-off-by: Eric Engestrom &l

[Mesa-dev] [PATCH mesa] mesa/format_info: use designated initialiser list

Also, make that table const, since no-one is supposed to modify it anyway. Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- I was grepping for a field to see where it was being set, and I couldn't find it because it was using positional struct initialisation. Ended up f

[Mesa-dev] [PATCH mesa] Fix khrplatform.h not installed if EGL is disabled.

From: Eric Le Bihan KHR/khrplatform.h is required by the EGL, GLES and VG headers, but is only installed if Mesa3d is compiled with EGL support. This patch installs this header file unconditionally. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=77240

Re: [Mesa-dev] [PATCH] util/rand_xor: add missing include statements

On Tuesday, 2017-06-13 20:01:07 +0200, Nicolas Dechesne wrote: > On Thu, Jun 1, 2017 at 4:53 PM, Emil Velikov wrote: > > Should be handled now. See the documentation for future stable nominations > > [1]. > > Actually, I don't see the patch in 17.1.2, was it expected?

Re: [Mesa-dev] [PATCH] nir: make various getters take const pointers

wed-by: Eric Engestrom <eric.engest...@imgtec.com> > > On Wed, Jun 7, 2017 at 2:25 AM, Grazvydas Ignotas <nota...@gmail.com> wrote: > > This will allow to constify other things. > > > > Signed-off-by: Grazvydas Ignotas <nota...@gmail.com> >

Re: [Mesa-dev] [PATCH v2 07/27] configure: error out when building GLX w/o the X11 platform

+++ b/configure.ac > @@ -1724,6 +1724,12 @@ for plat in $platforms; do > esac > done > > +if test "x$enable_glx" != xno; then > +if ! echo "$platforms" | grep -q 'x11'; then > +AC_MSG_ERROR([Building without the x11 platform as GLX is

Re: [Mesa-dev] [PATCH] docs: remove released versions from the calendar

On Thursday, 2017-05-04 17:37:56 +0100, Emil Velikov wrote: > From: Emil Velikov <emil.veli...@collabora.com> > > Signed-off-by: Emil Velikov <emil.veli...@collabora.com> Reviewed-by: Eric Engestrom <e...@engestrom.ch> I guess updating the release calendar cou

[Mesa-dev] [PATCH mesa] egl: avoid dereferencing a null display

Fixes: ddb99127a6f6c ("egl/x11: Honor the EGL_PLATFORM_X11_SCREEN_EXT attribute") Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- src/egl/main/egldisplay.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/egl/main/egldisplay.c b/src/egl/main/eg

Re: [Mesa-dev] [PATCH] egl: Fix -Wint-to-pointer-cast

= (void *)value; > > The fix: cast to uinptr_t before void*. > ^ > Fixes: ddb99127 egl/x11: Honor the EGL_PLATFORM_X11_SCREEN_EXT attribute > Cc: Adam Jackson <a...@redhat.com> Reviewed-by: Eric Engestrom <e...@engestrom.ch> > --- > sr

Re: [Mesa-dev] [PATCH 2/2] docs: extend until the end of August

On Saturday, 2017-05-06 18:46:13 +0300, Andres Gomez wrote: > Completed the 17.1 cycle and added the beginning of the 17.2 one. > > Cc: Emil Velikov <emil.veli...@collabora.com> > Cc: Juan A. Suarez Romero <jasua...@igalia.com> > Signed-off-by: Andres Gomez <ago...@

Re: [Mesa-dev] [PATCH] bin/get-fixes-pick-list.sh: don't warn if more than one, go over them

Replace newlines that are not followed by `Fixes:` with a space, before splitting and parsing each line? I guess this is better than what we currently have, and it won't fail more than it would before, so it's good enough for now; Reviewed-by: Eric Engestrom <e...@engestrom.ch> > +

Re: [Mesa-dev] [PATCH 1/3] mapi: replace mapi_table abstraction

gone, there' no point in having the current confusing > mix of the two. > > Signed-off-by: Emil Velikov <emil.veli...@collabora.com> Patches #1 and #3 are Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> > --- > src/mapi/entry.c | 2 +- > src/mapi/g

Re: [Mesa-dev] [PATCH] c11/threads: rework Windows thrd_current() comment

gt; + * to pass to DuplicateHandle. Only the resulting handle can be used > + * from other threads. > + * > + * Note that neither handle can be compared to the one by thread_create. > + * Only the thread IDs - as returned by GetThreadId and > GetCurrentThreadId nit: `GetThreadId

Re: [Mesa-dev] [PATCH 6/7] egl: drop unneeded sentinel from level_strings[]

On 4 May 2017 22:26:28 BST, Bartosz Tomczyk <bartosz.tomczy...@gmail.com> wrote: >It should be: > >i < ARRAY_SIZE(level_strings) > Indeed :) With this, the series is Reviewed-by: Eric Engestrom <e...@engestrom.ch> Cheers, Eric > >On 04.05.2017 20:47,

Re: [Mesa-dev] [PATCH] docs/releasing: don't forget to update the calendar

On 8 May 2017 16:06:08 BST, Emil Velikov <emil.l.veli...@gmail.com> wrote: >From: Emil Velikov <emil.veli...@collabora.com> > >Cc: Eric Engestrom <e...@engestrom.ch> >Suggested-by: Eric Engestrom <e...@engestrom.ch> >Signed-off-by: Emil Velikov <emil

Re: [Mesa-dev] [PATCH kmscube 1/2] helper to check for egl entrypoints

expose eglCreateImageKHR > but not eglDeleteImageKHR.. but otoh kmscube is useful for bringing > up drivers. Agreed. Both are Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> > > common.h | 11 +++ > cube-tex.c| 6 +++--- > cube-video.c | 4 +---

Re: [Mesa-dev] [PATCH 1/4] common: Check for extensions before resolving symbols

e nit picks below, but this patch is: Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> > --- > common.c | 63 +++ > 1 file changed, 51 insertions(+), 12 deletions(-) > > diff --git a/common.c b/common.c > index

[Mesa-dev] [PATCH mesa] configure.ac: simplify --enable-libunwind=auto check

Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- configure.ac | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/configure.ac b/configure.ac index b57be07e24..5caf316089 100644 --- a/configure.ac +++ b/configure.ac @@ -1066,16 +1066,12 @@ AC

Re: [Mesa-dev] [PATCH] util/rand_xor: add missing include statements

On Thursday, 2017-06-01 12:13:18 +0200, Nicolas Dechesne wrote: > Fixes for: > > src/util/rand_xor.c:60:13: error: implicit declaration of function 'open' > [-Werror=implicit-function-declaration] > int fd = open("/dev/urandom", O_RDONLY); > ^~~~ > src/util/rand_xor.c:60:34:

[Mesa-dev] [PATCH mesa] tree-wide: remove trailing backslash

Simple search for a backslash followed by two newlines. If one of the newlines were to be removed, this would cause issues, so let's just remove these trailing backslashes. Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- I can split the patch by module if you want, but this

Re: [Mesa-dev] [PATCH] util/rand_xor: add missing include statements

On Thursday, 2017-06-01 16:15:41 +0200, Nicolas Dechesne wrote: > On Thu, Jun 1, 2017 at 3:27 PM, Eric Engestrom > <eric.engest...@imgtec.com> wrote: > > On Thursday, 2017-06-01 12:13:18 +0200, Nicolas Dechesne wrote: > >> Fixes for: > >> > >> src/util/

Re: [Mesa-dev] [PATCH 2/3] radv/vulkan: Move radv_get_driver_version to src/vulkan/util

(patch_string + 1) : 0; > + if (strstr(VERSION, "devel")) { > + if (patch == 0) { > + patch = 99; > + if (minor == 0) { > +minor = 99; > +--major; > + } else > +--minor; > + } else > + --

Re: [Mesa-dev] [PATCH] mesa: wrap blit_framebuffer() into blit_framebuffer_err()

On Tuesday, 2017-06-06 14:40:28 +0200, Samuel Pitoiset wrote: > Also add ALWAYS_INLINE to blit_framebuffer(). > > Signed-off-by: Samuel Pitoiset > --- > > NOTE: Patch introduced between 9 and 10 in this series. Nothing changed > except some rebase conflicts. > >

Re: [Mesa-dev] [PATCH 1/7] egl/dri2: Avoid sign extension when building modifier

lue << 32; > + modifier |= (uint64_t) (attrs.DMABufPlaneModifiersLo[0].Value & > 0xffff); To be clear, the fix is to cast Lo before OR'ing it, right? The rest is just aesthetic? Reviewed-by: Eric Engestrom <eric.engest...@

[Mesa-dev] [PATCH mesa] build systems: uniformize git_sha1.h generation

Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- Note: Autotools and SCons are tested, but Android isn't. --- git_sha1_gen.sh | 13 + src/Makefile.am | 13 + src/SConscript

[Mesa-dev] [PATCH mesa] mesa: add missing include

fer); ^~~ Cc: Marek Olšák <marek.ol...@amd.com> Fixes: 585c5cf8a514783d9ed3 ("mesa: don't update draw buffer bounds in _mesa_update_state") Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- src/mesa/drivers/x11/xm_dd.c | 1 + 1 file chan

Re: [Mesa-dev] [PATCH] scons: add code to generate format_fallback.c file

On Tuesday, 2017-06-27 20:58:48 -0600, Brian Paul wrote: > Fixes broken SCons build since a1983223d8839a0c9 Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> Btw, the format "Fixes: $sha1 [optional commit title]" allows scripts to parse it and eg. apply to relev

Re: [Mesa-dev] [PATCH mesa] swr: use ARRAY_SIZE macro

nowing about this one :) > > Reviewed-by: Bruce Cherniak <bruce.chern...@intel.com> Thanks, pushed now. > > > On Sep 12, 2017, at 8:03 AM, Eric Engestrom <eric.engest...@imgtec.com> > > wrote: > > > > Signed-off-by: Eric Engestrom <eric.eng

Re: [Mesa-dev] [PATCH 2/3] glsl: check if induction var incremented before use in terminator

On Thursday, 2017-09-14 14:47:49 +1000, Timothy Arceri wrote: > do-while loops can increment the starting value before the > condition is checked. e.g. > > do { > ndx++; > } while (ndx < 3); > > This commit changes the code to detect this and reduces the > iteration count by 1 if found.

Re: [Mesa-dev] [PATCH mesa] glsl: compile unused function out

On Wednesday, 2017-09-13 17:24:57 +0200, Nicolai Hähnle wrote: > On 12.09.2017 17:01, Eric Engestrom wrote: > > The function is only called from one place, which is hidden behind > > the same `#ifdef DEBUG`. > > > > Fixes: ca73c3358c91434e68ab "glsl: Mark functions

Re: [Mesa-dev] [PATCH 2/3] egl: Wrap dri3 surface primitive around dri2 egl surface

On Friday, 2017-09-15 12:06:57 +0530, yogesh.mara...@intel.com wrote: > From: Yogesh Marathe > > Originally dri3 egl surface was wrapped around _EGLSurface. To support > explicit sync, new variables (e.g. enable_out_fence) were added to > dri2_egl_surface. As we

Re: [Mesa-dev] [PATCH v2 0/2] Add libunwind to travis gallium build and fix it

appropriately. Thanks, series looks good to me: Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> Emil, I'll let you push it. > > Best, > Gert > > Gert Wollny (2): > .travis.yml: force llvm-3.3 for "make Gallium ST Other" > .travis.yml: Add

Re: [Mesa-dev] [PATCH] swr/rast: Fix GetEnv() returned value

gs.freedesktop.org/show_bug.cgi?id=101832 Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101832 Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> I could've sworn I had already seen this patch on the ML though? > Fixes: a25093de718 ("swr/rast: Implement JIT shader cachin

Re: [Mesa-dev] [PATCH] swr/rast: do not crash on NULL strings returned by getenv

tel.com> > Cc: Laurent Carlier <lordhea...@gmail.com> > Cc: Bernhard Rosenkraenzer <b...@lindev.ch> > [Emil Velikov: make an actual commit from the misc diff] > Signed-off-by: Emil Velikov <emil.veli...@collabora.com> Laurent just sent this to the ML an hour before y

Re: [Mesa-dev] [PATCH v2 3/7] travis: Add clover build using llvm-3.7

avis does not allow > llvm-toolchain-trusty-3.7 You can drop this line now :) Don't 4.0 and 5.0 need the same binutils-2.26 as 3.9? Speaking of, I think the OVERRIDE_PATH you added is the only way to do this. With the above fixed or justified, the series is: Reviewed-by: Eric Engestrom

<    1   2   3   4   5   6   7   8   9   10   >