Re: [Mesa-dev] Applying fixes to stable branches

2021-01-07 Thread Andres Gomez
On Wed, 2021-01-06 at 19:19 -0500, Marek Olšák wrote: > Hi, > > How do you apply the fixes? The way it is done during the release process is semi-automated with the help of some scripts. > Is it possible to pick a random commit in master and apply all fixes that are > newer than that commit?

[Mesa-dev] nir/compiler: keep same bit size when lowering with flrp

2019-07-10 Thread Andres Gomez
This was probably not caught before because no supported test was exercising the flrp lowering with other bit size different than 32. With the arrival of VK_KHR_shader_float_controls we will have some of those and, unless we keep the bit size, we will end with something like:

[Mesa-dev] [MR] Revert "egl: Add a 565 pbuffer-only EGL config under X11."

2019-05-28 Thread Andres Gomez
This reverts commit dacb11a5. The reason for introducing this change was to fulfill CTS's requirement to be able to run a 565-no-depth-no-stencil config for ES 3.0 on X11. Unfortunately, enabling this causes other problems. The most relevant one is that, for i965, CTS was passing for GL 4.5 and

Re: [Mesa-dev] [PATCH v3 6/6] glsl/linker: check for xfb_offset aliasing

2019-04-23 Thread Andres Gomez
failing for us. > > > See below for one addition: > > On 4/22/19 3:00 AM, Andres Gomez wrote: > > From page 76 (page 80 of the PDF) of the GLSL 4.60 v.5 spec: > > > >" No aliasing in output buffers is allowed: It is a compile-time or > > lin

[Mesa-dev] [PATCH v3 6/6] glsl/linker: check for xfb_offset aliasing

2019-04-21 Thread Andres Gomez
ct and make it local to the validation process (Timothy). - Do not use a nested scope for the validation (Timothy). Cc: Timothy Arceri Cc: Ilia Mirkin Signed-off-by: Andres Gomez --- src/compiler/glsl/link_varyings.cpp | 109 src/compiler/glsl/link_varyings.h | 6

Re: [Mesa-dev] [PATCH v4 1/6] glsl/linker: location aliasing requires types to have the same width

2019-04-11 Thread Andres Gomez
not that important so it could also be dropped. Take a look to the (additional) changes and feel free to pick or not. > > Thanks, > Dylan > > Quoting Andres Gomez (2019-02-01 10:05:52) > > From: Iago Toral Quiroga > > > > Regarding location aliasing requirements, th

Re: [Mesa-dev] [PATCH v2 6/6] glsl/linker: check for xfb_offset aliasing

2019-04-10 Thread Andres Gomez
On Wed, 2019-04-10 at 10:40 +1000, Timothy Arceri wrote: > On 13/2/19 8:57 am, Andres Gomez wrote: > > From page 76 (page 80 of the PDF) of the GLSL 4.60 v.5 spec: > > > >" No aliasing in output buffers is allowed: It is a compile-time or > > link

Re: [Mesa-dev] [PATCH v2 6/6] glsl/linker: check for xfb_offset aliasing

2019-04-09 Thread Andres Gomez
I'll add locally to the commit log: Fixes the following test: KHR-GL44.enhanced_layouts.xfb_output_overlapping On Tue, 2019-02-12 at 23:57 +0200, Andres Gomez wrote: > From page 76 (page 80 of the PDF) of the GLSL 4.60 v.5 spec: > > " No aliasing in output buffers is allowed: I

[Mesa-dev] [PATCH v5 1/6] glsl/linker: location aliasing requires types to have the same width

2019-03-29 Thread Andres Gomez
and commit log (Andres). Fixes: 13652e7516a ("glsl/linker: Fix type checks for location aliasing") Cc: Ilia Mirkin Cc: Timothy Arceri Cc: Iago Toral Quiroga Signed-off-by: Andres Gomez --- src/compiler/glsl/link_varyings.cpp | 115 ++-- 1 file changed, 76 inserti

Re: [Mesa-dev] [PATCH] nir: Fix anonymous union initialization with older GCC.

2019-03-22 Thread Andres Gomez
This is: Reviewed-by: Andres Gomez On Fri, 2019-03-22 at 03:04 +, Vinson Lee wrote: > Fix this build error with GCC 4.4.7. > > CC nir/nir_opt_copy_prop_vars.lo > nir/nir_opt_copy_prop_vars.c: In function ‘load_element_from_ssa_entry_value’: > nir/nir_opt_copy_prop_va

Re: [Mesa-dev] [PATCH v4 1/6] glsl/linker: location aliasing requires types to have the same width

2019-03-20 Thread Andres Gomez
On Wed, 2019-03-20 at 16:46 +0200, Andres Gomez wrote: > On Thu, 2019-03-21 at 00:20 +1100, Timothy Arceri wrote: > > On 20/3/19 9:31 pm, Andres Gomez wrote: > > > On Wed, 2019-03-20 at 20:46 +1100, Timothy Arceri wrote: > > > > On 2/2/19 5:05 am, Andres Gomez wro

Re: [Mesa-dev] [PATCH v4 1/6] glsl/linker: location aliasing requires types to have the same width

2019-03-20 Thread Andres Gomez
On Thu, 2019-03-21 at 00:20 +1100, Timothy Arceri wrote: > On 20/3/19 9:31 pm, Andres Gomez wrote: > > On Wed, 2019-03-20 at 20:46 +1100, Timothy Arceri wrote: > > > On 2/2/19 5:05 am, Andres Gomez wrote: > > > > From: Iago Toral Quiroga > > > > > &

Re: [Mesa-dev] [PATCH v4 1/6] glsl/linker: location aliasing requires types to have the same width

2019-03-20 Thread Andres Gomez
On Wed, 2019-03-20 at 20:46 +1100, Timothy Arceri wrote: > On 2/2/19 5:05 am, Andres Gomez wrote: > > From: Iago Toral Quiroga > > > > Regarding location aliasing requirements, the OpenGL spec says: > > > >"Further, when location aliasing, the aliases

Re: [Mesa-dev] [PATCH v4 1/6] glsl/linker: location aliasing requires types to have the same width

2019-03-20 Thread Andres Gomez
On Wed, 2019-03-20 at 20:46 +1100, Timothy Arceri wrote: > On 2/2/19 5:05 am, Andres Gomez wrote: > > From: Iago Toral Quiroga > > > > Regarding location aliasing requirements, the OpenGL spec says: > > > >"Further, when location aliasing, the aliases

Re: [Mesa-dev] [PATCH v2 4/6] glsl/linker: don't fail non static used inputs without matching outputs

2019-03-19 Thread Andres Gomez
nce, I'll understand I can land this with your Rb. > > Reviewed-by: Timothy Arceri > > Thanks for fixing this! > > On 7/2/19 2:58 am, Andres Gomez wrote: > > If there is no Static Use of an input variable, the linker shouldn't > > fail whenever there

Re: [Mesa-dev] [PATCH] mesa: INVALID_VALUE for wrong type or format in Clear*Buffer*Data

2019-02-14 Thread Andres Gomez
On Thu, 2019-02-14 at 14:31 +0200, Tapani Pälli wrote: > LGTM > > Reviewed-by: Tapani Pälli Thanks for the review, Tapani ☺ > > On 2/12/19 2:17 PM, Andres Gomez wrote: > > Instead of generating a GL_INVALID_ENUM error when the type or format > > is incorrect while

[Mesa-dev] [PATCH v2 6/6] glsl/linker: check for xfb_offset aliasing

2019-02-12 Thread Andres Gomez
t succeeds: " ... layout (xfb_offset = 0) out vec2 a; layout (xfb_offset = 0) out vec4 b; ... " v2: use a data structure to track the used components instead of a nested loop (Ilia). Cc: Timothy Arceri Cc: Ilia Mirkin Signed-off-by: Andres Gomez --- src/compiler/glsl/li

[Mesa-dev] [PATCH] mesa: INVALID_VALUE for wrong type or format in Clear*Buffer*Data

2019-02-12 Thread Andres Gomez
table 8.2. An INVALID_VALUE error is generated if format is not one of the formats in table 8.3." Fixes the following test: KHR-GL45.direct_state_access.buffers_errors Cc: Pi Tabred Cc: Brian Paul Signed-off-by: Andres Gomez --- src/mesa/main/bufferobj.c | 8 1 file

Re: [Mesa-dev] [PATCH 2/6] glsl: correctly validate component layout qualifier for dvec{3, 4}

2019-02-11 Thread Andres Gomez
On Sat, 2019-02-02 at 10:49 +1100, Timothy Arceri wrote: > On 2/2/19 5:05 am, Andres Gomez wrote: > > From page 62 (page 68 of the PDF) of the GLSL 4.50 v.7 spec: > > > >" A dvec3 or dvec4 can only be declared without specifying a > > component." >

[Mesa-dev] [PATCH] Revert "glsl: relax input->output validation for SSO programs"

2019-02-08 Thread Andres Gomez
rface will be undefined." Fixes: 1aa5738e666 ("glsl: relax input->output validation for SSO programs") Cc: Tapani Pälli Cc: Timothy Arceri Cc: Ilia Mirkin Cc: Samuel Iglesias Gonsálvez Cc: Ian Romanick Signed-off-by: Andres Gomez --- src/compiler/glsl/link_varyings.cpp | 2 +- 1 fi

Re: [Mesa-dev] [PATCH v2 4/6] glsl/linker: don't fail non static used inputs without matching outputs

2019-02-08 Thread Andres Gomez
ce between vs and gs has a used input that doesn't > exist in the vs. The test should fail validation, the idea being the > test would have failed on your v1 of this patch. > > Thanks. > > > On 7/2/19 2:58 am, Andres Gomez wrote: > > If there is no Static

[Mesa-dev] [PATCH v2 4/6] glsl/linker: don't fail non static used inputs without matching outputs

2019-02-06 Thread Andres Gomez
Cc: Ian Romanick Cc: Ilia Mirkin Signed-off-by: Andres Gomez --- src/compiler/glsl/link_varyings.cpp | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/src/compiler/glsl/link_varyings.cpp b/src/compiler/glsl/link_varyings.cpp index e5f7d3e322a..36908d95

Re: [Mesa-dev] [PATCH 4/6] glsl/linker: don't fail non static used inputs without matching outputs

2019-02-06 Thread Andres Gomez
On Wed, 2019-02-06 at 09:42 +1100, Timothy Arceri wrote: > On 6/2/19 1:11 am, Andres Gomez wrote: > > On Fri, 2019-02-01 at 18:37 -0500, Ilia Mirkin wrote: > > > On Fri, Feb 1, 2019 at 1:08 PM Andres Gomez wrote: > > > > If there is no Static Use of an input

Re: [Mesa-dev] [PATCH 4/6] glsl/linker: don't fail non static used inputs without matching outputs

2019-02-05 Thread Andres Gomez
On Fri, 2019-02-01 at 18:37 -0500, Ilia Mirkin wrote: > On Fri, Feb 1, 2019 at 1:08 PM Andres Gomez wrote: > > If there is no Static Use of an input variable, the linker shouldn't > > fail whenever there is no defined matching output variable in the > > previous stage. > &

Re: [Mesa-dev] [PATCH 5/6] glsl/linker: simplify xfb_offset vs xfb_stride overflow check

2019-02-04 Thread Andres Gomez
On Fri, 2019-02-01 at 13:17 -0500, Ilia Mirkin wrote: > On Fri, Feb 1, 2019 at 1:08 PM Andres Gomez wrote: > > Current implementation uses a complicated calculation which relies in > > an implicit conversion to check the integral part of 2 division > > results. > > &

Re: [Mesa-dev] [PATCH 5/6] glsl/linker: simplify xfb_offset vs xfb_stride overflow check

2019-02-02 Thread Andres Gomez
On Sat, 2019-02-02 at 10:10 +1100, Timothy Arceri wrote: > On 2/2/19 5:05 am, Andres Gomez wrote: > > Current implementation uses a complicated calculation which relies in > > an implicit conversion to check the integral part of 2 division > > results. > > > >

[Mesa-dev] [PATCH v4 1/6] glsl/linker: location aliasing requires types to have the same width

2019-02-01 Thread Andres Gomez
16a ("glsl/linker: Fix type checks for location aliasing") Cc: Ilia Mirkin Signed-off-by: Andres Gomez --- src/compiler/glsl/link_varyings.cpp | 64 + 1 file changed, 46 insertions(+), 18 deletions(-) diff --git a/src/compiler/glsl/link_varyings.cpp

[Mesa-dev] [PATCH 4/6] glsl/linker: don't fail non static used inputs without matching outputs

2019-02-01 Thread Andres Gomez
c: Iago Toral Quiroga Cc: Samuel Iglesias Gonsálvez Cc: Tapani Pälli Cc: Ian Romanick Signed-off-by: Andres Gomez --- src/compiler/glsl/link_varyings.cpp | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/src/compiler/glsl/link_varyings.cpp b/src/compiler/glsl/li

[Mesa-dev] [PATCH 0/6] glsl/linker: several arb_enhanced_layouts related fixes

2019-02-01 Thread Andres Gomez
This series addresses the problems tested in the piglit series sent for review at: https://patchwork.freedesktop.org/series/56099/ Andres Gomez (5): glsl: correctly validate component layout qualifier for dvec{3,4} glsl/linker: always validate explicit location among inputs glsl/linker

[Mesa-dev] [PATCH 2/6] glsl: correctly validate component layout qualifier for dvec{3, 4}

2019-02-01 Thread Andres Gomez
;glsl: validate and store component layout qualifier in GLSL IR") Cc: Timothy Arceri Cc: Kenneth Graunke Signed-off-by: Andres Gomez --- src/compiler/glsl/ast_to_hir.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/compiler/glsl/ast_to_hir.cpp b/src/compiler/glsl/ast_to_hir.cpp

[Mesa-dev] [PATCH 6/6] glsl/linker: check for xfb_offset aliasing

2019-02-01 Thread Andres Gomez
t succeeds: " ... layout (xfb_offset = 0) out vec2 a; layout (xfb_offset = 0) out vec4 b; ... " Cc: Timothy Arceri Signed-off-by: Andres Gomez --- src/compiler/glsl/link_varyings.cpp | 23 +++ 1 file changed, 23 insertions(+) diff --git a/src/compiler/glsl/link

[Mesa-dev] [PATCH 5/6] glsl/linker: simplify xfb_offset vs xfb_stride overflow check

2019-02-01 Thread Andres Gomez
n") Cc: Timothy Arceri Signed-off-by: Andres Gomez --- src/compiler/glsl/link_varyings.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/compiler/glsl/link_varyings.cpp b/src/compiler/glsl/link_varyings.cpp index 6cebc5b3c5a..ab66ceb0d00 100644 --- a/src/compiler/gl

[Mesa-dev] [PATCH 3/6] glsl/linker: always validate explicit location among inputs

2019-02-01 Thread Andres Gomez
n aliasing is happening for the inputs. Therefore, we also need to validate the inputs independently from the outcome of the outputs validation. Cc: Timothy Arceri Cc: Iago Toral Quiroga Cc: Ilia Mirkin Signed-off-by: Andres Gomez --- src/compiler/glsl/link_varyings.cpp | 13 ++--- 1 file c

Re: [Mesa-dev] [PATCH] bin/get-pick-list.sh: fix the oneline printing

2019-01-14 Thread Andres Gomez
On Fri, 2019-01-11 at 14:56 +, Eric Engestrom wrote: > On Friday, 2019-01-11 16:42:25 +0200, Andres Gomez wrote: > > "--summary" will also print extended header information such as > > creations, renames and mode changes. > > > > Let's just use &

Re: [Mesa-dev] [PATCH] bin/get-pick-list.sh: fix redirection in sh

2019-01-14 Thread Andres Gomez
On Fri, 2019-01-11 at 15:41 +, Emil Velikov wrote: > On 2019/01/11, Andres Gomez wrote: > > "&>" is bash specific. > > > > Fixes: e0dbfc99537 ("bin/get-pick-list.sh: warn when commit lists invalid > > sha") > > Cc: Juan A. Suare

Re: [Mesa-dev] [ANNOUNCE] mesa 18.3.1

2019-01-12 Thread Andres Gomez
Gomez wrote: > On Fri, 2019-01-11 at 15:22 +, Emil Velikov wrote: > > Hi Andres, > > > > On Fri, 11 Jan 2019 at 15:05, Andres Gomez wrote: > > > > > > I'll start with the 18.3.2 release process and keep with the the > > > following bugfix rele

Re: [Mesa-dev] [ANNOUNCE] mesa 18.3.1

2019-01-11 Thread Andres Gomez
On Fri, 2019-01-11 at 15:22 +, Emil Velikov wrote: > Hi Andres, > > On Fri, 11 Jan 2019 at 15:05, Andres Gomez wrote: > > > > I'll start with the 18.3.2 release process and keep with the the > > following bugfix releases by now. > > > > I was going

Re: [Mesa-dev] [ANNOUNCE] mesa 18.3.1

2019-01-11 Thread Andres Gomez
I'll start with the 18.3.2 release process and keep with the the following bugfix releases by now. On Mon, 2019-01-07 at 15:33 +0200, Andres Gomez wrote: > Emil, the 18.3.2 should have already happened by the 19th of December. > > Is there anything stopping you from go

[Mesa-dev] [PATCH] bin/get-pick-list.sh: fix redirection in sh

2019-01-11 Thread Andres Gomez
"&>" is bash specific. Fixes: e0dbfc99537 ("bin/get-pick-list.sh: warn when commit lists invalid sha") Cc: Juan A. Suarez Cc: Eric Engestrom Cc: Dylan Baker Cc: Emil Velikov Signed-off-by: Andres Gomez --- bin/get-pick-list.sh | 2 +- 1 file changed, 1 insert

[Mesa-dev] [PATCH] bin/get-pick-list.sh: fix the oneline printing

2019-01-11 Thread Andres Gomez
rom Cc: Dylan Baker Cc: Emil Velikov Signed-off-by: Andres Gomez --- bin/get-pick-list.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bin/get-pick-list.sh b/bin/get-pick-list.sh index 3099fc69413..d71ff4a708a 100755 --- a/bin/get-pick-list.sh +++ b/bin/get-pick-

[Mesa-dev] [PATCH] docs: complete the calendar and release schedule documentation

2019-01-07 Thread Andres Gomez
As suggested by Emil Velikov. Cc: Dylan Baker Cc: Juan A. Suarez Cc: Emil Velikov Signed-off-by: Andres Gomez --- docs/release-calendar.html | 10 ++ docs/releasing.html| 14 -- 2 files changed, 22 insertions(+), 2 deletions(-) diff --git a/docs/release

Re: [Mesa-dev] [PATCH] glsl: correct typo in GLSL compilation error message

2019-01-07 Thread Andres Gomez
On Mon, 2019-01-07 at 16:48 +0100, Erik Faye-Lund wrote: > On Mon, 2019-01-07 at 15:50 +0200, Andres Gomez wrote: > > Correct a typo introduced by > > 037f68d81e1 ("glsl: apply align layout qualifier rules to block > > offsets") > > > > Cc: Timo

[Mesa-dev] [PATCH] glsl/linker: specify proper direction in location aliasing error

2019-01-07 Thread Andres Gomez
The check for location aliasing was always asuming output variables but this validation is also called for input variables. Fixes: e2abb75b0e4 ("glsl/linker: validate explicit locations for SSO programs") Cc: Iago Toral Quiroga Signed-off-by: Andres Gomez --- src/com

[Mesa-dev] [PATCH] glsl: correct typo in GLSL compilation error message

2019-01-07 Thread Andres Gomez
Correct a typo introduced by 037f68d81e1 ("glsl: apply align layout qualifier rules to block offsets") Cc: Timothy Arceri Signed-off-by: Andres Gomez --- src/compiler/glsl/ast_to_hir.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/glsl/ast_to_hir

[Mesa-dev] [PATCH] editorconfig: Add max_line_length property

2019-01-07 Thread Andres Gomez
The property is supported by the most of the editors, but not all: https://github.com/editorconfig/editorconfig/wiki/EditorConfig-Properties#max_line_length Cc: Eric Engestrom Cc: Eric Anholt Signed-off-by: Andres Gomez --- .editorconfig | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [Mesa-dev] [ANNOUNCE] mesa 18.3.1

2019-01-07 Thread Andres Gomez
Emil, the 18.3.2 should have already happened by the 19th of December. Is there anything stopping you from going ahead with it? I've also noticed that there is a 3 weeks gap (instead of 2) from 18.3.2 to 18.3.3. I suppose you decided that due to most of the people being on XMas and New Year

[Mesa-dev] [PATCH] glsl/linker: complete documentation for assign_attribute_or_color_locations

2019-01-02 Thread Andres Gomez
Commit 27f1298b9d9 ("glsl/linker: validate attribute aliasing before optimizations") forgot to complete the documentation. Cc: Tapani Pälli Signed-off-by: Andres Gomez --- src/compiler/glsl/linker.cpp | 22 +- 1 file changed, 13 insertions(+), 9 deletions(-)

Re: [Mesa-dev] [PATCH 1/2] bin/get-pick-list.sh: rework handing of sha nominations

2018-12-18 Thread Andres Gomez
On Tue, 2018-12-18 at 10:47 +, Emil Velikov wrote: > On Mon, 17 Dec 2018 at 22:35, Andres Gomez wrote: > > > > On Mon, 2018-12-17 at 18:36 +, Emil Velikov wrote: > > > On Mon, 17 Dec 2018 at 18:14, Andres Gomez wrote: > > > > > > > >

Re: [Mesa-dev] [PATCH mesa] drop autotools

2018-12-17 Thread Andres Gomez
On Mon, 2018-12-17 at 19:51 +0100, Bas Nieuwenhuizen wrote: > On Mon, Dec 17, 2018 at 6:33 PM Juan A. Suarez Romero > wrote: > > > > On Mon, 2018-12-03 at 10:21 +, Eric Engestrom wrote: > > > Cc: Emil Velikov > > > Cc: Andres Gomez > > > Cc:

[Mesa-dev] [PATCH] docs: update 18.3 and add 19.x cycles for the release calendar

2018-12-17 Thread Andres Gomez
Cc: Dylan Baker Cc: Juan A. Suarez Cc: Emil Velikov Signed-off-by: Andres Gomez --- docs/release-calendar.html | 118 - 1 file changed, 116 insertions(+), 2 deletions(-) diff --git a/docs/release-calendar.html b/docs/release-calendar.html index 924995c2698

Re: [Mesa-dev] [PATCH 1/2] bin/get-pick-list.sh: rework handing of sha nominations

2018-12-17 Thread Andres Gomez
On Mon, 2018-12-17 at 18:36 +, Emil Velikov wrote: > On Mon, 17 Dec 2018 at 18:14, Andres Gomez wrote: > > > > On Mon, 2018-12-17 at 16:43 +, Emil Velikov wrote: > > > Currently our is_sha_nomination does: > > > - folds any whitespace, attemptin

Re: [Mesa-dev] [PATCH 1/2] bin/get-pick-list.sh: rework handing of sha nominations

2018-12-17 Thread Andres Gomez
ndatory for direct rendering > +[fixes ] 5bc509363b6 glx: make xf86vidmode mandatory for direct rendering > > (b) > -[ stable ] 9a7b3199037 anv/query: flush render target before copying > results > > CC: Andres Gomez > CC: Juan A. Suarez > CC: Dylan Baker

Re: [Mesa-dev] [PATCH] docs: extends 18.2 lifecycle

2018-12-10 Thread Andres Gomez
This is: Reviewed-by: Andres Gomez On Mon, 2018-12-10 at 13:25 +0100, Juan A. Suarez Romero wrote: > As 18.3 was published with some delay, let's extend 18.2 life for > another extra release. > > CC: Andres Gomez > CC: Dylan Baker > CC: Emil Velikov > --- > docs/r

Re: [Mesa-dev] [PATCH] mesa/texture: Also check for LA texture when querying intensity component size

2018-09-11 Thread Andres Gomez
Gert, should we also include this in the stable queues ? On Mon, 2018-09-10 at 12:39 +0200, Gert Wollny wrote: > From: Gert Wollny > > Gallium may pick L16A16_FLOAT to represent GL_INTENSITY16F if no intensity > format is provided by the driver. However, when calling > >

Re: [Mesa-dev] [PATCH] travis: use python3.5 for meson

2018-09-11 Thread Andres Gomez
This is: Reviewed-by: Andres Gomez On Mon, 2018-09-10 at 14:15 +0200, Juan A. Suarez Romero wrote: > Newer Meson versions require python >=3.5. But in Trusty default python3 > version is 3.4.x. > > Install python3.5 and makes it the default version for Meson using > update-a

[Mesa-dev] [ANNOUNCE] mesa 18.2.0

2018-09-07 Thread Andres Gomez
: - GL_EXT_texture_norm16. radeonsi: - GL_EXT_texture_norm16. virgl: - GL_ARB_seamless_cubemap_per_texture. - GL_ARB_shader_stencil_export. For the full log see: git log 18.1-branchpoint..mesa-18.2.0 Changes since rc6: Andres Gomez (3): Revert "glsl: skip stringific

Re: [Mesa-dev] [Mesa-stable] [PATCH] glsl: fixer lexer for unreachable defines

2018-09-07 Thread Andres Gomez
Pulled into staging/18.2. Thanks for the heads up. On Thu, 2018-09-06 at 09:24 -0700, Dylan Baker wrote: > Quoting Timothy Arceri (2018-09-05 19:40:34) > > Cc: mesa-sta...@lists.freedesktop.org > > > > On 01/09/18 23:57, Timothy Arceri wrote: > > > If we have something like: > > > > > >

Re: [Mesa-dev] [PATCH v4 0/8] mesa: fix usage of [v][s][n]printf functions

2018-09-06 Thread Andres Gomez
On Thu, 2018-09-06 at 17:58 +0100, Eric Engestrom wrote: > On Thursday, 2018-09-06 17:43:50 +0300, asimiklit.w...@gmail.com wrote: > > From: Andrii Simiklit > > > > This patch improve usage of [v][s][n]printf functions. > > Fixes cross platform implementation of vsnprintf > > > > v2: Linux man

Re: [Mesa-dev] [ANNOUNCE] mesa 18.2.0-rc6

2018-09-06 Thread Andres Gomez
On Fri, 2018-09-07 at 08:26 +1000, Timothy Arceri wrote: > On 06/09/18 22:36, Andres Gomez wrote: > > On Thu, 2018-09-06 at 14:15 +1000, Timothy Arceri wrote: > > > On 06/09/18 07:57, Andres Gomez wrote:> Hello list, > > > > [...] > > > >

[Mesa-dev] [PATCH v2] docs: add the beginning of the 18.3 cycle

2018-09-06 Thread Andres Gomez
v2: Move 18.3.0-rcZ releases to Tuesdays. Cc: Dylan Baker Cc: Juan A. Suarez Cc: Emil Velikov Signed-off-by: Andres Gomez Acked-by: Dylan Baker --- Releases should happen on Wednesdays and X.Y.0-rcZ announcements just 24h before a release. Therefore, moving 18.3.0-rcZ to Tuesdays. diff

Re: [Mesa-dev] [ANNOUNCE] mesa 18.2.0-rc6

2018-09-06 Thread Andres Gomez
On Thu, 2018-09-06 at 14:15 +1000, Timothy Arceri wrote: > On 06/09/18 07:57, Andres Gomez wrote:> Hello list, [...] > > > > Testing reports/general approval > > > > > > Any testing reports (or general approval of the stat

Re: [Mesa-dev] [Mesa-announce] [ANNOUNCE] mesa 18.2.0-rc5

2018-09-06 Thread Andres Gomez
On Tue, 2018-09-04 at 17:10 -0400, Marek Olšák wrote: > Hi Andres, > > When do you plan to release final Mesa 18.2? > > Thanks, > Marek > > On Wed, Aug 29, 2018 at 8:28 PM, Andres Gomez wrote: [...] > > The plan is to have the sixth release candidate for 18.2.0

[Mesa-dev] [ANNOUNCE] mesa 18.2.0-rc6

2018-09-05 Thread Andres Gomez
Queued (32) === Andres Gomez (4): cherry-ignore: mesa: allow GL_UNSIGNED_BYTE type for SNORM reads cherry-ignore: radeonsi: fix regression in indirect input swizzles. cherry-ignore: anv/blorp: Fix a comment as per Nanley's review feedback Update version to 18.2.0-rc6

Re: [Mesa-dev] [Mesa-announce] [ANNOUNCE] mesa 18.2.0-rc5

2018-09-05 Thread Andres Gomez
On Tue, 2018-09-04 at 17:10 -0400, Marek Olšák wrote: > Hi Andres, > > When do you plan to release final Mesa 18.2? > > Thanks, > Marek > > On Wed, Aug 29, 2018 at 8:28 PM, Andres Gomez wrote: [...] > > > > The plan is to have the sixth release candidate

Re: [Mesa-dev] [PATCH] intel: compiler: remove dead local variables at optimization pass

2018-09-04 Thread Andres Gomez
Thanks for the prompt reply, Jason. I will skip this patch, then. On Tue, 2018-09-04 at 15:51 -0500, Jason Ekstrand wrote: > Doesn't matter too much > > On Tue, Sep 4, 2018 at 3:45 PM Andres Gomez wrote: > > Lionel, should we also include this in the stable queues ? > >

Re: [Mesa-dev] [PATCH] intel: compiler: remove dead local variables at optimization pass

2018-09-04 Thread Andres Gomez
Lionel, should we also include this in the stable queues ? On Mon, 2018-09-03 at 16:47 +0100, Lionel Landwerlin wrote: > We're hitting an assert in gfxbench because one of the local variable > is a sampler (according to Jason this isn't valid) : > > testfw_app:

Re: [Mesa-dev] [ANNOUNCE] mesa 18.2.0-rc5

2018-09-03 Thread Andres Gomez
On Fri, 2018-08-31 at 13:24 -0700, Mark Janes wrote: > Hi Andres, > > The final blockers have been resolved. You should be able to make an RC > that passes all Intel validation, if you pick up: > > 904c2a617d8 * i965/gen7_urb: Re-emit PUSH_CONSTANT_ALLOC on some gen9 > d9cf4308cee *

[Mesa-dev] [PATCH] docs: add the beginning of the 18.3 cycle

2018-08-31 Thread Andres Gomez
Cc: Dylan Baker Cc: Juan A. Suarez Cc: Emil Velikov Signed-off-by: Andres Gomez --- docs/release-calendar.html | 25 + 1 file changed, 25 insertions(+) This is just a proposal for the beginning of the 18.3 releasing process. 18.2 has gotten exceptionally long

Re: [Mesa-dev] [PATCH v2] egl/wayland: do not leak wl_buffer when it is locked

2018-08-31 Thread Andres Gomez
Juan, should we also include this in the stable queues ? On Thu, 2018-08-30 at 13:59 +0200, Juan A. Suarez Romero wrote: > If color buffer is locked, do not set its wayland buffer to NULL; > otherwise it can not be freed later. > > Rather, flag it in order to destroy it later on the release

[Mesa-dev] [PATCH] docs: update calendar to extended the 18.1 cycle by one more release

2018-08-30 Thread Andres Gomez
Due to having 2 additional RCs for 18.2. Cc: Dylan Baker Cc: Juan A. Suarez Cc: Emil Velikov Signed-off-by: Andres Gomez --- docs/release-calendar.html | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/docs/release-calendar.html b/docs/release-calendar.html index

[Mesa-dev] [ANNOUNCE] mesa 18.2.0-rc5

2018-08-29 Thread Andres Gomez
fix CMASK fast clear for NPOT textures with mipmapping on SI/CI/VI Tapani Pälli (1): a72dbc461bd mesa: allow GL_UNSIGNED_BYTE type for SNORM reads Queued (23) === Andres Gomez (1): Update version to 18.2.0-rc5 Dylan Baker (1): meson: Actually load transla

Re: [Mesa-dev] [PATCH] glsl/linker: Link all out vars from a shader objects on a single stage

2018-08-29 Thread Andres Gomez
Vadym, should we also include this in the stable queues ? On Mon, 2018-08-27 at 15:20 +0300, Vadym Shovkoplias wrote: > From: "vadym.shovkoplias" > > During intra stage linking some out variables can be dropped because > it is not used in a shader with the main function. But these out vars >

Re: [Mesa-dev] [Mesa-stable] [PATCH] mesa: allow GL_UNSIGNED_BYTE type for SNORM reads

2018-08-29 Thread Andres Gomez
On Wed, 2018-08-29 at 08:22 -0700, Dylan Baker wrote: > Quoting Tapani Pälli (2018-08-27 04:46:37) > > OpenGL ES spec states: > >"For normalized fixed-point rendering surfaces, the combination format > > RGBA and type UNSIGNED_BYTE is accepted." > > > > This fixes following failing

Re: [Mesa-dev] [PATCH 1/5] meson: Actually load translation files

2018-08-29 Thread Andres Gomez
Dylan, due to a previously backport requested by Emil, this patch has bumped into some trivial conflict I have resolved. Please, check that everything looks in order. You can find the commit here (staging/18.2):

Re: [Mesa-dev] [PATCH 2/3] anv: Copy the appliation info into the instance

2018-08-29 Thread Andres Gomez
Jason, this series (specifically, the patch 2/3), is causing regressions in VK-GL-CTS with mesa's 18.2 stable queue. I don't know if this is happening also in master, but it's quite possible. I've checked with the x11_egl target and the "vulkan-cts-1.1.2" branch:

Re: [Mesa-dev] [PATCH] mesa: allow GL_UNSIGNED_BYTE type for SNORM reads

2018-08-28 Thread Andres Gomez
This is: Tested-by: Andres Gomez On Mon, 2018-08-27 at 14:46 +0300, Tapani Pälli wrote: > OpenGL ES spec states: >"For normalized fixed-point rendering surfaces, the combination format > RGBA and type UNSIGNED_BYTE is accepted." > > This fixes followin

Re: [Mesa-dev] [PATCH] i965/gen6/xfb: handle case where transform feedback is not active

2018-08-28 Thread Andres Gomez
Andrii, Samuel, should we also include this in the stable queues ? On Wed, 2018-08-15 at 18:20 +0300, asimiklit.w...@gmail.com wrote: > From: Andrii Simiklit > > When the SVBI Payload Enable is false I guess the register R1.4 > which contains the Maximum Streamed Vertex Buffer Index is filled

Re: [Mesa-dev] [PATCH] intel: decoder: unify MI_BB_START field naming

2018-08-27 Thread Andres Gomez
Lionel, should we also include this in the stable queues ? On Tue, 2018-08-14 at 11:26 +0100, Lionel Landwerlin wrote: > The batch decoder looks for a field with a particular name to decide > whether an MI_BB_START leads into a second batch buffer level. Because > the names are different between

Re: [Mesa-dev] [PATCH] intel: decoder: handle 0 sized structs

2018-08-27 Thread Andres Gomez
Lionel, should we also include this in the stable queues ? On Sat, 2018-08-25 at 18:23 +0100, Lionel Landwerlin wrote: > Gen7.5 has a BLEND_STATE of size 0 which includes a variable length > group. We did not deal with that very well, leading to an endless > loop. > > Signed-off-by: Lionel

Re: [Mesa-dev] [PATCH] glsl/linker: Allow unused in blocks which are not declated on previous stage

2018-08-27 Thread Andres Gomez
Vadym, should we also include this in the stable queues ? On Mon, 2018-08-20 at 16:31 +0300, vadym.shovkoplias wrote: > From Section 4.3.4 (Inputs) of the GLSL 1.50 spec: > > "Only the input variables that are actually read need to be written > by the previous stage; it is allowed to

Re: [Mesa-dev] [PATCH 2/2] glsl: remove execute bit and shebang from python tests

2018-08-24 Thread Andres Gomez
Emil, I've done some trivial conflicts resolution upon cherry picking this commit. You can see it at (staging/18.2): https://gitlab.freedesktop.org/mesa/mesa/commit/f6dccf66865c31b13f48b50891a9f5a0d9949b1c Please, let me know if this is OK. On Fri, 2018-08-17 at 12:11 +0100, Emil Velikov

[Mesa-dev] [ANNOUNCE] mesa 18.2.0-rc4

2018-08-22 Thread Andres Gomez
er structs ac/nir: fix getting GLSL type of array of samplers for TG4 Queued (18) === Alexander Tsoy (1): meson: fix build for egl platform_x11 without dri3 and gbm Andres Gomez (2): cherry-ignore: autotools: don't ship the git_sha1.h generated in git in th

Re: [Mesa-dev] [PATCH] i965: enable EXT_render_snorm

2018-08-22 Thread Andres Gomez
Tapani, this is causing some new regressions in OpenGLES CTS: https://bugs.freedesktop.org/show_bug.cgi?id=107658 On Thu, 2018-08-02 at 14:14 +0300, Tapani Pälli wrote: > Signed-off-by: Tapani Pälli > --- > src/mesa/drivers/dri/i965/intel_extensions.c | 1 + > 1 file changed, 1 insertion(+) >

Re: [Mesa-dev] [PATCH] i965: Advertise 8 bits subpixel precision for viewport bounds on gen6+

2018-08-20 Thread Andres Gomez
Danylo, should we also include this in the stable queues ? On Mon, 2018-06-18 at 15:50 +0300, Danylo Piliaiev wrote: > We use floating-points for viewport bounds so VIEWPORT_SUBPIXEL_BITS > should reflect this. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105975 > >

Re: [Mesa-dev] [PATCH] glsl: Avoid calling get_array_element for scalar constants

2018-08-15 Thread Andres Gomez
Danylo, should we also include this in the stable queues ? On Mon, 2018-08-13 at 18:57 +0300, Danylo Piliaiev wrote: > Accessing scalar constant as an array in function call or > initializer list triggered assert in get_array_element. > Examples: >func(0[0]); >vec2 t = { 0[0], 0 }; > >

[Mesa-dev] [ANNOUNCE] mesa 18.2.0-rc3

2018-08-15 Thread Andres Gomez
droid: fix regression in drm_gralloc path (v2) Queued (24) === Adam Jackson (1): glx: GLX_MESA_multithread_makecurrent is direct-only Andres Gomez (1): Update version to 18.2.0-rc3 Bas Nieuwenhuizen (3): radv: Fix missing Android platform define. radv: Upd

Re: [Mesa-dev] [Mesa-stable] [PATCH] radv: Unset ZRANGE_PRECISION when depth was zeroed

2018-08-09 Thread Andres Gomez
On Thu, 2018-08-09 at 15:33 +0200, Bas Nieuwenhuizen wrote: > On Thu, Aug 9, 2018 at 2:56 PM, Andres Gomez wrote: > > Bas, James, did you eventually come with a resolution for this? Can I > > just ignore this nominated patch in the -stable ML? > > The fix in this patch lan

Re: [Mesa-dev] [PATCH] intel/isl: Avoid tiling on 16K-wide render targets

2018-08-09 Thread Andres Gomez
.gtf30.GL3Tests.framebuffer_blit.framebuffer_blit_error_blitframebuffer_multisampled_read_buffer_different_sizes GTF-GL46.gtf30.GL3Tests.framebuffer_blit.framebuffer_blit_functionality_multisampled_to_singlesampled_blit On Mon, 2018-07-30 at 19:25 +0300, Andres Gomez wrote: > That was qu

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/8] radv: don't flush src stages when dstStageMask == BOTTOM_OF_PIPE

2018-08-09 Thread Andres Gomez
Fredrik, which is the status of this series? Several patches got R-b but nothing has landed so far. Are you in need of more reviews for the rest of the patches in the series? On Tue, 2018-06-26 at 23:49 +0200, Fredrik Höglund wrote: > The Vulkan specification says: > >"An execution

Re: [Mesa-dev] [Mesa-stable] [PATCH 4/8] egl: rework input validation order in _eglCreateWindowSurfaceCommon

2018-08-09 Thread Andres Gomez
Emil, this patch has been stalled in the -stable ML for quite some time without update. Unless you say otherwise, I will just ignore it at this point and trust that you will also Cc -stable in the future, in case you come with another version. On Wed, 2017-09-27 at 17:36 +0200, Juan A. Suarez

Re: [Mesa-dev] [Mesa-stable] [PATCH] radv: Unset ZRANGE_PRECISION when depth was zeroed

2018-08-09 Thread Andres Gomez
Bas, James, did you eventually come with a resolution for this? Can I just ignore this nominated patch in the -stable ML? On Wed, 2018-03-28 at 15:28 +0200, Bas Nieuwenhuizen wrote: > No final resolution yet. > > I was trying to fix my minor comment, but looks like I have a bunch of > CTS

Re: [Mesa-dev] [Mesa-stable] [PATCH] glx: GLX_MESA_multithread_makecurrent is direct-only

2018-08-09 Thread Andres Gomez
Adam, which is the status of this patch? Is this effectively dropped? On Wed, 2017-12-06 at 16:13 -0500, Adam Jackson wrote: > On Wed, 2017-12-06 at 15:01 -0500, Ian Romanick wrote: > > On 12/06/2017 10:32 AM, Emil Velikov wrote: > > > On 5 December 2017 at 16:10, Adam Jackson wrote: > > > >

Re: [Mesa-dev] [Mesa-stable] [PATCH 07/10] gbm: unify error handling in gbm_dri_bo_import()

2018-08-09 Thread Andres Gomez
Emil, this patch never landed in master (nor got a R-b). Is this still relevant? Could you manage to get somebody to review it? I'd do it myself but I'm quite ignorant on the GBM bits. On Mon, 2017-10-16 at 17:04 +0100, Emil Velikov wrote: > From: Emil Velikov > > Fold the error handling for

Re: [Mesa-dev] [Mesa-stable] [PATCH] glx: use correct table offset for glAreTexturesResidentEXT

2018-08-09 Thread Andres Gomez
Emil, this patch has been stalled in the -stable ML for quite some time without update. Unless you say otherwise, I will just ignore it at this point and trust that you will also Cc -stable in the future, in case you come with another version. On Tue, 2017-09-26 at 18:52 +0200, Juan A. Suarez

Re: [Mesa-dev] [Mesa-stable] [PATCH] meta: Fix BlitFramebuffer temp texture setup

2018-08-09 Thread Andres Gomez
Romero wrote: > On Tue, 2017-07-11 at 15:42 +0300, Ville Syrjälä wrote: > > On Mon, Jul 10, 2017 at 11:42:18PM +0300, Andres Gomez wrote: > > > Ville, has this patch fallen through the cracks ? > > > > Nope. I've still been looking into the issue whenever I've had a >

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/3] anv: Stop racing relocation offsets

2018-08-09 Thread Andres Gomez
Romero wrote: > On Mon, 2017-06-26 at 22:39 +0300, Andres Gomez wrote: > > Jason, it doesn't seem like this patch has landed in master. Are you in > > need of review or is it that this has been superseded? > > > > > Gently ping to know what is the status for thi

Re: [Mesa-dev] [PATCH v2] drirc: Allow extension midshader for Metro Redux

2018-08-09 Thread Andres Gomez
Vadym, should we also include this in the stable queues ? On Mon, 2018-08-06 at 15:52 +0300, vadym.shovkoplias wrote: > This fixes both Metro 2033 Redux and Metro Last Light Redux > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=99730 > Signed-off-by: Eero Tamminen > Signed-off-by:

Re: [Mesa-dev] [PATCH] glsl: handle error case with ast_post_inc, ast_post_dec

2018-08-09 Thread Andres Gomez
Tapani, should we also include this in the stable queues ? On Tue, 2018-08-07 at 08:20 +0300, Tapani Pälli wrote: > Return ir_rvalue::error_value with ast_post_inc, ast_post_dec if > parser error was emitted previously. This way process_array_size > won't see bogus IR generated like with commit

[Mesa-dev] [ANNOUNCE] Mesa 18.2.0-rc2

2018-08-08 Thread Andres Gomez
ayland/egl: update surface size on window resize Queued (17) ======= Andres Gomez (2): intel/tools: add error2aub creation into autotools Update version to 18.2.0-rc2 Chad Versace (1): drisw: Fix build on Android Nougat, which lacks shm (v2) Eric Anholt (7): v3d: Ma

Re: [Mesa-dev] [PATCH 1/2] travis: add ubuntu-toolchain-r-test

2018-08-07 Thread Andres Gomez
With a bit more clarifying commit log, this is: Reviewed-by: Andres Gomez On Mon, 2018-08-06 at 12:17 +0200, Juan A. Suarez Romero wrote: > LLVM 6.0 requires GCC 4.9, which is not available in main Travis > repository. > > Fixes: fd1121e8399 ("amd: remove support for LLVM

  1   2   3   4   5   6   7   >