Re: [Mesa-dev] [PATCH v3 5/6] radeonsi: use slot indexes for bindless handles

On Tue, Aug 8, 2017 at 6:57 PM, Samuel Pitoiset wrote: > Using VRAM address as bindless handles is not a good idea because > we have to use LLVMIntToPTr and the LLVM CSE pass can't optimize > because it has no information about the pointer. > > Instead, use slots

Re: [Mesa-dev] [PATCH] radeonsi: don't enable surf index on shareable images.

On Fri, Aug 11, 2017 at 6:35 AM, Dave Airlie wrote: > From: Dave Airlie > > This fixes the SteamVR menus, which were broken by this feature. That's impossible. RADEON_SURF_SHAREABLE is already checked by ac_surface.c. This patch is a no-op change. Marek

Re: [Mesa-dev] [PATCH v5 09/12] radeon: use common pipe_screen ref counting

On Wed, Aug 9, 2017 at 10:34 PM, Rob Herring wrote: > On Wed, Aug 9, 2017 at 3:19 PM, Marek Olšák wrote: >> You already know I can't accept the amdgpu part. > > You don't agree with my explanation in the other patch? OK. This patch is: Reviewed-by: Marek

Re: [Mesa-dev] [PATCH 3/3] gallium/radeon: pass LLVM processor to the disk shader cache

On Fri, Aug 11, 2017 at 3:09 AM, Timothy Arceri wrote: > On 11/08/17 05:57, Marek Olšák wrote: >> >> From: Marek Olšák >> >> --- >> src/gallium/drivers/radeon/r600_pipe_common.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff

Re: [Mesa-dev] [PATCH 2/3] gallium/radeon: only pass shader-specific debug flags to the disk shader cache

Patches 1 & 2: Reviewed-by: Nicolai Hähnle On 10.08.2017 21:57, Marek Olšák wrote: From: Marek Olšák --- src/gallium/drivers/radeon/r600_pipe_common.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [PATCH 0/5] GL_OES_required_internalformat

Eric Anholt writes: > Tapani Pälli writes: > >> On 06/22/2017 02:08 AM, Eric Anholt wrote: >>> Tapani Pälli writes: >>> On 06/14/2017 01:12 AM, Eric Anholt wrote: > Tapani Pälli writes: >

Re: [Mesa-dev] [PATCH] radeonsi/gfx9: use the VI codepath for clamping Z

On 10.08.2017 22:33, Marek Olšák wrote: From: Marek Olšák This fixes corrupted shadows in Unigine Valley. The corruption disappeared when I stopped setting IMG_DATA_FORMAT_24_8 for depth. Cc: 17.2 Reviewed-by: Nicolai Hähnle

Re: [Mesa-dev] [PATCH v3 5/6] radeonsi: use slot indexes for bindless handles

On Fri, Aug 11, 2017 at 6:53 PM, Marek Olšák wrote: > On Tue, Aug 8, 2017 at 6:57 PM, Samuel Pitoiset > wrote: >> Using VRAM address as bindless handles is not a good idea because >> we have to use LLVMIntToPTr and the LLVM CSE pass can't optimize >>

Re: [Mesa-dev] [PATCH 2/2] i965: Guard GetBufferSubData's streaming memcpy load with USE_SSE41

On Thursday, August 10, 2017 11:50:30 PM PDT Tapani Pälli wrote: > I do wonder what the target machine is (I haven't seen one that would > not have ARCH_X86_HAVE_SSE4_1 true, both 32bit and 64bit) but falling > back to memcpy makes perfect sense without USE_SSE4_1; > > Reviewed-by: Tapani Pälli

Re: [Mesa-dev] [PATCH v2] gallium/util: add new module that allocate "numbers"

On Fri, Aug 11, 2017 at 10:55 AM, Samuel Pitoiset wrote: > Will be used for allocating bindless descriptor slots for > RadeonSI. > > v2 - change the interface (remove lock/unlock) >- make a non-inline implementation > > Signed-off-by: Samuel Pitoiset

Re: [Mesa-dev] [PATCH] i965/blorp: Correct type of src_format in call to intel_miptree_texture_aux_usage

Jason Ekstrand writes: > oof... Have you run this through Jenkins? It should be ok, but > it will be a functional change. It's a good change, but it is a > change. I ran the patch through jenkins, where the only problem it reported was a gpu hang on skl gt2 in:

Re: [Mesa-dev] [Mesa-stable] [PATCH] radeonsi: update non-resident bindless descriptors if needed

Reviewed-by: Marek Olšák Marek On Wed, Aug 9, 2017 at 3:47 PM, Samuel Pitoiset wrote: > Only resident bindless descriptors are currently updated and > re-uploaded, this makes sure that the non-resident ones are > also updated. > > Signed-off-by:

Re: [Mesa-dev] [PATCH 1/2] st/omx_tizonia: add --enable-omx-tizonia flag and build files

On 11 August 2017 at 13:54, Christian König wrote: > Am 11.08.2017 um 14:32 schrieb Emil Velikov: >> >> Hi Gurkirpal, >> >> Thanks for working on this. I believe Christian has some good points. >> There's only one small question + suggestion from me. >> >> On 11 August

Re: [Mesa-dev] [PATCH 1/2] st/omx_tizonia: add --enable-omx-tizonia flag and build files

Am 11.08.2017 um 06:31 schrieb Gurkirpal Singh: Coexist with --enable-omx so they can be built independently Detect tizonia package config file Generate libomxtiz_mesa.so and install it to libtizcore.pc::pluginsdir Only compile empty source (target.c) for now. Really nice piece of work. Just a

Re: [Mesa-dev] [PATCH 1/2] i965: Clean up intel_batchbuffer_init().

heh I've just sent a patch that passes context (to get rid of container_of) but I can see that screen is enough, thanks for fixing this! Reviewed-by: Tapani Pälli On 08/11/2017 08:52 AM, Kenneth Graunke wrote: Passing screen lets us get the kernel features, devinfo,

Re: [Mesa-dev] [PATCH v2] egl/dri2: Allow modifiers to add FDs to imports

Hi, On 11 August 2017 at 08:39, Philipp Zabel wrote: > Nice, this makes sure that all planes up to the last modifier have fds > present. And since all fds are guaranteed to be present, the modifier > equality check in dri2_check_dma_buf_attribs also makes sure that there

Re: [Mesa-dev] [PATCH 2/2] i965: Guard GetBufferSubData's streaming memcpy load with USE_SSE41

I do wonder what the target machine is (I haven't seen one that would not have ARCH_X86_HAVE_SSE4_1 true, both 32bit and 64bit) but falling back to memcpy makes perfect sense without USE_SSE4_1; Reviewed-by: Tapani Pälli On 08/11/2017 08:52 AM, Kenneth Graunke wrote:

Re: [Mesa-dev] [PATCH] gallium/util: add new module that allocate "numbers"

On 08/09/2017 06:41 PM, Nicolai Hähnle wrote: On 08.08.2017 18:57, Samuel Pitoiset wrote: Will be used for allocating bindless descriptor slots for RadeonSI. Signed-off-by: Samuel Pitoiset --- src/gallium/auxiliary/Makefile.sources | 1 +

Re: [Mesa-dev] [PATCH v2] egl/dri2: Allow modifiers to add FDs to imports

On Wed, 2017-08-09 at 11:53 +0100, Daniel Stone wrote: > When using dmabuf import, make sure that the modifier is actually > allowed to add planes to the base format, as implied by the comment. > > Signed-off-by: Daniel Stone --- >  src/egl/drivers/dri2/egl_dri2.c | 38

[Mesa-dev] [PATCH] i965: refactor, remove usage of container_of macro

Remove usage that was introduced by commit 29ba502. This fixes crashes seen on Android that uses clang for compilation. See some earlier discussion on container_of: https://lists.freedesktop.org/archives/mesa-dev/2017-April/152247.html Signed-off-by: Tapani Pälli

Re: [Mesa-dev] [PATCH v3 1/6] radeonsi: declare new user SGPR indices for bindless samplers/images

On 08/10/2017 11:17 PM, Marek Olšák wrote: On Tue, Aug 8, 2017 at 6:57 PM, Samuel Pitoiset wrote: A new pair of user SGPR is needed for loading the bindless descriptors from shaders. Because the descriptors are global for all stages, there is no need to add

[Mesa-dev] [PATCH 1/2] glsl: add size of the program resource for later validation

Signed-off-by: Tapani Pälli --- src/compiler/glsl/linker.cpp | 32 ++-- src/mesa/main/mtypes.h | 1 + 2 files changed, 23 insertions(+), 10 deletions(-) (Alternatively, we could make add_program_resource a template function so we would

[Mesa-dev] [PATCH 2/2] mesa: add typesize validation to resource functions

This makes development/changes to program resource code more safe. Patch also makes helper functions static. Signed-off-by: Tapani Pälli --- src/mesa/main/shader_query.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH v2] gallium/util: add new module that allocate "numbers"

Will be used for allocating bindless descriptor slots for RadeonSI. v2 - change the interface (remove lock/unlock) - make a non-inline implementation Signed-off-by: Samuel Pitoiset --- src/gallium/auxiliary/Makefile.sources | 2 +

Re: [Mesa-dev] [PATCH v2] egl/dri2: Allow modifiers to add FDs to imports

LGTM, now existence of fd is checked foreach plane_n; Reviewed-by: Tapani Pälli On 08/09/2017 01:53 PM, Daniel Stone wrote: When using dmabuf import, make sure that the modifier is actually allowed to add planes to the base format, as implied by the comment.

Re: [Mesa-dev] [PATCH 2/2] i965: Guard GetBufferSubData's streaming memcpy load with USE_SSE41

Quoting Kenneth Graunke (2017-08-11 06:52:47) > This should hopefully fix build issues on 32-bit Android-x86. > > Cc: Mauro Rossi > Cc: Tapani Pälli > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102050 > --- >

Re: [Mesa-dev] [PATCH 1/2] st/omx_tizonia: add --enable-omx-tizonia flag and build files

Am 11.08.2017 um 14:32 schrieb Emil Velikov: Hi Gurkirpal, Thanks for working on this. I believe Christian has some good points. There's only one small question + suggestion from me. On 11 August 2017 at 05:31, Gurkirpal Singh wrote: +

Re: [Mesa-dev] [PATCH 2/2] st/omx_tizonia: Add AVC decoder

On 11 August 2017 at 05:31, Gurkirpal Singh wrote: > --- /dev/null > +++ b/src/gallium/state_trackers/omx_tizonia/entrypoint.c > @@ -0,0 +1,152 @@ > +/** > + * > + * Permission is hereby granted, free

Re: [Mesa-dev] [PATCH 2/2] mesa: add typesize validation to resource functions

On 11/08/17 17:45, Tapani Pälli wrote: This makes development/changes to program resource code more safe. Patch also makes helper functions static. Signed-off-by: Tapani Pälli --- src/mesa/main/shader_query.cpp | 3 ++- 1 file changed, 2 insertions(+), 1

Re: [Mesa-dev] [PATCH 1/2] i965: Clean up intel_batchbuffer_init().

Reviewed-by: Iago Toral Quiroga On Thu, 2017-08-10 at 22:52 -0700, Kenneth Graunke wrote: > Passing screen lets us get the kernel features, devinfo, and bufmgr, > without needing container_of. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102062 > Cc: Mauro Rossi

Re: [Mesa-dev] [PATCH 2/2] mesa: add typesize validation to resource functions

On 08/11/2017 01:02 PM, Timothy Arceri wrote: On 11/08/17 17:45, Tapani Pälli wrote: This makes development/changes to program resource code more safe. Patch also makes helper functions static. Signed-off-by: Tapani Pälli --- src/mesa/main/shader_query.cpp | 3

[Mesa-dev] [Bug 101851] [regression] libEGL_common.a undefined reference to '__gxx_personality_v0'

https://bugs.freedesktop.org/show_bug.cgi?id=101851 --- Comment #5 from Mike Lothian --- I'm seeing this with 17.2-rc2 even when passing -fuse-ld=bfd libtool: link: ( cd ".libs" && rm -f "libEGL_common.la" && ln -s "../libEGL_common.la" "libEGL_common.la" ) /bin/sh

Re: [Mesa-dev] [PATCH 2/2] mesa: add typesize validation to resource functions

On 08/11/2017 01:18 PM, Tapani Pälli wrote: On 08/11/2017 01:02 PM, Timothy Arceri wrote: On 11/08/17 17:45, Tapani Pälli wrote: This makes development/changes to program resource code more safe. Patch also makes helper functions static. Signed-off-by: Tapani Pälli

Re: [Mesa-dev] [PATCH 2/2] i965: Guard GetBufferSubData's streaming memcpy load with USE_SSE41

On Fri, Aug 11, 2017 at 8:52 AM, Kenneth Graunke wrote: > This should hopefully fix build issues on 32-bit Android-x86. > > Cc: Mauro Rossi > Cc: Tapani Pälli > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102050 >

Re: [Mesa-dev] [PATCH 2/2] i965: Guard GetBufferSubData's streaming memcpy load with USE_SSE41

On 11 August 2017 at 12:31, Tapani Pälli wrote: > On 08/11/2017 02:23 PM, Grazvydas Ignotas wrote: >> >> On Fri, Aug 11, 2017 at 8:52 AM, Kenneth Graunke >> wrote: >>> >>> This should hopefully fix build issues on 32-bit Android-x86. >>> >>> Cc:

[Mesa-dev] [Bug 102148] Crash when running qopenglwidget example on mesa llvmpipe win32

https://bugs.freedesktop.org/show_bug.cgi?id=102148 Bug ID: 102148 Summary: Crash when running qopenglwidget example on mesa llvmpipe win32 Product: Mesa Version: git Hardware: x86 (IA32) OS: Windows (All)

Re: [Mesa-dev] [PATCH 2/2] i965: Guard GetBufferSubData's streaming memcpy load with USE_SSE41

On 08/11/2017 02:23 PM, Grazvydas Ignotas wrote: On Fri, Aug 11, 2017 at 8:52 AM, Kenneth Graunke wrote: This should hopefully fix build issues on 32-bit Android-x86. Cc: Mauro Rossi Cc: Tapani Pälli Bugzilla:

Re: [Mesa-dev] [PATCH 1/2] st/omx_tizonia: add --enable-omx-tizonia flag and build files

Hi Gurkirpal, Thanks for working on this. I believe Christian has some good points. There's only one small question + suggestion from me. On 11 August 2017 at 05:31, Gurkirpal Singh wrote: > +PKG_CHECK_MODULES([OMX_TIZONIA], [libtizonia >= >

Re: [Mesa-dev] [PATCH 2/2] egl: Add dma_buf_import_modifiers for glvnd

On 31 July 2017 at 15:15, Daniel Stone wrote: > Make sure we advertise the new entrypoints to libglvnd's EGL dispatch. Anyone? Cheers, Daniel ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

[Mesa-dev] [Bug 101982] Weston crashes when running an OpenGL program on i965

https://bugs.freedesktop.org/show_bug.cgi?id=101982 --- Comment #9 from Daniel Stone --- (In reply to Link Mauve from comment #8) > When not using the opengl-hq profile of mpv, I get a much better error, I’m > still not sure why it doesn’t crash the compositor in this case,

Re: [Mesa-dev] [PATCH 1/2] i965: Clean up intel_batchbuffer_init().

On 11 August 2017 at 06:52, Kenneth Graunke wrote: > Passing screen lets us get the kernel features, devinfo, and bufmgr, > without needing container_of. > Hmm it seems to be crashing since sample (aka brw) cannot be NULL. Which seems to be the case here. Reviewed-by: Emil

Re: [Mesa-dev] [PATCH 09/13] i965/vec4: Return float from spill_cost_for_type()

Oops, sorry about that! Reviewed-by: Iago Toral Quiroga On Thu, 2017-08-10 at 18:02 -0400, Matt Turner wrote: > --- >  src/intel/compiler/brw_vec4_reg_allocate.cpp | 2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [Mesa-dev] [PATCH 2/2] st/mesa: fix CTS regression caused by fcbb93e86024

On 1 August 2017 at 08:35, Timothy Arceri wrote: > When generation the storage offset for struct members we need > to skip opaque types as they no longer have backing storage. > > Fixes: fcbb93e86024 ("mesa: stop assigning unused storage for non-bindless > opaque types") >

Re: [Mesa-dev] [Mesa-stable] [PATCH v2 2.5/5] radeonsi: make sure TCS main output VGPRs don't alias inputs

On Fri, Aug 11, 2017 at 10:40 PM, Emil Velikov wrote: > Hi Nicolai, > > It seems that the first two patches [1] in this series landed with the > stable tag. > While this patch alongside the remaining three [2] did not. > > Do we want the latter in stable as well or shall

Re: [Mesa-dev] [Mesa-stable] [PATCH v2 2.5/5] radeonsi: make sure TCS main output VGPRs don't alias inputs

Hi Nicolai, It seems that the first two patches [1] in this series landed with the stable tag. While this patch alongside the remaining three [2] did not. Do we want the latter in stable as well or shall we leave them out? Thanks Emil [1] 873789002f5 radeonsi/gfx9: fix vertex idx in ES with

Re: [Mesa-dev] [PATCH v2 1/5] i965/eu: add support for 1-OWord Block Read/Write messages

This series resolves https://bugs.freedesktop.org/show_bug.cgi?id=101985, currently blocking 17.2 release. Tested-by: Mark Janes Samuel Iglesias Gonsálvez writes: > v2: > - Use nibctrl and the number of written/read owords to detect > each case of

[Mesa-dev] [PATCH] android: amd/common: fix sid_tables.h generation rules

Current generation rules rely on LOCAL_PATH variable, which may be undefined when dependencies are expanded; move to using MESA_TOP variable to define sid_tables.py script path Fixes the following building error: external/mesa/src/gallium/drivers/radeonsi/si_debug.c:30:10: fatal error:

[Mesa-dev] [PATCH 00/10] dri3: Swapbuffer update v2

Implement back-to-fake-front flips, Fix EGL_BUFFER_PRESERVED path. Implement dri3 support for GLX_SWAP_EXCHANGE_OML and GLX_SWAP_COPY_OML. The back-to-fake-front flips will save a full buffer copy in the case of a fake front being enabled and GLX_SWAP_UNDEFINED_OML. Support for

[Mesa-dev] [PATCH 02/11] loader/dri3: Make sure we always have a context for image blit operations

The code was relying on us always having a current context for client local image blit operations. Otherwise the blit would be skipped. However, glxSwapBuffers, for example, doesn't require a current context and that was a common problem in the dri1 era. It seems the problem has resurfaced with

[Mesa-dev] [PATCH 03/11] glx: Notify the dri3 loader if we are about destroy a dri screen

This gives the dri3 loader a chance to clean up the blit context cache. Signed-off-by: Thomas Hellstrom --- src/glx/dri3_glx.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/glx/dri3_glx.c b/src/glx/dri3_glx.c index dc94740..b79fec7 100644 ---

[Mesa-dev] [PATCH 09/11] loader_dri3: Eliminate the back-to-fake-front copy

Eliminate the back-to-fake-front copy by exchanging the previous back buffer and the fake front buffer. This is a gain except when we need to preserve the back buffer content but in that case we still typically gain by replacing a server-side blit by a client side non-flushing blit.

[Mesa-dev] [PATCH 07/11] loader_dri3: Support GLX_SWAP_COPY_OML

Support the GLX_SWAP_COPY_OML method. When this method is requested, we use the same swapbuffer code path as EGL_BUFFER_PRESERVED. Signed-off-by: Thomas Hellstrom --- src/loader/loader_dri3_helper.c | 9 - src/loader/loader_dri3_helper.h | 1 + 2 files changed, 9

[Mesa-dev] [PATCH 08/11] loader_dri3: Remove buffer_type from buffer metadata

It's not used anywhere and now that we're about to exchange back- and fake fronts it doesn't serve a purpose. Signed-off-by: Thomas Hellstrom --- src/loader/loader_dri3_helper.c | 2 -- src/loader/loader_dri3_helper.h | 2 -- 2 files changed, 4 deletions(-) diff --git

[Mesa-dev] [PATCH 06/11] loader_dri3: Honour the request to preserve back buffer content

EGL uses the force_copy parameter to loader_dri3_swap_buffers_msc() to indicate that it wants to preserve back buffer contents across a buffer swap. While the loader then turns off server-side page-flipping there's nothing to guarantee that a new backbuffer isn't chosen when EGL starts to render

Re: [Mesa-dev] [PATCH 3/3] gallium/radeon: pass LLVM processor to the disk shader cache

On Fri, Aug 11, 2017 at 6:00 PM, Nicolai Hähnle wrote: > On 10.08.2017 21:57, Marek Olšák wrote: >> >> From: Marek Olšák >> >> --- >> src/gallium/drivers/radeon/r600_pipe_common.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff

Re: [Mesa-dev] [PATCH] android: amd/common: fix sid_tables.h generation rules

On Fri, Aug 11, 2017 at 10:10 AM, Mauro Rossi wrote: > 2017-08-11 16:23 GMT+02:00 Rob Herring : >> On Fri, Aug 11, 2017 at 9:02 AM, Mauro Rossi wrote: >>> Current generation rules rely on LOCAL_PATH variable, >>> which may be

[Mesa-dev] [PATCH 04/11] egl/x11_dri3: Notify the dri3 loader when we're about to close a screen

This gives the dri3 loader a chance to clean up the blit context cache. Signed-off-by: Thomas Hellstrom --- src/egl/drivers/dri2/egl_dri2.c | 5 - src/egl/drivers/dri2/egl_dri2.h | 2 ++ src/egl/drivers/dri2/platform_x11_dri3.c | 9 + 3 files

[Mesa-dev] [PATCH 11/11] loader_dri3: Make sure we have an updated back

With GLX_SWAP_COPY_OML and GLX_SWAP_EXCHANGE_OML it may happen in situations when glXSwapBuffers() is immediately followed by for example another glXSwapBuffers() or glXCopyBuffers() or back buffer age querying, that we haven't yet allocated and initialized a new back buffer because there was no

[Mesa-dev] [PATCH 10/11] loader_dri3: Support GLX_SWAP_EXCHANGE_OML

Add support for the exchange swap method. Since we're now forcing a fake front buffer and we exchange the back and fake front on swaps, we don't need to add much code. Signed-off-by: Thomas Hellstrom --- src/loader/loader_dri3_helper.c | 8 +--- 1 file changed, 5

Re: [Mesa-dev] [PATCH] android: amd/common: fix sid_tables.h generation rules

2017-08-11 16:23 GMT+02:00 Rob Herring : > On Fri, Aug 11, 2017 at 9:02 AM, Mauro Rossi wrote: >> Current generation rules rely on LOCAL_PATH variable, >> which may be undefined when dependencies are expanded; >> move to using MESA_TOP variable to define

Re: [Mesa-dev] [PATCH v3 4/6] radeonsi: add si_emit_global_shader_pointers() helper

Reviewed-by: Marek Olšák Marek On Tue, Aug 8, 2017 at 6:57 PM, Samuel Pitoiset wrote: > To share common code between rw buffers and bindless descriptors. > > v3: - rename to si_emit_global_shader_pointers() > > Signed-off-by: Samuel Pitoiset

Re: [Mesa-dev] [PATCH] android: amd/common: fix sid_tables.h generation rules

On Fri, Aug 11, 2017 at 9:02 AM, Mauro Rossi wrote: > Current generation rules rely on LOCAL_PATH variable, > which may be undefined when dependencies are expanded; > move to using MESA_TOP variable to define sid_tables.py script path I count roughly 67 occurrences of

Re: [Mesa-dev] [PATCH libdrm] tests/amdgpu: add uvd encode unit tests

On Thu, Aug 10, 2017 at 2:02 PM, wrote: > From: Boyuan Zhang > > Signed-off-by: Boyuan Zhang Acked-by: Alex Deucher > --- > tests/amdgpu/Makefile.am | 1 + > tests/amdgpu/amdgpu_test.c |