From: Stephen Hemminger [EMAIL PROTECTED]
Date: Tue, 6 Jun 2006 11:53:06 -0700
I cleaned these up and put them in a git tree.
All 4 patches are in my tree now.
Thanks Stephen.
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More
Quoting David Miller:
|
| Fix: Move the `UDP_INC_STATS_BH(UDP_MIB_INDATAGRAMS)' statement from
| udp_queue_rcv_skb to udp_recvmsg. Now InDatagrams only counts those
| datagrams which were really delivered (as per RFC 2013).
|
|
| Unfortunately this breaks NFS and
From: Gerrit Renker [EMAIL PROTECTED]
Date: Mon, 12 Jun 2006 07:02:45 +0100
This is clearly preferable - would it look like this:
csum_copy_err:
UDP_INC_STATS_BH(UDP_MIB_INERRORS);
UDP_DEC_STATS_BH(UDP_MIB_INDATAGRAMS); /* requires new macro */
skb_kill_datagram(sk, skb,
David Miller [EMAIL PROTECTED] wrote:
Probably a better way to handle this is to correct the
INDATAGRAMS value by decrementing it when we notice that
the checksum is incorrect in a deferred manner.
I think sunrpc should instead increment the appropriate counters directly
as otherwise
On Sun, Jun 11, 2006 at 06:40:54PM -0400, Dave Jones wrote:
Ah-ha, I had tested the wrong card.
I also have a Sitecom card, which matches this ident you remove in your
patch..
PCMCIA_DEVICE_MANF_CARD(0xd601, 0x0002), /* Safeway 802.11b, ZCOMAX
AirRunner/XI-300 */
snip
So with your
* Herbert Xu [EMAIL PROTECTED] wrote:
On Tue, Jun 06, 2006 at 04:39:21PM +, Stefan Richter wrote:
BTW, the locking in -mm's net/unix/af_unix.c::unix_stream_connect()
differs a bit from stock unix_stream_connect(). I see spin_lock_bh() in
2.6.17-rc5-mm3 where 2.6.17-rc5 has
On Mon, Jun 12, 2006 at 08:38:07AM +0200, Ingo Molnar wrote:
yeah. I'll investigate - it's quite likely that sk_receive_queue.lock
will have to get per-address family locking rules - right?
Yes that's the issue.
Maybe it's enough to introduce a separate key for AF_UNIX alone (and
still
From: Herbert Xu [EMAIL PROTECTED]
Date: Mon, 12 Jun 2006 16:18:09 +1000
David Miller [EMAIL PROTECTED] wrote:
Probably a better way to handle this is to correct the
INDATAGRAMS value by decrementing it when we notice that
the checksum is incorrect in a deferred manner.
I think
From: Ingo Molnar [EMAIL PROTECTED]
Date: Mon, 12 Jun 2006 08:38:07 +0200
yeah. I'll investigate - it's quite likely that sk_receive_queue.lock
will have to get per-address family locking rules - right?
That's right.
Maybe it's enough to introduce a separate key for AF_UNIX alone (and
* Herbert Xu [EMAIL PROTECTED] wrote:
Maybe it's enough to introduce a separate key for AF_UNIX alone (and
still having all other protocols share the locking rules for
sk_receive_queue.lock) , by reinitializing its spinlock after
sock_init_data()?
This could work. AF_UNIX is
On Mon, Jun 12, 2006 at 08:57:01AM +0200, Ingo Molnar wrote:
regarding your point wrt. path of integration - it is pretty much the
only practical way to do this centrally as part of the lock validator
patches, but to collect ACKs from subsystem maintainers in the process.
So if you like it
From: Herbert Xu [EMAIL PROTECTED]
Date: Mon, 12 Jun 2006 17:03:56 +1000
On Mon, Jun 12, 2006 at 08:57:01AM +0200, Ingo Molnar wrote:
regarding your point wrt. path of integration - it is pretty much the
only practical way to do this centrally as part of the lock validator
patches, but
The code below implements the discussed solution of decrementing
InDatagrams if a datagram fails the checksum within udp_recvmsg().
I have given it a quick test / build and checked the outcome against
previous results: I now obtained correct counter values, i.e. the application
counted exactly
John Rose wrote:
+#define EHEA_MEM_START 0xc000
You probably don't want to hardcode this. Maybe KERNELBASE from page.h?
Yes, we want to use KERNELBASE
+
+int ehea_reg_mr_adapter(struct ehea_adapter *adapter)
+{
+ }
This creates DMA mappings for the entirety of kernel
On Sun, Jun 11, 2006 at 11:49:05PM -0700, David Miller wrote:
Yeah. Good point. But how much protocol internals do we want to
slide into the -data_ready() callbacks of such layers? That's ugly
and something we should try to avoid.
I agree with the objective of minimising the exposure of
On Mon, 2006-06-12 at 15:24 +0800, Wei Dong wrote:
Also, when kernel receives an IP packet and need to forward, but
TTL=1 or TTL=0, kernel just sends an ICMP packet to inform the
sender TTL count exceeded, and doesn't increase this counter.
This part of your change seems correct, please
* Ingo Molnar [EMAIL PROTECTED] wrote:
(the #ifdef LOCKDEP should probably be converted to some sort of
lockdep_split_lock_key(sk-sk_receive_queue.lock) op - i'll do that
later)
i've added such an op, lockdep_reinit_lock_key() - this makes the patch
cleaner:
--
On 12/06/06 01:30, Francois Romieu wrote:
The patch below agaisnt 2.6.17-rc6 includes the following changes:
Just FYI:
I just tried this patch set, but it doesn't do anything for the freeze
at high speed I mentioned on 2006-06-09. It still locks up. (As an
additional data point: I installed
Hi John,
Please queue this for 2.6.18.
--
Suspend MAC (and make MAC-suspend refcounting) when doing
long periodic work.
On long periodic work, we disable IRQs on the device, so
we don't want the MAC to stay operating and probably miss
packets due do non-delivery of interrupts.
Signed-off-by:
On Mon, Jun 12, 2006 at 01:49:54AM +0300, Faidon Liambotis wrote:
Having two drivers supporting the same set of hardware seems pretty
pointless to me. Plus, it confuses hotplugging/automatic detection.
This subject comes-up from time to time. In fact, I'm pretty sure
it came-up very recently
On Mon, Jun 12, 2006 at 11:40:29AM -0400, Neil Horman wrote:
Hey there-
the netpoll system currently has a rx to tx path via:
netpoll_rx
__netpoll_rx
arp_reply
netpoll_send_skb
dev-hard_start_tx
This rx-tx loop places network drivers at risk of
inadvertently
Andi Kleen wrote:
On Friday 09 June 2006 17:24, Mark Lord wrote:
Andi Kleen wrote:
If your laptop has firewire you can also use firescope.
(ftp://ftp.suse.com/pub/people/ak/firescope/)
..
FW keeps running as long as nobody resets the ieee1394 chip.
This looks interesting. But how does one
On Monday 12 June 2006 17:38, Mark Lord wrote:
Andi Kleen wrote:
On Friday 09 June 2006 17:24, Mark Lord wrote:
Andi Kleen wrote:
If your laptop has firewire you can also use firescope.
(ftp://ftp.suse.com/pub/people/ak/firescope/)
..
FW keeps running as long as nobody resets the
On Mon, 12 Jun 2006 19:50:22 +0200 Krzysztof Halasa wrote:
Hi,
Randy.Dunlap [EMAIL PROTECTED] writes:
Priority: tossup.
netdev-set_config can be called at any time, so these references
to __initdata would be a real problem.
However, problem has not been observed AFAIK.
Fix
On Mon, Jun 12, 2006 at 09:42:14AM -0700, Mitch Williams wrote:
On Sun, 2006-06-11 at 17:13 -0700, Neil Horman wrote:
Any further thoughts on this guys? I still think my last solution
solves all of
the netpoll problems, and isn't going to have any noticable impact on
performance.
I
Andrew, thanks for the review, comments inline...
On Thu, 2006-06-08 at 00:54 -0700, Andrew Morton wrote:
On Wed, 07 Jun 2006 15:06:05 -0500
Steve Wise [EMAIL PROTECTED] wrote:
This patch provides the new files implementing the iWARP Connection
Manager.
Review Changes:
-
On Thu, 2006-06-08 at 01:17 -0700, Andrew Morton wrote:
On Wed, 07 Jun 2006 15:06:55 -0500
Steve Wise [EMAIL PROTECTED] wrote:
+void c2_free(struct c2_alloc *alloc, u32 obj)
+{
+ spin_lock(alloc-lock);
+ clear_bit(obj, alloc-table);
+ spin_unlock(alloc-lock);
+}
The
On Mon, Jun 12, 2006 at 11:24:39AM -0400, John W. Linville wrote:
On Mon, Jun 12, 2006 at 01:49:54AM +0300, Faidon Liambotis wrote:
Having two drivers supporting the same set of hardware seems pretty
pointless to me. Plus, it confuses hotplugging/automatic detection.
This subject
Mourad De Clerck [EMAIL PROTECTED] :
[...]
I just tried this patch set, but it doesn't do anything for the freeze
at high speed I mentioned on 2006-06-09. It still locks up. (As an
additional data point: I installed win2k on this machine, and it seems
to have no problems transferring at high
Randy.Dunlap [EMAIL PROTECTED] writes:
static const char* version = SDLA driver v0.30, 12 Sep 1996,
[EMAIL PROTECTED];
1996 doesn't look encouraging but it may be misleading.
Yep. You could ignore it :) or rm drivers/net/wan/slda* :)
I don't know, maybe Mike will say something?
--
TX and RX handlers are allowed to change skb. Fix (hopefully) the last place
where this is not taken into account.
Signed-off-by: Jiri Benc [EMAIL PROTECTED]
---
net/d80211/ieee80211.c |1 +
1 files changed, 1 insertion(+)
--- dscape.orig/net/d80211/ieee80211.c
+++
If a driver needs to find out if the fragment it is supposed to pass to the
hardware is the first fragment, the only way to do this is to check if
a Fragment Number part of seq_ctrl field in the frame header equals to 0.
Let's make it easier.
Signed-off-by: Jiri Benc [EMAIL PROTECTED]
---
This is an attempt to fix bcm43xx driver. It is for DMA mode only and
incomplete even for that mode - ieee80211_hw-tx() callback should return
NETDEV_TX_* constants which is not completely fixed by this patch.
---
drivers/net/wireless/d80211/bcm43xx/bcm43xx_dma.c |6 +-
Following patches allow proper handling of situation when hw queue gets
filled up while sending 802.11 fragments.
This breaks drivers; an example how to fix them is in second patch. Also,
get_tx_stats callback is optional now.
--
Jiri Benc
SUSE Labs
-
To unsubscribe from this list: send the
When the queue gets filled up while sending fragments, do not discard the
frame.
Partially sent frames are stored in a buffer in ieee80211_local (there is
place for one frame for each queue there). When the space in hw queue gets
available again, stored frame for that queue is sent first.
Also,
On Mon, Jun 12, 2006 at 10:51:21AM -0500, Matt Mackall wrote:
On Mon, Jun 12, 2006 at 11:40:29AM -0400, Neil Horman wrote:
Hey there-
the netpoll system currently has a rx to tx path via:
netpoll_rx
__netpoll_rx
arp_reply
netpoll_send_skb
dev-hard_start_tx
Currently, before a packet is passed to the driver, the driver is asked
about status of its TX queues (i.e. how many packets are queued in each
queue and how large are queues).
This is different from the way generic networking works in Linux and it
doesn't allow easy implementation of
Most user don't want their kern.log/dmesg filled with
debugging gibberish, and could turn it on if prompted.
( Example:
wifi0: TXEXC - status=0x0004 ([Discon]) tx_control=000c
retry_count=0 tx_rate=0 fc=0x0108 (Data::0 ToDS)
A1=00:0f:66:43:d7:0a A2=00:05:3c:06:63:01 A3=33:33:00:00:00:16
On Thu, 8 Jun 2006 09:49:07 +0200 (CEST), Jiri Benc wrote:
ieee80211_local has a separate class_device. That means it has reference
counting independent of master net_device and can be freed at a different
time, therefore these two structures cannot be allocated together.
Solve this by
On Monday 12 June 2006 21:16, Jiri Benc wrote:
This makes fragmentation work with bcm43xx.
Signed-off-by: Jiri Benc [EMAIL PROTECTED]
Signed-off-by: Michael Buesch [EMAIL PROTECTED]
The other patch will get my sign-off tomorrow (I think modified, though).
I don't have time to look at it more
On Mon, Jun 12, 2006 at 09:35:23PM +0200, Jiri Benc wrote:
On Thu, 8 Jun 2006 09:49:07 +0200 (CEST), Jiri Benc wrote:
ieee80211_local has a separate class_device. That means it has reference
counting independent of master net_device and can be freed at a different
time, therefore these two
From: Ingo Molnar [EMAIL PROTECTED]
Date: Mon, 12 Jun 2006 10:49:36 +0200
Subject: undo AF_UNIX _bh locking changes and split lock-type
From: Ingo Molnar [EMAIL PROTECTED]
this cleans up lock-validator-special-locking-af_unix.patch: instead
of adding _bh locking to AF_UNIX, this patch
On Mon, Jun 12, 2006 at 06:39:58PM +0300, Faidon Liambotis wrote:
FWIW, I think we've experienced a similar situation like this in the
past in the networking land and the consensus was to completely remove
the other driver. I'm referring to e100/eepro100, of course.
The difference with
Matt Mackall wrote:
On Thu, Jun 08, 2006 at 07:15:50PM -0700, Jeremy Fitzhardinge wrote:
Here's a patch. I haven't tested it beyond compiling it, and I don't
know if it is actually correct. In this case, it seems pointless to
spin waiting for an even which will never happen. Should
Andi Kleen wrote:
On Monday 12 June 2006 17:38, Mark Lord wrote:
Okay, so I'm daft. But.. *what* is it ??
We have two machines: target (being debugged), and host (anything).
Sure, the target has to have ohci1394 loaded, and firescope running.
But what about the *other* end of the
Matt Mackall wrote:
Ahh, right. I forgot that I'd done that. Can you resend?
I just respun it against 2.6.17-rc6-mm2.
J
--
Subject: netpoll: don't spin forever sending to blocked queues
When transmitting a skb in netpoll_send_skb(), only retry a limited
number of times if the device
Mourad De Clerck [EMAIL PROTECTED] :
[...]
I do notice a pattern with more and less complicated/cpu intensive
traffic: using http (wget) I manage to finish doing the transfer of the
same reasonably big file. With scp I only manage to get to 90% of that
file before it freezes - I should still
This patch updates sunrpc to use in-kernel sockets API.
Thanks
Sridhar
diff --git a/net/sunrpc/svcsock.c b/net/sunrpc/svcsock.c
index a27905a..ee80b3c 100644
--- a/net/sunrpc/svcsock.c
+++ b/net/sunrpc/svcsock.c
@@ -388,7 +388,7 @@ svc_sendto(struct svc_rqst *rqstp, struc
/* send head */
This patch makes it convenient to use the sockets API by the in-kernel
users like sunrpc, cifs ocfs2 etc and any future users.
Currently they get to this API by directly accesing the function pointers
in the sock structure.
Most of these functions are pretty simple and can be made inline and
On 6/12/06, John W. Linville [EMAIL PROTECTED] wrote:
On Mon, Jun 12, 2006 at 01:49:54AM +0300, Faidon Liambotis wrote:
Having two drivers supporting the same set of hardware seems pretty
pointless to me. Plus, it confuses hotplugging/automatic detection.
This subject comes-up from time to
Add a counter for packets dropped by firmware.
Signed-off-by: Michael Chan [EMAIL PROTECTED]
diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
index 7a1fb52..1a5f7a8 100644
--- a/drivers/net/bnx2.c
+++ b/drivers/net/bnx2.c
@@ -4034,6 +4034,8 @@ bnx2_timer(unsigned long data)
msg =
Allow WOL settings on 5708 B2 and newer chips that have the problem
fixed.
Signed-off-by: Michael Chan [EMAIL PROTECTED]
diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
index 1a5f7a8..49c09da 100644
--- a/drivers/net/bnx2.c
+++ b/drivers/net/bnx2.c
@@ -5642,7 +5642,9 @@
Add functions to decompress firmware before loading to the internal
CPUs. Compressing the firmware reduces the driver size significantly.
Signed-off-by: Michael Chan [EMAIL PROTECTED]
diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index bdaaad8..1fb0a19 100644
--- a/drivers/net/Kconfig
From: Michael Chan [EMAIL PROTECTED]
Date: Mon, 12 Jun 2006 17:17:18 -0700
Add functions to decompress firmware before loading to the internal
CPUs. Compressing the firmware reduces the driver size significantly.
Signed-off-by: Michael Chan [EMAIL PROTECTED]
...
+#define FNAME0x8
From: Michael Chan [EMAIL PROTECTED]
Date: Mon, 12 Jun 2006 17:17:22 -0700
Update driver version to 1.4.42.
Signed-off-by: Michael Chan [EMAIL PROTECTED]
I didn't get patch 5, I can only assume it was a huge firmware
patch and that both vger.kernel.org and my own personal email
system
Change bnx2_fw.h to use compressed data (5/6)
Signed-off-by: Michael Chan [EMAIL PROTECTED]
diff --git a/drivers/net/bnx2_fw.h b/drivers/net/bnx2_fw.h
index 99d2989..de0cac7 100644
--- a/drivers/net/bnx2_fw.h
+++ b/drivers/net/bnx2_fw.h
@@ -1330,201 +1330,199 @@ static const u32
Change bnx2_fw.h to use compressed data (3/6)
Signed-off-by: Michael Chan [EMAIL PROTECTED]
diff --git a/drivers/net/bnx2_fw.h b/drivers/net/bnx2_fw.h
index c0e8d55..05e0294 100644
--- a/drivers/net/bnx2_fw.h
+++ b/drivers/net/bnx2_fw.h
@@ -1057,130 +1057,84 @@ static u32
Change bnx2_fw.h to use compressed data (4/6)
Signed-off-by: Michael Chan [EMAIL PROTECTED]
diff --git a/drivers/net/bnx2_fw.h b/drivers/net/bnx2_fw.h
index 05e0294..99d2989 100644
--- a/drivers/net/bnx2_fw.h
+++ b/drivers/net/bnx2_fw.h
@@ -1136,262 +1136,185 @@ static u8 bnx2_rv2p_proc1[] = {
On Mon, 12 Jun 2006, Sridhar Samudrala wrote:
- sendpage = sock-ops-sendpage ? : sock_no_sendpage;
+ sendpage = kernel_sendpage ? : sock_no_sendpage;
This is not equivalent.
--
James Morris
[EMAIL PROTECTED]
-
To unsubscribe from this list: send the line unsubscribe netdev in
the
On Monday 12 June 2006 23:25, Jeremy Fitzhardinge wrote:
Andi Kleen wrote:
On Monday 12 June 2006 17:38, Mark Lord wrote:
Okay, so I'm daft. But.. *what* is it ??
We have two machines: target (being debugged), and host (anything).
Sure, the target has to have ohci1394 loaded, and
On 12/06/06 17:10 -0700, Jesse Brandeburg wrote:
On 6/12/06, John W. Linville [EMAIL PROTECTED] wrote:
On Mon, Jun 12, 2006 at 01:49:54AM +0300, Faidon Liambotis wrote:
Having two drivers supporting the same set of hardware seems pretty
pointless to me. Plus, it confuses
Stephen Hemminger wrote:
my problem is that for my prism 2 adapter both drivers are loaded at
which point neither of them works. I'm running FC5, and i have to
keep removing the orinoco*.ko files to keep them from loading, so I'm
all for this patch.
use blacklist in module config to block
James Morris wrote:
On Mon, 12 Jun 2006, Sridhar Samudrala wrote:
- sendpage = sock-ops-sendpage ? : sock_no_sendpage;
+ sendpage = kernel_sendpage ? : sock_no_sendpage;
This is not equivalent.
Actually, we could make this a simple assignment as we check for
The resume bug was cause not by an early interrupt but because
the idle timeout was not being stopped on suspend. Also disable hardware
IRQ's on suspend. Will need to revisit this when wake-on-lan is added.
Patch against 2.6.17-rc latest which includes Linus's attempt at
fixing this.
From: Andi Kleen [EMAIL PROTECTED]
Date: Tue, 13 Jun 2006 05:47:49 +0200
I've been playing with the idea of writing early1394 that just
turns the DMA controller on as early as possible similar to earlyprintk
on the target. Then it would be possible to use it for early
debugging too. But so
Michael, you just sent out what appears to be 6 copies of the
bnx2_fw.h patch :-) I think your patch sending script messed
something up.
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
Stephen Hemminger wrote:
@@ -2183,9 +2190,6 @@ static int sky2_poll(struct net_device *
int work_done = 0;
u32 status = sky2_read32(hw, B0_Y2_SP_EISR);
- if (!~status)
- return 0;
-
if (status Y2_IS_HW_ERR)
sky2_hw_intr(hw);
It's
On Tuesday 13 June 2006 06:49, David Miller wrote:
From: Andi Kleen [EMAIL PROTECTED]
Date: Tue, 13 Jun 2006 05:47:49 +0200
I've been playing with the idea of writing early1394 that just
turns the DMA controller on as early as possible similar to earlyprintk
on the target. Then it would
From: Andi Kleen [EMAIL PROTECTED]
Date: Tue, 13 Jun 2006 06:54:14 +0200
I guess if you use 1394 with remote DMA for other protocols (like
video etc.) there must be some way for the subsystem to map
the memory even on IOMMU systems. I admit I haven't dived that
deeply into the 1394 subsystem
On Mon, 12 Jun 2006 16:56:01 -0700
Sridhar Samudrala [EMAIL PROTECTED] wrote:
This patch makes it convenient to use the sockets API by the in-kernel
users like sunrpc, cifs ocfs2 etc and any future users.
Currently they get to this API by directly accesing the function pointers
in the sock
From: Michael Chan [EMAIL PROTECTED]
Date: Mon, 12 Jun 2006 17:17:03 -0700
Add a counter for packets dropped by firmware.
Signed-off-by: Michael Chan [EMAIL PROTECTED]
Applied to net-2.6.18, thanks.
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to
From: Michael Chan [EMAIL PROTECTED]
Date: Mon, 12 Jun 2006 17:17:08 -0700
Allow WOL settings on 5708 B2 and newer chips that have the problem
fixed.
Signed-off-by: Michael Chan [EMAIL PROTECTED]
Applied to net-2.6.18, thanks.
-
To unsubscribe from this list: send the line unsubscribe
From: Michael Chan [EMAIL PROTECTED]
Date: Mon, 12 Jun 2006 17:17:13 -0700
Use CPU native page size to determine various ring sizes. This allows
order-0 memory allocations on all systems.
Signed-off-by: Michael Chan [EMAIL PROTECTED]
Are you sure you want to do this when the base page size
From: Michael Chan [EMAIL PROTECTED]
Date: Mon, 12 Jun 2006 18:42:29 -0700
On Mon, 2006-06-12 at 17:38 -0700, David Miller wrote:
From: Michael Chan [EMAIL PROTECTED]
Date: Mon, 12 Jun 2006 17:17:18 -0700
Add functions to decompress firmware before loading to the internal
CPUs.
Applied the firmware update patch, thanks a lot.
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Michael Chan [EMAIL PROTECTED]
Date: Mon, 12 Jun 2006 17:17:22 -0700
Update driver version to 1.4.42.
Signed-off-by: Michael Chan [EMAIL PROTECTED]
I'll apply this once we decide what is going to happen
with the BCM_PAGE_BITS change.
-
To unsubscribe from this list: send the line
Hi all,
I have recently run into the issue where connect() returns -EAGAIN
if the remote host is on the other end of an IPsec tunnel for which no
SAD exists yet.
I have read a few threads on the topic, and it seems that the idea is to
implement a scheme similar to ARP for queueing outgoing
77 matches
Mail list logo
