Re:[PATCH]Fix BUG of ip_rt_send_redirect()

2006-12-05 Thread Li Yewang
Herbert Xu [EMAIL PROTECTED] wrote: I think there are two problems here: 1)The first time we hit the check rate_last is zero. We should simply proceed with the redirect rather than treating this as a jiffies value. 2)When a dst is so old that the jiffies have wrapped around. I'm not sure

Re: dm-crypt changes in git-net tree

2006-12-05 Thread Herbert Xu
On Mon, Dec 04, 2006 at 10:59:07PM -0800, Andrew Morton wrote: On x86_64: drivers/md/dm-crypt.c: In function 'crypt_iv_benbi_ctr': drivers/md/dm-crypt.c:235: warning: cast to pointer from integer of different size drivers/md/dm-crypt.c: In function 'crypt_iv_benbi_gen':

Re: NETDEV-BCM43XX BUG - Failure to associate AP with latest devscape git pull..

2006-12-05 Thread Johannes Berg
On Mon, 2006-12-04 at 13:17 -0500, Robert Martin wrote: 03:00.0 0280: 14e4:4311 (rev 01) 4311 is pci-e though, iirc. Linux just shows pci-e like pci devices. Capabilities: [d0] Express Legacy Endpoint IRQ 0 Device: Supported: MaxPayload 128 bytes, PhantFunc 0,

[PATCH 2.6.20] [IPV6]: Repair IPv6 Fragments

2006-12-05 Thread YOSHIFUJI Hideaki / 吉藤英明
Hello. The commit [IPV6]: Use kmemdup (commit-id: af879cc704372ef762584e916129d19ffb39e844) broke IPv6 fragments. Bug was spotted by Yasuyuki Kozakai [EMAIL PROTECTED]. Signed-off-by: YOSHIFUJI Hideaki [EMAIL PROTECTED] -- diff --git a/net/ipv6/ip6_output.c b/net/ipv6/ip6_output.c index

TCP dynamic system

2006-12-05 Thread Sebastian Krahmer
Hi, Does anyone know a good book on the nature of TCP? Means, how does all the algorithms (Nagle, ...) delayed, quick, opt-ack, winodw-size, MSS etc. affect the thruput and so on? Something that explains (hopefully as good as TCP Illustrated) which parameters cause what effects. There are some

[PATCH 1/2] [IPV6] RAW: Don't release unlocked sock.

2006-12-05 Thread Masahide NAKAMURA
When user builds IPv6 header and send it through raw socket, kernel tries to release unlocked sock. (Kernel log shows BUG: bad unlock balance detected with enabled debug option.) The lock is held only for non-hdrincl sock in this function then this patch fix to do nothing about lock for hdrincl

[PATCH 2/2] [IPV6] RAW: Add checksum default defines for mobility header.

2006-12-05 Thread Masahide NAKAMURA
Add checksum default defines for mobility header(MH). As the result kernel's behavior is to handle MH checksum as default. Signed-off-by: Masahide NAKAMURA [EMAIL PROTECTED] --- net/ipv6/raw.c | 15 +-- 1 files changed, 13 insertions(+), 2 deletions(-) diff --git a/net/ipv6/raw.c

[PATCH 0/7] iproute2: 2.6.19 updates and Mobile IPv6 support for ip command

2006-12-05 Thread Masahide NAKAMURA
Hello, These are iproute2 updates: o Kernel header updates for 2.6.19 o libnetlink header updates to fit with 2.6.19 kernel o Mobile IPv6 xfrm support for ip command Since I could not build with the define nor find it on the kernel tree, It also contains a patch which disable FIB_RULE_INVERT.

[PATCH 2/7] Add missing macros which was removed from kernel header.

2006-12-05 Thread Masahide NAKAMURA
{IFA,IFLA,NDA,NDTA}_{RTA,PAYLOAD} macro is removed from kernel header since linux-2.6.19 because it is not used by kernel code. Signed-off-by: Masahide NAKAMURA [EMAIL PROTECTED] --- include/libnetlink.h | 35 +++ 1 files changed, 35 insertions(+), 0

[PATCH 7/7] [IP] XFRM: Mobility header support.

2006-12-05 Thread Masahide NAKAMURA
Signed-off-by: Masahide NAKAMURA [EMAIL PROTECTED] --- ip/ipxfrm.c |9 + ip/xfrm.h |3 +++ 2 files changed, 12 insertions(+), 0 deletions(-) diff --git a/ip/ipxfrm.c b/ip/ipxfrm.c index 7c9fd0b..9c8b4bd 100644 --- a/ip/ipxfrm.c +++ b/ip/ipxfrm.c @@ -483,6 +483,14 @@ void

[PATCH 6/7] [IP] XFRM: support report message by monitor.

2006-12-05 Thread Masahide NAKAMURA
Signed-off-by: Masahide NAKAMURA [EMAIL PROTECTED] --- ip/xfrm.h |2 ++ ip/xfrm_monitor.c | 52 2 files changed, 54 insertions(+), 0 deletions(-) diff --git a/ip/xfrm.h b/ip/xfrm.h index 51ffa4b..d33ff94 100644 --- a/ip/xfrm.h

[PATCH 4/7] [IP] XFRM: sub policy support.

2006-12-05 Thread Masahide NAKAMURA
Signed-off-by: Masahide NAKAMURA [EMAIL PROTECTED] --- ip/ipxfrm.c | 27 ++ ip/xfrm.h|4 + ip/xfrm_policy.c | 150 -- 3 files changed, 164 insertions(+), 17 deletions(-) diff --git a/ip/ipxfrm.c b/ip/ipxfrm.c index

[PATCH 5/7] [IP] XFRM: Mobile IPv6 route optimization support.

2006-12-05 Thread Masahide NAKAMURA
To support Mobile IPv6 RO, the following extension is included: o Use XFRM_MODE_XXX macro instead of magic number o New attribute option for all state: source address for deleting or getting message o New attribute options for RO: care-of address, last-used timestamp and wild-receive flag

[PATCH 3/7] [IP] RULE: Add ifdef to FIB_RULE_INVERT since it is missing.

2006-12-05 Thread Masahide NAKAMURA
Signed-off-by: Masahide NAKAMURA [EMAIL PROTECTED] --- ip/iprule.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/ip/iprule.c b/ip/iprule.c index c584b18..1da64b8 100644 --- a/ip/iprule.c +++ b/ip/iprule.c @@ -83,8 +83,10 @@ int print_rule(const struct sockaddr_nl

Re: [PATCH 1/5] ipw2100: Make ipw2100 depends on known working platforms

2006-12-05 Thread Christoph Hellwig
On Tue, Dec 05, 2006 at 02:40:52PM +0800, Zhu Yi wrote: [ Resubmit, if you still don't like it, I'll drop. ] ipw2100 driver doesn't support big endian by now. Signed-off-by: Karol Lewandowski [EMAIL PROTECTED] Signed-off-by: Zhu Yi [EMAIL PROTECTED] ---

Re: [PATCH 1/7] Sync with 2.6.19 kernel header about include/linux.

2006-12-05 Thread Thomas Graf
* Masahide NAKAMURA [EMAIL PROTECTED] 2006-12-05 19:15 diff --git a/include/linux/fib_rules.h b/include/linux/fib_rules.h index 8270aac..4418c8d 100644 --- a/include/linux/fib_rules.h +++ b/include/linux/fib_rules.h @@ -6,7 +6,6 @@ #include linux/rtnetlink.h /* rule is permanent, and

Re: [PATCH 3/7] [IP] RULE: Add ifdef to FIB_RULE_INVERT since it is missing.

2006-12-05 Thread Thomas Graf
* Masahide NAKAMURA [EMAIL PROTECTED] 2006-12-05 19:15 Signed-off-by: Masahide NAKAMURA [EMAIL PROTECTED] --- ip/iprule.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/ip/iprule.c b/ip/iprule.c index c584b18..1da64b8 100644 --- a/ip/iprule.c +++

Re: [PATCH 2/2] [IPV6] RAW: Add checksum default defines for mobility header.

2006-12-05 Thread YOSHIFUJI Hideaki / 吉藤英明
In article [EMAIL PROTECTED] (at Tue, 5 Dec 2006 19:03:27 +0900), Masahide NAKAMURA [EMAIL PROTECTED] says: Add checksum default defines for mobility header(MH). As the result kernel's behavior is to handle MH checksum as default. I'd like to hold this on. I need to check RFC. --yoshfuji

Re: [PATCH 1/7] Sync with 2.6.19 kernel header about include/linux.

2006-12-05 Thread Masahide NAKAMURA
Thomas Graf wrote: * Masahide NAKAMURA [EMAIL PROTECTED] 2006-12-05 19:15 diff --git a/include/linux/fib_rules.h b/include/linux/fib_rules.h index 8270aac..4418c8d 100644 --- a/include/linux/fib_rules.h +++ b/include/linux/fib_rules.h @@ -6,7 +6,6 @@ #include linux/rtnetlink.h /* rule is

Re: [PATCH 1/7] Sync with 2.6.19 kernel header about include/linux.

2006-12-05 Thread Thomas Graf
* Masahide NAKAMURA [EMAIL PROTECTED] 2006-12-05 20:44 Thomas Graf wrote: * Masahide NAKAMURA [EMAIL PROTECTED] 2006-12-05 19:15 diff --git a/include/linux/fib_rules.h b/include/linux/fib_rules.h index 8270aac..4418c8d 100644 --- a/include/linux/fib_rules.h +++ b/include/linux/fib_rules.h

Re: [PATCH 1/7] Sync with 2.6.19 kernel header about include/linux.

2006-12-05 Thread Masahide NAKAMURA
Thomas Graf wrote: Why are you reverting this? I just update the header about include/linux without thinking. Should I have to update them except fib_rules.h? The iproute2 git tree already contains patches for the 2.6.20 release. OK, thanks. Can you know another patch which is already

[PATCH 2.6.19 1/4] AT91RM9200 Ethernet: Remove 'at91_dev' and use netdev_priv()

2006-12-05 Thread Andrew Victor
Remove the global 'at91_dev' variable. Use netdev_priv() instead of casting dev-priv directly. Signed-off-by: Andrew Victor [EMAIL PROTECTED] diff -urN linux-2.6.19-final.orig/drivers/net/arm/at91_ether.c linux-2.6.19-final/drivers/net/arm/at91_ether.c ---

[PATCH 2.6.19 2/4] AT91RM9200 Ethernet: Move check_timer variable and use mod_timer()

2006-12-05 Thread Andrew Victor
Move the global 'check_timer' variable into the private data structure. Also now use mod_timer(). Signed-off-by: Andrew Victor [EMAIL PROTECTED] diff -urN linux-2.6.19-final.orig/drivers/net/arm/at91_ether.c linux-2.6.19-final/drivers/net/arm/at91_ether.c ---

[PATCH 2.6.19 3/4] AT91RM9200 Ethernet: Add netpoll / netconsole support

2006-12-05 Thread Andrew Victor
Adds netpoll / netconsole support. Original patch from Bill Gatliff. Signed-off-by: Andrew Victor [EMAIL PROTECTED] diff -urN linux-2.6.19-final.orig/drivers/net/arm/at91_ether.c linux-2.6.19-final/drivers/net/arm/at91_ether.c --- linux-2.6.19-final.orig/drivers/net/arm/at91_ether.c

[PATCH 2.6.19 4/4] AT91RM9200 Ethernet: Use dev_alloc_skb()

2006-12-05 Thread Andrew Victor
Use dev_alloc_skb() instead of alloc_skb(). It is also not necessary to adjust skb-len manually since that's already done by skb_put(). Signed-off-by: Andrew Victor [EMAIL PROTECTED] diff -urN linux-2.6.19-final.orig/drivers/net/arm/at91_ether.c

Re: [Madwifi-devel] ar5k and Atheros AR5005G

2006-12-05 Thread Michael Renzmann
Hi all. To make things easier for development I'd like to suggest a few madwif ibranches created: * madwifi-1152-openhal: based on madwifi-1152, patched with my patch, added openhal, old hal removed. Working free solution. Should exist just as a reference and to allow users to checkout a

Re: [PATCH 2/2] [IPV6] RAW: Add checksum default defines for mobility header.

2006-12-05 Thread Brian Haley
YOSHIFUJI Hideaki / wrote: Add checksum default defines for mobility header(MH). As the result kernel's behavior is to handle MH checksum as default. I'd like to hold this on. I need to check RFC. That looks correct according to 3775. -Brian - To unsubscribe from this list: send the

Re: [Madwifi-devel] ar5k and Atheros AR5005G

2006-12-05 Thread Luis R. Rodriguez
On 12/5/06, Michael Renzmann [EMAIL PROTECTED] wrote: openhal here. I've set up the suggested branches, with slight changing to the proposed names: * http://svn.madwifi.org/branches/madwifi-old-openhal (based on r1142) * http://svn.madwifi.org/branches/dadwifi-openhal (based on r1827) Neither

Re: [PATCH 1/1] myri10ge: write as 2 32-byte blocks in myri10ge_submit_8rx

2006-12-05 Thread Brice Goglin
Jeff Garzik wrote: Brice Goglin wrote: In the myri10ge_submit_8rx() routine, write the 64 byte request block as 2 32-byte blocks so that it is handled by the hardware pio write handler if write-combining is enabled. Signed-off-by: Brice Goglin [EMAIL PROTECTED] ---

Re: [PATCH 2/2] [IPV6] RAW: Add checksum default defines for mobility header.

2006-12-05 Thread YOSHIFUJI Hideaki / 吉藤英明
In article [EMAIL PROTECTED] (at Tue, 05 Dec 2006 10:04:14 -0500), Brian Haley [EMAIL PROTECTED] says: YOSHIFUJI Hideaki wrote: Add checksum default defines for mobility header(MH). As the result kernel's behavior is to handle MH checksum as default. I'd like to hold this on. I need

[PATCH 1/1] myri10ge: write as 2 32-byte blocks in myri10ge_submit_8rx

2006-12-05 Thread Brice Goglin
In the myri10ge_submit_8rx() routine, write the 64 byte request block as 2 32-byte blocks so that it is handled by the hardware pio write handler if write-combining is enabled. Signed-off-by: Brice Goglin [EMAIL PROTECTED] --- drivers/net/myri10ge/myri10ge.c |4 +++- 1 file changed, 3

Re: [Madwifi-devel] ar5k and Atheros AR5005G

2006-12-05 Thread Stephen Hemminger
On Tue, 5 Dec 2006 10:15:33 -0500 Luis R. Rodriguez [EMAIL PROTECTED] wrote: On 12/5/06, Michael Renzmann [EMAIL PROTECTED] wrote: openhal here. I've set up the suggested branches, with slight changing to the proposed names: * http://svn.madwifi.org/branches/madwifi-old-openhal

[PATCH] Netlink: add a pointer to the Generic Netlink wiki page

2006-12-05 Thread paul . moore
From: Paul Moore [EMAIL PROTECTED] Add a pointer to the OSDL wiki page on Generic Netlink. Signed-off-by: Paul Moore [EMAIL PROTECTED] --- Documentation/networking/00-INDEX|2 ++ Documentation/networking/generic_netlink.txt |3 +++ 2 files changed, 5 insertions(+) Index:

Re: [PATCH 1/7] Sync with 2.6.19 kernel header about include/linux.

2006-12-05 Thread Stephen Hemminger
On Tue, 05 Dec 2006 21:27:08 +0900 Masahide NAKAMURA [EMAIL PROTECTED] wrote: Thomas Graf wrote: Why are you reverting this? I just update the header about include/linux without thinking. Should I have to update them except fib_rules.h? The iproute2 git tree already contains patches

generic LRO in the net core stack?

2006-12-05 Thread Brice Goglin
Hi, About 2 month ago, I sent a patchset to implement software LRO in myri10ge. People replied that it might be time to implement something generic in the net core stack instead since it was the second driver to do so. We completely agree with this. But, I haven't heard back from this idea since

Re: [PATCH 3/7] [IP] RULE: Add ifdef to FIB_RULE_INVERT since it is missing.

2006-12-05 Thread Stephen Hemminger
On Tue, 5 Dec 2006 11:42:31 +0100 Thomas Graf [EMAIL PROTECTED] wrote: * Masahide NAKAMURA [EMAIL PROTECTED] 2006-12-05 19:15 Signed-off-by: Masahide NAKAMURA [EMAIL PROTECTED] --- ip/iprule.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/ip/iprule.c

Re: [PATCH 7/7] [IP] XFRM: Mobility header support.

2006-12-05 Thread Stephen Hemminger
All 4 XFRM patches applied - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

iproute2 update

2006-12-05 Thread Stephen Hemminger
I am about to push out a new version, so if you have any more patches pending the window is about to close. Please retest with current git tree -- Stephen Hemminger [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED]

[PATCH] allow ip_tables.h to be used from userspace

2006-12-05 Thread Stephen Hemminger
The xtables version of ip_tables.h was no longer usable (in sanitized form) by iproute2 and other applications because sparse annotations had crept in. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- include/linux/netfilter_ipv4/ip_tables.h |4 ++-- net/ipv4/netfilter/ip_tables.c

Re: [PATCH] allow ip_tables.h to be used from userspace

2006-12-05 Thread Patrick McHardy
Stephen Hemminger wrote: The xtables version of ip_tables.h was no longer usable (in sanitized form) by iproute2 and other applications because sparse annotations had crept in. @@ -194,7 +194,7 @@ struct ipt_replace /* Number of counters (must be equal to current number of entries).

Re: iproute2 update

2006-12-05 Thread Patrick McHardy
Stephen Hemminger wrote: I am about to push out a new version, so if you have any more patches pending the window is about to close. I still have this one I would like to get in. [IPROUTE]: Add support for routing rule fwmark masks Needs kernel = 2.6.19. Signed-off-by: Patrick McHardy [EMAIL

Re: [PATCH] allow ip_tables.h to be used from userspace

2006-12-05 Thread Stephen Hemminger
On Tue, 05 Dec 2006 19:38:21 +0100 Patrick McHardy [EMAIL PROTECTED] wrote: Stephen Hemminger wrote: The xtables version of ip_tables.h was no longer usable (in sanitized form) by iproute2 and other applications because sparse annotations had crept in. @@ -194,7 +194,7 @@ struct

Re: [PATCH] allow ip_tables.h to be used from userspace

2006-12-05 Thread Patrick McHardy
Stephen Hemminger wrote: On Tue, 05 Dec 2006 19:38:21 +0100 Patrick McHardy [EMAIL PROTECTED] wrote: I think this regex should be fixed instead to get rid of it while sanitizing (Makefile.headersinst). But ip_tables.h should still put include of compiler.h inside #ifdef __KERNEL__

[PATCH 1/2] qla3xxx: Add support for Qlogic 4032 chip.

2006-12-05 Thread Ron Mercer
Signed-off-by: Ron Mercer [EMAIL PROTECTED] --- drivers/net/qla3xxx.c | 375 + drivers/net/qla3xxx.h | 92 +++- 2 files changed, 392 insertions(+), 75 deletions(-) diff --git a/drivers/net/qla3xxx.c b/drivers/net/qla3xxx.c index

[PATCH 2/2] qla3xxx: Change version to v2.03.00-k2.

2006-12-05 Thread Ron Mercer
Signed-off-by: Ron Mercer [EMAIL PROTECTED] --- drivers/net/qla3xxx.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/qla3xxx.c b/drivers/net/qla3xxx.c index c39f20d..ae65602 100644 --- a/drivers/net/qla3xxx.c +++ b/drivers/net/qla3xxx.c @@ -39,7 +39,7 @@

Re: [Madwifi-devel] ar5k and Atheros AR5005G

2006-12-05 Thread Luis R. Rodriguez
On 12/5/06, Stephen Hemminger [EMAIL PROTECTED] wrote: On Tue, 5 Dec 2006 10:15:33 -0500 Luis R. Rodriguez [EMAIL PROTECTED] wrote: On 12/5/06, Michael Renzmann [EMAIL PROTECTED] wrote: openhal here. I've set up the suggested branches, with slight changing to the proposed names: *

Re: [PATCH] chelsio 10G (T1/T2)

2006-12-05 Thread Stephen Hemminger
On Tue, 5 Dec 2006 10:53:10 -0800 Felix Marti [EMAIL PROTECTED] wrote: T1's and T2's implementation of MSI has a bug. I believe to remember that it works with some chipsets but we should disable MSI by default. Is this really the platform bug, if so it should be handled by the pci quirks

[PATCH] sky2: sparse warnings

2006-12-05 Thread Stephen Hemminger
Get rid of sparse warnings in sky2 driver because of mixed enum usage. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- drivers/net/sky2.c | 18 -- drivers/net/sky2.h | 53 +--- 2 files changed, 29 insertions(+), 42

[PATCH] skge: fix sparse warnings

2006-12-05 Thread Stephen Hemminger
Fix sparse warnings from using enum as part of arithmetic expression, and comment indentation fixes Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- drivers/net/skge.h | 150 ++-- 1 files changed, 75 insertions(+), 75 deletions(-) diff

[PATCH] netxen: sparse warning and ioctl bug fixes

2006-12-05 Thread Stephen Hemminger
Fix sparse warnings and get rid of casts that hide misuse of __user pointers. There were two real bugs here: * ioctl was copying uninitialized stack om NETXEN_NIC_NAME * ioctl was dereferencing a user pointer in nettxen_nic_cmd_clear_stats. IMHO the ioctl usage in this driver is going to

Re: [RFC patch] driver for the Opencores Ethernet Controller

2006-12-05 Thread Dan Nicolaescu
Stephen Hemminger [EMAIL PROTECTED] writes: Indentation. See Documentation style. What about IRQF_SHARED? Not sure, maybe I should make this another driver parameter. On my platform is not shared... The trouble with devices, is that some poor sop clones the

Re: dm-crypt changes in git-net tree

2006-12-05 Thread David Miller
From: Herbert Xu [EMAIL PROTECTED] Date: Tue, 5 Dec 2006 19:40:41 +1100 [CRYPTO] dm-crypt: Make iv_gen_private a union Rather than stuffing integers into pointers with casts, let's use a union. Signed-off-by: Herbert Xu [EMAIL PROTECTED] Applied, thanks. - To unsubscribe from this list:

Re: [PATCH 2/2] [IPV6] RAW: Add checksum default defines for mobility header.

2006-12-05 Thread David Miller
From: YOSHIFUJI Hideaki [EMAIL PROTECTED] Date: Tue, 05 Dec 2006 20:02:42 +0900 (JST) In article [EMAIL PROTECTED] (at Tue, 5 Dec 2006 19:03:27 +0900), Masahide NAKAMURA [EMAIL PROTECTED] says: Add checksum default defines for mobility header(MH). As the result kernel's behavior is to

Re: [PATCH] Netlink: add a pointer to the Generic Netlink wiki page

2006-12-05 Thread David Miller
From: [EMAIL PROTECTED] Date: Tue, 05 Dec 2006 12:26:10 -0500 From: Paul Moore [EMAIL PROTECTED] Add a pointer to the OSDL wiki page on Generic Netlink. Signed-off-by: Paul Moore [EMAIL PROTECTED] Applied, thanks Paul. - To unsubscribe from this list: send the line unsubscribe netdev in

Re: [PATCH 1/2] [IPV6] RAW: Don't release unlocked sock.

2006-12-05 Thread David Miller
From: Masahide NAKAMURA [EMAIL PROTECTED] Date: Tue, 5 Dec 2006 19:03:14 +0900 When user builds IPv6 header and send it through raw socket, kernel tries to release unlocked sock. (Kernel log shows BUG: bad unlock balance detected with enabled debug option.) The lock is held only for

Re: [RFC patch] driver for the Opencores Ethernet Controller

2006-12-05 Thread Dan Nicolaescu
Lennert Buytenhek [EMAIL PROTECTED] writes: On Mon, Dec 04, 2006 at 10:27:52AM -0800, Dan Nicolaescu wrote: The Opencores Ethernet Controller is Verilog code that can be used to implement an Ethernet device in hardware. It needs to be coupled with a PHY and some buffer

Re: [NET_SCHED]: cls_fw: fix NULL pointer dereference

2006-12-05 Thread David Miller
From: Patrick McHardy [EMAIL PROTECTED] Date: Mon, 04 Dec 2006 16:34:46 +0100 [NET_SCHED]: cls_fw: fix NULL pointer dereference When the first fw classifier is initialized, there is a small window between the -init() and -change() calls, during which the classifier is active but not

Re: [PATCH 2.6.20] [IPV6]: Repair IPv6 Fragments

2006-12-05 Thread David Miller
From: YOSHIFUJI Hideaki [EMAIL PROTECTED] Date: Tue, 05 Dec 2006 18:28:28 +0900 (JST) Hello. The commit [IPV6]: Use kmemdup (commit-id: af879cc704372ef762584e916129d19ffb39e844) broke IPv6 fragments. Bug was spotted by Yasuyuki Kozakai [EMAIL PROTECTED]. Signed-off-by: YOSHIFUJI

Re: [PATCH 2/10] cxgb3 - main source file

2006-12-05 Thread Divy Le Ray
Stephen, Thanks for the review. Please see my replies inline. Stephen Hemminger wrote: O + * If we have multiple receive queues per port serviced by NAPI we need one + * netdevice per queue as NAPI operates on netdevices. We already have one + * netdevice, namely the one associated with

Re: [RFC] rfkill - Add support for input key to control wireless radio

2006-12-05 Thread Christoph Hellwig
+/* + * Function called by the key driver when the rfkill structure + * needs to be registered. + */ +int rfkill_register_key(struct rfkill *rfkill, int init_status) +{ + struct rfkill_type *type = master-type[rfkill-key_type]; + struct rfkill_key *key; + int status; + +

Re: [PATCH v2 04/13] Connection Manager

2006-12-05 Thread Brice Goglin
Steve Wise wrote: There is no SW TCP stack in this driver. The HW supports RDMA over TCP/IP/10GbE in HW and this is required for zero-copy RDMA over Ethernet (aka iWARP). The device is a 10 GbE device, not Infiniband. Then, I wonder why the driver goes in drivers/infiniband/ :) Is there

Re: [PATCH v2 04/13] Connection Manager

2006-12-05 Thread Steve Wise
On Tue, 2006-12-05 at 08:07 +0300, Evgeniy Polyakov wrote: On Mon, Dec 04, 2006 at 07:45:52AM -0800, Roland Dreier ([EMAIL PROTECTED]) wrote: This and a lot of other changes in this driver definitely says you implement your own stack of protocols on top of infiniband hardware.

Re: [PATCH v2 04/13] Connection Manager

2006-12-05 Thread Steve Wise
On Mon, 2006-12-04 at 21:13 -0800, Roland Dreier wrote: It is for iwarp/rdma from description. Yes, iWARP on top of 10G ethernet. If it is 10ge, then why does it parse incomping packet headers and implements initial tcp state machine? To establish connections to run RDMA over, I

Re: [PATCH v2 04/13] Connection Manager

2006-12-05 Thread Steve Wise
On Tue, 2006-12-05 at 08:13 +0300, Evgeniy Polyakov wrote: On Mon, Dec 04, 2006 at 10:20:51AM -0600, Steve Wise ([EMAIL PROTECTED]) wrote: This and a lot of other changes in this driver definitely says you implement your own stack of protocols on top of infiniband hardware.

Re: [PATCH v2 04/13] Connection Manager

2006-12-05 Thread Steve Wise
On Mon, 2006-12-04 at 21:27 -0800, Roland Dreier wrote: So will each new NIC implement some parts of TCP stack in theirs drivers? I hope not. The driver we merged (amso1100) did it completely in FW, with a separate MAC and IP interface for the RDMA connections. I think we better

Re: [PATCH v2 04/13] Connection Manager

2006-12-05 Thread Evgeniy Polyakov
On Tue, Dec 05, 2006 at 09:02:05AM -0600, Steve Wise ([EMAIL PROTECTED]) wrote: This and a lot of other changes in this driver definitely says you implement your own stack of protocols on top of infiniband hardware. ...but I do know this driver is for 10-gig ethernet HW. It

Re: [PATCH v2 04/13] Connection Manager

2006-12-05 Thread Evgeniy Polyakov
On Tue, Dec 05, 2006 at 09:14:36AM -0600, Steve Wise ([EMAIL PROTECTED]) wrote: Chelsio doesn't implement TCP stack in the driver. Just like Ammasso, it sends messages to the HW to setup connections. It differs from Ammasso in at least 2 ways: 1) Ammasso does the MPA negotiations in FW/HW.

Re: [PATCH v2 04/13] Connection Manager

2006-12-05 Thread Steve Wise
On Tue, 2006-12-05 at 18:19 +0300, Evgeniy Polyakov wrote: On Tue, Dec 05, 2006 at 09:02:05AM -0600, Steve Wise ([EMAIL PROTECTED]) wrote: This and a lot of other changes in this driver definitely says you implement your own stack of protocols on top of infiniband hardware.

Re: [PATCH v2 04/13] Connection Manager

2006-12-05 Thread Steve Wise
On Tue, 2006-12-05 at 18:27 +0300, Evgeniy Polyakov wrote: On Tue, Dec 05, 2006 at 09:14:36AM -0600, Steve Wise ([EMAIL PROTECTED]) wrote: Chelsio doesn't implement TCP stack in the driver. Just like Ammasso, it sends messages to the HW to setup connections. It differs from Ammasso in

Re: [PATCH v2 04/13] Connection Manager

2006-12-05 Thread Evgeniy Polyakov
On Tue, Dec 05, 2006 at 09:39:58AM -0600, Steve Wise ([EMAIL PROTECTED]) wrote: Phrases like MPA-aware TCP rises a lot of questions - briefly saying that hardware (even if it is called ethernet driver) can create and work with own TCP flows potentially modified in the way it likes which is

Re: [PATCH v2 04/13] Connection Manager

2006-12-05 Thread Steve Wise
On Tue, 2006-12-05 at 11:45 +0100, Brice Goglin wrote: Steve Wise wrote: There is no SW TCP stack in this driver. The HW supports RDMA over TCP/IP/10GbE in HW and this is required for zero-copy RDMA over Ethernet (aka iWARP). The device is a 10 GbE device, not Infiniband. Then, I

Re: [PATCH v2 04/13] Connection Manager

2006-12-05 Thread Steve Wise
On Tue, 2006-12-05 at 18:59 +0300, Evgeniy Polyakov wrote: On Tue, Dec 05, 2006 at 09:39:58AM -0600, Steve Wise ([EMAIL PROTECTED]) wrote: Phrases like MPA-aware TCP rises a lot of questions - briefly saying that hardware (even if it is called ethernet driver) can create and work with

Re: [openib-general] [PATCH v2 04/13] Connection Manager

2006-12-05 Thread Steve Wise
On Tue, 2006-12-05 at 10:12 -0600, Steve Wise wrote: On Tue, 2006-12-05 at 18:59 +0300, Evgeniy Polyakov wrote: On Tue, Dec 05, 2006 at 09:39:58AM -0600, Steve Wise ([EMAIL PROTECTED]) wrote: Phrases like MPA-aware TCP rises a lot of questions - briefly saying that hardware (even if

Re: [openib-general] [PATCH v2 04/13] Connection Manager

2006-12-05 Thread Steve Wise
On Tue, 2006-12-05 at 10:02 -0600, Steve Wise wrote: On Tue, 2006-12-05 at 11:45 +0100, Brice Goglin wrote: Steve Wise wrote: There is no SW TCP stack in this driver. The HW supports RDMA over TCP/IP/10GbE in HW and this is required for zero-copy RDMA over Ethernet (aka iWARP). The

Re: [PATCH v2 04/13] Connection Manager

2006-12-05 Thread Evgeniy Polyakov
On Tue, Dec 05, 2006 at 10:12:42AM -0600, Steve Wise ([EMAIL PROTECTED]) wrote: Ah. Data from an offloaded connection cannot leak into the main stack nor vice-verse. We can take an active RDMA connection establishment as an example if you want: Once the message is sent to the HW to setup a

Re: [PATCH v2 04/13] Connection Manager

2006-12-05 Thread Steve Wise
On Tue, 2006-12-05 at 19:31 +0300, Evgeniy Polyakov wrote: On Tue, Dec 05, 2006 at 10:12:42AM -0600, Steve Wise ([EMAIL PROTECTED]) wrote: Ah. Data from an offloaded connection cannot leak into the main stack nor vice-verse. We can take an active RDMA connection establishment as an

Re: [PATCH v2 04/13] Connection Manager

2006-12-05 Thread Roland Dreier
Is there really no way to only keep the actual hw infiniband there, move iwarp/rdma drivers in drivers/net/something/ and the core stuff in net/something/ ? It's definitely possible, but rearranging the source tree hasn't been a high priority (for me at least). - R. - To unsubscribe from

Re: [PATCH v2 04/13] Connection Manager

2006-12-05 Thread Evgeniy Polyakov
On Tue, Dec 05, 2006 at 10:47:25AM -0600, Steve Wise ([EMAIL PROTECTED]) wrote: And if there were a dataflow between addr/port a.b to addr/port c.d already, it will either terminated? Considering the following sequence: handlers-t3c_handlers-sched()-work_queue-work_handlers()-for

Re: [PATCH v2 04/13] Connection Manager

2006-12-05 Thread Evgeniy Polyakov
On Tue, Dec 05, 2006 at 08:26:49PM +0300, Evgeniy Polyakov ([EMAIL PROTECTED]) wrote: On Tue, Dec 05, 2006 at 10:47:25AM -0600, Steve Wise ([EMAIL PROTECTED]) wrote: And if there were a dataflow between addr/port a.b to addr/port c.d already, it will either terminated? Considering

Re: [PATCH v2 04/13] Connection Manager

2006-12-05 Thread Steve Wise
On Tue, 2006-12-05 at 20:26 +0300, Evgeniy Polyakov wrote: On Tue, Dec 05, 2006 at 10:47:25AM -0600, Steve Wise ([EMAIL PROTECTED]) wrote: And if there were a dataflow between addr/port a.b to addr/port c.d already, it will either terminated? Considering the following sequence:

Re: [PATCH v2 04/13] Connection Manager

2006-12-05 Thread Evgeniy Polyakov
On Tue, Dec 05, 2006 at 11:51:40AM -0600, Steve Wise ([EMAIL PROTECTED]) wrote: Almost - except the case about where those skbs are coming from? It looks like they are obtained from network, since it is ethernet driver, and if they match some set of rules, they are considered as valid MPA

Re: [PATCH] Add Broadcom PHY support

2006-12-05 Thread Andy Fleming
On Dec 5, 2006, at 00:03, Benjamin Herrenschmidt wrote: I believe that this fiber enabling can be done by defining config_init in the phy_driver struct. struct phy_driver { snip /* Called to initialize the PHY, * including after a reset */ int

Re: [RFC] rfkill - Add support for input key to control wireless radio

2006-12-05 Thread Ivo van Doorn
On Tuesday 05 December 2006 11:32, Christoph Hellwig wrote: +/* + * Function called by the key driver when the rfkill structure + * needs to be registered. + */ +int rfkill_register_key(struct rfkill *rfkill, int init_status) +{ + struct rfkill_type *type =

Re: [RFC] rfkill - Add support for input key to control wireless radio

2006-12-05 Thread Ivo van Doorn
[snip] +/* + * Function called by the key driver to report the new status + * of the key. + */ +void rfkill_report_event(struct rfkill *rfkill, int new_status) +{ + mutex_lock(master-mutex); + + if (rfkill_check_key(rfkill-key, new_status)) +

2.6.19-rc6-mm2: Network device naming starts at 1 instead of 0

2006-12-05 Thread Auke Kok
[resend] Quick note: I loaded up 2.6.19-rc6-mm2 on a platform here and noticed that the onboard e1000 NIC was enumerated to eth1 instead of eth0. on 2.6.18.5 and any other kernel I used before, it was properly named eth0 after startup. eth0 itself is completely missing (-ENODEV). I'll try to

Re: 2.6.19-rc6-mm2: Network device naming starts at 1 instead of 0

2006-12-05 Thread Rafael J. Wysocki
On Tuesday, 5 December 2006 23:07, Auke Kok wrote: [resend] Quick note: I loaded up 2.6.19-rc6-mm2 on a platform here and noticed that the onboard e1000 NIC was enumerated to eth1 instead of eth0. on 2.6.18.5 and any other kernel I used before, it was properly named eth0 after startup.

[PATCH] zd1211rw-d80211: check IEEE80211_TXCTL_USE_CTS_PROTECT

2006-12-05 Thread Michael Wu
zd1211rw-d80211: check IEEE80211_TXCTL_USE_CTS_PROTECT This makes zd1211 check for IEEE80211_TXCTL_USE_CTS_PROTECT and set things appropriately in the hardware TX header. Signed-off-by: Michael Wu [EMAIL PROTECTED] --- drivers/net/wireless/d80211/zd1211rw/zd_mac.c | 14 +- 1

[PATCH 0/7] chelsio: lightweight review

2006-12-05 Thread Francois Romieu
The serie applies against netdev-2.6#upstream-linus or linux-2.6#master Patches have been compiled. No further test. It is available as: git://electric-eye.fr.zoreil.com/home/romieu/linux-2.6.git#chelsio Former 'chelsio' branch is archived as 'chelsio-20061206'. Distance from 'master'

[PATCH 3/7] chelsio: spaces, tabs and friends

2006-12-05 Thread Francois Romieu
Signed-off-by: Francois Romieu [EMAIL PROTECTED] --- drivers/net/chelsio/common.h|2 +- drivers/net/chelsio/cpl5_cmd.h | 18 +++--- drivers/net/chelsio/cxgb2.c | 64 +++--- drivers/net/chelsio/elmer0.h| 40 +++--- drivers/net/chelsio/espi.c |

[PATCH 4/7] chelsio: use netdev_priv

2006-12-05 Thread Francois Romieu
Signed-off-by: Francois Romieu [EMAIL PROTECTED] --- drivers/net/chelsio/cxgb2.c | 60 +- drivers/net/chelsio/sge.c |4 +- 2 files changed, 32 insertions(+), 32 deletions(-) diff --git a/drivers/net/chelsio/cxgb2.c b/drivers/net/chelsio/cxgb2.c

[PATCH 1/7] chelsio: move return, break and continue statements on their own line

2006-12-05 Thread Francois Romieu
Signed-off-by: Francois Romieu [EMAIL PROTECTED] --- drivers/net/chelsio/espi.c |3 ++- drivers/net/chelsio/ixf1010.c |9 ++--- drivers/net/chelsio/mv88e1xxx.c |6 -- drivers/net/chelsio/subr.c |6 -- drivers/net/chelsio/vsc7326.c |3 ++-

[PATCH 2/7] chelsio: the return statement is not a function

2006-12-05 Thread Francois Romieu
Signed-off-by: Francois Romieu [EMAIL PROTECTED] --- drivers/net/chelsio/my3126.c | 16 drivers/net/chelsio/vsc7326.c | 12 ++-- 2 files changed, 14 insertions(+), 14 deletions(-) diff --git a/drivers/net/chelsio/my3126.c b/drivers/net/chelsio/my3126.c index

[PATCH 6/7] chelsio: useless test in cxgb2::remove_one

2006-12-05 Thread Francois Romieu
pci_get_drvadata() is necessarily distinct from NULL if cxgb2::init_one succeeded. cxgb2::remove_one is solely issued through the PCI device callback. Signed-off-by: Francois Romieu [EMAIL PROTECTED] --- drivers/net/chelsio/cxgb2.c | 32 1 files changed, 16

[PATCH 7/7] chelsio: misc cleanups in sge

2006-12-05 Thread Francois Romieu
- duplicated code in sge::free_cmdQ_buffers ; - NET_IP_ALIGN is already defined in (included) linux/skbuff.h ; - pci_alloc_consistent() returns void * ; - pci_alloc_consistent() returns a zeroed chunk of memory ; - early return in restart_tx_queues. Signed-off-by: Francois Romieu [EMAIL

[PATCH 5/7] chelsio: useless curly braces

2006-12-05 Thread Francois Romieu
Signed-off-by: Francois Romieu [EMAIL PROTECTED] --- drivers/net/chelsio/cxgb2.c |9 - drivers/net/chelsio/mv88e1xxx.c |4 ++-- drivers/net/chelsio/sge.c |3 +-- drivers/net/chelsio/vsc7326.c |3 +-- 4 files changed, 8 insertions(+), 11 deletions(-) diff --git

Re: [PATCH 4/7] chelsio: use netdev_priv

2006-12-05 Thread Stephen Hemminger
On Wed, 6 Dec 2006 01:16:52 +0100 Francois Romieu [EMAIL PROTECTED] wrote: Signed-off-by: Francois Romieu [EMAIL PROTECTED] --- drivers/net/chelsio/cxgb2.c | 60 +- drivers/net/chelsio/sge.c |4 +- 2 files changed, 32 insertions(+), 32

Re: [PATCH 4/7] chelsio: use netdev_priv

2006-12-05 Thread Francois Romieu
Stephen Hemminger [EMAIL PROTECTED] : [...] NAK for this driver. dev-priv points to a different location for each port on dual port board. To use netdev_priv() requires more serious surgery..Q Ok, it's removed from the branch. Patch #6 has been modified. Should I wait for someone to pick-up

Re: [PATCH wireless-2.6-git] prism54: WPA/RSN support for fullmac cards

2006-12-05 Thread John W. Linville
On Sun, Nov 26, 2006 at 11:47:49AM +0100, [EMAIL PROTECTED] wrote: On Sunday, 26. November 2006 06:27, you wrote: Sorry, still need the second ifup to bring the card up after plugging it in. ping -f looks good however, I will try to stress it more and will report if I see anything wrong.

Please pull 'upstream' branch of wireless-2.6

2006-12-05 Thread John W. Linville
The following changes since commit e62438630ca37539c8cc1553710bbfaa3cf960a7: Matthew Wilcox: Centralise definitions of sector_t and blkcnt_t are found in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-2.6.git upstream Daniel Drake:

[PATCH] netfilter: fix non-ANSI func. decl.

2006-12-05 Thread Randy Dunlap
From: Randy Dunlap [EMAIL PROTECTED] Fix non-ANSI function declaration: net/netfilter/nf_conntrack_core.c:1096:25: warning: non-ANSI function declaration of function 'nf_conntrack_flush' Signed-off-by: Randy Dunlap [EMAIL PROTECTED] --- net/netfilter/nf_conntrack_core.c |2 +- 1 file

  1   2   >