Re: [RFC ] [2 of 4] IEEE802.11 Regulatory/Geographical Support for drivers - database

2006-06-11 Thread Ulrich Kunitz
On 06-06-03 17:45 Larry Finger wrote: This message shows each of the 2.4 GHz and 5 GHz bands split into indoor and outdoor usage. For each group, the ISO name for that country is shown before the channel listing. There are a lot of countries that do not belong in the default group. I

Re: [RFC ] [1 of 4] IEEE802.11 Regulatory/Geographical Support for drivers - statement of project

2006-06-11 Thread Ulrich Kunitz
Larry, I've not read your patches your detail, so I comment only on your description. 1. A new routine, ieee80211_init_geo has been written that is called by a driver wishing to use this functionality. The arguments are an ieee80211_device, a two-character ISO3661 country code, and a flag

Re: [RFC] [patch 2/6] [Network namespace] Network device sharing by view

2006-06-11 Thread Andrew Morton
On Fri, 09 Jun 2006 23:02:04 +0200 [EMAIL PROTECTED] wrote: +int net_ns_dev_add(const char *devname, +struct net_ns_dev_list *devlist) +{ + struct net_ns_dev *db; + struct net_device *dev; + int ret = 0; + + read_lock(dev_base_lock); + + for (dev =

Re: [PATCH] [2.6.17-rc6] Section mismatch in drivers/net/ne.o during modpost

2006-06-11 Thread Jan Engelhardt
Doesn't look serious. init_module() is not __init, but it calls some __init functions and touches some __initdata. This is the typical case with inconsistent tagging. Worse yet, I once experienced a double-definition error, that is, I had __init int init_module(void) { /* module1 */

Re: [PATCH] [2.6.17-rc6] Section mismatch in drivers/net/ne.o during modpost

2006-06-11 Thread Jan Engelhardt
The messages above are from when I used gcc-4.1.1. With gcc-3.2.3 I only see a single warning. FTR, gcc 4.0.x is also 'affected'. Jan Engelhardt -- - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

UNHERALDED NEWS WITH COMMENTS: About rising interest rates and much more

2006-06-11 Thread info
Reply-To: Edward Subscribe here (twice weekly):http://straitgateministry.net UNHERALDED NEWS WITH COMMENTS: About rising interest rates, gifts to Israel, Christian-Zionism on the march, Wall Street and Oil READ THE FULL STORIES HERE: http://straitgateministry.net (Unheralded News) My

http://bugzilla.kernel.org/show_bug.cgi?id=6197

2006-06-11 Thread Andrew Morton
The reporter claims this is a netfilter bug. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] [2.6.17-rc6] Section mismatch in drivers/net/ne.o during modpost

2006-06-11 Thread Mikael Pettersson
On Sat, 10 Jun 2006 22:38:00 +0200, Sam Ravnborg wrote: --- linux-2617-rc6.orig/drivers/net/ne.c +++ linux-2617-rc6/drivers/net/ne.c @@ -829,7 +829,7 @@ that the ne2k probe is the last 8390 bas is at boot) and so the probe will get confused by any other 8390 cards. ISA device autoprobes on

Re: [patch 7/8] lock validator: fix ns83820.c irq-flags bug

2006-06-11 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: From: Ingo Molnar [EMAIL PROTECTED] Barry K. Nathan reported the following lockdep warning: [ 197.343948] BUG: warning at kernel/lockdep.c:1856/trace_hardirqs_on() [ 197.345928] [c010329b] show_trace_log_lvl+0x5b/0x105 [ 197.346359] [c0103896] show_trace+0x1b/0x20

Re: [patch 7/8] lock validator: fix ns83820.c irq-flags bug

2006-06-11 Thread Arjan van de Ven
Jeff Garzik wrote: The driver's locking is definitely wrong, but I don't think this is the fix, it's an obvious correct fix in the correctness sense though... Jesus, the locking here is awful. No wonder there are bugs. ... which given that fact, is for 2.6.17 probably the right thing,

Re: [RFC ] [2 of 4] IEEE802.11 Regulatory/Geographical Support for drivers - database

2006-06-11 Thread Larry Finger
Hi Uli, Thanks for the comments. Ulrich Kunitz wrote: two minor comments. 1. I appreciate that you are keeping everything in 80 character lines. So I believe the one line extending 80 characters is an oversight. I have tried, but will watch that more carefully. 2. Could you just

[PATCH] SoftMAC: Prevent multiple authentication attempts on the same network

2006-06-11 Thread Joseph Jezak
This patch addresses the No queue exists messages commonly seen during authentication and associating. These appear due to scheduling multiple authentication attempts on the same network. To prevent this, I added a flag to stop multiple authentication attempts by the association layer. I also

[PATCH] SoftMAC: Add network to ieee80211softmac_call_events when associate times out

2006-06-11 Thread Joseph Jezak
The ieee80211softmac_call_events function, when called with event type IEEE80211SOFTMAC_EVENT_ASSOCIATE_TIMEOUT should pass the network as the third parameter. This patch does that. Signed-off-by: Joseph Jezak [EMAIL PROTECTED] --- diff --git a/net/ieee80211/softmac/ieee80211softmac_assoc.c

Re: [patch 7/8] lock validator: fix ns83820.c irq-flags bug

2006-06-11 Thread Jeff Garzik
Arjan van de Ven wrote: Jeff Garzik wrote: The driver's locking is definitely wrong, but I don't think this is the fix, it's an obvious correct fix in the correctness sense though... Jesus, the locking here is awful. No wonder there are bugs. ... which given that fact, is for 2.6.17

Re: [patch 7/8] lock validator: fix ns83820.c irq-flags bug

2006-06-11 Thread Arjan van de Ven
Jeff Garzik wrote: Arjan van de Ven wrote: Jeff Garzik wrote: The driver's locking is definitely wrong, but I don't think this is the fix, it's an obvious correct fix in the correctness sense though... Jesus, the locking here is awful. No wonder there are bugs. ... which given that

Re: [PATCH 1/2] PHYLIB: Add get_link ethtool helper function

2006-06-11 Thread Jeff Garzik
Nathaniel Case wrote: This adds a phy_ethtool_get_link() function along the same lines as phy_ethtool_gset(). This provides drivers utilizing PHYLIB an alternative to using ethtool_op_get_link(). This is more desirable since the Link detected field in ethtool would actually reflect the state

Re: [RFC ] [1 of 4] IEEE802.11 Regulatory/Geographical Support for drivers - statement of project

2006-06-11 Thread Larry Finger
Uli, Ulrich Kunitz wrote: Larry, I've not read your patches your detail, so I comment only on your description. The problem is the driver doesn't have good ideas, whether the device is outdoor and in which country it operates. Devices have some information available, but I have definitely a

Re: [patch 7/8] lock validator: fix ns83820.c irq-flags bug

2006-06-11 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: diff -puN drivers/net/ns83820.c~lock-validator-fix-ns83820c-irq-flags-bug drivers/net/ns83820.c --- devel/drivers/net/ns83820.c~lock-validator-fix-ns83820c-irq-flags-bug 2006-06-08 22:18:34.0 -0700 +++ devel-akpm/drivers/net/ns83820.c2006-06-08

Re: [patch 7/8] lock validator: fix ns83820.c irq-flags bug

2006-06-11 Thread Arjan van de Ven
The above code snippet removes the nested unlock-irq, but now the code is unbalanced, so IMO this patch _adds_ confusion. I think the conservative patch for 2.6.17 is the one I have attached. Unless there are objections, that is what I will forward... this looks entirely fair and

Re: [PATCH RFC] netpoll: don't spin forever sending to stopped queues

2006-06-11 Thread Matt Mackall
On Thu, Jun 08, 2006 at 07:15:50PM -0700, Jeremy Fitzhardinge wrote: Matt Mackall wrote: That's odd. Netpoll holds a reference to the device, of course, but so does a normal up interface. So that shouldn't be the problem. Another possibility is that outgoing packets from printks in the driver

IEEE80211 Regulatory/Geographical Support for WLAN driver

2006-06-11 Thread Ulrich Kunitz
On 06-06-11 11:46 Larry Finger wrote: I don't see any means for the daemon to know its country other than the driver or the user telling it. If such a means exists, I would like to learn of it. My current working model is to supply the country code from a module option when the driver is

Re: [patch 7/8] lock validator: fix ns83820.c irq-flags bug

2006-06-11 Thread Benjamin LaHaise
The above code snippet removes the nested unlock-irq, but now the code is unbalanced, so IMO this patch _adds_ confusion. I think the conservative patch for 2.6.17 is the one I have attached. Unless there are objections, that is what I will forward... This looks reasonable and

Re: [PATCH] [2.6.17-rc6] Section mismatch in drivers/net/ne.o during modpost

2006-06-11 Thread Sam Ravnborg
On Sun, Jun 11, 2006 at 04:37:31PM +0200, Mikael Pettersson wrote: On Sat, 10 Jun 2006 22:38:00 +0200, Sam Ravnborg wrote: --- linux-2617-rc6.orig/drivers/net/ne.c +++ linux-2617-rc6/drivers/net/ne.c @@ -829,7 +829,7 @@ that the ne2k probe is the last 8390 bas is at boot) and so the

[PATCH] zd1211rw: disable TX queue during stop

2006-06-11 Thread Daniel Drake
This avoids some potential races. Signed-off-by: Daniel Drake [EMAIL PROTECTED] diff --git a/drivers/net/wireless/zd1211rw/zd_mac.c b/drivers/net/wireless/zd1211rw/zd_mac.c index bbe067e..3bdc54d 100644 --- a/drivers/net/wireless/zd1211rw/zd_mac.c +++ b/drivers/net/wireless/zd1211rw/zd_mac.c @@

Re: [PATCH 2.6.17-rc6] Remove Prism II support from Orinoco

2006-06-11 Thread Dave Jones
On Sat, Jun 10, 2006 at 02:08:50PM -0400, Dave Jones wrote: On Sat, Jun 10, 2006 at 08:50:10PM +0300, Faidon Liambotis wrote: Remove Prism II IDs from the orinoco driver since now we have a separate driver for them (HostAP). Additionally, kill orinoco_{pci,plx,nortel} completely,

Re: [PATCH 2.6.17-rc6] Remove Prism II support from Orinoco

2006-06-11 Thread Dave Jones
On Sun, Jun 11, 2006 at 06:27:19PM -0400, Dave Jones wrote: On Sat, Jun 10, 2006 at 02:08:50PM -0400, Dave Jones wrote: On Sat, Jun 10, 2006 at 08:50:10PM +0300, Faidon Liambotis wrote: Remove Prism II IDs from the orinoco driver since now we have a separate driver for them

Re: [PATCH 2.6.17-rc6] Remove Prism II support from Orinoco

2006-06-11 Thread Kyle McMartin
On Sun, Jun 11, 2006 at 06:40:54PM -0400, Dave Jones wrote: Under hostap, it's a brick, it won't even report any scanning results. Did you switch it into managed mode? The hostap driver, iirc, defaults to running in master (AP) mode. Cheers, Kyle - To unsubscribe from this list: send

[PATCH] [IrDA] irda-usb.c: STIR421x cleanups

2006-06-11 Thread Samuel Ortiz
This patch is for the net-2.6.18 tree. It cleans the STIR421x part of the irda-usb code. We also no longer try to load all existing firmwares but only the matching one (according to the USB id we get from the dongle). Signed-off-by: Nick Fedchik [EMAIL PROTECTED] Signed-off-by: Samuel Ortiz

Re: [PATCH 2.6.17-rc6] Remove Prism II support from Orinoco

2006-06-11 Thread Dave Jones
On Sun, Jun 11, 2006 at 06:31:40PM -0400, Kyle McMartin wrote: On Sun, Jun 11, 2006 at 06:40:54PM -0400, Dave Jones wrote: Under hostap, it's a brick, it won't even report any scanning results. Did you switch it into managed mode? The hostap driver, iirc, defaults to running in

Re: [RFT] Realtek 8168 ethernet support

2006-06-11 Thread Francois Romieu
The patch below agaisnt 2.6.17-rc6 includes the following changes: commit 3072cc0aba3ac0c944e196a63c4154ca5746ec0b r8169: sync with vendor's driver - add several PCI ID for the PCI-E adapters ; - new identification strings ; - the RTL_GIGA_MAC_VER_ defines have been renamed

Re: [PATCH 1/2] e1000: fix netpoll with NAPI

2006-06-11 Thread Neil Horman
On Thu, Jun 08, 2006 at 01:29:00PM -0400, Jeff Moyer wrote: == Regarding Re: [PATCH 1/2] e1000: fix netpoll with NAPI; Mitch Williams [EMAIL PROTECTED] adds: mitch.a.williams On Wed, 2006-06-07 at 11:44 -0700, Jeff Moyer wrote: That patch locks around the tx clean routine. As such, it

Remove useless check for null dev from uli526x_interrupt()

2006-06-11 Thread Dave Jones
As we're already dereferencing dev a few lines above, if this check could ever trigger, we'd have already oopsed. Signed-off-by: Dave Jones [EMAIL PROTECTED] --- linux-2.6/drivers/net/tulip/uli526x.c~ 2006-06-11 20:24:41.0 -0400 +++ linux-2.6/drivers/net/tulip/uli526x.c

Re: Problem authenticating using WPA with bcm43xx-softmac

2006-06-11 Thread Larry Finger
Johannes Berg wrote: On Fri, 2006-06-09 at 10:31 -0500, Larry Finger wrote: Do you mean a special dump, or is the kernel debug output and wpa_supplicant debug output sufficient? I was thinking of packet dumps but earlier you said you couldn't create any so I'm out of ideas for now. I was

Re: [PATCH netdev-2.6#upstream] net: au1000_eth: PHY framework conversion

2006-06-11 Thread Jeff Garzik
Herbert Valerio Riedel wrote: convert au1000_eth driver to use PHY framework and garbage collected functions and identifiers that became unused/obsolete in the process Signed-off-by: Herbert Valerio Riedel [EMAIL PROTECTED] applied - To unsubscribe from this list: send the line unsubscribe

Re: [PATCH] [IrDA] irda-usb.c: STIR421x cleanups

2006-06-11 Thread David Miller
From: Samuel Ortiz [EMAIL PROTECTED] Date: Mon, 12 Jun 2006 09:12:35 +0300 This patch is for the net-2.6.18 tree. It cleans the STIR421x part of the irda-usb code. We also no longer try to load all existing firmwares but only the matching one (according to the USB id we get from the dongle).

Re: [PATCH] bnx2: endian fixes

2006-06-11 Thread David Miller
From: Alexey Dobriyan [EMAIL PROTECTED] Date: Sat, 10 Jun 2006 15:52:51 +0400 Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED] Applied, thanks Alexey. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH] net.ipv4.ip_autoconfig sysctl removal

2006-06-11 Thread David Miller
From: Stephen Hemminger [EMAIL PROTECTED] Date: Mon, 5 Jun 2006 10:58:31 -0700 The sysctl net.ipv4.ip_autoconfig is a legacy value that is not used. Can it finally go in 2.6.18 or do we need to go through the whole feature-removal process? Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]

Re: [ PATCH 2.6.17-rc6 1/1] udp.c: counting InDatagrams which are never delivered

2006-06-11 Thread David Miller
From: Gerrit Renker [EMAIL PROTECTED] Date: Tue, 6 Jun 2006 19:25:40 +0100 Fix: Move the `UDP_INC_STATS_BH(UDP_MIB_INDATAGRAMS)' statement from udp_queue_rcv_skb to udp_recvmsg. Now InDatagrams only counts those datagrams which were really delivered (as per RFC 2013).

[PATCH netdev-2.6#upstream] net: au1000_eth: netdev_priv() conversion

2006-06-11 Thread Herbert Valerio Riedel
convert driver to use netdev_priv(net_device*) instead of accessing -priv directly; where applicable, declare the resulting local pointer to be 'const' Signed-off-by: Herbert Valerio Riedel [EMAIL PROTECTED] --- drivers/net/au1000_eth.c | 51 +++--- 1