Re: Netchannles: first stage has been completed. Further ideas.

2006-07-18 Thread David Miller
From: Evgeniy Polyakov [EMAIL PROTECTED] Date: Tue, 18 Jul 2006 12:16:26 +0400 I would ask to push netchannel support into -mm tree, but I expect in advance that having two separate TCP stacks (one of which can contain some bugs (I mean atcp.c)) is not that good idea, so I understand possible

Re: Netchannles: first stage has been completed. Further ideas.

2006-07-18 Thread Evgeniy Polyakov
On Tue, Jul 18, 2006 at 01:34:37AM -0700, David Miller ([EMAIL PROTECTED]) wrote: Perhaps I am mistaken with my priorities, but I tend to hit all the easy patches and bug fixes first, before significant new work. And even in the realm of new work, your things require the most serious

[RFC PATCH 32/33] Add the Xen virtual network device driver.

2006-07-18 Thread Chris Wright
The network device frontend driver allows the kernel to access network devices exported exported by a virtual machine containing a physical network device driver. Signed-off-by: Ian Pratt [EMAIL PROTECTED] Signed-off-by: Christian Limpach [EMAIL PROTECTED] Signed-off-by: Chris Wright [EMAIL

Re: [RFC PATCH 32/33] Add the Xen virtual network device driver.

2006-07-18 Thread Arjan van de Ven
On Tue, 2006-07-18 at 00:00 -0700, Chris Wright wrote: + +/** Send a packet on a net device to encourage switches to learn the + * MAC. We send a fake ARP request. + * + * @param dev device + * @return 0 on success, error code otherwise + */ +static int send_fake_arp(struct net_device

Re: [RFC PATCH 32/33] Add the Xen virtual network device driver.

2006-07-18 Thread Keir Fraser
On 18 Jul 2006, at 11:27, Arjan van de Ven wrote: Hmmm maybe it's me, but something bugs me if a NIC driver is going to send IP level ARP packets... that just feels very very wrong and is a blatant layering violation shouldn't the ifup/ifconfig scripts just be fixed instead if this is

Re: [RFC PATCH 32/33] Add the Xen virtual network device driver.

2006-07-18 Thread Arjan van de Ven
On Tue, 2006-07-18 at 11:35 +0100, Keir Fraser wrote: On 18 Jul 2006, at 11:27, Arjan van de Ven wrote: Hmmm maybe it's me, but something bugs me if a NIC driver is going to send IP level ARP packets... that just feels very very wrong and is a blatant layering violation shouldn't the

Re: Netchannles: first stage has been completed. Further ideas.

2006-07-18 Thread Christian Borntraeger
Hello Evgeniy, +asmlinkage long sys_netchannel_control(void __user *arg) [...] + if (copy_from_user(ctl, arg, sizeof(struct unetchannel_control))) + return -ERESTARTSYS; ^^^ [...] + if (copy_to_user(arg, ctl, sizeof(struct

Re: [PATCH] Bug in pskb_trim_rcsum()

2006-07-18 Thread Herbert Xu
On Tue, Jul 18, 2006 at 09:09:34AM +0800, Wei Yongjun wrote: And in my test, UDP under IPv4 maybe do that. My UDP packet is: packet1: ___ | Source Port | Dest Port | |_|_| | Length = 16

Re: Netchannles: first stage has been completed. Further ideas.

2006-07-18 Thread Evgeniy Polyakov
On Tue, Jul 18, 2006 at 01:16:18PM +0200, Christian Borntraeger ([EMAIL PROTECTED]) wrote: Hello Evgeniy, +asmlinkage long sys_netchannel_control(void __user *arg) [...] + if (copy_from_user(ctl, arg, sizeof(struct unetchannel_control))) + return -ERESTARTSYS;

Re: Netchannles: first stage has been completed. Further ideas.

2006-07-18 Thread Jörn Engel
On Tue, 18 July 2006 12:16:26 +0400, Evgeniy Polyakov wrote: Current tests with the latest netchannel patch show that netchannels outperforms sockets in any type of bulk transfer (big-sized, small-sized, sending, receiving) over 1gb wire. I omit graphs and numbers here, since I posted it

Re: [RFC PATCH 32/33] Add the Xen virtual network device driver.

2006-07-18 Thread Dave Boutcher
On Tue, 18 Jul 2006 12:42:28 +0200, Arjan van de Ven [EMAIL PROTECTED] said: On Tue, 2006-07-18 at 11:35 +0100, Keir Fraser wrote: On 18 Jul 2006, at 11:27, Arjan van de Ven wrote: Hmmm maybe it's me, but something bugs me if a NIC driver is going to send IP level ARP packets... that

Re: Netchannles: first stage has been completed. Further ideas.

2006-07-18 Thread Christian Borntraeger
On Tuesday 18 July 2006 13:51, Evgeniy Polyakov wrote: I think this should be -EFAULT instead of -ERESTARTSYS, right? I have no strong feeling on what must be returned in that case. As far as I see, copy*user can fail due to absence of the next destination page, so -ERESTARTSYS makes sence,

Re: [PATCH] Bug in pskb_trim_rcsum()

2006-07-18 Thread Alexey Kuznetsov
Hello! The whole point of CHECKSUM_UNNECESSARY is that the hardware parses the protocol header for us. So in this case it must calculate the checksum for only the first 8 bytes of the payload. I remember this place, I stalled there for a minute ages ago. He is right in his doubts, the place

[IPROUTE2]: update documentation on mirred and IFB

2006-07-18 Thread jamal
About two more or so to complete these.. cheers, jamal Clean up some documentation on mirred and IFB --- commit a067bda2c7c9972ad77ac174830a245896d18897 tree a1430a246e5607ec01b31795dd5b12b2e455f5d4 parent a31787bf2939fd9eb11396e3765c78c4d1e744a1 author Jamal Hadi Salim [EMAIL PROTECTED] Tue,

Re: [PATCH] Bug in pskb_trim_rcsum()

2006-07-18 Thread Herbert Xu
On Tue, Jul 18, 2006 at 04:54:39PM +0400, Alexey Kuznetsov wrote: I preferred optimistic approach: if the checksum comes out correct, we do not really care, how device calculated it. Probably, it calculated checksum over wrong data, but got a good checksum. So what? It is not a crypto digest

RE: [PATCH 0/2] NET: Accurate packet scheduling for ATM/ADSL

2006-07-18 Thread jamal
Russell, I apologize i havent followed the latest discussion to the detail. My understanding of Patricks work was it solved the ATM problem as well. I think he is busy somewhere - lets give him an opportunity to respond and i will try to catchup with the thread as well. cheers, jamal On Tue,

Re: [RFC PATCH 32/33] Add the Xen virtual network device driver.

2006-07-18 Thread jamal
On Tue, 2006-18-07 at 12:27 +0200, Arjan van de Ven wrote: Hmmm maybe it's me, but something bugs me if a NIC driver is going to send IP level ARP packets... that just feels very very wrong and is a blatant layering violation It is but the bonding driver has been setting precedence for

Re: [RFC PATCH 32/33] Add the Xen virtual network device driver.

2006-07-18 Thread Herbert Xu
jamal [EMAIL PROTECTED] wrote: I dont think the ifup/ifconfig provide operational status (i.e link up/down) - or do they? If they can be made to invoke scripts in such a case then we are set. In fact, that's a very good reason why this shouldn't be in netfront. Indeed, it shouldn't be in the

Re: [RFC PATCH 32/33] Add the Xen virtual network device driver.

2006-07-18 Thread John Haller
Herbert Xu wrote: jamal [EMAIL PROTECTED] wrote: I dont think the ifup/ifconfig provide operational status (i.e link up/down) - or do they? If they can be made to invoke scripts in such a case then we are set. In fact, that's a very good reason why this shouldn't be in netfront. Indeed, it

Simultanious transmits seems to cause hang on pcnet32

2006-07-18 Thread Lennart Sorensen
I am currently doing some testing on my system and managing to totally hang the system (so that the watchdog has to come along and reboot it). The setup is this: I have a PLX PCI-PCI bridge with 4 79C972 chips behind it, each running 100baseTX. I am transmitting traffic from a smartbits test

[PATCH 2/9] d80211: host_gen_beacon_template flag

2006-07-18 Thread Jiri Benc
This is a partial support for devices requiring beacon template. Please note that there is no support for PS mode for such cards yet. Signed-off-by: Jiri Benc [EMAIL PROTECTED] --- include/net/d80211.h |6 ++ net/d80211/ieee80211.c | 22 +-

[PATCH 6/9] d80211: optimize defragmentation

2006-07-18 Thread Jiri Benc
Optimize defragmentation by storing all fragments in skb queue and reallocating skb only once all fragments are received. Signed-off-by: Jiri Benc [EMAIL PROTECTED] --- net/d80211/ieee80211.c | 46 ++ net/d80211/ieee80211_i.h |3 ++-

[PATCH 8/9] d80211: Replace rc4 code with crypto api arc4

2006-07-18 Thread Jiri Benc
From: Michael Wu [EMAIL PROTECTED] This patch replaces the rc4 code used in wep.c with crypto api's arc4 cipher. The struct crypto_tfm passing in tkip isn't great, but it'll get fixed when tkip is converted to use crypto api entirely. (michael_mic) Signed-off-by: Michael Wu [EMAIL PROTECTED]

[PATCH 4/9] d80211: fix receiving through virtual interfaces

2006-07-18 Thread Jiri Benc
This fixes several problems with receiving when multiple interfaces are present or when some interface is in promiscious mode: - Packet type (PACKET_HOST and PACKET_OTHER_HOST) is set correctly now. - Failed decryption of a frame is reported only once for each frame. - Failed decryption of a

[PATCH 3/9] d80211: better deallocation of mdev

2006-07-18 Thread Jiri Benc
Master device and ieee80211_local are allocated separately now, so master device can be freed by the same function as other virtual interfaces. Signed-off-by: Jiri Benc [EMAIL PROTECTED] --- net/d80211/ieee80211.c |2 +- net/d80211/ieee80211_iface.c |3 ++- 2 files changed, 3

[PATCH 0/9] d80211: pull request

2006-07-18 Thread Jiri Benc
Please pull from git://git.kernel.org/pub/scm/linux/kernel/git/jbenc/dscape.git master to obtain following patches: Jiri Benc: d80211: do not receive through master interface when not scanning d80211: host_gen_beacon_template flag d80211: better deallocation of mdev

[PATCH 9/9] d80211: Add sparse bitwise annotations

2006-07-18 Thread Jiri Benc
From: Michael Wu [EMAIL PROTECTED] This patch adds sparse bitwise annotations to d80211. Signed-off-by: Michael Wu [EMAIL PROTECTED] Signed-off-by: Jiri Benc [EMAIL PROTECTED] --- include/net/d80211.h |6 +++--- include/net/d80211_mgmt.h | 42

[PATCH 1/9] d80211: do not receive through master interface when not scanning

2006-07-18 Thread Jiri Benc
Arrived packets should not go into master interface except when scanning - it leads to duplicate packets reception. This also fixes a race when scanning is finished during invoking of rx handlers. Signed-off-by: Jiri Benc [EMAIL PROTECTED] --- net/d80211/ieee80211.c | 17 +++--

[PATCH 5/9] d80211: fix defragmentation

2006-07-18 Thread Jiri Benc
When multiple virtual interfaces are active and some of them is in promisc mode, defragmentation does not work. Fix it by introducing separate fragment table for each virtual interface. Signed-off-by: Jiri Benc [EMAIL PROTECTED] --- net/d80211/ieee80211.c | 26

[PATCH 7/9] d80211: SET_NETDEV_DEV for non-master devices

2006-07-18 Thread Jiri Benc
This adds /sys/class/net/*/device symlinks for non-master (wlan* and wmgmt*) devices. Signed-off-by: Jiri Benc [EMAIL PROTECTED] --- net/d80211/ieee80211_iface.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) 80f18b79eacc07319afe473023a5358cfbc11ae6 diff --git

Re: [PATCH 0/9] d80211: pull request

2006-07-18 Thread Jiri Benc
On Tue, 18 Jul 2006 17:45:20 +0200 (CEST), Jiri Benc wrote: Please pull from git://git.kernel.org/pub/scm/linux/kernel/git/jbenc/dscape.git master to obtain following patches: Jiri Benc: d80211: do not receive through master interface when not scanning d80211:

[PATCH 1/2] bcm43xx-d80211: use host_gen_beacon_template

2006-07-18 Thread Jiri Benc
Use new host_gen_beacon_template flag. This also means workaround with iwconfig essid after hostapd is run is not necessary anymore. Signed-off-by: Jiri Benc [EMAIL PROTECTED] Signed-off-by: Michael Buesch [EMAIL PROTECTED] --- drivers/net/wireless/d80211/bcm43xx/bcm43xx_main.c | 36

[PATCH 0/2] bcm43xx-d80211: fixes after d80211 update

2006-07-18 Thread Jiri Benc
Both patches were acked by Michael. They allow bcm43xx-d80211 to take advantage of d80211 update. You may also pull them from 'bcm43xx' branch of my tree: git://git.kernel.org/pub/scm/linux/kernel/git/jbenc/dscape.git bcm43xx Jiri Benc: bcm43xx-d80211: use host_gen_beacon_template

[PATCH 2/2] bcm43xx-d80211: use SET_NETDEV_DEV

2006-07-18 Thread Jiri Benc
This adds /sys/class/net/wmaster0/device symlink. Signed-off-by: Jiri Benc [EMAIL PROTECTED] Signed-off-by: Michael Buesch [EMAIL PROTECTED] --- drivers/net/wireless/d80211/bcm43xx/bcm43xx_main.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-)

Re: Bluetooth update for 2.6

2006-07-18 Thread Marcel Holtmann
Hi Dave, here are two more bug fixes for the Bluetooth subsystem. Both are workarounds for either broken implementations or broken hardware. we've seen a bunch of buggy USB Bluetooth devices lately and I have three more patches to workaround various issues. I also re-based the tree to

[PATCH 01/10] MLSXFRM-v02: Granular IPSec associations for use in MLS environments

2006-07-18 Thread Venkat Yekkirala
The current approach to labeling Security Associations for SELinux purposes uses a one-to-one mapping between xfrm policy rules and security associations. This doesn’t address the needs of real world MLS (Multi-level System, traditional Bell-LaPadula) environments where a single xfrm policy rule

[PATCH 04/10] MLSXFRM-v02: Add security sid to flowi

2006-07-18 Thread Venkat Yekkirala
This adds security to flow key for labeling of flows as also to allow for making flow cache lookups based on the security label seemless. Signed-off-by: Venkat Yekkirala [EMAIL PROTECTED] --- Documentation/networking/secid.txt | 14 ++ include/net/flow.h |1 + 2

[PATCH 00/10] MLSXFRM-v02: Repost patchset with updates

2006-07-18 Thread Venkat Yekkirala
The following are the changes included in this patch set (relative to 2.6.18-rc1-mm2) as compared to the previous posting: - Correct use of BUG_ON (per James' and Stephen's comments) - security_sid_mls_copy: check context with policydb_context_isvalid (Stephen) - sk_getsecid: do away with

[PATCH 07/10] MLSXFRM: Add security context to acquire messages using PF_KEY

2006-07-18 Thread Venkat Yekkirala
This includes the security context of a security association created for use by IKE in the acquire messages sent to IKE daemons using PF_KEY. This would allow the daemons to include the security context in the negotiation, so that the resultant association is unique to that security context.

[PATCH 09/10] MLSXFRM-v02: Default labeling of socket specific IPSec policies

2006-07-18 Thread Venkat Yekkirala
This defaults the label of socket-specific IPSec policies to be the same as the socket they are set on. Signed-off-by: Venkat Yekkirala [EMAIL PROTECTED] --- include/linux/security.h| 19 ++--- include/net/xfrm.h |2 - net/key/af_key.c| 15

[PATCH FOR REFERENCE ONLY] MLSXFRM-v02: Add support to serefpolicy

2006-07-18 Thread Venkat Yekkirala
This patch has been included here just for reference for anyone wanting to try the patchset in enforcing mode. It will be submitted to the serefpolicy list later. This patch adds a polmatch avperm to arbitrate flow/state's access to a xfrm policy. It also defines MLS policy for association {

[PATCH 08/10] MLSXFRM-v02: Add flow labeling

2006-07-18 Thread Venkat Yekkirala
This labels the flows that could utilize IPSec xfrms at the points the flows are defined so that IPSec policy and SAs at the right label can be used. The following protos are currently not handled, but they should continue to be able to use single-labeled IPSec like they currently do. ipmr

[PATCH 03/10] MLSXFRM-v02: Add security sid to sock

2006-07-18 Thread Venkat Yekkirala
This adds security for IP sockets at the sock level. Security at the sock level is needed to enforce the SELinux security policy for security associations even when a sock is orphaned (such as in the TCP LAST_ACK state). This will also be used to enforce SELinux controls over data arriving at or

[PATCH 10/10] MLSXFRM-v02: Auto-labeling of child sockets

2006-07-18 Thread Venkat Yekkirala
This automatically labels the TCP, Unix stream, and dccp child sockets as well as openreqs to be at the same MLS level as the peer. This will result in the selection of appropriately labeled IPSec Security Associations. This also uses the sock's sid (as opposed to the isec sid) in SELinux

[PATCH 05/10] MLSXFRM-v02: Flow based matching of xfrm policy and state

2006-07-18 Thread Venkat Yekkirala
This implements a seemless mechanism for xfrm policy selection and state matching based on the flow sid. This also includes the necessary SELinux enforcement pieces. Signed-off-by: Venkat Yekkirala [EMAIL PROTECTED] --- include/linux/security.h| 106 +-- include/net/flow.h

[PATCH 06/10] MLSXFRM-v02: Add security context to acquire messages using netlink

2006-07-18 Thread Venkat Yekkirala
From: Serge Hallyn [EMAIL PROTECTED] This includes the security context of a security association created for use by IKE in the acquire messages sent to IKE daemons using netlink/xfrm_user. This would allow the daemons to include the security context in the negotiation, so that the resultant

Re: [RFC PATCH 32/33] Add the Xen virtual network device driver.

2006-07-18 Thread Herbert Xu
John Haller [EMAIL PROTECTED] wrote: But sending ARPs is not the right thing if the guest is expecting to use IPv6 networking, in which case unsolicited neighbor advertisements are the right thing to do. The driver just doesn't seem to be the right place to do this, as it doesn't/ shouldn't

Re: Simultanious transmits seems to cause hang on pcnet32

2006-07-18 Thread Don Fry
On Tue, Jul 18, 2006 at 11:20:17AM -0400, Lennart Sorensen wrote: I am currently doing some testing on my system and managing to totally hang the system (so that the watchdog has to come along and reboot it). The setup is this: I have a PLX PCI-PCI bridge with 4 79C972 chips behind it, each

Re: [PATCH] clear skb cb on IP input

2006-07-18 Thread Guillaume Chazarain
chas williams - CONTRACTOR wrote: why does the input side of the ip layer believe the cb contains valid data? it should zero the contents of the cb, or just fill in the cb correctly when the packet arrives at its doorstop. Why not clearing the whole IPCB(skb) instead of just IPCB(skb)-opts?

Re: Simultanious transmits seems to cause hang on pcnet32

2006-07-18 Thread Lennart Sorensen
On Tue, Jul 18, 2006 at 10:57:47AM -0700, Don Fry wrote: I don't know what a 'smartbits test system' is or how it works. Could you please briefly explain what it is and does? It is a network test system built by spirent (www.spirentcom.com). It is mainly a layer 2 test system (you configure

Re: [RFC] NAPI support for forcedeth

2006-07-18 Thread Daniel Drake
Hi Stephen, Stephen Hemminger wrote: Experimental version of NAPI for forcedeth. Untested, but others may want to help with comments and testing. I tested this: it worked for about 2 minutes, then the connection dropped and I was unable to connect to anything. I'll try and find some time

Weird TCP SACK problem. in Linux...

2006-07-18 Thread Oumer Teyeb
Hello Guys, I have some questions regarding TCP SACK implementation in Linux . As I am not a subscriber, could you please cc the reply to me? thanks! I am doing these experiments to find out the impact of reordering. So I have different TCP versions (newReno, SACK, FACk, DSACK, FRTO,) as

Re: [PATCH] clear skb cb on IP input

2006-07-18 Thread Herbert Xu
On Tue, Jul 18, 2006 at 08:19:34PM +0200, Guillaume Chazarain wrote: Why not clearing the whole IPCB(skb) instead of just IPCB(skb)-opts? that would also clear IPCB(skb)-flags. I agree, we should clear the whole IPCB. And, does not ipv6 need the same treatment with IP6CB? Probably.

Re: Strange TCP SACK behaviour in Linux TCP

2006-07-18 Thread Stephen Hemminger
On Tue, 18 Jul 2006 18:20:47 +0200 Oumer Teyeb [EMAIL PROTECTED] wrote: Hello Guys, I have some questions regarding TCP SACK implementation in Linux . As I am a subscriber, could you please cc the reply to me? thanks! I am doing these experiments to find out the impact of reordering. So

Re: Strange TCP SACK behaviour in Linux TCP

2006-07-18 Thread Stephen Hemminger
On Tue, 18 Jul 2006 18:20:47 +0200 Oumer Teyeb [EMAIL PROTECTED] wrote: Hello Guys, I have some questions regarding TCP SACK implementation in Linux . As I am a subscriber, could you please cc the reply to me? thanks! I am doing these experiments to find out the impact of reordering. So

Re: Netchannles: first stage has been completed. Further ideas.

2006-07-18 Thread Evgeniy Polyakov
On Tue, Jul 18, 2006 at 02:15:17PM +0200, J?rn Engel ([EMAIL PROTECTED]) wrote: Your description makes it sound as if you would take a huge leap, changing all in-kernel code _and_ the userspace interface in a single patch. Am I wrong? Or am I right and would it make sense to extract small

Re: [RFC, RFT] Re: [PATCH] d80211: make sleeping in hw-config possible #2

2006-07-18 Thread Michael Buesch
On Tuesday 18 July 2006 18:57, Jiri Benc wrote: On Tue, 11 Jul 2006 00:54:33 +0200, Michael Buesch wrote: This patch makes sleeping in the hw-config callback possible by removing the only atomic caller. The atomic caller was a timer and is replaced by a workqueue. This is a modified

[RFC, RFT] Re: [PATCH] d80211: make sleeping in hw-config possible #2

2006-07-18 Thread Jiri Benc
On Tue, 11 Jul 2006 00:54:33 +0200, Michael Buesch wrote: This patch makes sleeping in the hw-config callback possible by removing the only atomic caller. The atomic caller was a timer and is replaced by a workqueue. This is a modified version of the patch that doesn't use

Re: [RFC, RFT] Re: [PATCH] d80211: make sleeping in hw-config possible #2

2006-07-18 Thread Michael Buesch
On Tuesday 18 July 2006 19:36, Michael Buesch wrote: On Tuesday 18 July 2006 18:57, Jiri Benc wrote: On Tue, 11 Jul 2006 00:54:33 +0200, Michael Buesch wrote: This patch makes sleeping in the hw-config callback possible by removing the only atomic caller. The atomic caller was a timer

Re: [2.6 patch] net/core/user_dma.c should #include net/netdma.h

2006-07-18 Thread David Miller
From: Adrian Bunk [EMAIL PROTECTED] Date: Sat, 15 Jul 2006 02:36:17 +0200 Every file should #include the headers containing the prototypes for its global functions. Especially in cases like this one where gcc can tell us through a compile error that the prototype was wrong...

[PATCH] softmac: ERP handling and driver-level notifications

2006-07-18 Thread Daniel Drake
This patch implements ERP handling in softmac so that the drivers can support protection and preambles properly. I added a new struct, ieee80211softmac_bss_info, which is used for BSS-dependent variables like these. A new hook has been added (bssinfo_change), which allows the drivers to be

[PATCH] ieee80211: small ERP handling additions

2006-07-18 Thread Daniel Drake
This adds a flag to the ieee80211_network structure which indicates whether the stored erp_value is valid (a check against 0 is not enough, since an ERP of 0 is valid and very meaningful). I also added the ERP IE bit-definitions to ieee80211.h. This is needed by some upcoming softmac patches.

[PATCH] softmac: export highest_supported_rate function

2006-07-18 Thread Daniel Drake
zd1211 needs this functionality, no point duplicating it. Signed-off-by: Daniel Drake [EMAIL PROTECTED] Acked-by: Johannes Berg [EMAIL PROTECTED] Index: linux/include/net/ieee80211softmac.h === ---

Re: [PATCH] ieee80211: Make ieee80211_rx_any usable

2006-07-18 Thread Pete Zaitcev
On Tue, 18 Jul 2006 21:38:05 +0100 (BST), Daniel Drake [EMAIL PROTECTED] wrote: --- linux.orig/net/ieee80211/ieee80211_rx.c +++ linux/net/ieee80211/ieee80211_rx.c @@ -779,33 +779,44 @@ int ieee80211_rx(struct ieee80211_device return 0; } -/* Filter out unrelated packets, call

[PATCH] softmac: Add MAINTAINERS entry

2006-07-18 Thread Daniel Drake
Signed-off-by: Daniel Drake [EMAIL PROTECTED] Acked-by: Johannes Berg [EMAIL PROTECTED] diff --git a/MAINTAINERS b/MAINTAINERS index e99028c..ab7d701 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2590,6 +2590,18 @@ P: Nicolas Pitre M: [EMAIL PROTECTED] S: Maintained +SOFTMAC

Re: Netchannles: first stage has been completed. Further ideas.

2006-07-18 Thread David Miller
From: Evgeniy Polyakov [EMAIL PROTECTED] Date: Tue, 18 Jul 2006 23:11:37 +0400 Actually userspace will not see ERESTARTSYS, when it is returned from syscall. This is true only when a signal is pending. It is the signal dispatch code that fixes up the return value either by changing it to

Re: [RFC PATCH 32/33] Add the Xen virtual network device driver.

2006-07-18 Thread David Miller
From: Chris Wright [EMAIL PROTECTED] Date: Tue, 18 Jul 2006 00:00:32 -0700 +#ifdef CONFIG_XEN_BALLOON +#include xen/balloon.h +#endif Let's put the ifdefs in xen/balloon.h not in the files including it. +#ifdef CONFIG_XEN_BALLOON + /* Tell the ballon driver what is going on. */ +

Re: [RFC PATCH 32/33] Add the Xen virtual network device driver.

2006-07-18 Thread Chris Wright
* David Miller ([EMAIL PROTECTED]) wrote: From: Chris Wright [EMAIL PROTECTED] Date: Tue, 18 Jul 2006 00:00:32 -0700 +#ifdef CONFIG_XEN_BALLOON +#include xen/balloon.h +#endif Let's put the ifdefs in xen/balloon.h not in the files including it. +#ifdef CONFIG_XEN_BALLOON + /*

[PATCH Round 4 0/3][RFC] Network Event Notifier Mechanism

2006-07-18 Thread Steve Wise
All, I'm posting this one more time for a definitive decision on pulling in this netevent notifier patch. I've included in this patchset changes to the Infiniband Core to use netevents instead of packet snooping to discover IPoIB ARP changes. See patch 3/3 for the Infiniband changes. Thanks,

[PATCH Round 4 1/3] Network Event Notifier Mechanism.

2006-07-18 Thread Steve Wise
This patch uses notifier blocks to implement a network event notifier mechanism. Clients register their callback function by calling register_netevent_notifier() like this: static struct notifier_block nb = { .notifier_call = my_callback_func }; ... register_netevent_notifier(nb); ---

[PATCH Round 4 2/3] Core network changes to support network event notification.

2006-07-18 Thread Steve Wise
This patch adds netevent and netlink calls for neighbour change, route add/del, pmtu change, and routing redirect events. Netlink Details: Neighbour change events are broadcast as a new ndmsg type RTM_NEIGHUPD. Path mtu change events are broadcast as a new rtmsg type RTM_ROUTEUPD. Routing

[PATCH Round 4 3/3] Cleanup ib_addr module to use the netevent patch.

2006-07-18 Thread Steve Wise
--- drivers/infiniband/core/addr.c | 30 ++ 1 files changed, 14 insertions(+), 16 deletions(-) diff --git a/drivers/infiniband/core/addr.c b/drivers/infiniband/core/addr.c index d294bbc..1205e80 100644 --- a/drivers/infiniband/core/addr.c +++

[PATCH] [IrDA] Use alloc_skb() in IrDA TX path

2006-07-18 Thread Samuel Ortiz
Hi Dave, As pointed out by Christoph Hellwig, dev_alloc_skb() is not intended to be used for allocating TX sk_buff. The IrDA stack was exclusively calling dev_alloc_skb() on the TX path, and this patch fixes that. Signed-off-by: Samuel Ortiz [EMAIL PROTECTED] --- net/irda/af_irda.c

Re: Strange TCP SACK behaviour in Linux TCP

2006-07-18 Thread Oumer Teyeb
Hi Stephen, Thanks for the quick response. I have done what you asked and you can find the files at www.kom.auc.dk/~oumer/sackstuff.tar.gz I have run the different cases 10 times each, NT_NSACK[1-10].dat---no timestamp, no SACK NT_SACK[1-10].datno timestamp, SACK

Re: [PATCH] [IrDA] Use alloc_skb() in IrDA TX path

2006-07-18 Thread David Miller
From: Samuel Ortiz [EMAIL PROTECTED] Date: Wed, 19 Jul 2006 08:13:31 +0300 As pointed out by Christoph Hellwig, dev_alloc_skb() is not intended to be used for allocating TX sk_buff. The IrDA stack was exclusively calling dev_alloc_skb() on the TX path, and this patch fixes that.

Re: [PATCH 0/2] NET: Accurate packet scheduling for ATM/ADSL

2006-07-18 Thread Andy Furniss
Russell Stuart wrote: On Sat, 2006-06-24 at 10:13 -0400, jamal wrote: And yes, I was arguing that the tc scheme you describe would not be so bad either if the cost of making a generic change is expensive. snip Patrick seems to have a simple way to compensate generically for link layer

Re: [PATCH] [IrDA] Use alloc_skb() in IrDA TX path

2006-07-18 Thread Samuel Ortiz
On Tue, Jul 18, 2006 at 03:38:31PM -0700, David Miller wrote: As followups it would be nice to: 2) Change these 64 and 128 constant sizes to something with a name. Yes, this is not nice and I was already working on it. I decided to send this patch soon as I didn't want to hold Christoph's

Re: Netchannles: first stage has been completed. Further ideas.

2006-07-18 Thread Alexey Kuznetsov
Hello! Can I ask couple of questions? Just as a person who looked at VJ's slides once and was confused. And startled, when found that it is not considered as another joke of genuis. :-) About locks: is completely lockless (there is one irq lock when skb is queued/dequeued into

Re: [RFT] Realtek 8168 ethernet support

2006-07-18 Thread Francois Romieu
Francois Romieu [EMAIL PROTECTED] : The patch below agaisnt 2.6.17-rc6 includes the following changes: commit 3072cc0aba3ac0c944e196a63c4154ca5746ec0b r8169: sync with vendor's driver - add several PCI ID for the PCI-E adapters ; - new identification strings ; - the

Re: Netchannles: first stage has been completed. Further ideas.

2006-07-18 Thread David Miller
From: Alexey Kuznetsov [EMAIL PROTECTED] Date: Wed, 19 Jul 2006 03:01:21 +0400 The only improvement in this area suggested in VJ's slides is a lock-free producer-consumer ring. It is missing in your patch and I could guess it is not big loss, it is unlikely to improve something significantly

Re: [PATCH] NET: sun happymeal, little pci cleanup

2006-07-18 Thread David Miller
From: Jiri Slaby [EMAIL PROTECTED] Date: Tue, 18 Jul 2006 16:56:38 -0700 (PDT) NET: sun happymeal, little pci cleanup Use pci_register_driver instead of pci_module_init. Use PCI_DEVICE macro. Signed-off-by: Jiri Slaby [EMAIL PROTECTED] Applied, thanks Jiri. - To unsubscribe from this

Re: [PATCH 0/2] NET: Accurate packet scheduling for ATM/ADSL

2006-07-18 Thread Russell Stuart
On Tue, 2006-07-18 at 22:46 +0100, Andy Furniss wrote: FWIW I think it may be possible to do it Patricks' way, as if I read it properly he will end up with the ATM cell train length which gets shifted by cell_log and looked up as before. The ATM length will be in steps of 53 so with

[PATCH] Conversions from kmalloc+memset to k(z|c)alloc.

2006-07-18 Thread Panagiotis Issaris
From: Panagiotis Issaris [EMAIL PROTECTED] Conversions from kmalloc+memset to k(z|c)alloc. The original memsets did not clear out the entire allocated structure. To my unexperienced eye, that seemed a bit fishy (or at least a bit weird and inconsistent). Signed-off-by: Panagiotis Issaris [EMAIL

ethtool version 4 released

2006-07-18 Thread Jeff Garzik
Available at its standard home page: http://sourceforge.net/projects/gkernel/ Repository: git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/ethtool.git NEWS for this release: Version 4 - July 18, 2006 * Feature: UFO support * Feature: support long options * Features: e1000,

Re: [PATCH] Conversions from kmalloc+memset to k(z|c)alloc.

2006-07-18 Thread John W. Linville
On Wed, Jul 19, 2006 at 03:15:40AM +0200, Panagiotis Issaris wrote: From: Panagiotis Issaris [EMAIL PROTECTED] Conversions from kmalloc+memset to k(z|c)alloc. The original memsets did not clear out the entire allocated structure. To my unexperienced eye, that seemed a bit fishy (or at least

Re: [RFC PATCH 32/33] Add the Xen virtual network device driver.

2006-07-18 Thread Herbert Xu
Stephen Hemminger [EMAIL PROTECTED] wrote: diff -r eadc12b20f35 drivers/xen/netfront/netfront.c --- /dev/null Thu Jan 01 00:00:00 1970 + +++ b/drivers/xen/netfront/netfront.c Fri Jun 09 15:03:12 2006 -0400 @@ -0,0 +1,1584 @@ +static inline void init_skb_shinfo(struct sk_buff *skb) +{

Re: [PATCH] net: Conversions from kmalloc+memset to k(z|c)alloc.

2006-07-18 Thread David Miller
From: [EMAIL PROTECTED] (Panagiotis Issaris) Date: Wed, 19 Jul 2006 03:03:43 +0200 From: Panagiotis Issaris [EMAIL PROTECTED] net: Conversions from kmalloc+memset to kzalloc. Signed-off-by: Panagiotis Issaris [EMAIL PROTECTED] Applied, thanks a lot. One of the ieee80211 cases is even a

Re: [PATCH] Conversions from kmalloc+memset to k(z|c)alloc.

2006-07-18 Thread David Miller
From: John W. Linville [EMAIL PROTECTED] Date: Tue, 18 Jul 2006 22:48:05 -0400 On Wed, Jul 19, 2006 at 03:15:40AM +0200, Panagiotis Issaris wrote: From: Panagiotis Issaris [EMAIL PROTECTED] Conversions from kmalloc+memset to k(z|c)alloc. The original memsets did not clear out the

Wireless statistics for bcm43xx-d80211

2006-07-18 Thread Larry Finger
I have gotten most things working to produce wireless statistics through /proc/net/wireless for bcm43xx-d80211; however, I have one problem that I have not yet been able to solve. When I do a 'cat /proc/net/wireless', the following is printed: Inter-| sta-| Quality| Discarded

Re: Netchannles: first stage has been completed. Further ideas.

2006-07-18 Thread Evgeniy Polyakov
On Wed, Jul 19, 2006 at 03:01:21AM +0400, Alexey Kuznetsov ([EMAIL PROTECTED]) wrote: Hello! Hello, Alexey. Can I ask couple of questions? Just as a person who looked at VJ's slides once and was confused. And startled, when found that it is not considered as another joke of genuis. :-)