[
https://issues.apache.org/jira/browse/NUTCH-258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12467916
]
Sami Siren commented on NUTCH-258:
--
I haven't noticed this being a problem for me, so no objections from here.
Scott Ganyo (JIRA) wrote:
... since Hadoop hijacks and reassigns all log formatters (also a bad
practice!) in the org.apache.hadoop.util.LogFormatter static constructor ...
FYI, Hadoop no longer does this.
Doug
-
Take
It's at least out-of-date and perhaps obsolete. A quick read of
Fetcher.java looks like there might be a case where a fatal error is
logged but the fetcher doesn't exit, in FetcherThread#output().
So this raises an interesting question:
People (such as Scott G.) out there -- are you folks
Hi Doug,
So, does this render the patch that I wrote obsolete?
Cheers,
Chris
On 1/25/07 10:08 AM, Doug Cutting [EMAIL PROTECTED] wrote:
Scott Ganyo (JIRA) wrote:
... since Hadoop hijacks and reassigns all log formatters (also a bad
practice!) in the org.apache.hadoop.util.LogFormatter
Chris Mattmann wrote:
So, does this render the patch that I wrote obsolete?
It's at least out-of-date and perhaps obsolete. A quick read of
Fetcher.java looks like there might be a case where a fatal error is
logged but the fetcher doesn't exit, in FetcherThread#output().
Doug
[
http://issues.apache.org/jira/browse/NUTCH-258?page=comments#action_12429035 ]
Chris A. Mattmann commented on NUTCH-258:
-
Hi Folks,
A patch is available on this issue. Has anyone who was experiencing the
original problem tried out
[
http://issues.apache.org/jira/browse/NUTCH-258?page=comments#action_12422962 ]
Chris A. Mattmann commented on NUTCH-258:
-
Guys,
This issue slipped off my radar for a bt, but I'll have some free time this
week to work on it. If there
[
http://issues.apache.org/jira/browse/NUTCH-258?page=comments#action_12415984 ]
Jerome Charron commented on NUTCH-258:
--
Thanks for this patch Chris - even if now it is outdate by NUTCH-303 :-(
Since Nutch no more use the deprecated Hadoop
Thanks, Chris! (And thank you, Andrzej for interpreting my rantings!)
That plan sounds fantastic and I would be happy to help out.
Scott
On Jun 5, 2006, at 1:01 PM, Chris Mattmann wrote:
Hi Andrzej,
The main problem, as Scott observed, is that the static flag
affects all
instances of
[
http://issues.apache.org/jira/browse/NUTCH-258?page=comments#action_12414762 ]
Scott Ganyo commented on NUTCH-258:
---
For the record: I strongly object to closing this issue for the following
reasons:
1) Having a *side-effect* of the entire system stop
[
http://issues.apache.org/jira/browse/NUTCH-258?page=comments#action_12414763 ]
Stefan Groschupf commented on NUTCH-258:
Scott,
I agree with you. However we need a clean patch to solve the problem, we can
not just comment things out of the code.
Folks,
Before I (or someone else) reopens the issue, I think it's important to
understand the implications:
1) Having a *side-effect* of the entire system stop processing after merely
logging a message at a certain event level is a poor practice.
I'm not sure that the Fetcher quitting is a *
Chris Mattmann wrote:
Folks,
Before I (or someone else) reopens the issue, I think it's important to
understand the implications:
I vote for re-opening. See below.
1) Having a *side-effect* of the entire system stop processing after merely
logging a message at a certain event
Hi Andrzej,
The main problem, as Scott observed, is that the static flag affects all
instances of the task executing inside the same JVM. If there are
several Fetcher tasks (or any other tasks that check for SEVERE flag!),
belonging to different jobs, all of them will quit. This is
Chris Mattmann wrote:
+1
So, to summarize, the proposed resolution is:
* add flag field in Configuration instance to signify whether or not a
SEVERE error has been logged within a task's context
Yes, preferably define this as a public static final String-s in
NutchConfiguration, both
I have a proposal for a simple solution: set a flag in the current
Configuration instance, and check for this flag. The Configuration
instance provides a task-specific context persisting throughout the
lifetime of a task - but limited only to that task. Voila - problem
solved. We get
[
http://issues.apache.org/jira/browse/NUTCH-258?page=comments#action_12414646 ]
Stefan Neufeind commented on NUTCH-258:
---
Agreed. The root-causee of the loop should be identified. So I'd suggest
turning this into a wont-fix-bug - and if it occurs
[
http://issues.apache.org/jira/browse/NUTCH-258?page=comments#action_12414598 ]
Chris A. Mattmann commented on NUTCH-258:
-
Hi there,
I believe that the fetcher halting on a LOG.Severe is the intended behavior of
the system. The use of this
[
http://issues.apache.org/jira/browse/NUTCH-258?page=comments#action_12412705 ]
Stefan Neufeind commented on NUTCH-258:
---
Beware of simply silencing the error! It helped me at one place - but at
another it really caused an infinite loop not to end.
19 matches
Mail list logo