Re: [HACKERS] [sqlsmith] Planner crash on foreign table join

> On Apr 8, 2017, at 7:41 PM, Mark Dilger wrote: > > >> On Apr 8, 2017, at 7:35 PM, Tom Lane wrote: >> >> Mark Dilger writes: >>> This is very near where the original crash reported in this thread was >>> crashing,

Re: [HACKERS] [sqlsmith] Planner crash on foreign table join

> On Apr 8, 2017, at 7:35 PM, Tom Lane wrote: > > Mark Dilger writes: >> This is very near where the original crash reported in this thread was >> crashing, probably only >> different due to the extra lines of Assert that were added. Am I missing

Re: Fwd: Re: [HACKERS] Running make check-world in buildfarm (was Re: [COMMITTERS] pgsql: Use SASLprep to normalize passwords for SCRAM authentication.)

On 04/08/2017 02:49 PM, Andrew Dunstan wrote: > > On 04/08/2017 12:11 PM, Tom Lane wrote: >> Andrew Dunstan writes: I think it's partially knowing which target failed, and which regression.diffs to display. If we were able to revamp check-world so

Re: [HACKERS] [sqlsmith] Planner crash on foreign table join

Mark Dilger writes: > This is very near where the original crash reported in this thread was > crashing, probably only > different due to the extra lines of Assert that were added. Am I missing > some portion of the > fix that you are testing? I have only applied the

Re: [HACKERS] [sqlsmith] Planner crash on foreign table join

> On Apr 8, 2017, at 6:48 PM, Mark Dilger wrote: > > >> On Apr 8, 2017, at 6:38 PM, Mark Dilger wrote: >> >> >>> On Apr 8, 2017, at 5:13 PM, Tom Lane wrote: >>> >>> I wrote: Robert Haas

Re: [HACKERS] [sqlsmith] Planner crash on foreign table join

> On Apr 8, 2017, at 6:38 PM, Mark Dilger wrote: > > >> On Apr 8, 2017, at 5:13 PM, Tom Lane wrote: >> >> I wrote: >>> Robert Haas writes: On Sat, Apr 8, 2017 at 3:57 PM, Tom Lane wrote: I

Re: [HACKERS] [sqlsmith] Planner crash on foreign table join

> On Apr 8, 2017, at 5:13 PM, Tom Lane wrote: > > I wrote: >> Robert Haas writes: >>> On Sat, Apr 8, 2017 at 3:57 PM, Tom Lane wrote: >>> I think it's pretty dubious to change this, honestly. Just because it >>> would have caught

Re: [HACKERS] [sqlsmith] Planner crash on foreign table join

I wrote: > Robert Haas writes: >> On Sat, Apr 8, 2017 at 3:57 PM, Tom Lane wrote: >> I think it's pretty dubious to change this, honestly. Just because it >> would have caught this one bug doesn't make it an especially valuable >> thing in general.

Re: [HACKERS] recent deadlock regression test failures

On Sat, Apr 8, 2017 at 12:56 PM, Tom Lane wrote: > Thomas Munro writes: >> On Sat, Apr 8, 2017 at 4:22 PM, Tom Lane wrote: >> Based on the above, here is a version that introduces a simple boolean >> function

Re: [pgsql-www] [HACKERS] Small issue in online devel documentation build

On Sat, Apr 8, 2017 at 12:50:19PM -0400, Robert Haas wrote: > On Sat, Apr 8, 2017 at 6:39 AM, Bruce Momjian wrote: > > What other problems do we have with pgweb that I can work on? > > Well, the 10devel documentation doesn't believe in orange. Compare: > >

Re: [HACKERS] recent deadlock regression test failures

Kevin Grittner writes: > On Sat, Apr 8, 2017 at 12:56 PM, Tom Lane wrote: >> I'm imagining an API like >> isolation_test_is_waiting_for(int, int[]) returns bool > Good suggestion. > Thomas, would you like to produce a patch along these lines, or >

Re: [HACKERS] recent deadlock regression test failures

... BTW, one other minor coding suggestion for GetSafeSnapshotBlockingPids(): it might be better to avoid doing so much palloc work while holding the SerializableXactHashLock. Even if it's only held shared, I imagine that it's a contention bottleneck. You could avoid that by returning an array

Re: [HACKERS] 2017-03 CF Closed

On 04/08/2017 09:12 AM, Tom Lane wrote: > Michael Paquier writes: >> On Sat, Apr 8, 2017 at 11:27 PM, Andres Freund wrote: >>> Thanks for your work on managing the fest! > >> +1. Great work! > > Seconded. That's a huge amount of

Re: [HACKERS] [sqlsmith] Planner crash on foreign table join

On 2017-04-08 17:20:28 -0400, Tom Lane wrote: > Robert Haas writes: > > On Sat, Apr 8, 2017 at 3:57 PM, Tom Lane wrote: > >> This makes me wonder whether we were being penny-wise and pound-foolish > >> by not making Bitmapsets be a kind of Node, so that

Re: [HACKERS] [sqlsmith] Planner crash on foreign table join

Robert Haas writes: > On Sat, Apr 8, 2017 at 3:57 PM, Tom Lane wrote: >> This makes me wonder whether we were being penny-wise and pound-foolish >> by not making Bitmapsets be a kind of Node, so that there could be IsA >> assertions in the bitmapset.c

Re: [HACKERS] [sqlsmith] Planner crash on foreign table join

Andrew Gierth writes: > "Tom" == Tom Lane writes: > Tom> Experimentation shows that actually, the standard regression tests > Tom> provide dozens of opportunities for find_relation_from_clauses to > Tom> fail on non-RestrictInfo input.

Re: [HACKERS] [sqlsmith] Planner crash on foreign table join

On Sat, Apr 8, 2017 at 3:57 PM, Tom Lane wrote: > This makes me wonder whether we were being penny-wise and pound-foolish > by not making Bitmapsets be a kind of Node, so that there could be IsA > assertions in the bitmapset.c routines, as there are for Lists. Most >

Re: [HACKERS] pgbench - allow to store select results into variables

As the variable infrastructures are pretty different between psql & pgbench (typed vs untyped values, sorted array vs linked list data structure, no hook vs 2 hooks, name spaces vs no such thing...), I have chosen the simplest option of just copying the name checking function and extending

Re: [HACKERS] [sqlsmith] Planner crash on foreign table join

> "Tom" == Tom Lane writes: Tom> Experimentation shows that actually, the standard regression tests Tom> provide dozens of opportunities for find_relation_from_clauses to Tom> fail on non-RestrictInfo input. However, it lacks any IsA check, In a discussion with

Re: [HACKERS] pgbench - allow to store select results into variables

Hello Tatsuo-san, If I understand correctly, the patch is moved because of the unrelated issue that variables cannot be utf8 in pgbench, and it is a condition to consider this patch that existing pgbench variables (set with \set) can be utf8? I'm not sure if it is "unrelated" because the new

Re: [HACKERS] [sqlsmith] Planner crash on foreign table join

I wrote: > Andrew Gierth writes: >> Commit ac2b095088 assumes that clauselist_selectivity is being passed a >> list of RelOptInfo, but postgres_fdw is passing it a list of bare >> clauses. One of them is wrong :-) > It's a bit scary that apparently none of the

Re: [HACKERS] Undefined psql variables

2017-04-08 12:25 GMT+02:00 Fabien COELHO : > > Hello Pavel, > n > >> you proposal disallow client side expressions. >> > > I do agree that some client side expressions are necessary. I do not want > to disallow them. > > I agree so is not possible to mix server side and

Re: Fwd: Re: [HACKERS] Running make check-world in buildfarm (was Re: [COMMITTERS] pgsql: Use SASLprep to normalize passwords for SCRAM authentication.)

On 04/08/2017 12:11 PM, Tom Lane wrote: > Andrew Dunstan writes: >>> I think it's partially knowing which target failed, and which >>> regression.diffs to display. If we were able to revamp check-world so >>> it outputs a list of targets the regression machinery

Re: [HACKERS] Patch: Write Amplification Reduction Method (WARM)

On Wed, Apr 5, 2017 at 11:57 PM, Andres Freund wrote: > On 2017-04-05 09:36:47 -0400, Robert Haas wrote: > > By the way, the "Converting WARM chains back to HOT chains" section of > > README.WARM seems to be out of date. Any chance you could update that > > to reflect the

Re: [HACKERS] recent deadlock regression test failures

Thomas Munro writes: > On Sat, Apr 8, 2017 at 4:22 PM, Tom Lane wrote: >> It seems an entirely principle-free change in the function's definition. > You might say that pg_blocking_pid() is about locking only and not > arbitrary other kinds of

Re: [pgsql-www] [HACKERS] Small issue in online devel documentation build

On Sat, Apr 8, 2017 at 6:39 AM, Bruce Momjian wrote: > What other problems do we have with pgweb that I can work on? Well, the 10devel documentation doesn't believe in orange. Compare: https://www.postgresql.org/docs/devel/static/sql-createtable.html

Re: [HACKERS] [sqlsmith] Planner crash on foreign table join

Andrew Gierth writes: > "Andreas" == Andreas Seltenreich writes: > Andreas> testing master at f0e44021df with a loopback postgres_fdw > Andreas> installed, I see lots of crashes on queries joining foreign > Andreas> tables with various

Re: Fwd: Re: [HACKERS] Running make check-world in buildfarm (was Re: [COMMITTERS] pgsql: Use SASLprep to normalize passwords for SCRAM authentication.)

On 04/08/2017 05:26 PM, Andrew Dunstan wrote: Yes, I don't want just to run check-world. I am aware of a few test sets that need to be added, and I'm planning on doing that this weekend, in fact. Specifically: recovery, subscription, authentication and SSL. Peter Eisentraut raised this with me

Re: [HACKERS] 2017-03 CF Closed

Michael Paquier writes: > On Sat, Apr 8, 2017 at 11:27 PM, Andres Freund wrote: >> Thanks for your work on managing the fest! > +1. Great work! Seconded. That's a huge amount of generally-underappreciated work. regards,

Re: Fwd: Re: [HACKERS] Running make check-world in buildfarm (was Re: [COMMITTERS] pgsql: Use SASLprep to normalize passwords for SCRAM authentication.)

Andrew Dunstan writes: >> I think it's partially knowing which target failed, and which >> regression.diffs to display. If we were able to revamp check-world so >> it outputs a list of targets the regression machinery were able to run >> individually, it'd

Re: [HACKERS] 2017-03 CF Closed

On Sat, Apr 8, 2017 at 11:27 PM, Andres Freund wrote: > Thanks for your work on managing the fest! +1. Great work! -- Michael -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription:

Re: [HACKERS] snapbuild woes

On 4/8/17 10:29 AM, Erik Rijkers wrote: > On 2017-04-08 15:56, Andres Freund wrote: >> On 2017-04-08 09:51:39 -0400, David Steele wrote: >>> On 3/2/17 7:54 PM, Petr Jelinek wrote: >>> > >>> > Yes the copy patch needs rebase as well. But these ones are fine. >>> >>> This bug has been moved to CF

Re: [HACKERS] snapbuild woes

On 2017-04-08 16:29:10 +0200, Erik Rijkers wrote: > On 2017-04-08 15:56, Andres Freund wrote: > > On 2017-04-08 09:51:39 -0400, David Steele wrote: > > > On 3/2/17 7:54 PM, Petr Jelinek wrote: > > > > > > > > Yes the copy patch needs rebase as well. But these ones are fine. > > > > > > This bug

Re: [HACKERS] partitioned tables and contrib/sepgsql

Joe, * Joe Conway (m...@joeconway.com) wrote: > On 04/07/2017 05:36 PM, Robert Haas wrote: > > On Fri, Apr 7, 2017 at 5:22 PM, Joe Conway wrote: > >> 1) commit the 0002 patch now before the feature freeze and follow up > >>with the regression test patch when ready in a

Re: [HACKERS] snapbuild woes

On 2017-04-08 15:56, Andres Freund wrote: On 2017-04-08 09:51:39 -0400, David Steele wrote: On 3/2/17 7:54 PM, Petr Jelinek wrote: > > Yes the copy patch needs rebase as well. But these ones are fine. This bug has been moved to CF 2017-07. FWIW, as these are bug-fixes that need to be

Re: [HACKERS] 2017-03 CF Closed

Hi David, All, Thanks for your work on managing the fest! On 2017-04-08 10:25:06 -0400, David Steele wrote: > Final stats for the commitfest: > > Committed: 116 > Moved to next CF: 50 > Rejected: 2 > Returned with Feedback: 41 > Total: 209. Not a bad haul... - Andres -- Sent via

Re: Fwd: Re: [HACKERS] Running make check-world in buildfarm (was Re: [COMMITTERS] pgsql: Use SASLprep to normalize passwords for SCRAM authentication.)

On 04/08/2017 10:11 AM, Andrew Dunstan wrote: > > > Forwarded Message > Subject: Re: [HACKERS] Running make check-world in buildfarm (was Re: > [COMMITTERS] pgsql: Use SASLprep to normalize passwords for SCRAM > authentication.) > Date: Sat, 8 Apr 2017 07:05:54

[HACKERS] 2017-03 CF Closed

The commitfest has officially ended. I have pushed the remaining patches to the next commitfest or returned then with feedback as appropriate: Features moved to next CF: - new plpgsql extra_checks - Better estimate merging for duplicate vars in clausesel.c - initdb configurable wal_segment_size -

Re: [HACKERS] Remaining 2017-03 CF entries

Hi, On 2017-04-08 13:09:13 +0900, Masahiko Sawada wrote: > Could you consider the item 2PC on FDW as well? It is marked as "Move > to Next CF" early yesterday but I'm not sure that reason.. I've not moved it, but given that it was moved just before the feature freeze, it doesn't seem wrong to me

Re: [HACKERS] postgres_fdw: support parameterized foreign joins

On 4/7/17 9:54 AM, Arthur Zakirov wrote: > > Marked the patch as "Ready for Commiter". But the patch should be > commited only after the patch [1]. This submission has been moved to CF 2017-07. -- -David da...@pgmasters.net -- Sent via pgsql-hackers mailing list

Re: [HACKERS] Push down more UPDATEs/DELETEs in postgres_fdw

On 3/22/17 6:20 AM, Etsuro Fujita wrote: > On 2017/02/22 19:57, Rushabh Lathia wrote: >> Marked this as Ready for Committer. > > I noticed that this item in the CF app was incorrectly marked as > Committed. This patch isn't committed, so I returned it to the previous > status. I also rebased

Re: [HACKERS] Bug in to_timestamp().

On 2/27/17 4:19 AM, Artur Zakirov wrote: > On 15.02.2017 15:26, Amul Sul wrote: >> >> The new status of this patch is: Ready for Committer >> > > Thank you for your review! This submission has been moved to CF 2017-07. -- -David da...@pgmasters.net -- Sent via pgsql-hackers mailing list

Re: [HACKERS] Vacuum: allow usage of more than 1GB of work mem

On 4/7/17 10:19 PM, Claudio Freire wrote: > > I rebased the early free patch (patch 3) to apply on top of the v9 > patch 2 (it needed some changes). I recognize the early free patch > didn't get nearly as much scrutiny, so I'm fine with commiting only 2 > if that one's ready to go but 3 isn't. >

Re: [HACKERS] increasing the default WAL segment size

On 4/7/17 2:59 AM, Beena Emerson wrote: > I ran tests and following are the details: > > Machine details: > Architecture: ppc64le > Byte Order:Little Endian > CPU(s):192 > On-line CPU(s) list: 0-191 > Thread(s) per core:8 > Core(s) per socket:1 >

Re: [HACKERS] Running make check-world in buildfarm (was Re: [COMMITTERS] pgsql: Use SASLprep to normalize passwords for SCRAM authentication.)

On 2017-04-08 23:01:06 +0900, Michael Paquier wrote: > On Sat, Apr 8, 2017 at 7:33 PM, Heikki Linnakangas wrote: > > Hmm. It looks like none of the buildfarm members are running the > > authentication tests. Nor recovery tests, nor subscription tests. We're > > missing a trick

Re: [HACKERS] Crash on promotion when recovery.conf is renamed

On 3/28/17 1:21 AM, Tsunakawa, Takayuki wrote: > From: Michael Paquier [mailto:michael.paqu...@gmail.com] >> Okay. I got the message, and I agree with what you say here. You are right >> by the way, the error messages just use "two-phase file" and not "two-phase >> STATE file", missed that

Re: [HACKERS] WIP: Covering + unique indexes.

On 4/4/17 2:47 PM, Peter Geoghegan wrote: > > At the very least, you should change comments to note the issue. I > think it's highly unlikely that this could ever result in a failure to > find a split point, which there are many defenses against already, but > I think I would find that difficult

Re: [HACKERS] Running make check-world in buildfarm (was Re: [COMMITTERS] pgsql: Use SASLprep to normalize passwords for SCRAM authentication.)

On Sat, Apr 8, 2017 at 7:33 PM, Heikki Linnakangas wrote: > Hmm. It looks like none of the buildfarm members are running the > authentication tests. Nor recovery tests, nor subscription tests. We're > missing a trick here, at least some of the buildfarm members really ought to >

Re: [HACKERS] postgres_fdw bug in 9.6

On 4/7/17 3:24 PM, Robert Haas wrote: > > There's probably more to think about here, but those are my question > on an initial read-through. This bug has been moved to CF 2017-07. -- -David da...@pgmasters.net -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make

Re: [HACKERS] snapbuild woes

On 2017-04-08 09:51:39 -0400, David Steele wrote: > On 3/2/17 7:54 PM, Petr Jelinek wrote: > > > > Yes the copy patch needs rebase as well. But these ones are fine. > > This bug has been moved to CF 2017-07. FWIW, as these are bug-fixes that need to be backpatched, I do plan to work on them

Re: [HACKERS] snapbuild woes

On 3/2/17 7:54 PM, Petr Jelinek wrote: > > Yes the copy patch needs rebase as well. But these ones are fine. This bug has been moved to CF 2017-07. -- -David da...@pgmasters.net -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription:

Re: [HACKERS] Making clausesel.c Smarter

On 4/7/17 5:33 PM, Claudio Freire wrote: > > Also, can you add a test case? Cost values could make the test > fragile, so if that gives you trouble I'll understand, but it'd be > best to try and test this if possible. This submission has been moved to CF 2017-07. -- -David da...@pgmasters.net

Re: [HACKERS] plpgsql - additional extra checks

> On 1/13/17 6:55 AM, Marko Tiikkaja wrote: >> On Fri, Jan 13, 2017 at 2:46 AM, Jim Nasby > > wrote: >> >> On 1/11/17 5:54 AM, Pavel Stehule wrote: >> >> +too_many_rows >> + >> + >> +

Re: [HACKERS] recent deadlock regression test failures

On Sat, Apr 8, 2017 at 4:22 PM, Tom Lane wrote: > Thomas Munro writes: >> Here is an attempt at option 2 from the menu I posted above. Questions: > >> 1. Does anyone object to this extension of pg_blocking_pids()'s >> remit? If so, I could

Re: [pgsql-www] [HACKERS] Small issue in online devel documentation build

On Sat, Apr 8, 2017 at 07:33:15PM +0900, Fabien COELHO wrote: > > >The fix, as Fabien identified, is to conditionally inject additional CSS > >to be _more_ specific than the first CSS and set the font-size to a > >simple '1em' so the first CSS is not called twice. I don't think > >'important!'

[HACKERS] Running make check-world in buildfarm (was Re: [COMMITTERS] pgsql: Use SASLprep to normalize passwords for SCRAM authentication.)

On 04/08/2017 04:23 AM, Tom Lane wrote: Heikki Linnakangas writes: Use SASLprep to normalize passwords for SCRAM authentication. The test script that this adds appears to fail unless the environment selects a UTF8-based locale. On my RHEL6 machine, I see: LANG=C

Re: [pgsql-www] [HACKERS] Small issue in online devel documentation build

The fix, as Fabien identified, is to conditionally inject additional CSS to be _more_ specific than the first CSS and set the font-size to a simple '1em' so the first CSS is not called twice. I don't think 'important!' is necessary but it would be good to test this. I did not wrote the fix,

Re: [HACKERS] Undefined psql variables

Hello Pavel, n you proposal disallow client side expressions. I do agree that some client side expressions are necessary. I do not want to disallow them. I agree so is not possible to mix server side and client side expressions. My point is that a minimal of cross-support is possible.

Re: [HACKERS] [PATCH] Add GUCs for predicate lock promotion thresholds

Kevin Grittner writes: > Unfortunately, I was unable to get the follow-on patch to allow > setting by relation into a shape I liked. Let's see what we can do > for the next release. Okay, I'll try and crete a more comprehensive version of it for the next commitfest. > The

Re: [HACKERS] [sqlsmith] Planner crash on foreign table join

> "Andreas" == Andreas Seltenreich writes: Andreas> Hi, Andreas> testing master at f0e44021df with a loopback postgres_fdw Andreas> installed, I see lots of crashes on queries joining foreign Andreas> tables with various expressions. Below is a reduced recipe

Re: [HACKERS] PoC plpgsql - possibility to force custom or generic plan

2017-04-08 2:30 GMT+02:00 Peter Eisentraut : > On 4/6/17 14:32, Pavel Stehule wrote: > > I like to see any proposals about syntax or implementation. > > > > Using PRAGMA is one variant - introduced by PLpgSQL origin - Ada > > language. The PRAGMA syntax can be

[HACKERS] [sqlsmith] Planner crash on foreign table join

Hi, testing master at f0e44021df with a loopback postgres_fdw installed, I see lots of crashes on queries joining foreign tables with various expressions. Below is a reduced recipe for the regression database and a backtrace. regards, Andreas --8<---cut