Re: Regression in v7.2.10 - ui-dbus.so requires -fPIC

2024-03-18 Thread Michael Tokarev
18.03.2024 10:35, Marc-André Lureau wrote: .. dbus-display1 is also used with static linking for the unit test. It looks like the simplest is to let the actual target decide how it is built, even if it is compiled multiple time then: - dbus_display1_lib = static_library('dbus-display1',

Re: Regression in v7.2.10 - ui-dbus.so requires -fPIC

2024-03-18 Thread Olaf Hering
Mon, 18 Mar 2024 11:35:54 +0400 Marc-André Lureau : > Alternatively, we could always build with pic: true (or pic: > enable_modules), but that's not ideal either. I'm sure that unconditionally building with -fPIC has no downsides in this context. Olaf pgpGUQPNKGONs.pgp Description: Digitale

Re: Regression in v7.2.10 - ui-dbus.so requires -fPIC

2024-03-18 Thread Marc-André Lureau
Hi On Sun, Mar 17, 2024 at 11:10 AM Michael Tokarev wrote: > > 17.03.2024 01:19, Olaf Hering: > > Sat, 16 Mar 2024 22:40:14 +0300 Michael Tokarev : > > > >> meson: ensure dbus-display generated code is built before other units > >> (cherry picked from commit

Re: Regression in v7.2.10 - ui-dbus.so requires -fPIC

2024-03-17 Thread Michael Tokarev
17.03.2024 01:19, Olaf Hering: Sat, 16 Mar 2024 22:40:14 +0300 Michael Tokarev : meson: ensure dbus-display generated code is built before other units (cherry picked from commit 1222070e772833c6875e0ca63565db12c22df39e) "static_library" is used often. Some use the 'pic' option,

Re: Regression in v7.2.10 - ui-dbus.so requires -fPIC

2024-03-16 Thread Olaf Hering
Sat, 16 Mar 2024 22:40:14 +0300 Michael Tokarev : > meson: ensure dbus-display generated code is built before other units > (cherry picked from commit 1222070e772833c6875e0ca63565db12c22df39e) "static_library" is used often. Some use the 'pic' option, which fixes the issue. I think

Re: Regression in v7.2.10 - ui-dbus.so requires -fPIC

2024-03-16 Thread Michael Tokarev
15.03.2024 00:00, Olaf Hering wrote: ui-dbus.so is a shared library. But it is apparently handled differently than all the other shared libraries: it is not compiled with -fPIC. As a result it fails to link. Not sure why this happens only here. Everything up to v7.2.9 was fine. Looking at some