Re: [CVS] RPM: rpm/lib/ filetriggers.c

2008-12-23 Thread Jeff Johnson
This patch isn't needed. system.h will include config.h if -DHAVE_CONFIG_H is defined in CFLAGS, which is done throughout rpm. And RPM_VENDOR_FOO is passed through CFLAGS, not config.h, simpilarly to -DHAVE_CONFIG_H. See your change to the AutoFu for one example ;-) 73 de Jeff On Dec 22,

Re: [CVS] RPM: rpm/lib/ filetriggers.c

2008-12-23 Thread Jeff Johnson
On Dec 23, 2008, at 4:57 PM, Jeff Johnson wrote: This patch isn't needed. system.h will include config.h if -DHAVE_CONFIG_H is defined in CFLAGS, which is done throughout rpm. And RPM_VENDOR_FOO is passed through CFLAGS, not config.h, simpilarly to -DHAVE_CONFIG_H. If you __DO__ insist on

Re: [CVS] RPM: rpm/lib/ filetriggers.c

2008-12-23 Thread Per Øyvind Karlsen
2008/12/23 Jeff Johnson n3...@mac.com On Dec 23, 2008, at 4:57 PM, Jeff Johnson wrote: This patch isn't needed. system.h will include config.h if -DHAVE_CONFIG_H is defined in CFLAGS, which is done throughout rpm. And RPM_VENDOR_FOO is passed through CFLAGS, not config.h, simpilarly to

Re: [CVS] RPM: rpm/lib/ filetriggers.c

2008-12-23 Thread Jeff Johnson
On Dec 23, 2008, at 5:34 PM, Per Øyvind Karlsen wrote: \ #include system.h #if defined(RPM_VENDOR_MANDRIVA) Yes, but then some stuff would be compiled into filetriggers.o. If that is true (try by verifying non-zero-length filetriggers.o please), then something else is in need of