Re: [Spacewalk-devel] [PATCH] SSH Push Feature Proposal

2013-04-30 Thread Duncan Mac-Vicar P.
On 24/04/13 14:38, Johannes Renner wrote: Frankly, the first scenario does not sound that interesting to me. Access to and from DMZ is typically closed from/to all other networks as well and only opened in a very targeted fashion. The IT of that organization would still need to allow access

Re: [Spacewalk-devel] [PATCH] avoid relying on types returned by Hibernate

2013-07-02 Thread Silvio Moioli
On 07/01/2013 05:14 PM, Tomas Lestach wrote: All right, so in case the bug does not evince in current Spacewalk, will it be visible when we upgrade to newer hibernate (which version) or any other component? As far as I know, patched code is fragile regardless of Hibernate version (we

Re: [Spacewalk-devel] [PATCH] Adding a password strength meter to spacewalk

2014-01-06 Thread Silvio Moioli
On 12/20/2013 05:15 PM, R P Herrold wrote: This seems to pull in new dependencies, doesn't it? This merely adds some new Javascript files - that is standard practice in Spacewalk AFAIU, since packaging rules for Web resources in Fedora are still in draft and the Spacewalk community has not

Re: [Spacewalk-devel] Things that needs to be dobne before next release.

2014-01-09 Thread Duncan Mac-Vicar P.
On 09/01/14 13:26, Matej Kollar wrote: Major things that we currently consider release blockers for 2.1 from UI point of view are: * Things from [1] * Date picker * Human readable dates For this one, I was blocked by the perl list, for which I just sent a second patch. If anyone has

Re: [Spacewalk-devel] [PATCH] Adding a password strength meter to spacewalk

2014-01-21 Thread Maximilian Meister
On 01/07/2014 12:04 PM, Michael Mraka wrote: Is it possible to keep original pwstrength-bootstrap*.js unmodified and put modification to the separate .js (call modified functions from the page and call original functions from them)? Hi Michael, I end up with 2 separate .js files now. First

Re: [Spacewalk-devel] [RFC] showing timestamps in Spacewalk

2014-01-28 Thread Duncan Mac-Vicar P.
. I see date wrapped with time/time but no translation (e.g. on /network/systems/details/history/pending.pxt). No, I did some examples but did not include them in the patch. I think case by case we should define if for a displayed date it makes more sense the calendar or ago style. -- Duncan

Re: [Spacewalk-devel] [PATCH] Adding a password placeholder check when editing a user.

2014-01-29 Thread Maximilian Meister
On 01/29/2014 01:19 PM, Maximilian Meister wrote: Hi Michael, I have tried this in my first attempt, but the html:password struts tag doesn't accept the attribute placeholder=**. to reformulate my statement a bit, the html:password struts tag doesn't know any placeholder attribute.

Re: [Spacewalk-devel] [PATCH] Date/Time picker

2014-02-14 Thread Silvio Moioli
On 02/14/2014 03:16 PM, Michael Mraka wrote: should likely be / otherwise it produce opening tags not self closed tags. Actually in HTML5 void tags do not need the slash (it is optional). http://www.w3.org/TR/html-markup/syntax.html#void-element self-closing as a definition does not exist

Re: [Spacewalk-devel] On picking a standard on HTML5 void tags

2014-02-18 Thread Duncan Mac-Vicar P.
. As for patch rejection - no, most likely the other way round :). I am fine with using self-closing tags as long as everyone is aware that using it in a non-void tag will create bad markup and understand that the browser will just remove the /'s. It happened with i class=iconclass/ already, which

Re: [Spacewalk-devel] Introducing tetra

2015-04-21 Thread Silvio Moioli
Commons Collections 3.x and JDK 8: https://issues.apache.org/jira/browse/COLLECTIONS-527 Solution would be to either use JDK 7 or patch sources. I updated the example to Commons Collections 4 not to confuse first-time users. Thanks for reporting. I know that building of java packages with all

Re: [Spacewalk-devel] [PATCHES] two patches for SUSE support

2012-01-17 Thread Michael Calmer
Hi, Am Dienstag, 17. Januar 2012, 10:54:45 schrieb Jan Pazdziora: On Mon, Jan 16, 2012 at 04:48:17PM +0100, Michael Calmer wrote: [...] Renamed in Spacewalk master and rhn-client-tools-1.7.5-1. Thanks for pointing this issue out. Thanks. I have a new patch attached which define

[Spacewalk-devel] Timezone problem with DB timestamps

2012-07-30 Thread Johannes Renner
info about the timezone!). A generic fix could maybe look like the attached patch, see here for javadoc of the proposed method: http://docs.oracle.com/javase/6/docs/api/java/sql/ResultSet.html#getTimestamp%28java.lang.String,%20java.util.Calendar%29 Otherwise we could also fix the package build

Re: [Spacewalk-devel] Twitter Bootstrap: Standardizing the CSS framework?

2013-07-26 Thread Duncan Mac-Vicar P.
On 26/07/13 09:05, Tomas Lestach wrote: Hello Duncan, I wasn't able to apply your patch. Could you send your patch rebased on latest master? Or at least write me against what commit I shall apply it. It seems that java/code/webapp/WEB-INF/includes/header.jsp version against

Re: [Spacewalk-devel] [PATCH] Query not elaborated?

2012-08-13 Thread Johannes Renner
if they get elaborated later on. So I am coming up with two patch proposals, since I am not really sure about how we are intended to solve the problem: - The first patch fixes it by calling elaborate() manually once I wouldn't call the elaborate method manually. Since the mechanism has worked

[Spacewalk-devel] [Patch] patches for openSUSE clients

2012-10-31 Thread Michael Calmer
Nürnberg) From 0f2dc898aeace073e20162b4cfb656ca3ad5523d Mon Sep 17 00:00:00 2001 From: Michael Calmer m...@suse.de Date: Sun, 22 Apr 2012 16:33:37 +0200 Subject: [PATCH 01/10] BuildRequire docbook-style-xsl only on redhat --- spacewalk/pylint/spacewalk-pylint.spec | 2 +- 1 file changed, 1 insertion

Re: [Spacewalk-devel] [PATCH] updateinfo to Errata import in?spacewalk-repo-sync

2011-03-11 Thread Jan Pazdziora
. Here is an example from openSUSE which shows the unique problem updates !--PATCHINFO id=898568de8313f62fc290e303946cfe11!-- update status=stable from=maint-co...@suse.de type=recommended version=1596 idflash-player/id issued date=1256155647/ [...] update status=stable from=maint-co

Re: [Spacewalk-devel] [PATCH] Query not elaborated?

2012-08-07 Thread Michael Calmer
Hi, Am Montag, 6. August 2012, 17:59:12 schrieb Tomas Lestach: Hello Johannes, On Friday 03 of August 2012 12:44:11 Johannes Renner wrote: Hi, [...] So I am coming up with two patch proposals, since I am not really sure about how we are intended to solve the problem: - The first

Re: [Spacewalk-devel] [PATCH] fix metadata - generate pre flag into primary.xml

2013-07-11 Thread Tomas Lestach
Hello Michael, I committed your patch as: https://git.fedorahosted.org/cgit/spacewalk.git/commit/?id=2063afa928d7145620c5a81a5df4dd6e6e7c2071 Thank you! Tomas -- Tomas Lestach Red Hat Satellite Engineering, Red Hat - Original Message - From: Michael Calmer m...@suse.de To: spacewalk

Re: [Spacewalk-devel] [PATCH] UpdateErrataCacheCommand: log an error when orgId is incorrect

2013-09-09 Thread Grant Gainey
, esp on a fast multi-core machine, we fill the logs with NPEs. In the normal workflow, the window where this patch would be useful is very very *very* small - but it does still exist. And in the general case, the patch is harmless. I vote we take it, it cleans up a mess in the test-logs

[Spacewalk-devel] [PATCH] some patches for monitoring on postgres and pylint findings

2011-11-28 Thread Michael Calmer
ffc17d8bce7322d8108d55293dd6e411157d3196 Mon Sep 17 00:00:00 2001 From: Michael Calmer m...@suse.de Date: Sun, 27 Nov 2011 15:35:12 +0100 Subject: [PATCH 1/6] add missing import E:132,54:ConfigManagement.management_remove_channel: Undefined variable 'sys' --- .../handlers/config_mgmt/rhn_config_management.py |1 + 1

[Spacewalk-devel] [PATCH] Query not elaborated?

2012-08-03 Thread Johannes Renner
3a688e6570caa2ef2a4d0a20ffbf3f9237865efe Mon Sep 17 00:00:00 2001 From: Johannes Renner jren...@suse.de Date: Fri, 3 Aug 2012 12:13:49 +0200 Subject: [PATCH] Call elaborate manually --- .../redhat/rhn/manager/channel/ChannelManager.java |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

Re: [Spacewalk-devel] using XML RPC to create a virtual machine fails

2011-06-28 Thread Tomas Lestach
Hello Uwe, thanks for your patch. I divided it into two separate commits, since both fix different issues. http://git.fedorahosted.org/git/?p=spacewalk.git;a=commitdiff;h=619818bacae4d5e988d2959ffce76feed1562a31;hp=2f15fa6f0d6d1be52fb7f3acfe024480c2c5ac62 http://git.fedorahosted.org/git/?p

Re: [Spacewalk-devel] erratas and the client plugin package action

2011-10-17 Thread Ionuț Arțăriși
this patch? (zypp-plugin-spacewalk currently depends on this capability being provided to install patches correctly). Thank you, Ionuț From 35e7d4257942ac91c21d7120ed5d874032629b72 Mon Sep 17 00:00:00 2001 From: Michael Calmer m...@suse.de Date: Wed, 6 Jul 2011 17:51:04 +0200 Subject: [PATCH] add

Re: [Spacewalk-devel] [PATCH] Naming of cloned errata

2012-03-30 Thread Johannes Renner
().substring(3); String clonedAdvisory = CL + published.getAdvisory().substring(3); The reason for doing it like this might have been a small sized field in the database, but AFAIK we already upstreamed a patch to enlarge the respective field. Since cloned errata currently end up with rather strange

Re: [Spacewalk-devel] [PATCH] avoid relying on types returned by Hibernate

2013-07-01 Thread Tomas Lestach
Hello Silvio, - Original Message - From: Silvio Moioli smoi...@suse.de To: spacewalk-devel@redhat.com Sent: Monday, June 10, 2013 3:31:07 PM Subject: [Spacewalk-devel] [PATCH] avoid relying on types returned by Hibernate Hi, we had a downstream bug that boiled down

Re: [Spacewalk-devel] [PATCH] fix metadata - generate pre flag into primary.xml

2013-07-05 Thread Michael Calmer
-- SUSE LINUX Products GmbH, GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer HRB 16746 (AG Nürnberg) From f4c6227bd191fe6dcaed36b60cbd1060d6286e9d Mon Sep 17 00:00:00 2001 From: Michael Calmer m...@suse.de Date: Fri, 5 Jul 2013 13:52:34 +0200 Subject: [PATCH] Generate pre flag

Re: [Spacewalk-devel] [PATCH] Make CSV Separator Character Configurable

2013-08-20 Thread Tomas Lestach
choose the separator for every single CSV Download (and optionally store the last used value as user default). Regards, -- Tomas Lestach Red Hat Satellite Engineering, Red Hat - Original Message - From: Johannes Renner jren...@suse.de To: spacewalk-devel@redhat.com Sent: Monday, August

Re: [Spacewalk-devel] [PATCH] Allow null as createdBy and lastModifiedBy for custom data values

2014-01-23 Thread Johannes Renner
. I tested with searching by Custom Info. Hello, I can reproduce it using your insert statement (with existing server and key ids of course). This was with a previous version of our product, though, since this was currently the only server around not having that patch installed. I can

[Spacewalk-devel] [PATCH] 'es improve channel status display

2013-02-11 Thread Duncan Mac-Vicar P.
: Duncan Mac-Vicar P dmacvi...@suse.de Date: Wed, 30 Jan 2013 18:30:09 +0100 Subject: [PATCH 2/6] Do not silence catched exceptions. Debugging can be hard. --- java/code/src/com/redhat/rhn/taskomatic/TaskoRun.java |1 + 1 file changed, 1 insertion(+) diff --git a/java/code/src/com/redhat/rhn

[Spacewalk-devel] [PATCH] Add support for uploaded files in mocked requests, fix CryptoKeyCreateActionTest

2013-09-13 Thread Silvio Moioli
() { +// nothing to do since this is just a stub +} } } -- 1.8.1.4 From 9109c7911c5fe922d51fa7a20019884c6bc0e611 Mon Sep 17 00:00:00 2001 From: Silvio Moioli smoi...@suse.de Date: Tue, 10 Sep 2013 11:52:48 +0200 Subject: [PATCH 09/22] CryptoKeyCreateActionTest: do

Re: [Spacewalk-devel] [PATCH] Refactor listing of channels: RedHat.do - Vendor.do

2011-07-05 Thread Johannes Renner
Renner jren...@suse.de Date: Tue, 5 Jul 2011 12:48:33 +0200 Subject: [PATCH] Refactor and deprecate API method to listVendorChannels --- .../frontend/xmlrpc/channel/ChannelHandler.java| 26 +-- 1 files changed, 23 insertions(+), 3 deletions(-) diff --git a/java/code/src/com

[Spacewalk-devel] [PATCH] Avoid a possible concurrency issue on RhnSet update

2013-08-29 Thread Silvio Moioli
/docs/9.2/static/transaction-iso.html -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg Germany From ca96039fb3edc31f05427f0f70ce278174f905b1 Mon Sep 17 00:00:00 2001 From: Silvio Moioli smoi...@suse.de Date: Mon, 26 Aug 2013 18:37:19 +0200 Subject: [PATCH] Avoid issues

[Spacewalk-devel] [PATCH] AdvDataSourceTest: do not rely on test execution order

2013-08-29 Thread Silvio Moioli
Germany From 895b40c753fe63ee00bf740b778f9ad83157e1e6 Mon Sep 17 00:00:00 2001 From: Silvio Moioli smoi...@suse.de Date: Thu, 29 Aug 2013 14:31:44 +0200 Subject: [PATCH] AdvDataSourceTest: do not rely on test execution order --- .../db/datasource/test/AdvDataSourceTest.java | 43

[Spacewalk-devel] [PATCH] Make taskomatic max memory configurable via rhn.conf

2013-09-13 Thread Johannes Renner
(AG Nürnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer From bff7c320b8b6a20f1f829982a166077e07989afa Mon Sep 17 00:00:00 2001 From: Johannes Renner jren...@suse.de Date: Fri, 13 Sep 2013 11:11:13 +0200 Subject: [PATCH] Make taskomatic max memory configurable via rhn.conf --- java/scripts

Re: [Spacewalk-devel] [PATCH] updateinfo to Errata import in spacewalk-repo-sync

2011-03-07 Thread Michael Calmer
Hi, Am Montag, 7. März 2011, 15:05:36 schrieb Miroslav Suchý: On 03/07/2011 02:28 PM, Michael Calmer wrote: Hello, the attached patch set implements updateinfo to errata import in spacewalk-repo-sync. This patch also requires two small changes to yum. Patches are also attached

Re: [Spacewalk-devel] [PATCH] Pam setting on the user page not saving

2011-10-12 Thread Johannes Renner
On 10/12/2011 05:00 PM, Tomas Lestach wrote: Hello Johannes, yes, you're right. I just have one comment to your patch - I'd move updatePamAttribute() in SelfEditAction.java file into the updateDetails method. If you're ok with the change, I'd commit it. Let me know. Yes, I was just

Re: [Spacewalk-devel] erratas and the client plugin package action

2011-10-17 Thread Jan Pazdziora
capability. So can you please apply this patch? (zypp-plugin-spacewalk currently depends on this capability being provided to install patches correctly). Thank you, Ionuț From 35e7d4257942ac91c21d7120ed5d874032629b72 Mon Sep 17 00:00:00 2001 From: Michael Calmer m...@suse.de Date: Wed, 6 Jul

[Spacewalk-devel] [PATCH] fix metadata - generate pre flag into primary.xml

2013-07-05 Thread Michael Calmer
5908262665c2db84246ddf6d3739d58ce5c4f6a4 Mon Sep 17 00:00:00 2001 From: Michael Calmer m...@suse.de Date: Fri, 5 Jul 2013 13:52:34 +0200 Subject: [PATCH] Generate pre flag into the metadata --- .../redhat/rhn/taskomatic/task/repomd/PrimaryXmlWriter.java | 11 +++ 1 file changed, 11

Re: [Spacewalk-devel] [PATCH] Make CSV Separator Character Configurable

2013-08-20 Thread Johannes Renner
, here is a small feature patch that allows users to choose semicolon (;) as an alternative to comma (,) for the delimiter in all downloadable CSV files that we generate from the webapp. This seems to be helpful for importing those files into MS Excel for example. Unfortunately we had

Re: [Spacewalk-devel] [PATCH] Fix javascript Uncaught TypeError

2013-08-28 Thread Tomas Lestach
Message - From: Johannes Renner jren...@suse.de To: spacewalk-devel@redhat.com Sent: Tuesday, August 27, 2013 1:28:33 PM Subject: [Spacewalk-devel] [PATCH] Fix javascript Uncaught TypeError Hello, I really don't know how this could have been working before, but the attached patch

Re: [Spacewalk-devel] [PATCH] UpdateErrataCacheCommand: log an error when orgId is incorrect

2013-09-09 Thread Tomas Lestach
organization gets deleted before the background errata cache action gets executed.) Regards, -- Tomas Lestach Red Hat Satellite Engineering, Red Hat - Original Message - From: Silvio Moioli smoi...@suse.de To: spacewalk-devel@redhat.com Sent: Monday, September 9, 2013 8:27:56 AM Subject

Re: [Spacewalk-devel] [PATCH] Fix field length of erratum-advisory-name

2013-09-16 Thread Tomas Lestach
Right, I committed your patch as: 8d32ba46e92c1338c2a775df61688bfdcc8cbcdc Thank you! -- Tomas Lestach Red Hat Satellite Engineering, Red Hat - Original Message - From: Michael Calmer m...@suse.de To: spacewalk-devel@redhat.com Sent: Thursday, September 12, 2013 5:09:10 PM Subject

Re: [Spacewalk-devel] [PATCH] Adding a password strength meter to spacewalk

2014-01-08 Thread Maximilian Meister
On 01/08/2014 02:34 PM, Michael Mraka wrote: As it's new feature in spacewalk I'd vote for using current latest version of pwstrength-bootstrap. Okay, I'll work out a new patch with the latest version in the following days. I understand it. In such cases where we need to modify upstream

Re: [Spacewalk-devel] [PATCH] Single-system reboot page ported to Java

2014-01-22 Thread Matej Kollar
Thanks for your patchs, I have applied/pushed them to the master. -- Matej Kollar Satellite Engineering, Red Hat - Original Message - From: Silvio Moioli smoi...@suse.de To: spacewalk-devel@redhat.com Sent: Tuesday, January 21, 2014 6:19:49 PM Subject: Re: [Spacewalk-devel] [PATCH

[Spacewalk-devel] [PATCH] Patch synchronization issue

2013-08-21 Thread Silvio Moioli
:00:00 2001 From: Silvio Moioli smoi...@suse.de Date: Tue, 20 Aug 2013 17:25:00 +0200 Subject: [PATCH] Allow Hibernate to distinguish packages with identical name, arch and evr --- java/code/src/com/redhat/rhn/domain/rhnpackage/Package.java | 12 ++-- 1 file changed, 6 insertions(+), 6

[Spacewalk-devel] [PATCH] NPE when scheduling a package (install/remove/upgrade) action + remote command

2011-09-08 Thread Johannes Renner
d9fa52242fdae2302d4d1ba06eb2c181df0ba6ed Mon Sep 17 00:00:00 2001 From: Johannes Renner jren...@suse.de Date: Thu, 8 Sep 2011 14:58:43 +0200 Subject: [PATCH] Fix NPE when scheduling a package action + remote command --- .../rhn/domain/action/script/ScriptAction.java |4 +++- .../action/rhnpackage/ScheduleRemoteCommand.java

[Spacewalk-devel] [PATCH] Insert pxt session errors on postgres

2012-08-15 Thread Johannes Renner
...@suse.de Date: Wed, 15 Aug 2012 15:23:59 +0200 Subject: [PATCH] Fix insert pxt session for postgres when not logged in --- .../postgres/procs/create_pxt_session.sql |2 +- .../124-create_pxt_session.sql.oracle |1 + .../124-create_pxt_session.sql.postgresql

[Spacewalk-devel] [PATCH] WebUI HTTP proxy validator doesn't check for special characters

2012-11-14 Thread Johannes Renner
Products GmbH, HRB 16746 (AG Nürnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer From 9628af3c615588d24d6be31d999b19e0532fdf24 Mon Sep 17 00:00:00 2001 From: Johannes Renner jren...@suse.de Date: Wed, 14 Nov 2012 14:54:35 +0100 Subject: [PATCH] Check hostnames for special characters

[Spacewalk-devel] [PATCH] Errors with unrequired field Prefix

2012-11-15 Thread Johannes Renner
on PG only. Thanks, Johannes -- SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer From 7e095b96cc5d104b76cb0121ed8dc89e62ce50eb Mon Sep 17 00:00:00 2001 From: Johannes Renner jren...@suse.de Date: Thu, 15 Nov 2012 15:21:55 +0100 Subject: [PATCH] Fix

[Spacewalk-devel] [PATCH] Kickstartable channels should contain the anaconda package

2013-03-13 Thread Johannes Renner
From: Johannes Renner jren...@suse.de Date: Wed, 13 Mar 2013 17:00:01 +0100 Subject: [PATCH] Kickstartable channels should contain the anaconda package --- .../src/com/redhat/rhn/common/conf/ConfigDefaults.java|1 + .../src/com/redhat/rhn/domain/channel/ChannelFactory.java | 13

[Spacewalk-devel] Patch: improve MethodUtil determinism

2013-08-14 Thread Silvio Moioli
, 90409 Nürnberg Germany From 512281755d750b8188302917db905998e58e7b64 Mon Sep 17 00:00:00 2001 From: Silvio Moioli smoi...@suse.de Date: Wed, 14 Aug 2013 14:49:26 +0200 Subject: [PATCH] Make callMethod() and invokeStaticMethod() deterministic when multiple methods qualify for calling --- .../src

[Spacewalk-devel] [PATCH] com.redhat.rhn.common.db.datasource tests: get database username from configuration file

2013-08-29 Thread Silvio Moioli
Hi, it seems that some test cases in the com.redhat.rhn.common.db.datasource.test package have hardcoded database user names, which does not really work with our setup. I propose the attached patch to simply get the database name from rhn.conf. I am not really sure I understand why

[Spacewalk-devel] [PATCH] ChannelTest: do not assume a proxy channel family exists

2013-08-29 Thread Silvio Moioli
...@suse.de Date: Thu, 29 Aug 2013 11:23:00 +0200 Subject: [PATCH] ChannelTest: do not assume a proxy channel family exists --- .../rhn/domain/channel/test/ChannelFamilyFactoryTest.java | 14 +- .../com/redhat/rhn/domain/channel/test/ChannelTest.java| 9 + 2 files changed

[Spacewalk-devel] [PATCH] RequestContext.buildPageLink: force parameter ordering

2013-09-12 Thread Silvio Moioli
. In the attached patch I propose using a TreeMap instead, which produces a reliable ordering. Regards, -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg Germany From 984f3b48a370276bec7d3eedf0f114ed6ce07465 Mon Sep 17 00:00:00 2001 From: Silvio Moioli smoi...@suse.de Date

[Spacewalk-devel] [PATCH] Adding a password placeholder check when editing a user.

2014-01-28 Thread Maximilian Meister
password will contain the placeholder instead of my expectation [oldpassnewchars]. That could lead to locking out of a user. This patch makes sure that you can't lock yourself out accidentally like this. -- -- Mit freundlichen Grüßen, Maximilian Meister Systems Management Department SUSE LINUX

[Spacewalk-devel] [PATCHES] another patch set fixing PG SQL statements and other things

2011-12-08 Thread Michael Calmer
2001 From: Michael Calmer m...@suse.de Date: Fri, 2 Dec 2011 14:49:51 +0100 Subject: [PATCH 01/11] convert decode to case --- web/modules/rhn/RHN/DB/ContactMethod.pm |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/web/modules/rhn/RHN/DB/ContactMethod.pm b/web/modules/rhn/RHN

Re: [Spacewalk-devel] All relevant errata as All Errata

2012-03-05 Thread Duncan Mac-Vicar P.
From f6fcded8d4c718c1089d1aa31ee75196fd7a59db Mon Sep 17 00:00:00 2001 From: Duncan Mac-Vicar P dmacvi...@suse.de Date: Mon, 5 Mar 2012 13:27:53 +0100 Subject: [PATCH 1/2] Rename All Errata to All Types as we are refering to Erratas of all types (Bugfixes, Security) and it can be confused

[Spacewalk-devel] [PATCHES] CVE-ID changing syntax in 2014

2014-01-15 Thread Michael Calmer
: Jeff Hawn, Jennifer Guild, Felix Imendörffer HRB 16746 (AG Nürnberg) From 4e83d44ba79b8073ee994810c64ab6a7e4a0c850 Mon Sep 17 00:00:00 2001 From: Michael Calmer m...@suse.de Date: Wed, 15 Jan 2014 10:32:33 +0100 Subject: [PATCH 1/3] increase length of rhnCVE name column --- schema/spacewalk/common

Re: [Spacewalk-devel] [PATCH] update uptime quickly after reboot

2012-11-11 Thread Michael Calmer
-- SUSE LINUX Products GmbH, GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer HRB 16746 (AG Nürnberg)From 890305befa72239eaeadc1e9923de50bed36f7ea Mon Sep 17 00:00:00 2001 From: Michael Calmer m...@suse.de Date: Sun, 11 Nov 2012 15:42:37 +0100 Subject: [PATCH 5/5] call rhn-update-status

Re: [Spacewalk-devel] Deployment of images built with SUSE Studio

2012-06-06 Thread Johannes Renner
...@suse.de Date: Wed, 6 Jun 2012 15:27:35 +0200 Subject: [PATCH] Refactor default to RhnHelper.DEFAULT_FORWARD --- .../images/ScheduleImageDeploymentAction.java |3 ++- .../action/user/UserCredentialsDeleteAction.java |3 ++- .../action/user/UserCredentialsEditAction.java |3 ++- 3

[Spacewalk-devel] [PATCH] remove MAC address from profile list

2012-08-13 Thread Uwe Gansert
30e4bd5d3f2f9072f4696ccfb7bed0d9517f3584 Mon Sep 17 00:00:00 2001 From: Uwe Gansert u...@suse.de Date: Mon, 13 Aug 2012 15:18:22 +0200 Subject: [PATCH] removed MAC address from profile list --- .../frontend/strings/jsp/StringResource_en_US.xml |8 .../details/virtualization/provision/first.jsp |3 +-- 2

[Spacewalk-devel] [PATCH] Do not use America/New_York as the default timezone

2013-03-08 Thread Duncan Mac-Vicar P.
timezones, but one per offset, we take the first one that matches the offset. Duncan From bc80a6ff58aa2926dc01b8a4d6aaf80fce837a56 Mon Sep 17 00:00:00 2001 From: Duncan Mac-Vicar P dmacvi...@suse.de Date: Fri, 8 Mar 2013 16:06:01 +0100 Subject: [PATCH] Do not use America/New_York as the default

Re: [Spacewalk-devel] [PATCH] support for weak dependencies

2011-04-15 Thread Michael Calmer
:24:54PM +0100, Michael Calmer wrote: Hello, [...] Could you please investigate? Do you need list of rpms I have installed or something? I reworked the patchset: - removed the trailing whitespaces - fix the missing RPMTAG names bug (patch 0006) I've committed the patches

[Spacewalk-devel] [PATCH] xen distro inherits kernel options

2012-07-11 Thread Uwe Gansert
is a simple patch that copies the kopts to the xen distro. -- ciao, Uwe Gansert SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer Home: http://www.suse.de/~ug - Blog: http://suse.gansert.net listening to: No Voices by THYX diff --git a/java/code/src

Re: [Spacewalk-devel] [PATCH] Use braces for accessing composite types in PG

2012-11-02 Thread Johannes Renner
On 10/31/2012 05:00 PM, Tomas Lestach wrote: On Wednesday 31 of October 2012 14:38:49 Johannes Renner wrote: Hey, Ok, here is the patch to make the rewritten query work with PG as well (API call 'system.listLatestUpgradablePackages'). It's actually a follow up to this commit

Re: [Spacewalk-devel] [PATCH] avoid relying on types returned by Hibernate

2013-07-04 Thread Tomas Lestach
Applied as: https://git.fedorahosted.org/cgit/spacewalk.git/commit/?id=f7044a01be5211f00a2acd7b845e36da61357d63 I just removed unused imports. Thank you! -- Tomas Lestach Red Hat Satellite Engineering, Red Hat - Original Message - From: Silvio Moioli smoi...@suse.de To: spacewalk

[Spacewalk-devel] [PATCH] Fix field length of erratum-advisory-name

2013-09-13 Thread Michael Calmer
-- SUSE LINUX Products GmbH, GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer HRB 16746 (AG Nürnberg) From f4076ff1499a4bc955728be518ae473d80fff327 Mon Sep 17 00:00:00 2001 From: Michael Calmer m...@suse.de Date: Thu, 12 Sep 2013 17:04:19 +0200 Subject: [PATCH] Fix field length of erratum

Re: [Spacewalk-devel] Less compiler package to use

2013-10-22 Thread Johannes Renner
-p css/*.css %{buildroot}/%{_var}/www/html/ takes matched files and copies them into /%{_var}/www/html/ throwing away the fact they were placed in css directory. Sending you patch which fixes the problem. Ah yes, I see. Thank you very much for testing it! I applied your patch and hope

Re: [Spacewalk-devel] Asking for date/time in Spacewalk

2013-12-17 Thread Duncan Mac-Vicar P.
to start a discussion. I basically like the possibility to pick a date from the calendar and be able to enter it form the keyboard at the same time. Btw. I saw your patch requires jQuery. As I am not aware of any jquery packages available in Fedora koji http://koji.fedoraproject.org/koji

Re: [Spacewalk-devel] [PATCH] Date/Time picker

2014-02-15 Thread Matej Kollar
-- Matej Kollar Satellite Engineering, Red Hat - Original Message - From: Silvio Moioli smoi...@suse.de To: spacewalk-devel@redhat.com Sent: Friday, February 14, 2014 3:43:32 PM Subject: Re: [Spacewalk-devel] [PATCH] Date/Time picker On 02/14/2014 03:16 PM, Michael Mraka wrote

[Spacewalk-devel] [PATCH] fixes for system that needs reboot feature

2012-04-24 Thread Duncan Mac-Vicar P.
...@suse.de Date: Tue, 24 Apr 2012 16:18:00 +0200 Subject: [PATCH 1/3] Put the reboot notification at the end. Make it not mutually exclusive with other notifications. --- .../webapp/WEB-INF/pages/systems/sdc/overview.jsp | 16 1 files changed, 12 insertions(+), 4 deletions

Re: [Spacewalk-devel] [PATCH] Has signed Metadata

2011-03-21 Thread Michael Calmer
Hi, Am Montag, 21. März 2011, 15:28:49 schrieb Michael Mraka: Michael Mraka wrote: % Michael Calmer wrote: % % Hello, % % % Hi Michael, % % your second patch failed to apply on today's master HEAD (namely % b9d72a78d8084df93c90cd365ca24b776306eb15). % % I tried to apply it on older

Re: [Spacewalk-devel] [PATCH] Adding a password placeholder check when editing a user.

2014-02-04 Thread Maximilian Meister
Maxfeldstr. 5 D-90409 Nuremberg, Germany http://www.suse.com GF: Jeff Hawn, Jennifer Guild, Felix Imendoerffer, HRB 21284 (AG Nuremberg) From 1a82e2e6dfd888d85451835e14b46f6576a54b6a Mon Sep 17 00:00:00 2001 From: Maximilian Meister mmeis...@suse.de Date: Tue, 4 Feb 2014 10:40:19 +0100 Subject: [PATCH

Re: [Spacewalk-devel] [PATCH] build rhn-client-tools on openSUSE

2011-04-14 Thread Michael Calmer
Hi, Am Dienstag, 12. April 2011, 21:49:48 schrieb Miroslav Suchy: Dne 8.4.2011 14:49, Michael Calmer napsal(a): I spend the last week to build the spacewalk client tools on openSUSE and create a project in openSUSE build service.

Re: [Spacewalk-devel] erratas and the client plugin package action

2011-05-13 Thread Duncan Mac-Vicar P.
. Would it make more sense for errata.py to be in the yum-rhn-plugin? For *SUSE I think we will have to override errata.py as zypper should install the patch directly and not let the plugin resolve the package list. Would it be acceptable upstream that we don't install errata.py from the .spec

Re: [Spacewalk-devel] moving zypp-plugin-spacewalk to spacewalk code base

2011-11-07 Thread Duncan Mac-Vicar P.
On 10/31/2011 02:18 PM, Miroslav Suchy wrote: Dne 31.10.2011 11:41, Christian Berendt napsal(a): Why lives the zypp-plugin-spacewalk code in an external repository at the moment? We are aware of zypp-plugin-spacewalk, because it was announced here. But nobody sent us patch, which we can

Re: [Spacewalk-devel] [PATCH] Naming of cloned errata

2012-04-13 Thread Johannes Renner
On 04/11/2012 02:28 PM, Jan Pazdziora wrote: On Wed, Apr 11, 2012 at 11:43:07AM +0200, Johannes Renner wrote: I agree that clones of clones should get CM, CN, etc. instead of CL-CL-kernel*. How would you propose to detect clones for implementing this algorithm? How about having a new

Re: [Spacewalk-devel] [PATCH] CVEs missing in the security patches listing (on Oracle 11)

2012-08-17 Thread Johannes Renner
On 08/17/2012 01:20 PM, Jan Pazdziora wrote: On Fri, Aug 17, 2012 at 01:02:38PM +0200, Johannes Renner wrote: Hey, apparently the method getColumnLabel() of class ResultSetMetaData returns the column label in uppercase with Oracle 11 (using ojdbc5.jar). Therefore an equals(cve) in

Re: [Spacewalk-devel] List of installable packages: API vs. Web UI

2012-11-08 Thread Johannes Renner
. However, internal naming has lower priority, because the users do not come into contact with it, so it cannot be confusing for them. (But we of course try to keep the naming sensefull as well.) Ok, I might come up with a patch these days, fixing the existing API call so it behaves like its name

Re: [Spacewalk-devel] [PATCH] 'es improve channel status display

2013-02-21 Thread Duncan Mac-Vicar P.
On 02/14/2013 05:59 PM, Tomas Lestach wrote: Hi Duncan, thanks for your patches. I committed following: eb7beb3277fb8db48376e44c058bde8ad5d1be45 1db45d611fbc307b4eac1fa35d25ed3b30dc6fac 668f52d928590b4bc7e2d3c955f2b6a59e5d3fb8 I didn't commit following ones: *TaskoRun Log tail: Handle

[Spacewalk-devel] Using fonts in /rhn/account/LocalePreferences.do

2013-11-28 Thread Duncan Mac-Vicar P.
into this and I have a patch. However there is a problem. The normal fonts are not that complete so even if hindi shows correctly with their alphabet, korean and other do not. This can be fixed by adding another font that is complete (like gnu unifont) and generate a css style that would apply that font only

Re: [Spacewalk-devel] Using fonts in /rhn/account/LocalePreferences.do

2013-11-28 Thread Duncan Mac-Vicar P.
), % therefore getting rid of images would be really nice? % % I looked briefly into this and I have a patch. However there is a % problem. The normal fonts are not that complete so even if hindi shows % correctly with their alphabet, korean and other do not. % % This can be fixed by adding another

Re: [Spacewalk-devel] [RFC] showing timestamps in Spacewalk

2013-12-08 Thread Duncan Mac-Vicar P.
but for existing users, we might want to preserve the existing behaviour, and let the users change it manually. I disagree in making configurable (software complexity increases a lot adding little value), but if in order to get the patch upstream it is needed, with the client-side solution this should

Re: [Spacewalk-devel] [RFC] showing timestamps in Spacewalk

2013-12-13 Thread Duncan Mac-Vicar P.
the moment.js rhn:formatDateHuman tag into perl and post a patch. I still preferred the PrettyTime server-based one as one could test the tag easily with junit. -- Duncan Mac-Vicar P. - http://www.suse.com/ SUSE LINUX Products GmbH, GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer, HRB 16746 (AG Nürnberg

Re: [Spacewalk-devel] [PATCH] Adding a password strength meter to spacewalk

2014-01-07 Thread Maximilian Meister
On 01/07/2014 12:04 PM, Michael Mraka wrote: I see. Then it should keep the original name so we can easily figure out where it came from and replace it with newer version in the future. Hi Michael, the original name would be pwstrength.js (in 0.5.0). We decided to use the spacewalk- prefix

Re: [Spacewalk-devel] [PATCH] Adding a password placeholder check when editing a user.

2014-01-29 Thread Maximilian Meister
On 01/29/2014 10:35 AM, Michael Mraka wrote: Hello Maximilian, I think there's an easier way to do it in a plain html without new javascript file. If you replace input type=password name=desiredpassword maxlength=32 value=** class=form-control with input type=password

Re: [Spacewalk-devel] Spacewalk test suite/SQL validation?

2015-02-20 Thread Silvio Moioli
a pull request allowing installation on a 12.1 database? From the SUSE Manager team's perspective if your patches result in all unit tests to run correctly and some minimal manual testing is done (setup - register one system - patch it) then it would probably be enough, you can count on my

Re: [Spacewalk-devel] [PATCH] Allow null as createdBy and lastModifiedBy for custom data values

2014-01-21 Thread Jan Dobes
- Original Message - From: Johannes Renner jren...@suse.de To: spacewalk-devel@redhat.com Sent: Friday, January 17, 2014 12:30:09 PM Subject: [Spacewalk-devel] [PATCH] Allow null as createdBy and lastModifiedBy for custom data values Hello, I found another issue with the custom

Re: [Spacewalk-devel] Patch: improve MethodUtil determinism

2013-08-16 Thread Silvio Moioli
patch! Regards, -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg Germany From 3b4f56a64f76c9650b1d05cb6709c2f272c4255d Mon Sep 17 00:00:00 2001 From: Silvio Moioli smoi...@suse.de Date: Fri, 16 Aug 2013 10:47:56 +0200 Subject: [PATCH] Avoid testing callMethod on multiple

[Spacewalk-devel] [PATCH] update uptime quickly after reboot

2012-10-19 Thread Michael Calmer
-- SUSE LINUX Products GmbH, GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer HRB 16746 (AG Nürnberg) From 1c3b6b6a16d59305e44125467c7dc43ca152b289 Mon Sep 17 00:00:00 2001 From: Michael Calmer m...@suse.de Date: Thu, 18 Oct 2012 17:40:47 +0200 Subject: [PATCH 1/4] add xmlrpc

[Spacewalk-devel] [PATCH] some bugfixes

2013-03-22 Thread Michael Calmer
...@suse.de Date: Wed, 13 Mar 2013 16:06:11 +0100 Subject: [PATCH 1/5] add openSUSE 12.3 to spacewalk-common-channels config --- utils/spacewalk-common-channels.ini | 52 + 1 file changed, 52 insertions(+) diff --git a/utils/spacewalk-common-channels.ini b/utils

Re: [Spacewalk-devel] Cobbler 2.2 support in 1.6

2011-12-11 Thread Parsons, Aron
: [Spacewalk-devel] [PATCH] fix display of static snippets Message-ID: 4ed776a9.2050...@suse.de Content-Type: text/plain; charset=iso-8859-1; Format=flowed Hi, the read only snippets in the web ui need HTML/XML escaping. Especially AutoYaST XML snippets tend to be displayed wrong in the UI without escaping

Re: [Spacewalk-devel] [PATCHES] two patches for SUSE support

2012-01-16 Thread Michael Calmer
the classes are only defined if platform is deb, but also on SUSE with zypp plugin, yum is not installed. Additionally it fixes some python errors in the original code. You cannot assign a class which is defined later. The second one is a small patch to check for the zypp plugin and hide

Re: [Spacewalk-devel] [PATCH] Inconsistency in xmlrpc ChannelSerializer

2012-10-26 Thread Michael Calmer
Imendörffer HRB 16746 (AG Nürnberg) From 7841f0d35cb904d56c375c54b98a5b07ed31198d Mon Sep 17 00:00:00 2001 From: Michael Calmer m...@suse.de Date: Fri, 26 Oct 2012 11:18:24 +0200 Subject: [PATCH] Make yumrepo_last_sync optional. Do not return it, if the repo was never synced. --- .../redhat/rhn

[Spacewalk-devel] [PATCH] avoid negative payload sizes with older rpms

2013-02-12 Thread Duncan Mac-Vicar P.
the rpm header and will appear negative in the user interface. The following patch to spacewalk-backend (headerSource.py) removes the sign to this value, resulting in a cosmetic fix in the UI. I have another workaround patch to yum yumRepo.py that removes the sign even if the value is coming

Re: [Spacewalk-devel] [PATCH] Adding a password strength meter to spacewalk

2014-01-07 Thread Johannes Renner
On 12/20/2013 05:15 PM, R P Herrold wrote: On Fri, 20 Dec 2013, Maximilian Meister wrote: this patch would add a bootstrapified password strength meter to all pages where user details are being created or edited (create the initial admin user, create/edit normal users and create

[Spacewalk-devel] [PATCH] broken CVE URL in updateinfo.xml generated by spacewalk

2014-01-21 Thread Michael Calmer
-- SUSE LINUX Products GmbH, GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer HRB 16746 (AG Nürnberg) From 0613fb443f2c9a0cf16606cbde2328420d21 Mon Sep 17 00:00:00 2001 From: Michael Calmer m...@suse.de Date: Tue, 21 Jan 2014 11:29:24 +0100 Subject: [PATCH] fix CVE URL in updateinfo

Re: [Spacewalk-devel] [PATCH] Adding a password strength meter to spacewalk

2014-01-28 Thread Matej Kollar
Pushed as series of patches ending last of which is 201b52db45f9c7f10b159bbbcb8d41b1b9fc6f2d. -- Matej Kollar Satellite Engineering, Red Hat - Original Message - From: Maximilian Meister mmeis...@suse.de To: spacewalk-devel@redhat.com Sent: Tuesday, January 28, 2014 11:45:14 AM

Re: [Spacewalk-devel] On quality of patches

2014-01-30 Thread Duncan Mac-Vicar P.
On 30/01/14 11:57, Matej Kollar wrote: Hi all. We welcome community contributions and we want to maintain some level of quality. Natural expectation is that every proposed patch is tested for the functionality. I fully agree with you that this is not acceptable. Now, I think your

Re: [Spacewalk-devel] Twitter Bootstrap: Standardizing the CSS framework?

2013-07-26 Thread Tomas Lestach
your patch using: git format-patch Btw. do you plan to apply the bootstrap framework to perl pages as they are? Thank you, -- Tomas Lestach Red Hat Satellite Engineering, Red Hat - Original Message - From: Duncan Mac-Vicar P. dmacvi...@suse.de To: spacewalk-devel spacewalk-devel

<    1   2   3   >