Re: [Spacewalk-devel] devel repo: sync channels from dump

2015-10-27 Thread Silvio Moioli
On 26/10/2015 15:30, Tomas Lestach wrote: Would you, please, add it to the main PR, please? We would tag and build it and Pavel may check, whether it helps. Done, thanks! -- Silvio Moioli SUSE Manager Development Team ___ Spacewalk-devel mailing

Re: [Spacewalk-devel] devel repo: sync channels from dump

2015-10-26 Thread Silvio Moioli
so it's difficult for us to test that. Please give the patch a try and report back if it works. Thanks! -- Silvio Moioli SUSE Manager Development Team -- Silvio Moioli SUSE Manager Development Team >From 76694b63d50f7c79d9cf5a6a3de88675976f1120 Mon Sep 17 00:00:00 2001 From: Michael Calmer

Re: [Spacewalk-devel] Travis CI for Spacewalk git

2015-06-08 Thread Silvio Moioli
that needs to be adapted to be used in Travis, but it should be doable and it would be a further step in the same direction. Regards, -- Silvio Moioli SUSE Manager Development Team -- Silvio Moioli SUSE LLC Maxfeldstraße 5, 90409 Nürnberg Germany

Re: [Spacewalk-devel] Introducing tetra

2015-04-21 Thread Silvio Moioli
and maintain them. Okay, will keep that into account. Thanks! -- Silvio Moioli SUSE LLC Maxfeldstraße 5, 90409 Nürnberg Germany -- Silvio Moioli SUSE LLC Maxfeldstraße 5, 90409 Nürnberg Germany ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com

[Spacewalk-devel] Introducing tetra

2015-03-02 Thread Silvio Moioli
, thoughts and further discussion are of course very welcome. Silvio PS: currently tetra outputs SUSE-centric specfiles, but they are so simple that tweaking templates for Fedora or Red Hat distros would be trivial. -- Silvio Moioli SUSE LLC Maxfeldstraße 5, 90409 Nürnberg Germany

Re: [Spacewalk-devel] Spacewalk test suite/SQL validation?

2015-02-20 Thread Silvio Moioli
vote at least. We can always run the Cucumber integration test suite on SUSE Manager nightly once the PR is approved and report any bugs afterwards. Hth, -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg Germany ___ Spacewalk

Re: [Spacewalk-devel] Outstanding pull requests

2015-02-02 Thread Silvio Moioli
also recommend this: https://github.com/spacewalkproject/spacewalk/pull/200 Thanks, -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg Germany ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com

Re: [Spacewalk-devel] RFC: Action Chaining mockups and ideas

2014-03-03 Thread Silvio Moioli
welcome :-) Regards, -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg Germany ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel

[Spacewalk-devel] On picking a standard on HTML5 void tags (was: Date/Time picker)

2014-02-18 Thread Silvio Moioli
/uvvxg/html5_developers_do_you_self_close_your_tags_or/ -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg Germany ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel

Re: [Spacewalk-devel] On picking a standard on HTML5 void tags

2014-02-18 Thread Silvio Moioli
On 02/18/2014 09:46 AM, Silvio Moioli wrote: So all I have is one last question: Is this your own personal opinion or the whole Spacewalk team official position? In particular, will future patches be rejected if they have those trailing slashes? Oops, typo there. I really meant

Re: [Spacewalk-devel] Query question regarding system.listLatestUpgradeablePackages

2014-02-14 Thread Silvio Moioli
. Determining the to_version, to_release, to_epoch and to_package_id outputs of listLatestUpgradablePackages is actually non trivial and I suspect it adds up quite a lot of computation. Regards, -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg Germany

Re: [Spacewalk-devel] [PATCH] Date/Time picker

2014-02-14 Thread Silvio Moioli
a discussion with you in the next days, but this was faster :-) Thanks, -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg Germany ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo

Re: [Spacewalk-devel] RFC: Action Chaining mockups and ideas

2014-02-14 Thread Silvio Moioli
a system to an existing action in a chain is not possible at the moment. I don't see anything bad in getting this into Spacewalk, or that would go against Spacewalk's future desires. Great news! I will be back with a screencast soon. Thanks a lot, -- Silvio Moioli SUSE LINUX Products GmbH

Re: [Spacewalk-devel] Things that needs to be dobne before next release.

2014-02-13 Thread Silvio Moioli
that prevents merging? We can help in that case. From our side, we just added custom icons and I am planning to display some more relevant data in the Bare-metal System List page in the next weeks. Thanks, -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg Germany

Re: [Spacewalk-devel] [PATCH] Date/Time picker

2014-02-10 Thread Silvio Moioli
. Regards, -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg Germany ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel

Re: [Spacewalk-devel] Action chaining - table names

2014-01-23 Thread Silvio Moioli
practice for schema parts that were contributed by us, as there are other tables with that prefix - evidently I was wrong. No problem though, I fixed those commits already. Thanks again, -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg Germany

Re: [Spacewalk-devel] Action chaining - new js files

2014-01-23 Thread Silvio Moioli
code is ready to merge. By the way I am not familiar with the Spacewalk RPM build system and conventions so I might need some help - when everything else is finished I will ask you again. Thanks, -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg Germany

Re: [Spacewalk-devel] [PATCH] Single-system reboot page ported to Java

2014-01-21 Thread Silvio Moioli
/articles/javase/code-convention-138726.html -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg Germany From 51fc76e6de18e6e93f38652f389edf39976d5c38 Mon Sep 17 00:00:00 2001 From: Michael Calmer m...@suse.de Date: Thu, 16 Jan 2014 14:08:11 +0100 Subject: [PATCH] port

[Spacewalk-devel] [PATCH] Single-system reboot page ported to Java

2014-01-17 Thread Silvio Moioli
. Regards, -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg Germany From c6c2050412339f1d9fe789dc57f8b170e750ad31 Mon Sep 17 00:00:00 2001 From: Michael Calmer m...@suse.de Date: Thu, 16 Jan 2014 17:20:53 +0100 Subject: [PATCH 2/2] remove unused perl code after porting

Re: [Spacewalk-devel] less.js development mode broken

2014-01-14 Thread Silvio Moioli
in b7e3621. Regards, -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg Germany ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel

Re: [Spacewalk-devel] Things that needs to be dobne before next release.

2014-01-09 Thread Silvio Moioli
finished SUSE Manager side, and I also consider the Spacewalk rebase basically finished - please report any defects or issues that block upstreaming so that I can try to find a solution. Thanks, -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg Germany

[Spacewalk-devel] RFC: Action Chaining mockups and ideas

2014-01-08 Thread Silvio Moioli
in the coming weeks. I plan to regularly push commits there so that you can comment on code at any time. Hopefully this will ease acceptance checks and merging when development ends. Thanks for your cooperation in advance, -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg Germany

Re: [Spacewalk-devel] [PATCH] Adding a password strength meter to spacewalk

2014-01-06 Thread Silvio Moioli
suggestions on how to improve a password, it does not enforce any rule. Mandatory password complexity checks and the whole authentication code path is left untouched. HTH, -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg Germany

Re: [Spacewalk-devel] RFC: manage bare-metal systems from Spacewalk

2013-12-20 Thread Silvio Moioli
-metal systems visually. Just trying to figure out whether we can't achieve the same goal somehow easier with the current code... We obviously also thought hard about this, but could not find out a simpler alternative. Suggestions are welcome, as always. Regards, -- Silvio Moioli SUSE LINUX

Re: [Spacewalk-devel] RFC: manage bare-metal systems from Spacewalk

2013-12-18 Thread Silvio Moioli
. HTH, -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg Germany ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel

Re: [Spacewalk-devel] Pushing to spacewalk.git

2013-12-10 Thread Silvio Moioli
, -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg Germany ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel

Re: [Spacewalk-devel] Pushing to spacewalk.git

2013-12-10 Thread Silvio Moioli
On 12/10/2013 03:00 PM, Michael Mraka wrote: I was complaining about those one-commit sub-branches which immediatelly merge back to the master-bootstrap-css-fixes branch. Ok, no problem, we will avoid those from now on. Thanks, -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409

[Spacewalk-devel] RFC: manage bare-metal systems from Spacewalk

2013-12-06 Thread Silvio Moioli
in 2012. We are proud of finally putting the finishing touches to his work. [1] http://tinyurl.com/qxetm2n [2] http://tinyurl.com/oz7bvk5 [3] http://tinyurl.com/px8rgzm [4] http://tinyurl.com/pnkrsm3 [5] http://thread.gmane.org/gmane.linux.redhat.spacewalk.devel/4073/focus=4090 -- Silvio Moioli SUSE

[Spacewalk-devel] RFC: a Cobbler-based power management feature

2013-12-05 Thread Silvio Moioli
/gmane.linux.redhat.spacewalk.devel/4073/focus=4090 -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg Germany ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel

Re: [Spacewalk-devel] Using fonts in /rhn/account/LocalePreferences.do

2013-11-28 Thread Silvio Moioli
that: http://scripts.sil.org/cms/scripts/page.php?item_id=fontutils In SUSE operating systems it is part of the perl-Font-TTF package. HTH, -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg Germany ___ Spacewalk-devel mailing list

Re: [Spacewalk-devel] [PATCH] Proposal to remove filesystem dependencies from ConfigTest

2013-11-06 Thread Silvio Moioli
to hear it and patch the code again! Have a nice day, -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg Germany ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel

Re: [Spacewalk-devel] Patch proposal: try-wrapping XMLRPC serialization code

2013-10-02 Thread Silvio Moioli
all tests pass tests here as well. Thanks a lot! -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg Germany ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel

[Spacewalk-devel] [PATCH] Proposal to remove filesystem dependencies from ConfigTest

2013-10-01 Thread Silvio Moioli
are taken from either the classes directory or the jar file, copied in /tmp and read from there. As there are other possible solutions I wanted to submit this for review here before pushing it. Thanks, -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg Germany From

[Spacewalk-devel] [PATCH] Add support for uploaded files in mocked requests, fix CryptoKeyCreateActionTest

2013-09-13 Thread Silvio Moioli
BaseCryptoKeyEditAction with isContentsRequired() always returning true, so I removed that assertion as well. Regards, -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg Germany From bc726176a9b91dbc51449673e6c845909bf999c2 Mon Sep 17 00:00:00 2001 From: Silvio Moioli smoi...@suse.de Date

[Spacewalk-devel] [PATCH] SystemEntitlementsSetupActionTest: do not assume Org has virtualization entitlement

2013-09-13 Thread Silvio Moioli
SystemEntitlementsSetupActionTest was failing in our environment, as the tested Org missed a virtualization entitlement. The proposed attached patch fixes the problem. Regards, -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg Germany From

[Spacewalk-devel] [PATCH] MethodsSetupActionTest: do not assume that method command exists

2013-09-13 Thread Silvio Moioli
See attached patch. Regards, -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg Germany From d49e62923f34a64e5c2caac619d751d9e6010ac4 Mon Sep 17 00:00:00 2001 From: Silvio Moioli smoi...@suse.de Date: Mon, 9 Sep 2013 10:56:06 +0200 Subject: [PATCH 05/22

[Spacewalk-devel] [PATCH] junit tests: do not rely on Cobbler

2013-09-12 Thread Silvio Moioli
database and objects, so I think it makes sense to just use a mocked connection to avoid the Cobbler exception on a test system that will never be in Cobbler anyway. Comments welcome! Regards, -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg Germany From

[Spacewalk-devel] [PATCH] junit tests: some logging cleanups

2013-09-12 Thread Silvio Moioli
more and I am attaching a patch to fix them as well. Note: at the moment we haven't looked into main application code yet. This ends this patch batch, hopefully, as we were finally able to run all the tests successfully, at least on Postgres :-) Regards, -- Silvio Moioli SUSE LINUX Products GmbH

[Spacewalk-devel] [PATCH] Frontend monitoring tests: ensure a Monitoring Scout exists

2013-09-12 Thread Silvio Moioli
Hi, In some frontend tests it is assumed that at least one Monitoring Scout exists, and those tests will fail if there is none. The proposed attached patch creates a test Monitoring Scout before any operation that requires one, thus eliminating this precondition. Regards, -- Silvio Moioli SUSE

[Spacewalk-devel] [PATCH] MasterHandlerTest: handle getDefaultMaster exceptions

2013-09-12 Thread Silvio Moioli
is the very first call to getDefaultMaster(): since none of the test IssMaster objects has been flagged as default yet, the call may or may not throw exceptions depending on the previous state. The attached patch simply ignores such exception for the very first call. Regards, -- Silvio Moioli

[Spacewalk-devel] [PATCH] TestUtils: use the same temporary filename for the same file

2013-09-12 Thread Silvio Moioli
, -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg Germany From cc7e859551be0997f7d45ff6ad3257d91a15d4a6 Mon Sep 17 00:00:00 2001 From: Silvio Moioli smoi...@suse.de Date: Wed, 11 Sep 2013 15:48:57 +0200 Subject: [PATCH 21/22] TestUtils: use the same temporary filename when

[Spacewalk-devel] [PATCH] SystemHandlerTest: do not rely on hardcoded sequence ids

2013-09-12 Thread Silvio Moioli
simply relaxed that condition accordingly. See attached patch. Regards, -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg Germany From ec1b4e81c7e82005293bb50623aa6bef8bdcc92c Mon Sep 17 00:00:00 2001 From: Silvio Moioli smoi...@suse.de Date: Wed, 11 Sep 2013 15:00:56 +0200

[Spacewalk-devel] [PATCH] DownloadActionTest: do not assume file to be downloaded exists

2013-09-12 Thread Silvio Moioli
See attached patch. Regards, -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg Germany From 67eef48cbd7a10d9451501ade7d6df9c01a6f430 Mon Sep 17 00:00:00 2001 From: Silvio Moioli smoi...@suse.de Date: Mon, 9 Sep 2013 08:25:23 +0200 Subject: [PATCH 04/22

[Spacewalk-devel] [PATCH] AuthFilterTest: mocked request object updated

2013-09-12 Thread Silvio Moioli
AuthFilterTest was failing in our setup, apparently because the mocked request object was missing some methods that were added after the test itself was written. I added those methods and now it passes. See attached patch. Regards, -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5

[Spacewalk-devel] [PATCH] OrgHandlerTest: don't depend on a channel family with free entitlement slots

2013-09-12 Thread Silvio Moioli
not necessarily true in any instance, and IMO test code should take care of setting up and tearing down such a channel since it is needed to run tests. The attached patch adds some setup code to do that. Regards, -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg Germany From

[Spacewalk-devel] [PATCH] ActivationKeyHandlerTest: expect correct exceptions

2013-09-12 Thread Silvio Moioli
ActivationKeyHandlerTest expected InvalidEntitlementException where actually FaultException gets thrown. I updated the testcase. See attached patch. Regards, -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg Germany From 72b582c013959eb7efc45c57b05c76e7ff4bb654 Mon Sep

[Spacewalk-devel] [PATCH] RequestContext.buildPageLink: force parameter ordering

2013-09-12 Thread Silvio Moioli
. In the attached patch I propose using a TreeMap instead, which produces a reliable ordering. Regards, -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg Germany From 984f3b48a370276bec7d3eedf0f114ed6ce07465 Mon Sep 17 00:00:00 2001 From: Silvio Moioli smoi...@suse.de Date

Re: [Spacewalk-devel] pltcl question

2013-09-11 Thread Silvio Moioli
operation on a new connection, COMMIT or ROLLBACK. Maybe I simply missed some documentation somewhere, I apologize in that case :) Thanks for the detailed explanation, -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg Germany

Re: [Spacewalk-devel] pltcl question

2013-09-11 Thread Silvio Moioli
actually. I am reviewing my own patches today, and will be back with news soon. Regards, -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg Germany ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com

Re: [Spacewalk-devel] [PATCH] rhn.manager tests: do not assume an Org admin exists

2013-09-10 Thread Silvio Moioli
as soon as we are done running tests from the frontend package. Regards, -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg Germany ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman

[Spacewalk-devel] [PATCH] UserManagerTest: don't rely on hardcoded default time zone

2013-09-09 Thread Silvio Moioli
UserManagerTest relied on a default America/New_York time zone, I removed the hardcoded string replacing it with UserFactory.getDefaultTimeZone(). See attached patch. Regards, -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg Germany From

[Spacewalk-devel] [PATCH] ConfigureSatelliteCommandTest: do not rely on HashMap key ordering

2013-09-09 Thread Silvio Moioli
I noticed that ConfigureSatelliteCommandTest makes an assertion that depends on a HashMap key ordering, it was changed it to a SortedMap to guarantee repeatability. See attached patch. Regards, -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg Germany From

[Spacewalk-devel] [PATCH] SystemManagerTest: missing super.setUp() call added

2013-09-09 Thread Silvio Moioli
See attached patch. Regards, -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg Germany From 8377a9ba5f349a661f49a7f0ad9c393f7745f0fc Mon Sep 17 00:00:00 2001 From: Silvio Moioli smoi...@suse.de Date: Thu, 5 Sep 2013 09:11:37 +0200 Subject: [PATCH] SystemManagerTest

[Spacewalk-devel] [PATCH] MonitoringManagerTest: missing super.setUp() call added

2013-09-09 Thread Silvio Moioli
See attached patch. Regards, -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg Germany From 5865f906d561acb613addd31fa7e6b9e4e05e8af Mon Sep 17 00:00:00 2001 From: Silvio Moioli smoi...@suse.de Date: Wed, 4 Sep 2013 11:58:10 +0200 Subject: [PATCH] MonitoringManagerTest

[Spacewalk-devel] [PATCH] UpdateErrataCacheCommand: log an error when orgId is incorrect

2013-09-09 Thread Silvio Moioli
See attached patch. Previously a NPE would be generated, but since the stack trace is not very useful as it can only go back until run(), it only polluted test outputs. I think that logging the error makes more sense in this case. Regards, -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße

[Spacewalk-devel] [PATCH] VirtualizationEntitlementsManagerTest fixes

2013-09-09 Thread Silvio Moioli
, to keep Postgres from failing on subsequent statements. Regards, -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg Germany From f0b8fd871e09bf4300b2d2a7f5166965b77ea7cf Mon Sep 17 00:00:00 2001 From: Silvio Moioli smoi...@suse.de Date: Thu, 5 Sep 2013 11:58:35 +0200 Subject

Re: [Spacewalk-devel] [PATCH] VirtualizationEntitlementsManagerTest fixes

2013-09-09 Thread Silvio Moioli
On 09/09/2013 08:29 AM, Silvio Moioli wrote: I attached two patches: Patches updated to apply cleanly after Grant's commits. I apologize for the double post. Regards, -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg Germany From

Re: [Spacewalk-devel] [PATCH] UpdateErrataCacheCommand: log an error when orgId is incorrect

2013-09-09 Thread Silvio Moioli
the case, as we see many such NPEs in the unit tests' standard output. AFAIU this happens since BaseTestCaseWithUser sets up and deletes a new Org for every testsuite, so any pending operation on the errata cache can fail depending on timing. Regards, -- Silvio Moioli SUSE LINUX Products GmbH

Re: [Spacewalk-devel] [PATCH] Avoid a possible concurrency issue on RhnSet update

2013-09-05 Thread Silvio Moioli
ignoring them, yet accepting failures in this specific case. I will be back with a patch as soon as I have tested it. Thanks for the discussion by the way, as problems in this topic are traditionally difficult to handle! Regards, -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409

Re: [Spacewalk-devel] [PATCH] Avoid a possible concurrency issue on RhnSet update

2013-09-04 Thread Silvio Moioli
-id/937d27e10810020633k164e7f4bsb5213d86d2bfb...@mail.gmail.com [2] http://www.postgresql.org/docs/9.2/static/transaction-iso.html#XACT-READ-COMMITTED Regards, -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg Germany

[Spacewalk-devel] pltcl question

2013-09-04 Thread Silvio Moioli
, auto (the default) [...] for JDBCTransactionFactory, this returns ConnectionReleaseMode.AFTER_TRANSACTION Regards, -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg Germany ___ Spacewalk-devel mailing list Spacewalk-devel

[Spacewalk-devel] [PATCH] Avoid a possible concurrency issue on RhnSet update

2013-08-29 Thread Silvio Moioli
/docs/9.2/static/transaction-iso.html -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg Germany From ca96039fb3edc31f05427f0f70ce278174f905b1 Mon Sep 17 00:00:00 2001 From: Silvio Moioli smoi...@suse.de Date: Mon, 26 Aug 2013 18:37:19 +0200 Subject: [PATCH] Avoid issues

Re: [Spacewalk-devel] [PATCH] UserFactoryTest: avoid failure if there are no users

2013-08-29 Thread Silvio Moioli
to UserTestUtils and ServerTestUtils to ease implementation, where appropriate. Comments are always welcome, I look forward in contributing similar patches also in the future. Regards, -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg Germany From

[Spacewalk-devel] [PATCH] com.redhat.rhn.common.db.datasource tests: get database username from configuration file

2013-08-29 Thread Silvio Moioli
the original test was coded that way - maybe there is a reason but at the moment I do not see it. Regards, -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg Germany From fe99b2dfbc388409ce251e5f4fa54b3f21388ac8 Mon Sep 17 00:00:00 2001 From: Silvio Moioli smoi...@suse.de Date

[Spacewalk-devel] [PATCH] ChannelTest: do not assume a proxy channel family exists

2013-08-29 Thread Silvio Moioli
Hi, Here is another simple patch to avoid having a proxy channel family set up in order to run ChannelTest. Regards, -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg Germany From 5e7a3ada13e76d49e1b2bb9539b1c8eb415dd9d0 Mon Sep 17 00:00:00 2001 From: Silvio Moioli smoi

[Spacewalk-devel] [PATCH] AdvDataSourceTest: do not rely on test execution order

2013-08-29 Thread Silvio Moioli
executes the whole setup and teardown for each test, since that ensures tests do not depend on each other and does not hurt performance significantly. The patch has been tested both on Oracle and Postgres databases. Regards, -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg

[Spacewalk-devel] [PATCH] Patch synchronization issue

2013-08-21 Thread Silvio Moioli
() will copy packages from the original patch to the cloned patch with the line Justin Sherrill 2008 a85006389d436719240b49f8eea37f7550edf974 -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg Germany ___ Spacewalk-devel mailing list

[Spacewalk-devel] [PATCH] Patch synchronization issue

2013-08-21 Thread Silvio Moioli
as I know this should not cause any other regression. Comments welcome! PS: I apologize for my previous email, it was sent incomplete by mistake. Regards, -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg Germany From edfe0cafeb5a530cd4617303b58e594ff554b17b Mon Sep 17 00

Re: [Spacewalk-devel] [PATCH] Patch synchronization issue

2013-08-21 Thread Silvio Moioli
found a way how, please, let me know. In our case, the vendor simply changed a patch, adding packages. Custom channels/patches could also run in the same issue. Thanks, regards, -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg Germany

Re: [Spacewalk-devel] Patch: improve MethodUtil determinism

2013-08-16 Thread Silvio Moioli
patch! Regards, -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg Germany From 3b4f56a64f76c9650b1d05cb6709c2f272c4255d Mon Sep 17 00:00:00 2001 From: Silvio Moioli smoi...@suse.de Date: Fri, 16 Aug 2013 10:47:56 +0200 Subject: [PATCH] Avoid testing callMethod on multiple

[Spacewalk-devel] Patch: improve MethodUtil determinism

2013-08-14 Thread Silvio Moioli
() predictably run the same method when more than one is compatible. [1] getMethods' Javadoc explicitly warns against relying on ordering: [...] The elements in the array returned are not sorted and are not in any particular order. [...] Regards, -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5

[Spacewalk-devel] Patch: adapt LocalizationServiceTest to run on all JDKs

2013-08-14 Thread Silvio Moioli
downstream, we propose the attached patch to let the test to pass in any case. [1] http://bugs.sun.com/view_bug.do?bug_id=6609737 Regards, -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg Germany From 77ebde681a357f44499d90e015c5cb94e2172a4d Mon Sep 17 00:00:00 2001 From

Re: [Spacewalk-devel] Sharing state between Java and Perl stacks

2013-07-09 Thread Silvio Moioli
much, will keep that in mind in the future. Regards, -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg Germany ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel

Re: [Spacewalk-devel] [PATCH] avoid relying on types returned by Hibernate

2013-07-02 Thread Silvio Moioli
efforts, I am still not able reproduce a bug with upstream Spacewalk code so far. Regards, -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg Germany ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https

Re: [Spacewalk-devel] [PATCH] avoid relying on types returned by Hibernate

2013-07-01 Thread Silvio Moioli
me know. Regards, -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg Germany ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel

[Spacewalk-devel] [PATCH] avoid relying on types returned by Hibernate

2013-06-10 Thread Silvio Moioli
or not. Any comment is welcome! Regards, -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg Germany From e5d4e4a2b5e19524ae3c6b8e8e16a9825d8d28e6 Mon Sep 17 00:00:00 2001 From: Silvio Moioli smoi...@suse.de Date: Fri, 7 Jun 2013 16:02:00 +0200 Subject: [PATCH] Avoid relying

[Spacewalk-devel] Sharing state between Java and Perl stacks

2013-05-16 Thread Silvio Moioli
Hello everyone, I am trying to fix a minor bug in the Manage Software Channels section, and I would like to know your opinion about the possible solutions. Steps to reproduce the bug: - click on the Channels tab, - click on Manage Software Channels, - click on any one of the available

[Spacewalk-devel] [PATCH] avoid link-jars task when executing make-eclipse-project

2013-05-08 Thread Silvio Moioli
. because they are available, but in other locations). I attached a simple patch that removes the dependency. Regards, Silvio Moioli From 541498264598781c2c8656bf03abe63a8bc04277 Mon Sep 17 00:00:00 2001 From: Silvio Moioli smoi...@suse.de Date: Tue, 7 May 2013 09:50:52 +0200 Subject: [PATCH] Removed