Re: sysupgrade: exit 1 instead of exit 0 when ending early

2022-10-11 Thread bug
On Tue, Oct 11, 2022 at 01:32:43PM +0200, Janne Johansson wrote: > > On Mon, Oct 10, 2022 at 11:17:32AM -0600, Theo de Raadt wrote: > > > It's been explained a few times that being up-to-date is not an error. > > > It's a good thing, and no action is neccessary when up-to-date. > > > Any non-zero

Re: sysupgrade: exit 1 instead of exit 0 when ending early

2022-10-11 Thread Janne Johansson
> After reading the script, I'd nitpick that it merely advances the > version by one step rather than ensures the system is up-to-date, but I Then again, this seem to match exactly what the manpage says it should be doing: sysupgrade is a utility to upgrade OpenBSD to the next release or a

Re: sysupgrade: exit 1 instead of exit 0 when ending early

2022-10-11 Thread bug
On Tue, Oct 11, 2022 at 01:34:08PM +0200, Renaud Allard wrote: > > > On 10/11/22 13:10, bug wrote: > > On Mon, Oct 10, 2022 at 11:17:32AM -0600, Theo de Raadt wrote: > > > It's been explained a few times that being up-to-date is not an error. > > > It's a good thing, and no action is neccessary

Re: sysupgrade: exit 1 instead of exit 0 when ending early

2022-10-11 Thread Renaud Allard
On 10/11/22 13:10, bug wrote: On Mon, Oct 10, 2022 at 11:17:32AM -0600, Theo de Raadt wrote: It's been explained a few times that being up-to-date is not an error. It's a good thing, and no action is neccessary when up-to-date. Any non-zero value indicates an error, that would include 2.

Re: sysupgrade: exit 1 instead of exit 0 when ending early

2022-10-11 Thread Janne Johansson
> On Mon, Oct 10, 2022 at 11:17:32AM -0600, Theo de Raadt wrote: > > It's been explained a few times that being up-to-date is not an error. > > It's a good thing, and no action is neccessary when up-to-date. > > Any non-zero value indicates an error, that would include 2. You are > > marking this

Re: sysupgrade: exit 1 instead of exit 0 when ending early

2022-10-11 Thread bug
On Mon, Oct 10, 2022 at 11:17:32AM -0600, Theo de Raadt wrote: > It's been explained a few times that being up-to-date is not an error. > It's a good thing, and no action is neccessary when up-to-date. > > Any non-zero value indicates an error, that would include 2. You are > marking this as an

Re: sysupgrade: exit 1 instead of exit 0 when ending early

2022-10-11 Thread Stuart Henderson
On 2022/10/11 03:44, Mikolaj Kucharski wrote: > On Mon, Oct 10, 2022 at 11:17:32AM -0600, Theo de Raadt wrote: > > > Any non-zero value indicates an error, that would include 2. You are > > marking this as an error, when it isn't. > > > > You think this will help your scripting. Do you not

Re: sysupgrade: exit 1 instead of exit 0 when ending early

2022-10-10 Thread Mikolaj Kucharski
On Mon, Oct 10, 2022 at 11:17:32AM -0600, Theo de Raadt wrote: > It's been explained a few times that being up-to-date is not an error. > It's a good thing, and no action is neccessary when up-to-date. No action when up-to-date is not the same as action when not up-to-date, when you use -n and

Re: sysupgrade: exit 1 instead of exit 0 when ending early

2022-10-10 Thread Theo de Raadt
It's been explained a few times that being up-to-date is not an error. It's a good thing, and no action is neccessary when up-to-date. Any non-zero value indicates an error, that would include 2. You are marking this as an error, when it isn't. You think this will help your scripting. Do you

Re: sysupgrade: exit 1 instead of exit 0 when ending early

2022-10-10 Thread Mikolaj Kucharski
On Fri, Oct 07, 2022 at 02:39:01PM -0400, Josh Grosse wrote: > For ease of running sysupgrade from within a script. > > diff --git a/usr.sbin/sysupgrade/sysupgrade.sh > b/usr.sbin/sysupgrade/sysupgrade.sh > index d80ff127ffa..ce5800093c9 100644 > --- a/usr.sbin/sysupgrade/sysupgrade.sh > +++

Re: sysupgrade: exit 1 instead of exit 0 when ending early

2022-10-08 Thread Josh Grosse
On Sat, Oct 08, 2022 at 11:14:34AM +, Mikolaj Kucharski wrote: > On Sat, Oct 08, 2022 at 09:57:54AM +, Klemens Nanni wrote: > > On Sat, Oct 08, 2022 at 07:33:38AM +0200, Florian Obser wrote: > > > Being up2date doesn't feel like an error to me, what am I missing? > > > > I concur. > > >

Re: sysupgrade: exit 1 instead of exit 0 when ending early

2022-10-08 Thread Mikolaj Kucharski
On Sat, Oct 08, 2022 at 09:57:54AM +, Klemens Nanni wrote: > On Sat, Oct 08, 2022 at 07:33:38AM +0200, Florian Obser wrote: > > Being up2date doesn't feel like an error to me, what am I missing? > > I concur. > I think Josh is looking for similar behaviour to syspatch(8). To be able to

Re: sysupgrade: exit 1 instead of exit 0 when ending early

2022-10-08 Thread Klemens Nanni
On Sat, Oct 08, 2022 at 07:33:38AM +0200, Florian Obser wrote: > Being up2date doesn't feel like an error to me, what am I missing? I concur.

Re: sysupgrade: exit 1 instead of exit 0 when ending early

2022-10-07 Thread Florian Obser
On 2022-10-07 14:39 -04, Josh Grosse wrote: > For ease of running sysupgrade from within a script. > > diff --git a/usr.sbin/sysupgrade/sysupgrade.sh > b/usr.sbin/sysupgrade/sysupgrade.sh > index d80ff127ffa..ce5800093c9 100644 > --- a/usr.sbin/sysupgrade/sysupgrade.sh > +++

sysupgrade: exit 1 instead of exit 0 when ending early

2022-10-07 Thread Josh Grosse
For ease of running sysupgrade from within a script. diff --git a/usr.sbin/sysupgrade/sysupgrade.sh b/usr.sbin/sysupgrade/sysupgrade.sh index d80ff127ffa..ce5800093c9 100644 --- a/usr.sbin/sysupgrade/sysupgrade.sh +++ b/usr.sbin/sysupgrade/sysupgrade.sh @@ -153,7 +153,7 @@ rm SHA256.sig if