Re: [patch] S_ISDIR() check in yacc TMPDIR

> Sending this to tech list as suggested by mmcc@... > > The yacc(1) manual mentions TMPDIR is an extension. > The following patch re-factors the checks around TMPDIR. > This adds an explicit check for TMPDIR-is-a-directory. > With this patch applied, yacc can more reliably determine when it >

[patch] S_ISDIR() check in yacc TMPDIR

Hello, Sending this to tech list as suggested by mmcc@... The yacc(1) manual mentions TMPDIR is an extension. The following patch re-factors the checks around TMPDIR. This adds an explicit check for TMPDIR-is-a-directory. With this patch applied, yacc can more reliably determine when it should

Re: sqlite3 update

On 2016/06/08 19:01, James Turner wrote: > I prefer option 2. Switch to the amalgamation with our changes on top. I've been looking at this. I don't really like any of the options but this seems the "least worst" one. I'm not terribly happy about this, but I don't see what else we can really do

Kernel panic pf.c during halting

I don't know if this is enough, but I haven't had access to web using other device when kernel panicked. sysctl kern.version kern.version=OpenBSD 6.0-beta (GENERIC.MP) #2198: Sun Jun 19 11:58:45 MDT 2016

Re: new feature in pkg_add(1)

On Fri, Jun 17, 2016 at 04:02:36PM +0200, Marc Espie wrote: > I was waiting for snapshots to come up with the new stuff, but it > looks like amd64 will be a bit late. Someone is still hiking in > the mountains... > > > A week ago or so, I committed support for some disambiguating > filter in

Re: pf divert port reuse

On Tue, Jun 21, 2016 at 05:12:39PM +0200, Mike Belopuhov wrote: > Right, I've found it, but how can you tell that this is a new > connection if iss changes a lot and you just test if it's greater > than? The actual test should be if it's ouside of the window, > isn't it? That is very traditional

Re: pf divert port reuse

On Tue, Jun 21, 2016 at 16:08 +0200, Alexander Bluhm wrote: > On Tue, Jun 21, 2016 at 02:45:42PM +0200, Mike Belopuhov wrote: > > You're testing the sequence number > > of the new state with an existing one which has seen some > > traffic.. Are you sure this is correct? > > This is exactly what

Re: Updated man page for release.8

Attached is my proposed diff for /usr/src/share/man/man8/release.8 that adds instructions on how to build the install${VERSION}.{fs,iso} images. I have incorporated off-list feedback from Theo Buehler in this diff. Any feedback would be welcome. Please find attached an updated diff with

L2TP: rise download speed with ppp(4) + pipex(4)

Hello, I would like to announce that I finally reached 80 mbps of download via pure L2TP tunnel (without IPsec). I digged through ppp(4) and pppd(8) code several times and I could not find any bottlenecks. Looks like we need to change whole design of ppp(4) to reach any usable download speed.

Re: pf divert port reuse

On Tue, Jun 21, 2016 at 02:45:42PM +0200, Mike Belopuhov wrote: > You're testing the sequence number > of the new state with an existing one which has seen some > traffic.. Are you sure this is correct? This is exactly what the stack does to distinguish between packets that belong to an old

Updated man page for release.8

Attached is my proposed diff for /usr/src/share/man/man8/release.8 that adds instructions on how to build the install${VERSION}.{fs,iso} images. I have incorporated off-list feedback from Theo Buehler in this diff. Any feedback would be welcome. Index: release.8

Re: pf.conf macro with space

On 2016/06/21 08:57, sven falempin wrote: > A parsing tool is not like hacking into an advanced kernel > feature with unexpected side effect That is incorrect. I'm not implying anything about diffs proposed in this thread, but this parser *is* sensitive, it's more complex than you think, and

Re: pf.conf macro with space

On Tue, Jun 21, 2016 at 08:57:44AM -0400, sven falempin wrote: > I have explain the use of spaced macro, > a config file that is self explanatory. I suggest you use underscores instead of spaces in macro names.

Re: pf.conf macro with space

On 21 June 2016 at 14:57, Sebastian Benoit wrote: > Henning Brauer(hb-openbsdt...@ml.bsws.de) on 2016.06.21 13:11:16 +0200: >> * Stefan Sperling [2016-06-21 11:15]: >> > Generally, I would appreciate more detailed error messages from the pf.conf >> > parser. I

Re: pf.conf macro with space

On Tue, Jun 21, 2016 at 01:11:16PM +0200, Henning Brauer wrote: > * Stefan Sperling [2016-06-21 11:15]: > > Generally, I would appreciate more detailed error messages from the pf.conf > > parser. I recall several occasions where pfctl threw "syntax error" and more > > specific

Re: pf.conf macro with space

On Tue, Jun 21, 2016 at 8:30 AM, Stefan Sperling wrote: > On Tue, Jun 21, 2016 at 01:11:16PM +0200, Henning Brauer wrote: > > however, the ruleset in this case does NOT load. > > $ echo '"a macro with spaces"="foo"\npass from $a\ > macro\ with\ spaces"' | pfctl

Re: pf.conf macro with space

Henning Brauer(hb-openbsdt...@ml.bsws.de) on 2016.06.21 13:11:16 +0200: > * Stefan Sperling [2016-06-21 11:15]: > > Generally, I would appreciate more detailed error messages from the pf.conf > > parser. I recall several occasions where pfctl threw "syntax error" and more > >

Re: pf divert port reuse

On 21 June 2016 at 14:00, Alexander Bluhm wrote: > On Tue, Jun 21, 2016 at 11:24:14AM +0200, Mike Belopuhov wrote: >> So pf reused the port while some TCP segments were still in flight? > > No. The old state was in FIN_WAIT_2 and the socket in TIME_WAIT. Ah indeed, but

Re: pf.conf macro with space

On Tue, Jun 21, 2016 at 01:11:16PM +0200, Henning Brauer wrote: > however, the ruleset in this case does NOT load. > $ echo '"a macro with spaces"="foo"\npass from $a\ macro\ > with\ spaces"' | pfctl -nvf - > a macro with spaces = "foo" > stdin:2: macro 'a' not defined > stdin:2:

Re: pf divert port reuse

On Tue, Jun 21, 2016 at 11:24:14AM +0200, Mike Belopuhov wrote: > So pf reused the port while some TCP segments were still in flight? No. The old state was in FIN_WAIT_2 and the socket in TIME_WAIT. They were idling for 25 seconds. Then a new state was created and Nat pf_get_sport() did choose

Re: ppp_compressors

On 21 June 2016 at 13:43, Jeremie Courreges-Anglas wrote: > > We don't support modules, so no need to reserve space for additional PPP > compression methods. > > ok? > Sure.

ppp_compressors

We don't support modules, so no need to reserve space for additional PPP compression methods. ok? Index: if_ppp.c === RCS file: /cvs/src/sys/net/if_ppp.c,v retrieving revision 1.99 diff -u -p -p -u -r1.99 if_ppp.c --- if_ppp.c

Re: pf divert port reuse

On 21 June 2016 at 00:14, Alexander Bluhm wrote: > Hi, > > I have seen a problem with pf divert when the dynamic port in a nat > rule got reused. The function pf_state_key_attach() reused the > state as it was in TCPS_FIN_WAIT_2. The corresponding socket was > not

Re: pf.conf macro with space

On Tue, Jun 21, 2016 at 10:37:45AM +0200, Henning Brauer wrote: > * Sebastian Benoit [2016-06-21 10:15]: > > same thing without a stupid helper function, pointed out by henning. > > I'm actually not quite sure we need or want this. From my PoV, making > the tools too much of a

Re: pf.conf macro with space

* Sebastian Benoit [2016-06-21 10:15]: > same thing without a stupid helper function, pointed out by henning. I'm actually not quite sure we need or want this. From my PoV, making the tools too much of a nanny is against unix spirit. Macros with spaces don't actually cause

Re: pf.conf macro with space

Stefan Sperling(s...@stsp.name) on 2016.06.21 10:23:13 +0200: > On Tue, Jun 21, 2016 at 10:14:52AM +0200, Sebastian Benoit wrote: > > > > same thing without a stupid helper function, pointed out by henning. > > > > diff --git sbin/pfctl/parse.y sbin/pfctl/parse.y > > index 934438c..426cd93

Re: pf.conf macro with space

On Tue, Jun 21, 2016 at 10:14:52AM +0200, Sebastian Benoit wrote: > > same thing without a stupid helper function, pointed out by henning. > > diff --git sbin/pfctl/parse.y sbin/pfctl/parse.y > index 934438c..426cd93 100644 > --- sbin/pfctl/parse.y > +++ sbin/pfctl/parse.y > @@ -714,6 +714,10 @@

Re: pf.conf macro with space

On Tue, Jun 21, 2016 at 10:14:52AM +0200, Sebastian Benoit wrote: > > same thing without a stupid helper function, pointed out by henning. OK florian@ (for all parse.y instances we have, oh and as usual you forgot cwm in your list :) ) > > diff --git sbin/pfctl/parse.y sbin/pfctl/parse.y >

Re: pf.conf macro with space

same thing without a stupid helper function, pointed out by henning. diff --git sbin/pfctl/parse.y sbin/pfctl/parse.y index 934438c..426cd93 100644 --- sbin/pfctl/parse.y +++ sbin/pfctl/parse.y @@ -714,6 +714,10 @@ numberstring : NUMBER { varset :

check KTRPOINT() before calling ktrpledge()

Don't ktrace pledge if it is not enabled. Index: sys/kern/kern_pledge.c === RCS file: /cvs/src/sys/kern/kern_pledge.c,v retrieving revision 1.170 diff -u -p -r1.170 kern_pledge.c --- sys/kern/kern_pledge.c 7 Jun 2016 01:31:54