Re: opencvs - fix update -r and -A

On Fri, 14 Oct 2016 16:17:45 +0200, Joris Vink wrote: > In certain cases update -r and update -A would not properly set or reset > the sticky tag for file(s). This patch fixes that problem. After reading through the applicable parts of update.c I'm fairly certain this is correct. OK millert@

Re: make !!= extension

On Thu, 20 Oct 2016 15:22:44 +0200, Marc Espie wrote: Comments inline. > Index: make.1 > === > RCS file: /cvs/src/usr.bin/make/make.1,v > retrieving revision 1.120 > diff -u -p -r1.120 make.1 > --- make.113 Mar 2015 19:58:41

Re: opencvs - show branch revision in status

On Mon, 17 Oct 2016 12:59:36 +0200, Joris Vink wrote: > Let's bring status a bit more inline with its GNU cvs counter part. > > This diff adds the branch revision for the sticky tag if set. OK millert@ - todd

Re: syslog_r() should use strerror_r()

On Wed, 19 Oct 2016 09:34:16 -0600, "Theo de Raadt" wrote: > Inside strerror_r, I'm unsure why there is a save_errno dance. I don't see anything called by strerror_r() that would touch errno so we could get rid of the save_errno dance and just do: if (ret_errno) errno =

Re: syslog_r() should use strerror_r()

On Wed, 19 Oct 2016 09:11:36 -0600, "Todd C. Miller" wrote: > Currently, syslog_r() avoids using strerror() since it is not > reentrant. We have a reentrant strerror_r() so let's use it. Since strerror_r() always fills in the buffer there is no need to check the return value.

syslog_r() should use strerror_r()

Currently, syslog_r() avoids using strerror() since it is not reentrant. We have a reentrant strerror_r() so let's use it. OK? - todd Index: lib/libc/gen/syslog_r.c === RCS file: /cvs/src/lib/libc/gen/syslog_r.c,v retrieving

Re: syslog_r() should use strerror_r()

On Wed, 19 Oct 2016 17:29:18 +0200, Mark Kettenis wrote: > Perhaps add a comment explicitly stating that OpenBSD's strerror_r() > *is* reentrant? I thought that was implicit in the name. - todd

Re: smtpd: internal cleanups

On Wed, 16 Nov 2016 21:13:40 +0100, Eric Faurot wrote: > With this first diff, the user pointer is passed as parameter to the io > callback instead of having the user dereference the io structure. There > are places where the callback function is triggered outside of the io > layer. It's not

opencvs: quiet sign warnings

Quiet some sign warnings from the compiler. The common "st.st_size > SIZE_MAX" check causes many of them. To avoid this we need to cast st_size (which is off_t) to a large unsigned type. I think uintmax_t makes the most sense for this. - todd Index: buf.c

Re: config(8): use {err,warn}{,x} instead of fprintf(stderr, ...)

On Sun, 16 Oct 2016 11:47:32 +0200, Theo Buehler wrote: > Many files already include and there's a mix of hand-rolled > warning messages and there's incorrect usage warn("config: ..."). This > is a first sweep at unifying them. > > In mkheaders.c, there is an err() function, rename it to

Re: diff3: use boolean OR, not bitwise

On Sun, 16 Oct 2016 16:06:39 +0200, Otto Moerbeek wrote: > On Sun, Oct 16, 2016 at 07:07:36AM -0600, Todd C. Miller wrote: > > > It is effectively the same in this case but using the boolean OR > > is less surprising and may quiet over zealous compilers. > > Are you s

diff3: use boolean OR, not bitwise

It is effectively the same in this case but using the boolean OR is less surprising and may quiet over zealous compilers. OK? - todd Index: cvs/diff3.c === RCS file: /cvs/src/usr.bin/cvs/diff3.c,v retrieving revision 1.61 diff -u

Re: crontab(5): document -q flag in command

Whitespace between the -q and the command is optional, not required. - todd Index: crontab.5 === RCS file: /cvs/src/usr.sbin/cron/crontab.5,v retrieving revision 1.33 diff -u -p -u -r1.33 crontab.5 --- crontab.5 30 Jan 2014

Re: PING: Re: logname turd polish

On Wed, 12 Oct 2016 15:03:04 +0200, Ingo Schwarze wrote: > please just commit this patch you sent out back in July. > The old, verbose style keeps confusing people, > see for example Jan Stary's recent messages to tech@. > I guess you just overlooked my OK. > There was no opposition when you put

ftp: avoid printf of NULL in debug mode

I noticed that Jiri's ftp debug output had two instances where NULL was printed as a string. This fixes it. $ ftp -o /dev/null -M -d -V http://ftp.eu.openbsd.org/pub/OpenBSD/snapshots/amd64/ Before: host ftp.eu.openbsd.org, port (null), path pub/OpenBSD/snapshots/amd64/, save as /dev/null,

Re: [ftp] missing new line in debug+verbose mode

That will add an extra newline in the proxy case where it does: fprintf(ttyout, "Requesting %s", origline); ... fprintf(ttyout, " (via %s)\n", proxyurl); There is actually a newline printed for the non-proxy case but it happens too late. We either need to avoid

Re: arm64: add efibind header for efiboot(8)

The copyright notice says there is a license but doesn't specify what the license is. In constrast, sys/stand/efi/include/arm/efibind.h explicitly states it is under the BSD license and provides a link to the license text. I guess this is the same as sys/stand/efi/include/amd64/efibind.h so it

Re: arm64: add efibind header for efiboot(8)

On Tue, 13 Dec 2016 18:06:11 +0100, Patrick Wildt wrote: > Turns out, the copyright seems to be bad. This version is taken from > tianocore/edk2, modified to work with our efiboot(8) checkout. Great, thanks. > The diff to the arm efibind header is comparatively small now. Even better. OK

Re: Move auth_approval in su.c before fork is lost due to pledge?

One change with this diff is that the approval script will run as the invoking user, not the target user. I'm not sure that really makes a difference though. - todd

Re: traceroute(8): make progress on timeout

On Fri, 13 Jan 2017 16:07:31 +, Florian Obser wrote: > traceroute(8) never sees a timeout when poll(2) returns when it receives > a packet not intended for us. E.g. a ping(8) is running in parallel. > In this case we need to account for the time we already waited. Looks good but please make

Re: Move auth_approval in su.c before fork is lost due to pledge?

On 07 Jan 2017 21:14:17 -0700, "Andy Bradford" wrote: > As it turns out, it is because I have an approve entry in > /etc/login.conf and this requires the ability to fork the approval > program. When su tries to run approve it fails and I find the following > in dmesg: > >

Re: C11 max_align_t

I think you need to also define __CLANG_MAX_ALIGN_T_DEFINED and perhaps _GCC_MAX_ALIGN_T to avoid libcxx from redefining max_align_t as a different type. E.g. in src/lib/libcxx/include/stddef.h // Re-use the compiler's max_align_t where possible. #if !defined(__CLANG_MAX_ALIGN_T_DEFINED) &&

Re: syslogd multiple listen addresses

On Sun, 01 Jan 2017 21:05:58 +0100, Alexander Bluhm wrote: > Regular programs should die as early as possible when an error > occurs, then it can be fixed. But syslogd is special. If it dies, > you become blind and don't see any errors at all. An attacker could > exploit this. So I think

Re: syslogd multiple listen addresses

On Sat, 31 Dec 2016 01:18:16 +0100, Alexander Bluhm wrote: > Currently syslogd accepts network input only for either IPv4 or > IPv6. To overcome this limitation, allow to specify more than one > listen addresses. > > As multiple TLS contexts need more thought, implement it only for > TCP and

Re: acme-client use configuration file [1 of 5]

I think you also want something like the following. Also, acme-client.conf.5 has paths like: domain key /etc/ssl/private/example.com.key domain certificate /etc/ssl/example.com.crt instead of: domain key /etc/ssl/acme/private/example.com.key domain certificate

Re: find -delete

OK millert@ for the code. I'll defer to jmc@ on the man page bits. - todd

Re: qsort.c: remove useless variable

On Tue, 03 Jan 2017 21:51:12 +0100, Alexander Bluhm wrote: > I think it would be nicer to keep the char * a variable and remove > the (char *) casts instead. How about this? - todd Index: lib/libc/stdlib/qsort.c === RCS file:

Re: find(1): pledge mayexecve codepath

On Tue, 03 Jan 2017 23:52:46 +0100, Theo Buehler wrote: > tedu's -delete diff reminded me of a patch I've had in one of my trees > for quite a while: find(1) was tamed a few days before execve(2) was > added to kern_tame.c and I think it was simply forgotten that everything > was already prepared

Re: sort(1): fix segfault with -m flag

On Wed, 04 Jan 2017 12:24:15 +0100, Julien Ramseier wrote: > sort segfaults when using the -m flag and no files. > It should default to stdin instead. Committed, thanks. - todd

Re: syslogd multiple listen addresses

Now that syslogd supports multiple network sockets, does it still make sense to die if one of them cannot be bound? It seems like syslogd should still run as long as there is at least one address it can bind to. What do you think? - todd

qsort.c: remove useless variable

When qsort.c was de-registered, the register version of 'aa' was not removed. Since qsort() already contains casts of a to char * there's no need for a separate variable here. - todd Index: lib/libc/stdlib/qsort.c === RCS file:

Re: syslogd klog read size

Nice find, that explains the reports of broken lines. OK millert@ - todd

Re: syslogd chdir

Another alternative is to use realpath(3) to resolve the path so it can be used after the chdir(2). - todd

Re: cksum not working with both -a and -C flags together

On Tue, 28 Mar 2017 15:49:24 +0100, Craig Skinner wrote: > When cksum(1) is used with a -C checklist listing multiple algorithms, > and a single -a algorithm is specified, cksum doesn't select the correct > -a [algorithm], nor the correct line in the -C [checklist]: The -a option is only used to

Re: RTC clocks

On Sun, 26 Mar 2017 23:25:48 +0200, Mark Kettenis wrote: > The downside of this is that it becomes impossible to set the time > back that far. But the upside is that if you haven't left a machine > powered off for a very long time, the ntpd constraint will actually > work. I think that is a

mkdir(2): document EACCESS when no write permission

>From FreeBSD, POSIX has identical wording. Alternately, we could add an extra EACCESS entry similar to what exists in open(2). I'm happy with either approach. - todd Index: lib/libc/sys/mkdir.2 === RCS file:

Re: cksum not working with both -a and -C flags together

On Tue, 28 Mar 2017 09:33:53 -0600, "Todd C. Miller" wrote: > It seems to me that in -C mode it should really process all the > checksums that match the specified file(s), but the documentation > does not actually specify what the behavior is in this case. Here's a dif

Re: syslogd log.c

On Thu, 16 Mar 2017 02:15:48 +0100, Alexander Bluhm wrote: > The whole diff converting all the messages has more than 2000 lines > as it touches every part of syslogd code. I would refuse to review > such a huge diff, so I have splitted it. Let's start with the log.c > implementation. Looks

Re: syslogd fd_tls variable

On Thu, 16 Mar 2017 00:45:23 +0100, Alexander Bluhm wrote: > On Mon, Jan 09, 2017 at 10:46:42AM +0100, Alexander Bluhm wrote: > > To implement multiple tls listen sockets in syslogd, I have to get > > rid of the global variable fd_tls first. > > Looks like this diff got forgotten. Any ok? OK

Re: skeylogin.c: use arc4random_buf instead of /var/db/host.random

On Mon, 20 Mar 2017 21:06:23 +0100, Theo Buehler wrote: > libskey reads directly from /var/db/host.random and falls back to the > ctime of /dev/mem or / for generating the fake prompt for the user. You should also remove SKEY_RAND_FILE_PATH from skey.h. OK millert@ with that removed. - todd

Re: whois: remove pointless realloc()

On Wed, 15 Mar 2017 09:57:26 -0600, "Todd C. Miller" wrote: > There's no need to realloc() a chunk of memory when you don't care > about the old contents, we don't want have to memcpy() the old > contents to the new chunk only to throw it away. > While here, use asprint

whois: remove pointless realloc()

There's no need to realloc() a chunk of memory when you don't care about the old contents, we don't want have to memcpy() the old contents to the new chunk only to throw it away. While here, use asprintf() to simplify things. - todd Index: usr.bin/whois/whois.c

Re: rtadvd: asprintf

On Tue, 04 Apr 2017 19:08:13 +0200, Jeremie Courreges-Anglas wrote: > The last commit to this file fixed two (void)asprintf calls. Fix the > two remaining calls: depend on the ret buffer being set to NULL on > failure. Personally, I would leave vltimexpire and pltimexpire initialized to NULL

Re: __pure __dead

OK millert@ We should probably consider pruning out all the gcc < 3.x bits from sys/cdefs.h. - todd

Re: shutdown(8): warn format string should be literal

On Mon, 03 Apr 2017 22:21:10 +0200, Frederic Cambus wrote: > warn format string should be literal. OK millert@ Note that path can only be set to either _PATH_REBOOT or _PATH_HALT so there is no security issue, but the compiler doesn't know this. Changing the code helps eliminate false positives

lex: missing update of yy_buf_size?

I found this diff rotting in my tree. It doesn't look like yy_buf_size gets updated when we realloc. Am I missing something? - todd Index: usr.bin/lex/flex.skl === RCS file: /cvs/src/usr.bin/lex/flex.skl,v retrieving revision

lex: use isblank()

isblank() is part of C99, no reason not to use it. - todd Index: usr.bin/lex/parse.y === RCS file: /cvs/src/usr.bin/lex/parse.y,v retrieving revision 1.9 diff -u -p -u -r1.9 parse.y --- usr.bin/lex/parse.y 19 Nov 2015 19:43:40

Re: lex: missing update of yy_buf_size?

On Wed, 12 Apr 2017 09:12:53 -0600, "Theo de Raadt" wrote: > After realloc, the grown buffer's new space will be garbage bytes > rather than zeroed. Should we be afraid of another bug in the lex > accidentally looking 1 byte ahead, and proactively zero at least the > first byte of growth? lex

Re: lex: missing update of yy_buf_size?

On Wed, 12 Apr 2017 09:07:57 -0600, "Todd C. Miller" wrote: > I found this diff rotting in my tree. It doesn't look like yy_buf_size > gets updated when we realloc. Am I missing something? We also need to account for the two end of buffer chars somehow. I've opened a pull reque

Re: gzip not exiting 2 when not compressible

This was fixed after 6.0 came out. I believe it was: CVSROOT:/cvs Module name:src Changes by: mill...@cvs.openbsd.org 2016/08/17 06:02:38 Modified files: usr.bin/compress: gzopen.c Log message: When returning the file size info, only use z_total_in/z_total_out for the

Re: syslogd log_debug

On Wed, 05 Apr 2017 02:10:44 +0200, Alexander Bluhm wrote: > Updated diff after unlock, ok? Looks correct. OK millert@ - todd

Re: syslogd log_warn

On Wed, 05 Apr 2017 18:17:38 +0200, Alexander Bluhm wrote: > Replace logerror() functions with generic log_warn() from log.c. > Make messages a bit more consistent. Note that the new function > supports format strings. Replace some log_debug() with log_warn(). OK millert@ - todd

Re: mmap:ing /dev/rsdNc fails with EINVAL on all my attempts pages give no hint. Any way around it?

Not all devices support mmap. Only those that define a d_mmap entry in cdevsw[] will work (see conf.c and conf.h in the kernel). On OpenBSD, disks can not be mmaped. - todd

Re: mmap:ing /dev/rsdNc fails with EINVAL on all my attempts pages give no hint. Any way around it?

On Wed, 05 Apr 2017 11:24:11 -0600, "Theo de Raadt" wrote: > > "ls -l /dev/rsd0c; ls -l /dev/sd0c" shows that sd0c is a block device > > and rsd0c is a character device, and mmap's man page says that > > "character special files" are OK. > > The manual pages will never list all restrictions. In

Re: syslogd log fatal

On Wed, 05 Apr 2017 13:58:12 +0200, Alexander Bluhm wrote: > On Fri, Mar 17, 2017 at 02:09:35AM +0100, Alexander Bluhm wrote: > > This is the next step for refactoring internal syslogd(8) logging. > > Replace all combinations of logerror() and die() with log.c fatal(). > Also all err(3) after

Re: syslogd log fatal

On Wed, 05 Apr 2017 16:51:13 +0200, Alexander Bluhm wrote: > Syslogd's fatal() calls die() internally, so there is no change in > behavior. The idea is that you may call fatal() anywhere and die() > will do cleanup if necessary. Ah, right, I missed that. - todd

Re: syslogd log startup

On Thu, 06 Apr 2017 00:03:34 +0200, Alexander Bluhm wrote: > On Fri, Mar 17, 2017 at 02:09:35AM +0100, Alexander Bluhm wrote: > > This is the next step for refactoring internal syslogd(8) logging. > > Here is my final diff for now, thanks for all the reviews. > > The variable Startup is not

Re: syslogd log_info

On Wed, 05 Apr 2017 22:23:58 +0200, Alexander Bluhm wrote: > The function logmsg() was used to generate local messages and to > process incomming messages. Split this functionality into log_info() > and logline(). Sort the parameters like they appear in the syslog > line. Shouldn't vlogmsg()

Re: fsck_ffs(8): remove always false comparison

On Sun, 09 Apr 2017 18:09:51 +0200, Frederic Cambus wrote: > Remove always false comparison: inosused type is ino_t, which is > unsigned. It's not so simple. It looks like this is intended to handle inosused wrapping, which is possible. I think it is worth having a check in there of some kind.

Re: Fix regress/lib/libc/db

Maybe use UINT_MAX since st_size gets cast to u_int below? Either way OK millert@ - todd

Re: Fix regress/lib/libc/db

On Mon, 17 Apr 2017 17:12:13 +0200, Mark Kettenis wrote: > > From: "Todd C. Miller" <todd.mil...@courtesan.com> > > Date: Mon, 17 Apr 2017 08:49:26 -0600 > > > > Maybe use UINT_MAX since st_size gets cast to u_int below? > > Either way OK millert@

Re: clang: ignore -fno-force-addr

In general, if -fdo-something is supported I think it should also accept -fno-do-something. Since this was seen in the wild, patching llvm makes the most sense. Bonus points if you can get it upstreamed. - todd

Re: newsyslog timestamp

How about we just eliminate the "logfile turned over" message entirely? It's kind of bogus for newsyslog to be writing to the log files directly. I don't think that message provides any useful info. - todd

tcsetpgrp(3) can set errno to EINTR

If tcsetpgrp() is called by a background process and there is a SIGTTOU handler installed without SA_RESTART set, tcsetpgrp() will return -1 and set errno to EINTR. Index: lib/libc/termios/tcsetpgrp.3 === RCS file:

Re: syslogd log_info

On Wed, 05 Apr 2017 22:36:36 +0200, Alexander Bluhm wrote: > On Wed, Apr 05, 2017 at 02:29:46PM -0600, Todd C. Miller wrote: > > On Wed, 05 Apr 2017 22:23:58 +0200, Alexander Bluhm wrote: > > > > > The function logmsg() was used to generate local messages and to > >

Re: syslogd log ttymsg

On Wed, 05 Apr 2017 23:46:45 +0200, Alexander Bluhm wrote: > On Fri, Mar 17, 2017 at 02:09:35AM +0100, Alexander Bluhm wrote: > > This is the next step for refactoring internal syslogd(8) logging. > > As we did not have nice log functions before, ttymsg() had to return > the error string. Log

Re: syslogd tcp connect message

On Fri, 07 Apr 2017 14:50:27 +0200, Alexander Bluhm wrote: > I got feedback that on a TCP log server the TCP connections from > the clients are spamming the log file. The log clients reconnect > at every SIGHUP. > > The easy fix is to write these accept and close messages with debug > priority,

Re: Implement __cxa_thread_atexit

On Fri, 11 Aug 2017 16:31:44 +0200, Mark Kettenis wrote: > I've chosen to implement __cxa_thread_atexit() directly instead of > __cxa_thread_atexit_impl(). I think that is cleaner. It means we > don't need to make changes to libc++ for this to start working. It > looks like modern libstdc++

Re: sosend netlock assertion crash

On Thu, 13 Jul 2017 17:41:19 +0200, Alexander Bluhm wrote: > My laptop just crashed while running some php ports regress tests. > The kernel complained that it did not hold the netlock in sounlock() > after the out label in sosend(). The assert is correct, let's fix > the obvious offender.

Re: patch: make share/mk support for yacc files better behaved

On Sun, 09 Jul 2017 15:38:18 +0200, Marc Espie wrote: > On Sun, Jul 09, 2017 at 07:30:30AM -0600, Todd C. Miller wrote: > > On Sun, 09 Jul 2017 10:40:43 +0200, Marc Espie wrote: > > > > > After a full bulk, no parts of xenocara are affected and just five ports. >

Re: Remove accents from fortunes

On Tue, 11 Jul 2017 19:47:41 +0200, Ingo Schwarze wrote: > So here is a patch that makes putting UTF-8 characters into > fortune/datfiles safe. OK millert@ - todd

Re: patch: make share/mk support for yacc files better behaved

On Sun, 09 Jul 2017 10:40:43 +0200, Marc Espie wrote: > After a full bulk, no parts of xenocara are affected and just five ports. Those are all ports that include bsd.*.mk in their Makefiles, right? If so, it doesn't seem like a big deal. -todd

Re: Move newsyslog to TAILQ*

On Fri, 14 Jul 2017 22:15:49 +0200, Jeremie Courreges-Anglas wrote: > the proposal in > > https://marc.info/?l=openbsd-misc=150001966325010=2 > > made me look at newsyslog and its manually linked lists. Here's a stab > at using TAILQs instead. Oh good, now I don't have to do it ;-) I have

Re: Move newsyslog to TAILQ*

On Fri, 14 Jul 2017 22:59:58 +0200, Jeremie Courreges-Anglas wrote: > "Todd C. Miller" <todd.mil...@courtesan.com> writes: > > > On Fri, 14 Jul 2017 22:15:49 +0200, Jeremie Courreges-Anglas wrote: > > > >> the proposal in > >> > &

Re: Move newsyslog to TAILQ*

On Sat, 15 Jul 2017 00:24:05 +0200, Jeremie Courreges-Anglas wrote: > Wouldn't it be better if we at least tried to properly free what was > allocated in parse_file()? I'm not sure it is worth it since newsyslog is a short-lived process. If you feel strongly about this I could take a look at

Re: newsyslog: skip invalid newsyslog.conf entries

On Mon, 17 Jul 2017 22:21:36 +0200, Jeremie Courreges-Anglas wrote: > Here's a diff to skip invalid lines and return a meaningful error > status if meet one. A goto looked like the simplest way here because > of the nested for(;;) loop in parse_file(). > > While here, mention the exit status in

Re: login_skey crash

On Thu, 20 Jul 2017 17:26:59 +0200, Alexander Bluhm wrote: > When login_skey is called for a user without skey it crashes with > NULL pointer dereference. It tries to pass a file descriptor that > does not exist. This has to be done conditionally. OK millert@ - todd

Re: make: clarify an error string

On Mon, 24 Jul 2017 13:02:12 +0200, Marc Espie wrote: > Here's a proper error message: OK millert@ - todd

Re: whois(1): follow ICANN change to field names

On Wed, 26 Jul 2017 17:19:42 +0200, Jeremie Courreges-Anglas wrote: > On Wed, Jul 26 2017, Stuart Henderson wrote: > > the https://www.icann.org/resources/pages/rdds-labeling-policy-2017-02-01-e > n > > changes have gone live (at least for com/net), so whois(1) no longer

Re: whois(1): follow ICANN change to field names

On Wed, 26 Jul 2017 15:43:38 +0100, Stuart Henderson wrote: > the https://www.icann.org/resources/pages/rdds-labeling-policy-2017-02-01-en > changes have gone live (at least for com/net), so whois(1) no longer chases > referrals. OK to change the string to the new one? OK millert@ - todd

Re: vi(1): strtol -> strtonum

On Wed, 19 Jul 2017 21:44:43 +0200, Anton Lindqvist wrote: > Fairly straightforward, replace usage of strtol with strtonum. > No intended functional change. Looks good. OK millert@ - todd

Re: tty(4): mention TIOCSTAT

On Wed, 28 Jun 2017 15:35:36 -0600, "Theo de Raadt" wrote: > Nope. It requires a parameter. lukem messed this up two decades ago, > he should have used _IO but used the wrong one. Ah right, I missed that it is _IOW. OK millert@ as-is then. - todd

Re: tty(4): mention TIOCSTAT

On Wed, 28 Jun 2017 22:48:47 +0200, Anton Lindqvist wrote: > A first stab at documenting the TIOCSTAT ioctl. The paragraph is taken > from termios(4) as is and could might be reworked. The parameter is as > stated unused but consistent with the definition of TIOCSTAT in > sys/sys/ttycom.h. I

Re: Standard conformance of strtol(3)

Sorry, HP-UX actually has the same behavior as us. Here's what I have so far: 4.4BSD strtol() behavior: HP-UX NetBSD OpenBSD glibc strtol() behavior: AIX FreeBSD GNU/Linux Solaris macOS - todd

Re: Standard conformance of strtol(3)

Solaris, AIX, and HP-UX all have the same behavior as glibc. We are the outlier. Since the standard is clear that the 0x/0X prefix is optional I believe our behavior is wrong. - todd

Re: Standard conformance of strtol(3)

On Thu, 06 Jul 2017 07:37:19 -0600, "Todd C. Miller" wrote: > Sorry, HP-UX actually has the same behavior as us. Here's what I > have so far: > > 4.4BSD strtol() behavior: > HP-UX > NetBSD > OpenBSD strtol(3) was added to BSD in 4.3-Reno along

Re: Standard conformance of strtol(3)

I've just committed a fix for this. - todd

Re: patch: make lex rules parallel-safe

I wonder if it would be better to use lex.${.PREFIX}.c instead of ${.PREFIX}.lex.c. This would be more consistent with how lex's -Pprefix flag behaves. It's not a big deal either way as the file is strictly temporary. - todd

Re: no depends for perl

On Mon, 26 Jun 2017 19:49:18 +0200, Marc Espie wrote: > Probably the most intricate yet. > > This is not entirely new, since I had to split manpages already a long > time ago. The trick is to keep the "Configure stuff" in the main > Makefile.bsd-wrapper, and put everything else in

Re: Standard conformance of strtol(3)

C99 states that the 0x or 0X prefix is optional so we should only consume the prefix if the following character is a valid hex char. This is equivalent to the fix in FreeBSD but I used isxdigit(3). - todd Index: lib/libc/stdlib/strtoimax.c

Re: bin/ed: fix clang warnings

On Wed, 26 Apr 2017 22:10:49 +0200, Christian Weisgerber wrote: > This fixes the clang warnings in bin/ed. One extra pair of parentheses > and stop passing empty format strings to printf-family functions. One comment inline. Overall, I find the changes to be an improvement. I see that FreeBSD

Re: bin/ed: fix clang warnings

On Wed, 26 Apr 2017 22:56:57 +0200, Christian Weisgerber wrote: > The cases before and after follow the > > if (!interactive) { > if (garrulous) > ... > > pattern. *shrug* Yes, but in this case there is nothing to do if !garrulous which is

ksh: quiet clang warning

This quiets the folowing warning without resorting to a cast. /usr/src/bin/ksh/eval.c:329:19: warning: implicit conversion from 'int' to 'char' changes value from 192 to -64 [-Wconstant-conversion] *dp++ = '@' + 0x80;

Re: ftpd should not error out twice

On Thu, 27 Apr 2017 11:00:52 +0200, Mike Belopuhov wrote: > Indeed, it supresses errors from PORT and the like, while > keeping the "530 Please login with USER and PASS.". > > Before: > > USER foo > 331 Password required for foo. > PORT 12567 > 530 Please login with USER and

Re: ftpd should not error out twice

I don't have any objection to this but if it is committed a similar change should be made to check_login_epsvall. - todd

Re: Fix exponential glob

That patch seems to have gotten munged and there was a duplicate return statement. This one works for me. - todd Index: lib/libc/gen/glob.c === RCS file: /cvs/src/lib/libc/gen/glob.c,v retrieving revision 1.46 diff -u -p -u -r1.46

Re: Fix exponential glob

On Fri, 28 Apr 2017 15:31:34 -0600, "Todd C. Miller" wrote: > Here's a diff that hews a bit more closely to the example code in > https://research.swtch.com/glob Ignore that diff for now, it is not correct. - todd

Re: Fix exponential glob

Here's a diff that hews a bit more closely to the example code in https://research.swtch.com/glob - todd Index: lib/libc/gen/glob.c === RCS file: /cvs/src/lib/libc/gen/glob.c,v retrieving revision 1.46 diff -u -p -u -r1.46 glob.c

Re: printf(3) return value on ENOMEM

I just want to point out that we already return -1 for mmap allocation failures in the positional argument code. - todd

Re: fstat output

On Wed, 02 Aug 2017 11:01:38 +0200, Alexander Bluhm wrote: > On Wed, Aug 02, 2017 at 09:56:50AM +0200, Martin Pieuchot wrote: > > Simple diff to improved readability. Before: > > There are situations where you want a full match on the command. > For testing and scripting with long program names

<    1   2   3   4   5   6   7   8   9   10   >