Re: [PATCH 2/3] openbgpd: Add support for 'unknown' well-known communities

Small update. I renamed the 'msb' argument ('most significant bits') to 'part' to improve readability. In Community 15562:4, '15562' is part 0 and the '4' is part 1. Same type of logic might be useful down the road for Large Communities which would have 3 parts. - Job diff --git

Re: [PATCH] mv(1): add -v option for verbosity

On Sun, Jun 25, 2017 at 02:41:28PM +0200, Mark Kettenis wrote: > > Date: Sun, 25 Jun 2017 14:06:11 +0200 > > From: Job Snijders > > > > Hi all, > > > > This patch adds a -v option to mv(1) for more verbose output. > > > > $ touch a > > $ mv -v a b > > 'a' -> 'b'

Re: [PATCH] cp(1): add -v option for verbosity

Dear Alexander, On Sun, Jun 25, 2017 at 06:13:40PM +0200, Alexander Hall wrote: > On June 25, 2017 2:06:20 PM GMT+02:00, Job Snijders > wrote: > >This patch adds a -v option to cp(1) for more verbose output. > > > > $ touch a b; mkdir c > > $ cp -v a b c > > 'a'

Re: [PATCH] rm(1): add -v option for verbosity

Hi Ingo, Thanks for taking the time to review this. On Sun, Jun 25, 2017 at 03:12:26PM +0200, Ingo Schwarze wrote: > Job Snijders wrote on Sun, Jun 25, 2017 at 02:06:16PM +0200: > > > This patch adds a '-v' option to rm(1) for more verbose output. > > Do not add new options to standard

Re: [PATCH] cp(1): add -v option for verbosity

On June 25, 2017 2:06:20 PM GMT+02:00, Job Snijders wrote: >Dear team, > >This patch adds a -v option to cp(1) for more verbose output. > > $ touch a b; mkdir c > $ cp -v a b c > 'a' -> 'c/a' > 'b' -> 'c/b' > $ cp -rv c d > 'c' -> 'd/' >

Re: [PATCH] rm(1): add -v option for verbosity

Hi, Job Snijders wrote on Sun, Jun 25, 2017 at 02:06:16PM +0200: > This patch adds a '-v' option to rm(1) for more verbose output. Do not add new options to standard utilities, unless you can show that they are unusually useful in practice *and* practically every other system out there has

Re: [PATCH 1/3] openbgpd: Allow localpref of zero

OK On 2017 Jun 23 (Fri) at 16:01:16 +0200 (+0200), Job Snijders wrote: :Dear team, : :The lowest valid BGP LOCAL_PREF is 0, allowing bgpd to set 0 too will :accomodate interopability. : :Kind regards, : :Job : :--- a/usr.sbin/bgpd/parse.y :+++ b/usr.sbin/bgpd/parse.y :@@ -1988,7 +1988,7 @@

Re: [PATCH 2/3] openbgpd: Add support for 'unknown' well-known communities

On 2017 Jun 23 (Fri) at 16:01:58 +0200 (+0200), Job Snijders wrote: :Dear team, : :This patch makes 'unknown' well-known communities more of a first-class :citizen. : :A powerful property of well-known communities is that (often) operators :can implement the feature associated with a given

Re: [PATCH 2/3] openbgpd: Add support for 'unknown' well-known communities

On Sun, Jun 25, 2017 at 02:09:22PM +0200, Peter Hessler wrote: > : $ bgpctl show rib community WELLKNOWN:0 > : .. > : $ bgpctl show rib community WELLKNOWN:* > : .. > > Eh, I don't really see a reason to have syntatic sugar for > '65535'. In this case, I'm

Re: ksh(1): don't output invalid UTF-8 characters

For reference, I just committed the fix, see message below. Thanks to all who helped out. > CVSROOT: /cvs > Module name: src > Changes by: an...@cvs.openbsd.org 2017/06/25 02:51:53 > > Modified files: > bin/ksh: emacs.c > > Log message: > Don't output partial UTF-8

Re: [PATCH 3/3] openbgpd: Add well-known community GRACEFUL_SHUTDOWN

OK On 2017 Jun 23 (Fri) at 16:02:13 +0200 (+0200), Job Snijders wrote: :Dear team, : :This patch adds support for the "graceful shutdown" well-known :community as described in draft-ietf-grow-bgp-gshut. : :An example implementation would be to add the following to your :bgpd.conf: : :match

Re: [PATCH] mv(1): add -v option for verbosity

> Date: Sun, 25 Jun 2017 14:06:11 +0200 > From: Job Snijders > > Hi all, > > This patch adds a -v option to mv(1) for more verbose output. > > $ touch a > $ mv -v a b > 'a' -> 'b' > $ mkdir c > $ mv -v b c > 'b' -> 'c/b' > $ mv -v c d

[PATCH] rm(1): add -v option for verbosity

Hi all, This patch adds a '-v' option to rm(1) for more verbose output. $ mkdir a; touch a/b; touch c $ rm -rfv * removed 'a/b' removed directory 'a' removed 'c' Kind regards, Job diff --git bin/rm/rm.1 bin/rm/rm.1 index 5c8aefaab7d..7de2c7067ee 100644

[PATCH] mv(1): add -v option for verbosity

Hi all, This patch adds a -v option to mv(1) for more verbose output. $ touch a $ mv -v a b 'a' -> 'b' $ mkdir c $ mv -v b c 'b' -> 'c/b' $ mv -v c d 'e' -> 'd' And here is an example of the output of the situation mentioned in the

[PATCH] cp(1): add -v option for verbosity

Dear team, This patch adds a -v option to cp(1) for more verbose output. $ touch a b; mkdir c $ cp -v a b c 'a' -> 'c/a' 'b' -> 'c/b' $ cp -rv c d 'c' -> 'd/' 'c/a' -> 'd/a' 'c/b' -> 'd/b' Kind regards, Job diff --git bin/cp/cp.1

[PATCH] ffs: always assign random inode generation numbers

Hello, In ffs_inode_alloc(), inode generation numbers are incremented after being assigned an initial random value. Since the di_gen field is a signed integer, it may overflow, causing undefined behavior (this is unlikely to ever happen, though). This patch always assigns a random non-zero

Re: [PATCH] ffs: always assign random inode generation numbers

Dmitry Chestnykh wrote: > Hello, > > In ffs_inode_alloc(), inode generation numbers are incremented after > being assigned an initial random value. Since the di_gen field is a > signed integer, it may overflow, causing undefined behavior (this is > unlikely to ever happen, though). > > This

[patch] dhcpd.h

Remove unused structs and line up some comments. Index: dhcpd.h === RCS file: /cvs/src/usr.sbin/dhcpd/dhcpd.h,v retrieving revision 1.64 diff -u -p -u -r1.64 dhcpd.h --- dhcpd.h24 Apr 2017 14:58:36 -1.64 +++ dhcpd.h

Re: [PATCH] cp(1): add -v option for verbosity

On Sun, Jun 25, 2017 at 10:49:04PM +0200, Landry Breuil wrote: | > | Alternatively one can use rsync(1), but that is not part of the base. | > | > That may work for cp(1), but it's hard to replicate mv(1) behavior | > with rsync (only metadata changes when on the same fs) or even | > impossible

Re: [PATCH] ffs: always assign random inode generation numbers

Here's another version: it starts with a random 31-bit integer and then for subsequent allocations sets 23 random bits and incremented 8 bits from the previous generation number, so it's guaranteed to not repeat for at least 256 allocations (suggested by Kai Antweiler). -Dmitry Index:

Re: [PATCH] cp(1): add -v option for verbosity

On Sun, Jun 25, 2017 at 02:06:20PM +0200, Job Snijders wrote: > This patch adds a -v option to cp(1) for more verbose output. NetBSD/FreeBSD/DragonFly/OSX's cp(1) with "-v" print file names without the single quotes, which might indeed be more appealing to the eye: $ touch a b; mkdir c

ospfd: add IMSG_IFADDRADD to deal with "sh /etc/netstart if"

Hi, ospfd does not react nicely when running "sh /etc/netstart if". This is because adding the same address again do an interface results in RTM_DELADDR and RTM_NEWADDR. ospfd handles the former but the later. If this happens ospfd says "interface vether0:192.168.250.1 gone". Adjacencies on that

Re: make it easier to configure IPv6 on gif(4)

On Sat, Jun 24, 2017 at 07:09:20AM +0200, Stefan Sperling wrote: > ok? OK bluhm@ > > Index: ifconfig.c > === > RCS file: /cvs/src/sbin/ifconfig/ifconfig.c,v > retrieving revision 1.344 > diff -u -p -r1.344 ifconfig.c > ---

Re: [PATCH 3/3] openbgpd: Add well-known community GRACEFUL_SHUTDOWN

ok Job Snijders(j...@instituut.net) on 2017.06.23 16:02:13 +0200: > Dear team, > > This patch adds support for the "graceful shutdown" well-known > community as described in draft-ietf-grow-bgp-gshut. > > An example implementation would be to add the following to your > bgpd.conf: > >

Re: [PATCH] rm(1): add -v option for verbosity

On Sun, Jun 25, 2017 at 11:16:00PM +0200, Ingo Schwarze wrote: > Hi, > > Paul de Weerd wrote on Sun, Jun 25, 2017 at 10:46:15PM +0200: > > On Sun, Jun 25, 2017 at 03:12:26PM +0200, Ingo Schwarze wrote: > > > | If you are really unsure, study the output of > > | $ find * > > | first, before

Re: [PATCH] cp(1): add -v option for verbosity

Job Snijders wrote: > On Sun, Jun 25, 2017 at 02:06:20PM +0200, Job Snijders wrote: > > This patch adds a -v option to cp(1) for more verbose output. > > NetBSD/FreeBSD/DragonFly/OSX's cp(1) with "-v" print file names without > the single quotes, which might indeed be more appealing to the eye:

Re: [PATCH] ffs: always assign random inode generation numbers

On Sun, Jun 25, 2017 at 8:34 PM, Ted Unangst wrote: >> This patch always assigns a random non-zero positive integer in [1, >> INT_MAX] range, not equal to the previous generation number. > > will this cause problems if a number repeats? we've seen problems with that > before,

Re: [PATCH] cp(1): add -v option for verbosity

On Sun, Jun 25, 2017 at 06:22:05PM +0200, Job Snijders wrote: | Dear Alexander, | | On Sun, Jun 25, 2017 at 06:13:40PM +0200, Alexander Hall wrote: | > On June 25, 2017 2:06:20 PM GMT+02:00, Job Snijders wrote: | > >This patch adds a -v option to cp(1) for more verbose

Re: [PATCH] cp(1): add -v option for verbosity

On Sun, Jun 25, 2017 at 09:59:35PM +0200, Paul de Weerd wrote: > On Sun, Jun 25, 2017 at 06:22:05PM +0200, Job Snijders wrote: > | Dear Alexander, > | > | On Sun, Jun 25, 2017 at 06:13:40PM +0200, Alexander Hall wrote: > | > On June 25, 2017 2:06:20 PM GMT+02:00, Job Snijders

Re: [PATCH 2/3] openbgpd: Add support for 'unknown' well-known communities

On Sun, Jun 25, 2017 at 11:41:05PM +0200, Sebastian Benoit wrote: > ok > > as wor the WELLKNOWN, what do other implementations do? I'm not aware of other implementations that do a blanket replacement of "65535:" with something like "WELLKNOWN:" in their CLI output. Most implementations (after

Re: [diffs] libcrypto: minor man page fix & question about odd function types

Hi, Jack Burton wrote on Wed, Jun 21, 2017 at 11:45:38PM +0930: > X509_VERIFY_PARAM_set_flags(3) states that > X509_VERIFY_PARAM_set_flags() and X509_VERIFY_PARAM_clear_flags() > both "return 1 for success or 0 for failure". Which is true. > But both those functions always return 1 In the

Re: pf fragment drop stale

On Fri, Jun 23, 2017 at 03:00:07PM +0200, Alexander Bluhm wrote: > Adjusted timeouts will follow in the next diff. To avoid that fragments for a single connection that reuse the fragment id are reassembled into the wrong packet, throw away stale fragments. With the default timeout this happens

Re: [PATCH] rm(1): add -v option for verbosity

Hi Ingo, On Sun, Jun 25, 2017 at 03:12:26PM +0200, Ingo Schwarze wrote: | Hi, | | Job Snijders wrote on Sun, Jun 25, 2017 at 02:06:16PM +0200: | | > This patch adds a '-v' option to rm(1) for more verbose output. | | Do not add new options to standard utilities, unless you can show | that they

Re: make it easier to configure IPv6 on gif(4)

ok Stefan Sperling(s...@stsp.name) on 2017.06.24 07:09:20 +0200: > The kernel rejects IPv6 destination addresses on point-to-point > interfaces if the prefixlen is not 128. Because ifconfig defaults > to prefixlen 64, configuring IPv6 on e.g. gif(4) requires an > explicit prefix length, for

Re: [PATCH] rm(1): add -v option for verbosity

On Sun, Jun 25, 2017 at 04:09:11PM +0200, Job Snijders wrote: > --- bin/rm/rm.1 > +++ bin/rm/rm.1 > @@ -95,6 +95,8 @@ that directory is skipped. > .It Fl r > Equivalent to > .Fl R . > +.It Fl v > +Explain what is being done. On second thought, "Display what files were removed." would

Re: [PATCH] ffs: always assign random inode generation numbers

+ do { + ngen = arc4random_uniform(INT_MAX) + 1; + } while (DIP(ip, gen) == ngen); arc4random_uniform contains a potential loop (approx 1 in 4billion) for uniform resolution, and this wraps it with another loop (approx 1 in 4billion). I'd really prefer to see a

Re: [PATCH] ffs: always assign random inode generation numbers

On Sun, Jun 25, 2017 at 8:20 PM, Theo de Raadt wrote: > I'd really prefer to see a construct which doesn't do that. But > I don't know if that would result in something really complex. Sure, will send a different version if the problem that tedu@ mentioned can be solved.

Re: [PATCH] rm(1): add -v option for verbosity

Hi, Paul de Weerd wrote on Sun, Jun 25, 2017 at 10:46:15PM +0200: > On Sun, Jun 25, 2017 at 03:12:26PM +0200, Ingo Schwarze wrote: > | If you are really unsure, study the output of > | $ find * > | first, before typing > | $ rm -rf * > | No non-standard option is needed at all for this. >

Re: [PATCH] ffs: always assign random inode generation numbers

> On Sun, Jun 25, 2017 at 10:47:08PM -0600, Theo de Raadt wrote: > >> :-) Speaking of signed integers, does it really need to be signed? > > > >Perhaps not. Anyone know for sure? > > > >Of course this number should probably exclude 0 in it's range. > Probably [0, 3] completely as those are

Re: [PATCH] ffs: always assign random inode generation numbers

On Sun, Jun 25, 2017 at 10:47:08PM -0600, Theo de Raadt wrote: :-) Speaking of signed integers, does it really need to be signed? Perhaps not. Anyone know for sure? Of course this number should probably exclude 0 in it's range. Probably [0, 3] completely as those are reserved for

Re: [PATCH] ffs: always assign random inode generation numbers

> :-) Speaking of signed integers, does it really need to be signed? Perhaps not. Anyone know for sure? Of course this number should probably exclude 0 in it's range.

[patch] dispatch.c

Move initialization out of if/else block, unruly space, and memset struct beforehand. Index: dispatch.c === RCS file: /cvs/src/usr.sbin/dhcpd/dispatch.c,v retrieving revision 1.43 diff -u -p -u -r1.43 dispatch.c --- dispatch.c

Re: [PATCH] cp(1): add -v option for verbosity

> Job Snijders wrote: > > On Sun, Jun 25, 2017 at 02:06:20PM +0200, Job Snijders wrote: > > > This patch adds a -v option to cp(1) for more verbose output. > > > > NetBSD/FreeBSD/DragonFly/OSX's cp(1) with "-v" print file names without > > the single quotes, which might indeed be more appealing

Re: Add Diffie-Hellman group negotiation to iked

Hi, In this message I've tried to encode everything I've done to allow strongSwan on Android to connect with iked, including the latest patch. I have also verified that it breaks neither initial negotiation nor Child SA rekeying for OpenBSD, Windows, and strongSwan (on Android) clients. Stuart

Re: [PATCH 2/3] openbgpd: Add support for 'unknown' well-known communities

ok as wor the WELLKNOWN, what do other implementations do? If others print it or accept it as input, lets keep it. If not, remove it from both your diff and bgpctls output. /Benno Job Snijders(j...@instituut.net) on 2017.06.25 14:59:21 +0200: > Small update. > > I renamed the 'msb' argument