Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/http/mapper HostMap.java Mapper.java

2005-06-05 Thread Remy Maucherat
Peter Rossbach wrote: The issue is that this mechanism is bad, period. Why it is so bad? The implementation was faster then the revert mapper state. What is a better way to implement this feature? The optimization is just a ploy to force feed us with the feature. As I said, using a

RE: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/http/mapper HostMap.java Mapper.java

2005-06-05 Thread George Sexton
-Original Message- From: Remy Maucherat [mailto:[EMAIL PROTECTED] Sent: Saturday, June 04, 2005 11:30 AM To: Tomcat Developers List Subject: Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/htt p/mapper HostMap.java Mapper.java And the usefulness

RE: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/http/mapper HostMap.java Mapper.java

2005-06-05 Thread George Sexton
-Original Message- From: Bill Barker [mailto:[EMAIL PROTECTED] Sent: Saturday, June 04, 2005 1:27 PM To: Tomcat Developers List Subject: Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/htt p/mapper HostMap.java Mapper.java - Original

Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/http/mapper HostMap.java Mapper.java

2005-06-05 Thread Remy Maucherat
George Sexton wrote: The reasoning as I explained in my very lengthy message justifying the patch is to allow the application to have different behaviors based on the virtual host name, without having to re-configure tomcat. Thanks, I didn't understand ;) What is amazing is that you're

Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/http/mapper HostMap.java Mapper.java

2005-06-05 Thread Remy Maucherat
George Sexton wrote: There's no justification here. Explain why you think the code is bad it's actually a hell of a lot cleaner and easier to follow than the original code, and it's 15% faster. What exactly are your criteria for measuring goodness. I stated the reason, and the main one is that

Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/http/mapper HostMap.java Mapper.java

2005-06-05 Thread Bill Barker
- Original Message - From: George Sexton [EMAIL PROTECTED] To: 'Tomcat Developers List' tomcat-dev@jakarta.apache.org Sent: Sunday, June 05, 2005 8:53 AM Subject: RE: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/http/mapper HostMap.java Mapper.java

Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/http/mapper HostMap.java Mapper.java

2005-06-04 Thread Remy Maucherat
[EMAIL PROTECTED] wrote: pero2005/06/04 05:32:53 Modified:util/java/org/apache/tomcat/util/http/mapper Mapper.java Added: util/java/org/apache/tomcat/util/http/mapper HostMap.java Log: Support Host Alias matching with Connector attribute allowedAliasMatches Submitted

Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/http/mapper HostMap.java Mapper.java

2005-06-04 Thread Peter Rossbach
Hey Remy, For usefull feature I don't give up :-) The default of host alias matching is off. The current implementation is little bit fast then the old one. (Great) Every user of this feature can limit the dynamic host addition with Connector port=8080 allowedAliasMatches=10 / The wild card

Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/http/mapper HostMap.java Mapper.java

2005-06-04 Thread Remy Maucherat
Peter Rossbach wrote: Hey Remy, For usefull feature I don't give up :-) Fine, I'll just revert your patch then ;) The default of host alias matching is off. The current implementation is little bit fast then the old one. (Great) Every user of this feature can limit the dynamic host

Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/http/mapper HostMap.java Mapper.java

2005-06-04 Thread Bill Barker
- Original Message - From: Remy Maucherat [EMAIL PROTECTED] To: Tomcat Developers List tomcat-dev@jakarta.apache.org Sent: Saturday, June 04, 2005 10:29 AM Subject: Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/http/mapper HostMap.java Mapper.java

Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/http/mapper HostMap.java Mapper.java

2005-06-04 Thread Peter Rossbach
Hey. Remy Maucherat schrieb: Peter Rossbach wrote: Hey Remy, For usefull feature I don't give up :-) Fine, I'll just revert your patch then ;) Hmm, thanks for that... :-( The default of host alias matching is off. The current implementation is little bit fast then the old one.