RE: DO NOT REPLY [Bug 13861] - Authentication / SSL conflict (web.xml security-constraint auth-constraint user-data-constraint)

2003-07-17 Thread Mark Thomas
All, I would like to write a patch for this bug but before I do I have a few questions I would value your opinions on: 1. If the root cause is an IE but, should we do anything? 2. If we do make a change, is it reasonable to modify org.apache.coyote.http11.Http11Processor.parseHost() to always

RE: Bug 19867

2003-08-14 Thread Mark Thomas
On Tuesday, August 12, 2003 12:39 AM, Bill Barker [SMTP:[EMAIL PROTECTED] wrote: - Original Message - From: Mark Thomas [EMAIL PROTECTED] To: [EMAIL PROTECTED] Sent: Monday, August 11, 2003 3:23 PM Subject: RE: Bug 19867 I have been looking into http://nagoya.apache.org

[PATCH] Prevent NPE if CLIENT-CERT auth fails

2003-08-20 Thread Mark Thomas
A small patch. If auth fails, SSL session is terminated. Subsequent call to sslSupport.getPeerCertifcate() generates a NPE as sslSupport is null in this case. dditional commands, e-mail: [EMAIL PROTECTED]

RE: [PATCH] Prevent NPE if CLIENT-CERT auth fails

2003-08-30 Thread Mark Thomas
,e); } - } } On Wednesday, August 20, 2003 9:05 PM, Mark Thomas [SMTP:[EMAIL PROTECTED] wrote: A small patch. If auth fails, SSL session is terminated. Subsequent call to sslSupport.getPeerCertifcate() generates a NPE as sslSupport is null in this case. File

[PATCH] for bug 3098

2003-08-31 Thread Mark Thomas
A patch for the above is below. This patch addresses the issues raised by the second test case attached to the bug report. The first test case was fixed previously and the third test case works correctly with the current source. I have checked the TC4 and TC5 code against the TC3 code (where

[PATCH] Bug 3098 - Port to tc4

2003-09-01 Thread Mark Thomas
Port of my previous patch to tomcat 4. As previously, I took the opportunity to remove some unused imports. Mark Index: coyote/src/java/org/apache/coyote/tomcat4/CoyoteRequest.java === RCS file:

[PATCH] Bug 22823 Minor documentation update

2003-09-02 Thread Mark Thomas
Patch for bug 22823 is below. Need to make sure that http://jakarta.apache.org/tomcat/tomcat-4.1-doc/README.txt is also updated. Whilst looking at this I noticed that the nightly build directory is empty. Is this correct or has it moved? Either way the readme should be updated to reflect the

[PATCH] CGI Servlet bugs

2003-09-02 Thread Mark Thomas
Below is a patch for bug 22857, bug 22858 and one additional issue I found whilst looking at the other issues. I am concerned that the patch may only work on windows platforms and would appreciate it if someone with non-Windows knowledge could review this patch. I have included TC5 and TC4

[PATCH] Bug 22715

2003-09-04 Thread Mark Thomas
Resending. I seem to be having e-mail problems... The patches below (TC5 and TC4) fix bug 22715 in that they ensure that xml entities are correctly written back out to the password field of tomcat-users.xml I did consider a more general patch to allow xml entities in user names, group names

[PATCH] Bug 22715

2003-09-04 Thread Mark Thomas
The patches below (TC5 and TC4) fix bug 22715 in that they ensure that xml entities are correctly written back out to the password field of tomcat-users.xml I did consider a more general patch to allow xml entities in user names, group names and role names but wasn't sure of the potential side

[PATCH] Bug 22823 Minor documentation update

2003-09-05 Thread Mark Thomas
Patch for bug 22823 is below. Need to make sure that http://jakarta.apache.org/tomcat/tomcat-4.1-doc/README.txt is also updated. Whilst looking at this I noticed that the nightly build directory is empty. Is this correct or has it moved? Either way the readme should be updated to reflect the

[PATCH] Bug 22715

2003-09-05 Thread Mark Thomas
The patches below (TC5 and TC4) fix bug 22715 in that they ensure that xml entities are correctly written back out to the password field of tomcat-users.xml I did consider a more general patch to allow xml entities in user names, group names and role names but wasn't sure of the potential side

[PATCH] Bug 22666

2003-09-05 Thread Mark Thomas
URIs are always UTF-8 encoded. Therefore the parameter encoding should be set to UTF-8 and not to the request encoding (if set). Patches for TC5 and TC4 are below. Mark Index: catalina/src/share/org/apache/coyote/tomcat5/CoyoteRequest.java

RE: [PATCH] Bug 22666

2003-09-05 Thread Mark Thomas
:[EMAIL PROTECTED] wrote: Mark Thomas wrote: URIs are always UTF-8 encoded. Therefore the parameter encoding should be set to UTF-8 and not to the request encoding (if set). Patches for TC5 and TC4 are below. ? This is incorrect, strong -1 for this patch. Remy

RE: [PATCH] Bug 22666

2003-09-06 Thread Mark Thomas
is that option 3 is way to go. Before I start coding, I would be grateful for some feedback/guidance on my planned approach. Thanks in anticipation. Mark On Friday, September 05, 2003 8:13 PM, Remy Maucherat [SMTP:[EMAIL PROTECTED] wrote: Mark Thomas wrote: I was working from http://www.w3.org

RE: [PATCH] Bug 22666

2003-09-07 Thread Mark Thomas
On Sunday, September 07, 2003 8:47 AM, Remy Maucherat [SMTP:[EMAIL PROTECTED] wrote: Remy Maucherat wrote: I've just committed a very simple implementation of this (without the extra queryStringEncoding field, although this is not hard to add). Comments ? Remy Thanks for your help with

RE: [PATCH] Bug 22666

2003-09-09 Thread Mark Thomas
This works a treat. Do you want me to port the changes back to TC4? I need to do this so I can close the bug. Mark On Sunday, September 07, 2003 3:40 PM, Remy Maucherat [SMTP:[EMAIL PROTECTED] wrote: The idea is that it would work if the type of the MB is chars (see processParameters(MB)).

RE: Temporary (for development) CLASSPATH problem (tomcat 4)

2003-09-18 Thread Mark Thomas
How about using ant to compile and deploy your application? This would enable you to have complete control over the locations of your source files, your compilied classes and the war file. Mark On Thursday, September 18, 2003 6:45 PM, Peter Swulius [SMTP:[EMAIL PROTECTED] wrote: File:

[PATCH] Bug 23267

2003-09-27 Thread Mark Thomas
Resending. I have been having email problems recently. Apologies if this is received twice. The attached patches address a couple of issue highlighted by bug 23267 - zero length contexts caused a NPE on contextFile.getParentFile() - another exception on contextPath.substring(1) for zero length

[PATCH] Bug 3098 - Port to tc4

2003-09-27 Thread Mark Thomas
Going back through my list of things to do, the port of this patch hasn't yet been committed. Please could one of the committers do this so I can close bug 3098. Thanks, Mark Port of my previous patch to tomcat 4. As previously, I took the opportunity to remove some unused imports. Mark

RE: [PATCH] Bug 22666

2003-09-27 Thread Mark Thomas
Maucherat [SMTP:[EMAIL PROTECTED] wrote: Mark Thomas wrote: On Sunday, September 07, 2003 8:47 AM, Remy Maucherat [SMTP:[EMAIL PROTECTED] wrote: Remy Maucherat wrote: I've just committed a very simple implementation of this (without the extra queryStringEncoding field, although

RE: [PATCH] Bug 23267

2003-09-27 Thread Mark Thomas
Thanks for looking at this. I'll look into porting the necessary deployer changes to get this working on TC4. Mark On Saturday, September 27, 2003 1:26 PM, Remy Maucherat [SMTP:[EMAIL PROTECTED] wrote: Mark Thomas wrote: Resending. I have been having email problems recently. Apologies

[PATCH] Bug 23267

2003-09-27 Thread Mark Thomas
The attached patches address a couple of issue highlighted by bug 23267 - zero length contexts caused a NPE on contextFile.getParentFile() - another exception on contextPath.substring(1) for zero length contexts I also removed the filename.equals(ROOT) test as I couldn't see anywhere in the docs

RE: [PATCH] Bug 22666

2003-09-27 Thread Mark Thomas
release of TC 5 is still some way off I would be uncomfortable with any freeze of TC 4.1 as this would leave users with non-critical issues in limbo until a stable TC 5 is released. Comments? Mark On Saturday, September 27, 2003 1:42 PM, Remy Maucherat [SMTP:[EMAIL PROTECTED] wrote: Mark Thomas

Trying to fix bug 24392

2003-11-08 Thread Mark Thomas
All, I have been looking at the above bug and believe I have tracked the root cause down to org.apache.webapp.admin.defaultcontext.EditDefaultContextAction.java. Lines 173 and 195 refer to the DefaultLoader and DefaultManager respectively for which mBeans do not exist. I have had a look at

PATCH Bug24368

2003-11-09 Thread Mark Thomas
Please find below patches to catch an unhandled exception as reported in bug 24368. I have included patches for TC4 and TC5. The TC4 patch also includes removing some unused imports (thanks to Eclipse :) ) Grateful if one of the committers could apply them. Thanks, Mark TC4 patch follows:

RE: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/servlets WebdavServlet.java

2003-11-16 Thread Mark Thomas
, 2003 10:16 AM, [EMAIL PROTECTED] [SMTP:[EMAIL PROTECTED] wrote: remm2003/11/14 02:16:22 Modified:catalina/src/share/org/apache/catalina/servlets WebdavServlet.java Log: - Allow header handling. - Bug 24006, submitted by Mark Thomas. Revision

RE: Tomcat 3.3.2 release question - was RE: [5.0.15] Testbuild available

2003-11-26 Thread Mark Thomas
I can confirm that Larry is correct. TC4 (and TC5) behaviour is that any session created under an HTTPS connection will not normally be available via HTTP. There is a workaround that enables this behaviour. The bug report below gives more details.

[PATCH] Servlet Examples

2003-12-06 Thread Mark Thomas
Noticed this while looking at the examples. Worth making sure we get this sort of thing right. Mark Index: webapps/examples/servlets/helloworld.html === RCS file:

RE: jakarta-servletapi-4

2003-12-09 Thread Mark Thomas
If you can wait a day or so I have some fixes to the javadoc comments to commit. Only affects javadoc warnings during build so no problem if you need to go ahead without them. I need to figure out how to use my newly acquired commit privs before I can make the changes ;) Mark On Tuesday,

RE: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core ApplicationContext.java

2004-04-04 Thread Mark Thomas
From: Remy Maucherat [mailto:[EMAIL PROTECTED] Mark Thomas wrote: Fixing bug 13040 requires an additional patch that uses equals() for the whole algorithm. Hence the complications. This is what I was discussing above. The matching rule can't be fully implemented AFAIK. I think

RE: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core ApplicationContext.java

2004-04-04 Thread Mark Thomas
From: Remy Maucherat [mailto:[EMAIL PROTECTED] My proposal is to change getContext to provide the following behaviour: Context uripath result -- A / A A /foo/ B A /foo/bar/ C A /foo/bar/xxx/

RE: [5.0] JMX 1.2

2004-04-04 Thread Mark Thomas
Remy, Any further thoughts on this now the licencing issues appear to be resolved? Just thinking about how to fix bug 28178. Mark From: Remy Maucherat [mailto:[EMAIL PROTECTED] Amy Roh wrote: Hi Remy, JSR 160 will go final in October (assuming the final ballot passes, as seems

RE: Spam vulnerability at apache

2004-04-14 Thread Mark Thomas
Moderators get these messages too when we post to the list. There is usually no need to ask us to remove them as we do it as a matter of course. Depending on a number of factors, the address may also get barred from re-subscribing. Please give us a reasonable time to spot and remove them before

RE: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core ApplicationDispatcher.java

2004-04-24 Thread Mark Thomas
From: Remy Maucherat [mailto:[EMAIL PROTECTED] [EMAIL PROTECTED] wrote: markt 2004/04/24 08:12:00 Modified:catalina/src/share/org/apache/catalina/core ApplicationDispatcher.java Log: - Fix bug19801. Request dispatcher does not set empty

RE: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core ApplicationDispatcher.java

2004-04-24 Thread Mark Thomas
-Original Message- From: Remy Maucherat [mailto:[EMAIL PROTECTED] Sent: Saturday, April 24, 2004 4:32 PM To: Tomcat Developers List Subject: Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina /core ApplicationDispatcher.java Remy Maucherat wrote:

RE: New RM for Tomcat 5

2004-05-10 Thread Mark Thomas
+1 Mark From: Remy Maucherat [mailto:[EMAIL PROTECTED] Sent: Sunday, May 09, 2004 3:43 PM To: Tomcat Developers List Subject: New RM for Tomcat 5 Hi, Yoav has expressed interest in being the release manager for Tomcat 5. Since he has shown interest in nearly all Tomcat components,

WebappClassLoader: Lifecycle error : CL stopped

2004-04-27 Thread Mark Thomas
All, I have been looking at a couple of bugs in the admin app and have come across a problem with creating new hosts and contexts. The scenario is: 1. Create new host 2. Create new root context for the new host 3. Try to access jsp in new root context This gives causes the WebappClassLoader:

RE: WebappClassLoader: Lifecycle error : CL stopped

2004-04-28 Thread Mark Thomas
From: Remy Maucherat [mailto:[EMAIL PROTECTED] Sent: Tuesday, April 27, 2004 11:26 PM To: Tomcat Developers List Subject: Re: WebappClassLoader: Lifecycle error : CL stopped Shapira, Yoav wrote: Hi, I like #2: in fact, it seems like it should be strictly enforced for general

RE: WebappClassLoader: Lifecycle error : CL stopped

2004-05-04 Thread Mark Thomas
From: Remy Maucherat [mailto:[EMAIL PROTECTED] Sent: Tuesday, April 27, 2004 11:26 PM To: Tomcat Developers List Subject: Re: WebappClassLoader: Lifecycle error : CL stopped Shapira, Yoav wrote: Hi, I like #2: in fact, it seems like it should be strictly enforced for general

RE: Claudia Mendes/QPortugal está ausente de la oficina.

2004-05-27 Thread Mark Thomas
Personally, I don't find single messages that annoying. My personal approach is to let them send a single message. If I spot multiple messages from the same person I kick them off the list. Mark -Original Message- From: Martin Gainty [mailto:[EMAIL PROTECTED] Sent: Thursday, May 27,

RE: Valide o seu email

2004-06-15 Thread Mark Thomas
All, Apologies for the spam from this address. Just to let you know I have kicked them off the list and banned them from re-subscribing. Come the revolution auto-responders will be one of the first things up against the wall... While I am on the subject of kicking people off the list, those of

RE: Connecting to and updating the Tomcat user database

2004-06-15 Thread Mark Thomas
Please ask this question on the tomcat-user mailing list. tomcat-dev is for people developing tomcat, not for people developing with tomcat. Mark -Original Message- From: Robert Harper [mailto:[EMAIL PROTECTED] Sent: Tuesday, June 15, 2004 8:30 PM To: Tomcat Dev Subject:

Connector bugs

2004-06-16 Thread Mark Thomas
All, There are a number of reports in bugzilla for TC4 against the connectors. Since TC4 and TC5 use the same connectors and TC5 is under active development I propose re-assigning all connector bugs currently against TC4 to TC5. My aim is to increase the likelihood of resolving these bugs. From

RE: Connector bugs

2004-06-16 Thread Mark Thomas
Informatics -Original Message- From: Mark Thomas [mailto:[EMAIL PROTECTED] Sent: Wednesday, June 16, 2004 2:37 PM To: 'Tomcat Developers List' Subject: Connector bugs All, There are a number of reports in bugzilla for TC4 against the connectors. Since TC4 and TC5 use the same

RE: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/coyote/tomcat5 CoyoteResponse.java

2004-06-19 Thread Mark Thomas
Fair point - I'll revert it now. Is your objection to the concept of supporting mailto in redirect or just this bad implementation of it? I have seen some uses of this and some users must want to do it or the bug report would never have been filed. I am happy to work on a better implementation.

RE: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/coyote/tomcat5 CoyoteResponse.java

2004-06-20 Thread Mark Thomas
PROTECTED] Sent: Saturday, June 19, 2004 9:47 PM To: Tomcat Developers List Subject: Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/coyote/t omcat5 CoyoteResponse.java - Original Message - From: Mark Thomas [EMAIL PROTECTED] To: 'Tomcat Developers List' [EMAIL

RE: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/loader WebappClassLoader.java

2004-07-03 Thread Mark Thomas
From: Bill Barker [mailto:[EMAIL PROTECTED] From: [EMAIL PROTECTED] === RCS file: /home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apach e/catalina/loa der/WebappClassLoader.java,v retrieving revision 1.36

RE: cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/loader WebappClassLoader.java

2004-07-03 Thread Mark Thomas
Sorry about the comment - finger trouble on my part ;) Mark -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] Sent: Saturday, July 03, 2004 8:52 PM To: [EMAIL PROTECTED] Subject: cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/load er

RE: Hin Kan Lee/Prymnewey is out of the office.

2004-07-14 Thread Mark Thomas
Just done it. Mark -Original Message- From: Mladen Turk [mailto:[EMAIL PROTECTED] Sent: Wednesday, July 14, 2004 7:11 PM To: 'Tomcat Developers List' Subject: RE: Hin Kan Lee/Prymnewey is out of the office. Can someone kill this guy? -Original Message- From:

RE: getReader() BUG in tomcat 4.1.30 and beyond ?

2004-07-25 Thread Mark Thomas
I have just run a simple test using the latest 4.1.x branch from CVS and I do not see this bug - the data is displayed as expected. This was with tomcat standalone running on port 8080. There are two explanations for this: 1. There is a bug in 4.1.30 that has been fixed in CVS 2. There is

RE: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/mbeans MBeanUtils.java

2004-07-29 Thread Mark Thomas
Ah. Hadn't spotted that. I'll have a look. Thanks for the heads up. Mark -Original Message- From: Bill Barker [mailto:[EMAIL PROTECTED] Sent: Thursday, July 29, 2004 9:08 PM To: Tomcat Developers List Subject: Re: cvs commit:

RE: New committer: Peter Rossbach

2004-07-30 Thread Mark Thomas
+1 Mark -Original Message- From: Remy Maucherat [mailto:[EMAIL PROTECTED] Sent: Friday, July 30, 2004 2:05 PM To: Tomcat Developers List Subject: New committer: Peter Rossbach Hi, I'd like to nominate Peter Rossbach pr _at_ objektpark.de as a committer on the Tomcat

RE: tomcat build broken with strange javac error(never seen this one before)

2004-08-12 Thread Mark Thomas
1. Ignore the stop sending me mail message. Someone has managed to get themselves subscribed to the list and is obviously incapable of following the simple instructions included in every mail to unsubscribe. One of the list owners (of which I am one) will sort this out. 2. 3. The right place to

RE: building tomcat source in eclipse

2004-08-12 Thread Mark Thomas
What are you trying to achieve? I use Eclipse to develop TC5 ( TC4) but always build from the command line. I have each of the top level directories created by the build script as an Eclipse project. You can still use remote debugging etc as well as all the other Eclipse features. Mark

RE: Servlet.service error

2004-08-12 Thread Mark Thomas
Yes. Try posting on the tomcat-user mailing list. Mark -Original Message- From: Schalk Neethling [mailto:[EMAIL PROTECTED] Sent: Thursday, August 12, 2004 10:29 PM To: Tomcat Developers List Subject: Re: Servlet.service error Hey all! Does anyone have a suggestion here, or I

RE: Servlet.service error

2004-08-12 Thread Mark Thomas
: Servlet.service error Mark I did and have not received any response yet, that is why I double posted on the dev list. I thought it may be a dev issue. Mark Thomas wrote: Yes. Try posting on the tomcat-user mailing list. Mark -Original Message- From: Schalk Neethling [mailto

RE: building tomcat source in eclipse

2004-08-12 Thread Mark Thomas
, dean -Original Message- From: Mark Thomas [mailto:[EMAIL PROTECTED] Sent: Thursday, August 12, 2004 2:24 PM To: 'Tomcat Developers List'; 'Patrick Lacson' Subject: RE: building tomcat source in eclipse What are you trying to achieve? I use Eclipse to develop TC5 ( TC4

RE: cvs commit: jakarta-tomcat-catalina/webapps/docs cgi-howto.xml

2004-08-16 Thread Mark Thomas
Sorry. Finger trouble. Comment for this should have been: Housekeeping in CGI servlet. -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] Sent: Monday, August 16, 2004 11:27 PM To: [EMAIL PROTECTED] Subject: cvs commit: jakarta-tomcat-catalina/webapps/docs

RE: [VOTE] 4.1.31 maintenance release

2004-08-20 Thread Mark Thomas
ballot The 4.1.31 maintenance release should happen: [X] Yes [ ] No /ballot Just such a thing has been on my mind for a while. Whilst in an ideal world everyone would migrate to 5.x, I have seen many organisations prefer to stay on earlier versions of software for a variety of reasons. I

Karma for jakarta-servlet-*

2004-08-20 Thread Mark Thomas
There are some bugs in the examples I want to fix. AFAIK we can fix these but we can't change any of the API stuff - right? Anyway, how do I go about getting karma for these packages? Thanks, Mark - To unsubscribe, e-mail:

RE: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler JspDocumentParser.java Validator.java

2004-08-22 Thread Mark Thomas
Sorry, finger trouble on my part. The log should have been: Fix bug 13956. XSI Namespace Declaration should not be interpreted as a tag library declaration -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] Sent: Sunday, August 22, 2004 4:52 PM To: [EMAIL

RE: cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2004-08-23 Thread Mark Thomas
The reporter of the bug was trying to use a filter to override the contents of the server header and set it to no name. They didn't say so, but I am guessing there was a security motive behind their actions. Mark -Original Message- From: Remy Maucherat [mailto:[EMAIL PROTECTED]

RE: cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2004-08-23 Thread Mark Thomas
From: Bill Barker [mailto:[EMAIL PROTECTED] - Original Message - From: Remy Maucherat [EMAIL PROTECTED] To: Tomcat Developers List [EMAIL PROTECTED] Sent: Monday, August 23, 2004 1:01 PM Subject: Re: cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11

RE: cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2004-08-23 Thread Mark Thomas
From: Remy Maucherat [mailto:[EMAIL PROTECTED] Mark Thomas wrote: The reporter of the bug was trying to use a filter to override the contents of the server header and set it to no name. They didn't say so, but I am guessing there was a security motive behind their actions. Well

jakarta-servletapi-4 and jakarta-servletapi-5 karma request

2003-12-10 Thread Mark Thomas
Please can I have karma for jakarta-servletapi-4 and jakarta-servletapi-5. I have some patches to commit (javadoc fixes and an example update). Thanks, Mark - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands,

FW: Please update your email address...

2003-12-10 Thread Mark Thomas
Could someone with control of the mailing list remove the addresses below from the list. Thanks, Mark We're sorry, but the RAD general email addresses have changed recently (to slow the flood of spam sigh). Please use one of these addresses instead: Sales: [EMAIL PROTECTED] RAD Video

RE: DO NOT REPLY [Bug 24005] - various issues with values of live properties

2003-12-10 Thread Mark Thomas
The lack of commit messages was confusing me for a while but I managed to figure it out eventually. I just had to read the committer documentation ;) Mark On Wednesday, December 10, 2003 11:16 PM, Remy Maucherat [SMTP:[EMAIL PROTECTED] wrote: Woohoo, WebDAV fixes at last :) BTW, if you're

RE: jakarta-servletapi-4

2003-12-12 Thread Mark Thomas
: Works for me -- no rush. How about just tag it once you've checked those doc warning fixes in? :-) Keith | -Original Message- | From: Mark Thomas [mailto:[EMAIL PROTECTED] | Sent: Tuesday, December 09, 2003 2:03 PM | To: 'Tomcat Developers List' | Subject: RE: jakarta-servletapi-4

RE: jakarta-servletapi-4

2003-12-15 Thread Mark Thomas
ChemInformatics -Original Message- From: Mark Thomas [mailto:[EMAIL PROTECTED] Sent: Thursday, December 11, 2003 5:40 PM To: 'Tomcat Developers List' Subject: RE: jakarta-servletapi-4 Keith, I can't commit the fixes until I have jakarta-servletapi-4 karma. Can you help

RE: Important information about jakarta-servletapi-*

2003-12-17 Thread Mark Thomas
Mark, One final question. The javadoc bugs I was looking at were of the following types: - @returns used rather than @return - @seealso used rather than @see - etc Is it permitted to make changes to fix these? There were no changes to the actual text of the javadoc. Thanks, Mark On

License files error

2003-12-23 Thread Mark Thomas
All, There is a small grammatical error in most (all?) of the license files in various tomcat CVS repositories as described in http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10286. Does anyone have any objection to me editing the tomcat license files to align them with the official version

License files error

2003-12-23 Thread Mark Thomas
Resending using my apache e-mail address. Sorry for the duplicate mail. All, There is a small grammatical error in most (all?) of the license files in various tomcat CVS repositories as described in http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10286. Does anyone have any objection to me

RE: License files error

2003-12-23 Thread Mark Thomas
A lot of the license files in tomcat have the following lines: * 1. Redistributions of source code must retain the above copyright notice * *notice, this list of conditions and the following disclaimer. * Note that notice appears at the end of the first line as well as the

RE: cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/authenticator SingleSignOn.java

2003-12-23 Thread Mark Thomas
Brian, Sorry I didn't spot the overlap between your patch and my recent commit. If you could update your TC4.1 patch I would be happy to commit it. However, I wouldn't want your work on the patch to distract you from your Christmas shopping ;) Mark On Tuesday, December 23, 2003 7:20 PM,

RE: License files error

2003-12-23 Thread Mark Thomas
Will do. I'll start preparing the patches now. Mark On Tuesday, December 23, 2003 6:23 PM, Dirk-Willem van Gulik [SMTP:[EMAIL PROTECTED] wrote: On Tue, 23 Dec 2003, Mark Thomas wrote: A lot of the license files in tomcat have the following lines: * 1. Redistributions of source code

RE: License files error - PMC Approval Required

2003-12-23 Thread Mark Thomas
OK. The patch files have all been attached to the bug report at http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10286 Once I get the OK from the PMC I will commit them. Mark On Tuesday, December 23, 2003 9:21 PM, Mark Thomas [SMTP:[EMAIL PROTECTED] wrote: Will do. I'll start preparing

[PATCH - Proposed] Bug 10526

2003-12-27 Thread Mark Thomas
All, Looking at bug 10526 (http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10526) the patch below is proposed as the fix. Is there any reason not to apply it? I had a look at the spec for both sessions and authentication and couldn't see anything that would prevent it. Thanks in advance for

RE: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/resources messages.properties

2004-01-06 Thread Mark Thomas
Larry, AFAIK Tomcat behaviour does not depend on the version of the deployment descriptor schema apart from during the interpretation of the descriptor. On this basis, I am against setting a precedent here. Further, my understanding is that each version of Tomcat is written to support a single

RE: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core StandardHostDeployer.java

2004-01-06 Thread Mark Thomas
When I tested the deploy task, the behaviour I saw was that the original codedocBase = ExpandWar.expand(host, war, contextPath)code; failed to create any files at all in the webapp directory. The root context _was_ displayed in the manager app but when I tried to access it all I saw was a

RE: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/resources messages.properties

2004-01-06 Thread Mark Thomas
warning to the user since the application is not following the specification. --- Mark Roth, Java Software JSP 2.0 Co-Specification Lead Sun Microsystems, Inc. Mark Thomas wrote: Larry, AFAIK Tomcat behaviour does not depend on the version of the deployment descriptor schema apart

RE: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core StandardHostDeployer.java

2004-01-07 Thread Mark Thomas
} username=${username} password=${password} path= war=file:///C:\\javadev\\bugsopen\\bug11682\\build\\bug11682.war / /target On Wednesday, January 07, 2004 5:35 AM, Remy Maucherat [SMTP:[EMAIL PROTECTED] wrote: Mark Thomas wrote: When I tested the deploy task, the behaviour I saw

RE: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core StandardHostDeployer.java

2004-01-07 Thread Mark Thomas
] wrote: Mark Thomas wrote: It isn't beyond the realm of possibility that I am doing something stupid. This is what I did. Whilst looking into bug11682 I created a very simple web app (just index.jsp) made a war and then tried to deploy it via ant. I modified the build.xml from the manager

RE: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core StandardHostDeployer.java

2004-01-07 Thread Mark Thomas
OK, will do. Mark On Wednesday, January 07, 2004 9:52 PM, Remy Maucherat [SMTP:[EMAIL PROTECTED] wrote: Mark Thomas wrote: What I found was the .war was uploaded to work\Standalone\localhost\bug11682 and then expanded to webapps. If I used a path of xyz then the .war was expanded

RE: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2004-01-18 Thread Mark Thomas
Resending from right account. My hair splitting detector is beeping. This session code will need to be optimized, BTW. Will do. Tomorrow OK? Rémy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands,

RE: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2004-01-19 Thread Mark Thomas
My hair splitting detector is beeping. This session code will need to be optimized, BTW. Will do. Tomorrow OK? Rémy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

cookies attribute on context element

2004-01-19 Thread Mark Thomas
All, Help. I am somewhat confused. All the docs and the comments in the code, AFAICT, indicate that the cookies attribute is for enabling/disabling session tracking via cookies. However, Remy's comments on http://nagoya.apache.org/bugzilla/show_bug.cgi?id=1 would appear to contradict this.

RE: cookies attribute on context element

2004-01-19 Thread Mark Thomas
? Mark -Original Message- From: Remy Maucherat [mailto:[EMAIL PROTECTED] Sent: Monday, January 19, 2004 10:18 PM To: Tomcat Developers List Subject: Re: cookies attribute on context element Mark Thomas wrote: All, Help. I am somewhat confused. All the docs and the comments

RE: PROPOSAL: move bugzilla posts to separate list

2004-01-20 Thread Mark Thomas
-1, commits and bugzilla messages are important to Agree, -1 for a change like this. sure - but what's the problem to subscribe to the bug list if you need it? All developers should be looking at the bugzilla posts (and the commits). This is a list for developers after all. correct,

[PROPOSED PATCH] Bug 13307

2004-01-25 Thread Mark Thomas
All, The patch below has been proposed for bug 13307 (http://nagoya.apache.org/bugzilla/show_bug.cgi?id=13307). Since it involves class loaders and anything that involves class loaders is still a bit of a black art to me, I would be grateful for review of this proposed patch. Thanks, Mark

WebDAV and TC5

2004-01-29 Thread Mark Thomas
All, Any objections to adding the WebDAV web application to TC5? The plan is to just copy the files across from TC4, modify the build scripts as required and make a small change to the web.xml to overcome an issue with welcome files. If no-one objects, I'll do this tomorrow. Mark

RE: WebDAV and TC5

2004-01-30 Thread Mark Thomas
From: Shapira, Yoav [mailto:[EMAIL PROTECTED] Howdy, I don't have a big objection. But we removed it from TC5 intentionally, not by accident. No one has been complaining, aside from the one user who just voice in a few minutes ago, so we should have a good argument for adding it back,

RE: WebDAV and TC5

2004-02-01 Thread Mark Thomas
From: Remy Maucherat [mailto:[EMAIL PROTECTED] The servlet should be mapped as /* (to override Jasper and all the others), and the welcome file list should be empty, right ? Yes. Note an empty welcome file list needs to be included to override the default defined in conf/web.xml Maybe

RE: WebDAV and TC5

2004-02-01 Thread Mark Thomas
Remy Maucherat wrote: Mark Thomas wrote: Personally I prefer a working example with appropriate comments. It also saves me copying it from TC4 all the time ;) Cool. I think we need docs too (grin) :D (I know, I'm being mean) Fair point though. I'll put it on my list of things to do

[PROPOSED PATCH] Bugs 13833 and 14228

2004-02-11 Thread Mark Thomas
All, The patch below fixes (I believe) the following bugs: http://nagoya.apache.org/bugzilla/show_bug.cgi?id=13833 http://nagoya.apache.org/bugzilla/show_bug.cgi?id=14228 I am not 100% confident about this patch and would therefore appreciate some feedback before I commit it. The reasoning

RE: cvs commit: jakarta-tomcat-connectors/procrun/bin tomcat.exe tomcatw.exe

2004-02-13 Thread Mark Thomas
I'll look at this now... Mark From: Remy Maucherat [mailto:[EMAIL PROTECTED] So I'll wait a bit, see if Mark comments on bug 26906 (I think it's invalid: the fix seems to imply the URL sent by the client is always invalid), and then I'll put the 5.0.19 tag (and then someone will

RE: cvs commit: jakarta-tomcat-connectors/procrun/bin tomcat.exe tomcatw.exe

2004-02-13 Thread Mark Thomas
Fixed. (with an alternative patch) From: Mark Thomas [mailto:[EMAIL PROTECTED] I'll look at this now... Mark From: Remy Maucherat [mailto:[EMAIL PROTECTED] So I'll wait a bit, see if Mark comments on bug 26906 (I think it's invalid: the fix seems to imply the URL sent

RE: [5.0.19] webdav

2004-02-18 Thread Mark Thomas
The change was as a result of bug 22108. The example web app was trying to do two things: - be an 'normal' web app with an index page - be an example of a working webdav directory Essentially, there isn't a configuration for servlet mapping that enables both of the above to work reliably

RE: cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/loader WebappClassLoader.java

2004-02-22 Thread Mark Thomas
I would be grateful if someone more knowledgeable than I in the area of class loaders reviewed the URL encoding part of this patch. Thanks, Mark -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] Sent: Sunday, February 22, 2004 9:04 PM To: [EMAIL PROTECTED]

RE: allowTrace attribute causing problems inthe adminapplication

2004-02-27 Thread Mark Thomas
Just rebuilt Tomcat 4 from CVS, followed your steps and I do not see this problem. (Win XP, JDK1.4.2_03). -Original Message- From: Jeff Tulley [mailto:[EMAIL PROTECTED] Sent: Friday, February 27, 2004 10:44 PM To: [EMAIL PROTECTED] Subject: Re: allowTrace attribute causing problems

  1   2   3   >