Re: Good practice for disabling/ignoring failing test cases

2008-06-12 Thread Raymond Feng
, June 11, 2008 10:26 PM To: tuscany-dev@ws.apache.org Subject: Re: Good practice for disabling/ignoring failing test cases Since the vtest script assumes a test comment structure around specification line numbers, I created a new script specific to this purpose and added it to /java/etc. It scans

Re: Good practice for disabling/ignoring failing test cases

2008-06-12 Thread Vamsavardhana Reddy
:-). For example, // @Ignore // @Ignore(TUSCANY-2349) Thanks, Raymond -- From: Kevin Williams [EMAIL PROTECTED] Sent: Wednesday, June 11, 2008 10:26 PM To: tuscany-dev@ws.apache.org Subject: Re: Good practice for disabling/ignoring

Re: Good practice for disabling/ignoring failing test cases

2008-06-12 Thread Dan Becker
On Wed, Jun 11, 2008 at 11:02 PM, Raymond Feng [EMAIL PROTECTED] wrote: I see Vamsi uses the following strategy to disable failing unit test cases. @Test @Ignore(TUSCANY-) // Ignore the test case due to JIRA TUSCANY- public void testMySrtuff() { } +1 Very good practice. It documents

Re: Good practice for disabling/ignoring failing test cases

2008-06-12 Thread Mike Edwards
Raymond Feng wrote: Hi, I see Vamsi uses the following strategy to disable failing unit test cases. @Test @Ignore(TUSCANY-) // Ignore the test case due to JIRA TUSCANY- public void testMySrtuff() { } I think it's a very good practice we should follow to maintain a clean build while

Re: Good practice for disabling/ignoring failing test cases

2008-06-11 Thread Vamsavardhana Reddy
Thanks Raymond for pointing this out. We never used this strategy in Geronimo (infact, I have never put any JIRA number in any of the source files other that Release Notes may be). I have come across this in Tuscany source code and have been following it consistently from then on. Should give

Re: Good practice for disabling/ignoring failing test cases

2008-06-11 Thread Simon Laws
On Wed, Jun 11, 2008 at 6:43 PM, Vamsavardhana Reddy [EMAIL PROTECTED] wrote: Thanks Raymond for pointing this out. We never used this strategy in Geronimo (infact, I have never put any JIRA number in any of the source files other that Release Notes may be). I have come across this in

Re: Good practice for disabling/ignoring failing test cases

2008-06-11 Thread Kevin Williams
The vtest contributors get credit for this pattern! :-) We also have a Ruby script that scans the test source and, among other things, lists ignored tests and the associated blocking Jiras. On Wed, Jun 11, 2008 at 11:49 AM, Simon Laws [EMAIL PROTECTED] wrote: On Wed, Jun 11, 2008 at 6:43 PM,

Re: Good practice for disabling/ignoring failing test cases

2008-06-11 Thread Luciano Resende
+1 for using this pattern to disable/ignore tests that are failing. How about also running the script in an automated fashion and sending an e-mail to the list with the results ? What would be a good interval for running the script ? On Wed, Jun 11, 2008 at 1:03 PM, Kevin Williams [EMAIL

Re: Good practice for disabling/ignoring failing test cases

2008-06-11 Thread Raymond Feng
: Good practice for disabling/ignoring failing test cases +1 for using this pattern to disable/ignore tests that are failing. How about also running the script in an automated fashion and sending an e-mail to the list with the results ? What would be a good interval for running the script ? On Wed

Re: Good practice for disabling/ignoring failing test cases

2008-06-11 Thread Jean-Sebastien Delfino
Simon Laws wrote: On Wed, Jun 11, 2008 at 6:43 PM, Vamsavardhana Reddy [EMAIL PROTECTED] wrote: Thanks Raymond for pointing this out. We never used this strategy in Geronimo (infact, I have never put any JIRA number in any of the source files other that Release Notes may be). I have come

Re: Good practice for disabling/ignoring failing test cases

2008-06-11 Thread Kevin Williams
Since the vtest script assumes a test comment structure around specification line numbers, I created a new script specific to this purpose and added it to /java/etc. It scans for files named *testCase.java and collects methods annotated with @Ignore. I could use some help getting this automated