On Thu, Jan 22, 2015 at 1:56 PM, Darin Adler da...@apple.com wrote:
On Jan 22, 2015, at 12:58 PM, Dirk Pranke dpra...@chromium.org wrote:
Of course, Chromium was more willing to incur the cost of keeping all of
the pixel tests up to date when trivial things changed the output
iOS was the only one I was aware of that was left.
-- Dirk
On Mon, Jul 28, 2014 at 12:25 PM, David Farler dfar...@apple.com wrote:
Hi,
Are there any ports or users of old-run-webkit-tests left besides the iOS
Simulator? I'm on the verge of completing iOS Simulator support for
webkitpy and
On Sun, Mar 23, 2014 at 12:52 PM, Benjamin Poulain benja...@webkit.orgwrote:
Same here :(
On 3/23/14, 12:15 PM, Darin Adler wrote:
When I use run-webkit-tests to run the entire test suite, on a debug
build of TOT WebKit, on Mavericks, I’m having the following problems:
- Towards the end
On Mon, Mar 24, 2014 at 3:32 PM, Bem Jones-Bey bjone...@adobe.com wrote:
On Mar 24, 2014, at 14:54 , Dirk Pranke dpra...@chromium.org wrote:
On Sun, Mar 23, 2014 at 12:52 PM, Benjamin Poulain benja...@webkit.orgwrote:
Same here :(
On 3/23/14, 12:15 PM, Darin Adler wrote:
When I use
Ryosuke and I discussed this a bit over IRC. Ryosuke's main concern was
that supporting multiple document roots adds a fair amount of complexity to
NRWT. Conceptually, it's probably easier to add support to run the W3C's
new server (known as wptserve) and then maybe use it for *all* imported
tests
The way I got around this when I was first working on it was to simply map
imported/w3c onto a subdirectory of the document root in apache; it's a two
line change.
For some time I've toyed with the idea of changing the DocumentRoot to just
be LayoutTests/, so that any test could be run over http
On Wed, Dec 4, 2013 at 11:19 AM, Darin Adler da...@apple.com wrote:
On Dec 4, 2013, at 6:48 AM, youenn fablet youe...@gmail.com wrote:
I am planning to add some XHR tests from
https://github.com/w3c/web-platform-tests.
My initial plan was to add them in a subdirectory of
On Fri, Aug 30, 2013 at 10:06 AM, Oliver Hunt oli...@apple.com wrote:
On Aug 30, 2013, at 9:15 AM, Brendan Long s...@brendanlong.com wrote:
On 08/29/2013 05:45 PM, Benjamin Poulain wrote:
Can you explain a bit what it is for? What are the common use cases?
This would be useful for
On Fri, Aug 30, 2013 at 3:48 PM, Oliver Hunt oli...@apple.com wrote:
On Aug 30, 2013, at 12:44 PM, Dirk Pranke dpra...@chromium.org wrote:
On Fri, Aug 30, 2013 at 10:06 AM, Oliver Hunt oli...@apple.com wrote:
On Aug 30, 2013, at 9:15 AM, Brendan Long s...@brendanlong.com wrote:
On 08/29
I may be missing context, or just slow, but how does that link illustrate
things being harmful ? It looks like you're mostly adding the bug numbers
inline and/or taking skipped tests and making them flaky ?
-- Dirk
On Wed, May 22, 2013 at 6:11 PM, Ryosuke Niwa rn...@webkit.org wrote:
And
It seems like you could get nearly both things if you just had people list
both their @webkit.org and @company.com addresses (or at least a company
affiliation, if not an actual address) in committers.py, right?
-- Dirk
On Mon, Apr 29, 2013 at 10:26 AM, Brian Weinstein bweinst...@apple.comwrote:
On Wed, Apr 24, 2013 at 10:30 AM, L. David Baron dba...@dbaron.org wrote:
On Wednesday 2013-04-24 09:55 -0700, Darin Adler wrote:
On Apr 23, 2013, at 11:36 AM, Benjamin Poulain benja...@webkit.org
wrote:
The current mode works fine for some ref-tests but is really annoying
for others. I
On Wed, Apr 24, 2013 at 3:29 PM, Elliott Sprehn espr...@chromium.orgwrote:
On Wed, Apr 24, 2013 at 11:11 AM, Dirk Pranke dpra...@chromium.orgwrote:
...
I think this raises two related questions, both of which would be helped
by concrete examples:
1) What sort of test are you writing
On Wed, Apr 24, 2013 at 3:35 PM, Elliott Sprehn espr...@chromium.orgwrote:
On Wed, Apr 24, 2013 at 3:31 PM, Dirk Pranke dpra...@chromium.org wrote:
On Wed, Apr 24, 2013 at 3:29 PM, Elliott Sprehn espr...@chromium.orgwrote:
On Wed, Apr 24, 2013 at 11:11 AM, Dirk Pranke dpra
On Wed, Apr 24, 2013 at 3:49 PM, Darin Adler da...@apple.com wrote:
On Apr 24, 2013, at 3:45 PM, Dirk Pranke dpra...@chromium.org wrote:
in the absence of tests that *need* bigger viewports, I'd side w/ David
and say that we should fix tests to fit within 800x600 so that they are
portable
On Wed, Apr 24, 2013 at 4:00 PM, Darin Adler da...@apple.com wrote:
On Apr 24, 2013, at 3:52 PM, Dirk Pranke dpra...@chromium.org wrote:
You mean it's easy to write a test that is bigger than 800x600, and
perhaps we should generate some sort of warning for this?
It’s easy to write a test
On Tue, Apr 16, 2013 at 3:58 PM, Brent Fulgham bfulg...@gmail.com wrote:
Hi Daniel,
I'm afraid I don't quite understand the nature of the change you are
proposing:
1. Is it sufficient to supply the full path to the include files (e.g.,
change Foo.h to WebCore/html/Foo.h) to achieve these
Hi all,
Those of you who are subscribed to blink-dev@ will see that I just sent out
a note entitled Blink, Testing and the W3C, describing stuff I'm working
on to get the W3C tests running regularly as part of the layout tests. The
W3C has gotten to the point where they have many thousands of ref
On Fri, Apr 12, 2013 at 10:44 PM, Filip Pizlo fpi...@apple.com wrote:
On Apr 12, 2013, at 10:43 PM, Ryosuke Niwa rn...@webkit.org wrote:
Perhaps we can come up with some JS API for shared memory lock and
propose it in TC39 or WebApps WG?
I think that would be wonderful. Anyone else
On Fri, Apr 12, 2013 at 1:50 PM, Filip Pizlo fpi...@apple.com wrote:
I'm curious: would you want to use ParallelArray, if you had the
flexibility of building a different abstraction?
I find ParallelArray to be an awkward abstraction to begin with. I like
work queues and such. The whole
On Thu, Apr 11, 2013 at 9:51 AM, Darin Adler da...@apple.com wrote:
On Apr 11, 2013, at 5:02 AM, Thiago Marcos P. Santos tmpsan...@gmail.com
wrote:
Would be great if both projects could share the same generators.
The part that would be OK to share would be the parsing.
The actual code
On Thu, Apr 11, 2013 at 10:29 AM, Leandro Pereira lean...@profusion.mobiwrote:
dpranke,
On 04/11/2013 02:12 PM, Dirk Pranke wrote:
I'm not sure how useful a suggestion this is, but ANTLR has a pretty
strong framework for separating parsing from code generation and seems
like it would
On Wed, Apr 10, 2013 at 1:17 PM, Filip Pizlo fpi...@apple.com wrote:
I.e. if you believe that (A) is not a solvable problem, then this
constitutes an argument against ParallelArrays, and not against inferring
that a normal array should behave like a ParallelArray.
I believe that there are a
On Wed, Apr 10, 2013 at 7:37 AM, Filip Pizlo fpi...@apple.com wrote:
On Apr 10, 2013, at 2:29 AM, Pozdnyakov, Mikhail
mikhail.pozdnya...@intel.com wrote:
Why not infer ParallelArrays automatically?
Sorry, did not get it. Could you please elaborate?
Normal JS arrays. You use them
.
--Oliver
On Apr 10, 2013, at 12:37 PM, Dirk Pranke dpra...@chromium.org wrote:
On Wed, Apr 10, 2013 at 7:37 AM, Filip Pizlo fpi...@apple.com wrote:
On Apr 10, 2013, at 2:29 AM, Pozdnyakov, Mikhail
mikhail.pozdnya...@intel.com wrote:
Why not infer ParallelArrays automatically
...
Understand that the parallel APIs have to do all of this as well, the only
thing they lose is the is everything a number check
--Oliver
On Apr 10, 2013, at 12:50 PM, Dirk Pranke dpra...@chromium.org wrote:
Right, I get how ParallelArrays would work. I was asking Filip how you
might infer
On Wed, Apr 10, 2013 at 4:59 PM, Timothy Hatcher timo...@apple.com wrote:
On Apr 10, 2013, at 6:32 PM, Ryosuke Niwa rn...@webkit.org wrote:
Can we rewrite CodeGenerator*.pm in Ruby or Python? I feel that the
current code is very hard to understand and hack on. In particular we have
TestFailures, as I understand it, provides a summarize view of current tree
failures clustered by the changes that might have caused the failures, kind
of like garden-o-matic's initial page.
I believe I broke it at one point accidentally, asked if anyone used it,
and Ossy said that he did (there
On Thu, Apr 4, 2013 at 12:30 AM, Geoffrey Garen gga...@apple.com wrote:
Hi folks.
Since we no longer need to support the Chromium port, let's take the
opportunity to streamline. Hopefully, this will make development easier and
more coherent for everyone. Adam and Eric offered to do some of
On Thu, Apr 4, 2013 at 12:50 PM, Geoffrey Garen gga...@apple.com wrote:
To clarify:
(1) The EWS bots are still running.
(2) The mac and mac-wk2 EWS bots are running tests, and passing.
(3) The cr-linux bots are running tests, and failing.
If we're OK with item (3), we can go ahead with
On Tue, Mar 26, 2013 at 11:47 AM, Ryosuke Niwa rn...@webkit.org wrote:
On Tue, Mar 26, 2013 at 11:42 AM, Jarred Nicholls jar...@webkit.orgwrote:
On Tue, Mar 26, 2013 at 2:37 PM, Ryosuke Niwa rn...@webkit.org wrote:
On Tue, Mar 26, 2013 at 11:21 AM, Daniel Bratell brat...@opera.comwrote:
Is
On Tue, Mar 26, 2013 at 1:29 PM, Benjamin Poulain benja...@webkit.orgwrote:
On Tue, Mar 26, 2013 at 1:20 PM, Dirk Pranke dpra...@chromium.org wrote
If we have consensus that we should just switch to paths relative to
Source (or maybe a couple different options), that would be (IMO) a big
win
On Tue, Mar 26, 2013 at 1:42 PM, Alexis Menard ale...@webkit.org wrote:
On Tue, Mar 26, 2013 at 5:40 PM, Dirk Pranke dpra...@chromium.org wrote:
On Tue, Mar 26, 2013 at 1:29 PM, Benjamin Poulain benja...@webkit.org
wrote:
On Tue, Mar 26, 2013 at 1:20 PM, Dirk Pranke dpra...@chromium.org
On Thu, Mar 7, 2013 at 8:46 AM, Rebecca Hauck rha...@adobe.com wrote:
Hi Dirk Everyone,
Dirk, your question about this in IRC the other day was timely indeed.
I've recently written a batch of tests for CSS Regions that I intend to
submit to both the W3C and Webkit (and have planned more to
On Thu, Mar 7, 2013 at 3:04 PM, Tony Gentilcore to...@chromium.org wrote:
I also got a little inspiration from the
import-w3c-performance-wg-tests that already exists. I followed a few of
their steps, but had to add a few layers to handle the added complexity of
the CSS test suites.
Is there
On Tue, Feb 26, 2013 at 1:03 PM, Ryosuke Niwa rn...@webkit.org wrote:
On Tue, Feb 26, 2013 at 12:47 PM, Dirk Pranke dpra...@chromium.org wrote:
On Tue, Feb 26, 2013 at 2:11 AM, Ryosuke Niwa rn...@webkit.org wrote:
On Tue, Feb 26, 2013 at 1:55 AM, Tom Hudson tomhud...@google.com
wrote
On Mon, Feb 25, 2013 at 12:38 PM, Eric Seidel esei...@google.com wrote:
I've noticed as of late several different approaches being used when
adding/changing LayoutTests which need rebaselining on other platforms.
Obviously we cannot expect developers to test/rebaseline on all platforms
before
On Mon, Feb 25, 2013 at 1:22 PM, Ryosuke Niwa rn...@webkit.org wrote:
On Mon, Feb 25, 2013 at 12:52 PM, Dirk Pranke dpra...@google.com wrote:
On Mon, Feb 25, 2013 at 12:38 PM, Eric Seidel esei...@google.com wrote:
I've noticed as of late several different approaches being used when
adding
On Mon, Feb 25, 2013 at 1:33 PM, Ryosuke Niwa rn...@webkit.org wrote:
On Mon, Feb 25, 2013 at 1:29 PM, Dirk Pranke dpra...@google.com wrote:
On Mon, Feb 25, 2013 at 1:22 PM, Ryosuke Niwa rn...@webkit.org wrote:
On Mon, Feb 25, 2013 at 12:52 PM, Dirk Pranke dpra...@google.com
wrote:
I
Hi Jason,
On http://trac.webkit.org/wiki there are a bunch of pages under
Layout Tests and Performance Tests that describe much of the
infrastructure. These days most of it is written in Python.
I don't know what projects Benjamin has in mind so I don't know if
that will match what he was
On Wed, Feb 13, 2013 at 11:33 PM, Benjamin Poulain benja...@webkit.org wrote:
On Wed, Feb 13, 2013 at 11:16 PM, Dirk Pranke dpra...@chromium.org wrote:
Those changes are not harmless. There are people monitoring tests
results
full time in order to keep WebKit in good shape. No other part
On Mon, Feb 11, 2013 at 7:44 PM, Benjamin Poulain benja...@webkit.org wrote:
I am sorry, I should have given more context.
There is visibly a growing discontent in the community about the cost
imposed from small ports. Just two weeks ago, there were 2 threads
discussing the cost of
On Mon, Feb 11, 2013 at 1:41 PM, Kevin Ollivier kev...@theolliviers.com wrote:
Hi Martin,
On Feb 11, 2013, at 12:47 PM, Martin Robinson wrote:
On Mon, Feb 11, 2013 at 11:27 AM, Kevin Ollivier
kev...@theolliviers.com wrote:
The project is not dead per-se, but it's true that it's not very
On Mon, Feb 11, 2013 at 3:26 PM, Kevin Ollivier kev...@theolliviers.com wrote:
On Feb 11, 2013, at 2:01 PM, Martin Robinson wrote:
On Mon, Feb 11, 2013 at 1:41 PM, Kevin Ollivier kev...@theolliviers.com
wrote:
Actually, it will, if anything, increase the workload. Because I use waf, I
am
On Mon, Feb 11, 2013 at 4:30 PM, Kevin Ollivier kev...@theolliviers.com wrote:
On Feb 11, 2013, at 3:33 PM, Dirk Pranke wrote:
On Mon, Feb 11, 2013 at 3:26 PM, Kevin Ollivier kev...@theolliviers.com
wrote:
On Feb 11, 2013, at 2:01 PM, Martin Robinson wrote:
On Mon, Feb 11, 2013 at 1:41
On Sat, Feb 9, 2013 at 1:57 AM, Benjamin Poulain benja...@webkit.org wrote:
On Sat, Feb 9, 2013 at 1:24 AM, noam.rosent...@nokia.com wrote:
I did not say they cannot be tested with the two methods suggested :) It's
more about a preference to move some of those decisions from the test
On Fri, Feb 8, 2013 at 11:12 AM, Ryosuke Niwa rn...@webkit.org wrote:
On Fri, Feb 8, 2013 at 5:35 AM, noam.rosent...@nokia.com wrote:
we don't currently have a solution in webkit's test infrastructure for
testing animations on the fly, or in general for testing multiple image
results in the
On Tue, Feb 5, 2013 at 9:46 AM, Martin Robinson mrobin...@webkit.org wrote:
On Tue, Feb 5, 2013 at 9:28 AM, Adam Barth aba...@webkit.org wrote:
Do you know how they got rid of flakiness in their tests? We've spent
a bunch of effort fixing flaky tests (and in marking the remaining
flaky tests
I have looked at YAML off and on over the years, and I'm not sure that
it would be much of an improvement in this case.
I do believe that dropping the strict python syntax could make some
things easier to read. I don't have a fully-baked proposal in mind,
and I don't know what the perf hit would
On Tue, Feb 5, 2013 at 3:34 PM, Tim Ansell mit...@mithis.com wrote:
On 6 February 2013 07:17, Dirk Pranke dpra...@chromium.org wrote:
On Tue, Feb 5, 2013 at 9:46 AM, Martin Robinson mrobin...@webkit.org
wrote:
On Tue, Feb 5, 2013 at 9:28 AM, Adam Barth aba...@webkit.org wrote:
Do you know
On Sun, Feb 3, 2013 at 9:20 PM, Maciej Stachowiak m...@apple.com wrote:
On Feb 3, 2013, at 8:18 PM, Mike Lawther mikelawt...@chromium.org wrote:
Hi Maciej!
On 31 January 2013 11:15, Maciej Stachowiak m...@apple.com wrote:
It's far simplest for us if:
(a) There is an Xcode project (or a
The short answer is, you can't.
The fastest path is probably to get a working set of gyp files for the
apple mac wk2. I'm going to start working on this just to see how far
of we are (Adam's work from a year or two ago had JSC and WebCore
building, but wasn't too functional beyond that; even so,
On Thu, Jan 31, 2013 at 11:48 AM, Hugo Parente Lima
hugo.l...@openbossa.org wrote:
On Wednesday, January 30, 2013 04:15:48 PM Maciej Stachowiak wrote:
On Jan 30, 2013, at 3:24 PM, Dirk Pranke dpra...@chromium.org wrote:
On Wed, Jan 30, 2013 at 1:50 PM, Filip Pizlo fpi...@apple.com wrote
On Thu, Jan 31, 2013 at 12:10 PM, Patrick Gansterer par...@paroga.com wrote:
Am 31.01.2013 um 21:07 schrieb Dirk Pranke:
On Thu, Jan 31, 2013 at 11:48 AM, Hugo Parente Lima
hugo.l...@openbossa.org wrote:
On Wednesday, January 30, 2013 04:15:48 PM Maciej Stachowiak wrote:
On Jan 30, 2013
On Thu, Jan 31, 2013 at 9:14 AM, Patrick Gansterer par...@paroga.com wrote:
Am 31.01.2013 um 17:17 schrieb Maciej Stachowiak:
On Jan 31, 2013, at 1:56 AM, Patrick Gansterer par...@paroga.com wrote:
Am 31.01.2013 um 10:37 schrieb Ryosuke Niwa:
On Thu, Jan 31, 2013 at 1:17 AM, Jochen
On Thu, Jan 31, 2013 at 9:48 AM, Ryosuke Niwa rn...@webkit.org wrote:
On Thu, Jan 31, 2013 at 9:43 AM, Alexey Proskuryakov a...@apple.com wrote:
31.01.2013, в 0:17, Ryosuke Niwa rn...@webkit.org написал(а):
I did it for WTF and JSC with kevino@.
https://bugs.webkit.org/show_bug.cgi?id=72855
On Thu, Jan 31, 2013 at 2:52 PM, Alexey Proskuryakov a...@apple.com wrote:
31.01.2013, в 14:45, Dirk Pranke dpra...@chromium.org написал(а):
One thing to keep an eye on with WEBCORE_EXPORT is that it can increase
the number of exports for each port, because it would export symbols
On Thu, Jan 31, 2013 at 3:12 PM, Alexey Proskuryakov a...@webkit.org wrote:
31.01.2013, в 14:57, Dirk Pranke dpra...@chromium.org написал(а):
One thing to keep an eye on with WEBCORE_EXPORT is that it can increase
the number of exports for each port, because it would export symbols
On Wed, Jan 30, 2013 at 1:50 PM, Filip Pizlo fpi...@apple.com wrote:
Thanks for sharing this.
On Jan 30, 2013, at 1:28 PM, Eric Seidel e...@webkit.org wrote:
I wish we only had one build system (it were easy to add/remove/move files).
I believe changes like
This is the output of the test bots, right? I'm guessing this is due
to (a) us running pixel tests and (b) not checking in the expected
failing baselines. If I ever get back to working on supporting
-failing.png, this could go down *a lot*.
Alternatively, we could just decide to check in the
The build cop / gardener / sheriff / whatever may not have local or
easy access to a bot that reproduces the problem ... rolling it out
might be the only feasible way to test in that case.
On Tue, Dec 11, 2012 at 2:20 PM, Oliver Hunt oli...@apple.com wrote:
On Dec 11, 2012, at 2:17 PM, Peter
On Mon, Dec 10, 2012 at 1:30 AM, Jochen Eisinger joc...@chromium.org wrote:
Will the buildbots use ninja or the native build tools?
My only concern is that we're catching problems with e.g. MSVS only after we
roll the WebKit deps in chromium and one of the MSVS bots starts failing.
Eric is
On Fri, Nov 16, 2012 at 7:42 AM, Julien Chaffraix
julien.chaffr...@gmail.com wrote:
Seconded. I also think only the one who submitted the patch can clear
the r? flag. Others should NOT do that, please, even you are a
reviewer. You can r- the patch if you believe it is bad.
I disagree with
Argh, yeah. Unfortunately, I'm not sure what triggers this problem.
It's easy enough to fix as soon as I can find someone w/ access to the
CQ.
-- Dirk
On Tue, Nov 13, 2012 at 7:50 AM, Adam Barth aba...@webkit.org wrote:
Sounds related to a recent changed made by dpranke.
Adam
On Tue, Nov
We don't currently support port-specific reftests (or at least, not
very well), and we certainly should be trying to minimize where they
occur. Perhaps we should discuss why you need them (in a separate
thread with a separate subject line)? It sounds like this largely has
to do with what features
On Tue, Nov 13, 2012 at 11:29 AM, Glenn Adams gl...@skynav.com wrote:
On Tue, Nov 13, 2012 at 12:09 PM, Dirk Pranke dpra...@chromium.org wrote:
We don't currently support port-specific reftests (or at least, not
very well), and we certainly should be trying to minimize where they
occur
Hi all,
I occasionally get asked if the TestExpectations syntax supports a way
to distinguish different results for WebKit1 and WebKit2 via keywords.
We currently don't do this, and different ports have worked around
this in slightly different ways by using dedicated wk2-specific
TestExpectations
On Tue, Nov 13, 2012 at 12:02 PM, Tony Chang t...@chromium.org wrote:
On Tue, Nov 13, 2012 at 11:35 AM, Dirk Pranke dpra...@chromium.org wrote:
On Tue, Nov 13, 2012 at 11:29 AM, Glenn Adams gl...@skynav.com wrote:
On Tue, Nov 13, 2012 at 12:09 PM, Dirk Pranke dpra...@chromium.org
wrote
On Tue, Nov 13, 2012 at 12:29 PM, Dirk Pranke dpra...@chromium.org wrote:
On Tue, Nov 13, 2012 at 12:13 PM, Darin Adler da...@apple.com wrote:
I’d prefer an directory-based overlay/inheritance approach to sharing
WebKit1- vs. WebKit2-specific expectations over in-file keywords. I’d like
Hi all,
Currently, we have ~8000 pixel tests in the tree, and ~800 reference
tests. I would like to make that first number a lot smaller.
It turns out that we have a reasonably large number of tests that
produce the exact same pixel results. On chromium-mac on 10.8, for
example, there are 2048
On Tue, Nov 13, 2012 at 4:33 PM, Darin Adler da...@apple.com wrote:
On Nov 13, 2012, at 4:01 PM, Dirk Pranke dpra...@chromium.org wrote:
It turns out that we have a reasonably large number of tests that produce
the exact same pixel results. On chromium-mac on 10.8, for example
On Tue, Nov 13, 2012 at 4:59 PM, Darin Adler da...@apple.com wrote:
On Nov 13, 2012, at 4:56 PM, Dirk Pranke dpra...@chromium.org wrote:
Wouldn't the fact that there are a large set of tests with the same result
be an argument *for* doing the iframe thing?
The simple hand-coded green square
On Tue, Nov 13, 2012 at 5:06 PM, Eric Seidel e...@webkit.org wrote:
!DOCTYPE html
body style=margin: 0px
div style=height: 100px; width: 100px; background-color: green
Does seem pretty simple.
!DOCTYPE html
body style=margin: 0px
svgrect width=100px height=100px fill=greensvg
is even
http://build.webkit.org/TestFailures/
I think Adam Roben was working on this a year or so ago. It appears to
be broken at the moment (it's likely that I broke it, in fact), but
before I spend much time fixing it I thought I'd check.
I've never actually used it myself, so I'm not sure what all it
/TestFailures/ we use a very old copy
of test failures and it still works fine.
Dirk Pranke írta:
http://build.webkit.org/TestFailures/
I think Adam Roben was working on this a year or so ago. It appears to
be broken at the moment (it's likely that I broke it, in fact), but
before I spend much time
It is/was intended to be useful for quickly reviewing and rebaselining
a bunch of failures in a local (on-disk) checkout. It's been largely
unmaintained and ignored for quite some time in favor of
garden-o-matic.
I have recently started to land some patches that will make
garden-o-matic work
On Mon, Oct 29, 2012 at 5:48 AM, Maciej Stachowiak m...@apple.com wrote:
On Oct 28, 2012, at 10:09 PM, Dirk Pranke dpra...@chromium.org wrote:
On Sun, Oct 28, 2012 at 6:32 AM, Maciej Stachowiak m...@apple.com wrote:
I think the nature of loader and cache code is that it's very hard to make
On Oct 26, 2012, at 11:11 PM, Ryosuke Niwa rn...@webkit.org wrote:
I’m sure Antti, Alexey, and others who have worked on the loader and other
parts of WebKit are happy to write those tests or list the kind of things
they want to test. Heck, I don’t mind writing those tests if someone could
On Sun, Oct 28, 2012 at 2:47 PM, Ryosuke Niwa rn...@webkit.org wrote:
On Sun, Oct 28, 2012 at 2:09 PM, Dirk Pranke dpra...@chromium.org wrote:
On Oct 26, 2012, at 11:11 PM, Ryosuke Niwa rn...@webkit.org wrote:
I’m sure Antti, Alexey, and others who have worked on the loader and
other parts
(clear caches
between tests) for the mac and/or gtk ports' DRTs?
On Wed, Aug 8, 2012 at 2:35 PM, Dirk Pranke dpra...@chromium.org wrote:
On Wed, Aug 8, 2012 at 10:47 AM, Ojan Vafai o...@chromium.org wrote:
See https://bugs.webkit.org/show_bug.cgi?id=93195.
media/W3C/video/networkState
On Fri, Oct 26, 2012 at 11:38 AM, Ryosuke Niwa rn...@webkit.org wrote:
On Fri, Oct 26, 2012 at 11:33 AM, Elliott Sprehn espr...@chromium.org
wrote:
On Fri, Oct 26, 2012 at 11:17 AM, Ryosuke Niwa rn...@webkit.org wrote:
...
I agree this is a good change but it appears that we should add
I think there is some general interest in a feature like this.
I need to sync up w/ Adam and Eric and figure out what all might be
required here, so we might do this but I can't say for sure yet ...
-- Dirk
On Wed, Oct 24, 2012 at 8:40 AM, Adam Barth aba...@webkit.org wrote:
I don't have any
suspect that the zip size from the bots has just
ballooned above that cut-off and fixing LayoutTestResults to only
include the relevant files would probably make the EWSes start
uploading results.zip files again. :)
On Wed, Oct 24, 2012 at 12:33 PM, Dirk Pranke dpra...@chromium.org wrote:
I think
On Sun, Oct 21, 2012 at 2:17 PM, Maciej Stachowiak m...@apple.com wrote:
Apple did not ship the last release of Safari to SnowLeopard and we have no
plans to maintain SnowLeopard support on trunk. We haven't actively ripped
out SL-specific ifdefs because we were under the impression that the
?? :)
https://docs.google.com/drawings/d/1z65SKkWrD4Slm6jobIphHwwRADyUtjOAxwGBVKBY8Kc/edit
On Wed, Oct 17, 2012 at 8:15 PM, Dirk Pranke dpra...@chromium.org wrote:
All of the Chromium ports will use baselines in their port-specific
directories, then fall back through various paths to platform
All of the Chromium ports will use baselines in their port-specific
directories, then fall back through various paths to platform/chromium
and then to next to the test.
Which means you Apple folks can feel free to break things in
platform/mac to your hearts' content :).
Let me know if you see
Hi all,
You can largely ignore this if you never modify Chromium baselines or
TestExpectations. But if you do modify them ...
I'm working on getting our new 10.8/MountainLion bot green. It looks
like Apple changed their text rendering a bit in the latest release
and so we need lots more
Makes sense to me ...
On Thu, Oct 4, 2012 at 2:46 PM, Ojan Vafai o...@chromium.org wrote:
TL;DR: We should add a NeedsRebaseline keyword to TestExpectations and add
garden-o-matic tooling for it for the cases where someone commits a
change/test that they know will need new results for
Think Eric and Alexey identified the problem here ...
-- Dirk
On Wed, Oct 3, 2012 at 9:44 AM, Alexey Proskuryakov a...@webkit.org wrote:
03.10.2012, в 9:19, Eric Seidel e...@webkit.org написал(а):
Perhaps make is missing? or the java directory its trying to build is
missing and it's just
On Wed, Oct 3, 2012 at 3:39 PM, Darin Adler da...@apple.com wrote:
On Oct 3, 2012, at 9:10 AM, Ryosuke Niwa rn...@webkit.org wrote:
Could you tell us what your directory structure look like and where you're
executing that command? Looks like a path confusion.
My WebKit source tree is in
On Wed, Oct 3, 2012 at 4:18 PM, Dirk Pranke dpra...@chromium.org wrote:
On Wed, Oct 3, 2012 at 3:39 PM, Darin Adler da...@apple.com wrote:
On Oct 3, 2012, at 9:10 AM, Ryosuke Niwa rn...@webkit.org wrote:
Could you tell us what your directory structure look like and where you're
executing
Last call on this ... I will be removing the files later today unless
something goes awry :).
-- Dirk
On Fri, Sep 21, 2012 at 3:41 PM, Dirk Pranke dpra...@chromium.org wrote:
Hi all,
Now that we're on the new TestExpectations syntax, I'm planning to
remove the Skipped files (and support
Now landed in http://trac.webkit.org/changeset/129788 . Let me know if
there are any problems.
-- Dirk
On Thu, Sep 27, 2012 at 10:15 AM, Dirk Pranke dpra...@chromium.org wrote:
Last call on this ... I will be removing the files later today unless
something goes awry :).
-- Dirk
On Fri, Sep
, but of course I'll be happy
to troubleshoot/answer questions, etc :).
-- Dirk
On Thu, Sep 27, 2012 at 12:24 PM, Dirk Pranke dpra...@chromium.org wrote:
Now landed in http://trac.webkit.org/changeset/129788 . Let me know if
there are any problems.
-- Dirk
On Thu, Sep 27, 2012 at 10:15 AM, Dirk Pranke
On a related note, there is a gradual movement to pass more command
line flags along with each test to DRT during run-webkit-tests (to
toggle between pixel tests and non, change timeout values, etc.), and
being able to ensure we reset the state to the default between each
test is kinda necessary
As of http://trac.webkit.org/changeset/129265 .
(There are still some things to clean up in the code now that the old
syntax is gone, but hardly anyone will care about that).
I am not aware of any open bugs or issues with the new syntax. Speak
now or I'll assume we're all good :).
Cheers,
--
Hi all,
Now that we're on the new TestExpectations syntax, I'm planning to
remove the Skipped files (and support for them from NRWT).
I have a change posted that will add minimal support for the syntax to
old-run-webkit-tests in https://bugs.webkit.org/show_bug.cgi?id=97276
; basically any file
The URL is already optional. However, I would encourage people to
actually create useful bugs rather than not adding comments to the
TestExpectations/Skipped files.
I'm not a big fan of having to look in two different places to figure
out what's broken, and having bugs for things makes it easier
://bugs.webkit.org/show_bug.cgi?id=96845#c9 for details.
Dirk Pranke írta:
These changes are now starting to land ...
as of r129047, TEXT, IMAGE+TEXT, and AUDIO are no longer legal
keywords in the TestExpectations syntax ... you should use FAIL
instead.
I will be landing the support for the new
After some limited amount of thought, I'm inclined to agree with
Ryosuke and Ossy here. If we have tests that don't depend on checking
the metrics, can they just be dumpAsText tests or reftests instead?
I thought the initial motivation for --ignore-metrics was for new
ports to at least confirm
1 - 100 of 344 matches
Mail list logo
