Brady Eidson beid...@apple.com writes:
On Sep 26, 2012, at 2:46 PM, Tony Chang t...@chromium.org wrote:
I suppose we're biased in Mac-land where the mechanism originated,
but the API is simply a single string based API that only had to
be implemented once.
Your comment leads me to
We have a lot of tests that poke internal settings, via testRunner:
testRunner.setFrameFlatteningEnabled(true);
or window.internals:
internals.settings.setPageScaleFactor(0.5, 0, 0);
and some that poke preferences, like:
On Wed, Sep 26, 2012 at 1:44 PM, Simon Fraser simon.fra...@apple.comwrote:
We have a lot of tests that poke internal settings, via testRunner:
testRunner.setFrameFlatteningEnabled(true);
or window.internals:
internals.settings.setPageScaleFactor(0.5, 0, 0);
and some that poke
On Sep 26, 2012, at 1:48 PM, Ryosuke Niwa rn...@webkit.org wrote:
On Wed, Sep 26, 2012 at 1:44 PM, Simon Fraser simon.fra...@apple.com wrote:
First, direct calls on testRunner that just set preferences should be
migrated to internals.settings or testRunner.overridePreference calls, I
On Sep 26, 2012, at 1:44 PM, Simon Fraser simon.fra...@apple.com wrote:
* we should choose between internals.settings or
testRunner.overridePreference if that makes sense.
I've recently been working on a new API and I've discovered that
internals.settings and testRunner.overridePreference go
[re-sent from the proper address]
On Wed, Sep 26, 2012 at 2:00 PM, Adam Barth abarth@nowhere wrote:
On Wed, Sep 26, 2012 at 1:53 PM, Brady Eidson beid...@apple.com wrote:
On Sep 26, 2012, at 1:48 PM, Ryosuke Niwa rn...@webkit.org wrote:
On Wed, Sep 26, 2012 at 1:44 PM, Simon Fraser
I would agree with Adam, and the more we can move to window.internals,
the less technical debt we incur with each new DRT feature.
I would love to see overridePreferences go away (or only be used for
preferences which need to test the WebKit-side plumbing).
TestExpectation files on all ports are
On Sep 26, 2012, at 2:05 PM, Adam Barth aba...@webkit.org wrote:
[re-sent from the proper address]
On Wed, Sep 26, 2012 at 2:00 PM, Adam Barth abarth@nowhere wrote:
On Wed, Sep 26, 2012 at 1:53 PM, Brady Eidson beid...@apple.com wrote:
On Sep 26, 2012, at 1:48 PM, Ryosuke Niwa
On a related note, there is a gradual movement to pass more command
line flags along with each test to DRT during run-webkit-tests (to
toggle between pixel tests and non, change timeout values, etc.), and
being able to ensure we reset the state to the default between each
test is kinda necessary
On Sep 26, 2012, at 2:14 PM, Eric Seidel e...@webkit.org wrote:
TestExpectation files on all ports are full of:
# unskip these tests when we add obscure-drt-feature-x
http://trac.webkit.org/browser/trunk/LayoutTests/platform/wk2/Skipped#L107
On Wed, Sep 26, 2012 at 2:35 PM, Brady Eidson beid...@apple.com wrote:
On Sep 26, 2012, at 2:05 PM, Adam Barth aba...@webkit.org wrote:
[re-sent from the proper address]
On Wed, Sep 26, 2012 at 2:00 PM, Adam Barth abarth@nowhere wrote:
On Wed, Sep 26, 2012 at 1:53 PM, Brady Eidson
On Wed, Sep 26, 2012 at 2:35 PM, Brady Eidson beid...@apple.com wrote:
On Sep 26, 2012, at 2:05 PM, Adam Barth aba...@webkit.org wrote:
[re-sent from the proper address]
On Wed, Sep 26, 2012 at 2:00 PM, Adam Barth abarth@nowhere wrote:
On Wed, Sep 26, 2012 at 1:53 PM, Brady Eidson
On Sep 26, 2012, at 2:46 PM, Tony Chang t...@chromium.org wrote:
On Wed, Sep 26, 2012 at 2:35 PM, Brady Eidson beid...@apple.com wrote:
On Sep 26, 2012, at 2:05 PM, Adam Barth aba...@webkit.org wrote:
[re-sent from the proper address]
On Wed, Sep 26, 2012 at 2:00 PM, Adam Barth
On Sep 26, 2012, at 4:13 PM, Brady Eidson beid...@apple.com wrote:
On Sep 26, 2012, at 2:46 PM, Tony Chang t...@chromium.org wrote:
On Wed, Sep 26, 2012 at 2:35 PM, Brady Eidson beid...@apple.com wrote:
On Sep 26, 2012, at 2:05 PM, Adam Barth aba...@webkit.org wrote:
[re-sent from the
On Sep 26, 2012, at 4:43 PM, Adam Barth aba...@webkit.org wrote:
Maybe a better solution is auto-generate all this boilerplate code? If we
had a Settings.in file, we could generate all the port-specific code (and
maybe even much of Settings.h/cpp) automatically. Then all of these patches
On Wed, Sep 26, 2012 at 4:51 PM, Brady Eidson beid...@apple.com wrote:
On Sep 26, 2012, at 4:43 PM, Adam Barth aba...@webkit.org wrote:
Maybe a better solution is auto-generate all this boilerplate code? If we
had a Settings.in file, we could generate all the port-specific code (and
maybe
16 matches
Mail list logo
