[webkit-dev] ExceptionCode cleanup.

2013-02-11 Thread Mike West
Over the course of a few patches[1], I've refactored exception handling in twoish ways: 1. Call sites which ASSERT that no exception occurred have been replaced with the ASSERT_NO_EXCEPTION macro[2]. 2. A new IGNORE_EXCEPTION macro is now available, intended to make it clear that a method's

Re: [webkit-dev] Can Qt use some of the common DRT code?

2013-02-11 Thread Allan Sandfeld Jensen
On Monday 11 February 2013, Benjamin Poulain wrote: One of the differences is the way the Qt port works. Instead of using the JSC binding APIs, it uses its own JS Qt bindings. Would it be possible for Qt to move to the common code? It would make future refactoring easier as there would be one

[webkit-dev] Chromium's TestRunner library is now a component!

2013-02-11 Thread Jochen Eisinger
Hi, the TestRunner library used by chromium's DumpRenderTree is now a component (i.e. it builds as a DLL on Windows). It defines all the test runner objects such as testRunner or eventSender and is implemented entirely in terms of the public chromium WebKit API (i.e. it has no dependencies on WTF

Re: [webkit-dev] A catalog of iOS-specific changes related to the WebThread

2013-02-11 Thread Darin Fisher
Thanks for the heads up! -Darin On Sun, Feb 10, 2013 at 1:53 PM, Maciej Stachowiak m...@apple.com wrote: Here is a list all iOS-specific changes in WebCore and below that are due to the iOS WebKit threading model, from an exhaustive review of diffs to the downstream source. I'm not sure

Re: [webkit-dev] Is the wxWidgets port maintained?

2013-02-11 Thread Kevin Ollivier
Hi Benjamin, On Feb 10, 2013, at 7:23 PM, Benjamin Poulain wrote: Hi again, While looking into DRT changes, I notice there is zero activity on the wxWidgets implementation. Looking at WebCore/WebKit, excluding general changes, the last commit for wxWidgets is 6 months old:

Re: [webkit-dev] Is the wxWidgets port maintained?

2013-02-11 Thread Benjamin Poulain
On Mon, Feb 11, 2013 at 11:27 AM, Kevin Ollivier kev...@theolliviers.comwrote: I actually have recently been working on a patch to get trunk building again, though. The path of least resistance for me would simply be to ask people to ignore the wx port in their changes, but leave it in the

Re: [webkit-dev] Is the wxWidgets port maintained?

2013-02-11 Thread Martin Robinson
On Mon, Feb 11, 2013 at 11:27 AM, Kevin Ollivier kev...@theolliviers.com wrote: The project is not dead per-se, but it's true that it's not very active these days. Recently, I haven't had a lot of time to devote to the port. The other big factor has been that I've been the only active

Re: [webkit-dev] Is the wxWidgets port maintained?

2013-02-11 Thread Kevin Ollivier
On Feb 11, 2013, at 12:27 PM, Benjamin Poulain wrote: On Mon, Feb 11, 2013 at 11:27 AM, Kevin Ollivier kev...@theolliviers.com wrote: I actually have recently been working on a patch to get trunk building again, though. The path of least resistance for me would simply be to ask people to

Re: [webkit-dev] Is the wxWidgets port maintained?

2013-02-11 Thread Kevin Ollivier
Hi Martin, On Feb 11, 2013, at 12:47 PM, Martin Robinson wrote: On Mon, Feb 11, 2013 at 11:27 AM, Kevin Ollivier kev...@theolliviers.com wrote: The project is not dead per-se, but it's true that it's not very active these days. Recently, I haven't had a lot of time to devote to the port.

Re: [webkit-dev] Is the wxWidgets port maintained?

2013-02-11 Thread Ryosuke Niwa
On Mon, Feb 11, 2013 at 1:34 PM, Kevin Ollivier kev...@theolliviers.comwrote: On Feb 11, 2013, at 12:27 PM, Benjamin Poulain wrote: On Mon, Feb 11, 2013 at 11:27 AM, Kevin Ollivier kev...@theolliviers.comwrote: I actually have recently been working on a patch to get trunk building again,

Re: [webkit-dev] Is the wxWidgets port maintained?

2013-02-11 Thread Ryosuke Niwa
I'll add that now that https://github.com/WebKit/webkit uses the same hashing as git.webkit.org, it'll be trivial for folks wanting to have their own ports to fork on github and maintain svn history. Maybe we should even encourage that for new ports: initially forking WebKit on github to create

Re: [webkit-dev] Is the wxWidgets port maintained?

2013-02-11 Thread Martin Robinson
On Mon, Feb 11, 2013 at 1:41 PM, Kevin Ollivier kev...@theolliviers.com wrote: Actually, it will, if anything, increase the workload. Because I use waf, I am able to use Python to auto-generate the list of sources to build. In other words, I tell it to build all sources in a defined list of

Re: [webkit-dev] Is the wxWidgets port maintained?

2013-02-11 Thread Brent Fulgham
Hi Everyone, On Mon, Feb 11, 2013 at 1:51 PM, Ryosuke Niwa rn...@webkit.org wrote: Asking people to ignore wx is basically the same as having the code outside the tree. Having the code outside the tree would make this change effective instead of having one more rule to the project. My big

Re: [webkit-dev] Is the wxWidgets port maintained?

2013-02-11 Thread Maciej Stachowiak
On Feb 11, 2013, at 1:34 PM, Kevin Ollivier kev...@theolliviers.com wrote: On Feb 11, 2013, at 12:27 PM, Benjamin Poulain wrote: On Mon, Feb 11, 2013 at 11:27 AM, Kevin Ollivier kev...@theolliviers.com wrote: I actually have recently been working on a patch to get trunk building

Re: [webkit-dev] Is the wxWidgets port maintained?

2013-02-11 Thread Ryosuke Niwa
On Mon, Feb 11, 2013 at 2:13 PM, Brent Fulgham bfulg...@gmail.com wrote: On Mon, Feb 11, 2013 at 1:51 PM, Ryosuke Niwa rn...@webkit.org wrote: Asking people to ignore wx is basically the same as having the code outside the tree. Having the code outside the tree would make this change

Re: [webkit-dev] Is the wxWidgets port maintained?

2013-02-11 Thread Kevin Ollivier
On Feb 11, 2013, at 2:13 PM, Brent Fulgham wrote: Hi Everyone, On Mon, Feb 11, 2013 at 1:51 PM, Ryosuke Niwa rn...@webkit.org wrote: Asking people to ignore wx is basically the same as having the code outside the tree. Having the code outside the tree would make this change effective

Re: [webkit-dev] Is the wxWidgets port maintained?

2013-02-11 Thread Brent Fulgham
On Mon, Feb 11, 2013 at 1:55 PM, Ryosuke Niwa rn...@webkit.org wrote: Meanwhile, are there anything we can do as the WebKit community to help maintaing a one-man port like Wx in the future? e.g. rebumping build systems, etc... I think the recent discussions about standardizing on something

Re: [webkit-dev] Is the wxWidgets port maintained?

2013-02-11 Thread Dirk Pranke
On Mon, Feb 11, 2013 at 1:41 PM, Kevin Ollivier kev...@theolliviers.com wrote: Hi Martin, On Feb 11, 2013, at 12:47 PM, Martin Robinson wrote: On Mon, Feb 11, 2013 at 11:27 AM, Kevin Ollivier kev...@theolliviers.com wrote: The project is not dead per-se, but it's true that it's not very

Re: [webkit-dev] Is the wxWidgets port maintained?

2013-02-11 Thread Kevin Ollivier
On Feb 11, 2013, at 2:01 PM, Martin Robinson wrote: On Mon, Feb 11, 2013 at 1:41 PM, Kevin Ollivier kev...@theolliviers.com wrote: Actually, it will, if anything, increase the workload. Because I use waf, I am able to use Python to auto-generate the list of sources to build. In other

Re: [webkit-dev] Is the wxWidgets port maintained?

2013-02-11 Thread Dirk Pranke
On Mon, Feb 11, 2013 at 3:26 PM, Kevin Ollivier kev...@theolliviers.com wrote: On Feb 11, 2013, at 2:01 PM, Martin Robinson wrote: On Mon, Feb 11, 2013 at 1:41 PM, Kevin Ollivier kev...@theolliviers.com wrote: Actually, it will, if anything, increase the workload. Because I use waf, I am

Re: [webkit-dev] Is the wxWidgets port maintained?

2013-02-11 Thread Ryosuke Niwa
On Mon, Feb 11, 2013 at 3:26 PM, Kevin Ollivier kev...@theolliviers.comwrote: On Feb 11, 2013, at 2:01 PM, Martin Robinson wrote: On Mon, Feb 11, 2013 at 1:41 PM, Kevin Ollivier kev...@theolliviers.com wrote: Actually, it will, if anything, increase the workload. Because I use waf, I

Re: [webkit-dev] Removing ENABLE(WEB_INTENTS) code

2013-02-11 Thread Nico Weber
Going once, going twice… https://bugs.webkit.org/show_bug.cgi?id=109501 On Sat, Feb 2, 2013 at 3:09 PM, Sam Weinig wei...@apple.com wrote: Sounds good to me as well. -Sam On Jan 30, 2013, at 3:54 PM, Nico Weber tha...@chromium.org wrote: Hi, I'd like to delete all the

Re: [webkit-dev] Removing ENABLE(WEB_INTENTS) code

2013-02-11 Thread Eric Seidel
Having just spent all day removing NEW_XML cruft, I'm glad to see this unused code go sooner rather than later. :) On Mon, Feb 11, 2013 at 3:44 PM, Nico Weber tha...@chromium.org wrote: Going once, going twice… https://bugs.webkit.org/show_bug.cgi?id=109501 On Sat, Feb 2, 2013 at 3:09 PM,

Re: [webkit-dev] Controlling use of Deletion UI with ENABLE_DELETION_UI

2013-02-11 Thread Ryosuke Niwa
On Mon, Feb 11, 2013 at 3:53 PM, Enrica Casucci enr...@apple.com wrote: with http://trac.webkit.org/changeset/142533 I've added the ability to control the use of the Deletion UI. I've explicitly enabled the feature for MAC and disabled it for iOS but I left in on by default for all the other

Re: [webkit-dev] Is the wxWidgets port maintained?

2013-02-11 Thread Kevin Ollivier
On Feb 11, 2013, at 3:33 PM, Dirk Pranke wrote: On Mon, Feb 11, 2013 at 3:26 PM, Kevin Ollivier kev...@theolliviers.com wrote: On Feb 11, 2013, at 2:01 PM, Martin Robinson wrote: On Mon, Feb 11, 2013 at 1:41 PM, Kevin Ollivier kev...@theolliviers.com wrote: Actually, it will, if

Re: [webkit-dev] Is the wxWidgets port maintained?

2013-02-11 Thread Kevin Ollivier
On Feb 11, 2013, at 3:37 PM, Ryosuke Niwa wrote: On Mon, Feb 11, 2013 at 3:26 PM, Kevin Ollivier kev...@theolliviers.com wrote: On Feb 11, 2013, at 2:01 PM, Martin Robinson wrote: On Mon, Feb 11, 2013 at 1:41 PM, Kevin Ollivier kev...@theolliviers.com wrote: Actually, it will,

Re: [webkit-dev] Is the wxWidgets port maintained?

2013-02-11 Thread Dirk Pranke
On Mon, Feb 11, 2013 at 4:30 PM, Kevin Ollivier kev...@theolliviers.com wrote: On Feb 11, 2013, at 3:33 PM, Dirk Pranke wrote: On Mon, Feb 11, 2013 at 3:26 PM, Kevin Ollivier kev...@theolliviers.com wrote: On Feb 11, 2013, at 2:01 PM, Martin Robinson wrote: On Mon, Feb 11, 2013 at 1:41

Re: [webkit-dev] Is the wxWidgets port maintained?

2013-02-11 Thread Ryosuke Niwa
On Mon, Feb 11, 2013 at 4:53 PM, Kevin Ollivier kev...@theolliviers.comwrote: I know you're speaking more in general here, but just to be clear, over the past 6 months, the data hit that WebKit engineers have taken on account of the wx port is close to 0 bytes. The only time svn up or git

Re: [webkit-dev] Controlling use of Deletion UI with ENABLE_DELETION_UI

2013-02-11 Thread Ryosuke Niwa
On Mon, Feb 11, 2013 at 5:11 PM, Maciej Stachowiak m...@apple.com wrote: On Feb 11, 2013, at 4:23 PM, Ryosuke Niwa rn...@webkit.org wrote: On Mon, Feb 11, 2013 at 3:53 PM, Enrica Casucci enr...@apple.com wrote: with http://trac.webkit.org/changeset/142533 I've added the ability to control

Re: [webkit-dev] Controlling use of Deletion UI with ENABLE_DELETION_UI

2013-02-11 Thread Enrica Casucci
On Feb 11, 2013, at 5:16 PM, Ryosuke Niwa rn...@webkit.org wrote: On Mon, Feb 11, 2013 at 5:11 PM, Maciej Stachowiak m...@apple.com wrote: On Feb 11, 2013, at 4:23 PM, Ryosuke Niwa rn...@webkit.org wrote: On Mon, Feb 11, 2013 at 3:53 PM, Enrica Casucci enr...@apple.com wrote: with

Re: [webkit-dev] Is the wxWidgets port maintained?

2013-02-11 Thread Kevin Ollivier
On Feb 11, 2013, at 5:03 PM, Dirk Pranke wrote: On Mon, Feb 11, 2013 at 4:30 PM, Kevin Ollivier kev...@theolliviers.com wrote: On Feb 11, 2013, at 3:33 PM, Dirk Pranke wrote: On Mon, Feb 11, 2013 at 3:26 PM, Kevin Ollivier kev...@theolliviers.com wrote: On Feb 11, 2013, at 2:01 PM,

Re: [webkit-dev] Is the wxWidgets port maintained?

2013-02-11 Thread Kevin Ollivier
On Feb 11, 2013, at 5:20 PM, Benjamin Poulain wrote: On Mon, Feb 11, 2013 at 5:11 PM, Ryosuke Niwa rn...@webkit.org wrote: On Mon, Feb 11, 2013 at 4:53 PM, Kevin Ollivier kev...@theolliviers.com wrote: I know you're speaking more in general here, but just to be clear, over the past 6

Re: [webkit-dev] Is the wxWidgets port maintained?

2013-02-11 Thread Benjamin Poulain
On Mon, Feb 11, 2013 at 6:17 PM, Kevin Ollivier kev...@theolliviers.comwrote: To be honest, I think I know more about the wx port, and would probably be better able to cleanly remove it from the tree, than you would. As I've said from the start, I'll remove it if that's what people want, but I

Re: [webkit-dev] Is the wxWidgets port maintained?

2013-02-11 Thread Eric Seidel
This entire email thread makes me sad. I'm sad because we did this to ourselves (our porting systems/policies are lacking), we did this very abruptly (the last port we kicked out of webkit.org took a year?), and we don't have any clear policy for this sort of thing (adding/removing ports in