Re: [Wikitech-l] Separation of Concerns

2013-06-05 Thread Daniel Friesen
On Tue, 04 Jun 2013 18:50:38 -0700, Brad Jorsch bjor...@wikimedia.org wrote: On Tue, Jun 4, 2013 at 7:56 PM, Tyler Romeo tylerro...@gmail.com wrote: If you go by module, then you have problems where you need to grant specific rights for using modules like list=categorymembers and

[Wikitech-l] ???!!! ResourceLoader loading extension CSS DYNAMICALLY?!!

2013-06-05 Thread vitalif
Hello! I've got a serious issue with ResourceLoader. WHAT FOR it's made to load extension styles_ DYNAMICALLY using JavaScript? It's a very bad idea, it leads to page style flickering during load. I.e. first the page is displayed using only skin CSS and then you see how

Re: [Wikitech-l] ???!!! ResourceLoader loading extension CSS DYNAMICALLY?!!

2013-06-05 Thread Paul Selitskas
Why so many question marks? :) There is OutputPage::addModuleStyles(), it's said that it enables module CSS files via link / tags instead of loading it by means of JavaScript. Iirc, it works right like advertised. On Wed, Jun 5, 2013 at 3:43 PM, vita...@yourcmc.ru wrote: Hello! I've got a

Re: [Wikitech-l] Separation of Concerns

2013-06-05 Thread Brad Jorsch
On Jun 5, 2013 12:00 AM, Tyler Romeo tylerro...@gmail.com wrote: I'm sure you did, but it's kind of useless if nobody provides an explanation. Do you really expect me to just accept that some WMF engineers somewhere decided it was best? Your original message seemed to me to assume we were all

Re: [Wikitech-l] Separation of Concerns

2013-06-05 Thread Brad Jorsch
On Jun 5, 2013 3:48 AM, Daniel Friesen dan...@nadir-seen-fire.com wrote: but you can't grant the ability to edit normal pages without also granting the ability to edit your user CSS/JS We only need to introduce one (well two if you separate js and css) more right to restrict that. Then that

Re: [Wikitech-l] migrating hooks doc to doxygen?

2013-06-05 Thread Max Semenik
On 04.06.2013, 22:33 Antoine wrote: I would myself drop the mediawiki.org documentation in favour of inline documentation which is thus kept in sync with the code. I barely update the mw.org doc when doing changes. How large inline documentation can be? The benefit of a wiki is that you can

[Wikitech-l] Needless forks with incompatible license changes

2013-06-05 Thread Ryan Lane
On Tue, Jun 4, 2013 at 7:56 PM, Tyler Romeo tylerro...@gmail.com wrote: AuthPlugin never used to handle this kind of stuff. The only extensions that use AuthPlugin are those that provide *supplemental* authentication services. Notice that E:LDAPAuthentication uses AuthPlugin, but

Re: [Wikitech-l] ???!!! ResourceLoader loading extension CSS DYNAMICALLY?!!

2013-06-05 Thread Jon Robson
As Paul points out this is how it is supposed to work. Use $out-addModuleStyles for the most important styles. Any styles that are only used alongside javascript modules should be loaded dynamically and added to the page using $out-addModules. On Wed, Jun 5, 2013 at 6:05 AM, Paul Selitskas

[Wikitech-l] Tomorrow (June 6th): The start of one-week deploy cycle!

2013-06-05 Thread Greg Grossmeier
Hi all! Tomorrow we start the one-week deploy cycle here at WMF! You can see the general overview of the cycle here: https://wikitech.wikimedia.org/wiki/Deployments/One_week And the specific roadmap/plan for MediaWiki (with version numbers/dates) here:

Re: [Wikitech-l] [Wikitech-] ResourceLoader loading extension CSS dynamically?

2013-06-05 Thread Krinkle
On Jun 5, 2013, at 2:43 PM, vita...@yourcmc.ru wrote: Hello! I've got a serious issue with ResourceLoader. WHAT FOR it's made to load extension styles_ DYNAMICALLY using JavaScript? It's a very bad idea, it leads to page style flickering during load. I.e. first the page

[Wikitech-l] Question re. Html class : I ran into a problem correctly escaping the $content component

2013-06-05 Thread Thomas Gries
I recently try to modernize an extension [1] to use the /_Html _/class and found a problem (at least for me) . Like to receive your comments, and tips. In several cases, I had to use Htlm::rawElement (*) instead of the safer Html::element because of a nested div structure I want to generate like

Re: [Wikitech-l] Tomorrow (June 6th): The start of one-week deploy cycle!

2013-06-05 Thread Antoine Musso
Le 05/06/13 20:07, Greg Grossmeier a écrit : Tomorrow we start the one-week deploy cycle here at WMF! You can see the general overview of the cycle here: https://wikitech.wikimedia.org/wiki/Deployments/One_week And the specific roadmap/plan for MediaWiki (with version numbers/dates)

Re: [Wikitech-l] migrating hooks doc to doxygen?

2013-06-05 Thread Antoine Musso
Le 05/06/13 16:59, Max Semenik a écrit : How large inline documentation can be? The benefit of a wiki is that you can have large pages with a lot of documentation, examples and _links_ - not something you can do in a comment. Doxygen has support for examples, you could even get them out of the

Re: [Wikitech-l] Separation of Concerns

2013-06-05 Thread Chris Steipp
On Tue, Jun 4, 2013 at 9:00 PM, Tyler Romeo tylerro...@gmail.com wrote: I'm sure you did, but it's kind of useless if nobody provides an explanation. Do you really expect me to just accept that some WMF engineers somewhere decided it was best? I should have logged and posted our irc chats

Re: [Wikitech-l] migrating hooks doc to doxygen?

2013-06-05 Thread Antoine Musso
Le 04/06/13 19:40, Brad Jorsch a écrit : The result is pretty. But personally I'll probably continue to just look in hooks.txt if I need the info in there, and the markup in the (now-misnamed) file is rather ugly. Not that the existing file isn't also ugly, just less so. An interesting

[Wikitech-l] [X-POST] Universal Language Selector(ULS) Deployment - Phase 1

2013-06-05 Thread Runa Bhattacharjee
Hello, The Universal Language Selector (ULS)[1] provides a flexible way to configure and deliver language settings like interface language, fonts, and input methods (keyboard mappings). It combines the features of two earlier Mediawiki extensions Narayam[2] and WebFonts[3]. From June 11, 2013 on,

Re: [Wikitech-l] [Wikitech-ambassadors] [X-POST] Universal Language Selector(ULS) Deployment - Phase 1

2013-06-05 Thread shi zhao
Why ULS deployment all wikis? Chinese wikipedia: http://zh.wikipedia.org/ My blog: http://shizhao.org twitter: https://twitter.com/shizhao [[zh:User:Shizhao]] 2013/6/6 Runa Bhattacharjee rbhattachar...@wikimedia.org: Hello, The Universal Language Selector (ULS)[1] provides a flexible way to

Re: [Wikitech-l] [Wikimedia-l] [Wikitech-ambassadors] [X-POST] Universal Language Selector(ULS) Deployment - Phase 1

2013-06-05 Thread Federico Leva (Nemo)
shi zhao, 05/06/2013 22:07: Why ULS deployment all wikis? Does https://www.mediawiki.org/wiki/Universal_Language_Selector/Design#Rationale answer your question? Nemo ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org

Re: [Wikitech-l] [Wikimedia-l] [X-POST] Universal Language Selector(ULS) Deployment - Phase 1

2013-06-05 Thread Peter Coombe
What is the rationale for moving ULS from the personal toolbar to the interlanguage links on some sites? I find this change odd: * makes location and appearance of ULS inconsistent between sites * personal toolbar seems the conventional place for per-account settings and tools * features it is

Re: [Wikitech-l] Separation of Concerns

2013-06-05 Thread Daniel Friesen
On Wed, 05 Jun 2013 06:42:52 -0700, Brad Jorsch bjor...@wikimedia.org wrote: On Jun 5, 2013 3:48 AM, Daniel Friesen dan...@nadir-seen-fire.com wrote: There's nothing wrong with having a large list of fine-grained rights to grant as long as you format them properly for the user. In other

Re: [Wikitech-l] Separation of Concerns

2013-06-05 Thread Tyler Romeo
On Wed, Jun 5, 2013 at 3:23 PM, Chris Steipp cste...@wikimedia.org wrote: I should have logged and posted our irc chats around this, but I didn't think of that at the time. That's my fault. I'll try and reconstruct the discussions we had on wiki. Thank you. This will also be helpful should

Re: [Wikitech-l] Separation of Concerns

2013-06-05 Thread Platonides
On 05/06/13 15:42, Brad Jorsch wrote: There's nothing wrong with having a large list of fine-grained rights to grant as long as you format them properly for the user. In other words, implement another rights-grouping system just as complicated and less clear than the approach currently

Re: [Wikitech-l] Tomorrow (June 6th): The start of one-week deploy cycle!

2013-06-05 Thread Platonides
On 05/06/13 20:07, Greg Grossmeier wrote: Hi all! Tomorrow we start the one-week deploy cycle here at WMF! You can see the general overview of the cycle here: https://wikitech.wikimedia.org/wiki/Deployments/One_week And the specific roadmap/plan for MediaWiki (with version numbers/dates)

[Wikitech-l] Bugzilla: Separate bug report status when patch is in Gerrit?

2013-06-05 Thread Andre Klapper
Hi everybody, in December I mentioned the idea of having a PATCH_AVAILABLE or PATCH_TO_REVIEW status in Bugzilla [1] and that we should re-evaluate the idea once we have automatic notifications from Gerrit into Bugzilla in place [2]. This is now the case [3]. From the Amsterdam Hackathon I know

Re: [Wikitech-l] Bugzilla: Separate bug report status when patch is in Gerrit?

2013-06-05 Thread Jon Robson
I've been using ASSIGNED and assignee name to mean this... to me if someone is assigned to something it is a promise to attempt to fix it. I'm not sure how patch to review would be useful... Gerrit should be the place to look for things to review - not bugzilla. A RELEASED would however would be

Re: [Wikitech-l] New git-review lets you configure 'origin' as the gerrit remote

2013-06-05 Thread Juliusz Gonera
Thank you! On 05/31/2013 03:14 PM, Ori Livneh wrote: Hey, The new version of git-review released today (1.22) includes a patch I wrote that makes it possible to work against a single 'origin' remote. This amounts to a workaround for git-review's tendency to frighten you into thinking you're

Re: [Wikitech-l] New git-review lets you configure 'origin' as the gerrit remote

2013-06-05 Thread Yuri Astrakhan
I wonder if origin should be made the default setting for gerrit - after all every new git clone automatically uses origin. The fewer surprise! moments devs have, the more productive we become. On Wed, Jun 5, 2013 at 6:42 PM, Juliusz Gonera jgon...@wikimedia.orgwrote: Thank you! On

Re: [Wikitech-l] New git-review lets you configure 'origin' as the gerrit remote

2013-06-05 Thread Paul Selitskas
Tried setting up the global config in /etc. git-review's gone wild with an exception (very sorry, I switched the terminal off and cannot provide the backtrace; I remember it wanted 'updates' section or some kind of). Luckly ~/.config/ worked well, thanks! On Sat, Jun 1, 2013 at 1:14 AM, Ori

Re: [Wikitech-l] New git-review lets you configure 'origin' as the gerrit remote

2013-06-05 Thread Daniel Friesen
Not if they fork from our github mirror and their origin is their own repo. Personally my origin is the github remote I push my unfinished branches of code too. I use 'core' for the actual gerrit remote. And I didn't even fork. I did this before we had a github mirror. -- ~Daniel Friesen

Re: [Wikitech-l] New git-review lets you configure 'origin' as the gerrit remote

2013-06-05 Thread Yuri Astrakhan
Daniel, I am not saying it will solve everyone's usage scenarios, but I think one would agree that for the majority of the developers, origin is set by default. Even gerrit's own usage of navigate to gerrit.wikimedia.org, and copy git clone command from the project page uses origin, not -o gerrit.

Re: [Wikitech-l] Bugzilla: Separate bug report status when patch is in Gerrit?

2013-06-05 Thread Bartosz Dziewoński
Yesplz. The sooner we do this, the better. I've sometimes ASSIGNED bugs to myself to indicate that there's a patch, too, but assigning means different things for different people (e.g. the VE team assigns pretty much all bugs to someone and this means something to them internally I couldn't

Re: [Wikitech-l] Bugzilla: Separate bug report status when patch is in Gerrit?

2013-06-05 Thread Daniel Friesen
On Wed, 05 Jun 2013 15:15:47 -0700, Andre Klapper aklap...@wikimedia.org wrote: Hi everybody, * to make the Gerrit Notification Bot automatically change the bug report status to PATCH_AVAILABLE/PATCH_TO_REVIEW in Bugzilla when a patch for that bug report has been

Re: [Wikitech-l] Question re. Html class : I ran into a problem correctly escaping the $content component

2013-06-05 Thread Tyler Romeo
Have you tried seeing if changing the arguments to htmlspecialchars() will work? Note that htmlspecialchars() takes an argument $double_encode, e.g., htmlspecialchars( 'text', ENT_QUOTES, 'UTF-8', false ); When set to false, the function will not encode existing HTML entities in the text. More

Re: [Wikitech-l] Bugzilla: Separate bug report status when patch is in Gerrit?

2013-06-05 Thread K. Peachey
How does a Status change work better than a Keyword change in this case? ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Bugzilla: Separate bug report status when patch is in Gerrit?

2013-06-05 Thread Brian Wolff
On 6/5/13, Andre Klapper aklap...@wikimedia.org wrote: Hi everybody, in December I mentioned the idea of having a PATCH_AVAILABLE or PATCH_TO_REVIEW status in Bugzilla [1] and that we should re-evaluate the idea once we have automatic notifications from Gerrit into Bugzilla in place [2].

Re: [Wikitech-l] Bugzilla: Separate bug report status when patch is in Gerrit?

2013-06-05 Thread Matthew Flaschen
On 06/05/2013 08:18 PM, Daniel Friesen wrote: On Wed, 05 Jun 2013 15:15:47 -0700, Andre Klapper aklap...@wikimedia.org wrote: Hi everybody, * to make the Gerrit Notification Bot automatically change the bug report status to PATCH_AVAILABLE/PATCH_TO_REVIEW in Bugzilla

Re: [Wikitech-l] Question re. Html class : I ran into a problem correctly escaping the $content component

2013-06-05 Thread Daniel Friesen
How about we just introduce a Html::escape to escape for escaping of text to include into html chunks (not attributes, just html; attributes should always be required to pass through Html::expandAttributes. I'm not sure what the relevance of $wgContLang-normalize is. It's not applicable to

[Wikitech-l] Help with Scribunto/Lua modules

2013-06-05 Thread MZMcBride
Hi. I tried to write a Scribunto module in Lua today on Meta-Wiki called Sort: https://meta.wikimedia.org/wiki/Module:Sort. I struggled a lot to get an environment set up where I could easily test blocks of code, so I'm looking for any help/guidance I can get. The debug console seems finicky.

Re: [Wikitech-l] Question re. Html class : I ran into a problem correctly escaping the $content component

2013-06-05 Thread Matthew Flaschen
On 06/05/2013 02:47 PM, Thomas Gries wrote: *Both *are not suited for my case, when $outertext has this #160; character in it. I'm not totally clear what you mean. Is the actual string like 'foo bar #160;'? If so, where is this string coming from? Ideally, this should not be in the string

[Wikitech-l] Just noticed GitBlit

2013-06-05 Thread Tyler Romeo
So when did we get this new repo browser? Looks pretty nice, but I should note that all on-wiki gitweb links have now been broken. *-- * *Tyler Romeo* Stevens Institute of Technology, Class of 2016 Major in Computer Science www.whizkidztech.com | tylerro...@gmail.com

Re: [Wikitech-l] Just noticed GitBlit

2013-06-05 Thread Chad
On Thu, Jun 6, 2013 at 12:49 AM, Tyler Romeo tylerro...@gmail.com wrote: So when did we get this new repo browser? Looks pretty nice, but I should note that all on-wiki gitweb links have now been broken. Turned it on today. It's been in the pipeline for awhile. The various templates should've

Re: [Wikitech-l] Just noticed GitBlit

2013-06-05 Thread Daniel Friesen
On Wed, 05 Jun 2013 21:49:43 -0700, Tyler Romeo tylerro...@gmail.com wrote: So when did we get this new repo browser? Looks pretty nice, but I should note that all on-wiki gitweb links have now been broken. *-- * *Tyler Romeo* Stevens Institute of Technology, Class of 2016 Major in Computer