[MediaWiki-CodeReview] [MediaWiki r89676]: New comment added

2011-06-08 Thread MediaWiki Mail
User Tim Starling posted a comment on MediaWiki.r89676. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89676#c17855 Commit summary: 1.17: MFT r82247, r87203, r87265, r87494, r87497, r87711, r87840, r88076, r89615 Comment: Did you mean to backport r87711? I thought we weren't

[MediaWiki-CodeReview] [MediaWiki r89713]: Revision status changed

2011-06-08 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r89713. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89713#c0 Commit summary: Revert r87145, bug 28752: Xcache doesn't work in cli mode. As pointed out on CR, this didn't fix it, it just hid the issue.

[MediaWiki-CodeReview] [MediaWiki r85323]: New comment added

2011-06-08 Thread MediaWiki Mail
User Hashar posted a comment on MediaWiki.r85323. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85323#c17856 Commit summary: Type hints to substring used in integer addition Comment: I got your point. Maybe use meaningful variables instead? $hour = substr( $now, 8, 2 )

Re: [Wikitech-l] I'm in ur trunk, reviewing pre-1.18 branch code

2011-06-08 Thread Ashar Voultoiz
On 07/06/11 20:56, Brion Vibber wrote: Currently working (mostly backwards) to fill in the Code Review holes from before 1.18 branch point: Since ci.tesla is almost stable since last week, I have switched to reviewing 1.18. I might have added some bugs in the 1.17 backport queue. Is there any

Re: [Wikitech-l] I'm in ur trunk, reviewing pre-1.18 branch code

2011-06-08 Thread Ashar Voultoiz
On 07/06/11 23:27, Rob Lanphier wrote: http://toolserver.org/~robla/crstats/crstats.118all.html And here's the goals I posted on Friday: 2011-Jun-03 1594 2011-Jun-10 1329 2011-Jun-17 1064 2011-Jun-24 799 2011-Jul-01 534 2011-Jul-08 269 2011-Jul-15 4 This is a

[MediaWiki-CodeReview] [MediaWiki r87164]: New comment added

2011-06-08 Thread MediaWiki Mail
User IAlex posted a comment on MediaWiki.r87164. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/87164#c17857 Commit summary: Recommit r87129 and follow-ups but with a fix for the bug Brion found (sorry) Comment: Yes, the problem is that you cannot

[MediaWiki-CodeReview] [MediaWiki r89252]: New comment added

2011-06-08 Thread MediaWiki Mail
User Freakolowsky posted a comment on MediaWiki.r89252. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89252#c17858 Commit summary: * MFT r89250. only the tableExists function ad 1.17 already supports user-dbname difference Comment: The function is not exposed to direct input

[Wikitech-l] sprint ? Implement a way for _only authorized users to use Special:PasswordReset on other usernames bug29135

2011-06-08 Thread Thomas Gries
Am 02.06.2011 04:33, schrieb Mark A. Hershberger: === Implement a way for _only authorized users to use Special:PasswordReset on other usernames === https://bugzilla.wikimedia.org/29135 A valid feature request, but just that a lot of details, so this makes a good one for me to

Re: [Wikitech-l] I'm in ur trunk, reviewing pre-1.18 branch code

2011-06-08 Thread Dmitriy Sintsov
* Brion Vibber br...@pobox.com [Tue, 7 Jun 2011 11:56:36 -0700]: Currently working (mostly backwards) to fill in the Code Review holes from before 1.18 branch point: http://www.mediawiki.org/w/index.php?title=Special:Code/MediaWikioffset=87519path=%2Ftrunk%2Fphase3 Roadmap provisionally

[MediaWiki-CodeReview] [MediaWiki r89723]: New comment added

2011-06-08 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r89723. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89723#c17859 Commit summary: bug fix: multiselects not working from edit view Comment: Forgot debugging statements? ___

Re: [Wikitech-l] I'm in ur trunk, reviewing pre-1.18 branch code

2011-06-08 Thread Roan Kattouw
On Wed, Jun 8, 2011 at 9:30 AM, Dmitriy Sintsov ques...@rambler.ru wrote: I wish there was WYSIWYG editor in the roadmap. It can be anything: Wikia RTE, Magnus Manske visual editor, or anything else - however, supporting creating content from scratch (not just editing over already existing

[MediaWiki-CodeReview] [MediaWiki r89707]: New comment added

2011-06-08 Thread MediaWiki Mail
User Catrope posted a comment on MediaWiki.r89707. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/89707#c17860 Commit summary: quick fix for bug28983 . Do not use $path in the loop. Even the remaining $e is dangerous subject to change from the

[MediaWiki-CodeReview] [MediaWiki r81536]: New comment added

2011-06-08 Thread MediaWiki Mail
User Catrope posted a comment on MediaWiki.r81536. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/81536#c17861 Commit summary: (bug 19751) Filesystem is now checked during image undeletion * FSRepo::storeBatch() now does an sha1 check unless

[MediaWiki-CodeReview] [MediaWiki r89676]: New comment added

2011-06-08 Thread MediaWiki Mail
User Catrope posted a comment on MediaWiki.r89676. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/89676#c17863 Commit summary: 1.17: MFT r82247, r87203, r87265, r87494, r87497, r87711, r87840, r88076, r89615 Comment: Crap, looks like I haven't done this

[MediaWiki-CodeReview] [MediaWiki r89676]: New comment added

2011-06-08 Thread MediaWiki Mail
User Catrope posted a comment on MediaWiki.r89676. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/89676#c17864 Commit summary: 1.17: MFT r82247, r87203, r87265, r87494, r87497, r87711, r87840, r88076, r89615 Comment: Fixed in r89727

[MediaWiki-CodeReview] [MediaWiki r87099]: New comment added

2011-06-08 Thread MediaWiki Mail
User Hashar posted a comment on MediaWiki.r87099. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/87099#c17865 Commit summary: Provisional fix for Bug #28631 to remove artifacts from GIF. This seems better in my (very) limited testing than leaving it in,

[MediaWiki-CodeReview] [MediaWiki r87099]: New comment added

2011-06-08 Thread MediaWiki Mail
User TheDJ posted a comment on MediaWiki.r87099. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/87099#c17866 Commit summary: Provisional fix for Bug #28631 to remove artifacts from GIF. This seems better in my (very) limited testing than leaving it in,

[MediaWiki-CodeReview] [MediaWiki r89728]: New comment added

2011-06-08 Thread MediaWiki Mail
User Reedy posted a comment on MediaWiki.r89728. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89728#c17867 Commit summary: Localization update for he. Comment: Wouldn't it be easier to just do these on TranslateWiki, easier to track changes, and then it's not a separate

[MediaWiki-CodeReview] [MediaWiki r79463]: Revision status changed

2011-06-08 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r79463. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/79463#c0 Commit summary: Move fallback function creation out of function_exists() conditionals. This allows for unit testing of the fallback

[MediaWiki-CodeReview] [MediaWiki r81610]: Revision status changed

2011-06-08 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r81610. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81610#c0 Commit summary: Ignore code coverage for compatibility and shell functions The compatibility functions in GlobalFunctions are just wrapper

[MediaWiki-CodeReview] [MediaWiki r81644]: Revision status changed

2011-06-08 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r81644. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81644#c0 Commit summary: Fixed copy-paste fail that resulted in incorect authorship information. ___

[MediaWiki-CodeReview] [MediaWiki r86131]: New comment added

2011-06-08 Thread MediaWiki Mail
User Platonides posted a comment on MediaWiki.r86131. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86131#c17868 Commit summary: * Pass around parser options instead of users and made some parser options consistency fixes * Moved makeParserOptions to Article.php * Renamed

[MediaWiki-CodeReview] [MediaWiki r89729]: Revision status changed

2011-06-08 Thread MediaWiki Mail
User Platonides changed the status of MediaWiki.r89729. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89729#c0 Commit summary: Fix r89696 - caused fatal error ___ MediaWiki-CodeReview mailing list

Re: [Wikitech-l] Showing stub links by default - is it possible in a Wikimedia project?

2011-06-08 Thread Leo Koppelkamm
If we proceeded to remove the feature, they could fairly easily add it into Popups or one of the other JS citadels. I don't see a way to do it in JS w/o lengthy expensive API checks.. Leo ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org

[Wikitech-l] Extension bundling for 1.18

2011-06-08 Thread Mark A. Hershberger
There has been some talk among developers and others about bundling some extensions with the tarball. The new installer supports enabling extensions during installation, so if we're going to do it, I would like to start bundling them with the 1.18 tarball. Part of my motivation is that many

Re: [Wikitech-l] Extension bundling for 1.18

2011-06-08 Thread David Gerard
On 8 June 2011 16:22, Mark A. Hershberger mhershber...@wikimedia.org wrote: Part of my motivation is that many people seem to install MediaWiki and expect a wiki that acts very similar to Wikipedia, with which they are more familiar.  Now, part of the problem is documentation — these people

Re: [Wikitech-l] Extension bundling for 1.18

2011-06-08 Thread Chad
On Wed, Jun 8, 2011 at 11:22 AM, Mark A. Hershberger mhershber...@wikimedia.org wrote: Immediately, the objection of “bloat” would be raised.  To alleviate this concern, we can still provide a “MediaWiki-lite” tarball with only the contents of phase3 as before. Since we're going down the road

Re: [Wikitech-l] Extension bundling for 1.18

2011-06-08 Thread Jeroen De Dauw
Hey, Assuming that we are going to put *some* extensions in, we need to decide which ones. As some might remember, I raised the question of the Validator extension [0] could be included in the tarball earlier this year [1]. This extensions goal is facilitating features in other extensions,

Re: [Wikitech-l] I'm in ur trunk, reviewing pre-1.18 branch code

2011-06-08 Thread Brion Vibber
That reminds me I should merge docs to the roadmap page! For now those live at http://www.mediawiki.org/wiki/Future -- brion On Jun 8, 2011 4:13 AM, Roan Kattouw roan.katt...@gmail.com wrote: On Wed, Jun 8, 2011 at 9:30 AM, Dmitriy Sintsov ques...@rambler.ru wrote: I wish there was WYSIWYG

Re: [Wikitech-l] Extension bundling for 1.18

2011-06-08 Thread Trevor Parscal
While Vector is the default skin, the Vector extension should probably be bundled too. - Trevor On Wed, Jun 8, 2011 at 9:00 AM, Jeroen De Dauw jeroended...@gmail.comwrote: Hey, Assuming that we are going to put *some* extensions in, we need to decide which ones. As some might remember, I

Re: [Wikitech-l] Extension bundling for 1.18

2011-06-08 Thread Krinkle
Mark A. Hershberger wrote: Assuming that we are going to put *some* extensions in, we need to decide which ones. Based on the problem reports in Bugzilla, I think at least Cite and ParserFunctions should be bundled. Others would be Gadgets and WikiEditor. So my list would be: Cite

[MediaWiki-CodeReview] [MediaWiki r86898]: Revision status changed

2011-06-08 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r86898. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/86898#c0 Commit summary: proxy_check.php is probably useful to keep around, but it's not really an includes script Move it

Re: [Wikitech-l] Extension bundling for 1.18

2011-06-08 Thread Łukasz Garczewski
On Wed, Jun 8, 2011 at 5:22 PM, Mark A. Hershberger mhershber...@wikimedia.org wrote: So my list would be:    Cite    ParserFunctions    Gadgets    WikiEditor ConfirmEdit (rationale: every single public wiki I've setup dies without this) -- Lucas 'TOR' Garczewski Community Engineer

Re: [Wikitech-l] Update Gadgets extension on WMF wikis

2011-06-08 Thread Ildefons Stułbia
2011/6/7 Leo Koppelkamm diebu...@gmail.com: There's usually some code (general utility fn's, some legacy remappings etc.) in common.js that could break a lot of stuff if missing. +1 on moving optional stuff to gadgets It depends on project. General utility functions should be available as

[MediaWiki-CodeReview] [MediaWiki r89731]: New comment added

2011-06-08 Thread MediaWiki Mail
User Siebrand posted a comment on MediaWiki.r89731. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89731#c17869 Commit summary: * fixed regex to work * added missing directories Comment: Nitpick: should this script be named findHooks.php?

[MediaWiki-CodeReview] [MediaWiki r89730]: New comment added

2011-06-08 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r89730. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89730#c17870 Commit summary: introduce setting for page to use for glossary Comment: Would nowiki[[$1|terminology]]/nowiki be better?

Re: [Wikitech-l] Update Gadgets extension on WMF wikis

2011-06-08 Thread Strainu
2011/6/8 Ildefons Stułbia ildefons.stul...@gmail.com: 2011/6/7 Leo Koppelkamm diebu...@gmail.com: There's usually some code (general utility fn's, some legacy remappings etc.) in common.js that could break a lot of stuff if missing. +1 on moving optional stuff to gadgets It depends on

[Wikitech-l] Intended purpose of MediaWiki:Common.js anno MW 1.19/RL 2.0

2011-06-08 Thread Krinkle
Subject was: Update Gadgets extension on WMF wikis This part of the thread is hereby forked to discuss MediaWiki:Common.js. I do not believe MediaWiki:Common.js should be deleted (atleast not yet), I'm merely curious what usecases people have for it which may or may not be useful to be

[MediaWiki-CodeReview] [MediaWiki r89730]: New comment added

2011-06-08 Thread MediaWiki Mail
User F.trott posted a comment on MediaWiki.r89730. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89730#c17871 Commit summary: introduce setting for page to use for glossary Comment: I don't know, would it? I'd rather have it clearly identified without the need to follow (or

Re: [Wikitech-l] Update Gadgets extension on WMF wikis

2011-06-08 Thread Ildefons Stułbia
2011/6/8 Strainu strain...@gmail.com: Yes, it does depend on the project, but I'm pretty sure that in most projects there are some chunks of js in Common.js that simply should not be disabled. In my opinion any custom ui feature should be optional, because it will never satisfy all users. It

[MediaWiki-CodeReview] [MediaWiki r89732]: New comment added

2011-06-08 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r89732. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89732#c17872 Commit summary: followup r89730: Use the setting Comment: Perhaps say Page ... does not exist + 'lingo-noterminologypage' = '[[$1]] does not exist.', This is

Re: [Wikitech-l] Extension bundling for 1.18

2011-06-08 Thread Casey Brown
On Wed, Jun 8, 2011 at 11:22 AM, Mark A. Hershberger mhershber...@wikimedia.org wrote: Assuming that we are going to put *some* extensions in, we need to decide which ones. [..] Have a look at http://en.wikipedia.org/wiki/Special:Version or

[MediaWiki-CodeReview] [MediaWiki r89732]: New comment added

2011-06-08 Thread MediaWiki Mail
User F.trott posted a comment on MediaWiki.r89732. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89732#c17873 Commit summary: followup r89730: Use the setting Comment: 1) Can do. 2) Changed to Title::newFromText in r89734. 3) Oops, no. There should only be one terminology

[MediaWiki-CodeReview] [MediaWiki r89733]: New comment added

2011-06-08 Thread MediaWiki Mail
User ^demon posted a comment on MediaWiki.r89733. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89733#c17874 Commit summary: Adding WURFL library Comment: Is this available in an external repository somewhere? If so, we should probably use an svn:external instead :)

[MediaWiki-CodeReview] [MediaWiki r84739]: Revision status changed

2011-06-08 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r84739. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/84739#c0 Commit summary: Changes default value so that it's not converted to array( 0 = '' ) by the (array) cast a few

[MediaWiki-CodeReview] [MediaWiki r88936]: Revision status changed

2011-06-08 Thread MediaWiki Mail
User MarkAHershberger changed the status of MediaWiki.r88936. Old Status: fixme New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88936#c0 Commit summary: This needs to be forward-ported to trunk. Fix for Bug #28172 - wfGetDB called when it shouldn't be Avoid

[MediaWiki-CodeReview] [MediaWiki r89374]: Revision status changed

2011-06-08 Thread MediaWiki Mail
User MarkAHershberger changed the status of MediaWiki.r89374. Old Status: fixme New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89374#c0 Commit summary: Finish fix for bug #28172 (“wfGetDB called when it shouldn't be”). Will now forward port to trunk

Re: [Wikitech-l] Extension bundling for 1.18

2011-06-08 Thread David Gerard
On 8 June 2011 21:01, Casey Brown li...@caseybrown.org wrote: I'd suggest that you also look at Suggestions for extensions to be merged into core: http://www.mediawiki.org/wiki/Suggestions_for_extensions_to_be_merged_into_core The point of that page is to list extensions that we love and are

Re: [Wikitech-l] Extension bundling for 1.18

2011-06-08 Thread Rob Lanphier
On Wed, Jun 8, 2011 at 8:22 AM, Mark A. Hershberger mhershber...@wikimedia.org wrote: There has been some talk among developers and others about bundling some extensions with the tarball. The new installer supports enabling extensions during installation, so if we're going to do it, I would

Re: [Wikitech-l] Extension bundling for 1.18

2011-06-08 Thread Roan Kattouw
On Wed, Jun 8, 2011 at 10:25 PM, Rob Lanphier ro...@wikimedia.org wrote: This would be 1.19 at the earliest.  1.18 is already branched, and if we're aspiring to do much more frequent releases, the last thing we should do is to complicate a 1.18 release by trying to add more features into the

Re: [Wikitech-l] Extension bundling for 1.18

2011-06-08 Thread Brion Vibber
On Wed, Jun 8, 2011 at 1:30 PM, Roan Kattouw roan.katt...@gmail.com wrote: Why don't we first ask Tim how complicated it would be, and get someone else to do it if it's more than 2-3 hours of work? I'm also not sure the scripts Tim uses to create a tarball are even in SVN anywhere, maybe he'd

Re: [Wikitech-l] Extension bundling for 1.18

2011-06-08 Thread Chad
On Wed, Jun 8, 2011 at 4:30 PM, Roan Kattouw roan.katt...@gmail.com wrote: Why don't we first ask Tim how complicated it would be, and get someone else to do it if it's more than 2-3 hours of work? I'm also not sure the scripts Tim uses to create a tarball are even in SVN anywhere, maybe he'd

Re: [Wikitech-l] Extension bundling for 1.18

2011-06-08 Thread Chad
On Wed, Jun 8, 2011 at 4:41 PM, Brion Vibber br...@pobox.com wrote: Currently the installer's support for extensions is limited; Yes :( some won't actually set up right, Examples? and we don't handle dependencies well, s/well/at all/ but self-contained stuff like ParserFunctions and

Re: [Wikitech-l] Intended purpose of MediaWiki:Common.js anno MW 1.19/RL 2.0

2011-06-08 Thread Brion Vibber
On Wed, Jun 8, 2011 at 12:16 PM, Krinkle krinklem...@gmail.com wrote: Subject was: Update Gadgets extension on WMF wikis This part of the thread is hereby forked to discuss MediaWiki:Common.js. I do not believe MediaWiki:Common.js should be deleted (atleast not yet), I'm merely curious what

Re: [Wikitech-l] Extension bundling for 1.18

2011-06-08 Thread Brion Vibber
On Wed, Jun 8, 2011 at 1:43 PM, Chad innocentkil...@gmail.com wrote: On Wed, Jun 8, 2011 at 4:41 PM, Brion Vibber br...@pobox.com wrote: Currently the installer's support for extensions is limited; Yes :( some won't actually set up right, Examples? Whatever was listed in bugzilla on

[Wikitech-l] Cache Expiry

2011-06-08 Thread Robert Cummings
Hello, I've looked around for methods to manipulate the cache duration for a given article. There are methods to facilitate the expiration of an article, and there are extensions that can disable caching for articles via convenient management interfaces. What seems to be lacking though, is a way

Re: [Wikitech-l] Extension bundling for 1.18

2011-06-08 Thread Chad
On Wed, Jun 8, 2011 at 4:48 PM, Brion Vibber br...@pobox.com wrote: On Wed, Jun 8, 2011 at 1:43 PM, Chad innocentkil...@gmail.com wrote: On Wed, Jun 8, 2011 at 4:41 PM, Brion Vibber br...@pobox.com wrote: Currently the installer's support for extensions is limited; Yes :( some won't

[MediaWiki-CodeReview] [MediaWiki r89740]: New comment added

2011-06-08 Thread MediaWiki Mail
User F.trott posted a comment on MediaWiki.r89740. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89740#c17877 Commit summary: followup r89732: use wfMsgForContent, modify messages Comment: According to

[MediaWiki-CodeReview] [MediaWiki r89740]: New comment added

2011-06-08 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r89740. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89740#c17878 Commit summary: followup r89732: use wfMsgForContent, modify messages Comment: All wfMsgFoo variants take the parameters as varargs.

[MediaWiki-CodeReview] [MediaWiki r87734]: Revision status changed

2011-06-08 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r87734. Old Status: new New Status: resolved Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/87734#c0 Commit summary: Added messaging for above/below high/low tables

[MediaWiki-CodeReview] [MediaWiki r87773]: Revision status changed

2011-06-08 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r87773. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/87773#c0 Commit summary: Followup r87734 addWikiText( wfMsg()) - addWikiMsg()

[MediaWiki-CodeReview] [MediaWiki r87796]: Revision status changed

2011-06-08 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r87796. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/87796#c0 Commit summary: Checking for 10 rating sets rather than 5; Followup r87779

[MediaWiki-CodeReview] [MediaWiki r88946]: Revision status changed

2011-06-08 Thread MediaWiki Mail
User MarkAHershberger changed the status of MediaWiki.r88946. Old Status: fixme New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88946#c0 Commit summary: Fix Bug #28829 - “Failure to subscribe to mediawiki-announce is not reported to the user” Wasn't able to test

[MediaWiki-CodeReview] [MediaWiki r89494]: Revision status changed

2011-06-08 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r89494. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/89494#c0 Commit summary: Fix syntax in .sql (spaces), crashed updater (follow-up r89277)

Re: [Wikitech-l] Cache Expiry

2011-06-08 Thread Brion Vibber
On Wed, Jun 8, 2011 at 1:50 PM, Robert Cummings rob...@interjinn.comwrote: I've looked around for methods to manipulate the cache duration for a given article. There are methods to facilitate the expiration of an article, and there are extensions that can disable caching for articles via

Re: [Wikitech-l] Intended purpose of MediaWiki:Common.js anno MW 1.19/RL 2.0

2011-06-08 Thread Helder
On Wed, Jun 8, 2011 at 16:16, Krinkle krinklem...@gmail.com wrote: I think only a few things (if at all) should eventually stay in MediaWiki:Common.js. I'm having a hard time coming up with examples, but basically only stuff that is truly specific to that particular wiki and not related to

Re: [Wikitech-l] Extension bundling for 1.18

2011-06-08 Thread Brion Vibber
On Wed, Jun 8, 2011 at 1:50 PM, Chad innocentkil...@gmail.com wrote: Whatever was listed in bugzilla on that one bug where something didn't run its installer stages or something? I don't remember; the point is that we know we don't hook all hooks etc. That would be bug 28983, which is

Re: [Wikitech-l] Intended purpose of MediaWiki:Common.js anno MW 1.19/RL 2.0

2011-06-08 Thread Helder
On Wed, Jun 8, 2011 at 18:08, Helder helder.w...@gmail.com wrote: Still talking about Wikibooks, there are scripts such as the one used to add a link to the sidebar providing access to a random bug (which is a workaround to another open bug[5]). I meant providing access to a random

[MediaWiki-CodeReview] [MediaWiki r89399]: New comment added

2011-06-08 Thread MediaWiki Mail
User Platonides posted a comment on MediaWiki.r89399. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89399#c17880 Commit summary: rvv: r89398. Tim wants me to wait Comment: Yes, I think many scripts rely on this. ___

[MediaWiki-CodeReview] [MediaWiki r89399]: New comment added

2011-06-08 Thread MediaWiki Mail
User ^demon posted a comment on MediaWiki.r89399. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89399#c17881 Commit summary: rvv: r89398. Tim wants me to wait Comment: I see no problem with removing it from trunk when Tim's done merging stuff. There's a difference between

[MediaWiki-CodeReview] [MediaWiki r89277]: New comment added, and revision status changed

2011-06-08 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r89277. Old Status: new New Status: fixme User Catrope also posted a comment on MediaWiki.r89277. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/89277#c17882 Commit summary: Added 'problem articles' view to

[MediaWiki-CodeReview] [MediaWiki r89493]: Revision status changed

2011-06-08 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r89493. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/89493#c0 Commit summary: Fix filepath (typo), crashes updater (follow-up r89277)

[MediaWiki-CodeReview] [MediaWiki r89751]: Revision status changed

2011-06-08 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r89751. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89751#c0 Commit summary: Localisation updates for core and extension messages from translatewiki.net (2011-06-08 20:51:00 UTC)

[MediaWiki-CodeReview] [MediaWiki r89749]: Revision status changed

2011-06-08 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r89749. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89749#c0 Commit summary: Localisation updates for ToolserverI18N messages from translatewiki.net (2011-06-08 20:30:00)

[MediaWiki-CodeReview] [MediaWiki r89283]: Revision status changed

2011-06-08 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r89283. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89283#c0 Commit summary: Register alias file from r89164 for Translatewiki ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r89432]: Revision status changed

2011-06-08 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r89432. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89432#c0 Commit summary: Optional for Translatewiki (r89372) ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r89516]: Revision status changed

2011-06-08 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r89516. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89516#c0 Commit summary: Tweaks to messages and extension credit Add extension to Translatewiki ___

[MediaWiki-CodeReview] [MediaWiki r87750]: Revision status changed

2011-06-08 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r87750. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/87750#c0 Commit summary: ArticleFeedback fixes for legacy skins * CologneBlue skin ('cologneblue'): Previously absent (no

[MediaWiki-CodeReview] [MediaWiki r89673]: Revision status changed

2011-06-08 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r89673. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/89673#c0 Commit summary: Adding 'articlefeedback-disable-preference' to preferences panel under 'Appearance / options' *

[MediaWiki-CodeReview] [MediaWiki r88588]: New comment added

2011-06-08 Thread MediaWiki Mail
User ^demon posted a comment on MediaWiki.r88588. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88588#c17883 Commit summary: $wgArticle is deprecated! Possible removal in 1.20 or 1.21! * Encapsulate index.php in wfIndexMain() (similar to r77873) * Kill $wgArticle check in

[MediaWiki-CodeReview] [MediaWiki r89277]: New comment added

2011-06-08 Thread MediaWiki Mail
User Awjrichards posted a comment on MediaWiki.r89277. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/89277#c17884 Commit summary: Added 'problem articles' view to dashboard; refactored dashboard code (populateAFStatistics.php, primarily); Added new

Re: [Wikitech-l] Extension bundling for 1.18

2011-06-08 Thread MZMcBride
Casey Brown wrote: On Wed, Jun 8, 2011 at 11:22 AM, Mark A. Hershberger mhershber...@wikimedia.org wrote: Assuming that we are going to put *some* extensions in, we need to decide which ones. [..] Have a look at http://en.wikipedia.org/wiki/Special:Version or

Re: [Wikitech-l] Extension bundling for 1.18

2011-06-08 Thread Rob Lanphier
On Wed, Jun 8, 2011 at 1:30 PM, Roan Kattouw roan.katt...@gmail.com wrote: On Wed, Jun 8, 2011 at 10:25 PM, Rob Lanphier ro...@wikimedia.org wrote: This would be 1.19 at the earliest.  1.18 is already branched, and if we're aspiring to do much more frequent releases, the last thing we should do

Re: [Wikitech-l] Extension bundling for 1.18

2011-06-08 Thread Thomas Gries
I like to have these urgently added in the tarball by default: * TitleKey * Cite Tom signature.asc Description: OpenPGP digital signature ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org

Re: [Wikitech-l] Extension bundling for 1.18

2011-06-08 Thread Roan Kattouw
On Thu, Jun 9, 2011 at 12:21 AM, Rob Lanphier ro...@wikimedia.org wrote: You're willing to say there are exactly *zero* fixes that would be needed to be done in trunk and merged into 1.18 as a result of making this change? I guess the worst that could happen is that one of the bundled

Re: [Wikitech-l] Extension bundling for 1.18

2011-06-08 Thread Chad
On Wed, Jun 8, 2011 at 6:33 PM, Roan Kattouw roan.katt...@gmail.com wrote: On Thu, Jun 9, 2011 at 12:21 AM, Rob Lanphier ro...@wikimedia.org wrote: You're willing to say there are exactly *zero* fixes that would be needed to be done in trunk and merged into 1.18 as a result of making this

Re: [Wikitech-l] Extension bundling for 1.18

2011-06-08 Thread Thomas Gries
Am 09.06.2011 00:37, schrieb Chad: Also this. I think it's a good idea, but not worth putting aside 1.17 or 1.18 work to make it happen. I also think we are _not_ in a hurry to add extensions _now_ We should - starting now - take out time to collect (on a MediaWiki page ) opinions what

Re: [Wikitech-l] Extension bundling for 1.18

2011-06-08 Thread MZMcBride
Jeroen De Dauw wrote: As some might remember, I raised the question of the Validator extension [0] could be included in the tarball earlier this year [1]. This extensions goal is facilitating features in other extensions, which makes it somewhat unique, and is I think a good reason to include

[MediaWiki-CodeReview] [MediaWiki r89747]: New comment added

2011-06-08 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r89747. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89747#c17885 Commit summary: followup r89740: remove wfMsgReplaceArgs, small fix to messages Comment: You don't need the array() either in the wfMsgForContent calls :)

[MediaWiki-CodeReview] [MediaWiki r86044]: New comment added, and revision status changed

2011-06-08 Thread MediaWiki Mail
User Bawolff changed the status of MediaWiki.r86044. Old Status: new New Status: fixme User Bawolff also posted a comment on MediaWiki.r86044. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86044#c17886 Commit summary: Follow-up r 86041 per CR and IRC: * Article constructor

Re: [Wikitech-l] Showing stub links by default - is it possible in a Wikimedia project?

2011-06-08 Thread Happy-melon
Leo Koppelkamm diebu...@gmail.com wrote in message news:banlktinsckfvpnrscska4svdgq9zgvu...@mail.gmail.com... If we proceeded to remove the feature, they could fairly easily add it into Popups or one of the other JS citadels. I don't see a way to do it in JS w/o lengthy expensive API

Re: [Wikitech-l] Extension bundling for 1.18

2011-06-08 Thread Brion Vibber
On Wed, Jun 8, 2011 at 3:21 PM, Rob Lanphier ro...@wikimedia.org wrote: On Wed, Jun 8, 2011 at 1:30 PM, Roan Kattouw roan.katt...@gmail.com wrote: This argument completely misses the point. The (probably trivial) extra work is in the tarballing process and doesn't touch anything else.

[MediaWiki-CodeReview] [MediaWiki r89252]: New comment added

2011-06-08 Thread MediaWiki Mail
User Tim Starling posted a comment on MediaWiki.r89252. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89252#c17887 Commit summary: * MFT r89250. only the tableExists function ad 1.17 already supports user-dbname difference Comment: It's easier to add a $this-addQuotes() than

[MediaWiki-CodeReview] [MediaWiki r89741]: New comment added

2011-06-08 Thread MediaWiki Mail
User Tim Starling posted a comment on MediaWiki.r89741. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89741#c17888 Commit summary: 1.17: MFT r84739, r89707 Comment: Why are you not writing release notes? ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r88946]: Revision status changed

2011-06-08 Thread MediaWiki Mail
User Tim Starling changed the status of MediaWiki.r88946. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88946#c0 Commit summary: Fix Bug #28829 - “Failure to subscribe to mediawiki-announce is not reported to the user” Wasn't able to test

[MediaWiki-CodeReview] [MediaWiki r89748]: Revision status changed

2011-06-08 Thread MediaWiki Mail
User Tim Starling changed the status of MediaWiki.r89748. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89748#c0 Commit summary: MFT r89743 ___ MediaWiki-CodeReview mailing list

[Wikitech-l] irc.wikimedia.org status

2011-06-08 Thread John
irc.wikimedia.org has been down for six hours without any information can someone please take a look and give us some information? John ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] irc.wikimedia.org status

2011-06-08 Thread MZMcBride
John wrote: irc.wikimedia.org has been down for six hours without any information can someone please take a look and give us some information? It seems up to me. According to the server admin log,[1] Mark started ircd on the host a few hours ago. MZMcBride [1]

Re: [Wikitech-l] irc.wikimedia.org status

2011-06-08 Thread Mono mium
http://status.wikimedia.org/8777/156492/IRC-RecentChanges has some pretty graphs. On Wed, Jun 8, 2011 at 5:54 PM, MZMcBride z...@mzmcbride.com wrote: John wrote: irc.wikimedia.org has been down for six hours without any information can someone please take a look and give us some information?

Re: [Wikitech-l] irc.wikimedia.org status

2011-06-08 Thread Ryan Lane
It's been fixed for three hours now. One thing to note is that the IP address for the server changed. The DNS entry's cache settings are for one hour, you should be able to access it without issues now. I just tried it and it's working for me. When was the last time you tried it? On Wed, Jun 8,

  1   2   >