Re: [Intel-gfx] gitlab.fd.o financial situation and impact on services

2020-02-29 Thread Kristian Høgsberg
On Thu, Feb 27, 2020 at 7:38 PM Dave Airlie wrote: > > On Fri, 28 Feb 2020 at 07:27, Daniel Vetter wrote: > > > > Hi all, > > > > You might have read the short take in the X.org board meeting minutes > > already, here's the long version. > > > > The good news: gitlab.fd.o has become very popular

Re: [PATCH 1/2] Introduce keyboard grabbing protocol for Xwayland

2017-04-24 Thread Kristian Høgsberg
On Fri, Apr 21, 2017 at 5:50 AM Olivier Fourdan wrote: > > Hi Jonas, > > > > [...] > > > For that last point, I'd rather use: > > > > > > * does not guarantee that events sent to this client are > continuous, > > > a compositor may change and reroute keyboard

Re: [PATCH] xwayland: Use drm buffers for cursors if available

2016-02-10 Thread Kristian Høgsberg
On Wed, Feb 10, 2016 at 7:39 AM, Emil Velikov wrote: > Hi all, > > Just a small note: > > On 5 February 2016 at 08:42, Pekka Paalanen wrote: > >> umm, do we really want to add even more uses of the Mesa-private wl_drm >> protocol outside of Mesa?

Re: [PATCH] xwayland: Group multiple cursor buffers per shm pool

2015-12-04 Thread Kristian Høgsberg
On Tue, Dec 1, 2015 at 7:48 AM, Rui Matos wrote: > Each shm pool implies a file descriptor which means that currently, we > can quickly exhaust the available FDs since we create a shm pool per > cursor buffer. Instead, this patch creates shm pools big enough to > contain

[PATCH] xwayland: Add glamor and DRI3 support

2014-06-16 Thread Kristian Høgsberg
Reviewed-by: Axel Davy axel.d...@ens.fr Signed-off-by: Kristian Høgsberg k...@bitplanet.net --- This patch comes in after the 1.16 feature freeze, but we had to wait for mesa 10.2 to come out. The mesa release brings the new gbm api that we use to implement dri3 and glamor support in Xwayland

[PULL] Xwayland fixes

2014-04-21 Thread Kristian Høgsberg
to 66b602474047c499b8a888267a489790fc9f9d85: xwayland: Remove left-over ErrorF logging (2014-04-21 11:25:12 -0700) Kristian Høgsberg (4): xwayland: Build without GLX extension xwayland: Build without xshmfence

[PATCH 3/3] configure.ac: Remove check for WAYLAND_SCANNER_RULES

2014-04-08 Thread Kristian Høgsberg
This makes configure fail if the wayland autoconf macros aren't found. We don't need the scanner for shm-only xwayland so just drop this line for now. Signed-off-by: Kristian Høgsberg k...@bitplanet.net --- configure.ac | 1 - 1 file changed, 1 deletion(-) diff --git a/configure.ac b

[PATCH 1/3] xwayland: Build without GLX extension

2014-04-08 Thread Kristian Høgsberg
Signed-off-by: Kristian Høgsberg k...@bitplanet.net --- hw/xwayland/xwayland.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/hw/xwayland/xwayland.c b/hw/xwayland/xwayland.c index c2c6481..5cecefd 100644 --- a/hw/xwayland/xwayland.c +++ b/hw/xwayland/xwayland.c

[PATCH 2/3] xwayland: Build without xshmfence

2014-04-08 Thread Kristian Høgsberg
Signed-off-by: Kristian Høgsberg k...@bitplanet.net --- hw/xwayland/xwayland.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/xwayland/xwayland.c b/hw/xwayland/xwayland.c index 5cecefd..844745a 100644 --- a/hw/xwayland/xwayland.c +++ b/hw/xwayland/xwayland.c @@ -573,8 +573,10

Re: Xwayland DDX: build breaks in configuration

2014-04-08 Thread Kristian Høgsberg
On Sun, Apr 6, 2014 at 8:05 AM, Gaetan Nadon mems...@videotron.ca wrote: On 14-04-06 06:02 AM, Yaakov (Cygwin/X) wrote: Any idea how to fix this? I would prefer that the RC I'm still trying to construct will build for most people... Adding a copy of wayland-scanner.m4 to m4/ should work.

Re: [PATCH 2/3] xwayland: Build without xshmfence

2014-04-08 Thread Kristian Høgsberg
On Tue, Apr 8, 2014 at 10:13 AM, Daniel Stone dan...@fooishbar.org wrote: Hi, On 8 April 2014 17:24, Kristian Høgsberg k...@bitplanet.net wrote: diff --git a/hw/xwayland/xwayland.c b/hw/xwayland/xwayland.c index 5cecefd..844745a 100644 --- a/hw/xwayland/xwayland.c +++ b/hw/xwayland

Re: Xwayland series v2

2014-04-03 Thread Kristian Høgsberg
On Thu, Apr 3, 2014 at 3:38 PM, Keith Packard kei...@keithp.com wrote: Kristian Høgsberg k...@bitplanet.net writes: Here's an updated version of the Xwayland series. Thanks to Kristian for getting this cleaned up today and ready for the merge. 3c34dd3..b4d0bec master - master Thanks

[PATCH 2/7] composite: Add exception mechanism for implicit redirection policy

2014-04-01 Thread Kristian Høgsberg
-by: Kristian Høgsberg k...@bitplanet.net Reviewed-by: Keith Packard kei...@keithp.com --- composite/compinit.c | 24 composite/compint.h | 7 +++ composite/compositeext.h | 4 composite/compwindow.c | 18 ++ 4 files changed, 53 insertions

[PATCH 1/7] events: Make XYToWindow a screen function pointer

2014-04-01 Thread Kristian Høgsberg
from a given toplevel window. Signed-off-by: Kristian Høgsberg k...@bitplanet.net --- dix/events.c | 99 +--- dix/touch.c | 10 -- include/cursor.h | 2 ++ include/input.h | 1 - include/scrnintstr.h | 4 +++ mi/mi.h

[PATCH 3/7] dri3: Allow asynchronous implementation for dri3_open

2014-04-01 Thread Kristian Høgsberg
the reply is moved into a helper function, which the implementation can call upon receiving its authenticaion reply. Signed-off-by: Kristian Høgsberg k...@bitplanet.net --- dri3/dri3.h | 6 +- dri3/dri3_request.c | 38 -- dri3/dri3_screen.c | 2

Xwayland series v2

2014-04-01 Thread Kristian Høgsberg
Hi, Here's an updated version of the Xwayland series. This takes into account the patches from last series that are already upstream and adds support for glamor acceleration, DRI3+present and render nodes (when available). To that end, there are a few more patches outside Xwayland in this

[PATCH 5/7] glamor: Add new GLAMOR_CREATE_PIXMAP_NO_TEXTURE pixmap create flag

2014-04-01 Thread Kristian Høgsberg
This flag lets a DDX allocate a glamor pixmap without allocating the texture that backs it. The DDX can then allocate the texture itself and then set it later. Signed-off-by: Kristian Høgsberg k...@bitplanet.net --- glamor/glamor.c | 10 +- glamor/glamor.h | 1 + 2 files changed, 10

[PATCH 4/7] glamor: Move glamor_egl_screen_init() prototype to glamor.h

2014-04-01 Thread Kristian Høgsberg
A DDX that implements the glamor EGL functions need to pull in this prototype but shouldn't need to pull in glamor_priv.h Signed-off-by: Kristian Høgsberg k...@bitplanet.net --- glamor/glamor.h | 2 ++ glamor/glamor_egl_stubs.c | 4 +++- glamor/glamor_priv.h | 3 --- 3 files

[PATCH 6/7] glamor: Expose glamor_destroy_pixmap()

2014-04-01 Thread Kristian Høgsberg
When we create a glamor pixmap by calling glamor_create_pixmap() directly, we need to call glamor_destroy_pixmap() to destroy it. Signed-off-by: Kristian Høgsberg k...@bitplanet.net --- glamor/glamor.h | 1 + glamor/glamor_priv.h | 2 -- 2 files changed, 1 insertion(+), 2 deletions(-) diff

Re: [PATCH 6/6] Xwayland DDX

2014-04-01 Thread Kristian Høgsberg
On Tue, Apr 01, 2014 at 12:10:09AM -0700, Keith Packard wrote: Kristian Høgsberg k...@bitplanet.net writes: +static WindowPtr +xwl_xy_to_window(DeviceIntPtr master, SpritePtr sprite, int x, int y) With my previous adjustment to leave the existing public XYToWindow API unchanged

[PATCH] dri3: Allow asynchronous implementation for dri3_open

2014-03-31 Thread Kristian Høgsberg
the reply is moved into a helper function, which the implementation can call upon receiving its authenticaion reply. Signed-off-by: Kristian Høgsberg k...@bitplanet.net --- dri3/dri3.h | 6 +- dri3/dri3_request.c | 38 -- dri3/dri3_screen.c | 2 +- 3

Re: [PATCH] mi: Hush extension initialization (#75870)

2014-03-27 Thread Kristian Høgsberg
printing a line for every extension, whether it's enabled or not, and b) we're not actually initializing the extension at this point. I can get behind that. Reviewed-by: Kristian Høgsberg k...@bitplanet.net Signed-off-by: Adam Jackson a...@redhat.com --- mi/miinitext.c | 8 1 file changed

Re: [PATCH libxtrans v2] configure: Also add -D_DEFAULT_SOURCE to .pc cflags to shut up glibc warnings

2014-03-25 Thread Kristian Høgsberg
-by: Kristian Høgsberg k...@bitplanet.net Reviewed-by: Kristian Høgsberg k...@bitplanet.net This makes the warnings go away for me and the patch does the right thing according to features.h: /* _BSD_SOURCE and _SVID_SOURCE are deprecated aliases for _DEFAULT_SOURCE. If _DEFAULT_SOURCE is present we do

Re: [PATCH] Handle -displayfd and an explicit display number sensibly

2014-03-25 Thread Kristian Høgsberg
On Tue, Mar 25, 2014 at 9:39 AM, Jon TURNEY jon.tur...@dronecode.org.uk wrote: On 24/03/2014 19:56, Kristian Høgsberg wrote: On Wed, Mar 19, 2014 at 7:26 AM, Jon TURNEY wrote: Handle -displayfd and an explicit display number sensibly, e.g. use the explicitly specified display number, and write

[PATCH 2/6] os: Always compile ListenOnOpenFD() and export it

2014-03-25 Thread Kristian Høgsberg
This function was written to allow the X server to inherit the listen socket from launchd on OS X. The code is not specific to OS X though and will be useful for on-demand launched Xwayland servers. Signed-off-by: Kristian Høgsberg k...@bitplanet.net Reviewed-by: Daniel Stone dan

[PATCH 4/6] os: Add AddClientOnOpenFD() to create a new client for an file descriptor

2014-03-25 Thread Kristian Høgsberg
function to set it up as an X client. Signed-off-by: Kristian Høgsberg k...@bitplanet.net Reviewed-by: Daniel Stone dan...@fooishbar.org --- include/os.h| 2 ++ os/connection.c | 27 +++ 2 files changed, 29 insertions(+) diff --git a/include/os.h b/include/os.h index

[PATCH 3/6] os: Add a mechanism to prevent creating any listen sockets

2014-03-25 Thread Kristian Høgsberg
A socket-activated server will receive its listening sockets from the parent process and should not create its own sockets. This patch introduces a NoListen flag that can be set by a DDX to prevent the server from creating the sockets. Signed-off-by: Kristian Høgsberg k...@bitplanet.net Reviewed

[PATCH 1/6] .gitignore: Add new autotools file 'test-driver'

2014-03-25 Thread Kristian Høgsberg
Automake 1.12 introduces a new parallel test framework that uses a shell script helper and generates *.log and *.trs files. Add to .gitignore. Signed-off-by: Kristian Høgsberg k...@bitplanet.net Reviewed-by: Gaetan Nadon mems...@videotron.ca --- .gitignore | 1 + test/.gitignore | 2 ++ 2

Re: [PATCH] Handle -displayfd and an explicit display number sensibly

2014-03-24 Thread Kristian Høgsberg
On Wed, Mar 19, 2014 at 7:26 AM, Jon TURNEY jon.tur...@dronecode.org.uk wrote: Handle -displayfd and an explicit display number sensibly, e.g. use the explicitly specified display number, and write it to the displayfd I don't think the two options were meant to be used together, but I can see

[PATCH 2/2] test: Don't add TEST_LDADD to list test

2014-03-19 Thread Kristian Høgsberg
The list test case is always enabled, even if Xorg is disabled. TEST_LDADD pulls in Xorg files which breaks linking when Xorg is disabled. The list test doesn't need any libraries, so just remove list_LDADD. Signed-off-by: Kristian Høgsberg k...@bitplanet.net Cc: Peter Hutterer peter.hutte...@who

[PATCH 1/2] .gitignore: Add new autotools file 'test-driver'

2014-03-19 Thread Kristian Høgsberg
Automake 1.12 introduces a new parallel test framework that uses a shell script helper and generates *.log and *.trs files. Add to .gitignore. Signed-off-by: Kristian Høgsberg k...@bitplanet.net Cc: Gaetan Nadon mems...@videotron.ca --- .gitignore | 1 + test/.gitignore | 2 ++ 2 files

[PATCH v2 2/3] os: Add a mechanism to prevent creating any listen sockets

2014-03-19 Thread Kristian Høgsberg
checking, since the parent process is responsible for checking the lock before picking the display name and creating the sockets. Signed-off-by: Kristian Høgsberg k...@bitplanet.net --- The three patches in this series were split out from one big patch and I lost the nolock detail when I split

Re: [PATCH 3/3] os: Add AddClientOnOpenFD() to create a new client for an file descriptor

2014-03-19 Thread Kristian Høgsberg
On Wed, Mar 19, 2014 at 4:29 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Tue, Mar 18, 2014 at 10:06:00PM -0700, Kristian Høgsberg wrote: When the Xwayland server is socket-activated, we need to connect and initialize the window manager before the activating client gets to proceed

[PATCH v2 3/3] os: Add AddClientOnOpenFD() to create a new client for an file descriptor

2014-03-19 Thread Kristian Høgsberg
function to set it up as an X client. Signed-off-by: Kristian Høgsberg k...@bitplanet.net --- Here's v2 of this patch, which fixes the ErrorF(stderr, ...) Peter pointed out. AddClientOnOpenFD() now returns TRUE on success and FALSE on error. It's up to the caller to log an error message and either

Re: [PULL] xkb keymap loading

2014-03-18 Thread Kristian Høgsberg
from the Wayland server and falls back to us. Let's not pull this for now. Kristian Kristian Høgsberg (3): xkb: factor out xkb loading to LoadXkm xkb: add KeymapOrDefault xkb: add XkbLoadKeymapFromString

[PATCH 1/3] os: Always compile ListenOnOpenFD() and export it

2014-03-18 Thread Kristian Høgsberg
This function was written to allow the X server to inherit the listen socket from launchd on OS X. The code is not specific to OS X though and will be useful for on-demand launched Xwayland servers. Signed-off-by: Kristian Høgsberg k...@bitplanet.net --- include/os.h| 4 +--- os

[PATCH] .gitignore: Add new autotools file 'test-driver'

2014-03-18 Thread Kristian Høgsberg
Recent automake introduces a new shell script helper for the automake test framework. Add it to .gitignore. Signed-off-by: Kristian Høgsberg k...@bitplanet.net --- Gaetan, not sure what the convention is for .gitignore. You added the Do not edit comment, but I don't see any other mechanism

Re: [PATCH v2 0/5] xwayland: Refactor bits of XKB functionality

2014-03-13 Thread Kristian Høgsberg
all the tabs with spaces...) That's fine, I think I was trying to avoid a callback, but I don't think there was a good reasons for that. This new approach looks good too, for the new patches, Reviewed-by: Kristian Høgsberg k...@bitplanet.net Cheers, Peter

xwayland: Refactor bits of XKB functionality

2014-03-07 Thread Kristian Høgsberg
Hi list, Here's few xkb related patches that refactor and expose xkb functionality. There should be no change in behavior in these patches, the idea is to expose new entry points into existing code. This is in preparation for merging xwayland, where the X server has to parse and apply xkb maps

[PATCH 5/5] xkb: Factor out a function to copy a keymap's controls unto another

2014-03-07 Thread Kristian Høgsberg
From: Rui Matos tiagoma...@gmail.com Reviewed-by: Kristian Høgsberg k...@bitplanet.net --- include/xkbsrv.h | 3 +++ xkb/xkb.c| 14 +- xkb/xkbUtils.c | 23 +++ 3 files changed, 27 insertions(+), 13 deletions(-) diff --git a/include/xkbsrv.h b/include

[PATCH 3/5] xkb: Add XkbCompileKeymapFromString()

2014-03-07 Thread Kristian Høgsberg
This new function compiles a keymap from an in-memory string. We use it to add a new keyooard device init function, InitKeyboardDeviceStructFromString(), which inits a keyboard device with a keymap specified as a string instead of a rmlvo set. Reviewed-by: Daniel Stone dan...@fooishbar.org ---

[PATCH 1/5] xkb: Add struct XkbCompContext

2014-03-07 Thread Kristian Høgsberg
This commit adds a struct that contains most of the context for starting, running and cleaning up after xkbcomp. Reviewed-by: Daniel Stone dan...@fooishbar.org --- xkb/ddxLoad.c | 76 +-- 1 file changed, 38 insertions(+), 38 deletions(-)

[PATCH 2/5] xkb: Split out code to start and finish xkbcomp

2014-03-07 Thread Kristian Høgsberg
Using the context struct from previous commit, we can now split out code to start xkbcomp and to finish and clean up after it. Reviewed-by: Daniel Stone dan...@fooishbar.org --- xkb/ddxLoad.c | 39 --- 1 file changed, 28 insertions(+), 11 deletions(-) diff

[PATCH 4/5] xkb: Repurpose XkbCopyDeviceKeymap to apply a given keymap to a device

2014-03-07 Thread Kristian Høgsberg
From: Rui Matos tiagoma...@gmail.com This will also make it useful for cases when we have a new keymap to apply to a device but don't have a source device. Reviewed-by: Kristian Høgsberg k...@bitplanet.net --- Xi/exevents.c| 2 +- include/xkbsrv.h | 4 ++-- xkb/xkb.c| 2 +- xkb

Re: [PATCH 0/3] libxtrans + xserver: Add support for systemd socket activation (v5)

2013-12-03 Thread Kristian Høgsberg
On Tue, Dec 3, 2013 at 1:48 AM, Hans de Goede hdego...@redhat.com wrote: Hi, On 12/02/2013 09:54 PM, Kristian Høgsberg wrote: On Mon, Dec 2, 2013 at 11:44 AM, Hans de Goede hdego...@redhat.com wrote: Hi All, Hi, I didn't follow all this in detail, but I'm not sure that we need

Re: [PATCH 0/3] libxtrans + xserver: Add support for systemd socket activation (v5)

2013-12-02 Thread Kristian Høgsberg
On Mon, Dec 2, 2013 at 11:44 AM, Hans de Goede hdego...@redhat.com wrote: Hi All, Hi, I didn't follow all this in detail, but I'm not sure that we need Xtrans patches at all. The server already has ListenOnOpenFD() in os/connection.c. It was added for launchd under OSX, but we use it for

Re: [PATCH 08/10] Add support for MIT-SHM AttachFd request

2013-11-01 Thread Kristian Høgsberg
On Fri, Nov 1, 2013 at 12:37 AM, Keith Packard kei...@keithp.com wrote: Kristian Høgsberg k...@bitplanet.net writes: On Thu, Oct 31, 2013 at 3:43 PM, Keith Packard kei...@keithp.com wrote: This passes a file descriptor from the client to the server, which is then mmap'd A problem we

Re: [PATCH 08/10] Add support for MIT-SHM AttachFd request

2013-10-31 Thread Kristian Høgsberg
On Thu, Oct 31, 2013 at 3:43 PM, Keith Packard kei...@keithp.com wrote: This passes a file descriptor from the client to the server, which is then mmap'd A problem we recently hit in wayland, which also affects this extension is that a client can set up shared memory like this and the truncate

[PATCH 1/4] xkb: Add struct XkbCompContext

2013-04-10 Thread Kristian Høgsberg
This commit adds a struct that contains most of the context for starting, running and cleaning up after xkbcomp. Reviewed-by: Daniel Stone dan...@fooishbar.org --- xkb/ddxLoad.c | 76 +-- 1 file changed, 38 insertions(+), 38 deletions(-)

[PATCH 2/4] xkb: Split out code to start and finish xkbcomp

2013-04-10 Thread Kristian Høgsberg
Using the context struct from previous commit, we can now split out code to start xkbcomp and to finish and clean up after it. Reviewed-by: Daniel Stone dan...@fooishbar.org --- xkb/ddxLoad.c | 39 --- 1 file changed, 28 insertions(+), 11 deletions(-) diff

[PATCH 3/4] xkb: Add XkbCompileKeymapFromString()

2013-04-10 Thread Kristian Høgsberg
This new function compiles a keymap from an in-memory string. We use it to add a new keyooard device init function, InitKeyboardDeviceStructFromString(), which inits a keyboard device with a keymap specified as a string instead of a rmlvo set. Reviewed-by: Daniel Stone dan...@fooishbar.org ---

[FYI PATCH 4/4] xwayland: Use InitKeyboardDeviceStructFromString

2013-04-10 Thread Kristian Høgsberg
We can now use this new entry point from xwayland to initialize the keyboard map to what the wayland server sends. Reviewed-by: Daniel Stone dan...@fooishbar.org --- hw/xfree86/xwayland/xwayland-input.c | 55 -- hw/xfree86/xwayland/xwayland-private.h | 5

Re: Initial DRI3000 protocol specs available

2013-03-08 Thread Kristian Høgsberg
On Fri, Mar 8, 2013 at 3:59 AM, James Jones jajo...@nvidia.com wrote: On 03/07/2013 05:17 PM, Keith Packard wrote: * PGP Signed by an unknown key James Jones jajo...@nvidia.com writes: There didn't seem to be much interest outside of NVIDIA, so besides fence sync, the ideas are tabled

Re: [PATCH] os: use libunwind to generate backtraces

2013-02-18 Thread Kristian Høgsberg
On Sat, Feb 16, 2013 at 10:45 AM, Marcin Slusarz marcin.slus...@gmail.com wrote: Libunwind generates backtraces much more reliably than glibc's backtrace. Wow, didn't know about libunwind, it looks amazing. Do you mind if port this and use in weston? Kristian Signed-off-by: Marcin Slusarz

Re: [PATCH xserver 0/2] glx/dri2: Fix bug #50019.

2012-07-12 Thread Kristian Høgsberg
On Thu, Jul 12, 2012 at 7:16 AM, Michel Dänzer mic...@daenzer.net wrote: As suggested by Kristian Høgsberg, explicitly call FreeResource for the DRI2 drawable reference. [PATCH 1/2] dri2: Add DRI2CreateDrawable2. [PATCH 2/2] glx: Free DRI2 drawable reference to destroyed GLX Thanks, Michel

Re: [PATCH] dri2proto: add prime protocol support. (v2.1)

2012-07-06 Thread Kristian Høgsberg
, that is all. Fixed up the maths to match reality. v2.1: fix typo Looks fine to me. Is there a version bump that goes along with this so drivers can know they can ask for prime devices or should they just try and expect a NULL reply if it's not available? Reviewed-by: Kristian Høgsberg k

Re: [PATCH] glx: Pass GLX drawable ID to DRI2CreateDrawable().

2012-07-06 Thread Kristian Høgsberg
On Wed, Jul 4, 2012 at 5:03 AM, Michel Dänzer mic...@daenzer.net wrote: On Fre, 2012-06-29 at 19:09 +0200, Michel Dänzer wrote: On Fre, 2012-06-29 at 12:58 -0400, Kristian Høgsberg wrote: On Fri, Jun 29, 2012 at 12:30 PM, Michel Dänzer mic...@daenzer.net wrote: On Fre, 2012-06-29 at 12:20

Re: [PATCH] dri2proto: add prime protocol support. (v2.1)

2012-07-06 Thread Kristian Høgsberg
On Fri, Jul 6, 2012 at 9:41 AM, Dave Airlie airl...@gmail.com wrote: On Fri, Jul 6, 2012 at 2:32 PM, Kristian Høgsberg k...@bitplanet.net wrote: On Fri, Jul 6, 2012 at 6:27 AM, Dave Airlie airl...@gmail.com wrote: From: Dave Airlie airl...@redhat.com So we reserve bits 16-19 for offload

Re: [PATCH] glx: Pass GLX drawable ID to DRI2CreateDrawable().

2012-06-29 Thread Kristian Høgsberg
On Fri, Jun 29, 2012 at 12:30 PM, Michel Dänzer mic...@daenzer.net wrote: [ Did you intentionally not Cc the xorg-devel list? ] No that was an accident... not sure why I have reply all as default... On Fre, 2012-06-29 at 12:20 -0400, Kristian Høgsberg wrote: On Thu, Jun 28, 2012 at 7:39 AM

Re: [PATCH] dri2: Pass a ScreenPtr through to the driver's AuthMagic function. (v3)

2012-06-20 Thread Kristian Høgsberg
in as function context. v2: Don't break ABI v3: Paint the bikeshed blue; drop fd from AuthMagic2ProcPtr prototype Looks good, Reviewed-by: Kristian Høgsberg k...@bitplanet.net Signed-off-by: Christopher James Halse Rogers christopher.halse.rog...@canonical.com ---  hw/xfree86/dri2/dri2.c |   35

Re: [PATCH] dri2: Pass a ScreenPtr through to the driver's AuthMagic function.

2012-06-19 Thread Kristian Høgsberg
On Mon, Jun 18, 2012 at 12:58 PM, Keith Packard kei...@keithp.com wrote: Christopher James Halse Rogers christopher.halse.rog...@canonical.com writes: +typedef int (*DRI2AuthMagic2ProcPtr) (ScreenPtr pScreen, int fd, uint32_t magic); Bikeshed -- seems like the 'fd' parameter is not needed

Re: [PATCH] dri2: Pass a ScreenPtr through to the driver's AuthMagic function.

2012-06-18 Thread Kristian Høgsberg
in as function context. v2: Don't break ABI Yeah, looks good to me now. Reviewed-by: Kristian Høgsberg k...@bitplanet.net Signed-off-by: Christopher James Halse Rogers christopher.halse.rog...@canonical.com ---  hw/xfree86/dri2/dri2.c |   35 ---  hw/xfree86/dri2/dri2

Re: [PATCH] dri2: Pass a ScreenPtr through to the driver's AuthMagic

2012-06-17 Thread Kristian Høgsberg
On Fri, Jun 15, 2012 at 07:01:34PM +1000, Christopher James Halse Rogers wrote: xwayland drivers need access to their screen private data to authenticate. Now that drivers no longer have direct access to the global screen arrays, this needs to be passed in as function context. The way it was

Re: [PATCH] dri2: Pass a ScreenPtr through to the driver's AuthMagic

2012-06-17 Thread Kristian Høgsberg
On Fri, Jun 15, 2012 at 12:35:00PM +0200, Michel Dänzer wrote: On Fre, 2012-06-15 at 19:01 +1000, Christopher James Halse Rogers wrote: xwayland drivers need access to their screen private data to authenticate. Now that drivers no longer have direct access to the global screen arrays,

Re: [PATCH 02/02] dri2: Add DRI2GetParam request

2012-05-14 Thread Kristian Høgsberg
Packard kei...@keithp.com CC: Kristian Høgsberg k...@bitplanet.net CC: Ian Romanick i...@freedesktop.org CC: Eric Anholt e...@anholt.net CC: Ville Syrjälä syrj...@sci.fi CC: Michel Dänzer daen...@vmware.com CC: Jesse Barnes jbar...@virtuousgeek.org CC: Chris Wilson ch...@chris-wilson.co.uk

Re: [PULL libxkbcommon] Some more fixes and minor enhancements

2012-05-09 Thread Kristian Høgsberg
Hi Ran, Let me just point you to this branch as well: http://cgit.freedesktop.org/~krh/libxkbcommon/log/?h=keysyms I've been talking with Daniel about this in IRC, but I thought you might want to take a look too. With those patches the API is completely self-contained. We still need xproto,

Re: [PATCH] dri2proto: Fix documented opcodes

2012-05-02 Thread Kristian Høgsberg
correct to me. Kristian CC: Kristian Høgsberg k...@bitplanet.net Signed-off-by: Chad Versace chad.vers...@linux.intel.com ---  dri2proto.txt |   18 +-  1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/dri2proto.txt b/dri2proto.txt index df763c7..7bde067 100644

Re: [Pull Request] Glamor: A 2D rendering acceleration implementation based on OpenGL

2011-09-29 Thread Kristian Høgsberg
2011/9/28 zhigang gong zhigang.g...@gmail.com: 2011/9/28 Michel Dänzer mic...@daenzer.net: On Die, 2011-09-27 at 21:50 +0800, zhigang gong wrote: 3. Only support Intel platform currently. As glamor depends on KMS + MESA/EGL + GBM, currently only intel gfx device get supported. A Gallium

Re: [Mesa-dev] threads and X.org/AIGLX drivers

2011-05-12 Thread Kristian Høgsberg
On Wed, May 11, 2011 at 2:53 AM, Dave Airlie airl...@gmail.com wrote: Hey, So we got a bug reported against F15 where we were getting an illegal input event type 0, after passing it around the RH X team I eventually came to look at it. The problem appears to be that we are using llvmpipe as

Re: [Mesa-dev] auto generated glx code in X server

2011-03-15 Thread Kristian Høgsberg
On Tue, Mar 15, 2011 at 12:12 AM, Keith Packard kei...@keithp.com wrote: On Tue, 15 Mar 2011 13:52:40 +1000, Dave Airlie airl...@gmail.com wrote: a) undo ajax's cleanup, fix generator scripts to work again (not sure how possible that is since Olv's mapi changes), import latest GLX into server

[PATCH] Replace malloc with calloc to initialize the buffers[] as NULL in do_get_buffers function

2011-02-10 Thread Kristian Høgsberg
From: Justin Dou justin@intel.com The calling for allocate_or_reuse_buffer may fail due to some reason, e.g. out of memory. If the buffers[] were not initialized to be NULL, the following err_out may try to access an illegal memory, which will cause X crash afterward. Reviewed-by: Kristian

Re: [PATCH 0/5] glx input sanitizing

2011-01-10 Thread Kristian Høgsberg
On Mon, Jan 10, 2011 at 6:41 AM, Julien Cristau jcris...@debian.org wrote: On Mon, Jan  3, 2011 at 21:08:05 +0100, Julien Cristau wrote: Most of this series has been sitting in bug#28823 for a while.  It adds some missing checks for client-provided data in the glx code, and fixes a bug in the

[PATCH] glx: Refcnt the GLXDrawable to avoid use after free with multiple FreeResource

2010-12-16 Thread Kristian Høgsberg
Michel Dänzer, https://bugs.freedesktop.org/show_bug.cgi?id=28181 v3: Just use the refcnt and don't try to free other resources in the DrawableGone callback. Signed-off-by: Kristian Høgsberg k...@bitplanet.net Can we just do this instead? Didn't test the patch, but this should do

Re: where is KMS API docs?

2010-12-14 Thread Kristian Høgsberg
On Tue, Dec 14, 2010 at 9:59 AM, Jeremy C. Reed r...@reedmedia.net wrote: Where is the documentation for the KMS API? Any man pages? If not written, please point me to any specifications or source used for learning the API. There is no documentation, you can browse the API here:

Re: Fence Sync patches

2010-12-08 Thread Kristian Høgsberg
On Tue, Dec 7, 2010 at 7:54 PM, James Jones jajo...@nvidia.com wrote: On Sunday 05 December 2010 20:31:24 Owen Taylor wrote: ... But I can't say that I'm at all happy the idea that we'll have two sets of drivers, one where flushing rendering enables an implicit fence for subsequent rendering

Re: [PATCH libxkbcommon 0/6] Review libxkbcommon configuration Part 2

2010-12-07 Thread Kristian Høgsberg
it. Acked-by: Daniel Stone dan...@fooishbar.org Please feel free to push these patches to the repo as well. Yup, it all looks fine. For the series: Reviewed-by: Kristian Høgsberg k...@bitplanet.net ___ xorg-devel@lists.x.org: X.Org development Archives: http

Re: [RFC XI 2.1 - inputproto] Various fixes in response to Peter Hutterer's review

2010-12-02 Thread Kristian Høgsberg
On Thu, Dec 2, 2010 at 10:46 AM, Daniel Stone dan...@fooishbar.org wrote: ... OK, so would something like this suit you:  * at selection time, clients can choose whether or not to receive    not-for-you events  * at any point during a touch stream, the current owner of a touch can    tell the

Re: [PATCH] glx: Remove swap barrier and hyperpipe support

2010-11-19 Thread Kristian Høgsberg
any implementation of these should be done with additional DRI driver API, like the swap control extension. Yeah, kill it. Signed-off-by: Kristian Høgsberg k...@bitplanet.net Signed-off-by: Adam Jackson a...@redhat.com ---  glx/Makefile.am          |    1 -  glx/g_disptab.h          |   52

Re: The future of Xephyr and Kdriver

2010-11-08 Thread Kristian Høgsberg
On Mon, Nov 8, 2010 at 11:01 AM, Jamey Sharp ja...@minilop.net wrote: On Mon, Nov 8, 2010 at 1:45 AM, Feng, Haitao haitao.f...@intel.com wrote: Have you noticed Kristian's Wayland project? In an email discussion, Kristian mentioned the Xorg on Xorg idea and discussed its design and

Re: [PATCH] DRI2: Free DRI2 drawable references in DRI2DestroyDrawable

2010-10-29 Thread Kristian Høgsberg
server has to free the reference when client requests for it. If client calls DRI2CreateDrawable twice for same drawable same reference is reused and reference count is incremented. Signed-off-by: Pauli Nieminen ext-pauli.niemi...@nokia.com CC: Kristian Høgsberg k...@bitplanet.net ---  hw

Re: [PATCH 00/15] xserver: cleanup and standardize startup options

2010-10-28 Thread Kristian Høgsberg
On Thu, Oct 28, 2010 at 10:08 AM, Alan Coopersmith alan.coopersm...@oracle.com wrote: Tiago Vignatti wrote: Hi fellows, Our culture is turning -option the default syntax for arguments to be passed to the server. This patch set tries to standardize the rest of arguments that are not on such

Re: RFC: Use libxkbcommon in Xorg

2010-10-26 Thread Kristian Høgsberg
2010/10/26 Jon TURNEY jon.tur...@dronecode.org.uk: On 22/10/2010 03:26, Kristian Høgsberg wrote: Now, it's all looking pretty promising, but there are a few open issues I'd like to throw to the list.  First of all, there's the issue of how this intersects/dovetails/conflicts with xkb2

RFC: Use libxkbcommon in Xorg

2010-10-21 Thread Kristian Høgsberg
Hello, At XDS I volunteered to make X use libxkbcommon and I've spent a few days this week trying to make that happen. libxkbcommon is a new library started by Dan Nicholson which pulls in bits and pieces from various XKB components, and primarily it provides a library interface to the xkb

Re: [PATCH] Revert Set DamageSetReportAfterOp to true for the damage extension (#30260)

2010-10-20 Thread Kristian Høgsberg
8d7b7a0d71e0b89321b3341b781bc8845386def6. Sure, we can revert it. I never saw the corner case it fixes trigger, we usually never actually fill up a protocol buffer with damage events. The only case I saw that would flush a protocol buffer was sending out xkb keymaps. Acked-by: Kristian Høgsberg k

Re: [PATCH] Revert Set DamageSetReportAfterOp to true for the damage extension (#30260)

2010-10-20 Thread Kristian Høgsberg
On Wed, Oct 20, 2010 at 7:45 PM, Keith Packard kei...@keithp.com wrote: On Sun, 17 Oct 2010 09:58:50 -0700, Aaron Plattner aplatt...@nvidia.com wrote: In addition to the above, this commit also broke the Compiz Wallpaper plugin. Ok, as usual, Dave Airlie is right here -- independent of

Re: [PATCH v2] glx: Fix use after free in DrawableGone

2010-09-27 Thread Kristian Høgsberg
2010/9/23 Kristian Høgsberg k...@bitplanet.net: 2010/9/23 Jeremy Huddleston jerem...@apple.com: That seems off to me.  This is doing more than changing the c-next dereference.  You're now freeing it where you weren't before. Previously, you freed it inside: if (c-isCurrent (c-drawPriv

[PATCH] glx: Fix use after free in DrawableGone

2010-09-23 Thread Kristian Høgsberg
Signed-off-by: Kristian Høgsberg k...@bitplanet.net --- ==2989== Invalid write of size 4 ==2989==at 0x48CE6E5: DrawableGone (glxext.c:169) ==2989==by 0x809F401: FreeResource (resource.c:601) ==2989==by 0x80845CE: ProcDestroyWindow (dispatch.c:733) ==2989==by 0x8087D76

Re: [PATCH v2] glx: Fix use after free in DrawableGone

2010-09-23 Thread Kristian Høgsberg
not be the right thing to do, but in the scope of this patch, we're just delaying the destroy until we're done touching the context. Kristian On Sep 23, 2010, at 06:04, Kristian Høgsberg wrote: Signed-off-by: Kristian Høgsberg k...@bitplanet.net --- Chris Wilson points out that we were still

Re: [PATCH xserver] config: remove --with-dri-driver-path option, use dri.pc #29740

2010-08-24 Thread Kristian Høgsberg
2010/8/24 Gaetan Nadon mems...@videotron.ca: On Tue, 2010-08-24 at 12:56 +0200, Michel Dänzer wrote: Could just use dri.pc for the default value of the option, rather than removing it altogether? Yes. I think the author of the bug report wishes to also remove the option as it is no longer

[PULL] Flush fixes

2010-08-06 Thread Kristian Høgsberg
The following changes since commit 7e0575baf14ec4a89492fd2780f9ab5b9244afbd: ddc: Fix memory leak in GetEDID_DDC1 (2010-08-01 22:48:21 -0400) are available in the git repository at: git://anongit.freedesktop.org/~krh/xserver flush-callback Kristian Høgsberg (2): Always call the flush

Re: [Intel-gfx] xf86-video-intel: configure.ac

2010-07-28 Thread Kristian Høgsberg
On Wed, Jul 28, 2010 at 4:42 AM, Chris Wilson ch...@chris-wilson.co.uk wrote: On Tue, 27 Jul 2010 09:34:01 -0700, Jesse Barnes jbar...@virtuousgeek.org wrote: and glproto is missing a dep on GL: arjan In file included from i810.h:60:0, arjan                  from i810_accel.c:41: arjan

Re: [PATCH 14/15] xkb: Use memcpy for copy

2010-07-28 Thread Kristian Høgsberg
On Wed, Jul 28, 2010 at 7:26 AM, Daniel Stone dan...@fooishbar.org wrote: On Wed, Jul 28, 2010 at 02:11:05PM +0300, Pauli Nieminen wrote: On Tue, Jul 27, 2010 at 03:09:55PM +0300, Pauli Nieminen wrote: Source and destination have well defined size so use memcpy instead of strncpy.

Re: [PATCH] DRI2: use ConfigNotify to re-allocate buffers if root window changes

2010-07-08 Thread Kristian Høgsberg
On Thu, Jul 8, 2010 at 3:30 PM, Jesse Barnes jbar...@virtuousgeek.org wrote: On Thu, 08 Jul 2010 12:26:22 -0700 Keith Packard kei...@keithp.com wrote: On Thu, 8 Jul 2010 11:39:01 -0700, Jesse Barnes jbar...@virtuousgeek.org wrote: If the root window changes size, we need to re-allocate

Re: [PATCH 1/2] list.h: Fix list_for_each_entry_safe()

2010-06-20 Thread Kristian Høgsberg
On Fri, Jun 18, 2010 at 5:43 PM, Dan Nicholson dbn.li...@gmail.com wrote: On Fri, Jun 18, 2010 at 2:34 PM, Keith Packard kei...@keithp.com wrote: On Mon, 14 Jun 2010 09:25:22 -0400, Kristian Høgsberg k...@bitplanet.net wrote: -      pos = next, next = __container_of(next-member.next, next

[PATCH 1/2] list.h: Fix list_for_each_entry_safe()

2010-06-14 Thread Kristian Høgsberg
Can't use next as a macro argument since we're accessing the .next field of struct list. --- include/list.h |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/include/list.h b/include/list.h index 89dc29d..4ce20a8 100644 --- a/include/list.h +++ b/include/list.h @@

[PATCH 2/2] xfixes: Use list.h macros in tracking hide count

2010-06-14 Thread Kristian Høgsberg
--- This is not a patch to be applied. Recently, the utility of list.h was questioned and as I came a across the cursor hide count code today I figured it would make a good example of how list.h can make the code significantly simpler. In particular, it's easy to prepend and iterate though a

Re: [PATCH 1/2] list.h: Fix list_for_each_entry_safe()

2010-06-14 Thread Kristian Høgsberg
On Mon, Jun 14, 2010 at 10:52 AM, Tiago Vignatti tiago.vigna...@nokia.com wrote: On Mon, Jun 14, 2010 at 03:25:22PM +0200, ext Kristian H�gsberg wrote: Can't use next as a macro argument since we're accessing the .next field of struct list. ---  include/list.h |    6 +++---  1 files changed,

Re: [PATCH 2/2] xfixes: Use list.h macros in tracking hide count

2010-06-14 Thread Kristian Høgsberg
On Mon, Jun 14, 2010 at 10:56 AM, Tiago Vignatti tiago.vigna...@nokia.com wrote: On Mon, Jun 14, 2010 at 03:25:23PM +0200, ext Kristian H�gsberg wrote: This is not a patch to be applied. why not?! :) Oh, I mentioned this in my first attempt to send out these patches (which git send-mail

Re: [PATCH 2/2] xfixes: Use list.h macros in tracking hide count

2010-06-14 Thread Kristian Høgsberg
2010/6/14 Vignatti Tiago (Nokia-D/Helsinki) tiago.vigna...@nokia.com: On Mon, Jun 14, 2010 at 05:24:16PM +0200, ext Kristian Høgsberg wrote:  I don't think it makes sense to go through the server and replace existing linked list code.  That code is already written and tested, and replacing

Re: performance of pci_device_get_{vendor, device}_name() in X server startup

2010-06-09 Thread Kristian Høgsberg
On Wed, Jun 9, 2010 at 7:23 AM, Daniel Stone dan...@fooishbar.org wrote: On Tue, Jun 08, 2010 at 09:40:55PM -0400, Matt Turner wrote: On Tue, Jun 8, 2010 at 9:35 PM, Richard Barnette jrbarne...@chromium.org wrote: Still, cost/benefit matters here:  Essentially, the justification for all

  1   2   >