Matthew:
I find two issues at your update.
1. SUPPORT_MOBILE is not defined so the fast-resume related command can not be 
compliled.
2. The symbol_version and symbol_release can not be gotten from function 
grub_kernel_version() in stage2/builtins.c, So fast-resume can not work. I used 
the moblin kernel vmlinuZ-2.6.24-4-menlow-default

I can accept your thoughts to use sysem.map instead of fast-resume-symbol. 
However I think we should implement it through below way:
1. get the version and release number from image snap-shot. See reswsusp_info() 
at stage2/builtins.c
2. use the version and release number to decide which system.map file will be 
used
3. open the right system.map to get all the symbols address

So using above method we can only use below commands to implement fast-resume
Resume_symbol (hd0,0) tell grub the location of the system.map file
Resume_partition (hd0,2)
Resume
We need not to designate kernel and system map, and multi-kernel can be 
supported well. 

-----Original Message-----
From: Matthew Garrett [mailto:[EMAIL PROTECTED] 
Sent: 2008年3月3日 19:06
To: Xu, Martin
Cc: [email protected]; [EMAIL PROTECTED]
Subject: Re: Grub fast resume

On Mon, Mar 03, 2008 at 07:03:18PM +0800, Xu, Martin wrote:
> Garrett:
> I like the optimization, and in fact it is my original design.
> The reason I abandon the design later is that make fast-resume depends on 
> system.map file. If the file does not exist, or be damaged, fast-resume can 
> not work. 

The alternative is for it to depend on the symbols file, which could 
also be lost or damaged. Since the symbols file is generated from the 
system.map file, I don't think this is an issue.

> I have tried it at my machine and find that it can not work; I will look into 
> it clearly tomorrow.

Ok - if you could let me know how it fails, that would be great.

Thanks,
-- 
Matthew Garrett | [EMAIL PROTECTED]

-- 
Ubuntu-mobile mailing list
[email protected]
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/ubuntu-mobile

Reply via email to