On Tue, Mar 04, 2008 at 01:40:42PM +0800, Xu, Martin wrote:
> Matthew:
> I find two issues at your update.
> 1. SUPPORT_MOBILE is not defined so the fast-resume related command can not 
> be compliled.

It'll only be defined for lpia builds by default. Pass --enable-mobile 
to configure to define it for other builds.

> 2. The symbol_version and symbol_release can not be gotten from function 
> grub_kernel_version() in stage2/builtins.c, So fast-resume can not work. I 
> used the moblin kernel vmlinuZ-2.6.24-4-menlow-default

Hm. Can you work out why this doesn't work? The header format for the 
kernel is supposed to be fixed.

> I can accept your thoughts to use sysem.map instead of fast-resume-symbol. 
> However I think we should implement it through below way:
> 1. get the version and release number from image snap-shot. See 
> reswsusp_info() at stage2/builtins.c
> 2. use the version and release number to decide which system.map file will be 
> used
> 3. open the right system.map to get all the symbols address

That's not entirely ideal, since it assumes a consistent on-disk naming 
format. That works fine for us, but wouldn't work so well in the general 
case. It'd be nice not to make these assumptions, especially since the 
version numbers are contained within the kernel header.

-- 
Matthew Garrett | [EMAIL PROTECTED]

-- 
Ubuntu-mobile mailing list
[email protected]
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/ubuntu-mobile

Reply via email to