On Sat, Mar 8, 2014 at 7:05 PM, Tyler Romeo <tylerro...@gmail.com> wrote:
> On Sat, Mar 8, 2014 at 9:48 PM, Ryan Lane <rlan...@gmail.com> wrote: > > > Wikimedia uses deployment branches. Just because someone +2/merges into > > master doesn't mean it immediately shows up on Wikimedia servers. It > needs > > to go into a deployment branch, then it needs to get deployed by a > person. > > Also, we use a gating model, so tests are required to pass before > something > > is merged. I believe there are some tests that are essential, but take > too > > long to run, so they aren't gating, but the situation isn't as dire as > you > > claim. > > > > OK, then how did this change get deployed if it "broke" tests? > > The jenkins report says it passed tests, hence why it was deployed. If there's other tests that aren't reporting to gerrit or if there's a test that needs to be added, maybe that's a post-mortem action to track? - Ryan _______________________________________________ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
