On Mon 31.Aug'09 at 21:28:31 +0200, Martin Dietze wrote:
>
> Nice feature.
Yeah, I liked the concept and the name :-)
So that is why I was motivated to code it :-)
There are still more things to do. The most pressing one
for me is the fact that it covers the dock and the fact
that I was sloppy with the titlebar, resizebar and frame
width ("perfect is the enemy of good", so yesterday
I wanted something "only good" to have a starting point).
The dock issue I guess can be solved by using the usableArea
thing, but I haven't looked yet.
> Still one problem: you do a tiled maximise. The
> window takes the workspace's full height but not width. Now you
> do something which increases the height (e.g. if you use a
> gnome-terminal, press Ctrl-Shift-T to add a second tab, the
> height consumed by the tabs at the top will be added to the
> window's overall height).
Hm, I think the Maximus algorithm does not currently treats the
case where the "initial" position is out of the screen (I haven't
thought about it last night).
> Now I press the shortcut for vertical
> maximisation expecting the window to be resized to fit the
> workspace's height again. But instead the window is now
> maximised to the full workspace thus covering other windows,
> i.e. the tiled maximisation's effect is gone.
But this behavior I think is related to the shrink_v, shrink_h
etc logic in the beginning of wMaximizeWindow(), which I
think tries to remember what's been done already.
I will not have much time during this week to think about it,
unfortunately :-(
But I will gladly accept patches if someone fixes/improves
something :-)
PS: I felt unconfortable that I could traverse the windows list
using only tmp->prev, and I don't understand yet why the tmp-next
code I had yesterday was never used during my tests (so I removed
it from the patch). Does anyone knows if the focused window is
always the last one in the window list?
--
To unsubscribe, send mail to [email protected].
