On 8/8/01 7:35 PM, "Sam Ruby" <[EMAIL PROTECTED]> wrote:
>
>> Can we normalize the project descriptors? I would like to use the project
>> descriptors you have started for JJAR instead of rolling another project
>> descriptor but I really don't like the pattern
>
> Let me give the background for why the descriptors are the way the are at
> the moment, then I'll ask you for a concrete proposal.
>
> It is a philosophical thing. In essence, I don't believe in introducing
> complexity in 100% of the usages to address a need that exists in perhaps
> 20% of the definitions. For example, take a look at *EVERY*
> jakarta-turbine-* definition. There is a single project, and no nested
> subprojects. I'd prefer to keep it that way.
I always think in objects and the layout just strikes me as wrong. I don't
really consider the addition of <project></project> a complexity issue. To
someone looking at the a project descriptor for the first time will not know
what is what.
I would see the mapping as a project with a collection of targets, even if
there is only one target in the collection. Not a project that contains a
project, and might possibly contain a collection of subprojects. I
personally feel that what you currently have is harder to understand and
more complex because you have exceptional logic for unrolling the nested
subprojects. Simple difference of opinion.
> From a practical point of view, I also don't see it as a problem. I have a
> small, 100% pure Java program which unrolls these definitions. It doesn't
> even involve any icky, smelly, XSLT. ;-)
That's fine, but what about others trying to use the project descriptors
with other tools? Like I am trying to do with the digester, I can't use
simple rules without applying some exceptional logic to capture nested
subprojects. I'm not even sure it can work, but I will try. I think anyone
looking at the project descriptor would agree that it doesn't map cleanly to
an object.
> OK, now I've said my piece. What I would like to solicit from you is
> suggestions on how you think the following two lines should change:
>
> <project href="project/jakarta-ant.xml">
> <project name="jakarta-ant">
These are in the profile descriptors, I'm not sure what you are trying to
elicit but at the moment I don't see why the href=X isn't sufficient.
> If after reading the above, you give a concrete suggestion, I'll go ahead
> and make the change across the board. My only request is that the proposal
> does not require any of the jakarta-turbine-*.xml files to change.
I don't have a proposal that doesn't involve changing the project
descriptors, I don't feel they are correct in their current form, you feel
they are fine. C'est la vie :-) If I can get the digester to work on the
descriptors in their current form I will use what you have, if it doesn't I
will use something else.
> - Sam Ruby
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
--
jvz.
Jason van Zyl
http://tambora.zenplex.org
http://jakarta.apache.org/turbine
http://jakarta.apache.org/velocity
http://jakarta.apache.org/alexandria
http://jakarta.apache.org/commons
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
