To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=76653
User sb changed the following:
What |Old value |New value
================================================================================
CC|'' |'sb'
--------------------------------------------------------------------------------
------- Additional comments from [EMAIL PROTECTED] Wed May 2 09:32:45 +0000
2007 -------
@cmc: I am not sure I understand your changes. Take, for example, the two
changes in basic/source/classes/sb.cxx:1.30.24.1:
- Why wrap SFX_VB_ErrorTab in rtl::Static? It should be r/o static data (in
.text or .rodata, w/o any initialization necessary). A "static" is lacking from
the definition, maybe that causes bad effects with some compilers?
- Why wrap xAddInfo and xItemInfo in rtl::Static? A default constructed
SbxInfoRef (which is a tools/ref.hxx SV_DECL_REF) should consists of zeroed
memory (in .data or .dss, w/o any initialization necessary). Maybe the
definitions should be rewritten
- SbxInfoRef BasicCollection::xAddInfo = NULL;
- SbxInfoRef BasicCollection::xItemInfo = NULL;
+ SbxInfoRef BasicCollection::xAddInfo;
+ SbxInfoRef BasicCollection::xItemInfo;
to improve code emitted by compilers.
---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
