On Sun, 2003-03-02 at 21:24, Thomas Charbonnel wrote: > On Thu, 2003-02-27 at 19:43, Paul Davis wrote: > > i haven't had time today to get the patch for the hdsp ready. however, > > the new source works here (i have some CVS sync issues). i'll get it > > out to the list on monday (i'm gone for the weekend). > > > Did you sort out the rms register issue ? I'm currently implementing the > metering part of HDSPMixer and the rms values returned are obviously > bogus. > > Thomas
Ok, I sorted it out myself, the offsets for the rms and peak registers were wrong. Sorry Paul, I could have seen this much earlier if I had done more extensive tests: I kept on testing inputs 1 and 2 while the input rms offset pointed on input 3... :-\ The correct offsets can be found in the attached patch. Thomas
--- hdsp.c.orig 2003-03-03 00:30:46.000000000 +0100 +++ hdsp.c 2003-03-03 00:32:10.000000000 +0100 @@ -123,9 +123,9 @@ #define HDSP_playbackPeakLevel 4096 /* 26 * 32 bit values */ #define HDSP_inputPeakLevel 4224 /* 26 * 32 bit values */ -#define HDSP_outputPeakLevel 4100 /* 26 * 32 bit values */ +#define HDSP_outputPeakLevel 4096 /* 26 * 32 bit values */ #define HDSP_playbackRmsLevel 4612 /* 26 * 64 bit values */ -#define HDSP_inputRmsLevel 4884 /* 26 * 64 bit values */ +#define HDSP_inputRmsLevel 4868 /* 26 * 64 bit values */ #define HDSP_IO_EXTENT 5192