On Mon, Sep 7, 2026 at 4:40 PM Timur Kristóf <[email protected]> wrote: > > This series applies on top of my previous series: > "Improve existing SDMA queue resets" (currently under review) > > Prepare the code for implementing recovery for > SDMA v4 and all older SDMA (and SI DMA) versions. > Reorganize the SDMA 4.0 code so that the functions that are > responsible for managing the SDMA engines take an instance ID > as an argument. > > This makes it possible to manage the SDMA instances > independently of each other, which will enable us to > also use these functions to implement resetting and > recovering them independently. (The actual recovery > implementation will be in a follow-up patch series > which I will submit after this one is accepted.)
This series looks fine to me, although I think I would prefer to apply it along with the relevant soft reset changes to avoid churning the code until each family is ready. E.g., apply the cik_sdma refactor along with the CIK soft reset support, etc. Unless you have something else in mind. Series in general is: Reviewed-by: Alex Deucher <[email protected]> Alex > > Timur Kristóf (12): > drm/amdgpu/sdma: Refactor SI DMA functions to be per instance > drm/amdgpu/sdma: Refactor SI DMA clock gating functions to be > per-instance > drm/amdgpu/sdma: Refactor CIK SDMA functions to be per instance > drm/amdgpu/sdma: Refactor CIK SDMA clock gating functions to be > per-instance > drm/amdgpu/sdma: Refactor SDMA v2.4 functions to be per instance > drm/amdgpu/sdma: Refactor SDMA v2.4 golden registers to be > per-instance > drm/amdgpu/sdma: Refactor SDMA v3.0 functions to be per instance > drm/amdgpu/sdma: Refactor SDMA v3.0 clock gating functions to be > per-instance > drm/amdgpu/sdma: Refactor SDMA v3.0 golden registers to be > per-instance > drm/amdgpu/sdma: Refactor SDMA v4.0 functions to be per instance > drm/amdgpu/sdma: Refactor SDMA v4.0 clock gating functions to be > per-instance > drm/amdgpu/sdma: Refactor SDMA v4.0 golden registers to be > per-instance > > drivers/gpu/drm/amd/amdgpu/cik_sdma.c | 322 +++++++------- > drivers/gpu/drm/amd/amdgpu/sdma_v2_4.c | 232 +++++----- > drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c | 561 ++++++++++++++---------- > drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 577 +++++++++++++++---------- > drivers/gpu/drm/amd/amdgpu/si_dma.c | 160 ++++--- > 5 files changed, 1043 insertions(+), 809 deletions(-) > > -- > 2.55.0 >
