Hum.... chuuut ! I just fixed it ! I hope noone else saw the bug :p Phil Youness Alaoui a écrit : > ok, so you're the one to blame? :p > because, as I said, I just tested (with latest SVN) to drop a contact in no > group, and we get the bug report.. I > guess something undid your fix... > > KKRT > > On Fri, Jun 01, 2007 at 04:58:40PM +0200, Philippe Valembois - Phil wrote: >> If I remember well, I coded it like that : No group is considered as a >> virtual group like online/mobile/offline and dropping to it was recently >> fixed by disallowing it... >> Phil >> PS As I am the one who coded this part of code (based on the work done >> by Karel/Burger), I can reply easily to questions about this code (and >> to blames too :( ) ;) >> >> Youness Alaoui a écrit : >>> Indeed. Just so you know (in case you didn't realize it, but I think you >>> did). The 'no group' is a virtual group >>> (just like online/offline/mobile groups). It isn't listed as a group when >>> we fetch the contact list. In WLM, the >>> 'no group' doesn't appear, instead you have users on the top of the CL >>> without appearing inside a group (this >>> means you can't "collapse" the users who aren't in a group). The only way >>> to put a user in 'no group' is to >>> remove it from all groups. To delete a user, we remove it from all groups, >>> it becomes part of 'no group' then we >>> have to remove it from the 'no group' virtual group for the user to be >>> deleted from our CL. >>> Humm.. I just tried in WLM and it seems they changed it a bit, now users in >>> 'no group' aren't appearing in the >>> root of the CL, they actually appear in a "Other contacts" group under all >>> other groups (instead of being on >>> the top like before). If you have the option 'group contacts offline' (our >>> hybrid mode), then the 'other >>> contacts' group is under the 'offline' group. In WLM, there is no such >>> thing as 'move contact to 'other >>> contacts' group, and there is no such thing as 'remove from all groups', >>> but there is the contextual menu : >>> group options -> copy contact to -> group1 >>> group1 >>> etc.. >>> move contact to -> group1 >>> group2 >>> etc.. >>> remove contact from group >>> The 'group options' don't appear if you sort by status. >>> The 'remove contact from group' removes the user from the current group (in >>> which you right clicked the >>> contact). >>> The 'remove contact from group' doesn't appear if the user is in 'other >>> contacts'. >>> If you have a user in multiple groups you have to "remove contact from >>> group" from all the groups in order for >>> it to go to 'other contacts'. >>> As much as you can't drop a user to the 'offline' group, you also can't >>> drop a user to the 'other contacts' (so >>> you can't drag/drop a contact to 'no group' which would remove him from all >>> other groups). >>> >>> That being said, I don't know what the solution with amsn should be. Right >>> now, if we drop a user to 'no group', >>> we get a bug report (because we send the ADC moving the contact to group >>> '0' (which is no group) and the server >>> responds with a 403 error, which we don't check (we do a [lindex $response >>> X] to get the group id to which the >>> user got moved to, and then we check the variable list_$group or something, >>> so if $group is empty, we get an >>> error because $list_ doesn't exist. we should check if [lindex $response 0] >>> is ADC or an error message to make >>> sure we don't 'handle' the ADC in the wrong way. >>> >>> I think dropping should be disabled for no group (as well as mobile and >>> offline) and maybe just allow the >>> 'delete from group' instead of only 'delete'. But I don't see why a user >>> would want to put a contact in no >>> group, if he wants, he can create a group named "other contacts" or "no >>> group" or whatever, and move the contact >>> there. the 'no group' should be used ONLY when adding a new user, then once >>> you move it to a proper group, it >>> should stay in a 'valid' group. That's the purpose of 'no group' in my >>> opinion. I might be wrong though. >>> >>> So.. solution would be to disable drag/drop to no group, and leave the >>> behavior as it is, if we want to allow >>> users to move to no group, then the 'delete from group' method used by WLM >>> would be the way to go. >>> What do you think ? >>> >>> p.s. : sorry for the YAHEFY (yet another huge email from Youness :p). >>> >>> kaKaRoTo >>> >>> >>> >>> On Fri, Jun 01, 2007 at 01:31:36PM +0200, Harry Vennik wrote: >>>> I think the second way is the best. However, when a contact is >>>> dragged to No Group, and actually the contact is in multiple groups, >>>> then the user should be warned that moving a contact to No Group will >>>> remove it from any group it was in, and not just the group it was >>>> dragged from. >>>> >>>> Harry >>>> >>>> Op 1-jun-2007, om 13:19 heeft Mirko Hansen het volgende geschreven: >>>> >>>>> Hi guys, >>>>> >>>>> I tried to fix the bug reported on http://www.amsn-project.net/ >>>>> forums/viewtopic.php?t=3418 and there I noticed that the group >>>>> handling is some kind of incomplete relating especially to the "no >>>>> group". To the user this group appears a normal group, although it >>>>> isn't, but the user doesn't even know. So I think the user should >>>>> be able to handle with this special group almost the same as with a >>>>> normal group. Drag & drop to this group is/was buggy (did it ever >>>>> work?), but I think it should work. WLM doesn't allow this, there >>>>> it's only possible to remove a contact from all groups by using the >>>>> right-click menu. So we have two possibilities: 1. behave the same >>>>> way as WLM, not allowing to drop the contact on "no group" or 2. we >>>>> allow it and remove the contact from all other groups if it is >>>>> dropped on the "no group". I think the easiest and for n00bs most >>>>> logical way is 2, even if it might be a little bit strange that >>>>> copies of the contact in other groups will be removed, too, if you >>>>> drop the contact in the "no group". And as a logical consequence I >>>>> would add the possibility to move a contact to "no group" from the >>>>> context menu. What do you think? >>>>> The other way, if you think the way WLM handles this, is better, we >>>>> should add something like the "remove contact from all groups" to >>>>> the right-click menu, otherwise the user has no easy way to move a >>>>> contact from a group to the "no group". >>>>> >>>>> Bye, >>>>> Mirko >>>>> ---------------------------------------------------------------------- >>>>> --- >>>>> This SF.net email is sponsored by DB2 Express >>>>> Download DB2 Express C - the FREE version of DB2 express and take >>>>> control of your XML. No limits. Just data. Click to get it now. >>>>> http://sourceforge.net/powerbar/db2/ >>>>> _______________________________________________ >>>>> Amsn-devel mailing list >>>>> Amsn-devel@lists.sourceforge.net >>>>> https://lists.sourceforge.net/lists/listinfo/amsn-devel >>>> ------------------------------------------------------------------------- >>>> This SF.net email is sponsored by DB2 Express >>>> Download DB2 Express C - the FREE version of DB2 express and take >>>> control of your XML. No limits. Just data. Click to get it now. >>>> http://sourceforge.net/powerbar/db2/ >>>> _______________________________________________ >>>> Amsn-devel mailing list >>>> Amsn-devel@lists.sourceforge.net >>>> https://lists.sourceforge.net/lists/listinfo/amsn-devel >>> >>> ------------------------------------------------------------------------- >>> This SF.net email is sponsored by DB2 Express >>> Download DB2 Express C - the FREE version of DB2 express and take >>> control of your XML. No limits. Just data. Click to get it now. >>> http://sourceforge.net/powerbar/db2/ >>> _______________________________________________ >>> Amsn-devel mailing list >>> Amsn-devel@lists.sourceforge.net >>> https://lists.sourceforge.net/lists/listinfo/amsn-devel >>> >> >> ------------------------------------------------------------------------- >> This SF.net email is sponsored by DB2 Express >> Download DB2 Express C - the FREE version of DB2 express and take >> control of your XML. No limits. Just data. Click to get it now. >> http://sourceforge.net/powerbar/db2/ >> _______________________________________________ >> Amsn-devel mailing list >> Amsn-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/amsn-devel > > ------------------------------------------------------------------------- > This SF.net email is sponsored by DB2 Express > Download DB2 Express C - the FREE version of DB2 express and take > control of your XML. No limits. Just data. Click to get it now. > http://sourceforge.net/powerbar/db2/ > _______________________________________________ > Amsn-devel mailing list > Amsn-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/amsn-devel >
------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ _______________________________________________ Amsn-devel mailing list Amsn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/amsn-devel
